Remove all_paths_failed from PaymentPathFailed
authorValentine Wallace <vwallace@protonmail.com>
Sun, 12 Feb 2023 00:38:48 +0000 (19:38 -0500)
committerValentine Wallace <vwallace@protonmail.com>
Fri, 24 Feb 2023 19:21:08 +0000 (14:21 -0500)
commit2037a241f4aa5ff976bfd556bc61c12b73890b3e
tree55941630f8201f2acd493b6352e345d948727df2
parentf361aa62a42551be0de722ba4c886c1ebdcb13cd
Remove all_paths_failed from PaymentPathFailed

This field was previous useful in manual retries for users to know when all
paths of a payment have failed and it is safe to retry. Now that we support
automatic retries in ChannelManager and no longer support manual retries, the
field is no longer useful.

For backwards compat, we now always write false for this field. If we didn't do
this, previous versions would default this field's value to true, which can be
problematic because some clients have relied on the field to indicate when a
full payment retry is safe.
lightning-background-processor/src/lib.rs
lightning/src/ln/functional_test_utils.rs
lightning/src/ln/functional_tests.rs
lightning/src/ln/onion_route_tests.rs
lightning/src/ln/outbound_payment.rs
lightning/src/ln/payment_tests.rs
lightning/src/util/events.rs
pending_changelog/2043.txt [new file with mode: 0644]