Remove genesis block hash from public API
authorMatt Corallo <git@bluematt.me>
Thu, 9 Feb 2023 19:20:22 +0000 (19:20 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 24 Feb 2023 00:22:58 +0000 (00:22 +0000)
commit2c3e12e30925b007b7eec235b29236171ad2ed0e
treee9de4bd9eb73ea28c6219ca66c010a335647283b
parent96c8507fbf55b3ecc2009d2da5966ae9e391b310
Remove genesis block hash from public API

Forcing users to pass a genesis block hash has ended up being
error-prone largely due to byte-swapping questions for bindings
users. Further, our API is currently inconsistent - in
`ChannelManager` we take a `Bitcoin::Network` but in `NetworkGraph`
we take the genesis block hash.

Luckily `NetworkGraph` is the only remaining place where we require
users pass the genesis block hash, so swapping it for a `Network`
is a simple change.
15 files changed:
fuzz/src/full_stack.rs
fuzz/src/process_network_graph.rs
fuzz/src/router.rs
lightning-background-processor/src/lib.rs
lightning-rapid-gossip-sync/src/lib.rs
lightning-rapid-gossip-sync/src/processing.rs
lightning/src/ln/channelmanager.rs
lightning/src/ln/functional_test_utils.rs
lightning/src/ln/functional_tests.rs
lightning/src/ln/outbound_payment.rs
lightning/src/routing/gossip.rs
lightning/src/routing/router.rs
lightning/src/routing/scoring.rs
lightning/src/routing/test_utils.rs
lightning/src/routing/utxo.rs