Correct input comparison for input-subset RBF bump creation
authorMatt Corallo <git@bluematt.me>
Tue, 10 Dec 2019 03:14:47 +0000 (22:14 -0500)
committerAntoine Riard <ariard@student.42.fr>
Tue, 10 Dec 2019 22:42:40 +0000 (17:42 -0500)
commit2c8bc3c64e5e00b5401a3ae11083c55d6f24ebb4
tree0645e04b2b10c0103d2cf2138bffe82f2f701bb3
parent7be903ba006d45d95298d991f687affdee2c978f
Correct input comparison for input-subset RBF bump creation

This resolves a regression introduced in "Implement bumping engine in
ChannelMonitor::block_connected" in which not all inputs are checked.
Several opportunities to clarify and clean up comments are also taken.

Fix test_bump_penalty_txn_on_revoked_htlcs as now remote claim txn
build the same way than us are going to be register as cleaning
pending_claim_request after ANTI_REORG_DELAY. It means during this
delay we are going to generate invalid bumped claiming txn on
already claimed outpoints. Previously these txn weren't issued
because all their outpoints would have been removed.

Fix full_stack_target by adding more input for FuzzEstimator
fuzz/fuzz_targets/full_stack_target.rs
lightning/src/ln/channelmonitor.rs
lightning/src/ln/functional_tests.rs