projects / rust-lightning / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1a24dcc) | patch
Correct handling of `UnknownRequiredFeature` deserialization 2022-01-correct-req-feature-handling
authorMatt Corallo <git@bluematt.me>
Wed, 26 Jan 2022 02:04:20 +0000 (02:04 +0000)
committerMatt Corallo <git@bluematt.me>
Wed, 26 Jan 2022 02:12:35 +0000 (02:12 +0000)
commit94639137c362ecc41d8ca33374f4c84d87839766
tree81f47f4892d9ea488892724578033f02e6aec0cftree | snapshot
parent1a24dcc3e91240e5b1d1df24bfde063e84da1472commit | diff
Correct handling of `UnknownRequiredFeature` deserialization

Quite some time ago, `UnknownRequiredFeature` was only used when a
gossip message has a missing required feature. These days, its also
used for any required TLV which we do not understand in any
message. However, the handling of it was never updated in
`PeerManager`, leaving it printing a warning about gossip and
ignoring the message entirely.

Instead, we send a warning message and disconnect.

Closes #1236, as caught by @jkczyz.
lightning/src/ln/peer_handler.rs diff | blob | history
Personal fork of Rust-Lightning. Upstream is https://github.com/rust-bitcoin/rust-lightning