Fix off-by-one finalized transaction locktime
authorWilmer Paulino <wilmer@wilmerpaulino.com>
Sat, 15 Apr 2023 00:03:51 +0000 (17:03 -0700)
committerWilmer Paulino <wilmer@wilmerpaulino.com>
Sat, 22 Apr 2023 18:16:32 +0000 (11:16 -0700)
commit97e4344bea559b6a808321892b6ccbb9a54c9532
tree0f3c6b1e8267605b95afb522f4e3a42af7b857e5
parente904d68fa855b1e2941139db994644f45c852863
Fix off-by-one finalized transaction locktime

While these transactions were still valid, we incorrectly assumed that
they would propagate with a locktime of `current_height + 1`, when in
reality, only those with a locktime strictly lower than the next height
in the chain are allowed to enter the mempool.
lightning/src/chain/onchaintx.rs
lightning/src/chain/package.rs
lightning/src/ln/channelmanager.rs
lightning/src/ln/functional_test_utils.rs
lightning/src/ln/functional_tests.rs
lightning/src/ln/monitor_tests.rs
lightning/src/ln/payment_tests.rs
lightning/src/ln/reload_tests.rs
lightning/src/ln/reorg_tests.rs
lightning/src/util/test_utils.rs