Make PackageTemplate::height_timer non-optional
authorWilmer Paulino <wilmer@wilmerpaulino.com>
Sat, 15 Apr 2023 00:03:32 +0000 (17:03 -0700)
committerWilmer Paulino <wilmer@wilmerpaulino.com>
Wed, 19 Apr 2023 23:49:37 +0000 (16:49 -0700)
commita3b416a32ca967e8b2ef4adb3d97c3a447becda9
treee635158624f6b58bad14fc3296331178238ff15a
parent4828817f3f8425a0cf1874fc5000cae5ab95a9e8
Make PackageTemplate::height_timer non-optional

Now that we leverage a package's `height_timer` even for untractable
packages, there's no need to have it be an `Option` anymore. We aim to
not break compatibility by keeping the deserialization of such as an
`option`, and use the package's `height_original` when not present. This
allows us to retry packages from older `ChannelMonitor` versions that
have had a failed initial package broadcast.
lightning/src/chain/onchaintx.rs
lightning/src/chain/package.rs
lightning/src/ln/monitor_tests.rs