Rename `MonitorEvent::CommitmentTxConfirmed` to `HolderForceClosed`
authorMatt Corallo <git@bluematt.me>
Wed, 30 Aug 2023 18:22:33 +0000 (18:22 +0000)
committerMatt Corallo <git@bluematt.me>
Thu, 21 Sep 2023 19:04:41 +0000 (19:04 +0000)
commita96e2fe144383ea6fd670153fb895ee07a3245ef
tree8f1525df750d15c9382b363a85460681b5dd3434
parent6e115db22b1e1f89f62c958af1300ec0a47ef27a
Rename `MonitorEvent::CommitmentTxConfirmed` to `HolderForceClosed`

The `MonitorEvent::CommitmentTxConfirmed` has always been a result
of us force-closing the channel, not the counterparty doing so.
Thus, it was always a bit of a misnomer. Worse, it carried over
into the channel's `ClosureReason` in the event API.

Here we simply rename it and use the proper `ClosureReason`.
lightning/src/chain/channelmonitor.rs
lightning/src/ln/channelmanager.rs
lightning/src/ln/functional_tests.rs
lightning/src/ln/monitor_tests.rs
lightning/src/ln/reorg_tests.rs