Don't sign holder HTLCs along with holder commitments
authorWilmer Paulino <wilmer@wilmerpaulino.com>
Fri, 13 Oct 2023 21:09:37 +0000 (14:09 -0700)
committerWilmer Paulino <wilmer@wilmerpaulino.com>
Fri, 20 Oct 2023 22:32:15 +0000 (15:32 -0700)
commitaae4e7c0cab7f30e38b06a2314eea505389eefe1
tree83947e6a23e8b68a9ab4ff0343866e6e7d29043a
parenta9d9d266557abccb4ac55aa9fc2ba90ebb755c55
Don't sign holder HTLCs along with holder commitments

`sign_holder_commitment_and_htlcs` never really made sense. Unlike
`sign_counterparty_commitment`, the signatures for holder HTLC
transactions may be required much later than the commitment
transaction's. While it was nice for us to only reach the signer once to
obtain all holder signatures, it's not really ideal anymore as we want
our signatures to be random and not reused.

We no longer return all holder HTLC signatures and instead defer to
obtaining them via `EcdsaChannelSigner::sign_holder_htlc_transaction`.
lightning/src/chain/onchaintx.rs
lightning/src/ln/channel.rs
lightning/src/ln/monitor_tests.rs
lightning/src/sign/mod.rs
lightning/src/util/test_channel_signer.rs