Change variable nomenclature for to_self_delay
authorAntoine Riard <ariard@student.42.fr>
Wed, 26 Aug 2020 19:27:12 +0000 (15:27 -0400)
committerAntoine Riard <ariard@student.42.fr>
Mon, 14 Sep 2020 18:39:44 +0000 (14:39 -0400)
commitc6a91f2ebd301455c7ebae04eb1f308935666439
treeda1ac4eda89bac38294fcc4252e62661f1dee457
parentc7ef6df672b6eb7a8bec9230195fb7cee6d7393e
Change variable nomenclature for to_self_delay

To avoid reviewers confusion, rename counterparty_to_self_delay
to counteparty_selected_contest_delay, i.e the justice delay announced
by a channel counterparty restraining our transactions, and to_self_delay
to locally_selected_contest_delay, i.e the justice delay announced by us
restraining counterparty's transactions

We deviate from wider nomenclature by prefixing local data with a
locally_ extension due to the leak of this value in transactions/scripts
builder, where the confusion may happen.

Rename further AcceptChannelData to the new nomenclature.
lightning-c-bindings/src/chain/keysinterface.rs
lightning/src/chain/keysinterface.rs
lightning/src/ln/chan_utils.rs
lightning/src/ln/channel.rs
lightning/src/util/enforcing_trait_impls.rs