Correctly handle any `UPDATE` errors to phandom invoices 2022-12-fix-missing-data
authorMatt Corallo <git@bluematt.me>
Fri, 2 Dec 2022 21:12:47 +0000 (21:12 +0000)
committerMatt Corallo <git@bluematt.me>
Tue, 6 Dec 2022 20:00:44 +0000 (20:00 +0000)
commitc9fe69fa5fe2ce50dde6e5b59a16d5783a29a9d7
tree179d9db1b921bc8b237fa878d1c53840ea64227c
parent01d299ecdb513dac3a4bcba4a3e53c3e49c8fcc6
Correctly handle any `UPDATE` errors to phandom invoices

If we try to send any onion error with the `UPDATE` flag in
response to a phantom receipt, we should always swap it for
something generic that doesn't require a `channel_update` in it.
Here we use `temporary_node_failure`.

Test provided by Valentine Wallace <vwallace@protonmail.com>
lightning/src/ln/channelmanager.rs
lightning/src/ln/onion_route_tests.rs