Stop writing signer data as a part of channels 2023-11-less-graph-memory-frag
authorMatt Corallo <git@bluematt.me>
Sat, 4 Nov 2023 23:02:18 +0000 (23:02 +0000)
committerMatt Corallo <git@bluematt.me>
Thu, 9 Nov 2023 22:28:08 +0000 (22:28 +0000)
commit7a951b1bf7615fd7afb1e20c1c627e58a3599c84
tree66003c01a38a573121f1288a748fb5ac6b7dc9d8
parenta8d4cfa811e3472457bb874f24fae7175520c062
Stop writing signer data as a part of channels

This breaks backwards compatibility with versions of LDK prior to
0.0.113 as they expect to always read signer data.

This also substantially reduces allocations during `ChannelManager`
serialization, as we currently don't pre-allocate the `Vec` that
the signer gets written in to. We could alternatively pre-allocate
that `Vec`, but we've been set up to skip the write entirely for a
while, and 0.0.113 was released nearly a year ago. Users
downgrading to LDK 0.0.112 and before at this point should not be
expected.
CONTRIBUTING.md
lightning/src/ln/channel.rs
lightning/src/sign/type_resolver.rs
pending_changelog/113-channel-ser-compat.txt [new file with mode: 0644]