]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
4 years agoAssertions in update_fee_that_funder_cannot_afford to check consts
Matt Corallo [Wed, 1 Apr 2020 20:40:11 +0000 (16:40 -0400)]
Assertions in update_fee_that_funder_cannot_afford to check consts

4 years agoCorrect initial commitment check in inbound channel-open handling.
Matt Corallo [Wed, 1 Apr 2020 21:11:12 +0000 (17:11 -0400)]
Correct initial commitment check in inbound channel-open handling.

Previously, we would reject inbound channels if the funder wasn't
able to afford both the initial commitment transaction fee and the
initial commitment didn't meet both our and our counterparty's
reserve value.

We never bothered to check if it was impossible for them to meet
both reserve values, and meeting their own reserve is perfectly
acceptable anyway (as long as they eventually meet it).

The easy fix is to just check that they at least have enough funds
back to themselves on the initial commitment to meet our reserve,
though we could be more careful in the future.

4 years agoAdd TODOs
Matt Corallo [Mon, 17 Dec 2018 17:13:03 +0000 (12:13 -0500)]
Add TODOs

4 years agoTESTING
Matt Corallo [Thu, 7 Mar 2019 16:33:19 +0000 (11:33 -0500)]
TESTING

4 years agoTESTING
Matt Corallo [Fri, 1 Mar 2019 22:41:40 +0000 (17:41 -0500)]
TESTING

4 years agoMake full_stack_target more absurdly huge and check for funds loss
Matt Corallo [Fri, 17 Aug 2018 21:44:13 +0000 (17:44 -0400)]
Make full_stack_target more absurdly huge and check for funds loss

4 years agoConnect blocks at the end
Matt Corallo [Fri, 17 Aug 2018 21:42:28 +0000 (17:42 -0400)]
Connect blocks at the end

4 years agoAdditional asserts to include in fuzztesting (though may get hit?)
Matt Corallo [Tue, 5 Mar 2019 22:29:12 +0000 (17:29 -0500)]
Additional asserts to include in fuzztesting (though may get hit?)

4 years agoDemonstrate mutating functions which are not fully test-covered
Matt Corallo [Sun, 19 Jan 2020 05:13:13 +0000 (00:13 -0500)]
Demonstrate mutating functions which are not fully test-covered

4 years agoempty_commit: not-yet-PR-d commits follow
Matt Corallo [Thu, 20 Feb 2020 20:07:04 +0000 (15:07 -0500)]
empty_commit: not-yet-PR-d commits follow

4 years agoRevert "Test that txn pay at least a minimum relay fee in functional tests"
Matt Corallo [Tue, 17 Mar 2020 03:14:00 +0000 (23:14 -0400)]
Revert "Test that txn pay at least a minimum relay fee in functional tests"

This reverts commit cc038cc28796d04335f9705858cdfb74ee6f0d72.

4 years agoTest that txn pay at least a minimum relay fee in functional tests
Matt Corallo [Mon, 2 Mar 2020 16:44:11 +0000 (11:44 -0500)]
Test that txn pay at least a minimum relay fee in functional tests

4 years agoempty_commit: critical bugfixes follow
Matt Corallo [Thu, 27 Feb 2020 02:13:36 +0000 (21:13 -0500)]
empty_commit: critical bugfixes follow

4 years agoDon't send padding bytes for pings
Matt Corallo [Sat, 15 Feb 2020 03:51:09 +0000 (22:51 -0500)]
Don't send padding bytes for pings

We (somewhat needlessly) send an extra 64 bytes with every ping.
While this isn't exactly a big deal, I saw it and figured we
shouldn't waste bytes on the wire given some of the constraints of
potential users.

4 years agoAdd an fn to get a ChannelMonitor reference from a ManyChannelMonitor
Matt Corallo [Sat, 15 Feb 2020 01:06:31 +0000 (20:06 -0500)]
Add an fn to get a ChannelMonitor reference from a ManyChannelMonitor

This is really awkwrd, and relies on some (at least rather simple)
unsafe code (essentially avoiding the need for Pin), but it works
pretty well.

4 years agoempty_commit: not-yet-PR-d commits follow
Matt Corallo [Thu, 20 Feb 2020 20:07:04 +0000 (15:07 -0500)]
empty_commit: not-yet-PR-d commits follow

4 years agoAdd a Headers-over-DNS client to lightning-block-sync.
Matt Corallo [Tue, 5 May 2020 18:17:18 +0000 (14:17 -0400)]
Add a Headers-over-DNS client to lightning-block-sync.

This is useful to kick on backup BlockSources.

4 years agoAdd subcrate which impls a simple SPV client from Bitcoin Core RPC
Matt Corallo [Tue, 5 May 2020 16:36:32 +0000 (12:36 -0400)]
Add subcrate which impls a simple SPV client from Bitcoin Core RPC

This adds a new subcrate `lightning-block-sync` which is designed
to make it easier to get up-and-running by removing the effort of
building an SPV client and fetching the chain.

Instead of building a P2P client (and all the address management
that entails), this focuses on building a trivial SPV client which
can fetch from several instances of an abstract BlockSource. Then,
we provide two example BlockSource implementations that can fetch
from Bitcoin Core's RPC interface and Bitcoin Core's REST interface.

The code here is taken with heavy modifications from
rust-lightning-bitcoinrpc.

4 years agoExpose ChannelMonitor::block_[dis]connected as pub
Matt Corallo [Thu, 13 Feb 2020 04:55:22 +0000 (23:55 -0500)]
Expose ChannelMonitor::block_[dis]connected as pub

These are essentially required to make rescan-at-reload doable as
individual ChannelMonitors may be synced to different chain states
and thus need to have blocks replayed separately.

4 years agoempty_commit: PR 614 follows
Matt Corallo [Thu, 20 Feb 2020 20:11:36 +0000 (15:11 -0500)]
empty_commit: PR 614 follows

4 years agoDont hold peers lock when calling user code
Matt Corallo [Sun, 1 Mar 2020 03:03:53 +0000 (22:03 -0500)]
Dont hold peers lock when calling user code

4 years agoPretty-shitty implement TODOs for msg forwarding
Matt Corallo [Mon, 24 Feb 2020 23:14:40 +0000 (18:14 -0500)]
Pretty-shitty implement TODOs for msg forwarding

4 years agoempty_commit: Obviously-useful commits follow
Matt Corallo [Thu, 27 Feb 2020 02:13:03 +0000 (21:13 -0500)]
empty_commit: Obviously-useful commits follow

4 years agoRun with mutagen on travis.
Matt Corallo [Fri, 24 Apr 2020 18:22:26 +0000 (14:22 -0400)]
Run with mutagen on travis.

Sadly our test coverage isn't very good and I had to hunt for
functions to mutate where we fail tests on every mutation mutagen
creates, but committing the framework is a start.

4 years agoempty_commit: PR 453 follows
Matt Corallo [Thu, 20 Feb 2020 20:11:36 +0000 (15:11 -0500)]
empty_commit: PR 453 follows

4 years agoempty_commit: PR 539 follows
Matt Corallo [Thu, 27 Feb 2020 02:13:36 +0000 (21:13 -0500)]
empty_commit: PR 539 follows

4 years agoMerge pull request #624 from arik-so/encode_and_send_msg_method_refactor
Matt Corallo [Fri, 22 May 2020 18:45:55 +0000 (18:45 +0000)]
Merge pull request #624 from arik-so/encode_and_send_msg_method_refactor

Extract encode_and_send_msg into a method.

4 years agoExtract encode_and_send_msg into a method.
Arik Sosman [Mon, 18 May 2020 17:55:28 +0000 (10:55 -0700)]
Extract encode_and_send_msg into a method.

This is a response to splitting #585 into smaller components. This extraction will permit a future extraction of all message handling into a separate method, and then later even into a separate trait that will be accessible through language bindings.

4 years agoMerge pull request #622 from valentinewallace/chanmgr-logger-arc-to-deref
Matt Corallo [Mon, 18 May 2020 03:21:12 +0000 (03:21 +0000)]
Merge pull request #622 from valentinewallace/chanmgr-logger-arc-to-deref

ChannelManager+Router++ Logger Arc --> Deref

4 years agoPeerManager Logger Arc --> Deref
Valentine Wallace [Sun, 17 May 2020 16:13:29 +0000 (12:13 -0400)]
PeerManager Logger Arc --> Deref

4 years agoChannelManager+Router++ Logger Arc --> Deref
Valentine Wallace [Mon, 2 Mar 2020 17:55:53 +0000 (12:55 -0500)]
ChannelManager+Router++ Logger Arc --> Deref

This caused a bunch of cascading changes, including
passing loggers down to Channels in function calls
rather than having each Channel have a pointer to the
ChannelManager's Logger (which was a circular reference).
Other structs that the Channel had passed its Logger to also
had their loggers removed. Other newly unused Loggers were
also removed, especially when keeping them would've caused
a bunch of extra test changes to be necessary, e.g. with
the ChainWatchInterfaceUtil's Logger.

4 years agoMerge pull request #617 from sourabhmarathe/serialize-channelmanager-events
Matt Corallo [Thu, 14 May 2020 21:24:45 +0000 (21:24 +0000)]
Merge pull request #617 from sourabhmarathe/serialize-channelmanager-events

Serialize ChannelManager events

4 years agoSerialize ChannelManager events
Sourabh Marathe [Thu, 7 May 2020 01:02:44 +0000 (21:02 -0400)]
Serialize ChannelManager events

Also adds a test for de/serializing events

4 years agoMerge pull request #621 from TheBlueMatt/2020-05-592-nits
Matt Corallo [Tue, 12 May 2020 18:41:04 +0000 (18:41 +0000)]
Merge pull request #621 from TheBlueMatt/2020-05-592-nits

592+a few fixes

4 years agoFix some new indentation nits 2020-05-592-nits
Matt Corallo [Tue, 12 May 2020 01:12:23 +0000 (21:12 -0400)]
Fix some new indentation nits

4 years agoFix a few new (and one old) issues in the new channel_update
Matt Corallo [Tue, 12 May 2020 01:09:44 +0000 (21:09 -0400)]
Fix a few new (and one old) issues in the new channel_update

We need to always set lowest_inbound_channel_fees to None if there
are no channels (and we should ignore the channels which are
disabled for the purpose of lowest-fee calculations). Further, we
cannot unwrap the channel lookups as they may be for channels which
are not related to the channel we are processing an update for.
Finally, we can satisfy borrowck much easier since things are on
self instead of on a MutexGuard.

4 years agoAdd assertion since we now have a pub field that is PartialEq
Matt Corallo [Tue, 12 May 2020 01:08:35 +0000 (21:08 -0400)]
Add assertion since we now have a pub field that is PartialEq

We previously were only able to assert that the route graph
serialization roundtrips were good by comparing the network
messages returned from them, but we can now do better as the graph
is exposed publicly via a simple datastructure that implements
PartialEq.

4 years agoAdd missing comment on why last_update_message is None
Matt Corallo [Tue, 12 May 2020 01:08:11 +0000 (21:08 -0400)]
Add missing comment on why last_update_message is None

4 years agoMove get_addresses to network_graph and drop now-useless log_trace
Matt Corallo [Tue, 12 May 2020 01:07:02 +0000 (21:07 -0400)]
Move get_addresses to network_graph and drop now-useless log_trace

Because we expose the internals we don't need a method to log
their contents anymore, and get_addresses can now avoid copying as
we expose the RwLock directly

4 years agoDrop new test Node field introduced in 8ce2223b6952567b28adfcc11c2
Matt Corallo [Mon, 11 May 2020 22:36:58 +0000 (18:36 -0400)]
Drop new test Node field introduced in 8ce2223b6952567b28adfcc11c2

8ce2223b6952567b28adfcc11c23c9f19c4c0324 introduced a new field in
the "Node" objects used in our functional tests - the node_id. Its
not a bad idea to cache it, but unless we want to commit and use it
everywhere, we should avoid duplicating data, especially in tests
where we'd rather exercise the underlying code than bypass it.

4 years agoImprove routing-related documentation
Gleb Naumenko [Wed, 6 May 2020 23:04:44 +0000 (19:04 -0400)]
Improve routing-related documentation

4 years agoRemove NetGraphMsgHandler serialization
Gleb Naumenko [Wed, 6 May 2020 22:34:37 +0000 (18:34 -0400)]
Remove NetGraphMsgHandler serialization

4 years agoMake DirectionalChannelInfo optional
Gleb Naumenko [Sun, 3 May 2020 20:06:59 +0000 (16:06 -0400)]
Make DirectionalChannelInfo optional

4 years agoMove node announcement fields into a separate struct
Gleb Naumenko [Mon, 4 May 2020 17:53:44 +0000 (13:53 -0400)]
Move node announcement fields into a separate struct

4 years agoExpose some network graph methods
Gleb Naumenko [Sun, 3 May 2020 15:01:55 +0000 (11:01 -0400)]
Expose some network graph methods

4 years agoSplit routing from getting network messages
Gleb Naumenko [Sat, 2 May 2020 19:05:04 +0000 (15:05 -0400)]
Split routing from getting network messages

4 years agoRemove non-bitcoin chain helpers
Gleb Naumenko [Sat, 2 May 2020 18:58:06 +0000 (14:58 -0400)]
Remove non-bitcoin chain helpers

4 years agoMove router to a separate module
Gleb Naumenko [Sat, 2 May 2020 13:37:38 +0000 (09:37 -0400)]
Move router to a separate module

4 years agoMerge pull request #539 from TheBlueMatt/2020-03-static-remotekey
Matt Corallo [Wed, 6 May 2020 02:07:02 +0000 (02:07 +0000)]
Merge pull request #539 from TheBlueMatt/2020-03-static-remotekey

Require static_remotekey

4 years agoMerge pull request #613 from valentinewallace/less-confusing-chan-reserve-names
Matt Corallo [Wed, 6 May 2020 02:06:41 +0000 (02:06 +0000)]
Merge pull request #613 from valentinewallace/less-confusing-chan-reserve-names

Make channel reserve variable names less confusing.

4 years agoRename payment_basepoint/key to simply payment_point/key. 2020-03-static-remotekey
Matt Corallo [Mon, 9 Mar 2020 00:38:16 +0000 (20:38 -0400)]
Rename payment_basepoint/key to simply payment_point/key.

We no longer derive any keys from the payment point, so they aren't
a "base" but simply a point/key.

4 years agoRequire option_static_remotekey in channel/channelmonitor.
Matt Corallo [Sun, 3 May 2020 02:00:08 +0000 (22:00 -0400)]
Require option_static_remotekey in channel/channelmonitor.

This simplifies channelmonitor quite nicely (as expected) as we
never have to be concerned with learning data in a DataLossProtect
which is require for us to claim our funds from the latest remote
commitment transaction.

4 years agoAdd detection of feature_static_remotekey support and print
Matt Corallo [Tue, 3 Mar 2020 20:27:45 +0000 (15:27 -0500)]
Add detection of feature_static_remotekey support and print

This adds the ability to check for static_remotekey in appropriate
feature contexts and prints it at connect time. It is still
considered unknown for the purposes of requires_unknown_bits() as
we don't yet implement it.

4 years agoMake channel reserve variable names less confusing.
Valentine Wallace [Fri, 1 May 2020 22:39:18 +0000 (18:39 -0400)]
Make channel reserve variable names less confusing.

Previous to this commit, variables such as their_channel_reserve
referred to the channel reserve that _we_ are required to keep,
(the value is initially set by the remote). Similarly,
variables such as our_channel_reserve referred to the channel
reserve that we require the remote to keep.

Change this to use local_channel_reserve / remote_channel_reserve
to refer to the the channel reserve that the local is required to keep
and the channel reserve that the remote is required to keep, respectively.

4 years agoCheck local signtures explicitly in channel tx-generation tests
Matt Corallo [Mon, 9 Mar 2020 17:45:15 +0000 (13:45 -0400)]
Check local signtures explicitly in channel tx-generation tests

It appears the local signatures which are specified in the channel
transaction-generation tests were never checked directly (though
they were checked as a part of the overall fully-signed-transaction
tests).

Check them explicitly so that they can be updated for static remote
key.

4 years agoAdd additional trace logging in channel signature validation
Matt Corallo [Tue, 28 Apr 2020 23:46:45 +0000 (19:46 -0400)]
Add additional trace logging in channel signature validation

This makes it easier to amend the full_stack_target
test_no_existing_test_breakage test by always providing the
neccessary data in the log.

4 years agoMerge pull request #590 from jkczyz/2020-04-feature-flags
Matt Corallo [Wed, 29 Apr 2020 18:49:39 +0000 (18:49 +0000)]
Merge pull request #590 from jkczyz/2020-04-feature-flags

Features module improvements

4 years agoSanity check that known features are not required
Jeffrey Czyz [Tue, 28 Apr 2020 06:24:46 +0000 (23:24 -0700)]
Sanity check that known features are not required

4 years agoExpand testing of unknown feature bits
Jeffrey Czyz [Tue, 28 Apr 2020 05:12:53 +0000 (22:12 -0700)]
Expand testing of unknown feature bits

Include tests for requires_unknown_bits and supports_unknown_bits when
an unknown even bit, odd bit, or neither is set. Refactor bit clearing
such that tests and production code share the same code path. Fix a
potential spec incompatibility (currently only exposed in testing code)
where trailing zero bytes are not removed after a bit is cleared.

4 years agoGeneralize with_known_relevant_init_flags
Jeffrey Czyz [Wed, 22 Apr 2020 23:52:11 +0000 (16:52 -0700)]
Generalize with_known_relevant_init_flags

Converting from InitFeatures to other Features is accomplished using
Features::with_known_relevant_init_flags. Define a more general
to_context method which converts from Features of one Context to
another.

Additionally, ensure the source context only has known flags before
selecting flags for the target context.

4 years agoGeneralize feature methods to work in any context
Jeffrey Czyz [Thu, 16 Apr 2020 05:44:43 +0000 (22:44 -0700)]
Generalize feature methods to work in any context

Refactoring the features module allowed for making code specific to
certain contexts generalizable. Specifically, KNOWN_FEATURE_MASK
is defined on Context instead of hardcoded in each method
specialization. Thus, such methods are no longer required.

4 years agoRemove duplicate specification of features
Jeffrey Czyz [Thu, 16 Apr 2020 00:16:45 +0000 (17:16 -0700)]
Remove duplicate specification of features

Features for a given context are duplicated throughout the features
module. Use a macro for defining a Context and the applicable features
such that features only need to be defined for a Context in one place.
The Context provides bitmasks for selecting known and unknown feature
flags.

BOLT 1 and BOLT 9 refer to features as "known" if a peer understands
them. They also use the term "supported" to mean either optional or
required.

Update the features module to use similar terminology.
- Define contexts in terms of required and optional features rather than
  just supported features
- Define known features as those that are optional or required
- Rename supported() constructor to known()

For completeness, clear_optional_bit for each feature is now called
clear_bits and clears both optional and required bits.

4 years agoImprove features module documentation
Jeffrey Czyz [Tue, 14 Apr 2020 01:39:29 +0000 (18:39 -0700)]
Improve features module documentation

4 years agoEncapsulate feature flag checking and manipulation
Jeffrey Czyz [Fri, 10 Apr 2020 00:08:48 +0000 (17:08 -0700)]
Encapsulate feature flag checking and manipulation

Each feature is represented by two bits within Features' flags field.
Working with these flags requires bitwise operations, which can be error
prone. Rather than directly checking and manipulating bits, encapsulate
the bits within each feature trait and provide mechanisms for doing so.

This removes the need to comment on which features correspond to bitwise
expressions since the expressions use feature trait identifiers instead.

With this approach, byte literals and expressions can be evaluated at
compile time still. However, for these cases, knowing which byte within
the flags that a feature corresponds to still must be determined by the
implementor.

Remove the special case where initial_routing_sync has no even bit. Now,
it (bit 2) is considered known by the implementation.

4 years agoSet initial_routing_sync in InitFeatures
Jeffrey Czyz [Thu, 23 Apr 2020 16:47:15 +0000 (09:47 -0700)]
Set initial_routing_sync in InitFeatures

The initial_routing_sync feature is set by peer_handler whenever a full
sync of the network graph is desired. It is not explicitly set when
creating features with InitFeatures::supported().

An upcoming refactor will change supported() to known(), which will
return all features known by the implementation. Thus, the
initial_routing_sync flag will need to be set by default. This commit
makes the behavior change ahead of the refactor.

4 years agoMerge pull request #609 from LNP-BP/refactor-deps
Matt Corallo [Wed, 29 Apr 2020 17:15:38 +0000 (17:15 +0000)]
Merge pull request #609 from LNP-BP/refactor-deps

Refactor dependencies

4 years agoAdopting (W)PubkeyHash types
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 16:13:27 +0000 (18:13 +0200)]
Adopting (W)PubkeyHash types

4 years agoAdopting new bitcoin hash types and crate version
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 15:53:13 +0000 (17:53 +0200)]
Adopting new bitcoin hash types and crate version

4 years agoBDR: Linearizing secp256k1 deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:51:59 +0000 (16:51 +0200)]
BDR: Linearizing secp256k1 deps

4 years agoBitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:41:54 +0000 (16:41 +0200)]
Bitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps

4 years agoUnset upfront_shutdown_script using bit clearing
Jeffrey Czyz [Fri, 10 Apr 2020 18:36:47 +0000 (11:36 -0700)]
Unset upfront_shutdown_script using bit clearing

The test_upfront_shutdown_script functional test clears this feature
flag. However, the method used to clear the flag is implemented by bit
toggling. Thus, if the flag is not set the method would actually set it.
Implement the method using bit clearing instead.

4 years agoMerge pull request #608 from TheBlueMatt/2020-04-0.0.11
Matt Corallo [Sat, 25 Apr 2020 16:42:15 +0000 (16:42 +0000)]
Merge pull request #608 from TheBlueMatt/2020-04-0.0.11

0.0.11

4 years agoMerge pull request #598 from TheBlueMatt/2020-04-559-cleanups
Matt Corallo [Sat, 25 Apr 2020 16:42:03 +0000 (16:42 +0000)]
Merge pull request #598 from TheBlueMatt/2020-04-559-cleanups

Clean up ChannelKeys API

4 years agoBump versions to 0.0.11/net-tokio 0.0.3 2020-04-0.0.11
Matt Corallo [Sat, 25 Apr 2020 02:10:00 +0000 (22:10 -0400)]
Bump versions to 0.0.11/net-tokio 0.0.3

4 years agoRemove trivial assertions in LocalCommitmentTransaction fns 2020-04-559-cleanups
Matt Corallo [Fri, 24 Apr 2020 19:31:33 +0000 (15:31 -0400)]
Remove trivial assertions in LocalCommitmentTransaction fns

We don't need to assert that transaction structure is what we
expect when the transaction is created by a function twenty lines
up in the same file.

4 years agoRemove TODOs from documentation in keysinterface
Matt Corallo [Mon, 20 Apr 2020 05:07:18 +0000 (01:07 -0400)]
Remove TODOs from documentation in keysinterface

We should never be exposing our own TODOs to the world.

4 years agoDon't modify LocalCommitmemntTransaction after construction
Matt Corallo [Thu, 23 Apr 2020 19:43:21 +0000 (15:43 -0400)]
Don't modify LocalCommitmemntTransaction after construction

Instead of adding signatures to LocalCommitmentTransactions, we
instead leave them unsigned and use them to construct signed
Transactions when we want them. This cleans up the guts of
LocalCommitmentTransaction enough that we can, and do, expose its
state to the world, allowing external signers to have a basic
awareness of what they're signing.

4 years agoBatch-sign local HTLC txn with a well-doc'd API, returning sigs
Matt Corallo [Mon, 20 Apr 2020 02:59:53 +0000 (22:59 -0400)]
Batch-sign local HTLC txn with a well-doc'd API, returning sigs

1107ab06c33bd360bdee7ee64f4b690e753003f6 introduced an API to have a
ChannelKeys implementer sign HTLC transactions by calling into the
LocalCommitmentTransaction object, which would then store the tx.

This API was incredibly awkward, both because it required an
external signer trust our own internal interfaces, but also because
it didn't allow for any inspection of what was about to be signed.

Further, it signed the HTLC transactions one-by-one in a somewhat
inefficient way, and there isn't a clear way to resolve this (as
the which-HTLC parameter has to refer to something in between the
HTLC's arbitrary index, and its index in the commitment tx, which
has "holes" for the non-HTLC outputs and skips some HTLCs).

We replace it with a new function in ChannelKeys which allows us
to sign all HTLCs in a given commitment transaction (which allows
for a bit more effeciency on the signers' part, as well as
sidesteps the which-HTLC issue). This may also simplify the signer
implementation as we will always want to sign all HTLCs spending a
given commitment transaction at once anyway.

We also de-mut the LocalCommitmentTransaction passed to the
ChanKeys, instead opting to make LocalCommitmentTransaction const
and avoid storing any new HTLC-related data in it.

4 years agoReturn Result<Signature> instead of modifying args in ChannelKeys
Matt Corallo [Sun, 19 Apr 2020 21:26:41 +0000 (17:26 -0400)]
Return Result<Signature> instead of modifying args in ChannelKeys

This cleans up sign_local_commitment somewhat by returning a
Result<Signaure, ()> over the local commitment transaction instead
of modifying the struct which was passed in.

This is the first step in making LocalCommitmentTransaction a
completely pub struct, using it just to communicate enough
information to the user to allow them to construct a signaure
instead of having it contain a bunch of logic.

This should make it much easier to implement a custom ChannelKeys
by disconnecting the local commitment transaction signing from our
own datastructures.

4 years agoTrack signing of local txn in channelmonitor and refuse updates
Matt Corallo [Sun, 19 Apr 2020 18:15:56 +0000 (14:15 -0400)]
Track signing of local txn in channelmonitor and refuse updates

In e46e183084ed858f41aa304acd78503aea1a96ed we began tracking
whether a local commitment transaction had been signed and
broadcast in OnchainTxHandler, refusing to update the local
commitment transaction state in the ChannelMonitor on that basis.

This is fine, except that it doesn't make a lot of sense to store
the full local transaction state in OnchainTxHandler - we should be
providing it the unsigned local transaction at the time we wish to
broadcast and no more (just like we do all other transaction data).

4 years agoDry-up InputMaterial::Funding
Antoine Riard [Tue, 21 Apr 2020 01:19:00 +0000 (21:19 -0400)]
Dry-up InputMaterial::Funding

As channel_value last usage was for computing feerate but as this
one is static per-commitment and will always-be following specification,
we remove it.

4 years agoMerge pull request #579 from ariard/2020-04-sanitize-cltv-delay
Matt Corallo [Fri, 24 Apr 2020 22:50:45 +0000 (22:50 +0000)]
Merge pull request #579 from ariard/2020-04-sanitize-cltv-delay

Sanititze and document incoming HTLC cltv_expiry handling

4 years agoSanitize outgoing HTLC cltv_value
Antoine Riard [Fri, 10 Apr 2020 02:04:30 +0000 (22:04 -0400)]
Sanitize outgoing HTLC cltv_value

4 years agoDocument exactly our CLTV sanitization policy for final incoming HTLCs
Antoine Riard [Fri, 10 Apr 2020 01:51:29 +0000 (21:51 -0400)]
Document exactly our CLTV sanitization policy for final incoming HTLCs

We want to avoid a third-party channel closure, where a random node
by sending us a payment expiring at current height, would trigger our
onchain logic to close the channel due to a near-expiration.

4 years agoMerge pull request #607 from TheBlueMatt/2020-04-more-cleanups
Matt Corallo [Fri, 24 Apr 2020 22:17:53 +0000 (22:17 +0000)]
Merge pull request #607 from TheBlueMatt/2020-04-more-cleanups

CI and rustc warning cleanup

4 years agoInclude color when building fuzz targets in CI 2020-04-more-cleanups
Matt Corallo [Fri, 24 Apr 2020 21:35:18 +0000 (17:35 -0400)]
Include color when building fuzz targets in CI

4 years agoDisable timeout for full_stack_target runs in CI
Matt Corallo [Fri, 24 Apr 2020 20:56:20 +0000 (16:56 -0400)]
Disable timeout for full_stack_target runs in CI

It seems we've recently been seeing sporadic long-running
full_stack_target cases when running honggfuzz in CI. These
shouldn't be killed (as its possible they hit an error or a deadlock,
especially since the longest-running tests probably have the most
coverage).

4 years agoSilence fuzz build unused import warnings
Matt Corallo [Fri, 24 Apr 2020 20:24:25 +0000 (16:24 -0400)]
Silence fuzz build unused import warnings

4 years agoAddress new rustc warnings.
Matt Corallo [Fri, 24 Apr 2020 18:40:01 +0000 (14:40 -0400)]
Address new rustc warnings.

4 years agoFix step naming in fuzz tests in GitHub Actions
Matt Corallo [Fri, 24 Apr 2020 18:22:31 +0000 (14:22 -0400)]
Fix step naming in fuzz tests in GitHub Actions

4 years agoRun Github Actions on PRs, too
Matt Corallo [Fri, 24 Apr 2020 20:22:44 +0000 (16:22 -0400)]
Run Github Actions on PRs, too

4 years agoMerge pull request #593 from TheBlueMatt/2020-04-par-fuzz-check
Matt Corallo [Fri, 24 Apr 2020 20:52:19 +0000 (20:52 +0000)]
Merge pull request #593 from TheBlueMatt/2020-04-par-fuzz-check

Thread fuzz test cases

4 years agoDocument exactly our CLTV sanitization policy for incoming HTLCs
Antoine Riard [Fri, 10 Apr 2020 01:22:16 +0000 (21:22 -0400)]
Document exactly our CLTV sanitization policy for incoming HTLCs

4 years agoThread fuzz test cases 2020-04-par-fuzz-check
Matt Corallo [Fri, 21 Feb 2020 01:11:40 +0000 (20:11 -0500)]
Thread fuzz test cases

Adds threading (with logger capture) to fuzz targets so that we can
more effeciently test a failing fuzz corpus on new code changes.

4 years agoMerge pull request #587 from TheBlueMatt/2020-04-mpp-timeout
Matt Corallo [Fri, 24 Apr 2020 19:07:22 +0000 (19:07 +0000)]
Merge pull request #587 from TheBlueMatt/2020-04-mpp-timeout

Time out HTLCs before they expire

4 years agoAdd test for timing out HTLCs which are in the holding cell 2020-04-mpp-timeout
Matt Corallo [Mon, 20 Apr 2020 20:55:31 +0000 (16:55 -0400)]
Add test for timing out HTLCs which are in the holding cell

4 years agoTime out AwatingRemoteRAA outgoing HTLCs when we reach cltv_expiry
Antoine Riard [Sat, 8 Dec 2018 03:09:58 +0000 (22:09 -0500)]
Time out AwatingRemoteRAA outgoing HTLCs when we reach cltv_expiry

In case of committing out-of-time outgoing HTLCs, we force
ourselves to close the channel to avoid remote peer claims on a
non-backed HTLC

4 years agoAdd test for partial-send MPP due to monitor update failure
Matt Corallo [Tue, 14 Apr 2020 01:04:03 +0000 (21:04 -0400)]
Add test for partial-send MPP due to monitor update failure

Relatively simple test that, after a monitor update fails, we get
the right return value and continue with the bits of the MPP that
did not send after the monitor updating is restored.

4 years agoAdd a test for timeout'ing HTLCs which claim to be a part of an MPP
Matt Corallo [Thu, 19 Mar 2020 04:34:15 +0000 (00:34 -0400)]
Add a test for timeout'ing HTLCs which claim to be a part of an MPP

This is a key test for our automatic HTLC time-out logic, as it
ensures we don't allow an HTLC which indicates we should wait for
additional HTLCs before responding to cause us to force-close a
channel due to HTLC near-timeout.

4 years agoExpand expect_payment_failed!() to take error codes and use it more
Matt Corallo [Mon, 20 Apr 2020 19:46:35 +0000 (15:46 -0400)]
Expand expect_payment_failed!() to take error codes and use it more

expect_payment_failed!() was introduced after many of the tests
which could use it were written, so we take this opportunity to
switch them over now, increasing test coverage slightly by always
checking the payment hash expected.