]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
12 months agoRevert "Config-guard Event::InvoiceRequestFailed"
Jeffrey Czyz [Thu, 12 Oct 2023 21:10:51 +0000 (16:10 -0500)]
Revert "Config-guard Event::InvoiceRequestFailed"

This reverts commit c7219e46831751c52026932294c33fce24121d84.

12 months agoUse ChannelManager as OffersMessageHandler
Jeffrey Czyz [Tue, 6 Jun 2023 17:00:54 +0000 (12:00 -0500)]
Use ChannelManager as OffersMessageHandler

12 months agoOffersMessageHandler impl for ChannelManager
Jeffrey Czyz [Fri, 1 Sep 2023 19:04:27 +0000 (14:04 -0500)]
OffersMessageHandler impl for ChannelManager

Define the BOLT 12 message flow in ChannelManager's
OffersMessageHandler implementation.
- An invoice_request message results in responding with an invoice
  message if it can be verified that the request is for a valid offer.
- An invoice is paid if it can be verified to have originated from a
  sent invoice_request or a refund.
- An invoice_error is sent in some failure cases.
- Initial messages enqueued for sending are released to OnionMessenger

12 months agoCheck offer expiry when building invoice in no-std
Jeffrey Czyz [Thu, 19 Oct 2023 22:49:13 +0000 (17:49 -0500)]
Check offer expiry when building invoice in no-std

Building an invoice will fail if the underlying offer or refund has
already expired. The check was skipped in no-std since there is no
system clock. However, the invoice creation time can be used instead.
This prevents responding to an invoice request if the offer has already
expired.

12 months agoGrammar fix in docs
Jeffrey Czyz [Fri, 1 Sep 2023 14:40:34 +0000 (09:40 -0500)]
Grammar fix in docs

12 months agoBOLT12 invoice_feature methods for ChannelManager
Jeffrey Czyz [Fri, 1 Sep 2023 14:38:44 +0000 (09:38 -0500)]
BOLT12 invoice_feature methods for ChannelManager

12 months agoQualify BOLT11 ChannelManager invoice_features
Jeffrey Czyz [Fri, 1 Sep 2023 14:22:43 +0000 (09:22 -0500)]
Qualify BOLT11 ChannelManager invoice_features

12 months agoUtility for creating and sending Bolt12Invoices
Jeffrey Czyz [Fri, 15 Sep 2023 18:40:41 +0000 (13:40 -0500)]
Utility for creating and sending Bolt12Invoices

Add a utility to ChannelManager for creating a Bolt12Invoice for a
Refund such that the ChannelManager can recognize the PaymentHash and
reconstruct the PaymentPreimage from the PaymentSecret, the latter of
which is contained in a BlindedPath within the invoice.

12 months agoUtility for paying for an Offer
Jeffrey Czyz [Thu, 14 Sep 2023 18:32:51 +0000 (13:32 -0500)]
Utility for paying for an Offer

Add a utility to ChannelManager for sending an InvoiceRequest for an
Offer such that derived keys are used for the payer id. This allows for
stateless verification of any Invoice messages before it is paid.

Also tracks future payments using the given PaymentId such that the
corresponding Invoice is paid only once.

12 months agoAbsolute expiry or timer tick payment expiration
Jeffrey Czyz [Thu, 19 Oct 2023 19:38:16 +0000 (14:38 -0500)]
Absolute expiry or timer tick payment expiration

Pending outbound payments use an absolute expiry to determine when they
are considered stale and should be fail. In `no-std`, this may result in
long timeouts as the highest seen block time is used. Instead, allow for
expiration based on timer ticks. This will be use in an upcoming commit
for invoice request expiration.

12 months agoStore OffersMessages for later sending
Jeffrey Czyz [Thu, 14 Sep 2023 19:50:56 +0000 (14:50 -0500)]
Store OffersMessages for later sending

Upcoming commits will add utilities for sending an InvoiceRequest for an
Offer and an Invoice for a Refund. These messages need to be enqueued so
that they can be released in ChannelManager's implementation of
OffersMessageHandler to OnionMessenger for sending.

These messages do not need to be serialized as they must be resent upon
restart.

12 months agoExpand docs on failing expired outbound payments
Jeffrey Czyz [Thu, 19 Oct 2023 13:45:25 +0000 (08:45 -0500)]
Expand docs on failing expired outbound payments

12 months agoMerge pull request #2636 from slanesuke/impl-ToSocketAddrs-for-Hostname
Elias Rohrer [Fri, 20 Oct 2023 07:52:29 +0000 (09:52 +0200)]
Merge pull request #2636 from slanesuke/impl-ToSocketAddrs-for-Hostname

Impl ToSocketAddrs for SocketAddress

12 months agoMerge pull request #2666 from tnull/2023-10-observable-update
Matt Corallo [Thu, 19 Oct 2023 21:49:02 +0000 (21:49 +0000)]
Merge pull request #2666 from tnull/2023-10-observable-update

12 months agoMerge pull request #2661 from TheBlueMatt/2023-10-dup-claim-chan-hang
Matt Corallo [Thu, 19 Oct 2023 17:53:46 +0000 (17:53 +0000)]
Merge pull request #2661 from TheBlueMatt/2023-10-dup-claim-chan-hang

Immediately unblock channels on duplicate claims

12 months agoImmediately unblock channels on duplicate claims 2023-10-dup-claim-chan-hang
Matt Corallo [Wed, 11 Oct 2023 14:01:28 +0000 (14:01 +0000)]
Immediately unblock channels on duplicate claims

When `MonitorUpdateCompletionAction`s were added, we didn't
consider the case of a duplicate claim during normal HTLC
processing (as the handling only had an `if let` rather than a
`match`, which made the branch easy to miss). This can lead to a
channel freezing indefinitely if an HTLC is claimed (without a
`commitment_signed`), the peer disconnects, and then the HTLC is
claimed again, leading to a never-completing
`MonitorUpdateCompletionAction`.

The fix is simple - if we get back an
`UpdateFulfillCommitFetch::DuplicateClaim` when claiming from the
inbound edge, immediately unlock the outbound edge channel with a
new `MonitorUpdateCompletionAction::FreeOtherChannelImmediately`.

Here we implement this fix by actually generating the new variant
when a claim is duplicative.

12 months agoAdd an immediately-freeing `MonitorUpdateCompletionAction`.
Matt Corallo [Wed, 11 Oct 2023 13:56:00 +0000 (13:56 +0000)]
Add an immediately-freeing `MonitorUpdateCompletionAction`.

When `MonitorUpdateCompletionAction`s were added, we didn't
consider the case of a duplicate claim during normal HTLC
processing (as the handling only had an `if let` rather than a
`match`, which made the branch easy to miss). This can lead to a
channel freezing indefinitely if an HTLC is claimed (without a
`commitment_signed`), the peer disconnects, and then the HTLC is
claimed again, leading to a never-completing
`MonitorUpdateCompletionAction`.

The fix is simple - if we get back an
`UpdateFulfillCommitFetch::DuplicateClaim` when claiming from the
inbound edge, immediately unlock the outbound edge channel with a
new `MonitorUpdateCompletionAction::FreeOtherChannelImmediately`.

Here we add the new variant, which we start generating in the next
commit.

12 months agoIndicate to `claim_funds_internal` that we're replaying on startup
Matt Corallo [Thu, 12 Oct 2023 22:26:07 +0000 (22:26 +0000)]
Indicate to `claim_funds_internal` that we're replaying on startup

While we'd previously avoided this, this is sadly now required in
the next commit.

12 months agoLog when we prepare to block a channel's next `revoke_and_ack`
Matt Corallo [Wed, 11 Oct 2023 01:39:26 +0000 (01:39 +0000)]
Log when we prepare to block a channel's next `revoke_and_ack`

This may help in debugging blocking actions in the future.

12 months agoDon't apply PathFailure::ChannelUpdateMessage
Elias Rohrer [Thu, 19 Oct 2023 15:00:50 +0000 (17:00 +0200)]
Don't apply PathFailure::ChannelUpdateMessage

If we receive a channel update from an intermediary via a failure onion
we shouldn't apply them in a persisted and network-observable way to our
network graph, as this might introduce a privacy leak. Here, we
therefore avoid applying such updates to our network graph.

12 months agoAllow to verify channel updates without applying them
Elias Rohrer [Fri, 13 Oct 2023 09:30:15 +0000 (11:30 +0200)]
Allow to verify channel updates without applying them

We introduce a new `NetworkGraph::verify_channel_update` method that
allows to check whether an update would be applied by `update_channel`.

12 months agoMerge pull request #2578 from jkczyz/2023-09-offer-utilities
Matt Corallo [Thu, 19 Oct 2023 02:41:48 +0000 (02:41 +0000)]
Merge pull request #2578 from jkczyz/2023-09-offer-utilities

BOLT 12 Offers utilities

12 months agoImpl ToSocketAddrs for SocketAddress
slanesuke [Sat, 30 Sep 2023 23:05:00 +0000 (17:05 -0600)]
Impl ToSocketAddrs for SocketAddress

12 months agoClean up peel_onion name, parameters, and docs
Jeffrey Czyz [Wed, 18 Oct 2023 23:24:07 +0000 (18:24 -0500)]
Clean up peel_onion name, parameters, and docs

For consistency with other functions and doc cleanliness.

12 months agoInclude a one-hop blinded path in Offer and Refund
Jeffrey Czyz [Fri, 3 Mar 2023 15:38:45 +0000 (09:38 -0600)]
Include a one-hop blinded path in Offer and Refund

While this doesn't add much privacy over not including any blinded
paths, it allows us to exercise code for receiving on blinded paths.

12 months agoStateless offer and refund builder utilities
Jeffrey Czyz [Tue, 14 Feb 2023 03:54:37 +0000 (21:54 -0600)]
Stateless offer and refund builder utilities

Add utility functions to ChannelManager for creating OfferBuilder,
and RefundBuilder such that derived keys are used for the signing
pubkey and payer id, respectively. This allows for stateless
verification of any InvoiceRequest and Invoice messages.

Later, blinded paths can be included in the returned builders.

Also tracks future payments using the given PaymentId such that the
corresponding Invoice is paid only once.

12 months agoAwait for invoices using an absolute expiry
Jeffrey Czyz [Tue, 17 Oct 2023 14:59:39 +0000 (09:59 -0500)]
Await for invoices using an absolute expiry

PendingOutboundPayment::AwaitingInvoice counts the number of timer ticks
that have passed awaiting a Bolt12Invoice for an InvoiceRequest. When a
constant INVOICE_REQUEST_TIMEOUT_TICKS has passed, the payment is
forgotten. However, this mechanism is insufficient for the Refund
scenario, where the Refund's expiration should be used instead.

Change AwaitingInvoice to store an absolute expiry instead. When
removing stale payments, pass the `SystemTime` in `std` and the highest
block time minus two hours in `no-std`.

12 months agoRemove outdated docs
Jeffrey Czyz [Tue, 17 Oct 2023 15:47:48 +0000 (10:47 -0500)]
Remove outdated docs

12 months agoAllow sending onion messages to 1-hop blinded path
Jeffrey Czyz [Mon, 11 Sep 2023 22:40:43 +0000 (17:40 -0500)]
Allow sending onion messages to 1-hop blinded path

This allows for specifying the introduction node as the message
recipient.

12 months agoEnqueue onion messages in handlers
Jeffrey Czyz [Thu, 14 Sep 2023 02:19:50 +0000 (21:19 -0500)]
Enqueue onion messages in handlers

When constructing onion messages to send initially (opposed to replying
to one from a handler), the user must construct an OnionMessagePath first
before calling OnionMessener::send_onion_message. Additionally, having a
reference to OnionMessener isn't always desirable. For instance, in an
upcoming commit, ChannelManager will implement OffersMessageHandler,
which OnionMessenger needs a reference to. If ChannelManager had a
reference to OnionMessenger, too, there would be a dependency cycle.

Instead, modify OffersMessageHandler and CustomOnionMessageHandler's
interfaces to include a method for releasing pending onion messages.
That way, ChannelManager may, for instance, construct and enqueue an
InvoiceRequest for sending without needing a reference to
OnionMessenger.

Additionally, OnionMessenger has responsibility for path finding just as
it does when replying to messages from a handler. It performs this when
extracting messages from the handlers before returning the next message
to send to a peer.

12 months agoGeneralize CustomOnionMessageContents trait
Jeffrey Czyz [Tue, 19 Sep 2023 17:35:13 +0000 (12:35 -0500)]
Generalize CustomOnionMessageContents trait

Rename CustomOnionMessageContents to OnionMessageContents and use it as
a trait bound on messages passed to OnionMessenger methods. This allows
using the trait in an upcoming commit as a bound on the contents of
PendingOnionMessage.

Also, make ParsedOnionMessageContent implement OnionMessageContents so
that Payload can be bounded by OnionMessageContents directly, but used
when either reading a ParsedOnionMessageContent or writing a specific
type of OnionMessageContents (e.g., OffersMessage).

12 months agoRename OnionMessageContents
Jeffrey Czyz [Tue, 19 Sep 2023 15:59:53 +0000 (10:59 -0500)]
Rename OnionMessageContents

In preparation for needing the name OnionMessageContents for a trait to
bound methods, rename it to ParsedOnionMessageContents. In the next
commit, it's use will be limited to reading only, and the new trait will
be a bound on method parameters instead.

12 months agoGeneralize respond_with_onion_message
Jeffrey Czyz [Wed, 13 Sep 2023 19:13:05 +0000 (14:13 -0500)]
Generalize respond_with_onion_message

OnionMessenger can send onion message responses from its handlers using
respond_with_onion_message, which finds a path to the destination and
enqueues the response for sending. Generalize this as it can be used not
only for responses but for initial sends as well.

12 months agoImport msgs::OnionMessage
Jeffrey Czyz [Fri, 13 Oct 2023 16:12:57 +0000 (11:12 -0500)]
Import msgs::OnionMessage

12 months agoClean up onion messenger parameters and docs
Jeffrey Czyz [Thu, 5 Oct 2023 01:23:34 +0000 (15:23 -1000)]
Clean up onion messenger parameters and docs

12 months agoAvoid overloading introduction_node_id
Jeffrey Czyz [Tue, 12 Sep 2023 22:18:49 +0000 (17:18 -0500)]
Avoid overloading introduction_node_id

12 months agoRemove OnionMessageProvider
Jeffrey Czyz [Tue, 12 Sep 2023 21:57:15 +0000 (16:57 -0500)]
Remove OnionMessageProvider

OnionMessageProvider is a super-trait of OnionMessageHandler, but they
don't need to be used separately. Additionally, the former is misplaced
in the events module. Remove OnionMessageProvider and add it's only
method, next_onion_message_for_peer, into OnionMessageHandler.

12 months agoUpdate OnionMessenger docs for Offers
Jeffrey Czyz [Tue, 12 Sep 2023 21:14:16 +0000 (16:14 -0500)]
Update OnionMessenger docs for Offers

12 months agoMerge pull request #2663 from TheBlueMatt/2023-10-peer-race-send-discon
Matt Corallo [Wed, 18 Oct 2023 21:54:57 +0000 (21:54 +0000)]
Merge pull request #2663 from TheBlueMatt/2023-10-peer-race-send-discon

Fix race between outbound messages and peer disconnection

12 months agoMerge pull request #2658 from wpaulino/bogus-channel-reestablish
Matt Corallo [Wed, 18 Oct 2023 21:47:31 +0000 (21:47 +0000)]
Merge pull request #2658 from wpaulino/bogus-channel-reestablish

Send bogus ChannelReestablish for unknown channels

12 months agoMerge pull request #2599 from Evanfeenstra/peel-onion
Matt Corallo [Wed, 18 Oct 2023 21:11:52 +0000 (21:11 +0000)]
Merge pull request #2599 from Evanfeenstra/peel-onion

public static peel_onion method on OnionMessenger

12 months agoFix race between outbound messages and peer disconnection 2023-10-peer-race-send-discon
Matt Corallo [Wed, 18 Oct 2023 15:22:26 +0000 (15:22 +0000)]
Fix race between outbound messages and peer disconnection

Previously, outbound messages held in `process_events` could race
with peer disconnection, allowing a message intended for a peer
before disconnection to be sent to the same peer after
disconnection.

The fix is simple - hold the peers read lock while we fetch
pending messages from peers (as we disconnect with the write lock).

12 months agoRelease short_to_chan_info lock throughout forwarding_channel_not_found
Wilmer Paulino [Mon, 16 Oct 2023 20:29:06 +0000 (13:29 -0700)]
Release short_to_chan_info lock throughout forwarding_channel_not_found

Not doing so caused a lock order inversion between the locks
`ChannelManager::best_block` and `ChannelManager::short_to_chan_info`
after the addition of `test_trigger_lnd_force_close`.

It turns out that we were holding the `short_to_chan_info` for longer
than needed when processing HTLC forwards. We only need to acquire it to
quickly obtain channel info, and there aren't any other locks within
`forwarding_channel_not_found` that depend on it being held.

12 months agoDisconnect peer when force closing a funded channel with an error
Wilmer Paulino [Fri, 13 Oct 2023 16:28:35 +0000 (09:28 -0700)]
Disconnect peer when force closing a funded channel with an error

We do this to ensure that the counterparty will always broadcast their
latest state when we broadcast ours. Usually, they'll do this with the
`error` message alone, but if they don't receive it or ignore it, then
we'll force them to broadcast by sending them a bogus
`channel_reestablish` upon reconnecting. Note that this doesn't apply to
unfunded channels as there is no commitment transaction to broadcast.

12 months agoSend bogus ChannelReestablish for unknown channels
Wilmer Paulino [Wed, 11 Oct 2023 16:42:05 +0000 (09:42 -0700)]
Send bogus ChannelReestablish for unknown channels

Unfortunately, lnd doesn't force close on errors
(https://github.com/lightningnetwork/lnd/blob/abb1e3463f3a83bbb843d5c399869dbe930ad94f/htlcswitch/link.go#L2119).
One of the few ways to get an lnd counterparty to force close is by
replicating what they do when restoring static channel backups (SCBs).
They send an invalid `ChannelReestablish` with `0` commitment numbers
and an invalid `your_last_per_commitment_secret`.

Since we received a `ChannelReestablish` for a channel that doesn't
exist, we can assume it's likely the channel closed from our point of
view, but it remains open on the counterparty's side. By sending this
bogus `ChannelReestablish` message now as a response to theirs, we
trigger them to force close broadcasting their latest state. If the
closing transaction from our point of view remains unconfirmed, it'll
enter a race with the counterparty's to-be-broadcast latest commitment
transaction.

12 months agopublic static peel_onion method on OnionMessenger
Evan Feenstra [Tue, 26 Sep 2023 18:29:16 +0000 (11:29 -0700)]
public static peel_onion method on OnionMessenger

12 months agoMerge pull request #2662 from jkczyz/2023-10-chain-hash
valentinewallace [Tue, 17 Oct 2023 15:05:45 +0000 (11:05 -0400)]
Merge pull request #2662 from jkczyz/2023-10-chain-hash

Use `ChainHash` instead of `BlockHash` as applicable

12 months agoMerge pull request #2665 from TheBlueMatt/2023-10-scanable-test-logs
valentinewallace [Mon, 16 Oct 2023 19:59:32 +0000 (15:59 -0400)]
Merge pull request #2665 from TheBlueMatt/2023-10-scanable-test-logs

Make test log lines somewhat more eye-scannable

12 months agoUse ChainHash instead of BlockHash as applicable
Jeffrey Czyz [Fri, 13 Oct 2023 22:01:19 +0000 (17:01 -0500)]
Use ChainHash instead of BlockHash as applicable

ChainHash is more appropriate for places where an arbitrary BlockHash is
not desirable. This type was introduced in later versions of the bitcoin
crate, thus BlockHash was used instead.

Using ChainHash also makes it easier to check if ChannelManager is
compatible with an Offer.

12 months agoMerge pull request #2664 from TheBlueMatt/2023-10-ci-disk-usage
Matt Corallo [Mon, 16 Oct 2023 14:56:34 +0000 (14:56 +0000)]
Merge pull request #2664 from TheBlueMatt/2023-10-ci-disk-usage

Reduce disk usage in CI

12 months agoMerge pull request #2625 from tnull/2023-09-moar-tests-n-fixes
Matt Corallo [Sun, 15 Oct 2023 20:18:56 +0000 (20:18 +0000)]
Merge pull request #2625 from tnull/2023-09-moar-tests-n-fixes

Improve test coverage of #2575 router fixes

12 months agoMake test log lines somewhat more eye-scannable 2023-10-scanable-test-logs
Matt Corallo [Thu, 12 Oct 2023 21:15:49 +0000 (21:15 +0000)]
Make test log lines somewhat more eye-scannable

When running tests, our log output should be reasonably readable
by developers, but currently it repeats the module twice (via the
module and file name), and then starts the log line at a variable
location.

Instead, we only print the module and then align the start of the
log lines so that the output is much more scannable.

12 months agoReduce disk usage in CI 2023-10-ci-disk-usage
Matt Corallo [Sat, 14 Oct 2023 18:41:34 +0000 (18:41 +0000)]
Reduce disk usage in CI

Recently github appears to have reduced the available free disk
space in actions runs, causing CI to fail with out of space errors.
Here we simply run `cargo clean` a few times in CI to reduce our
disk usage somewhat.

12 months agoMerge pull request #2655 from TheBlueMatt/2023-10-no-test-net
Matt Corallo [Sat, 14 Oct 2023 02:10:31 +0000 (02:10 +0000)]
Merge pull request #2655 from TheBlueMatt/2023-10-no-test-net

Replace `lightning-block-sync` test that depended on `foo.com`

12 months agoMerge pull request #2639 from vladimirfomene/fix-final-incorrect-cltv
valentinewallace [Fri, 13 Oct 2023 21:12:11 +0000 (17:12 -0400)]
Merge pull request #2639 from vladimirfomene/fix-final-incorrect-cltv

Fix final incorrect cltv

12 months agofix: use the update_add_htlc's cltv_expiry for comparison
Vladimir Fomene [Mon, 2 Oct 2023 19:05:42 +0000 (22:05 +0300)]
fix: use the update_add_htlc's cltv_expiry for comparison

As noted in BOLT 4, we should be using the update_add_htlc's cltv_expiry,
not the CLTV expiry set by the sender in the onion for this comparison.
See here: https://github.com/lightning/bolts/blob/4dcc377209509b13cf89a4b91fde7d478f5b46d8/04-onion-routing.md?plain=1#L334

12 months agoReplace `lightning-block-sync` test that depended on `foo.com` 2023-10-no-test-net
Matt Corallo [Mon, 9 Oct 2023 03:24:54 +0000 (03:24 +0000)]
Replace `lightning-block-sync` test that depended on `foo.com`

Our tests should generally not rely on internet access, and should
not rely on the behavior of any given remote server. However, one
of the `endpoint_tests` in `lightning-block-sync::http` relied on
`foo.com` resolving to a single socket address, which both might
change in the future and makes our tests fail without internet.

12 months agoMerge pull request #2650 from TheBlueMatt/2023-10-make-clippy-shut-up
Matt Corallo [Thu, 12 Oct 2023 20:44:46 +0000 (20:44 +0000)]
Merge pull request #2650 from TheBlueMatt/2023-10-make-clippy-shut-up

Make clippy shut up about `PartialOrd` and `Ord` both impl'd

12 months agoMerge pull request #2657 from Fedeparma74/fix-close-channel-deadlock
Matt Corallo [Thu, 12 Oct 2023 18:16:02 +0000 (18:16 +0000)]
Merge pull request #2657 from Fedeparma74/fix-close-channel-deadlock

Fix deadlock when closing an unavailable channel

12 months agoFix deadlock when closing an unavailable channel
Fedeparma74 [Wed, 11 Oct 2023 08:50:28 +0000 (10:50 +0200)]
Fix deadlock when closing an unavailable channel

12 months agoMerge pull request #2652 from tnull/2023-10-deref-achannelmanager
Elias Rohrer [Sun, 8 Oct 2023 07:11:19 +0000 (09:11 +0200)]
Merge pull request #2652 from tnull/2023-10-deref-achannelmanager

12 months agoMerge pull request #2651 from G8XSU/rm-same-feerate-log
valentinewallace [Fri, 6 Oct 2023 23:18:32 +0000 (13:18 -1000)]
Merge pull request #2651 from G8XSU/rm-same-feerate-log

Remove log for not changing feerate when it was equal

12 months agoMerge pull request #2649 from benthecarman/display-outpoint
Matt Corallo [Fri, 6 Oct 2023 19:00:01 +0000 (19:00 +0000)]
Merge pull request #2649 from benthecarman/display-outpoint

Impl Display for Outpoint

12 months agoHave methods take `AChannelManager` as `Deref::Target`
Elias Rohrer [Fri, 6 Oct 2023 17:30:45 +0000 (07:30 -1000)]
Have methods take `AChannelManager` as `Deref::Target`

12 months agoImpl Display for Outpoint
benthecarman [Thu, 5 Oct 2023 19:38:49 +0000 (14:38 -0500)]
Impl Display for Outpoint

12 months agoRemove log for not changing feerate when it was equal
Gursharan Singh [Fri, 6 Oct 2023 01:18:10 +0000 (15:18 -1000)]
Remove log for not changing feerate when it was equal

Log is not required in this case and creates unnecessary log lines at
trace level.

12 months agoMake clippy shut up about `PartialOrd` and `Ord` both impl'd 2023-10-make-clippy-shut-up
Matt Corallo [Thu, 5 Oct 2023 23:57:08 +0000 (23:57 +0000)]
Make clippy shut up about `PartialOrd` and `Ord` both impl'd

Clippy gets mad that we have an implementation of `ParialOrd` and
`Ord` separately, even though both are identical. Making
`ParitalOrd` call `Ord` makes clippy shut up.

12 months agoMerge pull request #2640 from sr-gi/20231003-expose-from-be-bytes
Matt Corallo [Thu, 5 Oct 2023 23:45:59 +0000 (23:45 +0000)]
Merge pull request #2640 from sr-gi/20231003-expose-from-be-bytes

Makes Features::from_be_bytes public

12 months agoMakes Features::from_be_bytes public
Sergi Delgado Segura [Tue, 3 Oct 2023 12:46:18 +0000 (08:46 -0400)]
Makes Features::from_be_bytes public

Downstream projects building Feature<T> are most likely doing so with a
big-endian byte array, however only `from_le_bytes` is exposed.

12 months agoMerge pull request #2645 from TheBlueMatt/2023-10-changelog-dates v0.0.117
Matt Corallo [Wed, 4 Oct 2023 02:16:04 +0000 (02:16 +0000)]
Merge pull request #2645 from TheBlueMatt/2023-10-changelog-dates

Set the timestamp for and provide diff stats for 0.0.117 CHANGELOG

12 months agoSet the timestamp for and provide diff stats for 0.0.117 CHANGELOG 2023-10-changelog-dates
Matt Corallo [Tue, 3 Oct 2023 23:56:58 +0000 (23:56 +0000)]
Set the timestamp for and provide diff stats for 0.0.117 CHANGELOG

12 months agoMerge pull request #2620 from TheBlueMatt/2023-09-cut-0.0.117
Matt Corallo [Tue, 3 Oct 2023 23:16:59 +0000 (23:16 +0000)]
Merge pull request #2620 from TheBlueMatt/2023-09-cut-0.0.117

Cut 0.0.117

12 months agoBump crate versions to 0.0.117/invoice 0.25 2023-09-cut-0.0.117
Matt Corallo [Tue, 3 Oct 2023 17:15:45 +0000 (17:15 +0000)]
Bump crate versions to 0.0.117/invoice 0.25

12 months agoAdd 0.0.117 release notes
Matt Corallo [Fri, 29 Sep 2023 02:50:27 +0000 (02:50 +0000)]
Add 0.0.117 release notes

12 months agoMerge pull request #2631 from TheBlueMatt/2023-09-pm-no-refs-reqd
Matt Corallo [Tue, 3 Oct 2023 17:12:19 +0000 (17:12 +0000)]
Merge pull request #2631 from TheBlueMatt/2023-09-pm-no-refs-reqd

Fix `Simple*PeerManager` to not require refs to the `UtxoLookup`

12 months agoMerge pull request #2634 from TheBlueMatt/2023-09-claimable-unwrap
Matt Corallo [Tue, 3 Oct 2023 17:12:08 +0000 (17:12 +0000)]
Merge pull request #2634 from TheBlueMatt/2023-09-claimable-unwrap

Avoid unwrap'ing `channel_parameters` in to_counterparty signing

12 months agoClean up at least some lifetimes on `SimpleRefPeerManager` 2023-09-pm-no-refs-reqd
Matt Corallo [Tue, 3 Oct 2023 03:52:53 +0000 (03:52 +0000)]
Clean up at least some lifetimes on `SimpleRefPeerManager`

Rather than simply a, b, c, d...we at least use names for a few
things, also splitting the reused 'f lifetime.

12 months agoNote when we're allowed to unwrap channel parameters in docs 2023-09-claimable-unwrap
Matt Corallo [Tue, 3 Oct 2023 04:32:40 +0000 (04:32 +0000)]
Note when we're allowed to unwrap channel parameters in docs

This further documents the parameter-fetching utilities in
`InMemorySigner` to hopefully make them more robust against future
spurious `unwrap`s.

12 months agoMake `InMemorySigner` parameter-fetching utilities return `Option`s
Matt Corallo [Tue, 3 Oct 2023 04:12:28 +0000 (04:12 +0000)]
Make `InMemorySigner` parameter-fetching utilities return `Option`s

In the previous commit we fixed a bug where we were spuriously
(indirectly) `unwrap`ing the `channel_parameters` in
`InMemorySigner`. Here we make such bugs much less likely in the
future by having the utilities which do the `unwrap`ing internally
return `Option`s instead.

This makes the `unwrap`s clear at the callsite.

12 months agoMerge pull request #2595 from TheBlueMatt/2023-09-117-bindings-part1
Matt Corallo [Tue, 3 Oct 2023 03:56:46 +0000 (03:56 +0000)]
Merge pull request #2595 from TheBlueMatt/2023-09-117-bindings-part1

Various cleanups to make bindings generation simpler

12 months agoMerge pull request #2632 from TheBlueMatt/2023-09-writeable-rwlock
Matt Corallo [Tue, 3 Oct 2023 03:45:03 +0000 (03:45 +0000)]
Merge pull request #2632 from TheBlueMatt/2023-09-writeable-rwlock

Implement Readable/Writeable for RwLock wrappers

12 months agoMerge pull request #2633 from TheBlueMatt/2023-09-expose-onion-parse
Jeffrey Czyz [Tue, 3 Oct 2023 01:16:13 +0000 (20:16 -0500)]
Merge pull request #2633 from TheBlueMatt/2023-09-expose-onion-parse

Expose `parse_onion_address` publicly in `no-std`

13 months agoAvoid unwrap'ing `channel_parameters` in to_counterparty signing
Matt Corallo [Sun, 1 Oct 2023 00:15:22 +0000 (00:15 +0000)]
Avoid unwrap'ing `channel_parameters` in to_counterparty signing

Previously, `StaticPaymentOutputDescriptor`s did not include
`channel_parameters` for the signer. As a result, when going to
spend old `StaticPaymentOutputDescriptor`s,
`InMemorySigner::sign_counterparty_payment_input` may be called
with `channel_parameters` set to `None`. This should be fine, but
in fa2a2efef47b5da48ac7a239f3d8a835a7f28164 we started relying on
it (indirectly via `channel_features`) for signing. This caused an
`unwrap` when spending old output descriptors.

This is fixed here by simply avoiding the unwrap and assuming old
`StaticPaymentOutputDescriptor`s represent non-anchor channels.

13 months agoRemove unused `mem::drop` which drops a reference 2023-09-117-bindings-part1
Matt Corallo [Sun, 1 Oct 2023 00:00:37 +0000 (00:00 +0000)]
Remove unused `mem::drop` which drops a reference

13 months agoFix new unused variable warning in `test_utils.rs`
Matt Corallo [Sat, 30 Sep 2023 17:47:45 +0000 (17:47 +0000)]
Fix new unused variable warning in `test_utils.rs`

13 months agoUse `crate::prelude::*` to load `Vec`, rather than `crate::Vec`
Matt Corallo [Thu, 28 Sep 2023 02:45:00 +0000 (02:45 +0000)]
Use `crate::prelude::*` to load `Vec`, rather than `crate::Vec`

This is kinda dumb, but the bindings get confused when referring
to `Vec` absolutely in a `use` statement, and there's no reason not
to load our prelude everywhere.

13 months agoDrop various bounds on types passed to `MonitorUpdatingPersister`
Matt Corallo [Wed, 27 Sep 2023 23:02:50 +0000 (23:02 +0000)]
Drop various bounds on types passed to `MonitorUpdatingPersister`

The new `MonitorUpdatingPersister` has a few redundant type bounds
(re-specified on functions after having been specified on the
struct itself), which we remove here.

Further, it requires a `Deref<FeeEstimator>` which is `Clone`able.
This is generally fine in rust, but annoying in bindings, so we
simply elide it in favor if a `&Deref<FeeEstimator>`.

13 months agoMake `create_onion_message` a freestanding function
Matt Corallo [Mon, 25 Sep 2023 22:10:27 +0000 (22:10 +0000)]
Make `create_onion_message` a freestanding function

The new `create_onion_message` function in `OnionMessenger` is hard
to handle - it has various generic requirements indirectly via the
struct, but they're not bounded by any of the method parameters.
Thus, you can't simply call `OnionMessenger::create_onion_message`,
as various bounds are not specified.

Instead, we move it to a freestanding function so that it can be
called directly without explicitly setting bounds.

13 months agoMark `AChannelManager` no-export
Matt Corallo [Mon, 25 Sep 2023 22:14:04 +0000 (22:14 +0000)]
Mark `AChannelManager` no-export

The trait itself has no purpose for bindings, as all structs are
concretized anyway. Further, the bindings have specific handling
for generic bounding traits like this.

13 months agoMark `SpendableOutputDescriptor::to_psbt_input` as no-export
Matt Corallo [Sun, 24 Sep 2023 23:41:10 +0000 (23:41 +0000)]
Mark `SpendableOutputDescriptor::to_psbt_input` as no-export

Its honestly likely not all that useful as its not materially
interoperable with other PSBT libraries. Instead, users should
simply fetch the full PSBT and use the inputs from it as they see
fit.

13 months agoDrop unnecessary crate:: prefix when accessing `bitcoin` in macro
Matt Corallo [Sat, 23 Sep 2023 23:34:33 +0000 (23:34 +0000)]
Drop unnecessary crate:: prefix when accessing `bitcoin` in macro

Unexported macros don't need to use the `$crate` prefix.

13 months agoAvoid ref to a `Vec` when accessing custom onion TLVs
Matt Corallo [Fri, 22 Sep 2023 01:44:57 +0000 (01:44 +0000)]
Avoid ref to a `Vec` when accessing custom onion TLVs

The bindings can't easily return a reference to a `Vec`, so we
instead split the implementation into vec/slice depending on the
`c_bindings` flag.

13 months agoAvoid blanket impls in bindings builds
Matt Corallo [Mon, 25 Sep 2023 01:05:45 +0000 (01:05 +0000)]
Avoid blanket impls in bindings builds

The C bindings implements `Deref` for all traits, so having a
blanket `Deref` implementation ends up conflicting with this.

13 months agoSimplify score bounding with a unified type
Matt Corallo [Sun, 24 Sep 2023 23:59:13 +0000 (23:59 +0000)]
Simplify score bounding with a unified type

In a few places we require a unified scorer, which implements both
`ScoreLookUp` and `ScoreUpdate`. Rather than double-bounding (which
the bindings generator can't handle directly), we use a top-level
`Score` trait which requires both and is implemented for all
implementers of both supertraits.

13 months agoRemove unnecessary bounds in scoring
Matt Corallo [Thu, 21 Sep 2023 22:54:14 +0000 (22:54 +0000)]
Remove unnecessary bounds in scoring

In our scoring logic we have a handful of unnecessary bounds,
leading to extra diff in the bindings branch when those bounds have
to be removed as well as a few cases where bindings generation
simply gets confused.

Here we remove a number of bounds across the scoring traits and
impls, cleaning things up and simplifying bindings changes.

13 months agoUse `Default::default()` to construct `()` as score-updating param
Matt Corallo [Thu, 21 Sep 2023 22:22:18 +0000 (22:22 +0000)]
Use `Default::default()` to construct `()` as score-updating param

In 6b0d94a3029f74de3a7542cbba0d48c2f7e5866b we switched most tests
to `Default::default()` for scoring parameters passed to
route-fetching. Here we do the same for the scoring parameters when
passed to score-updating.

13 months agoExpose `parse_onion_address` publicly in `no-std` 2023-09-expose-onion-parse
Matt Corallo [Sat, 30 Sep 2023 18:05:10 +0000 (18:05 +0000)]
Expose `parse_onion_address` publicly in `no-std`

The reason for having a separate `parse_onion_address` from
`FromStr` is to have an onion parsing function in `no-std`, but
when we added it we forgot to make it public. We do this here, as
well as fix a few compilation warnings in `no-std`.

13 months agoSwitch `Simple*ChannelManager` locks around `Score` to `RwLock` 2023-09-writeable-rwlock
Matt Corallo [Sat, 30 Sep 2023 17:40:42 +0000 (17:40 +0000)]
Switch `Simple*ChannelManager` locks around `Score` to `RwLock`

This switches the locks used around `ProbabilisticScorer` in
`Simple*ChannelManager` type aliases to `RwLock`.

13 months agoFix `Simple*PeerManager` to not require refs to the `UtxoLookup`
Matt Corallo [Sat, 30 Sep 2023 17:32:28 +0000 (17:32 +0000)]
Fix `Simple*PeerManager` to not require refs to the `UtxoLookup`

`UtxoLookup` doesn't strictly need to be referenced from the
`PeerManager`, and in fact the new `GossipVerifier` in
`lightning-block-sync` requires itself to be owned by the
`PeerManager` (for circular type reasons).

This allows us to use `lightning-block-sync`'s `GossipVerifier`
with `SimpleArcPeerManager` in ldk-sample.

13 months agoImplement `Readable`/`Writeable` for `RwLock` wrappers
Matt Corallo [Sat, 30 Sep 2023 17:35:21 +0000 (17:35 +0000)]
Implement `Readable`/`Writeable` for `RwLock` wrappers

We now support separate R/W locks in `LockableScore`, which allow
us to do routefinding in parallel, however in order to support
`WriteableScore` for such users we need to implement `Writeable`
for `RwLock` wrappers around `Writeable` types, which we do here.