]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
15 months agoAdd ChannelShutdownState to ChannelDetails
henghonglee [Tue, 27 Jun 2023 16:54:15 +0000 (00:54 +0800)]
Add ChannelShutdownState to ChannelDetails

This commit adds the state of channel shutdown to channeldetails

16 months agoMerge pull request #2384 from jkczyz/2023-06-message-router
Matt Corallo [Sun, 2 Jul 2023 20:11:18 +0000 (20:11 +0000)]
Merge pull request #2384 from jkczyz/2023-06-message-router

Define a default `MessageRouter` implementation

16 months agoMerge pull request #2375 from TonyGiorgio/remove-doc-future-anchor-support
Matt Corallo [Sun, 2 Jul 2023 20:10:10 +0000 (20:10 +0000)]
Merge pull request #2375 from TonyGiorgio/remove-doc-future-anchor-support

Remove doc specifying future anchor support

16 months agoDefine a default MessageRouter implementation
Jeffrey Czyz [Sun, 25 Jun 2023 19:26:17 +0000 (14:26 -0500)]
Define a default MessageRouter implementation

Otherwise, users need to define one when using "Simple" type aliases.

16 months agoMerge pull request #2386 from TheBlueMatt/2023-06-macos-msrv
Wilmer Paulino [Fri, 30 Jun 2023 14:12:00 +0000 (07:12 -0700)]
Merge pull request #2386 from TheBlueMatt/2023-06-macos-msrv

Fix 1.54- builds with the `backtrace` feature due to MSRV breakage

16 months agoFix 1.54- builds with the `backtrace` feature due to MSRV breakage 2023-06-macos-msrv
Matt Corallo [Fri, 30 Jun 2023 03:10:29 +0000 (03:10 +0000)]
Fix 1.54- builds with the `backtrace` feature due to MSRV breakage

The test-only `backtrace` feature broke on rustc prior to 1.55.

16 months agoClarify event doc specifying anchor support
Tony Giorgio [Sun, 25 Jun 2023 02:20:50 +0000 (21:20 -0500)]
Clarify event doc specifying anchor support

16 months agoMerge pull request #2322 from andrei-21/fix/instant-overflow
Matt Corallo [Thu, 29 Jun 2023 21:05:39 +0000 (21:05 +0000)]
Merge pull request #2322 from andrei-21/fix/instant-overflow

16 months agoMerge pull request #2372 from wpaulino/channelmanager-new-highest-seen-timestamp
Matt Corallo [Thu, 29 Jun 2023 04:15:46 +0000 (04:15 +0000)]
Merge pull request #2372 from wpaulino/channelmanager-new-highest-seen-timestamp

Require best block timestamp within ChannelManager::new

16 months agoUse `MonotonicTime` as `Instant` shifted by 10 years forward
Andrei [Thu, 29 Jun 2023 00:00:00 +0000 (00:00 +0000)]
Use `MonotonicTime` as `Instant` shifted by 10 years forward

Such implementation allows `MonotonicTime` to go backward up to 10
years on all platforms. On some platforms (e.g. iOS) `Instant` is
represented as `u64` of nanoseconds since the boot of the system.
Obviously such implementation does not allow to go backward before the
time of the boot.

Co-authored-by: Andrei <andrei.i@posteo.de>
Co-authored-by: Jeffrey Czyz <jkczyz@gmail.com>
16 months agoRequire best block timestamp within ChannelManager::new
Wilmer Paulino [Thu, 22 Jun 2023 22:19:15 +0000 (15:19 -0700)]
Require best block timestamp within ChannelManager::new

This ensures freshly initialized nodes can proceed to create unexpired
invoices without a call to `best_block_updated`, since an invoice's
expiration delta is applied to `highest_seen_timestamp`.

16 months agoMerge pull request #2374 from arik-so/2023-06-build-warning-fixes
Matt Corallo [Tue, 27 Jun 2023 14:32:25 +0000 (14:32 +0000)]
Merge pull request #2374 from arik-so/2023-06-build-warning-fixes

Fix build warnings

16 months agoFix clone warning on nightly.
Arik Sosman [Mon, 26 Jun 2023 14:17:18 +0000 (10:17 -0400)]
Fix clone warning on nightly.

16 months agoRemove redundant `mut`s in router.rs.
Arik Sosman [Sat, 24 Jun 2023 17:54:14 +0000 (10:54 -0700)]
Remove redundant `mut`s in router.rs.

16 months agoFix warning about deserialization marker.
Arik Sosman [Sat, 24 Jun 2023 05:35:14 +0000 (22:35 -0700)]
Fix warning about deserialization marker.

Specifically, the legacy deserialization
prevention marker variable was not being
read.

16 months agoFix build warning about HTLCSource::dummy().
Arik Sosman [Sat, 24 Jun 2023 05:34:14 +0000 (22:34 -0700)]
Fix build warning about HTLCSource::dummy().

16 months agoFix build warning about public_from_secret_hex.
Arik Sosman [Sat, 24 Jun 2023 05:33:55 +0000 (22:33 -0700)]
Fix build warning about public_from_secret_hex.

16 months agoMerge pull request #2368 from wpaulino/inbound-anchors-manual-acceptance v0.0.116-alpha1
Matt Corallo [Sat, 24 Jun 2023 15:44:46 +0000 (15:44 +0000)]
Merge pull request #2368 from wpaulino/inbound-anchors-manual-acceptance

Require inbound channels with anchor outputs to be accepted manually

16 months agoMerge pull request #2367 from wpaulino/remove-anchors-flag
Wilmer Paulino [Fri, 23 Jun 2023 23:17:48 +0000 (16:17 -0700)]
Merge pull request #2367 from wpaulino/remove-anchors-flag

Remove anchors config flag

16 months agoRequire inbound channels with anchor outputs to be accepted manually
Wilmer Paulino [Tue, 20 Jun 2023 19:14:48 +0000 (12:14 -0700)]
Require inbound channels with anchor outputs to be accepted manually

Since the use of channels with anchor outputs requires a reserve of
onchain funds to handle channel force closures, it would be
irresponsible to allow a node to accept inbound channel without first
consulting such reserves. To allow users to do so, we require such
channels be manually accepted.

16 months agoMerge pull request #2373 from TheBlueMatt/2023-06-116-alpha
Matt Corallo [Fri, 23 Jun 2023 22:38:47 +0000 (22:38 +0000)]
Merge pull request #2373 from TheBlueMatt/2023-06-116-alpha

16 months agoSupport manual inbound acceptance in channel creation test utils
Wilmer Paulino [Tue, 20 Jun 2023 19:11:44 +0000 (12:11 -0700)]
Support manual inbound acceptance in channel creation test utils

16 months agoMerge pull request #2362 from TheBlueMatt/2023-06-unblocked-mons-in-manager
Matt Corallo [Fri, 23 Jun 2023 20:46:26 +0000 (20:46 +0000)]
Merge pull request #2362 from TheBlueMatt/2023-06-unblocked-mons-in-manager

Move in-flight ChannelMonitorUpdates to ChannelManager

16 months agoRemove anchors config flag
Wilmer Paulino [Tue, 20 Jun 2023 18:29:00 +0000 (11:29 -0700)]
Remove anchors config flag

Now that all of the core functionality for anchor outputs has landed,
we're ready to remove the config flag that was temporarily hiding it
from our API.

16 months agoBump versions to LDK 116-alpha1 and invoice 24.0-alpha1 2023-06-116-alpha
Matt Corallo [Fri, 23 Jun 2023 19:42:08 +0000 (19:42 +0000)]
Bump versions to LDK 116-alpha1 and invoice 24.0-alpha1

16 months agoRename `Channel::pending_monitor_updates` to `blocked` 2023-06-unblocked-mons-in-manager
Matt Corallo [Tue, 20 Jun 2023 23:27:55 +0000 (23:27 +0000)]
Rename `Channel::pending_monitor_updates` to `blocked`

To differentiate between in-flight pending completion and blocked
updates.

16 months agoRename Channel's latest-monitor-update fetch method for clarity
Matt Corallo [Tue, 20 Jun 2023 02:16:03 +0000 (02:16 +0000)]
Rename Channel's latest-monitor-update fetch method for clarity

`Channel::get_latest_complete_monitor_update_id` no longer refers
to complete updates, but rather ones which were passed to the
`ChannelManager` and which the `CHannel` no longer knows about.
Thus, we rename it `get_latest_unblocked_monitor_update_id`.

16 months agoRemove the `blocked` param on `ChannelMonitorUpdates` in `Channel`
Matt Corallo [Mon, 19 Jun 2023 06:31:43 +0000 (06:31 +0000)]
Remove the `blocked` param on `ChannelMonitorUpdates` in `Channel`

Now that all `ChannelMonitorUpdate`s stored in `Channel` are
blocked we don't need a bool to track it.

16 months agoDrop the now-unused update_id param to monitor update macros
Matt Corallo [Mon, 19 Jun 2023 05:35:34 +0000 (05:35 +0000)]
Drop the now-unused update_id param to monitor update macros

16 months agoMove in-flight `ChannelMonitorUpdate`s to `ChannelManager`
Matt Corallo [Mon, 19 Jun 2023 06:26:39 +0000 (06:26 +0000)]
Move in-flight `ChannelMonitorUpdate`s to `ChannelManager`

Because `ChannelMonitorUpdate`s can be generated for a
channel which is already closed, and must still be tracked
through their completion, storing them in a `Channel`
doesn't make sense - we'd have to have a redundant place to
put them post-closure and handle both storage locations
equivalently.

Instead, here, we move to storing in-flight
`ChannelMonitorUpdate`s to the `ChannelManager`, leaving
blocked `ChannelMonitorUpdate`s in the `Channel` as they
were.

16 months agoMerge pull request #2361 from arik-so/2023-06-anchor-channel-type-features
Matt Corallo [Fri, 23 Jun 2023 19:12:15 +0000 (19:12 +0000)]
Merge pull request #2361 from arik-so/2023-06-anchor-channel-type-features

Replace `opt_anchors` with `ChannelTypeFeatures`

16 months agoSync `ChannelTransactionParameters` features to `ChannelContext`.
Arik Sosman [Wed, 21 Jun 2023 23:41:09 +0000 (16:41 -0700)]
Sync `ChannelTransactionParameters` features to `ChannelContext`.

16 months agoVerify channel type features for decoding.
Arik Sosman [Tue, 20 Jun 2023 20:17:28 +0000 (13:17 -0700)]
Verify channel type features for decoding.

16 months agoReplace `opt_anchors` with `ChannelTypeFeatures`
Arik Sosman [Mon, 19 Jun 2023 17:30:34 +0000 (10:30 -0700)]
Replace `opt_anchors` with `ChannelTypeFeatures`

This change modifies six structs that were keeping
track of anchors features with an `opt_anchors` field,
as well as another field keeping track of nonzero-fee-
anchor-support.

16 months agoMerge pull request #2365 from TheBlueMatt/2023-06-fix-fuzz-dep
valentinewallace [Thu, 22 Jun 2023 22:49:09 +0000 (18:49 -0400)]
Merge pull request #2365 from TheBlueMatt/2023-06-fix-fuzz-dep

Ensure we build if a downstream crate sets `--cfg=fuzzing`

16 months agoMethod for `ChannelTypeFeatures` serialization compatibility.
Arik Sosman [Wed, 21 Jun 2023 23:12:45 +0000 (16:12 -0700)]
Method for `ChannelTypeFeatures` serialization compatibility.

16 months agoDefine `ChannelTypeFeatures` methods for anchors logic.
Arik Sosman [Mon, 19 Jun 2023 17:28:36 +0000 (10:28 -0700)]
Define `ChannelTypeFeatures` methods for anchors logic.

Specifically, introduce a new constructor for an anchors-
supporting feature set, as well as methods that will
maintain forwards-compatible deserialization in older
versions.

16 months agoReference-rhs bitwise operations for features.
Arik Sosman [Thu, 22 Jun 2023 21:14:02 +0000 (14:14 -0700)]
Reference-rhs bitwise operations for features.

16 months agoDocument nonzero anchors in features module.
Arik Sosman [Thu, 22 Jun 2023 22:22:40 +0000 (15:22 -0700)]
Document nonzero anchors in features module.

16 months agoIntroduce nonzero fee anchors feature.
Arik Sosman [Mon, 19 Jun 2023 17:25:01 +0000 (10:25 -0700)]
Introduce nonzero fee anchors feature.

16 months agoSimplify cases in `handle_new_monitor_update` macro
Matt Corallo [Sun, 18 Jun 2023 23:56:16 +0000 (23:56 +0000)]
Simplify cases in `handle_new_monitor_update` macro

By giving up on a tiny bit of parallelism and tweaking the return
types, we can make the `handle_new_monitor_update` macro a bit
clearer - now the only cases where its called after a monitor was
updated was when the monitor was initially committed.

16 months agoDrop the now-unused `push_blockable_mon_update`
Matt Corallo [Sun, 18 Jun 2023 23:18:34 +0000 (23:18 +0000)]
Drop the now-unused `push_blockable_mon_update`

16 months agoMove most `handle_new_monitor_update` calls to pass the update
Matt Corallo [Sun, 18 Jun 2023 21:55:30 +0000 (21:55 +0000)]
Move most `handle_new_monitor_update` calls to pass the update

Most of the calls to the `handle_new_monitor_update` macro had the
exact same pattern - calling `update_monitor` followed by the
macro. Given that common pattern will grow to first pushing the
new monitor onto an in-flight set and then calling `update_monitor`
unifying the pattern into a single macro now avoids more code churn
in the coming commits.

16 months agoReturn owned `ChannelMonitorUpdate`s from `Channel`
Matt Corallo [Sun, 18 Jun 2023 21:18:03 +0000 (21:18 +0000)]
Return owned `ChannelMonitorUpdate`s from `Channel`

In the coming commits we'll move to storing in-flight
`ChannelMonitorUpdate`s in the `ChannelManager` rather in the
`Channel` (which will then only retain `ChannelMonitorUpdate`s
which have not yet been released/are blocked.

This will simplify handling of pending `ChannelMonitorUpdate` after
a channel has closed by not having to move them into the
`ChannelManager`.

16 months agoMerge pull request #2319 from valentinewallace/2023-05-forward-less-than-onion
Elias Rohrer [Wed, 21 Jun 2023 07:25:07 +0000 (09:25 +0200)]
Merge pull request #2319 from valentinewallace/2023-05-forward-less-than-onion

Allow forwarding less than the amount in the onion

16 months agoEnsure we build if a downstream crate sets `--cfg=fuzzing` 2023-06-fix-fuzz-dep
Matt Corallo [Tue, 20 Jun 2023 17:14:21 +0000 (17:14 +0000)]
Ensure we build if a downstream crate sets `--cfg=fuzzing`

Downstream crates building fur fuzzing will usually set
`--cfg=fuzzing` as a side-effect of the Rust fuzzing tooling. Thus,
we should ensure we build without failure in such cases.

We do this here by simply relying on the `_test_utils` feature,
rather than conditionally-compiling in modules based on the
`fuzzing` flag.

16 months agoDocument on claim events that amount_msat may be > invoice amount
Valentine Wallace [Thu, 15 Jun 2023 19:59:04 +0000 (15:59 -0400)]
Document on claim events that amount_msat may be > invoice amount

16 months agoCheck UpdateAddHTLC::skimmed_fee_msat on receive
Valentine Wallace [Wed, 24 May 2023 23:21:21 +0000 (19:21 -0400)]
Check UpdateAddHTLC::skimmed_fee_msat on receive

Make sure the penultimate hop took the amount of fee that they claimed to take.
Without checking this TLV, we're heavily relying on the receiving wallet code
to correctly implement logic to calculate that that the fee is as expected.

16 months agoSet UpdateAddHTLC::skimmed_fee_msat on forward
Valentine Wallace [Wed, 24 May 2023 23:15:25 +0000 (19:15 -0400)]
Set UpdateAddHTLC::skimmed_fee_msat on forward

So the receiver can verify it and approve underpaying HTLCs (see
ChannelConfig::accept_underpaying_htlcs).

16 months agoPersist update_add sender skimmed fee in Channel
Valentine Wallace [Fri, 9 Jun 2023 11:42:07 +0000 (13:42 +0200)]
Persist update_add sender skimmed fee in Channel

16 months agoTrack the sender's skimmed fee in UpdateAddHTLC
Valentine Wallace [Thu, 25 May 2023 13:57:16 +0000 (09:57 -0400)]
Track the sender's skimmed fee in UpdateAddHTLC

16 months agoAllow receiving less than the onion claims to pay
Valentine Wallace [Wed, 24 May 2023 15:53:05 +0000 (11:53 -0400)]
Allow receiving less than the onion claims to pay

Useful for penultimate hops in routes to take an extra fee, if for example they
opened a JIT channel to the payee and want them to help bear the channel open
cost.

16 months agoAdd PaymentClaimable::counterparty_skimmed_fee_msat
Valentine Wallace [Tue, 16 May 2023 20:14:40 +0000 (16:14 -0400)]
Add PaymentClaimable::counterparty_skimmed_fee_msat

See its docs

16 months agoPersist counterparty skimmed fee in ClaimableHTLC
Valentine Wallace [Thu, 15 Jun 2023 16:54:58 +0000 (12:54 -0400)]
Persist counterparty skimmed fee in ClaimableHTLC

Used to get an accurate skimmed fee in the resulting PaymentClaimable event.

16 months agoSet extra skimmed fee on intercepted forward
Valentine Wallace [Thu, 15 Jun 2023 16:37:21 +0000 (12:37 -0400)]
Set extra skimmed fee on intercepted forward

Receivers need to use this value to verify incoming payments if
ChannelConfig::accept_underpaying_htlcs is set.

16 months agoAdd config knob for accepting underpaying HTLCs
Valentine Wallace [Tue, 16 May 2023 18:18:47 +0000 (14:18 -0400)]
Add config knob for accepting underpaying HTLCs

See ChannelConfig::accept_underpaying_htlcs

16 months agoMove next hop packet pubkey calculation to outside channel lock
Valentine Wallace [Tue, 20 Jun 2023 21:40:12 +0000 (17:40 -0400)]
Move next hop packet pubkey calculation to outside channel lock

16 months agoMove PendingHTLCStatus construction inside channel lock
Valentine Wallace [Tue, 16 May 2023 20:14:40 +0000 (16:14 -0400)]
Move PendingHTLCStatus construction inside channel lock

We need the channel lock for constructing a pending HTLC's status because we
need to know if the channel accepts underpaying HTLCs in upcoming commits.

16 months agoMerge pull request #2120 from valentinewallace/2023-03-blinded-pathfinding
Matt Corallo [Tue, 20 Jun 2023 15:51:59 +0000 (15:51 +0000)]
Merge pull request #2120 from valentinewallace/2023-03-blinded-pathfinding

16 months agoMerge pull request #2089 from wpaulino/bump-transaction-event-handler
Matt Corallo [Mon, 19 Jun 2023 22:45:54 +0000 (22:45 +0000)]
Merge pull request #2089 from wpaulino/bump-transaction-event-handler

Add BumpTransaction event handler

16 months agoProvide a default CoinSelectionSource implementation via a new trait
Wilmer Paulino [Thu, 27 Apr 2023 00:44:49 +0000 (17:44 -0700)]
Provide a default CoinSelectionSource implementation via a new trait

Certain users may not care how their UTXOs are selected, or their wallet
may not expose enough controls to fully implement the
`CoinSelectionSource` trait. As an alternative, we introduce another
trait `WalletSource` they could opt to implement instead, which is much
simpler as it just returns the set of confirmed UTXOs that may be used.
This trait implementation is then consumed into a wrapper `Wallet` which
implements the `CoinSelectionSource` trait using a "smallest
above-dust-after-spend first" coin selection algorithm.

16 months agoAdd BumpTransaction event handler
Wilmer Paulino [Thu, 27 Apr 2023 00:42:35 +0000 (17:42 -0700)]
Add BumpTransaction event handler

This allows users to bump their commitments and HTLC transactions
without having to worry about all the little details to do so. Instead,
we'll just require that they implement the `CoinSelectionSource` trait
over their wallet/UTXO source, granting the event handler permission to
spend confirmed UTXOs for the transactions it'll produce.

While the event handler should in most cases produce valid transactions,
assuming the provided confirmed UTXOs are valid, it may not produce
relayable transactions due to not satisfying certain Replace-By-Fee
(RBF) mempool policy requirements. Some of these require that the
replacement transactions have a higher feerate and absolute fee than the
conflicting transactions it aims to replace. To make sure we adhere to
these requirements, we'd have to persist some state for all transactions
the event handler has produced, greatly increasing its complexity. While
we may consider implementing so in the future, we choose to go with a
simple initial version that relies on the OnchainTxHandler's bumping
frequency. For each new bumping attempt, the OnchainTxHandler proposes a
25% feerate increase to ensure transactions can propagate under
constrained mempool circumstances.

16 months agoExpose ClaimId for each claim bump in BumpTransactionEvent
Wilmer Paulino [Thu, 11 May 2023 20:50:46 +0000 (13:50 -0700)]
Expose ClaimId for each claim bump in BumpTransactionEvent

16 months agoExpose existing PackageID to API and rename to ClaimId
Wilmer Paulino [Thu, 11 May 2023 20:49:00 +0000 (13:49 -0700)]
Expose existing PackageID to API and rename to ClaimId

In a future commit, we plan to expand `BumpTransactionEvent` variants to
include the unique identifier assigned to pending output claims by the
`OnchainTxHandler` when a commitment is broadcast/confirmed. This
requires making it public in our API. We also choose to rename it to
`ClaimId` for the benefit of users, as the previous `PackageID` term
could be interpreted to be the ID of a BIP-331 transaction package.

16 months agoChange package ID computation for HTLC claims on anchor channels
Wilmer Paulino [Thu, 11 May 2023 22:39:13 +0000 (15:39 -0700)]
Change package ID computation for HTLC claims on anchor channels

While the previous way of computing the identifier was safe, it wouldn't
have been in certain scenarios if we considered splitting aggregated
packages. While this type of splitting has yet to be implemented, it may
come in the near future. To ensure we're prepared to handle such, we
opt to instead commit to all of the HTLCs to claim in the request.

16 months agoImplement routing to blinded payment paths
Valentine Wallace [Wed, 14 Jun 2023 22:14:29 +0000 (18:14 -0400)]
Implement routing to blinded payment paths

Sending to them is still disallowed, for now.

16 months agoRouter: clean up Path construction
Valentine Wallace [Thu, 15 Jun 2023 13:48:31 +0000 (09:48 -0400)]
Router: clean up Path construction

We don't need to collect a vec of Results anymore.

16 months agoAdd CandidateRouteHop::Blinded and ::OneHopBlinded variant
Valentine Wallace [Tue, 13 Jun 2023 23:37:53 +0000 (19:37 -0400)]
Add CandidateRouteHop::Blinded and ::OneHopBlinded variant

It's unclear what values 1-hop blinded paths should set their BlindedPayInfos
to, because those values are meant to refer to the fees/cltv delta on the path
*between* the intro node and the destination. We zero out these values in the
new variant's methods so they don't mess with path finding/construction.

16 months agoUpdate CandidateRouteHop::short_channel_id to be optional
Valentine Wallace [Tue, 13 Jun 2023 23:36:12 +0000 (19:36 -0400)]
Update CandidateRouteHop::short_channel_id to be optional

16 months agoMerge pull request #2351 from TheBlueMatt/2023-04-remove-legacy-recv
Matt Corallo [Sat, 17 Jun 2023 18:38:25 +0000 (18:38 +0000)]
Merge pull request #2351 from TheBlueMatt/2023-04-remove-legacy-recv

Drop `create_inbound_payment*_legacy` breaking downgrade to 0.0.103

16 months agoRouting: accommodate for blinded paths in used liquidity tracking
Valentine Wallace [Tue, 13 Jun 2023 21:47:36 +0000 (17:47 -0400)]
Routing: accommodate for blinded paths in used liquidity tracking

16 months agoReplace max_channel_saturation_power_of_half hardcode with const
Valentine Wallace [Wed, 14 Jun 2023 22:36:48 +0000 (18:36 -0400)]
Replace max_channel_saturation_power_of_half hardcode with const

16 months agoAdd utils for creating blinded PaymentParameters
Valentine Wallace [Fri, 19 May 2023 21:37:58 +0000 (17:37 -0400)]
Add utils for creating blinded PaymentParameters

16 months agoReverse (BlindedPath, BlindedPayInfo) tuple order in offers invoice.
Valentine Wallace [Fri, 16 Jun 2023 13:45:04 +0000 (09:45 -0400)]
Reverse (BlindedPath, BlindedPayInfo) tuple order in offers invoice.

To make it uniform with PaymentParameters' Payee::Blinded::route_hints.

16 months agoMerge pull request #2077 from dunxen/2023-02-splitchannelstate
Matt Corallo [Fri, 16 Jun 2023 06:01:10 +0000 (06:01 +0000)]
Merge pull request #2077 from dunxen/2023-02-splitchannelstate

Split prefunded `Channel` into `Inbound`/`Outbound` channels

16 months agoRename `inbound_is_awaiting_accept()` to `is_awaiting_accept()`
Duncan Dean [Tue, 13 Jun 2023 15:17:59 +0000 (17:17 +0200)]
Rename `inbound_is_awaiting_accept()` to `is_awaiting_accept()`

16 months agoRename `InboundV1Channel::new_from_req` to `InboundV1Channel::new`
Duncan Dean [Wed, 7 Jun 2023 18:49:26 +0000 (20:49 +0200)]
Rename `InboundV1Channel::new_from_req` to `InboundV1Channel::new`

16 months agoMove inbound channel methods into `InboundV1Channel`'s impl
Duncan Dean [Wed, 7 Jun 2023 16:14:59 +0000 (18:14 +0200)]
Move inbound channel methods into `InboundV1Channel`'s impl

16 months agoMove outbound channel methods into `OutboundV1Channel`'s impl
Duncan Dean [Wed, 7 Jun 2023 16:09:23 +0000 (18:09 +0200)]
Move outbound channel methods into `OutboundV1Channel`'s impl

16 months agoCreate and use methods for counting channels
Duncan Dean [Wed, 7 Jun 2023 17:52:21 +0000 (19:52 +0200)]
Create and use methods for counting channels

This commit also adds two new maps to `PeerState` for keeping track
of `OutboundV1Channel`s and `InboundV1Channel`s so that further
commits are a bit easier to review.

16 months agoRefactor channel map update macros for use with `ChannelContext`
Duncan Dean [Wed, 7 Jun 2023 17:22:59 +0000 (19:22 +0200)]
Refactor channel map update macros for use with `ChannelContext`

16 months agoMove `Channel::force_shutdown` to `ChannelContext` impl
Duncan Dean [Tue, 13 Jun 2023 15:31:28 +0000 (17:31 +0200)]
Move `Channel::force_shutdown` to `ChannelContext` impl

16 months agoMove inbound channel constructor into `InboundV1Channel` impl
Duncan Dean [Wed, 7 Jun 2023 14:17:18 +0000 (16:17 +0200)]
Move inbound channel constructor into `InboundV1Channel` impl

16 months agoMove outbound channel constructor into `OutboundV1Channel` impl
Duncan Dean [Wed, 7 Jun 2023 14:09:35 +0000 (16:09 +0200)]
Move outbound channel constructor into `OutboundV1Channel` impl

16 months agoIntroduce `InboundV1Channel` & `OutboundV1Channel`
Duncan Dean [Wed, 5 Apr 2023 11:43:02 +0000 (13:43 +0200)]
Introduce `InboundV1Channel` & `OutboundV1Channel`

16 months agoMove channel constants up
Duncan Dean [Thu, 30 Mar 2023 09:17:32 +0000 (11:17 +0200)]
Move channel constants up

16 months agoMake `ChannelManager::issue_channel_close_events` take a `ChannelContext`
Duncan Dean [Tue, 13 Jun 2023 14:43:43 +0000 (16:43 +0200)]
Make `ChannelManager::issue_channel_close_events` take a `ChannelContext`

16 months agoConvert `ChannelDetails::from_channel` to `ChannelDetails::from_channel_context`
Duncan Dean [Wed, 7 Jun 2023 09:03:46 +0000 (11:03 +0200)]
Convert `ChannelDetails::from_channel` to `ChannelDetails::from_channel_context`

This rename and refactor is so that we can get channel details from a
`ChannelContext` which is a common object to all channels.

16 months agoMove `Channel::get_available_balances` to `ChannelContext` impl
Duncan Dean [Tue, 13 Jun 2023 14:40:49 +0000 (16:40 +0200)]
Move `Channel::get_available_balances` to `ChannelContext` impl

16 months agoMove `Channel::next_*_commit_tx_fee_msat` methods to `ChannelContext` impl
Duncan Dean [Tue, 13 Jun 2023 11:54:40 +0000 (13:54 +0200)]
Move `Channel::next_*_commit_tx_fee_msat` methods to `ChannelContext` impl

16 months agoMove `Channel::commit_tx_fee_msat` to file-level utilities
Duncan Dean [Tue, 13 Jun 2023 11:26:50 +0000 (13:26 +0200)]
Move `Channel::commit_tx_fee_msat` to file-level utilities

16 months agoMove `Channel::get_*_pending_htlc_stats` to `ChannelContext` impl
Duncan Dean [Tue, 13 Jun 2023 11:19:02 +0000 (13:19 +0200)]
Move `Channel::get_*_pending_htlc_stats` to `ChannelContext` impl

16 months agoPrepare some methods for upcoming moves to `ChannelContext`
Duncan Dean [Tue, 13 Jun 2023 10:34:36 +0000 (12:34 +0200)]
Prepare some methods for upcoming moves to `ChannelContext`

To reduce interleaving in commits, we introduce a `context` variable
in methods to be moved in upcoming commits so there is minimal change
with the moves.

16 months agoMove `Channel::get_feerate_sat_per_1000_weight` and other methods
Duncan Dean [Wed, 7 Jun 2023 10:33:41 +0000 (12:33 +0200)]
Move `Channel::get_feerate_sat_per_1000_weight` and other methods

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields to be updated for things to
compile, but these should be quite clear.

This commit also uses the `context` field where needed for compilation
and tests to pass due to the above change.

f s/tarcontext.get_/target_/

16 months agoMove `Channel::build_holder_transaction_keys` and some other methods
Duncan Dean [Wed, 7 Jun 2023 10:26:53 +0000 (12:26 +0200)]
Move `Channel::build_holder_transaction_keys` and some other methods

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields need to be updated for things to
compile, but these should be quite clear.

This commit also uses the `context` field where needed for compilation
and tests to pass due to the above change.

16 months agoMove `Channel::build_commitment_transaction` to `ChannelContext` impl
Duncan Dean [Wed, 7 Jun 2023 10:20:25 +0000 (12:20 +0200)]
Move `Channel::build_commitment_transaction` to `ChannelContext` impl

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields need to be updated for things to
compile, but these should be quite clear.

This commit also uses the `context` field where needed for compilation
and tests to pass due to the above change.

16 months agoMove `Channel::channel_id` and some other methods to `ChannelContext` impl
Duncan Dean [Wed, 7 Jun 2023 10:15:24 +0000 (12:15 +0200)]
Move `Channel::channel_id` and some other methods to `ChannelContext` impl

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields need to be updated for things to
compile, but these should be quite clear.

This commit also uses the `context` field where needed for compilation
and tests to pass due to the above change.

16 months agoMove `Channel::get_update_time_counter` and some other methods
Duncan Dean [Wed, 7 Jun 2023 09:57:35 +0000 (11:57 +0200)]
Move `Channel::get_update_time_counter` and some other methods

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields need to be updated for things to
compile, but these should be quite clear.

This commit also uses these methods through the `context` field where
needed for compilation and tests to pass due to the above change.

16 months agoMove `Channel::opt_anchors` to `ChannelContext` impl & move some util fns
Duncan Dean [Wed, 7 Jun 2023 09:29:44 +0000 (11:29 +0200)]
Move `Channel::opt_anchors` to `ChannelContext` impl & move some util fns

This is one of a series of commits to make sure methods are moved by
chunks so they are easily reviewable in diffs. Unfortunately they are
not purely move-only as fields need to be updated for things to
compile, but these should be quite clear.

16 months agoMove `Channel` fields into `ChannelContext` struct
Duncan Dean [Tue, 7 Mar 2023 19:56:01 +0000 (21:56 +0200)]
Move `Channel` fields into `ChannelContext` struct

This is a first step for simplifying the channel state and introducing
new unfunded channel types that hold similar state before being promoted
to funded channels.

Essentially, we want the outer `Channel` type (and upcoming channel types)
to wrap the context so we can apply typestate patterns to the that wrapper
while also deduplicating code for common state and other internal fields.