Wilmer Paulino [Tue, 11 Jul 2023 22:16:16 +0000 (15:16 -0700)]
Avoid yielding ChannelClose bump events with sufficient feerate
There's no need to yield such an event when the commitment transaction
already meets the target feerate on its own, so we can simply broadcast
it without an anchor child transaction. This may be a common occurrence
until we are less aggressive about feerate updates.
Wilmer Paulino [Tue, 11 Jul 2023 22:14:01 +0000 (15:14 -0700)]
Move feerate helpers to chain module
We plan to use these outside of the `bump_transaction` module in the
next commit, and they really should belong in the same module as
`FeeEstimator`.
Jeffrey Czyz [Fri, 14 Jul 2023 20:59:33 +0000 (15:59 -0500)]
Qualify the BOLT 11 invoice description type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 20:53:07 +0000 (15:53 -0500)]
Qualify the BOLT 11 invoice signature type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 19:41:58 +0000 (14:41 -0500)]
Qualify the BOLT 11 invoice features type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 01:56:30 +0000 (20:56 -0500)]
Qualify the BOLT 11 semantic error type
A previous commit qualified the BOLT 12 semantic error type. Qualify the
BOLT 11 semantic error type for consistency.
Jeffrey Czyz [Fri, 14 Jul 2023 01:49:02 +0000 (20:49 -0500)]
Qualify the BOLT 11 parse error type
A previous commit qualified the BOLT 12 parse error type. Qualify the
BOLT 11 parse error type for consistency.
Jeffrey Czyz [Fri, 14 Jul 2023 01:34:27 +0000 (20:34 -0500)]
Qualify the BOLT 11 raw invoice types
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Thu, 13 Jul 2023 22:22:26 +0000 (17:22 -0500)]
Qualify the BOLT 11 invoice type
A previous commit qualified the BOLT 12 invoice type. Qualify the BOLT
11 invoice type for consistency.
Jeffrey Czyz [Thu, 13 Jul 2023 21:28:55 +0000 (16:28 -0500)]
Qualify the BOLT 12 semantic error
To avoid a naming conflict in bindings with BOLT 11 semantic error,
qualify the BOLT 12 semantic error type.
Jeffrey Czyz [Thu, 13 Jul 2023 21:09:43 +0000 (16:09 -0500)]
Qualify the BOLT 12 parse error
To avoid a naming conflict in bindings with BOLT 11 parse error, qualify
the BOLT 12 parse error type.
Jeffrey Czyz [Thu, 13 Jul 2023 18:47:09 +0000 (13:47 -0500)]
Qualify the BOLT 12 unsigned invoice type
A previous commit qualified the BOLT 12 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Thu, 13 Jul 2023 18:32:40 +0000 (13:32 -0500)]
Qualify the BOLT 12 invoice type
To avoid a naming conflict in bindings with BOLT 11 invoices, qualify
the BOLT 12 invoice type.
Jeffrey Czyz [Fri, 14 Jul 2023 20:04:30 +0000 (15:04 -0500)]
Fix grammar in docs
Jeffrey Czyz [Fri, 14 Jul 2023 20:02:29 +0000 (15:02 -0500)]
Use rustc stable for check_commits
Otherwise, the compiler will panic when using 1.57 for upcoming commits.
Valentine Wallace [Thu, 23 Mar 2023 22:34:47 +0000 (18:34 -0400)]
Move pending forward htlc construction into method
In upcoming blinded paths work, this method will grow to handle blinded
forwards.
Matt Corallo [Wed, 12 Jul 2023 22:37:40 +0000 (22:37 +0000)]
Merge pull request #2391 from TheBlueMatt/2023-07-all-compl-actions
Handle pre-startup and closed-channel monitor update completion actions
Matt Corallo [Wed, 5 Jul 2023 17:06:19 +0000 (17:06 +0000)]
Add comment describing when a completion action can be discarded
In an older PR a reviewer had asked why the discarding of a channel
being blocked on another monitor update is okay if the blocked
channel has since closed. At the time, this was not actually okay -
the monitor updates in the channel weren't moved to the
`ChannelManager` on close so the whole pipeline was busted, but
with the changes in
4041f0899f86eaf6a0a4576a91918fa54026ac46 the
handling of channel closes with pending monitor updates is now
correct, and so is the existing code block.
Matt Corallo [Wed, 5 Jul 2023 02:15:42 +0000 (02:15 +0000)]
Run monitor update completion actions for pre-startup completion
If a `ChannelMonitorUpdate` completes being persisted, but the
`ChannelManager` isn't informed thereof (or isn't persisted) before
shutdown, on startup we may still have it listed as in-flight. When
we compare the available `ChannelMonitor` with the in-flight set,
we'll notice it completed and remove it, however this may leave
some post-update actions dangling which need to complete.
Here we handle this with a new `BackgroundEvent` indicating we need
to handle any post-update action(s) for a given channel.
Elias Rohrer [Wed, 12 Jul 2023 19:17:56 +0000 (21:17 +0200)]
Merge pull request #2393 from wpaulino/bump-transaction-event-handler-fixups
Bump transaction event handler fixups
Matt Corallo [Wed, 12 Jul 2023 16:12:11 +0000 (16:12 +0000)]
Merge pull request #2406 from tnull/2023-07-pin-serde
Pin `serde_json` in CI to fix MSRV builds
Elias Rohrer [Wed, 12 Jul 2023 09:28:42 +0000 (11:28 +0200)]
Pin `serde_json` in CI to fix MSRV
Unfortunately `serde_json` switched to use Rust edition 2021 with
version 1.0.101, i.e., has an MSRV of 1.56 now.
Wilmer Paulino [Wed, 5 Jul 2023 16:45:20 +0000 (09:45 -0700)]
Expose previous UTXO for anchor and HTLC inputs
This may be required by some wallets that rely on PSBTs internally to
create/sign transactions.
Wilmer Paulino [Wed, 5 Jul 2023 16:47:05 +0000 (09:47 -0700)]
Add transaction-related helpers to AnchorDescriptor
This provides a similar interface as `HTLCDescriptor` for users which
choose to implement their own bump transaction event handler.
Wilmer Paulino [Thu, 6 Jul 2023 17:05:34 +0000 (10:05 -0700)]
Provide missing post-derivation signer parameters
Users may expect these to be provided manually after derivation in the
event they need to perform any enforcement prior to signing.
Wilmer Paulino [Thu, 6 Jul 2023 17:04:50 +0000 (10:04 -0700)]
Cache HTLC per_commitment_point in descriptor
This allows us to obtain the HTLC input and output from its descriptor
without needing to derive the `per_commitment_point` through the signer.
Wilmer Paulino [Sun, 2 Jul 2023 20:45:26 +0000 (13:45 -0700)]
Expose CoinSelection struct members
These are meant to be provided by the user, so they need to be exposed
in the API.
Wilmer Paulino [Sun, 2 Jul 2023 20:44:53 +0000 (13:44 -0700)]
Accept BumpTransactionEvent in handle_event
There's no reason to accept the general `Event` enum.
Matt Corallo [Tue, 11 Jul 2023 19:58:34 +0000 (19:58 +0000)]
Merge pull request #2400 from TheBlueMatt/2023-07-kill-vec_type
Fix backwards compat for blocked_monitor_updates and finally kill `vec_type`
Matt Corallo [Mon, 10 Jul 2023 22:24:31 +0000 (22:24 +0000)]
Document some TLV write/read formats
While we don't want to publicly document these and support them for
downstream crates, documenting them internally is useful.
Matt Corallo [Fri, 7 Jul 2023 21:05:29 +0000 (21:05 +0000)]
Drop `vec_type` TLV handling entirely
Historically, we used `vec_type` for all TLV Vec reads/writes, but
it is asymmetric and thus somewhat confusing - on the write side it
always writes a TLV entry, even if there are zero elements. On the
read side, it happily accepts a missing TLV, providing a
zero-length vector.
In
85b573ddad70f3c5ee36e0992d587842af507a8d a new `optional_vec`
TLV format was added which was symmetric, but only supports
optional vecs.
Now that we've migrated entirely to the new `required_vec` TLV
type, we can entirely remove the awkward `vec_type`.
Matt Corallo [Fri, 7 Jul 2023 19:57:23 +0000 (19:57 +0000)]
Convert `channelmonitor` `vec_type` TLV writes to required/optional
* `HolderSignedTx::htlc_outputs` has always been written since it
was converted to TLVs in
86641ea68062388a01c99c6ed131f56477c8e4.
* `ChanelMonitorUpdateStep::*::htlc_outputs` have been written
since the enum was converted to TLVs in
86641ea68062388a01c99c6.
Elias Rohrer [Tue, 11 Jul 2023 07:31:37 +0000 (09:31 +0200)]
Merge pull request #2395 from wpaulino/phantom-deduped-forward-event
Force enqueue second forward event for phantom receives
Matt Corallo [Tue, 4 Jul 2023 15:13:32 +0000 (15:13 +0000)]
Handle monitor completion actions for closed channels
If a channel has been closed, there may still be some
`ChannelMonitorUpdate`(s) which are pending completion. These
in-flight updates may also be blocking another channel from letting
an update fly, e.g. for forwarded payments where the payment
preimage will be removed from the downstream channel after the
upstream channel has closed.
Luckily all the infrastructure to handle this case is already in
place - we just need to process the
`monitor_update_blocked_actions` for closed channels.
Wilmer Paulino [Mon, 10 Jul 2023 20:01:50 +0000 (13:01 -0700)]
Merge pull request #2369 from TheBlueMatt/2023-06-mon-event-less-race
Don't drop ChannelMonitor Events until they're processed
Matt Corallo [Tue, 20 Jun 2023 22:52:27 +0000 (22:52 +0000)]
Don't drop `ChannelMonitor` `Event`s until they're processed
We currently assume the owner of `ChannelMonitor`s won't persist
the `ChannelMonitor` while `Event`s are being processed. This is
fine, except (a) its generally hard to do so and (b) the
`ChainMonitor` doesn't even do this.
Thus, in rare cases, a user could begin processing events which
are, generated by connecting a transaction or a new best-block,
take some time to do so, and while doing so process a further chain
event, causing persistece. This could lose the event being
processed alltogether, which could lose the user funds.
This should be very rare, but may have been made slightly more
reachable with (a) the async event processing making it more
common to do networking in event handling, (b) the new future
generation in the `ChainMonitor`, which now wakes the
`background-processor` directly when chain actions happen on the
`ChainMonitor`.
Wilmer Paulino [Wed, 5 Jul 2023 20:29:12 +0000 (13:29 -0700)]
Handle new event processing logic when enqueuing forward event
This was a regression resulting from
f2453b7 since we now process events
in a loop until there aren't any left. Processing events is done in
batches and they are not removed until we're done processing each batch.
Since handling a `PendingHTLCsForwardable` event will call back into the
`ChannelManager`, we'll still see the original forwarding event not
removed. Phantom payments will need an additional forwarding event
before being claimed to make them look real by taking more time.
Wilmer Paulino [Mon, 10 Jul 2023 16:27:57 +0000 (09:27 -0700)]
Merge pull request #2364 from TheBlueMatt/2023-06-htlc-preimage-replay
Re-claim forwarded HTLCs on startup
Matt Corallo [Sat, 8 Jul 2023 22:04:06 +0000 (22:04 +0000)]
Merge pull request #2307 from benthecarman/verify-funcs
Add helper functions to verify node and channel annoucements
Matt Corallo [Sat, 8 Jul 2023 21:47:48 +0000 (21:47 +0000)]
Merge pull request #2042 from ffaex/add_fn
added fn_add_htlc
Matt Corallo [Sat, 8 Jul 2023 20:46:26 +0000 (20:46 +0000)]
Merge pull request #2396 from tnull/2023-07-fix-github-actions
Update CI to remove deprecated actions
benthecarman [Thu, 18 May 2023 20:43:56 +0000 (15:43 -0500)]
Add helper functions to verify node and channel annoucements
Right now the only real way to verify the node and channel
announcements is to call `update_node_from_announcement`/
`update_channel_from_announcement`. If you want to do some
processing before you add to your network graph then you need to
manually verify the signature. This adds some nice helper functions
to make it easier.
I tried to do the same for channel update but it did not seem as
easy so figured that is fine to punt on since I don't see many
people doing manual things with channel updates.
Matt Corallo [Fri, 7 Jul 2023 15:01:05 +0000 (15:01 +0000)]
Rename `ClosingMonitorUpdateRegeneratedOnStartup` to `Closed...`
Now that we also use the "Closing" `BackgroundEvent` for
already-closed channels we need to rename it and tweak the docs.
Matt Corallo [Thu, 4 May 2023 21:51:18 +0000 (21:51 +0000)]
Re-claim forwarded HTLCs on startup
Because `ChannelMonitorUpdate`s can complete asynchronously and
out-of-order now, a `commitment_signed` `ChannelMonitorUpdate` from
a downstream channel could complete prior to the preimage
`ChannelMonitorUpdate` on the upstream channel. In that case, we may
not get a `update_fulfill_htlc` replay on startup. Thus, we have to
ensure any payment preimages contained in that downstream update are
re-claimed on startup.
Here we do this during the existing walk of the `ChannelMonitor`
preimages for closed channels.
Matt Corallo [Sat, 8 Jul 2023 02:15:10 +0000 (02:15 +0000)]
Merge pull request #2354 from alecchendev/2023-06-bump-default-dust-exp
Bump dust exposure threshold
Matt Corallo [Fri, 7 Jul 2023 21:21:09 +0000 (21:21 +0000)]
Merge pull request #2347 from henghonglee/issue-2304
Expose whether a channel is closing in ChannelDetails
Matt Corallo [Fri, 7 Jul 2023 19:46:45 +0000 (19:46 +0000)]
Replace `vec_type` TLVs in channel/manager with required/optional
* `PhantomRouteHints::channels` has been written since the struct
was added in
410eb053656b1a4d3a6c506f1902e456a69324ac.
* `HTLCSource::path_hops` has been written since the struct was
converted to TLVs in
66784e32fe454e9a5b2080b85fc4d8816ac5e436.
Matt Corallo [Fri, 7 Jul 2023 19:27:15 +0000 (19:27 +0000)]
Convert routing `vec_type `TLV writes to other TLV types
* `BlindedTail::hops` has always been written since it was
introduced in
64c26c8a793f35c55076a2188912e92106900bab.
* `PaymentParameters::clear_hints` has always been written since
it was introduced as `Payee::route_hitns` in
46b68c517dba57bde5.
Matt Corallo [Fri, 7 Jul 2023 20:55:12 +0000 (20:55 +0000)]
Migrate `chan_utils` `vec_type` TLVs to required/optional
* `CommitmentTransaction::htlcs` has always been written since the
struct was converted to TLVs in
66784e32fe454e9a5b2080b85fc4d881.
* `HolderCommitmentTransaction::counterparty_htlc_sigs` have always
been written since the struct was converted to TLVs in
c8bc1b6d3de45aeddc755d0875b3dce8d86f79c1.
Matt Corallo [Fri, 7 Jul 2023 19:18:16 +0000 (19:18 +0000)]
Convert `Event` vec storage away from `vec_type`
* `PaymentPathFailed::path` was added without an optional compat
wrapper in
e5310dd5f0347fcaaf21b2742a1084f97fc84bd8.
* `PaymentPathSuccessful::path` has always been written since the
event was added in
2c4f16d5e39e6d4e90d1b9836cceaad11810fbaa.
* `Probe{Failed,Successful}::path` have always been written since
the events were added in
eb8bce0d161d5d6c135be5fd8c7ebe2699857a.
Matt Corallo [Fri, 7 Jul 2023 18:44:24 +0000 (18:44 +0000)]
Convert some `vec_type` TLVs to `required_vec`
This converts some required TLVs to `required_vec` which are, in
fact, required (and have been written forever).
* `HTLCFailReason` hasn't changed since many structs were converted
to TLVs in
66784e32fe454e9a5b2080b85fc4d8816ac5e436.
* `NodeInfo::channels` has been written since `NetworkGraph`
structs were converted to TLVs in
321b19c4d96a49b39b5583d0f12fea.
* Several test-only TLV writes were converted.
Matt Corallo [Fri, 7 Jul 2023 18:38:06 +0000 (18:38 +0000)]
Add a `required_vec` TLV deserialization type
Historically, we used `vec_type` for all TLV Vec reads/writes, but
it is asymmetric and thus somewhat confusing - on the write side it
always writes a TLV entry, even if there are zero elements. On the
read side, it happily accepts a missing TLV, providing a
zero-length vector.
In
85b573ddad70f3c5ee36e0992d587842af507a8d a new `optional_vec`
TLV format was added which was symmetric, but only supports
optional vecs. This adds the corresponding required form, always
writing a TLV and ensuring it is present.
Alec Chen [Thu, 6 Jul 2023 22:46:48 +0000 (17:46 -0500)]
Use multiplier in dust exposure threshold calculation
This commit makes use of the added enum to calculate the dust
exposure threshold based on the current fee rate. This also updates
tests to ensure it works as intended.
Alec Chen [Tue, 20 Jun 2023 22:33:43 +0000 (17:33 -0500)]
Send fee estimator through to `get_max_htlc_dust_exposure_threshold`
Alec Chen [Mon, 19 Jun 2023 02:53:43 +0000 (21:53 -0500)]
Add max dust exposure multiplier config knob
With fee rates rising dramatically in mid-April 2023, thresholds for
what is considered dust have risen, often exceeding our previous dust
exposure threshold of 5k sats. This causes all payments and HTLC
forwards between 5k sats and new dust thresholds to fail.
This commit changes our max dust exposure config knob from a fixed
upper limit to a `MaxDustHTLCExposure` enum with an additional variant
to allow setting our max dust exposure to a multiplier on the current
high priority feerate.
To remain backwards compatible we'll always write the fixed limit if
it's set, or its default value in its currently reserved TLV.
We also now write an odd TLV for the new enum, so that previous
versions can safely ignore it upon downgrading, while allowing us to
make use of the new type when it's written.
Matt Corallo [Fri, 7 Jul 2023 18:28:25 +0000 (18:28 +0000)]
Fix backwards compat for `blocked_monitor_updates`
In
1ce2beb77455a674888f3e3589723195eaa7b13c,
`Channel::blocked_monitor_updates` was moved to an even TLV to
ensure downgrades with vec entries are forbidden. However, the
serialized type remained `vec_type`, which is always written.
Instead, `optional_vec` must be used.
valentinewallace [Fri, 7 Jul 2023 15:45:55 +0000 (11:45 -0400)]
Merge pull request #2392 from TheBlueMatt/2023-07-async-mon-even-tlv
Move Channel's blocked monitor updates vec to an even TLV
valentinewallace [Fri, 7 Jul 2023 15:39:01 +0000 (11:39 -0400)]
Merge pull request #2399 from tnull/2023-07-expose-default-message-router
Expose `DefaultMessageRouter`
Elias Rohrer [Fri, 7 Jul 2023 13:08:01 +0000 (15:08 +0200)]
Expose `DefaultMessageRouter`
Matt Corallo [Thu, 6 Jul 2023 17:53:54 +0000 (17:53 +0000)]
Merge pull request #2383 from henghonglee/fix-dyn
Fix DefaultRouter type restrained to only MutexGuard
Elias Rohrer [Thu, 6 Jul 2023 12:30:31 +0000 (14:30 +0200)]
Update Github Actions to remove deprecated actions
henghonglee [Tue, 27 Jun 2023 16:54:15 +0000 (00:54 +0800)]
Add ChannelShutdownState to ChannelDetails
This commit adds the state of channel shutdown to channeldetails
Matt Corallo [Wed, 5 Jul 2023 17:20:48 +0000 (17:20 +0000)]
Move Channel's blocked monitor updates vec to an even TLV
In
9dfe42cf8681afc9c3f84e0c85a4e2a30c1156a8,
`ChannelMonitorUpdate`s were stored in `Channel` while they were
being processed. Because it was possible (though highly unlikely,
due to various locking likely blocking persistence) an update was
in-flight (even synchronously) when a `ChannelManager` was
persisted, the new updates were persisted via an odd TLV.
However, in
4041f0899f86eaf6a0a4576a91918fa54026ac46 these pending
monitor updates were moved to `ChannelManager`, with appropriate
handling there. Now the only `ChannelMonitorUpdate`s which are
stored in `Channel` are those which are explicitly blocked, which
requires the async pipeline.
Because we don't support async monitor update users downgrading to
0.0.115 or lower, we move to persisting them via an even TLV. As
the odd TLV storage has not yet been released, we can do so
trivially.
Fixes #2317.
henghonglee [Thu, 29 Jun 2023 02:41:38 +0000 (10:41 +0800)]
Fix DefaultRouter type restrained to only MutexGuard
Type of DerefMut for DefaultRouter was specialized to only MutexGuard.
It should be generic around RefMut and MutexGuard. This commit fixes that
Matt Corallo [Sun, 2 Jul 2023 20:11:18 +0000 (20:11 +0000)]
Merge pull request #2384 from jkczyz/2023-06-message-router
Define a default `MessageRouter` implementation
Matt Corallo [Sun, 2 Jul 2023 20:10:10 +0000 (20:10 +0000)]
Merge pull request #2375 from TonyGiorgio/remove-doc-future-anchor-support
Remove doc specifying future anchor support
Jeffrey Czyz [Sun, 25 Jun 2023 19:26:17 +0000 (14:26 -0500)]
Define a default MessageRouter implementation
Otherwise, users need to define one when using "Simple" type aliases.
Wilmer Paulino [Fri, 30 Jun 2023 14:12:00 +0000 (07:12 -0700)]
Merge pull request #2386 from TheBlueMatt/2023-06-macos-msrv
Fix 1.54- builds with the `backtrace` feature due to MSRV breakage
Matt Corallo [Fri, 30 Jun 2023 03:10:29 +0000 (03:10 +0000)]
Fix 1.54- builds with the `backtrace` feature due to MSRV breakage
The test-only `backtrace` feature broke on rustc prior to 1.55.
Tony Giorgio [Sun, 25 Jun 2023 02:20:50 +0000 (21:20 -0500)]
Clarify event doc specifying anchor support
Matt Corallo [Thu, 29 Jun 2023 21:05:39 +0000 (21:05 +0000)]
Merge pull request #2322 from andrei-21/fix/instant-overflow
Matt Corallo [Thu, 29 Jun 2023 04:15:46 +0000 (04:15 +0000)]
Merge pull request #2372 from wpaulino/channelmanager-new-highest-seen-timestamp
Require best block timestamp within ChannelManager::new
Andrei [Thu, 29 Jun 2023 00:00:00 +0000 (00:00 +0000)]
Use `MonotonicTime` as `Instant` shifted by 10 years forward
Such implementation allows `MonotonicTime` to go backward up to 10
years on all platforms. On some platforms (e.g. iOS) `Instant` is
represented as `u64` of nanoseconds since the boot of the system.
Obviously such implementation does not allow to go backward before the
time of the boot.
Co-authored-by: Andrei <andrei.i@posteo.de>
Co-authored-by: Jeffrey Czyz <jkczyz@gmail.com>
Wilmer Paulino [Thu, 22 Jun 2023 22:19:15 +0000 (15:19 -0700)]
Require best block timestamp within ChannelManager::new
This ensures freshly initialized nodes can proceed to create unexpired
invoices without a call to `best_block_updated`, since an invoice's
expiration delta is applied to `highest_seen_timestamp`.
Matt Corallo [Wed, 31 May 2023 22:51:49 +0000 (22:51 +0000)]
Some minor comment/doc tweaks in new monitor update blocking code
A few nits that came up in review to make the docs clearer, but not
anything super critical.
Matt Corallo [Tue, 27 Jun 2023 14:32:25 +0000 (14:32 +0000)]
Merge pull request #2374 from arik-so/2023-06-build-warning-fixes
Fix build warnings
Arik Sosman [Mon, 26 Jun 2023 14:17:18 +0000 (10:17 -0400)]
Fix clone warning on nightly.
Arik Sosman [Sat, 24 Jun 2023 17:54:14 +0000 (10:54 -0700)]
Remove redundant `mut`s in router.rs.
Arik Sosman [Sat, 24 Jun 2023 05:35:14 +0000 (22:35 -0700)]
Fix warning about deserialization marker.
Specifically, the legacy deserialization
prevention marker variable was not being
read.
Arik Sosman [Sat, 24 Jun 2023 05:34:14 +0000 (22:34 -0700)]
Fix build warning about HTLCSource::dummy().
Arik Sosman [Sat, 24 Jun 2023 05:33:55 +0000 (22:33 -0700)]
Fix build warning about public_from_secret_hex.
Matt Corallo [Sat, 24 Jun 2023 15:44:46 +0000 (15:44 +0000)]
Merge pull request #2368 from wpaulino/inbound-anchors-manual-acceptance
Require inbound channels with anchor outputs to be accepted manually
Wilmer Paulino [Fri, 23 Jun 2023 23:17:48 +0000 (16:17 -0700)]
Merge pull request #2367 from wpaulino/remove-anchors-flag
Remove anchors config flag
Wilmer Paulino [Tue, 20 Jun 2023 19:14:48 +0000 (12:14 -0700)]
Require inbound channels with anchor outputs to be accepted manually
Since the use of channels with anchor outputs requires a reserve of
onchain funds to handle channel force closures, it would be
irresponsible to allow a node to accept inbound channel without first
consulting such reserves. To allow users to do so, we require such
channels be manually accepted.
Matt Corallo [Fri, 23 Jun 2023 22:38:47 +0000 (22:38 +0000)]
Merge pull request #2373 from TheBlueMatt/2023-06-116-alpha
Wilmer Paulino [Tue, 20 Jun 2023 19:11:44 +0000 (12:11 -0700)]
Support manual inbound acceptance in channel creation test utils
Matt Corallo [Fri, 23 Jun 2023 20:46:26 +0000 (20:46 +0000)]
Merge pull request #2362 from TheBlueMatt/2023-06-unblocked-mons-in-manager
Move in-flight ChannelMonitorUpdates to ChannelManager
Wilmer Paulino [Tue, 20 Jun 2023 18:29:00 +0000 (11:29 -0700)]
Remove anchors config flag
Now that all of the core functionality for anchor outputs has landed,
we're ready to remove the config flag that was temporarily hiding it
from our API.
Matt Corallo [Fri, 23 Jun 2023 19:42:08 +0000 (19:42 +0000)]
Bump versions to LDK 116-alpha1 and invoice 24.0-alpha1
Matt Corallo [Tue, 20 Jun 2023 23:27:55 +0000 (23:27 +0000)]
Rename `Channel::pending_monitor_updates` to `blocked`
To differentiate between in-flight pending completion and blocked
updates.
Matt Corallo [Tue, 20 Jun 2023 02:16:03 +0000 (02:16 +0000)]
Rename Channel's latest-monitor-update fetch method for clarity
`Channel::get_latest_complete_monitor_update_id` no longer refers
to complete updates, but rather ones which were passed to the
`ChannelManager` and which the `CHannel` no longer knows about.
Thus, we rename it `get_latest_unblocked_monitor_update_id`.
Matt Corallo [Mon, 19 Jun 2023 06:31:43 +0000 (06:31 +0000)]
Remove the `blocked` param on `ChannelMonitorUpdates` in `Channel`
Now that all `ChannelMonitorUpdate`s stored in `Channel` are
blocked we don't need a bool to track it.
Matt Corallo [Mon, 19 Jun 2023 05:35:34 +0000 (05:35 +0000)]
Drop the now-unused update_id param to monitor update macros
Matt Corallo [Mon, 19 Jun 2023 06:26:39 +0000 (06:26 +0000)]
Move in-flight `ChannelMonitorUpdate`s to `ChannelManager`
Because `ChannelMonitorUpdate`s can be generated for a
channel which is already closed, and must still be tracked
through their completion, storing them in a `Channel`
doesn't make sense - we'd have to have a redundant place to
put them post-closure and handle both storage locations
equivalently.
Instead, here, we move to storing in-flight
`ChannelMonitorUpdate`s to the `ChannelManager`, leaving
blocked `ChannelMonitorUpdate`s in the `Channel` as they
were.
Matt Corallo [Fri, 23 Jun 2023 19:12:15 +0000 (19:12 +0000)]
Merge pull request #2361 from arik-so/2023-06-anchor-channel-type-features
Replace `opt_anchors` with `ChannelTypeFeatures`
Arik Sosman [Wed, 21 Jun 2023 23:41:09 +0000 (16:41 -0700)]
Sync `ChannelTransactionParameters` features to `ChannelContext`.
Arik Sosman [Tue, 20 Jun 2023 20:17:28 +0000 (13:17 -0700)]
Verify channel type features for decoding.
Arik Sosman [Mon, 19 Jun 2023 17:30:34 +0000 (10:30 -0700)]
Replace `opt_anchors` with `ChannelTypeFeatures`
This change modifies six structs that were keeping
track of anchors features with an `opt_anchors` field,
as well as another field keeping track of nonzero-fee-
anchor-support.
valentinewallace [Thu, 22 Jun 2023 22:49:09 +0000 (18:49 -0400)]
Merge pull request #2365 from TheBlueMatt/2023-06-fix-fuzz-dep
Ensure we build if a downstream crate sets `--cfg=fuzzing`
Arik Sosman [Wed, 21 Jun 2023 23:12:45 +0000 (16:12 -0700)]
Method for `ChannelTypeFeatures` serialization compatibility.