]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
13 months agoSwitch `Simple*ChannelManager` locks around `Score` to `RwLock` 2023-09-writeable-rwlock
Matt Corallo [Sat, 30 Sep 2023 17:40:42 +0000 (17:40 +0000)]
Switch `Simple*ChannelManager` locks around `Score` to `RwLock`

This switches the locks used around `ProbabilisticScorer` in
`Simple*ChannelManager` type aliases to `RwLock`.

13 months agoImplement `Readable`/`Writeable` for `RwLock` wrappers
Matt Corallo [Sat, 30 Sep 2023 17:35:21 +0000 (17:35 +0000)]
Implement `Readable`/`Writeable` for `RwLock` wrappers

We now support separate R/W locks in `LockableScore`, which allow
us to do routefinding in parallel, however in order to support
`WriteableScore` for such users we need to implement `Writeable`
for `RwLock` wrappers around `Writeable` types, which we do here.

13 months agoMerge pull request #2630 from TheBlueMatt/2023-09-117-rc1 v0.0.117-rc1
Matt Corallo [Sat, 30 Sep 2023 00:38:27 +0000 (00:38 +0000)]
Merge pull request #2630 from TheBlueMatt/2023-09-117-rc1

Bump crate versions to 0.0.117-rc1/invoice 0.25-rc1

13 months agoMerge pull request #2610 from wpaulino/missing-htlc-claim-balance
Matt Corallo [Fri, 29 Sep 2023 23:55:04 +0000 (23:55 +0000)]
Merge pull request #2610 from wpaulino/missing-htlc-claim-balance

Fix matching of second-stage HTLC claim in get_htlc_balance

13 months agoMerge pull request #2621 from G8XSU/dont-persist-erroneous-update
Matt Corallo [Fri, 29 Sep 2023 23:45:57 +0000 (23:45 +0000)]
Merge pull request #2621 from G8XSU/dont-persist-erroneous-update

Persist entire monitor if there is an error while applying monitor_update

13 months agoBump crate versions to 0.0.117-rc1/invoice 0.25-rc1 2023-09-117-rc1
Matt Corallo [Fri, 29 Sep 2023 23:39:18 +0000 (23:39 +0000)]
Bump crate versions to 0.0.117-rc1/invoice 0.25-rc1

13 months agoFix wrong node broadcaster in test_yield_anchors_events
Wilmer Paulino [Fri, 29 Sep 2023 23:00:35 +0000 (16:00 -0700)]
Fix wrong node broadcaster in test_yield_anchors_events

13 months agoAdd anchors coverage to test_revoked_counterparty_aggregated_claims
Wilmer Paulino [Tue, 26 Sep 2023 20:05:16 +0000 (13:05 -0700)]
Add anchors coverage to test_revoked_counterparty_aggregated_claims

13 months agoAdd anchors coverage to test_revoked_counterparty_htlc_tx_balances
Wilmer Paulino [Tue, 26 Sep 2023 18:59:12 +0000 (11:59 -0700)]
Add anchors coverage to test_revoked_counterparty_htlc_tx_balances

13 months agoAdd update_persisted_channel doc to indicate rare case for None update
Gursharan Singh [Fri, 29 Sep 2023 20:41:18 +0000 (13:41 -0700)]
Add update_persisted_channel doc to indicate rare case for None update

13 months agoPersist full monitor if there is an error while applying monitor_update
Gursharan Singh [Fri, 29 Sep 2023 03:30:53 +0000 (20:30 -0700)]
Persist full monitor if there is an error while applying monitor_update

Motivation: When there is an error while applying monitor_update to a
channel_monitor,  we don't want to persist a 'monitor_update' which
results in a failure to apply later while reading 'channel_monitor' with
updates from storage. Instead, we should persist the entire 'channel_monitor'
here.

13 months agoCorrectly mark chain_sync updates in test_utils
Gursharan Singh [Fri, 29 Sep 2023 04:18:47 +0000 (21:18 -0700)]
Correctly mark chain_sync updates in test_utils

We were incorrectly marking updates as chain_sync
or not in test_utils based on whether monitor_update
is None or not. Instead, use UpdateOrigin to determine it.

13 months agoAdd anchors coverage to test_revoked_counterparty_commitment_balances
Wilmer Paulino [Tue, 26 Sep 2023 17:31:09 +0000 (10:31 -0700)]
Add anchors coverage to test_revoked_counterparty_commitment_balances

13 months agoAdd anchors coverage to test_balances_on_local_commitment_htlcs
Wilmer Paulino [Tue, 26 Sep 2023 00:01:31 +0000 (17:01 -0700)]
Add anchors coverage to test_balances_on_local_commitment_htlcs

13 months agoAdd anchors coverage to test_claim_value_force_close
Wilmer Paulino [Mon, 25 Sep 2023 23:59:05 +0000 (16:59 -0700)]
Add anchors coverage to test_claim_value_force_close

13 months agoAdd anchors coverage to chanmon_claim_value_coop_close
Wilmer Paulino [Wed, 27 Sep 2023 21:11:35 +0000 (14:11 -0700)]
Add anchors coverage to chanmon_claim_value_coop_close

13 months agoAdd test util to handle bump HTLC events
Wilmer Paulino [Tue, 26 Sep 2023 18:59:42 +0000 (11:59 -0700)]
Add test util to handle bump HTLC events

13 months agoFix matching of second-stage HTLC claim in get_htlc_balance
Matt Corallo [Sun, 24 Sep 2023 02:32:08 +0000 (02:32 +0000)]
Fix matching of second-stage HTLC claim in get_htlc_balance

We incorrectly assumed that the descriptor's output index from
second-stage HTLC transaction would always match the HTLC's output index
in the commitment transaction. This doesn't make any sense though, we
need to make sure we map the descriptor to it's corresponding HTLC in
the commitment. Instead, we check that the transaction from which the
descriptor originated from spends the HTLC in question.

Note that pre-anchors, second-stage HTLC transactions are always 1
input-1 output, so previously we would only match if the HTLC was the
first output in the commitment transaction. Post-anchors, they are
malleable, so  we can aggregate multiple HTLC claims into a single
transaction making this even more likely to happen. Unfortunately, we
lacked proper coverage in this area so the bug went unnoticed. To
address this, we aim to extend our existing coverage of
`get_claimable_balances` to anchor outputs channels in the following
commits.

13 months agoMerge pull request #2629 from jkczyz/2023-09-invreqfailed
Matt Corallo [Fri, 29 Sep 2023 22:42:50 +0000 (22:42 +0000)]
Merge pull request #2629 from jkczyz/2023-09-invreqfailed

Config-guard `Event::InvoiceRequestFailed`

13 months agoMerge pull request #2605 from wpaulino/anchors-monitor-track-to-remote-script
Matt Corallo [Fri, 29 Sep 2023 22:06:58 +0000 (22:06 +0000)]
Merge pull request #2605 from wpaulino/anchors-monitor-track-to-remote-script

Use correct to_remote script in counterparty commitments

13 months agoRemove unused imports
Jeffrey Czyz [Fri, 29 Sep 2023 21:04:21 +0000 (14:04 -0700)]
Remove unused imports

13 months agoFix build warning for unused method
Jeffrey Czyz [Fri, 29 Sep 2023 21:03:39 +0000 (14:03 -0700)]
Fix build warning for unused method

13 months agoRemove an unnecessary enumerate
Jeffrey Czyz [Fri, 29 Sep 2023 20:58:34 +0000 (13:58 -0700)]
Remove an unnecessary enumerate

13 months agoConfig-guard Event::InvoiceRequestFailed
Jeffrey Czyz [Fri, 29 Sep 2023 20:47:25 +0000 (13:47 -0700)]
Config-guard Event::InvoiceRequestFailed

The event cannot be generated publicly, so remove it for now to avoid
users needing to handle it.

13 months agoMerge pull request #2628 from wvanlint/fix_multiple_shutdown_results
Matt Corallo [Fri, 29 Sep 2023 21:25:51 +0000 (21:25 +0000)]
Merge pull request #2628 from wvanlint/fix_multiple_shutdown_results

Fix handling multiple ShutdownResults

13 months agoExpose witness_script for StaticPaymentOutputDescriptor
Wilmer Paulino [Thu, 28 Sep 2023 19:31:43 +0000 (12:31 -0700)]
Expose witness_script for StaticPaymentOutputDescriptor

13 months agoFix incorrect anchors `counterparty_payment_script` upon deserialization
Wilmer Paulino [Thu, 28 Sep 2023 19:12:19 +0000 (12:12 -0700)]
Fix incorrect anchors `counterparty_payment_script` upon deserialization

13 months agoMerge pull request #2622 from wpaulino/funding-and-commitment-tx-confirm-same-block
Matt Corallo [Fri, 29 Sep 2023 21:06:55 +0000 (21:06 +0000)]
Merge pull request #2622 from wpaulino/funding-and-commitment-tx-confirm-same-block

Avoid early return upon confirmation of channel funding

13 months agoMerge pull request #2626 from TheBlueMatt/2023-09-revert-2476
Matt Corallo [Fri, 29 Sep 2023 21:06:41 +0000 (21:06 +0000)]
Merge pull request #2626 from TheBlueMatt/2023-09-revert-2476

Revert "Remove AvailableBalances::balance_msat"

13 months agoFix off-by-one max witness estimate for P2WPKH StaticPaymentDescriptor
Wilmer Paulino [Thu, 28 Sep 2023 16:07:10 +0000 (09:07 -0700)]
Fix off-by-one max witness estimate for P2WPKH StaticPaymentDescriptor

We were not accounting for the extra byte denoting the number of items
in the witness stack.

13 months agoSupport signing to_remote anchors variant for StaticPaymentOutput
Wilmer Paulino [Mon, 25 Sep 2023 23:55:22 +0000 (16:55 -0700)]
Support signing to_remote anchors variant for StaticPaymentOutput

`to_remote` outputs on commitment transactions with anchor outputs have
an additional `1 CSV` constraint on its spending condition,
transitioning away from the previous P2WPKH script to a P2WSH.

Since our `ChannelMonitor` was never updated to track the proper
`to_remote` script on anchor outputs channels, we also missed updating
our signer to handle the new script changes.

13 months agoUse correct to_remote script in counterparty commitments
Wilmer Paulino [Mon, 25 Sep 2023 23:53:42 +0000 (16:53 -0700)]
Use correct to_remote script in counterparty commitments

While our commitment transactions did use the correct `to_remote`
script, the `ChannelMonitor`'s was not as it is tracked separately. This
would lead to users never receiving an `Event::SpendableOutputs` with a
`StaticPaymentOutput` descriptor to claim the funds.

Luckily, any users affected which had channel closures confirmed by a
counterparty commitment just need to replay the closing transaction to
receive the event.

13 months agoMerge pull request #2624 from wpaulino/2609-follow-up
Matt Corallo [Fri, 29 Sep 2023 20:07:16 +0000 (20:07 +0000)]
Merge pull request #2624 from wpaulino/2609-follow-up

Address 2609 follow-up comments

13 months agoFix handling multiple ShutdownResults
Willem Van Lint [Fri, 29 Sep 2023 19:06:36 +0000 (12:06 -0700)]
Fix handling multiple ShutdownResults

13 months agoMerge pull request #2623 from wpaulino/htlc-claim-receive-preimage-after-close
Matt Corallo [Fri, 29 Sep 2023 18:53:44 +0000 (18:53 +0000)]
Merge pull request #2623 from wpaulino/htlc-claim-receive-preimage-after-close

Claim HTLCs with preimage from currently confirmed commitment

13 months agoAvoid early return upon confirmation of channel funding
Wilmer Paulino [Fri, 22 Sep 2023 17:39:10 +0000 (10:39 -0700)]
Avoid early return upon confirmation of channel funding

This early return is only possible if the channel requires a single
confirmation, allowing a `channel_ready` message to go out. This can be
problematic though if a commitment transaction (specifically from the
counterparty, as the channel would be immediately closed if a local
commitment is broadcast) also confirms within the same block. The
`ChannelMonitor` will detect both, but it won't inform the
`ChannelManager` at all. Luckily, while the channel still is considered
open to the `ChannelManager`, the `ChannelMonitor` will reject any
further updates to the channel state.

13 months agoRevert "Remove AvailableBalances::balance_msat" 2023-09-revert-2476
Matt Corallo [Fri, 29 Sep 2023 18:32:25 +0000 (18:32 +0000)]
Revert "Remove AvailableBalances::balance_msat"

While removing the `balance_msat` field absolutely makes sense -
it is, at best, confusing - we really need a solid replacement for
it before we can do so. While one such replacement is in progress,
it is not complete and we'd like to not block our current release
on its completion.

This reverts commit ef5be580f51d6756612fea710516c0297203f4dc.

13 months agoOnly yield DelayedPaymentOutput descriptors once their delay expires
Wilmer Paulino [Fri, 29 Sep 2023 16:40:34 +0000 (09:40 -0700)]
Only yield DelayedPaymentOutput descriptors once their delay expires

Otherwise, we could give users a descriptor ahead of time that will
result in an invalid transaction spend/broadcast.

13 months agoMerge pull request #2617 from wpaulino/no-persist-same-channel-update
Matt Corallo [Fri, 29 Sep 2023 17:39:49 +0000 (17:39 +0000)]
Merge pull request #2617 from wpaulino/no-persist-same-channel-update

Avoid persisting on same counterparty's ChannelUpdate

13 months agoMerge pull request #2591 from TheBlueMatt/2023-09-2562-followups
Elias Rohrer [Fri, 29 Sep 2023 17:08:36 +0000 (19:08 +0200)]
Merge pull request #2591 from TheBlueMatt/2023-09-2562-followups

Doc and comment followups to #2562

13 months agoNote required levels of descendant transactions in get_spendable_outputs
Wilmer Paulino [Fri, 29 Sep 2023 16:16:48 +0000 (09:16 -0700)]
Note required levels of descendant transactions in get_spendable_outputs

Three levels of descendant transactions starting from the channel's
funding transaction should cover all potential spendable outputs.

The first level covers the commitment transaction.

The second level covers the to_self claims, to_remote claims,
second-stage HTLC claims and justice transactions.

The third levels covers the justice transactions on second-stage HTLCs,
and to_self claims on second-stage HTLCs.

13 months agoTest preimage claim after reorg of counterparty commitment
Wilmer Paulino [Mon, 14 Aug 2023 19:12:54 +0000 (12:12 -0700)]
Test preimage claim after reorg of counterparty commitment

This test adds coverage for receiving a preimage after seeing a
counterparty commitment confirm, followed by a reorg and the
confirmation of a different commitment instead.

The first test covers the case where a holder commitment confirms after
the counterparty commitment reorg.

The second test covers the case where a previous counterparty commitment
confirms after the latest counterparty commitment reorg.

13 months agoClaim HTLCs with preimage from currently confirmed commitment
Wilmer Paulino [Fri, 28 Jul 2023 22:32:29 +0000 (15:32 -0700)]
Claim HTLCs with preimage from currently confirmed commitment

We should always claim HTLCs from the currently confirmed commitment,
rather than always claiming from the latest or previous counterparty
commitment if we've seen either confirm onchain at a prior point.

13 months agoAvoid persisting on same counterparty's ChannelUpdate
Wilmer Paulino [Thu, 28 Sep 2023 23:02:25 +0000 (16:02 -0700)]
Avoid persisting on same counterparty's ChannelUpdate

Some nodes may rebroadcast their `ChannelUpdate` to their counterparty
on every connection establishment, which leads to us doing an additional
persist most of the time when nothing has changed. Now, we'll only
persist if we receive an update that changes anything.

13 months agoMerge pull request #2609 from wpaulino/monitor-get-spendable-output
Matt Corallo [Fri, 29 Sep 2023 01:29:47 +0000 (01:29 +0000)]
Merge pull request #2609 from wpaulino/monitor-get-spendable-output

Allow retrieval of SpendableOutputDescriptors from relevant transactions

13 months agoMerge pull request #2604 from TheBlueMatt/2023-09-route-overpay-limit
Matt Corallo [Fri, 29 Sep 2023 00:19:04 +0000 (00:19 +0000)]
Merge pull request #2604 from TheBlueMatt/2023-09-route-overpay-limit

Try to overpay the recipient if we fail to find a path at all and limit overpay

13 months agoRetrieve all possible spendable outputs from transactions
Wilmer Paulino [Thu, 28 Sep 2023 18:42:13 +0000 (11:42 -0700)]
Retrieve all possible spendable outputs from transactions

Assuming our keys haven't been compromised, and that random transactions
aren't learning of these scripts somehow and sending funds to them, it
was only possible for one spendable output to exist within a
transaction.

- `shutdown_script` can only exist in co-op close transactions.
- `counterparty_payment_script` can only exist in counterparty
  commitment transactions.
- `broadcasted_holder_revokable_script` can only exist in holder
  commitment/HTLC transactions.
- `destination_script` can exist in any other type of claim we support.

Now that we're exposing this API to users such that they can rescan any
relevant transactions, there's no harm in allowing them to claim more
funds from spendable outputs than we expected.

13 months agoAllow retrieval of SpendableOutputDescriptors from relevant transactions
Wilmer Paulino [Wed, 27 Sep 2023 17:27:44 +0000 (10:27 -0700)]
Allow retrieval of SpendableOutputDescriptors from relevant transactions

Currently, our API will only expose `SpendableOutputDescriptor`s once
after they are no longer under reorg risk (see `ANTI_REORG_DELAY`).
Users have often requested they'd like the ability to retrieve these in
some other way, either for historical purposes, or to handle replaying
any in the event of a failure.

13 months agoAdd more details about async persistence completion/backgrounding 2023-09-2562-followups
Matt Corallo [Thu, 28 Sep 2023 20:45:27 +0000 (20:45 +0000)]
Add more details about async persistence completion/backgrounding

This clarifies somewhat that async persistence should run
indefinitely or keep trying via polling, and that either is
acceptable.

13 months agoLog max routing fee before we start pathfinding 2023-09-route-overpay-limit
Matt Corallo [Thu, 28 Sep 2023 17:51:05 +0000 (17:51 +0000)]
Log max routing fee before we start pathfinding

This may be useful in debugging routing failures in the future.

13 months agoInclude any recipient overpayment amounts in the route fee limit
Matt Corallo [Thu, 28 Sep 2023 18:19:36 +0000 (18:19 +0000)]
Include any recipient overpayment amounts in the route fee limit

If the user told us to limit their total fee exposure, we should
do so including any potential overpayment to the recipient, which
is ultimately a part of the "fee" as far as the user is concerned.

13 months agoTry to overpay the recipient if we fail to find a path at all
Matt Corallo [Tue, 26 Sep 2023 21:58:53 +0000 (21:58 +0000)]
Try to overpay the recipient if we fail to find a path at all

Previously we'd only try to overpay if we managed to find a path
to the recipient which was sufficient. However, if we fail to find
any path to the recipient at all we should still retry overpaying
the recipient. Ultimately we should be silling to pay whatever
reasonable performance penalty if the alternative is not finding a
path at all, which we do here.

13 months agoAllow routefinding again due to HTLC limit based on >= not >
Matt Corallo [Thu, 28 Sep 2023 18:19:50 +0000 (18:19 +0000)]
Allow routefinding again due to HTLC limit based on >= not >

While this doesn't matter much in practice, if we go around again
when route-finding to try to meet an htlc_minimum_msat, we use the
`recommended_value_msat` which can work if we meet the
`htlc_minimum_msat` on a channel exactly, so using >= rather than >
can capture cases with 1msat more.

13 months agoMerge pull request #2612 from TheBlueMatt/2023-09-namespace-split
Matt Corallo [Thu, 28 Sep 2023 20:37:54 +0000 (20:37 +0000)]
Merge pull request #2612 from TheBlueMatt/2023-09-namespace-split

Refer to top-level persistence namespaces as primary_namespace

13 months agoMerge pull request #2575 from tnull/2023-09-fix-debug-panic
Matt Corallo [Thu, 28 Sep 2023 20:30:29 +0000 (20:30 +0000)]
Merge pull request #2575 from tnull/2023-09-fix-debug-panic

Various router fixes and #2417 follow-ups

13 months agoMerge pull request #2611 from TheBlueMatt/2023-09-no-close-on-bad-update
Matt Corallo [Thu, 28 Sep 2023 19:06:24 +0000 (19:06 +0000)]
Merge pull request #2611 from TheBlueMatt/2023-09-no-close-on-bad-update

Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`

13 months agoUpdate remaining references to primary/secondary namespaces 2023-09-namespace-split
Matt Corallo [Thu, 28 Sep 2023 17:28:04 +0000 (17:28 +0000)]
Update remaining references to primary/secondary namespaces

Update various variables, error strings, and the pending changelog
entry to refer to new namespace terminology.

13 months agoUpdate storage constants to new PRIMARY/SECONDARY namespace terms
Matt Corallo [Thu, 28 Sep 2023 17:06:20 +0000 (17:06 +0000)]
Update storage constants to new PRIMARY/SECONDARY namespace terms

13 months agoRename the persistence `sub_namespace` to `secondary_namespace`
Matt Corallo [Thu, 28 Sep 2023 16:36:52 +0000 (16:36 +0000)]
Rename the persistence `sub_namespace` to `secondary_namespace`

With the top-level namespace now called "primary", "secondary"
makes more sense than "sub".

13 months agoDon't retry overpaid values for `PartialFailure`s
Elias Rohrer [Wed, 27 Sep 2023 10:43:31 +0000 (12:43 +0200)]
Don't retry overpaid values for `PartialFailure`s

Previously, if an overpaid path would fail immediately, we'd retry a
`PartialFailure` with the full path amount, _including_ any overpayment.

Here, we now subtract the succeeded paths' values from the
net. value to exclude the overpaid amounts on retry.

13 months agoAssert query's and route's `final_value_msat` are equal
Elias Rohrer [Thu, 28 Sep 2023 08:04:35 +0000 (10:04 +0200)]
Assert query's and route's `final_value_msat` are equal

13 months agoRefactor `mpp_retry[_overpay]` tests to use `SendEvent::from_event`
Elias Rohrer [Wed, 27 Sep 2023 07:57:20 +0000 (09:57 +0200)]
Refactor `mpp_retry[_overpay]` tests to use `SendEvent::from_event`

.. as a follow-up from #2417.

13 months agoMake ignored candidate counts `u32`
Elias Rohrer [Wed, 27 Sep 2023 07:28:43 +0000 (09:28 +0200)]
Make ignored candidate counts `u32`

.. as a follow-up from #2417.

13 months agoAvoid adding duplicate hint candidates if they are first hops
Elias Rohrer [Fri, 22 Sep 2023 14:38:30 +0000 (16:38 +0200)]
Avoid adding duplicate hint candidates if they are first hops

If we have a direct channel to a node generating an invoice with route
hints, we'd previously happily add multiple candidates that all refer to
the same channel. To keep our candidate set small and unify our tracking
where possible, we now check if its `short_channel_id` is an
`outbound_scid_alias` of any of our first hops and refrain from adding
another candidate if it's the case.

13 months agoAlso add route hints if we are the source
Elias Rohrer [Fri, 22 Sep 2023 13:56:07 +0000 (15:56 +0200)]
Also add route hints if we are the source

Previously, we would only consider route hints if we had a direct
channel to the first node in the hint or if the first node in the hint
was part of the public network graph.

However, this left out the possiblity of us being part of the first hop,
especially if our own node is not announced and part of the graph.

13 months agoMerge pull request #2607 from DhananjayPurohit/civkit-branch
Matt Corallo [Thu, 28 Sep 2023 16:54:44 +0000 (16:54 +0000)]
Merge pull request #2607 from DhananjayPurohit/civkit-branch

Issue in adding rust lightning as dependency on windows

13 months agoMerge pull request #2606 from wpaulino/anchors-counterparty-htlc-claim-sequence
Matt Corallo [Thu, 28 Sep 2023 16:32:18 +0000 (16:32 +0000)]
Merge pull request #2606 from wpaulino/anchors-counterparty-htlc-claim-sequence

Use correct input sequence for HTLC claims from counterparty commitments

13 months agoLog full channel_update messages received for our channels 2023-09-no-close-on-bad-update
Matt Corallo [Thu, 28 Sep 2023 16:30:02 +0000 (16:30 +0000)]
Log full channel_update messages received for our channels

13 months agoExtend logging of ignored candidates
Elias Rohrer [Fri, 22 Sep 2023 13:00:43 +0000 (15:00 +0200)]
Extend logging of ignored candidates

13 months agoUse `saturating_add` when adding inflight HTLCs values
Elias Rohrer [Thu, 14 Sep 2023 12:14:03 +0000 (14:14 +0200)]
Use `saturating_add` when adding inflight HTLCs values

Previously this calculation could overflow, leading to panicking in `debug`.

13 months agochore: remove time_utils.rs
DhananjayPurohit [Tue, 26 Sep 2023 09:24:00 +0000 (14:54 +0530)]
chore: remove time_utils.rs

No longer needed time_utils in lightning-invoice

13 months agoRefer to top-level persistence namespaces as `primary_namespace`
Matt Corallo [Thu, 28 Sep 2023 02:40:07 +0000 (02:40 +0000)]
Refer to top-level persistence namespaces as `primary_namespace`

This fixes a bindings build error as `namespace` is a C++ keyword
which cannot be used as an argument, and while this could be fixed
in the bindings rather than here, separating the term `namespace`
between the concept (which refers to the primary and sub
namespaces) and the primary namespace makes the documentation more
readable.

13 months agoUse `Result<_, io::Error>` over `io::Result<_>`
Matt Corallo [Wed, 27 Sep 2023 22:26:57 +0000 (22:26 +0000)]
Use `Result<_, io::Error>` over `io::Result<_>`

Personally I've always found the overload of a prelude enum to be
confusing, and never bothered to handle it properly in bindings as
a result. To avoid needing to do so now, we simply move the
newly-introduced `io::Result` usages over to
`Result<_, io::Error>`.

13 months agoDon't FC when a `channel_update` has a bogus `htlc_minimum_msat`
Matt Corallo [Thu, 28 Sep 2023 00:46:31 +0000 (00:46 +0000)]
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`

If a peer sends us a `channel_update` for our own channel with an
`htlc_minimum_msat` which is more than the channel's amount, that's
dumb, but there's no reason to force-close the channel. We don't
even use the field.

Here we simply drop the unnecessary check.

13 months agoMerge pull request #2570 from valentinewallace/2023-08-router-fuzz-fail
Matt Corallo [Wed, 27 Sep 2023 20:40:32 +0000 (20:40 +0000)]
Merge pull request #2570 from valentinewallace/2023-08-router-fuzz-fail

Fix router fuzz failure

13 months agoUse correct input sequence for HTLC claims from counterparty commitments
Wilmer Paulino [Mon, 25 Sep 2023 23:57:04 +0000 (16:57 -0700)]
Use correct input sequence for HTLC claims from counterparty commitments

HTLC outputs, like the `to_remote` output, in commitment transactions
with anchor outputs also have an additional `1 CSV` constraint on the
counterparty. When spending such outputs, their corresponding input
needs to have their sequence set to 1. This was done for HTLC claims
from holder commitments, but unfortunately not for counterparty
commitments as we were lacking test coverage.

13 months agoget_route: fix path value contribution to include min htlc overpay 2023-09-2570-fuzz-test
Valentine Wallace [Wed, 27 Sep 2023 03:44:27 +0000 (23:44 -0400)]
get_route: fix path value contribution to include min htlc overpay

Previously, the fuzzer hit a debug panic because we wouldn't include the amount
overpaid to meet a last hop's min_htlc in the total collected paths value. We
now include this value and also penalize hops along the overpaying path to
ensure that it gets deprioritized in path selection.

13 months agoget_route: fix path_min for first_hop<>network_node candidates
Valentine Wallace [Wed, 27 Sep 2023 02:21:15 +0000 (22:21 -0400)]
get_route: fix path_min for first_hop<>network_node candidates

Previously, we would add a first_hop<>network_node channel that did not have
enough contribution amount to cover the next channel's min htlc plus fees,
because we were storing the next hop as having a path_min that did not include
fees, and would add a connecting first_hop node that did not have enough
contribution amount, leading to a debug panic upon invalid path construction.

13 months agoget_route: fix path_min for first_hop<>blinded_hint candidates
Valentine Wallace [Tue, 26 Sep 2023 22:57:02 +0000 (18:57 -0400)]
get_route: fix path_min for first_hop<>blinded_hint candidates

See previous commit, but the bug where we would underestimate how much a first
hop candidate needed to be able to relay was also present in blinded paths.

13 months agoget_route: fix path_min when adding first_hop<>route_hint candidates
Valentine Wallace [Wed, 27 Sep 2023 01:19:33 +0000 (21:19 -0400)]
get_route: fix path_min when adding first_hop<>route_hint candidates

Previously, we would add a candidate hop to the list of potential hops even
though its available contribution wasn't sufficient to meet the next hop's
min_htlc. We'd subsequently build an invalid path using this hop and hit a
debug assertion.

13 months agoget_route: fix outdated var name
Valentine Wallace [Fri, 22 Sep 2023 20:13:36 +0000 (16:13 -0400)]
get_route: fix outdated var name

Previously this variable was a bool, but has since been updated to be an
Option, so rename accordingly.

13 months agoPathfinding: ignore blinded route hints where we are the intro node
Valentine Wallace [Tue, 12 Sep 2023 18:57:59 +0000 (14:57 -0400)]
Pathfinding: ignore blinded route hints where we are the intro node

See tests, but the fuzzer found several panics from not fully ignoring these
hints.

We should support these route hints eventually, but it will involve some
reworking of the Path/BlindedTail structs.

13 months agoRemove trailing whitespace in get_route
Valentine Wallace [Tue, 12 Sep 2023 19:01:53 +0000 (15:01 -0400)]
Remove trailing whitespace in get_route

Because my text editor loves to do that.

13 months agoRefuse to pathfind when provided our_node_id matches internal dummy pk
Valentine Wallace [Tue, 12 Sep 2023 18:56:54 +0000 (14:56 -0400)]
Refuse to pathfind when provided our_node_id matches internal dummy pk

The fuzzer managed to hit this and it causes some invalid paths to be generated
internally.

13 months agoPathfinding: log when we ignore one hop blinded route hints
Valentine Wallace [Tue, 12 Sep 2023 18:55:36 +0000 (14:55 -0400)]
Pathfinding: log when we ignore one hop blinded route hints

13 months agoMerge pull request #2601 from TheBlueMatt/2023-09-117-alpha2 v0.0.117-alpha2
Matt Corallo [Wed, 27 Sep 2023 03:51:12 +0000 (03:51 +0000)]
Merge pull request #2601 from TheBlueMatt/2023-09-117-alpha2

Bump versions to 0.0.117-alpha2/invoice 0.25.0-alpha2

13 months agoMerge pull request #2603 from TheBlueMatt/2023-09-default-route-limit
Matt Corallo [Wed, 27 Sep 2023 03:47:16 +0000 (03:47 +0000)]
Merge pull request #2603 from TheBlueMatt/2023-09-default-route-limit

Set a default max_total_routing_fee_msat of 1% + 50sats

13 months agoMerge pull request #2602 from TheBlueMatt/2023-09-descriptor-hash
Matt Corallo [Wed, 27 Sep 2023 03:47:09 +0000 (03:47 +0000)]
Merge pull request #2602 from TheBlueMatt/2023-09-descriptor-hash

Derive `Hash` for `SpendableOutputDescriptor`

13 months agoMerge pull request #2359 from domZippilli/2023-06-monitor-updating-persister
Matt Corallo [Wed, 27 Sep 2023 03:46:39 +0000 (03:46 +0000)]
Merge pull request #2359 from domZippilli/2023-06-monitor-updating-persister

Monitor updating persister

13 months agoAdd MonitorUpdatingPersister
Dom Zippilli [Wed, 30 Aug 2023 00:42:07 +0000 (17:42 -0700)]
Add MonitorUpdatingPersister

MonitorUpdatingPersister is an implementation of Persister that stores
ChannelMonitorUpdates separately from ChannelMonitors. Its RFC is
in #2545, at https://github.com/orgs/lightningdevkit/discussions/2545.

Co-Authored-By: Elias Rohrer <dev@tnull.de>
13 months agoMerge pull request #2486 from wvanlint/batch_channel_opens
Matt Corallo [Tue, 26 Sep 2023 22:54:12 +0000 (22:54 +0000)]
Merge pull request #2486 from wvanlint/batch_channel_opens

Batch funding for v1 channel establishments

13 months agoSet a default `max_total_routing_fee_msat` of 1% + 50sats 2023-09-default-route-limit
Matt Corallo [Tue, 26 Sep 2023 21:28:29 +0000 (21:28 +0000)]
Set a default `max_total_routing_fee_msat` of 1% + 50sats

When using the normal default constructors, we should have some
fee maximum to ensure our default behavior is safe. Here we pick
1% + 50 sats to ensure we're always willing to pay
reasonabl(y high) fees, but not anything too wild.

13 months agoDerive `Debug` and `Display` for `Route`
Matt Corallo [Tue, 26 Sep 2023 21:12:46 +0000 (21:12 +0000)]
Derive `Debug` and `Display` for `Route`

13 months agoDerive `Hash` for `SpendableOutputDescriptor` 2023-09-descriptor-hash
Matt Corallo [Tue, 26 Sep 2023 20:41:49 +0000 (20:41 +0000)]
Derive `Hash` for `SpendableOutputDescriptor`

This allows for easy descriptor de-duplication before building a
claiming transaction.

13 months agoBatch funding for v1 channel establishments
Willem Van Lint [Sat, 29 Jul 2023 00:21:47 +0000 (17:21 -0700)]
Batch funding for v1 channel establishments

13 months agoRename finish_force_close_channel to finish_close_channel
Willem Van Lint [Tue, 26 Sep 2023 05:39:26 +0000 (22:39 -0700)]
Rename finish_force_close_channel to finish_close_channel

13 months agoAlways call finish_force_close_channel on closure
Willem Van Lint [Tue, 26 Sep 2023 05:36:26 +0000 (22:36 -0700)]
Always call finish_force_close_channel on closure

This is a step towards more unified closing of channels, and provides a
place where the per_peer_state lock is not held.

13 months agoBump versions to 0.0.117-alpha2/invoice 0.25.0-alpha2 2023-09-117-alpha2
Matt Corallo [Tue, 26 Sep 2023 20:21:08 +0000 (20:21 +0000)]
Bump versions to 0.0.117-alpha2/invoice 0.25.0-alpha2

13 months agoMerge pull request #2417 from tnull/2023-07-max-total-fee
Matt Corallo [Tue, 26 Sep 2023 20:07:52 +0000 (20:07 +0000)]
Merge pull request #2417 from tnull/2023-07-max-total-fee

Add config option to set maximum total routing fee

13 months agoTest `max_total_routing_fee_msat` handling when retrying overpaid paths
Elias Rohrer [Tue, 26 Sep 2023 13:30:39 +0000 (15:30 +0200)]
Test `max_total_routing_fee_msat` handling when retrying overpaid paths

We setup an MPP scenario with two paths in which we need to overpay to
reach `htlc_minimum_msat`. We then fail the overpaid path and check that
on retry our `max_total_routing_fee_msat` only accounts for the path
fees, but not for the fees overpaid in the first attempt.