projects
/
ldk-c-bindings
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
e63c884
)
Correctly print lifetime parameters when printing generic arguments
author
Matt Corallo
<git@bluematt.me>
Sun, 21 Nov 2021 18:17:35 +0000
(18:17 +0000)
committer
Matt Corallo
<git@bluematt.me>
Tue, 30 Nov 2021 15:39:48 +0000
(15:39 +0000)
c-bindings-gen/src/types.rs
patch
|
blob
|
history
diff --git
a/c-bindings-gen/src/types.rs
b/c-bindings-gen/src/types.rs
index 357fe4c815004a3ae775827a46ef3a34b013cc5b..9b0b93a3a38b786fb8e957155186eb4a3108c99e 100644
(file)
--- a/
c-bindings-gen/src/types.rs
+++ b/
c-bindings-gen/src/types.rs
@@
-386,9
+386,9
@@
impl<'a, 'b, 'c: 'a + 'b> ResolveType<'c> for Option<&GenericTypes<'a, 'b>> {
pub enum DeclType<'a> {
MirroredEnum,
Trait(&'a syn::ItemTrait),
pub enum DeclType<'a> {
MirroredEnum,
Trait(&'a syn::ItemTrait),
- StructImported { generic
_param_count: usize
},
+ StructImported { generic
s: &'a syn::Generics
},
StructIgnored,
StructIgnored,
- EnumIgnored { generic
_param_count: usize
},
+ EnumIgnored { generic
s: &'a syn::Generics
},
}
pub struct ImportResolver<'mod_lifetime, 'crate_lft: 'mod_lifetime> {
}
pub struct ImportResolver<'mod_lifetime, 'crate_lft: 'mod_lifetime> {
@@
-500,7
+500,7
@@
impl<'mod_lifetime, 'crate_lft: 'mod_lifetime> ImportResolver<'mod_lifetime, 'cr
syn::Item::Struct(s) => {
if let syn::Visibility::Public(_) = s.vis {
match export_status(&s.attrs) {
syn::Item::Struct(s) => {
if let syn::Visibility::Public(_) = s.vis {
match export_status(&s.attrs) {
- ExportStatus::Export => { declared.insert(s.ident.clone(), DeclType::StructImported { generic
_param_count: s.generics.params.len()
}); },
+ ExportStatus::Export => { declared.insert(s.ident.clone(), DeclType::StructImported { generic
s: &s.generics
}); },
ExportStatus::NoExport => { declared.insert(s.ident.clone(), DeclType::StructIgnored); },
ExportStatus::TestOnly => continue,
ExportStatus::NotImplementable => panic!("(C-not implementable) should only appear on traits!"),
ExportStatus::NoExport => { declared.insert(s.ident.clone(), DeclType::StructIgnored); },
ExportStatus::TestOnly => continue,
ExportStatus::NotImplementable => panic!("(C-not implementable) should only appear on traits!"),
@@
-515,14
+515,14
@@
impl<'mod_lifetime, 'crate_lft: 'mod_lifetime> ImportResolver<'mod_lifetime, 'cr
else { process_alias = false; }
}
if process_alias {
else { process_alias = false; }
}
if process_alias {
- declared.insert(t.ident.clone(), DeclType::StructImported { generic
_param_count: t.generics.params.len()
});
+ declared.insert(t.ident.clone(), DeclType::StructImported { generic
s: &t.generics
});
}
}
},
syn::Item::Enum(e) => {
if let syn::Visibility::Public(_) = e.vis {
match export_status(&e.attrs) {
}
}
},
syn::Item::Enum(e) => {
if let syn::Visibility::Public(_) = e.vis {
match export_status(&e.attrs) {
- ExportStatus::Export if is_enum_opaque(e) => { declared.insert(e.ident.clone(), DeclType::EnumIgnored { generic
_param_count: e.generics.params.len()
}); },
+ ExportStatus::Export if is_enum_opaque(e) => { declared.insert(e.ident.clone(), DeclType::EnumIgnored { generic
s: &e.generics
}); },
ExportStatus::Export => { declared.insert(e.ident.clone(), DeclType::MirroredEnum); },
ExportStatus::NotImplementable => panic!("(C-not implementable) should only appear on traits!"),
_ => continue,
ExportStatus::Export => { declared.insert(e.ident.clone(), DeclType::MirroredEnum); },
ExportStatus::NotImplementable => panic!("(C-not implementable) should only appear on traits!"),
_ => continue,
@@
-1863,7
+1863,7
@@
impl<'a, 'c: 'a> TypeResolver<'a, 'c> {
} else if let Some(c_type) = path_lookup(&resolved_path, is_ref, ptr_for_ref) {
write!(w, "{}", c_type).unwrap();
} else if let Some((_, generics)) = self.crate_types.opaques.get(&resolved_path) {
} else if let Some(c_type) = path_lookup(&resolved_path, is_ref, ptr_for_ref) {
write!(w, "{}", c_type).unwrap();
} else if let Some((_, generics)) = self.crate_types.opaques.get(&resolved_path) {
- decl_lookup(w, &DeclType::StructImported { generic
_param_count: generics.params.len()
}, &resolved_path, is_ref, is_mut);
+ decl_lookup(w, &DeclType::StructImported { generic
s: &generics
}, &resolved_path, is_ref, is_mut);
} else if self.crate_types.mirrored_enums.get(&resolved_path).is_some() {
decl_lookup(w, &DeclType::MirroredEnum, &resolved_path, is_ref, is_mut);
} else if let Some(t) = self.crate_types.traits.get(&resolved_path) {
} else if self.crate_types.mirrored_enums.get(&resolved_path).is_some() {
decl_lookup(w, &DeclType::MirroredEnum, &resolved_path, is_ref, is_mut);
} else if let Some(t) = self.crate_types.traits.get(&resolved_path) {
@@
-1976,9
+1976,15
@@
impl<'a, 'c: 'a> TypeResolver<'a, 'c> {
|a, b, c| self.to_c_conversion_inline_suffix_from_path(a, b, c),
|w, decl_type, full_path, is_ref, _is_mut| match decl_type {
DeclType::MirroredEnum => write!(w, ")").unwrap(),
|a, b, c| self.to_c_conversion_inline_suffix_from_path(a, b, c),
|w, decl_type, full_path, is_ref, _is_mut| match decl_type {
DeclType::MirroredEnum => write!(w, ")").unwrap(),
- DeclType::EnumIgnored { generic
_param_count }|DeclType::StructImported { generic_param_count
} if is_ref => {
+ DeclType::EnumIgnored { generic
s }|DeclType::StructImported { generics
} if is_ref => {
write!(w, " as *const {}<", full_path).unwrap();
write!(w, " as *const {}<", full_path).unwrap();
- for _ in 0..*generic_param_count { write!(w, "_, ").unwrap(); }
+ for param in generics.params.iter() {
+ if let syn::GenericParam::Lifetime(_) = param {
+ write!(w, "'_, ").unwrap();
+ } else {
+ write!(w, "_, ").unwrap();
+ }
+ }
if from_ptr {
write!(w, ">) as *mut _ }}, is_owned: false }}").unwrap();
} else {
if from_ptr {
write!(w, ">) as *mut _ }}, is_owned: false }}").unwrap();
} else {