1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Functional tests which test the correct handling of ChannelMonitorUpdateErr returns from
12 //! There are a bunch of these as their handling is relatively error-prone so they are split out
13 //! here. See also the chanmon_fail_consistency fuzz test.
15 use bitcoin::blockdata::block::{Block, BlockHeader};
16 use bitcoin::blockdata::constants::genesis_block;
17 use bitcoin::hash_types::BlockHash;
18 use bitcoin::network::constants::Network;
19 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdateErr};
20 use chain::transaction::OutPoint;
23 use ln::{PaymentPreimage, PaymentHash};
24 use ln::channelmanager::{ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentSendFailure};
25 use ln::features::{InitFeatures, InvoiceFeatures};
27 use ln::msgs::{ChannelMessageHandler, ErrorAction, RoutingMessageHandler};
28 use routing::router::get_route;
29 use util::config::UserConfig;
30 use util::enforcing_trait_impls::EnforcingSigner;
31 use util::events::{Event, MessageSendEvent, MessageSendEventsProvider, PaymentPurpose};
32 use util::errors::APIError;
33 use util::ser::{ReadableArgs, Writeable};
34 use util::test_utils::TestBroadcaster;
36 use bitcoin::hashes::sha256::Hash as Sha256;
37 use bitcoin::hashes::Hash;
39 use ln::functional_test_utils::*;
45 use sync::{Arc, Mutex};
47 // If persister_fail is true, we have the persister return a PermanentFailure
48 // instead of the higher-level ChainMonitor.
49 fn do_test_simple_monitor_permanent_update_fail(persister_fail: bool) {
50 // Test that we handle a simple permanent monitor update failure
51 let mut chanmon_cfgs = create_chanmon_cfgs(2);
52 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
53 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
54 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
55 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
56 let logger = test_utils::TestLogger::new();
58 let (_, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(&nodes[1]);
60 match persister_fail {
61 true => chanmon_cfgs[0].persister.set_update_ret(Err(ChannelMonitorUpdateErr::PermanentFailure)),
62 false => *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::PermanentFailure))
64 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
65 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
66 unwrap_send_err!(nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)), true, APIError::ChannelUnavailable {..}, {});
67 check_added_monitors!(nodes[0], 2);
69 let events_1 = nodes[0].node.get_and_clear_pending_msg_events();
70 assert_eq!(events_1.len(), 2);
72 MessageSendEvent::BroadcastChannelUpdate { .. } => {},
73 _ => panic!("Unexpected event"),
76 MessageSendEvent::HandleError { node_id, .. } => assert_eq!(node_id, nodes[1].node.get_our_node_id()),
77 _ => panic!("Unexpected event"),
80 // TODO: Once we hit the chain with the failure transaction we should check that we get a
81 // PaymentFailed event
83 assert_eq!(nodes[0].node.list_channels().len(), 0);
87 fn test_monitor_and_persister_update_fail() {
88 // Test that if both updating the `ChannelMonitor` and persisting the updated
89 // `ChannelMonitor` fail, then the failure from updating the `ChannelMonitor`
90 // one that gets returned.
91 let chanmon_cfgs = create_chanmon_cfgs(2);
92 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
93 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
94 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
96 // Create some initial channel
97 let chan = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
98 let outpoint = OutPoint { txid: chan.3.txid(), index: 0 };
100 // Rebalance the network to generate htlc in the two directions
101 send_payment(&nodes[0], &vec!(&nodes[1])[..], 10_000_000);
103 // Route an HTLC from node 0 to node 1 (but don't settle)
104 let preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9_000_000).0;
106 // Make a copy of the ChainMonitor so we can capture the error it returns on a
107 // bogus update. Note that if instead we updated the nodes[0]'s ChainMonitor
108 // directly, the node would fail to be `Drop`'d at the end because its
109 // ChannelManager and ChainMonitor would be out of sync.
110 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
111 let logger = test_utils::TestLogger::with_id(format!("node {}", 0));
112 let persister = test_utils::TestPersister::new();
113 let tx_broadcaster = TestBroadcaster {
114 txn_broadcasted: Mutex::new(Vec::new()),
115 // Because we will connect a block at height 200 below, we need the TestBroadcaster to know
116 // that we are at height 200 so that it doesn't think we're violating the time lock
117 // requirements of transactions broadcasted at that point.
118 blocks: Arc::new(Mutex::new(vec![(genesis_block(Network::Testnet).header, 200); 200])),
121 let monitors = nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap();
122 let monitor = monitors.get(&outpoint).unwrap();
123 let mut w = test_utils::TestVecWriter(Vec::new());
124 monitor.write(&mut w).unwrap();
125 let new_monitor = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
126 &mut io::Cursor::new(&w.0), &test_utils::OnlyReadsKeysInterface {}).unwrap().1;
127 assert!(new_monitor == *monitor);
128 let chain_mon = test_utils::TestChainMonitor::new(Some(&chain_source), &tx_broadcaster, &logger, &chanmon_cfgs[0].fee_estimator, &persister, &node_cfgs[0].keys_manager);
129 assert!(chain_mon.watch_channel(outpoint, new_monitor).is_ok());
132 let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
133 chain_mon.chain_monitor.block_connected(&Block { header, txdata: vec![] }, 200);
135 // Set the persister's return value to be a TemporaryFailure.
136 persister.set_update_ret(Err(ChannelMonitorUpdateErr::TemporaryFailure));
138 // Try to update ChannelMonitor
139 assert!(nodes[1].node.claim_funds(preimage));
140 check_added_monitors!(nodes[1], 1);
141 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
142 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
143 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
144 if let Some(ref mut channel) = nodes[0].node.channel_state.lock().unwrap().by_id.get_mut(&chan.2) {
145 if let Ok((_, _, _, update)) = channel.commitment_signed(&updates.commitment_signed, &node_cfgs[0].fee_estimator, &node_cfgs[0].logger) {
146 // Check that even though the persister is returning a TemporaryFailure,
147 // because the update is bogus, ultimately the error that's returned
148 // should be a PermanentFailure.
149 if let Err(ChannelMonitorUpdateErr::PermanentFailure) = chain_mon.chain_monitor.update_channel(outpoint, update.clone()) {} else { panic!("Expected monitor error to be permanent"); }
150 logger.assert_log_contains("lightning::chain::chainmonitor".to_string(), "Failed to persist channel monitor update: TemporaryFailure".to_string(), 1);
151 if let Ok(_) = nodes[0].chain_monitor.update_channel(outpoint, update) {} else { assert!(false); }
152 } else { assert!(false); }
153 } else { assert!(false); };
155 check_added_monitors!(nodes[0], 1);
156 let events = nodes[0].node.get_and_clear_pending_events();
157 assert_eq!(events.len(), 1);
161 fn test_simple_monitor_permanent_update_fail() {
162 do_test_simple_monitor_permanent_update_fail(false);
164 // Test behavior when the persister returns a PermanentFailure.
165 do_test_simple_monitor_permanent_update_fail(true);
168 // If persister_fail is true, we have the persister return a TemporaryFailure instead of the
169 // higher-level ChainMonitor.
170 fn do_test_simple_monitor_temporary_update_fail(disconnect: bool, persister_fail: bool) {
171 // Test that we can recover from a simple temporary monitor update failure optionally with
172 // a disconnect in between
173 let mut chanmon_cfgs = create_chanmon_cfgs(2);
174 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
175 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
176 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
177 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
178 let logger = test_utils::TestLogger::new();
180 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(&nodes[1]);
182 match persister_fail {
183 true => chanmon_cfgs[0].persister.set_update_ret(Err(ChannelMonitorUpdateErr::TemporaryFailure)),
184 false => *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure))
188 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
189 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
190 unwrap_send_err!(nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)), false, APIError::MonitorUpdateFailed, {});
191 check_added_monitors!(nodes[0], 1);
194 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
195 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
196 assert_eq!(nodes[0].node.list_channels().len(), 1);
199 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
200 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
201 reconnect_nodes(&nodes[0], &nodes[1], (true, true), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
204 match persister_fail {
205 true => chanmon_cfgs[0].persister.set_update_ret(Ok(())),
206 false => *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()))
208 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
209 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
210 check_added_monitors!(nodes[0], 0);
212 let mut events_2 = nodes[0].node.get_and_clear_pending_msg_events();
213 assert_eq!(events_2.len(), 1);
214 let payment_event = SendEvent::from_event(events_2.pop().unwrap());
215 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
216 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
217 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
219 expect_pending_htlcs_forwardable!(nodes[1]);
221 let events_3 = nodes[1].node.get_and_clear_pending_events();
222 assert_eq!(events_3.len(), 1);
224 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
225 assert_eq!(payment_hash_1, *payment_hash);
226 assert_eq!(amt, 1000000);
228 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
229 assert!(payment_preimage.is_none());
230 assert_eq!(payment_secret_1, *payment_secret);
232 _ => panic!("expected PaymentPurpose::InvoicePayment")
235 _ => panic!("Unexpected event"),
238 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
240 // Now set it to failed again...
241 let (_, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(&nodes[1]);
243 match persister_fail {
244 true => chanmon_cfgs[0].persister.set_update_ret(Err(ChannelMonitorUpdateErr::TemporaryFailure)),
245 false => *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure))
247 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
248 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
249 unwrap_send_err!(nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)), false, APIError::MonitorUpdateFailed, {});
250 check_added_monitors!(nodes[0], 1);
253 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
254 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
255 assert_eq!(nodes[0].node.list_channels().len(), 1);
258 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
259 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
260 reconnect_nodes(&nodes[0], &nodes[1], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
263 // ...and make sure we can force-close a frozen channel
264 nodes[0].node.force_close_channel(&channel_id).unwrap();
265 check_added_monitors!(nodes[0], 1);
266 check_closed_broadcast!(nodes[0], true);
268 // TODO: Once we hit the chain with the failure transaction we should check that we get a
269 // PaymentFailed event
271 assert_eq!(nodes[0].node.list_channels().len(), 0);
275 fn test_simple_monitor_temporary_update_fail() {
276 do_test_simple_monitor_temporary_update_fail(false, false);
277 do_test_simple_monitor_temporary_update_fail(true, false);
279 // Test behavior when the persister returns a TemporaryFailure.
280 do_test_simple_monitor_temporary_update_fail(false, true);
281 do_test_simple_monitor_temporary_update_fail(true, true);
284 fn do_test_monitor_temporary_update_fail(disconnect_count: usize) {
285 let disconnect_flags = 8 | 16;
287 // Test that we can recover from a temporary monitor update failure with some in-flight
288 // HTLCs going on at the same time potentially with some disconnection thrown in.
289 // * First we route a payment, then get a temporary monitor update failure when trying to
290 // route a second payment. We then claim the first payment.
291 // * If disconnect_count is set, we will disconnect at this point (which is likely as
292 // TemporaryFailure likely indicates net disconnect which resulted in failing to update
293 // the ChannelMonitor on a watchtower).
294 // * If !(disconnect_count & 16) we deliver a update_fulfill_htlc/CS for the first payment
295 // immediately, otherwise we wait disconnect and deliver them via the reconnect
296 // channel_reestablish processing (ie disconnect_count & 16 makes no sense if
297 // disconnect_count & !disconnect_flags is 0).
298 // * We then update the channel monitor, reconnecting if disconnect_count is set and walk
299 // through message sending, potentially disconnect/reconnecting multiple times based on
300 // disconnect_count, to get the update_fulfill_htlc through.
301 // * We then walk through more message exchanges to get the original update_add_htlc
302 // through, swapping message ordering based on disconnect_count & 8 and optionally
303 // disconnect/reconnecting based on disconnect_count.
304 let chanmon_cfgs = create_chanmon_cfgs(2);
305 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
306 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
307 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
308 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
309 let logger = test_utils::TestLogger::new();
311 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
313 // Now try to send a second payment which will fail to send
314 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
316 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
317 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
318 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
319 unwrap_send_err!(nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)), false, APIError::MonitorUpdateFailed, {});
320 check_added_monitors!(nodes[0], 1);
323 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
324 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
325 assert_eq!(nodes[0].node.list_channels().len(), 1);
327 // Claim the previous payment, which will result in a update_fulfill_htlc/CS from nodes[1]
328 // but nodes[0] won't respond since it is frozen.
329 assert!(nodes[1].node.claim_funds(payment_preimage_1));
330 check_added_monitors!(nodes[1], 1);
331 let events_2 = nodes[1].node.get_and_clear_pending_msg_events();
332 assert_eq!(events_2.len(), 1);
333 let (bs_initial_fulfill, bs_initial_commitment_signed) = match events_2[0] {
334 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
335 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
336 assert!(update_add_htlcs.is_empty());
337 assert_eq!(update_fulfill_htlcs.len(), 1);
338 assert!(update_fail_htlcs.is_empty());
339 assert!(update_fail_malformed_htlcs.is_empty());
340 assert!(update_fee.is_none());
342 if (disconnect_count & 16) == 0 {
343 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &update_fulfill_htlcs[0]);
344 let events_3 = nodes[0].node.get_and_clear_pending_events();
345 assert_eq!(events_3.len(), 1);
347 Event::PaymentSent { ref payment_preimage } => {
348 assert_eq!(*payment_preimage, payment_preimage_1);
350 _ => panic!("Unexpected event"),
353 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), commitment_signed);
354 check_added_monitors!(nodes[0], 1);
355 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
356 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented generation of RAA".to_string(), 1);
359 (update_fulfill_htlcs[0].clone(), commitment_signed.clone())
361 _ => panic!("Unexpected event"),
364 if disconnect_count & !disconnect_flags > 0 {
365 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
366 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
369 // Now fix monitor updating...
370 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
371 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
372 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
373 check_added_monitors!(nodes[0], 0);
375 macro_rules! disconnect_reconnect_peers { () => { {
376 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
377 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
379 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
380 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
381 assert_eq!(reestablish_1.len(), 1);
382 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
383 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
384 assert_eq!(reestablish_2.len(), 1);
386 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
387 let as_resp = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
388 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
389 let bs_resp = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
391 assert!(as_resp.0.is_none());
392 assert!(bs_resp.0.is_none());
394 (reestablish_1, reestablish_2, as_resp, bs_resp)
397 let (payment_event, initial_revoke_and_ack) = if disconnect_count & !disconnect_flags > 0 {
398 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
399 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
401 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
402 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
403 assert_eq!(reestablish_1.len(), 1);
404 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
405 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
406 assert_eq!(reestablish_2.len(), 1);
408 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
409 check_added_monitors!(nodes[0], 0);
410 let mut as_resp = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
411 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
412 check_added_monitors!(nodes[1], 0);
413 let mut bs_resp = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
415 assert!(as_resp.0.is_none());
416 assert!(bs_resp.0.is_none());
418 assert!(bs_resp.1.is_none());
419 if (disconnect_count & 16) == 0 {
420 assert!(bs_resp.2.is_none());
422 assert!(as_resp.1.is_some());
423 assert!(as_resp.2.is_some());
424 assert!(as_resp.3 == RAACommitmentOrder::CommitmentFirst);
426 assert!(bs_resp.2.as_ref().unwrap().update_add_htlcs.is_empty());
427 assert!(bs_resp.2.as_ref().unwrap().update_fail_htlcs.is_empty());
428 assert!(bs_resp.2.as_ref().unwrap().update_fail_malformed_htlcs.is_empty());
429 assert!(bs_resp.2.as_ref().unwrap().update_fee.is_none());
430 assert!(bs_resp.2.as_ref().unwrap().update_fulfill_htlcs == vec![bs_initial_fulfill]);
431 assert!(bs_resp.2.as_ref().unwrap().commitment_signed == bs_initial_commitment_signed);
433 assert!(as_resp.1.is_none());
435 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_resp.2.as_ref().unwrap().update_fulfill_htlcs[0]);
436 let events_3 = nodes[0].node.get_and_clear_pending_events();
437 assert_eq!(events_3.len(), 1);
439 Event::PaymentSent { ref payment_preimage } => {
440 assert_eq!(*payment_preimage, payment_preimage_1);
442 _ => panic!("Unexpected event"),
445 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_resp.2.as_ref().unwrap().commitment_signed);
446 let as_resp_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
447 // No commitment_signed so get_event_msg's assert(len == 1) passes
448 check_added_monitors!(nodes[0], 1);
450 as_resp.1 = Some(as_resp_raa);
454 if disconnect_count & !disconnect_flags > 1 {
455 let (second_reestablish_1, second_reestablish_2, second_as_resp, second_bs_resp) = disconnect_reconnect_peers!();
457 if (disconnect_count & 16) == 0 {
458 assert!(reestablish_1 == second_reestablish_1);
459 assert!(reestablish_2 == second_reestablish_2);
461 assert!(as_resp == second_as_resp);
462 assert!(bs_resp == second_bs_resp);
465 (SendEvent::from_commitment_update(nodes[1].node.get_our_node_id(), as_resp.2.unwrap()), as_resp.1.unwrap())
467 let mut events_4 = nodes[0].node.get_and_clear_pending_msg_events();
468 assert_eq!(events_4.len(), 2);
469 (SendEvent::from_event(events_4.remove(0)), match events_4[0] {
470 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
471 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
474 _ => panic!("Unexpected event"),
478 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
480 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
481 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
482 let bs_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
483 // nodes[1] is awaiting an RAA from nodes[0] still so get_event_msg's assert(len == 1) passes
484 check_added_monitors!(nodes[1], 1);
486 if disconnect_count & !disconnect_flags > 2 {
487 let (_, _, as_resp, bs_resp) = disconnect_reconnect_peers!();
489 assert!(as_resp.1.unwrap() == initial_revoke_and_ack);
490 assert!(bs_resp.1.unwrap() == bs_revoke_and_ack);
492 assert!(as_resp.2.is_none());
493 assert!(bs_resp.2.is_none());
496 let as_commitment_update;
497 let bs_second_commitment_update;
499 macro_rules! handle_bs_raa { () => {
500 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_revoke_and_ack);
501 as_commitment_update = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
502 assert!(as_commitment_update.update_add_htlcs.is_empty());
503 assert!(as_commitment_update.update_fulfill_htlcs.is_empty());
504 assert!(as_commitment_update.update_fail_htlcs.is_empty());
505 assert!(as_commitment_update.update_fail_malformed_htlcs.is_empty());
506 assert!(as_commitment_update.update_fee.is_none());
507 check_added_monitors!(nodes[0], 1);
510 macro_rules! handle_initial_raa { () => {
511 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &initial_revoke_and_ack);
512 bs_second_commitment_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
513 assert!(bs_second_commitment_update.update_add_htlcs.is_empty());
514 assert!(bs_second_commitment_update.update_fulfill_htlcs.is_empty());
515 assert!(bs_second_commitment_update.update_fail_htlcs.is_empty());
516 assert!(bs_second_commitment_update.update_fail_malformed_htlcs.is_empty());
517 assert!(bs_second_commitment_update.update_fee.is_none());
518 check_added_monitors!(nodes[1], 1);
521 if (disconnect_count & 8) == 0 {
524 if disconnect_count & !disconnect_flags > 3 {
525 let (_, _, as_resp, bs_resp) = disconnect_reconnect_peers!();
527 assert!(as_resp.1.unwrap() == initial_revoke_and_ack);
528 assert!(bs_resp.1.is_none());
530 assert!(as_resp.2.unwrap() == as_commitment_update);
531 assert!(bs_resp.2.is_none());
533 assert!(as_resp.3 == RAACommitmentOrder::RevokeAndACKFirst);
536 handle_initial_raa!();
538 if disconnect_count & !disconnect_flags > 4 {
539 let (_, _, as_resp, bs_resp) = disconnect_reconnect_peers!();
541 assert!(as_resp.1.is_none());
542 assert!(bs_resp.1.is_none());
544 assert!(as_resp.2.unwrap() == as_commitment_update);
545 assert!(bs_resp.2.unwrap() == bs_second_commitment_update);
548 handle_initial_raa!();
550 if disconnect_count & !disconnect_flags > 3 {
551 let (_, _, as_resp, bs_resp) = disconnect_reconnect_peers!();
553 assert!(as_resp.1.is_none());
554 assert!(bs_resp.1.unwrap() == bs_revoke_and_ack);
556 assert!(as_resp.2.is_none());
557 assert!(bs_resp.2.unwrap() == bs_second_commitment_update);
559 assert!(bs_resp.3 == RAACommitmentOrder::RevokeAndACKFirst);
564 if disconnect_count & !disconnect_flags > 4 {
565 let (_, _, as_resp, bs_resp) = disconnect_reconnect_peers!();
567 assert!(as_resp.1.is_none());
568 assert!(bs_resp.1.is_none());
570 assert!(as_resp.2.unwrap() == as_commitment_update);
571 assert!(bs_resp.2.unwrap() == bs_second_commitment_update);
575 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_second_commitment_update.commitment_signed);
576 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
577 // No commitment_signed so get_event_msg's assert(len == 1) passes
578 check_added_monitors!(nodes[0], 1);
580 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment_update.commitment_signed);
581 let bs_second_revoke_and_ack = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
582 // No commitment_signed so get_event_msg's assert(len == 1) passes
583 check_added_monitors!(nodes[1], 1);
585 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
586 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
587 check_added_monitors!(nodes[1], 1);
589 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_revoke_and_ack);
590 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
591 check_added_monitors!(nodes[0], 1);
593 expect_pending_htlcs_forwardable!(nodes[1]);
595 let events_5 = nodes[1].node.get_and_clear_pending_events();
596 assert_eq!(events_5.len(), 1);
598 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
599 assert_eq!(payment_hash_2, *payment_hash);
600 assert_eq!(amt, 1000000);
602 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
603 assert!(payment_preimage.is_none());
604 assert_eq!(payment_secret_2, *payment_secret);
606 _ => panic!("expected PaymentPurpose::InvoicePayment")
609 _ => panic!("Unexpected event"),
612 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
616 fn test_monitor_temporary_update_fail_a() {
617 do_test_monitor_temporary_update_fail(0);
618 do_test_monitor_temporary_update_fail(1);
619 do_test_monitor_temporary_update_fail(2);
620 do_test_monitor_temporary_update_fail(3);
621 do_test_monitor_temporary_update_fail(4);
622 do_test_monitor_temporary_update_fail(5);
626 fn test_monitor_temporary_update_fail_b() {
627 do_test_monitor_temporary_update_fail(2 | 8);
628 do_test_monitor_temporary_update_fail(3 | 8);
629 do_test_monitor_temporary_update_fail(4 | 8);
630 do_test_monitor_temporary_update_fail(5 | 8);
634 fn test_monitor_temporary_update_fail_c() {
635 do_test_monitor_temporary_update_fail(1 | 16);
636 do_test_monitor_temporary_update_fail(2 | 16);
637 do_test_monitor_temporary_update_fail(3 | 16);
638 do_test_monitor_temporary_update_fail(2 | 8 | 16);
639 do_test_monitor_temporary_update_fail(3 | 8 | 16);
643 fn test_monitor_update_fail_cs() {
644 // Tests handling of a monitor update failure when processing an incoming commitment_signed
645 let chanmon_cfgs = create_chanmon_cfgs(2);
646 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
647 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
648 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
649 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
650 let logger = test_utils::TestLogger::new();
652 let (payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(nodes[1]);
654 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
655 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
656 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
657 check_added_monitors!(nodes[0], 1);
660 let send_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
661 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event.msgs[0]);
663 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
664 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_event.commitment_msg);
665 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
666 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
667 check_added_monitors!(nodes[1], 1);
668 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
670 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
671 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
672 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
673 check_added_monitors!(nodes[1], 0);
674 let responses = nodes[1].node.get_and_clear_pending_msg_events();
675 assert_eq!(responses.len(), 2);
678 MessageSendEvent::SendRevokeAndACK { ref msg, ref node_id } => {
679 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
680 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &msg);
681 check_added_monitors!(nodes[0], 1);
683 _ => panic!("Unexpected event"),
686 MessageSendEvent::UpdateHTLCs { ref updates, ref node_id } => {
687 assert!(updates.update_add_htlcs.is_empty());
688 assert!(updates.update_fulfill_htlcs.is_empty());
689 assert!(updates.update_fail_htlcs.is_empty());
690 assert!(updates.update_fail_malformed_htlcs.is_empty());
691 assert!(updates.update_fee.is_none());
692 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
694 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
695 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &updates.commitment_signed);
696 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
697 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
698 check_added_monitors!(nodes[0], 1);
699 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
701 _ => panic!("Unexpected event"),
704 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
705 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
706 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
707 check_added_monitors!(nodes[0], 0);
709 let final_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
710 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &final_raa);
711 check_added_monitors!(nodes[1], 1);
713 expect_pending_htlcs_forwardable!(nodes[1]);
715 let events = nodes[1].node.get_and_clear_pending_events();
716 assert_eq!(events.len(), 1);
718 Event::PaymentReceived { payment_hash, ref purpose, amt } => {
719 assert_eq!(payment_hash, our_payment_hash);
720 assert_eq!(amt, 1000000);
722 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
723 assert!(payment_preimage.is_none());
724 assert_eq!(our_payment_secret, *payment_secret);
726 _ => panic!("expected PaymentPurpose::InvoicePayment")
729 _ => panic!("Unexpected event"),
732 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
736 fn test_monitor_update_fail_no_rebroadcast() {
737 // Tests handling of a monitor update failure when no message rebroadcasting on
738 // channel_monitor_updated() is required. Backported from chanmon_fail_consistency
740 let chanmon_cfgs = create_chanmon_cfgs(2);
741 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
742 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
743 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
744 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
745 let logger = test_utils::TestLogger::new();
747 let (payment_preimage_1, our_payment_hash, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
749 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
750 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
751 nodes[0].node.send_payment(&route, our_payment_hash, &Some(payment_secret_1)).unwrap();
752 check_added_monitors!(nodes[0], 1);
755 let send_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
756 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event.msgs[0]);
757 let bs_raa = commitment_signed_dance!(nodes[1], nodes[0], send_event.commitment_msg, false, true, false, true);
759 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
760 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &bs_raa);
761 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
762 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
763 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
764 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
765 check_added_monitors!(nodes[1], 1);
767 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
768 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
769 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
770 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
771 check_added_monitors!(nodes[1], 0);
772 expect_pending_htlcs_forwardable!(nodes[1]);
774 let events = nodes[1].node.get_and_clear_pending_events();
775 assert_eq!(events.len(), 1);
777 Event::PaymentReceived { payment_hash, .. } => {
778 assert_eq!(payment_hash, our_payment_hash);
780 _ => panic!("Unexpected event"),
783 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
787 fn test_monitor_update_raa_while_paused() {
788 // Tests handling of an RAA while monitor updating has already been marked failed.
789 // Backported from chanmon_fail_consistency fuzz tests as this used to be broken.
790 let chanmon_cfgs = create_chanmon_cfgs(2);
791 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
792 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
793 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
794 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
795 let logger = test_utils::TestLogger::new();
797 send_payment(&nodes[0], &[&nodes[1]], 5000000);
798 let (payment_preimage_1, our_payment_hash_1, our_payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
800 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
801 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
802 nodes[0].node.send_payment(&route, our_payment_hash_1, &Some(our_payment_secret_1)).unwrap();
803 check_added_monitors!(nodes[0], 1);
805 let send_event_1 = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
807 let (payment_preimage_2, our_payment_hash_2, our_payment_secret_2) = get_payment_preimage_hash!(nodes[0]);
809 let net_graph_msg_handler = &nodes[1].net_graph_msg_handler;
810 let route = get_route(&nodes[1].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
811 nodes[1].node.send_payment(&route, our_payment_hash_2, &Some(our_payment_secret_2)).unwrap();
812 check_added_monitors!(nodes[1], 1);
814 let send_event_2 = SendEvent::from_event(nodes[1].node.get_and_clear_pending_msg_events().remove(0));
816 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event_1.msgs[0]);
817 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_event_1.commitment_msg);
818 check_added_monitors!(nodes[1], 1);
819 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
821 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
822 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_event_2.msgs[0]);
823 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_event_2.commitment_msg);
824 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
825 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
826 check_added_monitors!(nodes[0], 1);
828 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
829 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
830 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented responses to RAA".to_string(), 1);
831 check_added_monitors!(nodes[0], 1);
833 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
834 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
835 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
836 check_added_monitors!(nodes[0], 0);
838 let as_update_raa = get_revoke_commit_msgs!(nodes[0], nodes[1].node.get_our_node_id());
839 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_update_raa.0);
840 check_added_monitors!(nodes[1], 1);
841 let bs_cs = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
843 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_update_raa.1);
844 check_added_monitors!(nodes[1], 1);
845 let bs_second_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
847 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_cs.commitment_signed);
848 check_added_monitors!(nodes[0], 1);
849 let as_second_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
851 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_second_raa);
852 check_added_monitors!(nodes[0], 1);
853 expect_pending_htlcs_forwardable!(nodes[0]);
854 expect_payment_received!(nodes[0], our_payment_hash_2, our_payment_secret_2, 1000000);
856 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_second_raa);
857 check_added_monitors!(nodes[1], 1);
858 expect_pending_htlcs_forwardable!(nodes[1]);
859 expect_payment_received!(nodes[1], our_payment_hash_1, our_payment_secret_1, 1000000);
861 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
862 claim_payment(&nodes[1], &[&nodes[0]], payment_preimage_2);
865 fn do_test_monitor_update_fail_raa(test_ignore_second_cs: bool) {
866 // Tests handling of a monitor update failure when processing an incoming RAA
867 let chanmon_cfgs = create_chanmon_cfgs(3);
868 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
869 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
870 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
871 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
872 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
873 let logger = test_utils::TestLogger::new();
875 // Rebalance a bit so that we can send backwards from 2 to 1.
876 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 5000000);
878 // Route a first payment that we'll fail backwards
879 let (_, payment_hash_1, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000);
881 // Fail the payment backwards, failing the monitor update on nodes[1]'s receipt of the RAA
882 assert!(nodes[2].node.fail_htlc_backwards(&payment_hash_1));
883 expect_pending_htlcs_forwardable!(nodes[2]);
884 check_added_monitors!(nodes[2], 1);
886 let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
887 assert!(updates.update_add_htlcs.is_empty());
888 assert!(updates.update_fulfill_htlcs.is_empty());
889 assert_eq!(updates.update_fail_htlcs.len(), 1);
890 assert!(updates.update_fail_malformed_htlcs.is_empty());
891 assert!(updates.update_fee.is_none());
892 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
894 let bs_revoke_and_ack = commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false, true, false, true);
895 check_added_monitors!(nodes[0], 0);
897 // While the second channel is AwaitingRAA, forward a second payment to get it into the
899 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[2]);
901 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
902 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
903 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
904 check_added_monitors!(nodes[0], 1);
907 let mut send_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
908 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event.msgs[0]);
909 commitment_signed_dance!(nodes[1], nodes[0], send_event.commitment_msg, false);
911 expect_pending_htlcs_forwardable!(nodes[1]);
912 check_added_monitors!(nodes[1], 0);
913 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
915 // Now fail monitor updating.
916 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
917 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
918 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
919 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
920 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
921 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
922 check_added_monitors!(nodes[1], 1);
924 // Forward a third payment which will also be added to the holding cell, despite the channel
925 // being paused waiting a monitor update.
926 let (_, payment_hash_3, payment_secret_3) = get_payment_preimage_hash!(nodes[2]);
928 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
929 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[2].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
930 nodes[0].node.send_payment(&route, payment_hash_3, &Some(payment_secret_3)).unwrap();
931 check_added_monitors!(nodes[0], 1);
934 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(())); // We succeed in updating the monitor for the first channel
935 send_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
936 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event.msgs[0]);
937 commitment_signed_dance!(nodes[1], nodes[0], send_event.commitment_msg, false, true);
938 check_added_monitors!(nodes[1], 0);
940 // Call forward_pending_htlcs and check that the new HTLC was simply added to the holding cell
941 // and not forwarded.
942 expect_pending_htlcs_forwardable!(nodes[1]);
943 check_added_monitors!(nodes[1], 0);
944 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
946 let (payment_preimage_4, payment_hash_4) = if test_ignore_second_cs {
947 // Try to route another payment backwards from 2 to make sure 1 holds off on responding
948 let (payment_preimage_4, payment_hash_4, payment_secret_4) = get_payment_preimage_hash!(nodes[0]);
949 let net_graph_msg_handler = &nodes[2].net_graph_msg_handler;
950 let route = get_route(&nodes[2].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
951 nodes[2].node.send_payment(&route, payment_hash_4, &Some(payment_secret_4)).unwrap();
952 check_added_monitors!(nodes[2], 1);
954 send_event = SendEvent::from_event(nodes[2].node.get_and_clear_pending_msg_events().remove(0));
955 nodes[1].node.handle_update_add_htlc(&nodes[2].node.get_our_node_id(), &send_event.msgs[0]);
956 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &send_event.commitment_msg);
957 check_added_monitors!(nodes[1], 1);
958 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
959 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented generation of RAA".to_string(), 1);
960 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
961 (Some(payment_preimage_4), Some(payment_hash_4))
962 } else { (None, None) };
964 // Restore monitor updating, ensuring we immediately get a fail-back update and a
965 // update_add update.
966 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
967 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_2.2).unwrap().clone();
968 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
969 check_added_monitors!(nodes[1], 0);
970 expect_pending_htlcs_forwardable!(nodes[1]);
971 check_added_monitors!(nodes[1], 1);
973 let mut events_3 = nodes[1].node.get_and_clear_pending_msg_events();
974 if test_ignore_second_cs {
975 assert_eq!(events_3.len(), 3);
977 assert_eq!(events_3.len(), 2);
980 // Note that the ordering of the events for different nodes is non-prescriptive, though the
981 // ordering of the two events that both go to nodes[2] have to stay in the same order.
982 let messages_a = match events_3.pop().unwrap() {
983 MessageSendEvent::UpdateHTLCs { node_id, mut updates } => {
984 assert_eq!(node_id, nodes[0].node.get_our_node_id());
985 assert!(updates.update_fulfill_htlcs.is_empty());
986 assert_eq!(updates.update_fail_htlcs.len(), 1);
987 assert!(updates.update_fail_malformed_htlcs.is_empty());
988 assert!(updates.update_add_htlcs.is_empty());
989 assert!(updates.update_fee.is_none());
990 (updates.update_fail_htlcs.remove(0), updates.commitment_signed)
992 _ => panic!("Unexpected event type!"),
994 let raa = if test_ignore_second_cs {
995 match events_3.remove(1) {
996 MessageSendEvent::SendRevokeAndACK { node_id, msg } => {
997 assert_eq!(node_id, nodes[2].node.get_our_node_id());
1000 _ => panic!("Unexpected event"),
1003 let send_event_b = SendEvent::from_event(events_3.remove(0));
1004 assert_eq!(send_event_b.node_id, nodes[2].node.get_our_node_id());
1006 // Now deliver the new messages...
1008 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &messages_a.0);
1009 commitment_signed_dance!(nodes[0], nodes[1], messages_a.1, false);
1010 expect_payment_failed!(nodes[0], payment_hash_1, true);
1012 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_event_b.msgs[0]);
1014 if test_ignore_second_cs {
1015 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_event_b.commitment_msg);
1016 check_added_monitors!(nodes[2], 1);
1017 let bs_revoke_and_ack = get_event_msg!(nodes[2], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1018 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa.unwrap());
1019 check_added_monitors!(nodes[2], 1);
1020 let bs_cs = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1021 assert!(bs_cs.update_add_htlcs.is_empty());
1022 assert!(bs_cs.update_fail_htlcs.is_empty());
1023 assert!(bs_cs.update_fail_malformed_htlcs.is_empty());
1024 assert!(bs_cs.update_fulfill_htlcs.is_empty());
1025 assert!(bs_cs.update_fee.is_none());
1027 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_revoke_and_ack);
1028 check_added_monitors!(nodes[1], 1);
1029 as_cs = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1031 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_cs.commitment_signed);
1032 check_added_monitors!(nodes[1], 1);
1034 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &send_event_b.commitment_msg);
1035 check_added_monitors!(nodes[2], 1);
1037 let bs_revoke_and_commit = nodes[2].node.get_and_clear_pending_msg_events();
1038 assert_eq!(bs_revoke_and_commit.len(), 2);
1039 match bs_revoke_and_commit[0] {
1040 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1041 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
1042 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &msg);
1043 check_added_monitors!(nodes[1], 1);
1045 _ => panic!("Unexpected event"),
1048 as_cs = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1050 match bs_revoke_and_commit[1] {
1051 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1052 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
1053 assert!(updates.update_add_htlcs.is_empty());
1054 assert!(updates.update_fail_htlcs.is_empty());
1055 assert!(updates.update_fail_malformed_htlcs.is_empty());
1056 assert!(updates.update_fulfill_htlcs.is_empty());
1057 assert!(updates.update_fee.is_none());
1058 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &updates.commitment_signed);
1059 check_added_monitors!(nodes[1], 1);
1061 _ => panic!("Unexpected event"),
1065 assert_eq!(as_cs.update_add_htlcs.len(), 1);
1066 assert!(as_cs.update_fail_htlcs.is_empty());
1067 assert!(as_cs.update_fail_malformed_htlcs.is_empty());
1068 assert!(as_cs.update_fulfill_htlcs.is_empty());
1069 assert!(as_cs.update_fee.is_none());
1070 let as_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1073 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &as_cs.update_add_htlcs[0]);
1074 nodes[2].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &as_cs.commitment_signed);
1075 check_added_monitors!(nodes[2], 1);
1076 let bs_second_raa = get_event_msg!(nodes[2], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1078 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_raa);
1079 check_added_monitors!(nodes[2], 1);
1080 let bs_second_cs = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1082 nodes[1].node.handle_revoke_and_ack(&nodes[2].node.get_our_node_id(), &bs_second_raa);
1083 check_added_monitors!(nodes[1], 1);
1084 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1086 nodes[1].node.handle_commitment_signed(&nodes[2].node.get_our_node_id(), &bs_second_cs.commitment_signed);
1087 check_added_monitors!(nodes[1], 1);
1088 let as_second_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[2].node.get_our_node_id());
1090 nodes[2].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &as_second_raa);
1091 check_added_monitors!(nodes[2], 1);
1092 assert!(nodes[2].node.get_and_clear_pending_msg_events().is_empty());
1094 expect_pending_htlcs_forwardable!(nodes[2]);
1096 let events_6 = nodes[2].node.get_and_clear_pending_events();
1097 assert_eq!(events_6.len(), 2);
1099 Event::PaymentReceived { payment_hash, .. } => { assert_eq!(payment_hash, payment_hash_2); },
1100 _ => panic!("Unexpected event"),
1103 Event::PaymentReceived { payment_hash, .. } => { assert_eq!(payment_hash, payment_hash_3); },
1104 _ => panic!("Unexpected event"),
1107 if test_ignore_second_cs {
1108 expect_pending_htlcs_forwardable!(nodes[1]);
1109 check_added_monitors!(nodes[1], 1);
1111 send_event = SendEvent::from_node(&nodes[1]);
1112 assert_eq!(send_event.node_id, nodes[0].node.get_our_node_id());
1113 assert_eq!(send_event.msgs.len(), 1);
1114 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &send_event.msgs[0]);
1115 commitment_signed_dance!(nodes[0], nodes[1], send_event.commitment_msg, false);
1117 expect_pending_htlcs_forwardable!(nodes[0]);
1119 let events_9 = nodes[0].node.get_and_clear_pending_events();
1120 assert_eq!(events_9.len(), 1);
1122 Event::PaymentReceived { payment_hash, .. } => assert_eq!(payment_hash, payment_hash_4.unwrap()),
1123 _ => panic!("Unexpected event"),
1125 claim_payment(&nodes[2], &[&nodes[1], &nodes[0]], payment_preimage_4.unwrap());
1128 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage_2);
1132 fn test_monitor_update_fail_raa() {
1133 do_test_monitor_update_fail_raa(false);
1134 do_test_monitor_update_fail_raa(true);
1138 fn test_monitor_update_fail_reestablish() {
1139 // Simple test for message retransmission after monitor update failure on
1140 // channel_reestablish generating a monitor update (which comes from freeing holding cell
1142 let chanmon_cfgs = create_chanmon_cfgs(3);
1143 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1144 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1145 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1146 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1147 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1149 let (our_payment_preimage, _, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000);
1151 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1152 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1154 assert!(nodes[2].node.claim_funds(our_payment_preimage));
1155 check_added_monitors!(nodes[2], 1);
1156 let mut updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1157 assert!(updates.update_add_htlcs.is_empty());
1158 assert!(updates.update_fail_htlcs.is_empty());
1159 assert!(updates.update_fail_malformed_htlcs.is_empty());
1160 assert!(updates.update_fee.is_none());
1161 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
1162 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1163 expect_payment_forwarded!(nodes[1], Some(1000), false);
1164 check_added_monitors!(nodes[1], 1);
1165 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1166 commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, false);
1168 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1169 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1170 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1172 let as_reestablish = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1173 let bs_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1175 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
1177 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
1179 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id())
1180 .contents.flags & 2, 0); // The "disabled" bit should be unset as we just reconnected
1182 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1183 check_added_monitors!(nodes[1], 1);
1185 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1186 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1188 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1189 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1191 assert!(as_reestablish == get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id()));
1192 assert!(bs_reestablish == get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id()));
1194 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
1196 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id())
1197 .contents.flags & 2, 0); // The "disabled" bit should be unset as we just reconnected
1199 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
1200 check_added_monitors!(nodes[1], 0);
1202 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id())
1203 .contents.flags & 2, 0); // The "disabled" bit should be unset as we just reconnected
1205 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1206 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_1.2).unwrap().clone();
1207 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1208 check_added_monitors!(nodes[1], 0);
1210 updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1211 assert!(updates.update_add_htlcs.is_empty());
1212 assert!(updates.update_fail_htlcs.is_empty());
1213 assert!(updates.update_fail_malformed_htlcs.is_empty());
1214 assert!(updates.update_fee.is_none());
1215 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
1216 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1217 commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
1219 let events = nodes[0].node.get_and_clear_pending_events();
1220 assert_eq!(events.len(), 1);
1222 Event::PaymentSent { payment_preimage, .. } => assert_eq!(payment_preimage, our_payment_preimage),
1223 _ => panic!("Unexpected event"),
1228 fn raa_no_response_awaiting_raa_state() {
1229 // This is a rather convoluted test which ensures that if handling of an RAA does not happen
1230 // due to a previous monitor update failure, we still set AwaitingRemoteRevoke on the channel
1231 // in question (assuming it intends to respond with a CS after monitor updating is restored).
1232 // Backported from chanmon_fail_consistency fuzz tests as this used to be broken.
1233 let chanmon_cfgs = create_chanmon_cfgs(2);
1234 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1235 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1236 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1237 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
1238 let logger = test_utils::TestLogger::new();
1240 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
1241 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
1242 let (payment_preimage_3, payment_hash_3, payment_secret_3) = get_payment_preimage_hash!(nodes[1]);
1244 // Queue up two payments - one will be delivered right away, one immediately goes into the
1245 // holding cell as nodes[0] is AwaitingRAA. Ultimately this allows us to deliver an RAA
1246 // immediately after a CS. By setting failing the monitor update failure from the CS (which
1247 // requires only an RAA response due to AwaitingRAA) we can deliver the RAA and require the CS
1248 // generation during RAA while in monitor-update-failed state.
1250 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1251 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1252 nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)).unwrap();
1253 check_added_monitors!(nodes[0], 1);
1254 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1255 check_added_monitors!(nodes[0], 0);
1258 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1259 assert_eq!(events.len(), 1);
1260 let payment_event = SendEvent::from_event(events.pop().unwrap());
1261 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1262 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1263 check_added_monitors!(nodes[1], 1);
1265 let bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1266 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_responses.0);
1267 check_added_monitors!(nodes[0], 1);
1268 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1269 assert_eq!(events.len(), 1);
1270 let payment_event = SendEvent::from_event(events.pop().unwrap());
1272 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_responses.1);
1273 check_added_monitors!(nodes[0], 1);
1274 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1276 // Now we have a CS queued up which adds a new HTLC (which will need a RAA/CS response from
1277 // nodes[1]) followed by an RAA. Fail the monitor updating prior to the CS, deliver the RAA,
1278 // then restore channel monitor updates.
1279 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1280 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1281 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1282 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1283 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1284 check_added_monitors!(nodes[1], 1);
1286 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1287 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1288 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented responses to RAA".to_string(), 1);
1289 check_added_monitors!(nodes[1], 1);
1291 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1292 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1293 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1294 // nodes[1] should be AwaitingRAA here!
1295 check_added_monitors!(nodes[1], 0);
1296 let bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1297 expect_pending_htlcs_forwardable!(nodes[1]);
1298 expect_payment_received!(nodes[1], payment_hash_1, payment_secret_1, 1000000);
1300 // We send a third payment here, which is somewhat of a redundant test, but the
1301 // chanmon_fail_consistency test required it to actually find the bug (by seeing out-of-sync
1302 // commitment transaction states) whereas here we can explicitly check for it.
1304 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1305 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1306 nodes[0].node.send_payment(&route, payment_hash_3, &Some(payment_secret_3)).unwrap();
1307 check_added_monitors!(nodes[0], 0);
1308 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1310 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_responses.0);
1311 check_added_monitors!(nodes[0], 1);
1312 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1313 assert_eq!(events.len(), 1);
1314 let payment_event = SendEvent::from_event(events.pop().unwrap());
1316 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_responses.1);
1317 check_added_monitors!(nodes[0], 1);
1318 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1320 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1321 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1322 check_added_monitors!(nodes[1], 1);
1323 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1325 // Finally deliver the RAA to nodes[1] which results in a CS response to the last update
1326 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1327 check_added_monitors!(nodes[1], 1);
1328 expect_pending_htlcs_forwardable!(nodes[1]);
1329 expect_payment_received!(nodes[1], payment_hash_2, payment_secret_2, 1000000);
1330 let bs_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1332 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1333 check_added_monitors!(nodes[0], 1);
1335 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_update.commitment_signed);
1336 check_added_monitors!(nodes[0], 1);
1337 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1339 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1340 check_added_monitors!(nodes[1], 1);
1341 expect_pending_htlcs_forwardable!(nodes[1]);
1342 expect_payment_received!(nodes[1], payment_hash_3, payment_secret_3, 1000000);
1344 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
1345 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
1346 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_3);
1350 fn claim_while_disconnected_monitor_update_fail() {
1351 // Test for claiming a payment while disconnected and then having the resulting
1352 // channel-update-generated monitor update fail. This kind of thing isn't a particularly
1353 // contrived case for nodes with network instability.
1354 // Backported from chanmon_fail_consistency fuzz tests as an unmerged version of the handling
1355 // code introduced a regression in this test (specifically, this caught a removal of the
1356 // channel_reestablish handling ensuring the order was sensical given the messages used).
1357 let chanmon_cfgs = create_chanmon_cfgs(2);
1358 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1359 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1360 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1361 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
1362 let logger = test_utils::TestLogger::new();
1364 // Forward a payment for B to claim
1365 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
1367 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1368 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1370 assert!(nodes[1].node.claim_funds(payment_preimage_1));
1371 check_added_monitors!(nodes[1], 1);
1373 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1374 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1376 let as_reconnect = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1377 let bs_reconnect = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1379 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reconnect);
1380 let _as_channel_update = get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
1382 // Now deliver a's reestablish, freeing the claim from the holding cell, but fail the monitor
1384 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1386 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reconnect);
1387 let _bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
1388 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1389 check_added_monitors!(nodes[1], 1);
1390 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1392 // Send a second payment from A to B, resulting in a commitment update that gets swallowed with
1393 // the monitor still failed
1394 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
1396 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1397 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1398 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1399 check_added_monitors!(nodes[0], 1);
1402 let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1403 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
1404 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_updates.commitment_signed);
1405 check_added_monitors!(nodes[1], 1);
1406 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1407 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented generation of RAA".to_string(), 1);
1408 // Note that nodes[1] not updating monitor here is OK - it wont take action on the new HTLC
1409 // until we've channel_monitor_update'd and updated for the new commitment transaction.
1411 // Now un-fail the monitor, which will result in B sending its original commitment update,
1412 // receiving the commitment update from A, and the resulting commitment dances.
1413 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1414 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1415 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1416 check_added_monitors!(nodes[1], 0);
1418 let bs_msgs = nodes[1].node.get_and_clear_pending_msg_events();
1419 assert_eq!(bs_msgs.len(), 2);
1422 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1423 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
1424 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
1425 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &updates.commitment_signed);
1426 check_added_monitors!(nodes[0], 1);
1428 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1429 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1430 check_added_monitors!(nodes[1], 1);
1432 _ => panic!("Unexpected event"),
1436 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1437 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
1438 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), msg);
1439 check_added_monitors!(nodes[0], 1);
1441 _ => panic!("Unexpected event"),
1444 let as_commitment = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1446 let bs_commitment = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1447 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment.commitment_signed);
1448 check_added_monitors!(nodes[0], 1);
1449 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1451 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_commitment.commitment_signed);
1452 check_added_monitors!(nodes[1], 1);
1453 let bs_raa = get_event_msg!(nodes[1], MessageSendEvent::SendRevokeAndACK, nodes[0].node.get_our_node_id());
1454 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1455 check_added_monitors!(nodes[1], 1);
1457 expect_pending_htlcs_forwardable!(nodes[1]);
1458 expect_payment_received!(nodes[1], payment_hash_2, payment_secret_2, 1000000);
1460 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
1461 check_added_monitors!(nodes[0], 1);
1463 let events = nodes[0].node.get_and_clear_pending_events();
1464 assert_eq!(events.len(), 1);
1466 Event::PaymentSent { ref payment_preimage } => {
1467 assert_eq!(*payment_preimage, payment_preimage_1);
1469 _ => panic!("Unexpected event"),
1472 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
1476 fn monitor_failed_no_reestablish_response() {
1477 // Test for receiving a channel_reestablish after a monitor update failure resulted in no
1478 // response to a commitment_signed.
1479 // Backported from chanmon_fail_consistency fuzz tests as it caught a long-standing
1480 // debug_assert!() failure in channel_reestablish handling.
1481 let chanmon_cfgs = create_chanmon_cfgs(2);
1482 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1483 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1484 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1485 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
1486 let logger = test_utils::TestLogger::new();
1488 // Route the payment and deliver the initial commitment_signed (with a monitor update failure
1490 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
1492 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1493 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1494 nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)).unwrap();
1495 check_added_monitors!(nodes[0], 1);
1498 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1499 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1500 assert_eq!(events.len(), 1);
1501 let payment_event = SendEvent::from_event(events.pop().unwrap());
1502 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1503 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1504 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1505 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1506 check_added_monitors!(nodes[1], 1);
1508 // Now disconnect and immediately reconnect, delivering the channel_reestablish while nodes[1]
1509 // is still failing to update monitors.
1510 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1511 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1513 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1514 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1516 let as_reconnect = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReestablish, nodes[1].node.get_our_node_id());
1517 let bs_reconnect = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
1519 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reconnect);
1520 let _bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
1521 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reconnect);
1522 let _as_channel_update = get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
1524 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1525 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1526 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1527 check_added_monitors!(nodes[1], 0);
1528 let bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1530 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_responses.0);
1531 check_added_monitors!(nodes[0], 1);
1532 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_responses.1);
1533 check_added_monitors!(nodes[0], 1);
1535 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1536 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1537 check_added_monitors!(nodes[1], 1);
1539 expect_pending_htlcs_forwardable!(nodes[1]);
1540 expect_payment_received!(nodes[1], payment_hash_1, payment_secret_1, 1000000);
1542 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
1546 fn first_message_on_recv_ordering() {
1547 // Test that if the initial generator of a monitor-update-frozen state doesn't generate
1548 // messages, we're willing to flip the order of response messages if neccessary in resposne to
1549 // a commitment_signed which needs to send an RAA first.
1550 // At a high level, our goal is to fail monitor updating in response to an RAA which needs no
1551 // response and then handle a CS while in the failed state, requiring an RAA followed by a CS
1552 // response. To do this, we start routing two payments, with the final RAA for the first being
1553 // delivered while B is in AwaitingRAA, hence when we deliver the CS for the second B will
1554 // have no pending response but will want to send a RAA/CS (with the updates for the second
1555 // payment applied).
1556 // Backported from chanmon_fail_consistency fuzz tests as it caught a bug here.
1557 let chanmon_cfgs = create_chanmon_cfgs(2);
1558 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1559 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1560 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1561 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
1562 let logger = test_utils::TestLogger::new();
1564 // Route the first payment outbound, holding the last RAA for B until we are set up so that we
1565 // can deliver it and fail the monitor update.
1566 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(nodes[1]);
1568 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1569 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1570 nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)).unwrap();
1571 check_added_monitors!(nodes[0], 1);
1574 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1575 assert_eq!(events.len(), 1);
1576 let payment_event = SendEvent::from_event(events.pop().unwrap());
1577 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
1578 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1579 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1580 check_added_monitors!(nodes[1], 1);
1581 let bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1583 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_responses.0);
1584 check_added_monitors!(nodes[0], 1);
1585 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_responses.1);
1586 check_added_monitors!(nodes[0], 1);
1588 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1590 // Route the second payment, generating an update_add_htlc/commitment_signed
1591 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
1593 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1594 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1595 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1596 check_added_monitors!(nodes[0], 1);
1598 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1599 assert_eq!(events.len(), 1);
1600 let payment_event = SendEvent::from_event(events.pop().unwrap());
1601 assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
1603 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1605 // Deliver the final RAA for the first payment, which does not require a response. RAAs
1606 // generally require a commitment_signed, so the fact that we're expecting an opposite response
1607 // to the next message also tests resetting the delivery order.
1608 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1609 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1610 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1611 check_added_monitors!(nodes[1], 1);
1613 // Now deliver the update_add_htlc/commitment_signed for the second payment, which does need an
1614 // RAA/CS response, which should be generated when we call channel_monitor_update (with the
1615 // appropriate HTLC acceptance).
1616 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1617 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
1618 check_added_monitors!(nodes[1], 1);
1619 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1620 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Previous monitor update failure prevented generation of RAA".to_string(), 1);
1622 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1623 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1624 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1625 check_added_monitors!(nodes[1], 0);
1627 expect_pending_htlcs_forwardable!(nodes[1]);
1628 expect_payment_received!(nodes[1], payment_hash_1, payment_secret_1, 1000000);
1630 let bs_responses = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1631 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_responses.0);
1632 check_added_monitors!(nodes[0], 1);
1633 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_responses.1);
1634 check_added_monitors!(nodes[0], 1);
1636 let as_raa = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
1637 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1638 check_added_monitors!(nodes[1], 1);
1640 expect_pending_htlcs_forwardable!(nodes[1]);
1641 expect_payment_received!(nodes[1], payment_hash_2, payment_secret_2, 1000000);
1643 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
1644 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
1648 fn test_monitor_update_fail_claim() {
1649 // Basic test for monitor update failures when processing claim_funds calls.
1650 // We set up a simple 3-node network, sending a payment from A to B and failing B's monitor
1651 // update to claim the payment. We then send two payments C->B->A, which are held at B.
1652 // Finally, we restore the channel monitor updating and claim the payment on B, forwarding
1653 // the payments from C onwards to A.
1654 let chanmon_cfgs = create_chanmon_cfgs(3);
1655 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1656 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1657 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1658 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1659 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1660 let logger = test_utils::TestLogger::new();
1662 // Rebalance a bit so that we can send backwards from 3 to 2.
1663 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 5000000);
1665 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
1667 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1668 assert!(nodes[1].node.claim_funds(payment_preimage_1));
1669 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Temporary failure claiming HTLC, treating as success: Failed to update ChannelMonitor".to_string(), 1);
1670 check_added_monitors!(nodes[1], 1);
1672 // Note that at this point there is a pending commitment transaction update for A being held by
1673 // B. Even when we go to send the payment from C through B to A, B will not update this
1674 // already-signed commitment transaction and will instead wait for it to resolve before
1675 // forwarding the payment onwards.
1677 let (_, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[0]);
1680 let net_graph_msg_handler = &nodes[2].net_graph_msg_handler;
1681 route = get_route(&nodes[2].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1_000_000, TEST_FINAL_CLTV, &logger).unwrap();
1682 nodes[2].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1683 check_added_monitors!(nodes[2], 1);
1686 // Successfully update the monitor on the 1<->2 channel, but the 0<->1 channel should still be
1687 // paused, so forward shouldn't succeed until we call channel_monitor_updated().
1688 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1690 let mut events = nodes[2].node.get_and_clear_pending_msg_events();
1691 assert_eq!(events.len(), 1);
1692 let payment_event = SendEvent::from_event(events.pop().unwrap());
1693 nodes[1].node.handle_update_add_htlc(&nodes[2].node.get_our_node_id(), &payment_event.msgs[0]);
1694 let events = nodes[1].node.get_and_clear_pending_msg_events();
1695 assert_eq!(events.len(), 0);
1696 commitment_signed_dance!(nodes[1], nodes[2], payment_event.commitment_msg, false, true);
1698 let (_, payment_hash_3, payment_secret_3) = get_payment_preimage_hash!(nodes[0]);
1699 nodes[2].node.send_payment(&route, payment_hash_3, &Some(payment_secret_3)).unwrap();
1700 check_added_monitors!(nodes[2], 1);
1702 let mut events = nodes[2].node.get_and_clear_pending_msg_events();
1703 assert_eq!(events.len(), 1);
1704 let payment_event = SendEvent::from_event(events.pop().unwrap());
1705 nodes[1].node.handle_update_add_htlc(&nodes[2].node.get_our_node_id(), &payment_event.msgs[0]);
1706 let events = nodes[1].node.get_and_clear_pending_msg_events();
1707 assert_eq!(events.len(), 0);
1708 commitment_signed_dance!(nodes[1], nodes[2], payment_event.commitment_msg, false, true);
1710 // Now restore monitor updating on the 0<->1 channel and claim the funds on B.
1711 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_1.2).unwrap().clone();
1712 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1713 check_added_monitors!(nodes[1], 0);
1715 let bs_fulfill_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1716 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_fulfill_update.update_fulfill_htlcs[0]);
1717 commitment_signed_dance!(nodes[0], nodes[1], bs_fulfill_update.commitment_signed, false);
1718 expect_payment_sent!(nodes[0], payment_preimage_1);
1720 // Get the payment forwards, note that they were batched into one commitment update.
1721 expect_pending_htlcs_forwardable!(nodes[1]);
1722 check_added_monitors!(nodes[1], 1);
1723 let bs_forward_update = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1724 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_forward_update.update_add_htlcs[0]);
1725 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_forward_update.update_add_htlcs[1]);
1726 commitment_signed_dance!(nodes[0], nodes[1], bs_forward_update.commitment_signed, false);
1727 expect_pending_htlcs_forwardable!(nodes[0]);
1729 let events = nodes[0].node.get_and_clear_pending_events();
1730 assert_eq!(events.len(), 2);
1732 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
1733 assert_eq!(payment_hash_2, *payment_hash);
1734 assert_eq!(1_000_000, amt);
1736 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1737 assert!(payment_preimage.is_none());
1738 assert_eq!(payment_secret_2, *payment_secret);
1740 _ => panic!("expected PaymentPurpose::InvoicePayment")
1743 _ => panic!("Unexpected event"),
1746 Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
1747 assert_eq!(payment_hash_3, *payment_hash);
1748 assert_eq!(1_000_000, amt);
1750 PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1751 assert!(payment_preimage.is_none());
1752 assert_eq!(payment_secret_3, *payment_secret);
1754 _ => panic!("expected PaymentPurpose::InvoicePayment")
1757 _ => panic!("Unexpected event"),
1762 fn test_monitor_update_on_pending_forwards() {
1763 // Basic test for monitor update failures when processing pending HTLC fail/add forwards.
1764 // We do this with a simple 3-node network, sending a payment from A to C and one from C to A.
1765 // The payment from A to C will be failed by C and pending a back-fail to A, while the payment
1766 // from C to A will be pending a forward to A.
1767 let chanmon_cfgs = create_chanmon_cfgs(3);
1768 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1769 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1770 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1771 let chan_1 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
1772 create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
1773 let logger = test_utils::TestLogger::new();
1775 // Rebalance a bit so that we can send backwards from 3 to 1.
1776 send_payment(&nodes[0], &[&nodes[1], &nodes[2]], 5000000);
1778 let (_, payment_hash_1, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 1000000);
1779 assert!(nodes[2].node.fail_htlc_backwards(&payment_hash_1));
1780 expect_pending_htlcs_forwardable!(nodes[2]);
1781 check_added_monitors!(nodes[2], 1);
1783 let cs_fail_update = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1784 nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &cs_fail_update.update_fail_htlcs[0]);
1785 commitment_signed_dance!(nodes[1], nodes[2], cs_fail_update.commitment_signed, true, true);
1786 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1788 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[0]);
1790 let net_graph_msg_handler = &nodes[2].net_graph_msg_handler;
1791 let route = get_route(&nodes[2].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[0].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1792 nodes[2].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1793 check_added_monitors!(nodes[2], 1);
1796 let mut events = nodes[2].node.get_and_clear_pending_msg_events();
1797 assert_eq!(events.len(), 1);
1798 let payment_event = SendEvent::from_event(events.pop().unwrap());
1799 nodes[1].node.handle_update_add_htlc(&nodes[2].node.get_our_node_id(), &payment_event.msgs[0]);
1800 commitment_signed_dance!(nodes[1], nodes[2], payment_event.commitment_msg, false);
1802 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1803 expect_pending_htlcs_forwardable!(nodes[1]);
1804 check_added_monitors!(nodes[1], 1);
1805 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1806 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1808 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1809 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_1.2).unwrap().clone();
1810 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1811 check_added_monitors!(nodes[1], 0);
1813 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1814 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
1815 nodes[0].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_add_htlcs[0]);
1816 commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
1818 let events = nodes[0].node.get_and_clear_pending_events();
1819 assert_eq!(events.len(), 2);
1820 if let Event::PaymentFailed { payment_hash, rejected_by_dest, .. } = events[0] {
1821 assert_eq!(payment_hash, payment_hash_1);
1822 assert!(rejected_by_dest);
1823 } else { panic!("Unexpected event!"); }
1825 Event::PendingHTLCsForwardable { .. } => { },
1826 _ => panic!("Unexpected event"),
1828 nodes[0].node.process_pending_htlc_forwards();
1829 expect_payment_received!(nodes[0], payment_hash_2, payment_secret_2, 1000000);
1831 claim_payment(&nodes[2], &[&nodes[1], &nodes[0]], payment_preimage_2);
1835 fn monitor_update_claim_fail_no_response() {
1836 // Test for claim_funds resulting in both a monitor update failure and no message response (due
1837 // to channel being AwaitingRAA).
1838 // Backported from chanmon_fail_consistency fuzz tests as an unmerged version of the handling
1840 let chanmon_cfgs = create_chanmon_cfgs(2);
1841 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1842 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1843 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1844 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
1845 let logger = test_utils::TestLogger::new();
1847 // Forward a payment for B to claim
1848 let (payment_preimage_1, _, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000);
1850 // Now start forwarding a second payment, skipping the last RAA so B is in AwaitingRAA
1851 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(nodes[1]);
1853 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
1854 let route = get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 1000000, TEST_FINAL_CLTV, &logger).unwrap();
1855 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
1856 check_added_monitors!(nodes[0], 1);
1859 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1860 assert_eq!(events.len(), 1);
1861 let payment_event = SendEvent::from_event(events.pop().unwrap());
1862 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1863 let as_raa = commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true, false, true);
1865 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1866 assert!(nodes[1].node.claim_funds(payment_preimage_1));
1867 check_added_monitors!(nodes[1], 1);
1868 let events = nodes[1].node.get_and_clear_pending_msg_events();
1869 assert_eq!(events.len(), 0);
1870 nodes[1].logger.assert_log("lightning::ln::channelmanager".to_string(), "Temporary failure claiming HTLC, treating as success: Failed to update ChannelMonitor".to_string(), 1);
1872 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1873 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1874 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1875 check_added_monitors!(nodes[1], 0);
1876 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1878 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa);
1879 check_added_monitors!(nodes[1], 1);
1880 expect_pending_htlcs_forwardable!(nodes[1]);
1881 expect_payment_received!(nodes[1], payment_hash_2, payment_secret_2, 1000000);
1883 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1884 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fulfill_htlcs[0]);
1885 commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false);
1887 let events = nodes[0].node.get_and_clear_pending_events();
1888 assert_eq!(events.len(), 1);
1890 Event::PaymentSent { ref payment_preimage } => {
1891 assert_eq!(*payment_preimage, payment_preimage_1);
1893 _ => panic!("Unexpected event"),
1896 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
1899 // confirm_a_first and restore_b_before_conf are wholly unrelated to earlier bools and
1900 // restore_b_before_conf has no meaning if !confirm_a_first
1901 fn do_during_funding_monitor_fail(confirm_a_first: bool, restore_b_before_conf: bool) {
1902 // Test that if the monitor update generated by funding_transaction_generated fails we continue
1903 // the channel setup happily after the update is restored.
1904 let chanmon_cfgs = create_chanmon_cfgs(2);
1905 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1906 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1907 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1909 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 43, None).unwrap();
1910 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()));
1911 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), InitFeatures::known(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
1913 let (temporary_channel_id, funding_tx, funding_output) = create_funding_transaction(&nodes[0], 100000, 43);
1915 nodes[0].node.funding_transaction_generated(&temporary_channel_id, funding_tx.clone()).unwrap();
1916 check_added_monitors!(nodes[0], 0);
1918 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1919 let funding_created_msg = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
1920 let channel_id = OutPoint { txid: funding_created_msg.funding_txid, index: funding_created_msg.funding_output_index }.to_channel_id();
1921 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created_msg);
1922 check_added_monitors!(nodes[1], 1);
1924 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
1925 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, nodes[0].node.get_our_node_id()));
1926 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1927 nodes[0].logger.assert_log("lightning::ln::channelmanager".to_string(), "Failed to update ChannelMonitor".to_string(), 1);
1928 check_added_monitors!(nodes[0], 1);
1929 assert!(nodes[0].node.get_and_clear_pending_events().is_empty());
1930 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1931 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1932 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
1933 check_added_monitors!(nodes[0], 0);
1935 let events = nodes[0].node.get_and_clear_pending_events();
1936 assert_eq!(events.len(), 0);
1937 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
1938 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0].txid(), funding_output.txid);
1940 if confirm_a_first {
1941 confirm_transaction(&nodes[0], &funding_tx);
1942 nodes[1].node.handle_funding_locked(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendFundingLocked, nodes[1].node.get_our_node_id()));
1944 assert!(!restore_b_before_conf);
1945 confirm_transaction(&nodes[1], &funding_tx);
1946 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1949 // Make sure nodes[1] isn't stupid enough to re-send the FundingLocked on reconnect
1950 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
1951 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
1952 reconnect_nodes(&nodes[0], &nodes[1], (false, confirm_a_first), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
1953 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
1954 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1956 if !restore_b_before_conf {
1957 confirm_transaction(&nodes[1], &funding_tx);
1958 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
1959 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
1962 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
1963 let (outpoint, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&channel_id).unwrap().clone();
1964 nodes[1].node.channel_monitor_updated(&outpoint, latest_update);
1965 check_added_monitors!(nodes[1], 0);
1967 let (channel_id, (announcement, as_update, bs_update)) = if !confirm_a_first {
1968 nodes[0].node.handle_funding_locked(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingLocked, nodes[0].node.get_our_node_id()));
1970 confirm_transaction(&nodes[0], &funding_tx);
1971 let (funding_locked, channel_id) = create_chan_between_nodes_with_value_confirm_second(&nodes[1], &nodes[0]);
1972 (channel_id, create_chan_between_nodes_with_value_b(&nodes[0], &nodes[1], &funding_locked))
1974 if restore_b_before_conf {
1975 confirm_transaction(&nodes[1], &funding_tx);
1977 let (funding_locked, channel_id) = create_chan_between_nodes_with_value_confirm_second(&nodes[0], &nodes[1]);
1978 (channel_id, create_chan_between_nodes_with_value_b(&nodes[1], &nodes[0], &funding_locked))
1980 for node in nodes.iter() {
1981 assert!(node.net_graph_msg_handler.handle_channel_announcement(&announcement).unwrap());
1982 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
1983 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
1986 send_payment(&nodes[0], &[&nodes[1]], 8000000);
1987 close_channel(&nodes[0], &nodes[1], &channel_id, funding_tx, true);
1991 fn during_funding_monitor_fail() {
1992 do_during_funding_monitor_fail(true, true);
1993 do_during_funding_monitor_fail(true, false);
1994 do_during_funding_monitor_fail(false, false);
1998 fn test_path_paused_mpp() {
1999 // Simple test of sending a multi-part payment where one path is currently blocked awaiting
2001 let chanmon_cfgs = create_chanmon_cfgs(4);
2002 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
2003 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
2004 let mut nodes = create_network(4, &node_cfgs, &node_chanmgrs);
2006 let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
2007 let (chan_2_ann, _, chan_2_id, _) = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known());
2008 let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
2009 let chan_4_id = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
2010 let logger = test_utils::TestLogger::new();
2012 let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash!(&nodes[3]);
2013 let mut route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph.read().unwrap(), &nodes[3].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &[], 100000, TEST_FINAL_CLTV, &logger).unwrap();
2015 // Set us up to take multiple routes, one 0 -> 1 -> 3 and one 0 -> 2 -> 3:
2016 let path = route.paths[0].clone();
2017 route.paths.push(path);
2018 route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
2019 route.paths[0][0].short_channel_id = chan_1_id;
2020 route.paths[0][1].short_channel_id = chan_3_id;
2021 route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
2022 route.paths[1][0].short_channel_id = chan_2_ann.contents.short_channel_id;
2023 route.paths[1][1].short_channel_id = chan_4_id;
2025 // Set it so that the first monitor update (for the path 0 -> 1 -> 3) succeeds, but the second
2026 // (for the path 0 -> 2 -> 3) fails.
2027 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
2028 *nodes[0].chain_monitor.next_update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
2030 // Now check that we get the right return value, indicating that the first path succeeded but
2031 // the second got a MonitorUpdateFailed err. This implies PaymentSendFailure::PartialFailure as
2032 // some paths succeeded, preventing retry.
2033 if let Err(PaymentSendFailure::PartialFailure(results)) = nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)) {
2034 assert_eq!(results.len(), 2);
2035 if let Ok(()) = results[0] {} else { panic!(); }
2036 if let Err(APIError::MonitorUpdateFailed) = results[1] {} else { panic!(); }
2037 } else { panic!(); }
2038 check_added_monitors!(nodes[0], 2);
2039 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Ok(()));
2041 // Pass the first HTLC of the payment along to nodes[3].
2042 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
2043 assert_eq!(events.len(), 1);
2044 pass_along_path(&nodes[0], &[&nodes[1], &nodes[3]], 0, payment_hash.clone(), Some(payment_secret), events.pop().unwrap(), false, None);
2046 // And check that, after we successfully update the monitor for chan_2 we can pass the second
2047 // HTLC along to nodes[3] and claim the whole payment back to nodes[0].
2048 let (outpoint, latest_update) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_2_id).unwrap().clone();
2049 nodes[0].node.channel_monitor_updated(&outpoint, latest_update);
2050 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
2051 assert_eq!(events.len(), 1);
2052 pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], 200_000, payment_hash.clone(), Some(payment_secret), events.pop().unwrap(), true, None);
2054 claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_preimage);
2057 fn do_channel_holding_cell_serialize(disconnect: bool, reload_a: bool) {
2058 // Tests that, when we serialize a channel with AddHTLC entries in the holding cell, we
2059 // properly free them on reconnect. We previously failed such HTLCs upon serialization, but
2060 // that behavior was both somewhat unexpected and also broken (there was a debug assertion
2061 // which failed in such a case).
2062 let chanmon_cfgs = create_chanmon_cfgs(2);
2063 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2064 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
2065 let persister: test_utils::TestPersister;
2066 let new_chain_monitor: test_utils::TestChainMonitor;
2067 let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
2068 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2070 let chan_id = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 15_000_000, 7_000_000_000, InitFeatures::known(), InitFeatures::known()).2;
2071 let (payment_preimage_1, payment_hash_1, payment_secret_1) = get_payment_preimage_hash!(&nodes[1]);
2072 let (payment_preimage_2, payment_hash_2, payment_secret_2) = get_payment_preimage_hash!(&nodes[1]);
2074 // Do a really complicated dance to get an HTLC into the holding cell, with MonitorUpdateFailed
2075 // set but AwaitingRemoteRevoke unset. When this test was written, any attempts to send an HTLC
2076 // while MonitorUpdateFailed is set are immediately failed-backwards. Thus, the only way to get
2077 // an AddHTLC into the holding cell is to add it while AwaitingRemoteRevoke is set but
2078 // MonitorUpdateFailed is unset, and then swap the flags.
2081 // a) routing a payment from node B to node A,
2082 // b) sending a payment from node A to node B without delivering any of the generated messages,
2083 // putting node A in AwaitingRemoteRevoke,
2084 // c) sending a second payment from node A to node B, which is immediately placed in the
2086 // d) claiming the first payment from B, allowing us to fail the monitor update which occurs
2087 // when we try to persist the payment preimage,
2088 // e) delivering A's commitment_signed from (b) and the resulting B revoke_and_ack message,
2089 // clearing AwaitingRemoteRevoke on node A.
2091 // Note that because, at the end, MonitorUpdateFailed is still set, the HTLC generated in (c)
2092 // will not be freed from the holding cell.
2093 let (payment_preimage_0, _, _) = route_payment(&nodes[1], &[&nodes[0]], 100000);
2096 let net_graph_msg_handler = &nodes[0].net_graph_msg_handler;
2097 get_route(&nodes[0].node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &nodes[1].node.get_our_node_id(), None, None, &Vec::new(), 100000, TEST_FINAL_CLTV, nodes[0].logger).unwrap()
2100 nodes[0].node.send_payment(&route, payment_hash_1, &Some(payment_secret_1)).unwrap();
2101 check_added_monitors!(nodes[0], 1);
2102 let send = SendEvent::from_node(&nodes[0]);
2103 assert_eq!(send.msgs.len(), 1);
2105 nodes[0].node.send_payment(&route, payment_hash_2, &Some(payment_secret_2)).unwrap();
2106 check_added_monitors!(nodes[0], 0);
2108 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
2109 assert!(nodes[0].node.claim_funds(payment_preimage_0));
2110 check_added_monitors!(nodes[0], 1);
2112 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send.msgs[0]);
2113 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send.commitment_msg);
2114 check_added_monitors!(nodes[1], 1);
2116 let (raa, cs) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2118 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &raa);
2119 check_added_monitors!(nodes[0], 1);
2122 // Optionally reload nodes[0] entirely through a serialization roundtrip, otherwise just
2123 // disconnect the peers. Note that the fuzzer originally found this issue because
2124 // deserializing a ChannelManager in this state causes an assertion failure.
2126 let nodes_0_serialized = nodes[0].node.encode();
2127 let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
2128 nodes[0].chain_monitor.chain_monitor.monitors.read().unwrap().iter().next().unwrap().1.write(&mut chan_0_monitor_serialized).unwrap();
2130 persister = test_utils::TestPersister::new();
2131 let keys_manager = &chanmon_cfgs[0].keys_manager;
2132 new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), nodes[0].logger, node_cfgs[0].fee_estimator, &persister, keys_manager);
2133 nodes[0].chain_monitor = &new_chain_monitor;
2134 let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
2135 let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
2136 &mut chan_0_monitor_read, keys_manager).unwrap();
2137 assert!(chan_0_monitor_read.is_empty());
2139 let mut nodes_0_read = &nodes_0_serialized[..];
2140 let config = UserConfig::default();
2141 nodes_0_deserialized = {
2142 let mut channel_monitors = HashMap::new();
2143 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
2144 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
2145 default_config: config,
2147 fee_estimator: node_cfgs[0].fee_estimator,
2148 chain_monitor: nodes[0].chain_monitor,
2149 tx_broadcaster: nodes[0].tx_broadcaster.clone(),
2150 logger: nodes[0].logger,
2154 nodes[0].node = &nodes_0_deserialized;
2155 assert!(nodes_0_read.is_empty());
2157 nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0.clone(), chan_0_monitor).unwrap();
2158 check_added_monitors!(nodes[0], 1);
2160 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
2162 nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
2164 // Now reconnect the two
2165 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
2166 let reestablish_1 = get_chan_reestablish_msgs!(nodes[0], nodes[1]);
2167 assert_eq!(reestablish_1.len(), 1);
2168 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
2169 let reestablish_2 = get_chan_reestablish_msgs!(nodes[1], nodes[0]);
2170 assert_eq!(reestablish_2.len(), 1);
2172 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &reestablish_1[0]);
2173 let resp_1 = handle_chan_reestablish_msgs!(nodes[1], nodes[0]);
2174 check_added_monitors!(nodes[1], 0);
2176 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &reestablish_2[0]);
2177 let resp_0 = handle_chan_reestablish_msgs!(nodes[0], nodes[1]);
2179 assert!(resp_0.0.is_none());
2180 assert!(resp_0.1.is_none());
2181 assert!(resp_0.2.is_none());
2182 assert!(resp_1.0.is_none());
2183 assert!(resp_1.1.is_none());
2185 // Check that the freshly-generated cs is equal to the original (which we will deliver in a
2187 if let Some(pending_cs) = resp_1.2 {
2188 assert!(pending_cs.update_add_htlcs.is_empty());
2189 assert!(pending_cs.update_fail_htlcs.is_empty());
2190 assert!(pending_cs.update_fulfill_htlcs.is_empty());
2191 assert_eq!(pending_cs.commitment_signed, cs);
2192 } else { panic!(); }
2194 // There should be no monitor updates as we are still pending awaiting a failed one.
2195 check_added_monitors!(nodes[0], 0);
2196 check_added_monitors!(nodes[1], 0);
2199 // If we finish updating the monitor, we should free the holding cell right away (this did
2200 // not occur prior to #756).
2201 *nodes[0].chain_monitor.update_ret.lock().unwrap() = None;
2202 let (funding_txo, mon_id) = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&chan_id).unwrap().clone();
2203 nodes[0].node.channel_monitor_updated(&funding_txo, mon_id);
2205 // New outbound messages should be generated immediately upon a call to
2206 // get_and_clear_pending_msg_events (but not before).
2207 check_added_monitors!(nodes[0], 0);
2208 let mut events = nodes[0].node.get_and_clear_pending_msg_events();
2209 check_added_monitors!(nodes[0], 1);
2210 assert_eq!(events.len(), 1);
2212 // Deliver the pending in-flight CS
2213 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &cs);
2214 check_added_monitors!(nodes[0], 1);
2216 let commitment_msg = match events.pop().unwrap() {
2217 MessageSendEvent::UpdateHTLCs { node_id, updates } => {
2218 assert_eq!(node_id, nodes[1].node.get_our_node_id());
2219 assert!(updates.update_fail_htlcs.is_empty());
2220 assert!(updates.update_fail_malformed_htlcs.is_empty());
2221 assert!(updates.update_fee.is_none());
2222 assert_eq!(updates.update_fulfill_htlcs.len(), 1);
2223 nodes[1].node.handle_update_fulfill_htlc(&nodes[0].node.get_our_node_id(), &updates.update_fulfill_htlcs[0]);
2224 expect_payment_sent!(nodes[1], payment_preimage_0);
2225 assert_eq!(updates.update_add_htlcs.len(), 1);
2226 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &updates.update_add_htlcs[0]);
2227 updates.commitment_signed
2229 _ => panic!("Unexpected event type!"),
2232 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &commitment_msg);
2233 check_added_monitors!(nodes[1], 1);
2235 let as_revoke_and_ack = get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id());
2236 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_revoke_and_ack);
2237 expect_pending_htlcs_forwardable!(nodes[1]);
2238 expect_payment_received!(nodes[1], payment_hash_1, payment_secret_1, 100000);
2239 check_added_monitors!(nodes[1], 1);
2241 commitment_signed_dance!(nodes[1], nodes[0], (), false, true, false);
2243 expect_pending_htlcs_forwardable!(nodes[1]);
2244 expect_payment_received!(nodes[1], payment_hash_2, payment_secret_2, 100000);
2246 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_1);
2247 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage_2);
2250 fn channel_holding_cell_serialize() {
2251 do_channel_holding_cell_serialize(true, true);
2252 do_channel_holding_cell_serialize(true, false);
2253 do_channel_holding_cell_serialize(false, true); // last arg doesn't matter
2256 #[derive(PartialEq)]
2257 enum HTLCStatusAtDupClaim {
2262 fn do_test_reconnect_dup_htlc_claims(htlc_status: HTLCStatusAtDupClaim, second_fails: bool) {
2263 // When receiving an update_fulfill_htlc message, we immediately forward the claim backwards
2264 // along the payment path before waiting for a full commitment_signed dance. This is great, but
2265 // can cause duplicative claims if a node sends an update_fulfill_htlc message, disconnects,
2266 // reconnects, and then has to re-send its update_fulfill_htlc message again.
2267 // In previous code, we didn't handle the double-claim correctly, spuriously closing the
2268 // channel on which the inbound HTLC was received.
2269 let chanmon_cfgs = create_chanmon_cfgs(3);
2270 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
2271 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
2272 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
2274 create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2275 let chan_2 = create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known()).2;
2277 let (payment_preimage, payment_hash, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100_000);
2279 let mut as_raa = None;
2280 if htlc_status == HTLCStatusAtDupClaim::HoldingCell {
2281 // In order to get the HTLC claim into the holding cell at nodes[1], we need nodes[1] to be
2282 // awaiting a remote revoke_and_ack from nodes[0].
2283 let (_, second_payment_hash, second_payment_secret) = get_payment_preimage_hash!(nodes[1]);
2284 let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph.read().unwrap(),
2285 &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 100_000, TEST_FINAL_CLTV, nodes[1].logger).unwrap();
2286 nodes[0].node.send_payment(&route, second_payment_hash, &Some(second_payment_secret)).unwrap();
2287 check_added_monitors!(nodes[0], 1);
2289 let send_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
2290 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &send_event.msgs[0]);
2291 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &send_event.commitment_msg);
2292 check_added_monitors!(nodes[1], 1);
2294 let (bs_raa, bs_cs) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
2295 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
2296 check_added_monitors!(nodes[0], 1);
2297 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_cs);
2298 check_added_monitors!(nodes[0], 1);
2300 as_raa = Some(get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
2303 let fulfill_msg = msgs::UpdateFulfillHTLC {
2309 assert!(nodes[2].node.fail_htlc_backwards(&payment_hash));
2310 expect_pending_htlcs_forwardable!(nodes[2]);
2311 check_added_monitors!(nodes[2], 1);
2312 get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2314 assert!(nodes[2].node.claim_funds(payment_preimage));
2315 check_added_monitors!(nodes[2], 1);
2316 let cs_updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
2317 assert_eq!(cs_updates.update_fulfill_htlcs.len(), 1);
2318 // Check that the message we're about to deliver matches the one generated:
2319 assert_eq!(fulfill_msg, cs_updates.update_fulfill_htlcs[0]);
2321 nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &fulfill_msg);
2322 expect_payment_forwarded!(nodes[1], Some(1000), false);
2323 check_added_monitors!(nodes[1], 1);
2325 let mut bs_updates = None;
2326 if htlc_status != HTLCStatusAtDupClaim::HoldingCell {
2327 bs_updates = Some(get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()));
2328 assert_eq!(bs_updates.as_ref().unwrap().update_fulfill_htlcs.len(), 1);
2329 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.as_ref().unwrap().update_fulfill_htlcs[0]);
2330 expect_payment_sent!(nodes[0], payment_preimage);
2331 if htlc_status == HTLCStatusAtDupClaim::Cleared {
2332 commitment_signed_dance!(nodes[0], nodes[1], &bs_updates.as_ref().unwrap().commitment_signed, false);
2335 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
2338 nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), false);
2339 nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
2342 reconnect_nodes(&nodes[1], &nodes[2], (false, false), (0, 0), (0, 0), (1, 0), (0, 0), (0, 0), (false, false));
2343 expect_pending_htlcs_forwardable!(nodes[1]);
2345 reconnect_nodes(&nodes[1], &nodes[2], (false, false), (0, 0), (1, 0), (0, 0), (0, 0), (0, 0), (false, false));
2348 if htlc_status == HTLCStatusAtDupClaim::HoldingCell {
2349 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &as_raa.unwrap());
2350 check_added_monitors!(nodes[1], 1);
2351 expect_pending_htlcs_forwardable_ignore!(nodes[1]); // We finally receive the second payment, but don't claim it
2353 bs_updates = Some(get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id()));
2354 assert_eq!(bs_updates.as_ref().unwrap().update_fulfill_htlcs.len(), 1);
2355 nodes[0].node.handle_update_fulfill_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.as_ref().unwrap().update_fulfill_htlcs[0]);
2356 expect_payment_sent!(nodes[0], payment_preimage);
2358 if htlc_status != HTLCStatusAtDupClaim::Cleared {
2359 commitment_signed_dance!(nodes[0], nodes[1], &bs_updates.as_ref().unwrap().commitment_signed, false);
2364 fn test_reconnect_dup_htlc_claims() {
2365 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::Received, false);
2366 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::HoldingCell, false);
2367 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::Cleared, false);
2368 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::Received, true);
2369 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::HoldingCell, true);
2370 do_test_reconnect_dup_htlc_claims(HTLCStatusAtDupClaim::Cleared, true);
2374 fn test_temporary_error_during_shutdown() {
2375 // Test that temporary failures when updating the monitor's shutdown script do not prevent
2376 // cooperative close.
2377 let mut config = test_default_channel_config();
2378 config.channel_options.commit_upfront_shutdown_pubkey = false;
2380 let chanmon_cfgs = create_chanmon_cfgs(2);
2381 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2382 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(config), Some(config)]);
2383 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2385 let (_, _, channel_id, funding_tx) = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
2387 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
2388 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::TemporaryFailure));
2389 close_channel(&nodes[0], &nodes[1], &channel_id, funding_tx, false);
2390 check_added_monitors!(nodes[0], 1);
2391 check_added_monitors!(nodes[1], 1);
2395 fn test_permanent_error_during_sending_shutdown() {
2396 // Test that permanent failures when updating the monitor's shutdown script result in a force
2397 // close when initiating a cooperative close.
2398 let mut config = test_default_channel_config();
2399 config.channel_options.commit_upfront_shutdown_pubkey = false;
2401 let chanmon_cfgs = create_chanmon_cfgs(2);
2402 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2403 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(config), None]);
2404 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2406 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
2407 *nodes[0].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::PermanentFailure));
2409 assert!(nodes[0].node.close_channel(&channel_id).is_ok());
2410 check_closed_broadcast!(nodes[0], true);
2411 check_added_monitors!(nodes[0], 2);
2415 fn test_permanent_error_during_handling_shutdown() {
2416 // Test that permanent failures when updating the monitor's shutdown script result in a force
2417 // close when handling a cooperative close.
2418 let mut config = test_default_channel_config();
2419 config.channel_options.commit_upfront_shutdown_pubkey = false;
2421 let chanmon_cfgs = create_chanmon_cfgs(2);
2422 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
2423 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(config)]);
2424 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
2426 let channel_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).2;
2427 *nodes[1].chain_monitor.update_ret.lock().unwrap() = Some(Err(ChannelMonitorUpdateErr::PermanentFailure));
2429 assert!(nodes[0].node.close_channel(&channel_id).is_ok());
2430 let shutdown = get_event_msg!(nodes[0], MessageSendEvent::SendShutdown, nodes[1].node.get_our_node_id());
2431 nodes[1].node.handle_shutdown(&nodes[0].node.get_our_node_id(), &InitFeatures::known(), &shutdown);
2432 check_closed_broadcast!(nodes[1], true);
2433 check_added_monitors!(nodes[1], 2);