_ Git - rust-lightning/blob - lightning/src/ln/channel.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 use bitcoin::blockdata::script::{Script,Builder};
  11 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
  12 use bitcoin::blockdata::opcodes;
  13 use bitcoin::util::bip143;
  14 use bitcoin::consensus::encode;
  15
  16 use bitcoin::hashes::Hash;
  17 use bitcoin::hashes::sha256::Hash as Sha256;
  18 use bitcoin::hashes::sha256d::Hash as Sha256d;
  19 use bitcoin::hash_types::{Txid, BlockHash, WPubkeyHash};
  20
  21 use bitcoin::secp256k1::key::{PublicKey,SecretKey};
  22 use bitcoin::secp256k1::{Secp256k1,Signature};
  23 use bitcoin::secp256k1;
  24
  25 use ln::{PaymentPreimage, PaymentHash};
  26 use ln::features::{ChannelFeatures, InitFeatures};
  27 use ln::msgs;
  28 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
  29 use ln::channelmanager::{BestBlock, PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, BREAKDOWN_TIMEOUT, MIN_CLTV_EXPIRY_DELTA, MAX_LOCAL_BREAKDOWN_TIMEOUT};
  30 use ln::chan_utils::{CounterpartyCommitmentSecrets, TxCreationKeys, HTLCOutputInCommitment, HTLC_SUCCESS_TX_WEIGHT, HTLC_TIMEOUT_TX_WEIGHT, make_funding_redeemscript, ChannelPublicKeys, CommitmentTransaction, HolderCommitmentTransaction, ChannelTransactionParameters, CounterpartyChannelTransactionParameters, MAX_HTLCS, get_commitment_transaction_number_obscure_factor};
  31 use ln::chan_utils;
  32 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
  33 use chain::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep, HTLC_FAIL_BACK_BUFFER};
  34 use chain::transaction::{OutPoint, TransactionData};
  35 use chain::keysinterface::{Sign, KeysInterface};
  36 use util::transaction_utils;
  37 use util::ser::{Readable, ReadableArgs, Writeable, Writer, VecWriter};
  38 use util::logger::Logger;
  39 use util::errors::APIError;
  40 use util::config::{UserConfig,ChannelConfig};
  41 use util::scid_utils::scid_from_parts;
  42
  43 use prelude::*;
  44 use core::{cmp,mem,fmt};
  45 use core::ops::Deref;
  46 #[cfg(any(test, feature = "fuzztarget"))]
  47 use std::sync::Mutex;
  48 use bitcoin::hashes::hex::ToHex;
  49 use bitcoin::blockdata::opcodes::all::OP_PUSHBYTES_0;
  50
  51 #[cfg(test)]
  52 pub struct ChannelValueStat {
  53         pub value_to_self_msat: u64,
  54         pub channel_value_msat: u64,
  55         pub channel_reserve_msat: u64,
  56         pub pending_outbound_htlcs_amount_msat: u64,
  57         pub pending_inbound_htlcs_amount_msat: u64,
  58         pub holding_cell_outbound_amount_msat: u64,
  59         pub counterparty_max_htlc_value_in_flight_msat: u64, // outgoing
  60         pub counterparty_dust_limit_msat: u64,
  61 }
  62
  63 enum InboundHTLCRemovalReason {
  64         FailRelay(msgs::OnionErrorPacket),
  65         FailMalformed(([u8; 32], u16)),
  66         Fulfill(PaymentPreimage),
  67 }
  68
  69 enum InboundHTLCState {
  70         /// Offered by remote, to be included in next local commitment tx. I.e., the remote sent an
  71         /// update_add_htlc message for this HTLC.
  72         RemoteAnnounced(PendingHTLCStatus),
  73         /// Included in a received commitment_signed message (implying we've
  74         /// revoke_and_ack'd it), but the remote hasn't yet revoked their previous
  75         /// state (see the example below). We have not yet included this HTLC in a
  76         /// commitment_signed message because we are waiting on the remote's
  77         /// aforementioned state revocation. One reason this missing remote RAA
  78         /// (revoke_and_ack) blocks us from constructing a commitment_signed message
  79         /// is because every time we create a new "state", i.e. every time we sign a
  80         /// new commitment tx (see [BOLT #2]), we need a new per_commitment_point,
  81         /// which are provided one-at-a-time in each RAA. E.g., the last RAA they
  82         /// sent provided the per_commitment_point for our current commitment tx.
  83         /// The other reason we should not send a commitment_signed without their RAA
  84         /// is because their RAA serves to ACK our previous commitment_signed.
  85         ///
  86         /// Here's an example of how an HTLC could come to be in this state:
  87         /// remote --> update_add_htlc(prev_htlc)   --> local
  88         /// remote --> commitment_signed(prev_htlc) --> local
  89         /// remote <-- revoke_and_ack               <-- local
  90         /// remote <-- commitment_signed(prev_htlc) <-- local
  91         /// [note that here, the remote does not respond with a RAA]
  92         /// remote --> update_add_htlc(this_htlc)   --> local
  93         /// remote --> commitment_signed(prev_htlc, this_htlc) --> local
  94         /// Now `this_htlc` will be assigned this state. It's unable to be officially
  95         /// accepted, i.e. included in a commitment_signed, because we're missing the
  96         /// RAA that provides our next per_commitment_point. The per_commitment_point
  97         /// is used to derive commitment keys, which are used to construct the
  98         /// signatures in a commitment_signed message.
  99         /// Implies AwaitingRemoteRevoke.
 100         ///
 101         /// [BOLT #2]: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md
 102         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
 103         /// Included in a received commitment_signed message (implying we've revoke_and_ack'd it).
 104         /// We have also included this HTLC in our latest commitment_signed and are now just waiting
 105         /// on the remote's revoke_and_ack to make this HTLC an irrevocable part of the state of the
 106         /// channel (before it can then get forwarded and/or removed).
 107         /// Implies AwaitingRemoteRevoke.
 108         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
 109         Committed,
 110         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
 111         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
 112         /// we'll drop it.
 113         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
 114         /// commitment transaction without it as otherwise we'll have to force-close the channel to
 115         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
 116         /// anyway). That said, ChannelMonitor does this for us (see
 117         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
 118         /// local state before then, once we're sure that the next commitment_signed and
 119         /// ChannelMonitor::provide_latest_local_commitment_tx will not include this HTLC.
 120         LocalRemoved(InboundHTLCRemovalReason),
 121 }
 122
 123 struct InboundHTLCOutput {
 124         htlc_id: u64,
 125         amount_msat: u64,
 126         cltv_expiry: u32,
 127         payment_hash: PaymentHash,
 128         state: InboundHTLCState,
 129 }
 130
 131 enum OutboundHTLCState {
 132         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
 133         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
 134         /// we will promote to Committed (note that they may not accept it until the next time we
 135         /// revoke, but we don't really care about that:
 136         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
 137         ///    money back (though we won't), and,
 138         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
 139         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
 140         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
 141         ///    we'll never get out of sync).
 142         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
 143         /// OutboundHTLCOutput's size just for a temporary bit
 144         LocalAnnounced(Box<msgs::OnionPacket>),
 145         Committed,
 146         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
 147         /// the change (though they'll need to revoke before we fail the payment).
 148         RemoteRemoved(Option<HTLCFailReason>),
 149         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 150         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 151         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 152         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
 153         /// remote revoke_and_ack on a previous state before we can do so.
 154         AwaitingRemoteRevokeToRemove(Option<HTLCFailReason>),
 155         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 156         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 157         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 158         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
 159         /// revoke_and_ack to drop completely.
 160         AwaitingRemovedRemoteRevoke(Option<HTLCFailReason>),
 161 }
 162
 163 struct OutboundHTLCOutput {
 164         htlc_id: u64,
 165         amount_msat: u64,
 166         cltv_expiry: u32,
 167         payment_hash: PaymentHash,
 168         state: OutboundHTLCState,
 169         source: HTLCSource,
 170 }
 171
 172 /// See AwaitingRemoteRevoke ChannelState for more info
 173 enum HTLCUpdateAwaitingACK {
 174         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
 175                 // always outbound
 176                 amount_msat: u64,
 177                 cltv_expiry: u32,
 178                 payment_hash: PaymentHash,
 179                 source: HTLCSource,
 180                 onion_routing_packet: msgs::OnionPacket,
 181         },
 182         ClaimHTLC {
 183                 payment_preimage: PaymentPreimage,
 184                 htlc_id: u64,
 185         },
 186         FailHTLC {
 187                 htlc_id: u64,
 188                 err_packet: msgs::OnionErrorPacket,
 189         },
 190 }
 191
 192 /// There are a few "states" and then a number of flags which can be applied:
 193 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
 194 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
 195 /// move on to ChannelFunded.
 196 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
 197 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
 198 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
 199 enum ChannelState {
 200         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
 201         OurInitSent = 1 << 0,
 202         /// Implies we have received their open_channel/accept_channel message
 203         TheirInitSent = 1 << 1,
 204         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
 205         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
 206         /// upon receipt of funding_created, so simply skip this state.
 207         FundingCreated = 4,
 208         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
 209         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
 210         /// and our counterparty consider the funding transaction confirmed.
 211         FundingSent = 8,
 212         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
 213         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 214         TheirFundingLocked = 1 << 4,
 215         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
 216         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 217         OurFundingLocked = 1 << 5,
 218         ChannelFunded = 64,
 219         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
 220         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
 221         /// dance.
 222         PeerDisconnected = 1 << 7,
 223         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
 224         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
 225         /// outbound messages until they've managed to do so.
 226         MonitorUpdateFailed = 1 << 8,
 227         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
 228         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
 229         /// messages as then we will be unable to determine which HTLCs they included in their
 230         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
 231         /// later.
 232         /// Flag is set on ChannelFunded.
 233         AwaitingRemoteRevoke = 1 << 9,
 234         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
 235         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
 236         /// to respond with our own shutdown message when possible.
 237         RemoteShutdownSent = 1 << 10,
 238         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
 239         /// point, we may not add any new HTLCs to the channel.
 240         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
 241         /// us their shutdown.
 242         LocalShutdownSent = 1 << 11,
 243         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
 244         /// to drop us, but we store this anyway.
 245         ShutdownComplete = 4096,
 246 }
 247 const BOTH_SIDES_SHUTDOWN_MASK: u32 = ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32;
 248 const MULTI_STATE_FLAGS: u32 = BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32;
 249
 250 pub const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
 251
 252 /// The "channel disabled" bit in channel_update must be set based on whether we are connected to
 253 /// our counterparty or not. However, we don't want to announce updates right away to avoid
 254 /// spamming the network with updates if the connection is flapping. Instead, we "stage" updates to
 255 /// our channel_update message and track the current state here.
 256 /// See implementation at [`super::channelmanager::ChannelManager::timer_tick_occurred`].
 257 #[derive(Clone, Copy, PartialEq)]
 258 pub(super) enum ChannelUpdateStatus {
 259         /// We've announced the channel as enabled and are connected to our peer.
 260         Enabled,
 261         /// Our channel is no longer live, but we haven't announced the channel as disabled yet.
 262         DisabledStaged,
 263         /// Our channel is live again, but we haven't announced the channel as enabled yet.
 264         EnabledStaged,
 265         /// We've announced the channel as disabled.
 266         Disabled,
 267 }
 268
 269 /// An enum indicating whether the local or remote side offered a given HTLC.
 270 enum HTLCInitiator {
 271         LocalOffered,
 272         RemoteOffered,
 273 }
 274
 275 /// Used when calculating whether we or the remote can afford an additional HTLC.
 276 struct HTLCCandidate {
 277         amount_msat: u64,
 278         origin: HTLCInitiator,
 279 }
 280
 281 impl HTLCCandidate {
 282         fn new(amount_msat: u64, origin: HTLCInitiator) -> Self {
 283                 Self {
 284                         amount_msat,
 285                         origin,
 286                 }
 287         }
 288 }
 289
 290 /// Information needed for constructing an invoice route hint for this channel.
 291 #[derive(Clone)]
 292 pub struct CounterpartyForwardingInfo {
 293         /// Base routing fee in millisatoshis.
 294         pub fee_base_msat: u32,
 295         /// Amount in millionths of a satoshi the channel will charge per transferred satoshi.
 296         pub fee_proportional_millionths: u32,
 297         /// The minimum difference in cltv_expiry between an ingoing HTLC and its outgoing counterpart,
 298         /// such that the outgoing HTLC is forwardable to this counterparty. See `msgs::ChannelUpdate`'s
 299         /// `cltv_expiry_delta` for more details.
 300         pub cltv_expiry_delta: u16,
 301 }
 302
 303 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
 304 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
 305 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
 306 // inbound channel.
 307 //
 308 // Holder designates channel data owned for the benefice of the user client.
 309 // Counterparty designates channel data owned by the another channel participant entity.
 310 pub(super) struct Channel<Signer: Sign> {
 311         config: ChannelConfig,
 312
 313         user_id: u64,
 314
 315         channel_id: [u8; 32],
 316         channel_state: u32,
 317         secp_ctx: Secp256k1<secp256k1::All>,
 318         channel_value_satoshis: u64,
 319
 320         latest_monitor_update_id: u64,
 321
 322         holder_signer: Signer,
 323         shutdown_pubkey: PublicKey,
 324         destination_script: Script,
 325
 326         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
 327         // generation start at 0 and count up...this simplifies some parts of implementation at the
 328         // cost of others, but should really just be changed.
 329
 330         cur_holder_commitment_transaction_number: u64,
 331         cur_counterparty_commitment_transaction_number: u64,
 332         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
 333         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
 334         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
 335         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
 336
 337         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
 338         /// need to ensure we resend them in the order we originally generated them. Note that because
 339         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
 340         /// sufficient to simply set this to the opposite of any message we are generating as we
 341         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
 342         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
 343         /// send it first.
 344         resend_order: RAACommitmentOrder,
 345
 346         monitor_pending_funding_locked: bool,
 347         monitor_pending_revoke_and_ack: bool,
 348         monitor_pending_commitment_signed: bool,
 349         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
 350         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
 351
 352         // pending_update_fee is filled when sending and receiving update_fee
 353         // For outbound channel, feerate_per_kw is updated with the value from
 354         // pending_update_fee when revoke_and_ack is received
 355         //
 356         // For inbound channel, feerate_per_kw is updated when it receives
 357         // commitment_signed and revoke_and_ack is generated
 358         // The pending value is kept when another pair of update_fee and commitment_signed
 359         // is received during AwaitingRemoteRevoke and relieved when the expected
 360         // revoke_and_ack is received and new commitment_signed is generated to be
 361         // sent to the funder. Otherwise, the pending value is removed when receiving
 362         // commitment_signed.
 363         pending_update_fee: Option<u32>,
 364         // update_fee() during ChannelState::AwaitingRemoteRevoke is hold in
 365         // holdina_cell_update_fee then moved to pending_udpate_fee when revoke_and_ack
 366         // is received. holding_cell_update_fee is updated when there are additional
 367         // update_fee() during ChannelState::AwaitingRemoteRevoke.
 368         holding_cell_update_fee: Option<u32>,
 369         next_holder_htlc_id: u64,
 370         next_counterparty_htlc_id: u64,
 371         update_time_counter: u32,
 372         feerate_per_kw: u32,
 373
 374         #[cfg(debug_assertions)]
 375         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
 376         holder_max_commitment_tx_output: ::std::sync::Mutex<(u64, u64)>,
 377         #[cfg(debug_assertions)]
 378         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
 379         counterparty_max_commitment_tx_output: ::std::sync::Mutex<(u64, u64)>,
 380
 381         last_sent_closing_fee: Option<(u32, u64, Signature)>, // (feerate, fee, holder_sig)
 382
 383         /// The hash of the block in which the funding transaction was included.
 384         funding_tx_confirmed_in: Option<BlockHash>,
 385         funding_tx_confirmation_height: u32,
 386         short_channel_id: Option<u64>,
 387
 388         counterparty_dust_limit_satoshis: u64,
 389         #[cfg(test)]
 390         pub(super) holder_dust_limit_satoshis: u64,
 391         #[cfg(not(test))]
 392         holder_dust_limit_satoshis: u64,
 393         #[cfg(test)]
 394         pub(super) counterparty_max_htlc_value_in_flight_msat: u64,
 395         #[cfg(not(test))]
 396         counterparty_max_htlc_value_in_flight_msat: u64,
 397         //get_holder_max_htlc_value_in_flight_msat(): u64,
 398         /// minimum channel reserve for self to maintain - set by them.
 399         counterparty_selected_channel_reserve_satoshis: u64,
 400         // get_holder_selected_channel_reserve_satoshis(channel_value_sats: u64): u64
 401         counterparty_htlc_minimum_msat: u64,
 402         holder_htlc_minimum_msat: u64,
 403         #[cfg(test)]
 404         pub counterparty_max_accepted_htlcs: u16,
 405         #[cfg(not(test))]
 406         counterparty_max_accepted_htlcs: u16,
 407         //implied by OUR_MAX_HTLCS: max_accepted_htlcs: u16,
 408         minimum_depth: u32,
 409
 410         counterparty_forwarding_info: Option<CounterpartyForwardingInfo>,
 411
 412         pub(crate) channel_transaction_parameters: ChannelTransactionParameters,
 413         funding_transaction: Option<Transaction>,
 414
 415         counterparty_cur_commitment_point: Option<PublicKey>,
 416         counterparty_prev_commitment_point: Option<PublicKey>,
 417         counterparty_node_id: PublicKey,
 418
 419         counterparty_shutdown_scriptpubkey: Option<Script>,
 420
 421         commitment_secrets: CounterpartyCommitmentSecrets,
 422
 423         channel_update_status: ChannelUpdateStatus,
 424
 425         /// Our counterparty's channel_announcement signatures provided in announcement_signatures.
 426         /// This can be used to rebroadcast the channel_announcement message later.
 427         announcement_sigs: Option<(Signature, Signature)>,
 428
 429         // We save these values so we can make sure `next_local_commit_tx_fee_msat` and
 430         // `next_remote_commit_tx_fee_msat` properly predict what the next commitment transaction fee will
 431         // be, by comparing the cached values to the fee of the tranaction generated by
 432         // `build_commitment_transaction`.
 433         #[cfg(any(test, feature = "fuzztarget"))]
 434         next_local_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
 435         #[cfg(any(test, feature = "fuzztarget"))]
 436         next_remote_commitment_tx_fee_info_cached: Mutex<Option<CommitmentTxInfoCached>>,
 437 }
 438
 439 #[cfg(any(test, feature = "fuzztarget"))]
 440 struct CommitmentTxInfoCached {
 441         fee: u64,
 442         total_pending_htlcs: usize,
 443         next_holder_htlc_id: u64,
 444         next_counterparty_htlc_id: u64,
 445         feerate: u32,
 446 }
 447
 448 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
 449 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
 450
 451 #[cfg(not(test))]
 452 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
 453 #[cfg(test)]
 454 pub const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
 455 #[cfg(not(test))]
 456 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 457 #[cfg(test)]
 458 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 459
 460 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
 461 /// it's 2^24.
 462 pub const MAX_FUNDING_SATOSHIS: u64 = 1 << 24;
 463
 464 /// Maximum counterparty `dust_limit_satoshis` allowed. 2 * standard dust threshold on p2wsh output
 465 /// Scales up on Bitcoin Core's proceeding policy with dust outputs. A typical p2wsh output is 43
 466 /// bytes to which Core's `GetDustThreshold()` sums up a minimal spend of 67 bytes (even if
 467 /// a p2wsh witnessScript might be *effectively* smaller), `dustRelayFee` is set to 3000sat/kb, thus
 468 /// 110 * 3000 / 1000 = 330. Per-protocol rules, all time-sensitive outputs are p2wsh, a value of
 469 /// 330 sats is the lower bound desired to ensure good propagation of transactions. We give a bit
 470 /// of margin to our counterparty and pick up 660 satoshis as an accepted `dust_limit_satoshis`
 471 /// upper bound to avoid negotiation conflicts with other implementations.
 472 pub const MAX_DUST_LIMIT_SATOSHIS: u64 = 2 * 330;
 473
 474 /// A typical p2wsh output is 43 bytes to which Core's `GetDustThreshold()` sums up a minimal
 475 /// spend of 67 bytes (even if a p2wsh witnessScript might be *effectively* smaller), `dustRelayFee`
 476 /// is set to 3000sat/kb, thus 110 * 3000 / 1000 = 330. Per-protocol rules, all time-sensitive outputs
 477 /// are p2wsh, a value of 330 sats is the lower bound desired to ensure good propagation of transactions.
 478 pub const MIN_DUST_LIMIT_SATOSHIS: u64 = 330;
 479
 480 /// Used to return a simple Error back to ChannelManager. Will get converted to a
 481 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
 482 /// channel_id in ChannelManager.
 483 pub(super) enum ChannelError {
 484         Ignore(String),
 485         Close(String),
 486         CloseDelayBroadcast(String),
 487 }
 488
 489 impl fmt::Debug for ChannelError {
 490         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 491                 match self {
 492                         &ChannelError::Ignore(ref e) => write!(f, "Ignore : {}", e),
 493                         &ChannelError::Close(ref e) => write!(f, "Close : {}", e),
 494                         &ChannelError::CloseDelayBroadcast(ref e) => write!(f, "CloseDelayBroadcast : {}", e)
 495                 }
 496         }
 497 }
 498
 499 macro_rules! secp_check {
 500         ($res: expr, $err: expr) => {
 501                 match $res {
 502                         Ok(thing) => thing,
 503                         Err(_) => return Err(ChannelError::Close($err)),
 504                 }
 505         };
 506 }
 507
 508 impl<Signer: Sign> Channel<Signer> {
 509         // Convert constants + channel value to limits:
 510         fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
 511                 channel_value_satoshis * 1000 / 10 //TODO
 512         }
 513
 514         /// Returns a minimum channel reserve value the remote needs to maintain,
 515         /// required by us.
 516         ///
 517         /// Guaranteed to return a value no larger than channel_value_satoshis
 518         pub(crate) fn get_holder_selected_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
 519                 let (q, _) = channel_value_satoshis.overflowing_div(100);
 520                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
 521         }
 522
 523         // Constructors:
 524         pub fn new_outbound<K: Deref, F: Deref>(fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, config: &UserConfig) -> Result<Channel<Signer>, APIError>
 525         where K::Target: KeysInterface<Signer = Signer>,
 526               F::Target: FeeEstimator,
 527         {
 528                 let holder_selected_contest_delay = config.own_channel_config.our_to_self_delay;
 529                 let holder_signer = keys_provider.get_channel_signer(false, channel_value_satoshis);
 530                 let pubkeys = holder_signer.pubkeys().clone();
 531
 532                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
 533                         return Err(APIError::APIMisuseError{err: format!("funding_value must be smaller than {}, it was {}", MAX_FUNDING_SATOSHIS, channel_value_satoshis)});
 534                 }
 535                 let channel_value_msat = channel_value_satoshis * 1000;
 536                 if push_msat > channel_value_msat {
 537                         return Err(APIError::APIMisuseError { err: format!("Push value ({}) was larger than channel_value ({})", push_msat, channel_value_msat) });
 538                 }
 539                 if holder_selected_contest_delay < BREAKDOWN_TIMEOUT {
 540                         return Err(APIError::APIMisuseError {err: format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks", holder_selected_contest_delay)});
 541                 }
 542                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(channel_value_satoshis);
 543                 if holder_selected_channel_reserve_satoshis < MIN_DUST_LIMIT_SATOSHIS {
 544                         return Err(APIError::APIMisuseError { err: format!("Holder selected channel  reserve below implemention limit dust_limit_satoshis {}", holder_selected_channel_reserve_satoshis) });
 545                 }
 546
 547                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
 548
 549                 let mut secp_ctx = Secp256k1::new();
 550                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
 551
 552                 Ok(Channel {
 553                         user_id,
 554                         config: config.channel_options.clone(),
 555
 556                         channel_id: keys_provider.get_secure_random_bytes(),
 557                         channel_state: ChannelState::OurInitSent as u32,
 558                         secp_ctx,
 559                         channel_value_satoshis,
 560
 561                         latest_monitor_update_id: 0,
 562
 563                         holder_signer,
 564                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 565                         destination_script: keys_provider.get_destination_script(),
 566
 567                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 568                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 569                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
 570
 571                         pending_inbound_htlcs: Vec::new(),
 572                         pending_outbound_htlcs: Vec::new(),
 573                         holding_cell_htlc_updates: Vec::new(),
 574                         pending_update_fee: None,
 575                         holding_cell_update_fee: None,
 576                         next_holder_htlc_id: 0,
 577                         next_counterparty_htlc_id: 0,
 578                         update_time_counter: 1,
 579
 580                         resend_order: RAACommitmentOrder::CommitmentFirst,
 581
 582                         monitor_pending_funding_locked: false,
 583                         monitor_pending_revoke_and_ack: false,
 584                         monitor_pending_commitment_signed: false,
 585                         monitor_pending_forwards: Vec::new(),
 586                         monitor_pending_failures: Vec::new(),
 587
 588                         #[cfg(debug_assertions)]
 589                         holder_max_commitment_tx_output: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 590                         #[cfg(debug_assertions)]
 591                         counterparty_max_commitment_tx_output: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 592
 593                         last_sent_closing_fee: None,
 594
 595                         funding_tx_confirmed_in: None,
 596                         funding_tx_confirmation_height: 0,
 597                         short_channel_id: None,
 598
 599                         feerate_per_kw: feerate,
 600                         counterparty_dust_limit_satoshis: 0,
 601                         holder_dust_limit_satoshis: MIN_DUST_LIMIT_SATOSHIS,
 602                         counterparty_max_htlc_value_in_flight_msat: 0,
 603                         counterparty_selected_channel_reserve_satoshis: 0,
 604                         counterparty_htlc_minimum_msat: 0,
 605                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
 606                         counterparty_max_accepted_htlcs: 0,
 607                         minimum_depth: 0, // Filled in in accept_channel
 608
 609                         counterparty_forwarding_info: None,
 610
 611                         channel_transaction_parameters: ChannelTransactionParameters {
 612                                 holder_pubkeys: pubkeys,
 613                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
 614                                 is_outbound_from_holder: true,
 615                                 counterparty_parameters: None,
 616                                 funding_outpoint: None
 617                         },
 618                         funding_transaction: None,
 619
 620                         counterparty_cur_commitment_point: None,
 621                         counterparty_prev_commitment_point: None,
 622                         counterparty_node_id,
 623
 624                         counterparty_shutdown_scriptpubkey: None,
 625
 626                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
 627
 628                         channel_update_status: ChannelUpdateStatus::Enabled,
 629
 630                         announcement_sigs: None,
 631
 632                         #[cfg(any(test, feature = "fuzztarget"))]
 633                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
 634                         #[cfg(any(test, feature = "fuzztarget"))]
 635                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
 636                 })
 637         }
 638
 639         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
 640                 where F::Target: FeeEstimator
 641         {
 642                 let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 643                 if feerate_per_kw < lower_limit {
 644                         return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {}", feerate_per_kw, lower_limit)));
 645                 }
 646                 let upper_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) as u64  * 2;
 647                 if feerate_per_kw as u64 > upper_limit {
 648                         return Err(ChannelError::Close(format!("Peer's feerate much too high. Actual: {}. Our expected upper limit: {}", feerate_per_kw, upper_limit)));
 649                 }
 650                 Ok(())
 651         }
 652
 653         /// Creates a new channel from a remote sides' request for one.
 654         /// Assumes chain_hash has already been checked and corresponds with what we expect!
 655         pub fn new_from_req<K: Deref, F: Deref>(fee_estimator: &F, keys_provider: &K, counterparty_node_id: PublicKey, their_features: InitFeatures, msg: &msgs::OpenChannel, user_id: u64, config: &UserConfig) -> Result<Channel<Signer>, ChannelError>
 656                 where K::Target: KeysInterface<Signer = Signer>,
 657           F::Target: FeeEstimator
 658         {
 659                 let holder_signer = keys_provider.get_channel_signer(true, msg.funding_satoshis);
 660                 let pubkeys = holder_signer.pubkeys().clone();
 661                 let counterparty_pubkeys = ChannelPublicKeys {
 662                         funding_pubkey: msg.funding_pubkey,
 663                         revocation_basepoint: msg.revocation_basepoint,
 664                         payment_point: msg.payment_point,
 665                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
 666                         htlc_basepoint: msg.htlc_basepoint
 667                 };
 668                 let mut local_config = (*config).channel_options.clone();
 669
 670                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
 671                         return Err(ChannelError::Close(format!("Configured with an unreasonable our_to_self_delay ({}) putting user funds at risks. It must be greater than {}", config.own_channel_config.our_to_self_delay, BREAKDOWN_TIMEOUT)));
 672                 }
 673
 674                 // Check sanity of message fields:
 675                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
 676                         return Err(ChannelError::Close(format!("Funding must be smaller than {}. It was {}", MAX_FUNDING_SATOSHIS, msg.funding_satoshis)));
 677                 }
 678                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
 679                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must be not greater than funding_satoshis: {}", msg.channel_reserve_satoshis, msg.funding_satoshis)));
 680                 }
 681                 let funding_value = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
 682                 if msg.push_msat > funding_value {
 683                         return Err(ChannelError::Close(format!("push_msat {} was larger than funding value {}", msg.push_msat, funding_value)));
 684                 }
 685                 if msg.dust_limit_satoshis > msg.funding_satoshis {
 686                         return Err(ChannelError::Close(format!("dust_limit_satoshis {} was larger than funding_satoshis {}. Peer never wants payout outputs?", msg.dust_limit_satoshis, msg.funding_satoshis)));
 687                 }
 688                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
 689                         return Err(ChannelError::Close(format!("Bogus; channel reserve ({}) is less than dust limit ({})", msg.channel_reserve_satoshis, msg.dust_limit_satoshis)));
 690                 }
 691                 let full_channel_value_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000;
 692                 if msg.htlc_minimum_msat >= full_channel_value_msat {
 693                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) was larger than full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
 694                 }
 695                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
 696
 697                 let max_counterparty_selected_contest_delay = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
 698                 if msg.to_self_delay > max_counterparty_selected_contest_delay {
 699                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_counterparty_selected_contest_delay, msg.to_self_delay)));
 700                 }
 701                 if msg.max_accepted_htlcs < 1 {
 702                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
 703                 }
 704                 if msg.max_accepted_htlcs > MAX_HTLCS {
 705                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
 706                 }
 707
 708                 // Now check against optional parameters as set by config...
 709                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
 710                         return Err(ChannelError::Close(format!("Funding satoshis ({}) is less than the user specified limit ({})", msg.funding_satoshis, config.peer_channel_config_limits.min_funding_satoshis)));
 711                 }
 712                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
 713                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat,  config.peer_channel_config_limits.max_htlc_minimum_msat)));
 714                 }
 715                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
 716                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
 717                 }
 718                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
 719                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
 720                 }
 721                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
 722                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
 723                 }
 724                 if msg.dust_limit_satoshis < MIN_DUST_LIMIT_SATOSHIS {
 725                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_DUST_LIMIT_SATOSHIS)));
 726                 }
 727                 if msg.dust_limit_satoshis >  MAX_DUST_LIMIT_SATOSHIS {
 728                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_DUST_LIMIT_SATOSHIS)));
 729                 }
 730
 731                 // Convert things into internal flags and prep our state:
 732
 733                 let announce = if (msg.channel_flags & 1) == 1 { true } else { false };
 734                 if config.peer_channel_config_limits.force_announced_channel_preference {
 735                         if local_config.announced_channel != announce {
 736                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours".to_owned()));
 737                         }
 738                 }
 739                 // we either accept their preference or the preferences match
 740                 local_config.announced_channel = announce;
 741
 742                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 743
 744                 let holder_selected_channel_reserve_satoshis = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(msg.funding_satoshis);
 745                 if holder_selected_channel_reserve_satoshis < MIN_DUST_LIMIT_SATOSHIS {
 746                         return Err(ChannelError::Close(format!("Suitable channel reserve not found. remote_channel_reserve was ({}). dust_limit_satoshis is ({}).", holder_selected_channel_reserve_satoshis, MIN_DUST_LIMIT_SATOSHIS)));
 747                 }
 748                 if msg.channel_reserve_satoshis < MIN_DUST_LIMIT_SATOSHIS {
 749                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is smaller than our dust limit ({})", msg.channel_reserve_satoshis, MIN_DUST_LIMIT_SATOSHIS)));
 750                 }
 751                 if holder_selected_channel_reserve_satoshis < msg.dust_limit_satoshis {
 752                         return Err(ChannelError::Close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", msg.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
 753                 }
 754
 755                 // check if the funder's amount for the initial commitment tx is sufficient
 756                 // for full fee payment
 757                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
 758                 let lower_limit = background_feerate as u64 * COMMITMENT_TX_BASE_WEIGHT;
 759                 if funders_amount_msat < lower_limit {
 760                         return Err(ChannelError::Close(format!("Insufficient funding amount ({}) for initial commitment. Must be at least {}", funders_amount_msat, lower_limit)));
 761                 }
 762
 763                 let to_local_msat = msg.push_msat;
 764                 let to_remote_msat = funders_amount_msat - background_feerate as u64 * COMMITMENT_TX_BASE_WEIGHT;
 765                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= holder_selected_channel_reserve_satoshis * 1000 {
 766                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment".to_owned()));
 767                 }
 768
 769                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
 770                         match &msg.shutdown_scriptpubkey {
 771                                 &OptionalField::Present(ref script) => {
 772                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
 773                                         if script.len() == 0 {
 774                                                 None
 775                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
 776                                         } else if is_unsupported_shutdown_script(&their_features, script) {
 777                                                 return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format. script: ({})", script.to_bytes().to_hex())));
 778                                         } else {
 779                                                 Some(script.clone())
 780                                         }
 781                                 },
 782                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
 783                                 &OptionalField::Absent => {
 784                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
 785                                 }
 786                         }
 787                 } else { None };
 788
 789                 let mut secp_ctx = Secp256k1::new();
 790                 secp_ctx.seeded_randomize(&keys_provider.get_secure_random_bytes());
 791
 792                 let chan = Channel {
 793                         user_id,
 794                         config: local_config,
 795
 796                         channel_id: msg.temporary_channel_id,
 797                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
 798                         secp_ctx,
 799
 800                         latest_monitor_update_id: 0,
 801
 802                         holder_signer,
 803                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 804                         destination_script: keys_provider.get_destination_script(),
 805
 806                         cur_holder_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 807                         cur_counterparty_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 808                         value_to_self_msat: msg.push_msat,
 809
 810                         pending_inbound_htlcs: Vec::new(),
 811                         pending_outbound_htlcs: Vec::new(),
 812                         holding_cell_htlc_updates: Vec::new(),
 813                         pending_update_fee: None,
 814                         holding_cell_update_fee: None,
 815                         next_holder_htlc_id: 0,
 816                         next_counterparty_htlc_id: 0,
 817                         update_time_counter: 1,
 818
 819                         resend_order: RAACommitmentOrder::CommitmentFirst,
 820
 821                         monitor_pending_funding_locked: false,
 822                         monitor_pending_revoke_and_ack: false,
 823                         monitor_pending_commitment_signed: false,
 824                         monitor_pending_forwards: Vec::new(),
 825                         monitor_pending_failures: Vec::new(),
 826
 827                         #[cfg(debug_assertions)]
 828                         holder_max_commitment_tx_output: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 829                         #[cfg(debug_assertions)]
 830                         counterparty_max_commitment_tx_output: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 831
 832                         last_sent_closing_fee: None,
 833
 834                         funding_tx_confirmed_in: None,
 835                         funding_tx_confirmation_height: 0,
 836                         short_channel_id: None,
 837
 838                         feerate_per_kw: msg.feerate_per_kw,
 839                         channel_value_satoshis: msg.funding_satoshis,
 840                         counterparty_dust_limit_satoshis: msg.dust_limit_satoshis,
 841                         holder_dust_limit_satoshis: MIN_DUST_LIMIT_SATOSHIS,
 842                         counterparty_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
 843                         counterparty_selected_channel_reserve_satoshis: msg.channel_reserve_satoshis,
 844                         counterparty_htlc_minimum_msat: msg.htlc_minimum_msat,
 845                         holder_htlc_minimum_msat: if config.own_channel_config.our_htlc_minimum_msat == 0 { 1 } else { config.own_channel_config.our_htlc_minimum_msat },
 846                         counterparty_max_accepted_htlcs: msg.max_accepted_htlcs,
 847                         minimum_depth: config.own_channel_config.minimum_depth,
 848
 849                         counterparty_forwarding_info: None,
 850
 851                         channel_transaction_parameters: ChannelTransactionParameters {
 852                                 holder_pubkeys: pubkeys,
 853                                 holder_selected_contest_delay: config.own_channel_config.our_to_self_delay,
 854                                 is_outbound_from_holder: false,
 855                                 counterparty_parameters: Some(CounterpartyChannelTransactionParameters {
 856                                         selected_contest_delay: msg.to_self_delay,
 857                                         pubkeys: counterparty_pubkeys,
 858                                 }),
 859                                 funding_outpoint: None
 860                         },
 861                         funding_transaction: None,
 862
 863                         counterparty_cur_commitment_point: Some(msg.first_per_commitment_point),
 864                         counterparty_prev_commitment_point: None,
 865                         counterparty_node_id,
 866
 867                         counterparty_shutdown_scriptpubkey,
 868
 869                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
 870
 871                         channel_update_status: ChannelUpdateStatus::Enabled,
 872
 873                         announcement_sigs: None,
 874
 875                         #[cfg(any(test, feature = "fuzztarget"))]
 876                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
 877                         #[cfg(any(test, feature = "fuzztarget"))]
 878                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
 879                 };
 880
 881                 Ok(chan)
 882         }
 883
 884         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
 885         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
 886         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
 887         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
 888         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
 889         /// an HTLC to a).
 890         /// @local is used only to convert relevant internal structures which refer to remote vs local
 891         /// to decide value of outputs and direction of HTLCs.
 892         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
 893         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
 894         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
 895         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
 896         /// which peer generated this transaction and "to whom" this transaction flows.
 897         /// Returns (the transaction info, the number of HTLC outputs which were present in the
 898         /// transaction, the list of HTLCs which were not ignored when building the transaction).
 899         /// Note that below-dust HTLCs are included in the third return value, but not the second, and
 900         /// sources are provided only for outbound HTLCs in the third return value.
 901         #[inline]
 902         fn build_commitment_transaction<L: Deref>(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, feerate_per_kw: u32, logger: &L) -> (CommitmentTransaction, usize, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>) where L::Target: Logger {
 903                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
 904                 let num_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
 905                 let mut included_non_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(num_htlcs);
 906
 907                 let broadcaster_dust_limit_satoshis = if local { self.holder_dust_limit_satoshis } else { self.counterparty_dust_limit_satoshis };
 908                 let mut remote_htlc_total_msat = 0;
 909                 let mut local_htlc_total_msat = 0;
 910                 let mut value_to_self_msat_offset = 0;
 911
 912                 log_trace!(logger, "Building commitment transaction number {} (really {} xor {}) for {}, generated by {} with fee {}...", commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number), get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound()), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
 913
 914                 macro_rules! get_htlc_in_commitment {
 915                         ($htlc: expr, $offered: expr) => {
 916                                 HTLCOutputInCommitment {
 917                                         offered: $offered,
 918                                         amount_msat: $htlc.amount_msat,
 919                                         cltv_expiry: $htlc.cltv_expiry,
 920                                         payment_hash: $htlc.payment_hash,
 921                                         transaction_output_index: None
 922                                 }
 923                         }
 924                 }
 925
 926                 macro_rules! add_htlc_output {
 927                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
 928                                 if $outbound == local { // "offered HTLC output"
 929                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
 930                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
 931                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 932                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
 933                                         } else {
 934                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 935                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 936                                         }
 937                                 } else {
 938                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
 939                                         if $htlc.amount_msat / 1000 >= broadcaster_dust_limit_satoshis + (feerate_per_kw as u64 * HTLC_SUCCESS_TX_WEIGHT / 1000) {
 940                                                 log_trace!(logger, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 941                                                 included_non_dust_htlcs.push((htlc_in_tx, $source));
 942                                         } else {
 943                                                 log_trace!(logger, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 944                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 945                                         }
 946                                 }
 947                         }
 948                 }
 949
 950                 for ref htlc in self.pending_inbound_htlcs.iter() {
 951                         let (include, state_name) = match htlc.state {
 952                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
 953                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
 954                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
 955                                 InboundHTLCState::Committed => (true, "Committed"),
 956                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
 957                         };
 958
 959                         if include {
 960                                 add_htlc_output!(htlc, false, None, state_name);
 961                                 remote_htlc_total_msat += htlc.amount_msat;
 962                         } else {
 963                                 log_trace!(logger, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 964                                 match &htlc.state {
 965                                         &InboundHTLCState::LocalRemoved(ref reason) => {
 966                                                 if generated_by_local {
 967                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
 968                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
 969                                                         }
 970                                                 }
 971                                         },
 972                                         _ => {},
 973                                 }
 974                         }
 975                 }
 976
 977                 for ref htlc in self.pending_outbound_htlcs.iter() {
 978                         let (include, state_name) = match htlc.state {
 979                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
 980                                 OutboundHTLCState::Committed => (true, "Committed"),
 981                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
 982                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
 983                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
 984                         };
 985
 986                         if include {
 987                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
 988                                 local_htlc_total_msat += htlc.amount_msat;
 989                         } else {
 990                                 log_trace!(logger, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 991                                 match htlc.state {
 992                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(None)|OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) => {
 993                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
 994                                         },
 995                                         OutboundHTLCState::RemoteRemoved(None) => {
 996                                                 if !generated_by_local {
 997                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
 998                                                 }
 999                                         },
1000                                         _ => {},
1001                                 }
1002                         }
1003                 }
1004
1005                 let value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
1006                 assert!(value_to_self_msat >= 0);
1007                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
1008                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
1009                 // "violate" their reserve value by couting those against it. Thus, we have to convert
1010                 // everything to i64 before subtracting as otherwise we can overflow.
1011                 let value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
1012                 assert!(value_to_remote_msat >= 0);
1013
1014                 #[cfg(debug_assertions)]
1015                 {
1016                         // Make sure that the to_self/to_remote is always either past the appropriate
1017                         // channel_reserve *or* it is making progress towards it.
1018                         let mut broadcaster_max_commitment_tx_output = if generated_by_local {
1019                                 self.holder_max_commitment_tx_output.lock().unwrap()
1020                         } else {
1021                                 self.counterparty_max_commitment_tx_output.lock().unwrap()
1022                         };
1023                         debug_assert!(broadcaster_max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.counterparty_selected_channel_reserve_satoshis as i64);
1024                         broadcaster_max_commitment_tx_output.0 = cmp::max(broadcaster_max_commitment_tx_output.0, value_to_self_msat as u64);
1025                         debug_assert!(broadcaster_max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis) as i64);
1026                         broadcaster_max_commitment_tx_output.1 = cmp::max(broadcaster_max_commitment_tx_output.1, value_to_remote_msat as u64);
1027                 }
1028
1029                 let total_fee = feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + (included_non_dust_htlcs.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
1030                 let (value_to_self, value_to_remote) = if self.is_outbound() {
1031                         (value_to_self_msat / 1000 - total_fee as i64, value_to_remote_msat / 1000)
1032                 } else {
1033                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - total_fee as i64)
1034                 };
1035
1036                 let mut value_to_a = if local { value_to_self } else { value_to_remote };
1037                 let mut value_to_b = if local { value_to_remote } else { value_to_self };
1038
1039                 if value_to_a >= (broadcaster_dust_limit_satoshis as i64) {
1040                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
1041                 } else {
1042                         value_to_a = 0;
1043                 }
1044
1045                 if value_to_b >= (broadcaster_dust_limit_satoshis as i64) {
1046                         log_trace!(logger, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
1047                 } else {
1048                         value_to_b = 0;
1049                 }
1050
1051                 let num_nondust_htlcs = included_non_dust_htlcs.len();
1052
1053                 let channel_parameters =
1054                         if local { self.channel_transaction_parameters.as_holder_broadcastable() }
1055                         else { self.channel_transaction_parameters.as_counterparty_broadcastable() };
1056                 let tx = CommitmentTransaction::new_with_auxiliary_htlc_data(commitment_number,
1057                                                                              value_to_a as u64,
1058                                                                              value_to_b as u64,
1059                                                                              keys.clone(),
1060                                                                              feerate_per_kw,
1061                                                                              &mut included_non_dust_htlcs,
1062                                                                              &channel_parameters
1063                 );
1064                 let mut htlcs_included = included_non_dust_htlcs;
1065                 // The unwrap is safe, because all non-dust HTLCs have been assigned an output index
1066                 htlcs_included.sort_unstable_by_key(|h| h.0.transaction_output_index.unwrap());
1067                 htlcs_included.append(&mut included_dust_htlcs);
1068
1069                 (tx, num_nondust_htlcs, htlcs_included)
1070         }
1071
1072         #[inline]
1073         fn get_closing_scriptpubkey(&self) -> Script {
1074                 let channel_close_key_hash = WPubkeyHash::hash(&self.shutdown_pubkey.serialize());
1075                 Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_close_key_hash[..]).into_script()
1076         }
1077
1078         #[inline]
1079         fn get_closing_transaction_weight(&self, a_scriptpubkey: Option<&Script>, b_scriptpubkey: Option<&Script>) -> u64 {
1080                 let mut ret =
1081                 (4 +                                           // version
1082                  1 +                                           // input count
1083                  36 +                                          // prevout
1084                  1 +                                           // script length (0)
1085                  4 +                                           // sequence
1086                  1 +                                           // output count
1087                  4                                             // lock time
1088                  )*4 +                                         // * 4 for non-witness parts
1089                 2 +                                            // witness marker and flag
1090                 1 +                                            // witness element count
1091                 4 +                                            // 4 element lengths (2 sigs, multisig dummy, and witness script)
1092                 self.get_funding_redeemscript().len() as u64 + // funding witness script
1093                 2*(1 + 71);                                    // two signatures + sighash type flags
1094                 if let Some(spk) = a_scriptpubkey {
1095                         ret += ((8+1) +                            // output values and script length
1096                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1097                 }
1098                 if let Some(spk) = b_scriptpubkey {
1099                         ret += ((8+1) +                            // output values and script length
1100                                 spk.len() as u64) * 4;                 // scriptpubkey and witness multiplier
1101                 }
1102                 ret
1103         }
1104
1105         #[inline]
1106         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
1107                 let txins = {
1108                         let mut ins: Vec<TxIn> = Vec::new();
1109                         ins.push(TxIn {
1110                                 previous_output: self.funding_outpoint().into_bitcoin_outpoint(),
1111                                 script_sig: Script::new(),
1112                                 sequence: 0xffffffff,
1113                                 witness: Vec::new(),
1114                         });
1115                         ins
1116                 };
1117
1118                 assert!(self.pending_inbound_htlcs.is_empty());
1119                 assert!(self.pending_outbound_htlcs.is_empty());
1120                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
1121
1122                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1123                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.is_outbound() { total_fee_satoshis as i64 } else { 0 };
1124                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.is_outbound() { 0 } else { total_fee_satoshis as i64 };
1125
1126                 if value_to_self < 0 {
1127                         assert!(self.is_outbound());
1128                         total_fee_satoshis += (-value_to_self) as u64;
1129                 } else if value_to_remote < 0 {
1130                         assert!(!self.is_outbound());
1131                         total_fee_satoshis += (-value_to_remote) as u64;
1132                 }
1133
1134                 if !skip_remote_output && value_to_remote as u64 > self.holder_dust_limit_satoshis {
1135                         txouts.push((TxOut {
1136                                 script_pubkey: self.counterparty_shutdown_scriptpubkey.clone().unwrap(),
1137                                 value: value_to_remote as u64
1138                         }, ()));
1139                 }
1140
1141                 if value_to_self as u64 > self.holder_dust_limit_satoshis {
1142                         txouts.push((TxOut {
1143                                 script_pubkey: self.get_closing_scriptpubkey(),
1144                                 value: value_to_self as u64
1145                         }, ()));
1146                 }
1147
1148                 transaction_utils::sort_outputs(&mut txouts, |_, _| { cmp::Ordering::Equal }); // Ordering doesnt matter if they used our pubkey...
1149
1150                 let mut outputs: Vec<TxOut> = Vec::new();
1151                 for out in txouts.drain(..) {
1152                         outputs.push(out.0);
1153                 }
1154
1155                 (Transaction {
1156                         version: 2,
1157                         lock_time: 0,
1158                         input: txins,
1159                         output: outputs,
1160                 }, total_fee_satoshis)
1161         }
1162
1163         fn funding_outpoint(&self) -> OutPoint {
1164                 self.channel_transaction_parameters.funding_outpoint.unwrap()
1165         }
1166
1167         #[inline]
1168         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1169         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1170         /// our counterparty!)
1171         /// The result is a transaction which we can revoke broadcastership of (ie a "local" transaction)
1172         /// TODO Some magic rust shit to compile-time check this?
1173         fn build_holder_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1174                 let per_commitment_point = self.holder_signer.get_per_commitment_point(commitment_number, &self.secp_ctx);
1175                 let delayed_payment_base = &self.get_holder_pubkeys().delayed_payment_basepoint;
1176                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1177                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1178
1179                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys".to_owned()))
1180         }
1181
1182         #[inline]
1183         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1184         /// will sign and send to our counterparty.
1185         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1186         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1187                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1188                 //may see payments to it!
1189                 let revocation_basepoint = &self.get_holder_pubkeys().revocation_basepoint;
1190                 let htlc_basepoint = &self.get_holder_pubkeys().htlc_basepoint;
1191                 let counterparty_pubkeys = self.get_counterparty_pubkeys();
1192
1193                 Ok(secp_check!(TxCreationKeys::derive_new(&self.secp_ctx, &self.counterparty_cur_commitment_point.unwrap(), &counterparty_pubkeys.delayed_payment_basepoint, &counterparty_pubkeys.htlc_basepoint, revocation_basepoint, htlc_basepoint), "Remote tx keys generation got bogus keys".to_owned()))
1194         }
1195
1196         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1197         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1198         /// Panics if called before accept_channel/new_from_req
1199         pub fn get_funding_redeemscript(&self) -> Script {
1200                 make_funding_redeemscript(&self.get_holder_pubkeys().funding_pubkey, self.counterparty_funding_pubkey())
1201         }
1202
1203         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
1204         /// @local is used only to convert relevant internal structures which refer to remote vs local
1205         /// to decide value of outputs and direction of HTLCs.
1206         fn build_htlc_transaction(&self, prev_hash: &Txid, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys, feerate_per_kw: u32) -> Transaction {
1207                 chan_utils::build_htlc_transaction(prev_hash, feerate_per_kw, if local { self.get_counterparty_selected_contest_delay() } else { self.get_holder_selected_contest_delay() }, htlc, &keys.broadcaster_delayed_payment_key, &keys.revocation_key)
1208         }
1209
1210         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1211         /// In such cases we debug_assert!(false) and return a ChannelError::Ignore. Thus, will always
1212         /// return Ok(_) if debug assertions are turned on or preconditions are met.
1213         ///
1214         /// Note that it is still possible to hit these assertions in case we find a preimage on-chain
1215         /// but then have a reorg which settles on an HTLC-failure on chain.
1216         fn get_update_fulfill_htlc<L: Deref>(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage, logger: &L) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitorUpdate>), ChannelError> where L::Target: Logger {
1217                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1218                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1219                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1220                 // either.
1221                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1222                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1223                 }
1224                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1225
1226                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1227
1228                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1229                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1230                 // these, but for now we just have to treat them as normal.
1231
1232                 let mut pending_idx = core::usize::MAX;
1233                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1234                         if htlc.htlc_id == htlc_id_arg {
1235                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1236                                 match htlc.state {
1237                                         InboundHTLCState::Committed => {},
1238                                         InboundHTLCState::LocalRemoved(ref reason) => {
1239                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1240                                                 } else {
1241                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1242                                                 }
1243                                                 debug_assert!(false, "Tried to fulfill an HTLC that was already fail/fulfilled");
1244                                                 return Ok((None, None));
1245                                         },
1246                                         _ => {
1247                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1248                                                 // Don't return in release mode here so that we can update channel_monitor
1249                                         }
1250                                 }
1251                                 pending_idx = idx;
1252                                 break;
1253                         }
1254                 }
1255                 if pending_idx == core::usize::MAX {
1256                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1257                 }
1258
1259                 // Now update local state:
1260                 //
1261                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1262                 // can claim it even if the channel hits the chain before we see their next commitment.
1263                 self.latest_monitor_update_id += 1;
1264                 let monitor_update = ChannelMonitorUpdate {
1265                         update_id: self.latest_monitor_update_id,
1266                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1267                                 payment_preimage: payment_preimage_arg.clone(),
1268                         }],
1269                 };
1270
1271                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1272                         for pending_update in self.holding_cell_htlc_updates.iter() {
1273                                 match pending_update {
1274                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1275                                                 if htlc_id_arg == htlc_id {
1276                                                         // Make sure we don't leave latest_monitor_update_id incremented here:
1277                                                         self.latest_monitor_update_id -= 1;
1278                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already fulfilled");
1279                                                         return Ok((None, None));
1280                                                 }
1281                                         },
1282                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1283                                                 if htlc_id_arg == htlc_id {
1284                                                         log_warn!(logger, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1285                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1286                                                         // rare enough it may not be worth the complexity burden.
1287                                                         debug_assert!(false, "Tried to fulfill an HTLC that was already failed");
1288                                                         return Ok((None, Some(monitor_update)));
1289                                                 }
1290                                         },
1291                                         _ => {}
1292                                 }
1293                         }
1294                         log_trace!(logger, "Adding HTLC claim to holding_cell! Current state: {}", self.channel_state);
1295                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1296                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1297                         });
1298                         return Ok((None, Some(monitor_update)));
1299                 }
1300
1301                 {
1302                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1303                         if let InboundHTLCState::Committed = htlc.state {
1304                         } else {
1305                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1306                                 return Ok((None, Some(monitor_update)));
1307                         }
1308                         log_trace!(logger, "Upgrading HTLC {} to LocalRemoved with a Fulfill!", log_bytes!(htlc.payment_hash.0));
1309                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1310                 }
1311
1312                 Ok((Some(msgs::UpdateFulfillHTLC {
1313                         channel_id: self.channel_id(),
1314                         htlc_id: htlc_id_arg,
1315                         payment_preimage: payment_preimage_arg,
1316                 }), Some(monitor_update)))
1317         }
1318
1319         pub fn get_update_fulfill_htlc_and_commit<L: Deref>(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage, logger: &L) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitorUpdate>), ChannelError> where L::Target: Logger {
1320                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage, logger)? {
1321                         (Some(update_fulfill_htlc), Some(mut monitor_update)) => {
1322                                 let (commitment, mut additional_update) = self.send_commitment_no_status_check(logger)?;
1323                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1324                                 // strictly increasing by one, so decrement it here.
1325                                 self.latest_monitor_update_id = monitor_update.update_id;
1326                                 monitor_update.updates.append(&mut additional_update.updates);
1327                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1328                         },
1329                         (Some(update_fulfill_htlc), None) => {
1330                                 let (commitment, monitor_update) = self.send_commitment_no_status_check(logger)?;
1331                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1332                         },
1333                         (None, Some(monitor_update)) => Ok((None, Some(monitor_update))),
1334                         (None, None) => Ok((None, None))
1335                 }
1336         }
1337
1338         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1339         /// In such cases we debug_assert!(false) and return a ChannelError::Ignore. Thus, will always
1340         /// return Ok(_) if debug assertions are turned on or preconditions are met.
1341         ///
1342         /// Note that it is still possible to hit these assertions in case we find a preimage on-chain
1343         /// but then have a reorg which settles on an HTLC-failure on chain.
1344         pub fn get_update_fail_htlc<L: Deref>(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket, logger: &L) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> where L::Target: Logger {
1345                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1346                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1347                 }
1348                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1349
1350                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1351                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1352                 // these, but for now we just have to treat them as normal.
1353
1354                 let mut pending_idx = core::usize::MAX;
1355                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1356                         if htlc.htlc_id == htlc_id_arg {
1357                                 match htlc.state {
1358                                         InboundHTLCState::Committed => {},
1359                                         InboundHTLCState::LocalRemoved(_) => {
1360                                                 debug_assert!(false, "Tried to fail an HTLC that was already fail/fulfilled");
1361                                                 return Ok(None);
1362                                         },
1363                                         _ => {
1364                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1365                                                 return Err(ChannelError::Ignore(format!("Unable to find a pending HTLC which matched the given HTLC ID ({})", htlc.htlc_id)));
1366                                         }
1367                                 }
1368                                 pending_idx = idx;
1369                         }
1370                 }
1371                 if pending_idx == core::usize::MAX {
1372                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1373                 }
1374
1375                 // Now update local state:
1376                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1377                         for pending_update in self.holding_cell_htlc_updates.iter() {
1378                                 match pending_update {
1379                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1380                                                 if htlc_id_arg == htlc_id {
1381                                                         debug_assert!(false, "Tried to fail an HTLC that was already fulfilled");
1382                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1383                                                 }
1384                                         },
1385                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1386                                                 if htlc_id_arg == htlc_id {
1387                                                         debug_assert!(false, "Tried to fail an HTLC that was already failed");
1388                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID".to_owned()));
1389                                                 }
1390                                         },
1391                                         _ => {}
1392                                 }
1393                         }
1394                         log_trace!(logger, "Placing failure for HTLC ID {} in holding cell", htlc_id_arg);
1395                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1396                                 htlc_id: htlc_id_arg,
1397                                 err_packet,
1398                         });
1399                         return Ok(None);
1400                 }
1401
1402                 log_trace!(logger, "Failing HTLC ID {} back with a update_fail_htlc message", htlc_id_arg);
1403                 {
1404                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1405                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1406                 }
1407
1408                 Ok(Some(msgs::UpdateFailHTLC {
1409                         channel_id: self.channel_id(),
1410                         htlc_id: htlc_id_arg,
1411                         reason: err_packet
1412                 }))
1413         }
1414
1415         // Message handlers:
1416
1417         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig, their_features: InitFeatures) -> Result<(), ChannelError> {
1418                 // Check sanity of message fields:
1419                 if !self.is_outbound() {
1420                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer".to_owned()));
1421                 }
1422                 if self.channel_state != ChannelState::OurInitSent as u32 {
1423                         return Err(ChannelError::Close("Got an accept_channel message at a strange time".to_owned()));
1424                 }
1425                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1426                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? dust_limit_satoshis was {}", msg.dust_limit_satoshis)));
1427                 }
1428                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1429                         return Err(ChannelError::Close(format!("Bogus channel_reserve_satoshis ({}). Must not be greater than ({})", msg.channel_reserve_satoshis, self.channel_value_satoshis)));
1430                 }
1431                 if msg.channel_reserve_satoshis < self.holder_dust_limit_satoshis {
1432                         return Err(ChannelError::Close(format!("Peer never wants payout outputs? channel_reserve_satoshis was ({}). dust_limit is ({})", msg.channel_reserve_satoshis, self.holder_dust_limit_satoshis)));
1433                 }
1434                 let remote_reserve = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis);
1435                 if msg.dust_limit_satoshis > remote_reserve {
1436                         return Err(ChannelError::Close(format!("Dust limit ({}) is bigger than our channel reserve ({})", msg.dust_limit_satoshis, remote_reserve)));
1437                 }
1438                 let full_channel_value_msat = (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000;
1439                 if msg.htlc_minimum_msat >= full_channel_value_msat {
1440                         return Err(ChannelError::Close(format!("Minimum htlc value ({}) is full channel value ({})", msg.htlc_minimum_msat, full_channel_value_msat)));
1441                 }
1442                 let max_delay_acceptable = u16::min(config.peer_channel_config_limits.their_to_self_delay, MAX_LOCAL_BREAKDOWN_TIMEOUT);
1443                 if msg.to_self_delay > max_delay_acceptable {
1444                         return Err(ChannelError::Close(format!("They wanted our payments to be delayed by a needlessly long period. Upper limit: {}. Actual: {}", max_delay_acceptable, msg.to_self_delay)));
1445                 }
1446                 if msg.max_accepted_htlcs < 1 {
1447                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel".to_owned()));
1448                 }
1449                 if msg.max_accepted_htlcs > MAX_HTLCS {
1450                         return Err(ChannelError::Close(format!("max_accepted_htlcs was {}. It must not be larger than {}", msg.max_accepted_htlcs, MAX_HTLCS)));
1451                 }
1452
1453                 // Now check against optional parameters as set by config...
1454                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1455                         return Err(ChannelError::Close(format!("htlc_minimum_msat ({}) is higher than the user specified limit ({})", msg.htlc_minimum_msat, config.peer_channel_config_limits.max_htlc_minimum_msat)));
1456                 }
1457                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1458                         return Err(ChannelError::Close(format!("max_htlc_value_in_flight_msat ({}) is less than the user specified limit ({})", msg.max_htlc_value_in_flight_msat, config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat)));
1459                 }
1460                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1461                         return Err(ChannelError::Close(format!("channel_reserve_satoshis ({}) is higher than the user specified limit ({})", msg.channel_reserve_satoshis, config.peer_channel_config_limits.max_channel_reserve_satoshis)));
1462                 }
1463                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1464                         return Err(ChannelError::Close(format!("max_accepted_htlcs ({}) is less than the user specified limit ({})", msg.max_accepted_htlcs, config.peer_channel_config_limits.min_max_accepted_htlcs)));
1465                 }
1466                 if msg.dust_limit_satoshis < MIN_DUST_LIMIT_SATOSHIS {
1467                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is less than the implementation limit ({})", msg.dust_limit_satoshis, MIN_DUST_LIMIT_SATOSHIS)));
1468                 }
1469                 if msg.dust_limit_satoshis > MAX_DUST_LIMIT_SATOSHIS {
1470                         return Err(ChannelError::Close(format!("dust_limit_satoshis ({}) is greater than the implementation limit ({})", msg.dust_limit_satoshis, MAX_DUST_LIMIT_SATOSHIS)));
1471                 }
1472                 if msg.minimum_depth > config.peer_channel_config_limits.max_minimum_depth {
1473                         return Err(ChannelError::Close(format!("We consider the minimum depth to be unreasonably large. Expected minimum: ({}). Actual: ({})", config.peer_channel_config_limits.max_minimum_depth, msg.minimum_depth)));
1474                 }
1475
1476                 let counterparty_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1477                         match &msg.shutdown_scriptpubkey {
1478                                 &OptionalField::Present(ref script) => {
1479                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1480                                         if script.len() == 0 {
1481                                                 None
1482                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
1483                                         } else if is_unsupported_shutdown_script(&their_features, script) {
1484                                                 return Err(ChannelError::Close(format!("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format. script: ({})", script.to_bytes().to_hex())));
1485                                         } else {
1486                                                 Some(script.clone())
1487                                         }
1488                                 },
1489                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1490                                 &OptionalField::Absent => {
1491                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out".to_owned()));
1492                                 }
1493                         }
1494                 } else { None };
1495
1496                 self.counterparty_dust_limit_satoshis = msg.dust_limit_satoshis;
1497                 self.counterparty_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1498                 self.counterparty_selected_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1499                 self.counterparty_htlc_minimum_msat = msg.htlc_minimum_msat;
1500                 self.counterparty_max_accepted_htlcs = msg.max_accepted_htlcs;
1501                 self.minimum_depth = msg.minimum_depth;
1502
1503                 let counterparty_pubkeys = ChannelPublicKeys {
1504                         funding_pubkey: msg.funding_pubkey,
1505                         revocation_basepoint: msg.revocation_basepoint,
1506                         payment_point: msg.payment_point,
1507                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1508                         htlc_basepoint: msg.htlc_basepoint
1509                 };
1510
1511                 self.channel_transaction_parameters.counterparty_parameters = Some(CounterpartyChannelTransactionParameters {
1512                         selected_contest_delay: msg.to_self_delay,
1513                         pubkeys: counterparty_pubkeys,
1514                 });
1515
1516                 self.counterparty_cur_commitment_point = Some(msg.first_per_commitment_point);
1517                 self.counterparty_shutdown_scriptpubkey = counterparty_shutdown_scriptpubkey;
1518
1519                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1520
1521                 Ok(())
1522         }
1523
1524         fn funding_created_signature<L: Deref>(&mut self, sig: &Signature, logger: &L) -> Result<(Txid, CommitmentTransaction, Signature), ChannelError> where L::Target: Logger {
1525                 let funding_script = self.get_funding_redeemscript();
1526
1527                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1528                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, self.feerate_per_kw, logger).0;
1529                 {
1530                         let trusted_tx = initial_commitment_tx.trust();
1531                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1532                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1533                         // They sign the holder commitment transaction...
1534                         log_trace!(logger, "Checking funding_created tx signature {} by key {} against tx {} (sighash {}) with redeemscript {}", log_bytes!(sig.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&initial_commitment_bitcoin_tx.transaction), log_bytes!(sighash[..]), encode::serialize_hex(&funding_script));
1535                         secp_check!(self.secp_ctx.verify(&sighash, &sig, self.counterparty_funding_pubkey()), "Invalid funding_created signature from peer".to_owned());
1536                 }
1537
1538                 let counterparty_keys = self.build_remote_transaction_keys()?;
1539                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, self.feerate_per_kw, logger).0;
1540
1541                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1542                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1543                 log_trace!(logger, "Initial counterparty ID {} tx {}", counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1544
1545                 let counterparty_signature = self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, &self.secp_ctx)
1546                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0;
1547
1548                 // We sign "counterparty" commitment transaction, allowing them to broadcast the tx if they wish.
1549                 Ok((counterparty_initial_bitcoin_tx.txid, initial_commitment_tx, counterparty_signature))
1550         }
1551
1552         fn counterparty_funding_pubkey(&self) -> &PublicKey {
1553                 &self.get_counterparty_pubkeys().funding_pubkey
1554         }
1555
1556         pub fn funding_created<L: Deref>(&mut self, msg: &msgs::FundingCreated, best_block: BestBlock, logger: &L) -> Result<(msgs::FundingSigned, ChannelMonitor<Signer>), ChannelError> where L::Target: Logger {
1557                 if self.is_outbound() {
1558                         return Err(ChannelError::Close("Received funding_created for an outbound channel?".to_owned()));
1559                 }
1560                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1561                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1562                         // remember the channel, so it's safe to just send an error_message here and drop the
1563                         // channel.
1564                         return Err(ChannelError::Close("Received funding_created after we got the channel!".to_owned()));
1565                 }
1566                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1567                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1568                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1569                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1570                 }
1571
1572                 let funding_txo = OutPoint { txid: msg.funding_txid, index: msg.funding_output_index };
1573                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
1574                 // This is an externally observable change before we finish all our checks.  In particular
1575                 // funding_created_signature may fail.
1576                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
1577
1578                 let (counterparty_initial_commitment_txid, initial_commitment_tx, signature) = match self.funding_created_signature(&msg.signature, logger) {
1579                         Ok(res) => res,
1580                         Err(ChannelError::Close(e)) => {
1581                                 self.channel_transaction_parameters.funding_outpoint = None;
1582                                 return Err(ChannelError::Close(e));
1583                         },
1584                         Err(e) => {
1585                                 // The only error we know how to handle is ChannelError::Close, so we fall over here
1586                                 // to make sure we don't continue with an inconsistent state.
1587                                 panic!("unexpected error type from funding_created_signature {:?}", e);
1588                         }
1589                 };
1590
1591                 let holder_commitment_tx = HolderCommitmentTransaction::new(
1592                         initial_commitment_tx,
1593                         msg.signature,
1594                         Vec::new(),
1595                         &self.get_holder_pubkeys().funding_pubkey,
1596                         self.counterparty_funding_pubkey()
1597                 );
1598
1599                 // Now that we're past error-generating stuff, update our local state:
1600
1601                 let funding_redeemscript = self.get_funding_redeemscript();
1602                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
1603                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
1604                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
1605                                                           &self.shutdown_pubkey, self.get_holder_selected_contest_delay(),
1606                                                           &self.destination_script, (funding_txo, funding_txo_script.clone()),
1607                                                           &self.channel_transaction_parameters,
1608                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
1609                                                           obscure_factor,
1610                                                           holder_commitment_tx, best_block);
1611
1612                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_commitment_txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
1613
1614                 self.channel_state = ChannelState::FundingSent as u32;
1615                 self.channel_id = funding_txo.to_channel_id();
1616                 self.cur_counterparty_commitment_transaction_number -= 1;
1617                 self.cur_holder_commitment_transaction_number -= 1;
1618
1619                 Ok((msgs::FundingSigned {
1620                         channel_id: self.channel_id,
1621                         signature
1622                 }, channel_monitor))
1623         }
1624
1625         /// Handles a funding_signed message from the remote end.
1626         /// If this call is successful, broadcast the funding transaction (and not before!)
1627         pub fn funding_signed<L: Deref>(&mut self, msg: &msgs::FundingSigned, best_block: BestBlock, logger: &L) -> Result<(ChannelMonitor<Signer>, Transaction), ChannelError> where L::Target: Logger {
1628                 if !self.is_outbound() {
1629                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?".to_owned()));
1630                 }
1631                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
1632                         return Err(ChannelError::Close("Received funding_signed in strange state!".to_owned()));
1633                 }
1634                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1635                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1636                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1637                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1638                 }
1639
1640                 let funding_script = self.get_funding_redeemscript();
1641
1642                 let counterparty_keys = self.build_remote_transaction_keys()?;
1643                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, self.feerate_per_kw, logger).0;
1644                 let counterparty_trusted_tx = counterparty_initial_commitment_tx.trust();
1645                 let counterparty_initial_bitcoin_tx = counterparty_trusted_tx.built_transaction();
1646
1647                 log_trace!(logger, "Initial counterparty ID {} tx {}", counterparty_initial_bitcoin_tx.txid, encode::serialize_hex(&counterparty_initial_bitcoin_tx.transaction));
1648
1649                 let holder_signer = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number)?;
1650                 let initial_commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &holder_signer, true, false, self.feerate_per_kw, logger).0;
1651                 {
1652                         let trusted_tx = initial_commitment_tx.trust();
1653                         let initial_commitment_bitcoin_tx = trusted_tx.built_transaction();
1654                         let sighash = initial_commitment_bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
1655                         // They sign our commitment transaction, allowing us to broadcast the tx if we wish.
1656                         if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
1657                                 return Err(ChannelError::Close("Invalid funding_signed signature from peer".to_owned()));
1658                         }
1659                 }
1660
1661                 let holder_commitment_tx = HolderCommitmentTransaction::new(
1662                         initial_commitment_tx,
1663                         msg.signature,
1664                         Vec::new(),
1665                         &self.get_holder_pubkeys().funding_pubkey,
1666                         self.counterparty_funding_pubkey()
1667                 );
1668
1669
1670                 let funding_redeemscript = self.get_funding_redeemscript();
1671                 let funding_txo = self.get_funding_txo().unwrap();
1672                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
1673                 let obscure_factor = get_commitment_transaction_number_obscure_factor(&self.get_holder_pubkeys().payment_point, &self.get_counterparty_pubkeys().payment_point, self.is_outbound());
1674                 let channel_monitor = ChannelMonitor::new(self.secp_ctx.clone(), self.holder_signer.clone(),
1675                                                           &self.shutdown_pubkey, self.get_holder_selected_contest_delay(),
1676                                                           &self.destination_script, (funding_txo, funding_txo_script),
1677                                                           &self.channel_transaction_parameters,
1678                                                           funding_redeemscript.clone(), self.channel_value_satoshis,
1679                                                           obscure_factor,
1680                                                           holder_commitment_tx, best_block);
1681
1682                 channel_monitor.provide_latest_counterparty_commitment_tx(counterparty_initial_bitcoin_tx.txid, Vec::new(), self.cur_counterparty_commitment_transaction_number, self.counterparty_cur_commitment_point.unwrap(), logger);
1683
1684                 assert_eq!(self.channel_state & (ChannelState::MonitorUpdateFailed as u32), 0); // We have no had any monitor(s) yet to fail update!
1685                 self.channel_state = ChannelState::FundingSent as u32;
1686                 self.cur_holder_commitment_transaction_number -= 1;
1687                 self.cur_counterparty_commitment_transaction_number -= 1;
1688
1689                 Ok((channel_monitor, self.funding_transaction.as_ref().cloned().unwrap()))
1690         }
1691
1692         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), ChannelError> {
1693                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1694                         return Err(ChannelError::Close("Peer sent funding_locked when we needed a channel_reestablish".to_owned()));
1695                 }
1696
1697                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
1698
1699                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1700                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1701                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1702                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
1703                         self.update_time_counter += 1;
1704                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
1705                                  // Note that funding_signed/funding_created will have decremented both by 1!
1706                                  self.cur_holder_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
1707                                  self.cur_counterparty_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
1708                                 // If we reconnected before sending our funding locked they may still resend theirs:
1709                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
1710                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
1711                         if self.counterparty_cur_commitment_point != Some(msg.next_per_commitment_point) {
1712                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point".to_owned()));
1713                         }
1714                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
1715                         return Ok(());
1716                 } else {
1717                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time".to_owned()));
1718                 }
1719
1720                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
1721                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
1722                 Ok(())
1723         }
1724
1725         /// Returns (inbound_htlc_count, htlc_inbound_value_msat)
1726         fn get_inbound_pending_htlc_stats(&self) -> (u32, u64) {
1727                 let mut htlc_inbound_value_msat = 0;
1728                 for ref htlc in self.pending_inbound_htlcs.iter() {
1729                         htlc_inbound_value_msat += htlc.amount_msat;
1730                 }
1731                 (self.pending_inbound_htlcs.len() as u32, htlc_inbound_value_msat)
1732         }
1733
1734         /// Returns (outbound_htlc_count, htlc_outbound_value_msat) *including* pending adds in our
1735         /// holding cell.
1736         fn get_outbound_pending_htlc_stats(&self) -> (u32, u64) {
1737                 let mut htlc_outbound_value_msat = 0;
1738                 for ref htlc in self.pending_outbound_htlcs.iter() {
1739                         htlc_outbound_value_msat += htlc.amount_msat;
1740                 }
1741
1742                 let mut htlc_outbound_count = self.pending_outbound_htlcs.len();
1743                 for update in self.holding_cell_htlc_updates.iter() {
1744                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
1745                                 htlc_outbound_count += 1;
1746                                 htlc_outbound_value_msat += amount_msat;
1747                         }
1748                 }
1749
1750                 (htlc_outbound_count as u32, htlc_outbound_value_msat)
1751         }
1752
1753         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
1754         /// Doesn't bother handling the
1755         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
1756         /// corner case properly.
1757         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
1758                 // Note that we have to handle overflow due to the above case.
1759                 (cmp::max(self.channel_value_satoshis as i64 * 1000 - self.value_to_self_msat as i64 - self.get_inbound_pending_htlc_stats().1 as i64, 0) as u64,
1760                 cmp::max(self.value_to_self_msat as i64 - self.get_outbound_pending_htlc_stats().1 as i64, 0) as u64)
1761         }
1762
1763         // Get the fee cost of a commitment tx with a given number of HTLC outputs.
1764         // Note that num_htlcs should not include dust HTLCs.
1765         fn commit_tx_fee_msat(&self, num_htlcs: usize) -> u64 {
1766                 // Note that we need to divide before multiplying to round properly,
1767                 // since the lowest denomination of bitcoin on-chain is the satoshi.
1768                 (COMMITMENT_TX_BASE_WEIGHT + num_htlcs as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC) * self.feerate_per_kw as u64 / 1000 * 1000
1769         }
1770
1771         // Get the commitment tx fee for the local's (i.e. our) next commitment transaction based on the
1772         // number of pending HTLCs that are on track to be in our next commitment tx, plus an additional
1773         // HTLC if `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs
1774         // are excluded.
1775         fn next_local_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
1776                 assert!(self.is_outbound());
1777
1778                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * HTLC_SUCCESS_TX_WEIGHT / 1000) + self.holder_dust_limit_satoshis;
1779                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * HTLC_TIMEOUT_TX_WEIGHT / 1000) + self.holder_dust_limit_satoshis;
1780
1781                 let mut addl_htlcs = 0;
1782                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
1783                 match htlc.origin {
1784                         HTLCInitiator::LocalOffered => {
1785                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
1786                                         addl_htlcs += 1;
1787                                 }
1788                         },
1789                         HTLCInitiator::RemoteOffered => {
1790                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
1791                                         addl_htlcs += 1;
1792                                 }
1793                         }
1794                 }
1795
1796                 let mut included_htlcs = 0;
1797                 for ref htlc in self.pending_inbound_htlcs.iter() {
1798                         if htlc.amount_msat / 1000 < real_dust_limit_success_sat {
1799                                 continue
1800                         }
1801                         // We include LocalRemoved HTLCs here because we may still need to broadcast a commitment
1802                         // transaction including this HTLC if it times out before they RAA.
1803                         included_htlcs += 1;
1804                 }
1805
1806                 for ref htlc in self.pending_outbound_htlcs.iter() {
1807                         if htlc.amount_msat / 1000 < real_dust_limit_timeout_sat {
1808                                 continue
1809                         }
1810                         match htlc.state {
1811                                 OutboundHTLCState::LocalAnnounced {..} => included_htlcs += 1,
1812                                 OutboundHTLCState::Committed => included_htlcs += 1,
1813                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
1814                                 // We don't include AwaitingRemoteRevokeToRemove HTLCs because our next commitment
1815                                 // transaction won't be generated until they send us their next RAA, which will mean
1816                                 // dropping any HTLCs in this state.
1817                                 _ => {},
1818                         }
1819                 }
1820
1821                 for htlc in self.holding_cell_htlc_updates.iter() {
1822                         match htlc {
1823                                 &HTLCUpdateAwaitingACK::AddHTLC { amount_msat, .. } => {
1824                                         if amount_msat / 1000 < real_dust_limit_timeout_sat {
1825                                                 continue
1826                                         }
1827                                         included_htlcs += 1
1828                                 },
1829                                 _ => {}, // Don't include claims/fails that are awaiting ack, because once we get the
1830                                          // ack we're guaranteed to never include them in commitment txs anymore.
1831                         }
1832                 }
1833
1834                 let num_htlcs = included_htlcs + addl_htlcs;
1835                 let res = self.commit_tx_fee_msat(num_htlcs);
1836                 #[cfg(any(test, feature = "fuzztarget"))]
1837                 {
1838                         let mut fee = res;
1839                         if fee_spike_buffer_htlc.is_some() {
1840                                 fee = self.commit_tx_fee_msat(num_htlcs - 1);
1841                         }
1842                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
1843                                 + self.holding_cell_htlc_updates.len();
1844                         let commitment_tx_info = CommitmentTxInfoCached {
1845                                 fee,
1846                                 total_pending_htlcs,
1847                                 next_holder_htlc_id: match htlc.origin {
1848                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
1849                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
1850                                 },
1851                                 next_counterparty_htlc_id: match htlc.origin {
1852                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
1853                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
1854                                 },
1855                                 feerate: self.feerate_per_kw,
1856                         };
1857                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
1858                 }
1859                 res
1860         }
1861
1862         // Get the commitment tx fee for the remote's next commitment transaction based on the number of
1863         // pending HTLCs that are on track to be in their next commitment tx, plus an additional HTLC if
1864         // `fee_spike_buffer_htlc` is Some, plus a new HTLC given by `new_htlc_amount`. Dust HTLCs are
1865         // excluded.
1866         fn next_remote_commit_tx_fee_msat(&self, htlc: HTLCCandidate, fee_spike_buffer_htlc: Option<()>) -> u64 {
1867                 assert!(!self.is_outbound());
1868
1869                 let real_dust_limit_success_sat = (self.feerate_per_kw as u64 * HTLC_SUCCESS_TX_WEIGHT / 1000) + self.counterparty_dust_limit_satoshis;
1870                 let real_dust_limit_timeout_sat = (self.feerate_per_kw as u64 * HTLC_TIMEOUT_TX_WEIGHT / 1000) + self.counterparty_dust_limit_satoshis;
1871
1872                 let mut addl_htlcs = 0;
1873                 if fee_spike_buffer_htlc.is_some() { addl_htlcs += 1; }
1874                 match htlc.origin {
1875                         HTLCInitiator::LocalOffered => {
1876                                 if htlc.amount_msat / 1000 >= real_dust_limit_success_sat {
1877                                         addl_htlcs += 1;
1878                                 }
1879                         },
1880                         HTLCInitiator::RemoteOffered => {
1881                                 if htlc.amount_msat / 1000 >= real_dust_limit_timeout_sat {
1882                                         addl_htlcs += 1;
1883                                 }
1884                         }
1885                 }
1886
1887                 // When calculating the set of HTLCs which will be included in their next commitment_signed, all
1888                 // non-dust inbound HTLCs are included (as all states imply it will be included) and only
1889                 // committed outbound HTLCs, see below.
1890                 let mut included_htlcs = 0;
1891                 for ref htlc in self.pending_inbound_htlcs.iter() {
1892                         if htlc.amount_msat / 1000 <= real_dust_limit_timeout_sat {
1893                                 continue
1894                         }
1895                         included_htlcs += 1;
1896                 }
1897
1898                 for ref htlc in self.pending_outbound_htlcs.iter() {
1899                         if htlc.amount_msat / 1000 <= real_dust_limit_success_sat {
1900                                 continue
1901                         }
1902                         // We only include outbound HTLCs if it will not be included in their next commitment_signed,
1903                         // i.e. if they've responded to us with an RAA after announcement.
1904                         match htlc.state {
1905                                 OutboundHTLCState::Committed => included_htlcs += 1,
1906                                 OutboundHTLCState::RemoteRemoved {..} => included_htlcs += 1,
1907                                 OutboundHTLCState::LocalAnnounced { .. } => included_htlcs += 1,
1908                                 _ => {},
1909                         }
1910                 }
1911
1912                 let num_htlcs = included_htlcs + addl_htlcs;
1913                 let res = self.commit_tx_fee_msat(num_htlcs);
1914                 #[cfg(any(test, feature = "fuzztarget"))]
1915                 {
1916                         let mut fee = res;
1917                         if fee_spike_buffer_htlc.is_some() {
1918                                 fee = self.commit_tx_fee_msat(num_htlcs - 1);
1919                         }
1920                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
1921                         let commitment_tx_info = CommitmentTxInfoCached {
1922                                 fee,
1923                                 total_pending_htlcs,
1924                                 next_holder_htlc_id: match htlc.origin {
1925                                         HTLCInitiator::LocalOffered => self.next_holder_htlc_id + 1,
1926                                         HTLCInitiator::RemoteOffered => self.next_holder_htlc_id,
1927                                 },
1928                                 next_counterparty_htlc_id: match htlc.origin {
1929                                         HTLCInitiator::LocalOffered => self.next_counterparty_htlc_id,
1930                                         HTLCInitiator::RemoteOffered => self.next_counterparty_htlc_id + 1,
1931                                 },
1932                                 feerate: self.feerate_per_kw,
1933                         };
1934                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = Some(commitment_tx_info);
1935                 }
1936                 res
1937         }
1938
1939         pub fn update_add_htlc<F, L: Deref>(&mut self, msg: &msgs::UpdateAddHTLC, mut pending_forward_status: PendingHTLCStatus, create_pending_htlc_status: F, logger: &L) -> Result<(), ChannelError>
1940         where F: for<'a> Fn(&'a Self, PendingHTLCStatus, u16) -> PendingHTLCStatus, L::Target: Logger {
1941                 // We can't accept HTLCs sent after we've sent a shutdown.
1942                 let local_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::LocalShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
1943                 if local_sent_shutdown {
1944                         pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|20);
1945                 }
1946                 // If the remote has sent a shutdown prior to adding this HTLC, then they are in violation of the spec.
1947                 let remote_sent_shutdown = (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32);
1948                 if remote_sent_shutdown {
1949                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state".to_owned()));
1950                 }
1951                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1952                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish".to_owned()));
1953                 }
1954                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1955                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel".to_owned()));
1956                 }
1957                 if msg.amount_msat == 0 {
1958                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC".to_owned()));
1959                 }
1960                 if msg.amount_msat < self.holder_htlc_minimum_msat {
1961                         return Err(ChannelError::Close(format!("Remote side tried to send less than our minimum HTLC value. Lower limit: ({}). Actual: ({})", self.holder_htlc_minimum_msat, msg.amount_msat)));
1962                 }
1963
1964                 let (inbound_htlc_count, htlc_inbound_value_msat) = self.get_inbound_pending_htlc_stats();
1965                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1966                         return Err(ChannelError::Close(format!("Remote tried to push more than our max accepted HTLCs ({})", OUR_MAX_HTLCS)));
1967                 }
1968                 let holder_max_htlc_value_in_flight_msat = Channel::<Signer>::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis);
1969                 if htlc_inbound_value_msat + msg.amount_msat > holder_max_htlc_value_in_flight_msat {
1970                         return Err(ChannelError::Close(format!("Remote HTLC add would put them over our max HTLC value ({})", holder_max_htlc_value_in_flight_msat)));
1971                 }
1972                 // Check holder_selected_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1973                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1974                 // something if we punish them for broadcasting an old state).
1975                 // Note that we don't really care about having a small/no to_remote output in our local
1976                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
1977                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
1978                 // present in the next commitment transaction we send them (at least for fulfilled ones,
1979                 // failed ones won't modify value_to_self).
1980                 // Note that we will send HTLCs which another instance of rust-lightning would think
1981                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
1982                 // Channel state once they will not be present in the next received commitment
1983                 // transaction).
1984                 let mut removed_outbound_total_msat = 0;
1985                 for ref htlc in self.pending_outbound_htlcs.iter() {
1986                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(None) = htlc.state {
1987                                 removed_outbound_total_msat += htlc.amount_msat;
1988                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) = htlc.state {
1989                                 removed_outbound_total_msat += htlc.amount_msat;
1990                         }
1991                 }
1992
1993                 let pending_value_to_self_msat =
1994                         self.value_to_self_msat + htlc_inbound_value_msat - removed_outbound_total_msat;
1995                 let pending_remote_value_msat =
1996                         self.channel_value_satoshis * 1000 - pending_value_to_self_msat;
1997                 if pending_remote_value_msat < msg.amount_msat {
1998                         return Err(ChannelError::Close("Remote HTLC add would overdraw remaining funds".to_owned()));
1999                 }
2000
2001                 // Check that the remote can afford to pay for this HTLC on-chain at the current
2002                 // feerate_per_kw, while maintaining their channel reserve (as required by the spec).
2003                 let remote_commit_tx_fee_msat = if self.is_outbound() { 0 } else {
2004                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2005                         self.next_remote_commit_tx_fee_msat(htlc_candidate, None) // Don't include the extra fee spike buffer HTLC in calculations
2006                 };
2007                 if pending_remote_value_msat - msg.amount_msat < remote_commit_tx_fee_msat {
2008                         return Err(ChannelError::Close("Remote HTLC add would not leave enough to pay for fees".to_owned()));
2009                 };
2010
2011                 let chan_reserve_msat =
2012                         Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis) * 1000;
2013                 if pending_remote_value_msat - msg.amount_msat - remote_commit_tx_fee_msat < chan_reserve_msat {
2014                         return Err(ChannelError::Close("Remote HTLC add would put them under remote reserve value".to_owned()));
2015                 }
2016
2017                 if !self.is_outbound() {
2018                         // `2 *` and `Some(())` is for the fee spike buffer we keep for the remote. This deviates from
2019                         // the spec because in the spec, the fee spike buffer requirement doesn't exist on the
2020                         // receiver's side, only on the sender's.
2021                         // Note that when we eventually remove support for fee updates and switch to anchor output
2022                         // fees, we will drop the `2 *`, since we no longer be as sensitive to fee spikes. But, keep
2023                         // the extra htlc when calculating the next remote commitment transaction fee as we should
2024                         // still be able to afford adding this HTLC plus one more future HTLC, regardless of being
2025                         // sensitive to fee spikes.
2026                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2027                         let remote_fee_cost_incl_stuck_buffer_msat = 2 * self.next_remote_commit_tx_fee_msat(htlc_candidate, Some(()));
2028                         if pending_remote_value_msat - msg.amount_msat - chan_reserve_msat < remote_fee_cost_incl_stuck_buffer_msat {
2029                                 // Note that if the pending_forward_status is not updated here, then it's because we're already failing
2030                                 // the HTLC, i.e. its status is already set to failing.
2031                                 log_info!(logger, "Attempting to fail HTLC due to fee spike buffer violation");
2032                                 pending_forward_status = create_pending_htlc_status(self, pending_forward_status, 0x1000|7);
2033                         }
2034                 } else {
2035                         // Check that they won't violate our local required channel reserve by adding this HTLC.
2036                         let htlc_candidate = HTLCCandidate::new(msg.amount_msat, HTLCInitiator::RemoteOffered);
2037                         let local_commit_tx_fee_msat = self.next_local_commit_tx_fee_msat(htlc_candidate, None);
2038                         if self.value_to_self_msat < self.counterparty_selected_channel_reserve_satoshis * 1000 + local_commit_tx_fee_msat {
2039                                 return Err(ChannelError::Close("Cannot accept HTLC that would put our balance under counterparty-announced channel reserve value".to_owned()));
2040                         }
2041                 }
2042                 if self.next_counterparty_htlc_id != msg.htlc_id {
2043                         return Err(ChannelError::Close(format!("Remote skipped HTLC ID (skipped ID: {})", self.next_counterparty_htlc_id)));
2044                 }
2045                 if msg.cltv_expiry >= 500000000 {
2046                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height".to_owned()));
2047                 }
2048
2049                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
2050                         if let PendingHTLCStatus::Forward(_) = pending_forward_status {
2051                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
2052                         }
2053                 }
2054
2055                 // Now update local state:
2056                 self.next_counterparty_htlc_id += 1;
2057                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
2058                         htlc_id: msg.htlc_id,
2059                         amount_msat: msg.amount_msat,
2060                         payment_hash: msg.payment_hash,
2061                         cltv_expiry: msg.cltv_expiry,
2062                         state: InboundHTLCState::RemoteAnnounced(pending_forward_status),
2063                 });
2064                 Ok(())
2065         }
2066
2067         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
2068         #[inline]
2069         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentHash>, fail_reason: Option<HTLCFailReason>) -> Result<&HTLCSource, ChannelError> {
2070                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2071                         if htlc.htlc_id == htlc_id {
2072                                 match check_preimage {
2073                                         None => {},
2074                                         Some(payment_hash) =>
2075                                                 if payment_hash != htlc.payment_hash {
2076                                                         return Err(ChannelError::Close(format!("Remote tried to fulfill HTLC ({}) with an incorrect preimage", htlc_id)));
2077                                                 }
2078                                 };
2079                                 match htlc.state {
2080                                         OutboundHTLCState::LocalAnnounced(_) =>
2081                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) before it had been committed", htlc_id))),
2082                                         OutboundHTLCState::Committed => {
2083                                                 htlc.state = OutboundHTLCState::RemoteRemoved(fail_reason);
2084                                         },
2085                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
2086                                                 return Err(ChannelError::Close(format!("Remote tried to fulfill/fail HTLC ({}) that they'd already fulfilled/failed", htlc_id))),
2087                                 }
2088                                 return Ok(&htlc.source);
2089                         }
2090                 }
2091                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find".to_owned()))
2092         }
2093
2094         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<HTLCSource, ChannelError> {
2095                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2096                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state".to_owned()));
2097                 }
2098                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2099                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish".to_owned()));
2100                 }
2101
2102                 let payment_hash = PaymentHash(Sha256::hash(&msg.payment_preimage.0[..]).into_inner());
2103                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None).map(|source| source.clone())
2104         }
2105
2106         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2107                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2108                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state".to_owned()));
2109                 }
2110                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2111                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish".to_owned()));
2112                 }
2113
2114                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2115                 Ok(())
2116         }
2117
2118         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
2119                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2120                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state".to_owned()));
2121                 }
2122                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2123                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish".to_owned()));
2124                 }
2125
2126                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
2127                 Ok(())
2128         }
2129
2130         pub fn commitment_signed<F: Deref, L: Deref>(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &F, logger: &L) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, Option<msgs::ClosingSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)>
2131         where F::Target: FeeEstimator,
2132                                 L::Target: Logger
2133         {
2134                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2135                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state".to_owned())));
2136                 }
2137                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2138                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish".to_owned())));
2139                 }
2140                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2141                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds".to_owned())));
2142                 }
2143
2144                 let funding_script = self.get_funding_redeemscript();
2145
2146                 let keys = self.build_holder_transaction_keys(self.cur_holder_commitment_transaction_number).map_err(|e| (None, e))?;
2147
2148                 let mut update_fee = false;
2149                 let feerate_per_kw = if !self.is_outbound() && self.pending_update_fee.is_some() {
2150                         update_fee = true;
2151                         self.pending_update_fee.unwrap()
2152                 } else {
2153                         self.feerate_per_kw
2154                 };
2155
2156                 let (num_htlcs, mut htlcs_cloned, commitment_tx, commitment_txid) = {
2157                         let commitment_tx = self.build_commitment_transaction(self.cur_holder_commitment_transaction_number, &keys, true, false, feerate_per_kw, logger);
2158                         let commitment_txid = {
2159                                 let trusted_tx = commitment_tx.0.trust();
2160                                 let bitcoin_tx = trusted_tx.built_transaction();
2161                                 let sighash = bitcoin_tx.get_sighash_all(&funding_script, self.channel_value_satoshis);
2162
2163                                 log_trace!(logger, "Checking commitment tx signature {} by key {} against tx {} (sighash {}) with redeemscript {}", log_bytes!(msg.signature.serialize_compact()[..]), log_bytes!(self.counterparty_funding_pubkey().serialize()), encode::serialize_hex(&bitcoin_tx.transaction), log_bytes!(sighash[..]), encode::serialize_hex(&funding_script));
2164                                 if let Err(_) = self.secp_ctx.verify(&sighash, &msg.signature, &self.counterparty_funding_pubkey()) {
2165                                         return Err((None, ChannelError::Close("Invalid commitment tx signature from peer".to_owned())));
2166                                 }
2167                                 bitcoin_tx.txid
2168                         };
2169                         let htlcs_cloned: Vec<_> = commitment_tx.2.iter().map(|htlc| (htlc.0.clone(), htlc.1.map(|h| h.clone()))).collect();
2170                         (commitment_tx.1, htlcs_cloned, commitment_tx.0, commitment_txid)
2171                 };
2172
2173                 let total_fee = feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
2174                 //If channel fee was updated by funder confirm funder can afford the new fee rate when applied to the current local commitment transaction
2175                 if update_fee {
2176                         let counterparty_reserve_we_require = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis);
2177                         if self.channel_value_satoshis - self.value_to_self_msat / 1000 < total_fee + counterparty_reserve_we_require {
2178                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee".to_owned())));
2179                         }
2180                 }
2181                 #[cfg(any(test, feature = "fuzztarget"))]
2182                 {
2183                         if self.is_outbound() {
2184                                 let projected_commit_tx_info = self.next_local_commitment_tx_fee_info_cached.lock().unwrap().take();
2185                                 *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2186                                 if let Some(info) = projected_commit_tx_info {
2187                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len()
2188                                                 + self.holding_cell_htlc_updates.len();
2189                                         if info.total_pending_htlcs == total_pending_htlcs
2190                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
2191                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
2192                                                 && info.feerate == self.feerate_per_kw {
2193                                                         assert_eq!(total_fee, info.fee / 1000);
2194                                                 }
2195                                 }
2196                         }
2197                 }
2198
2199                 if msg.htlc_signatures.len() != num_htlcs {
2200                         return Err((None, ChannelError::Close(format!("Got wrong number of HTLC signatures ({}) from remote. It must be {}", msg.htlc_signatures.len(), num_htlcs))));
2201                 }
2202
2203                 // TODO: Sadly, we pass HTLCs twice to ChannelMonitor: once via the HolderCommitmentTransaction and once via the update
2204                 let mut htlcs_and_sigs = Vec::with_capacity(htlcs_cloned.len());
2205                 for (idx, (htlc, source)) in htlcs_cloned.drain(..).enumerate() {
2206                         if let Some(_) = htlc.transaction_output_index {
2207                                 let htlc_tx = self.build_htlc_transaction(&commitment_txid, &htlc, true, &keys, feerate_per_kw);
2208                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
2209                                 let htlc_sighash = hash_to_message!(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, SigHashType::All)[..]);
2210                                 log_trace!(logger, "Checking HTLC tx signature {} by key {} against tx {} (sighash {}) with redeemscript {}", log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(keys.countersignatory_htlc_key.serialize()), encode::serialize_hex(&htlc_tx), log_bytes!(htlc_sighash[..]), encode::serialize_hex(&htlc_redeemscript));
2211                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &keys.countersignatory_htlc_key) {
2212                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer".to_owned())));
2213                                 }
2214                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
2215                         } else {
2216                                 htlcs_and_sigs.push((htlc, None, source));
2217                         }
2218                 }
2219
2220                 let holder_commitment_tx = HolderCommitmentTransaction::new(
2221                         commitment_tx,
2222                         msg.signature,
2223                         msg.htlc_signatures.clone(),
2224                         &self.get_holder_pubkeys().funding_pubkey,
2225                         self.counterparty_funding_pubkey()
2226                 );
2227
2228                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number - 1, &self.secp_ctx);
2229                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 1);
2230
2231                 // Update state now that we've passed all the can-fail calls...
2232                 let mut need_commitment = false;
2233                 if !self.is_outbound() {
2234                         if let Some(fee_update) = self.pending_update_fee {
2235                                 self.feerate_per_kw = fee_update;
2236                                 // We later use the presence of pending_update_fee to indicate we should generate a
2237                                 // commitment_signed upon receipt of revoke_and_ack, so we can only set it to None
2238                                 // if we're not awaiting a revoke (ie will send a commitment_signed now).
2239                                 if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) == 0 {
2240                                         need_commitment = true;
2241                                         self.pending_update_fee = None;
2242                                 }
2243                         }
2244                 }
2245
2246                 self.latest_monitor_update_id += 1;
2247                 let mut monitor_update = ChannelMonitorUpdate {
2248                         update_id: self.latest_monitor_update_id,
2249                         updates: vec![ChannelMonitorUpdateStep::LatestHolderCommitmentTXInfo {
2250                                 commitment_tx: holder_commitment_tx,
2251                                 htlc_outputs: htlcs_and_sigs
2252                         }]
2253                 };
2254
2255                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2256                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
2257                                 Some(forward_info.clone())
2258                         } else { None };
2259                         if let Some(forward_info) = new_forward {
2260                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
2261                                 need_commitment = true;
2262                         }
2263                 }
2264                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2265                         if let Some(fail_reason) = if let &mut OutboundHTLCState::RemoteRemoved(ref mut fail_reason) = &mut htlc.state {
2266                                 Some(fail_reason.take())
2267                         } else { None } {
2268                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(fail_reason);
2269                                 need_commitment = true;
2270                         }
2271                 }
2272
2273                 self.cur_holder_commitment_transaction_number -= 1;
2274                 // Note that if we need_commitment & !AwaitingRemoteRevoke we'll call
2275                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
2276                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
2277
2278                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
2279                         // In case we initially failed monitor updating without requiring a response, we need
2280                         // to make sure the RAA gets sent first.
2281                         self.monitor_pending_revoke_and_ack = true;
2282                         if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2283                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
2284                                 // the corresponding HTLC status updates so that get_last_commitment_update
2285                                 // includes the right HTLCs.
2286                                 self.monitor_pending_commitment_signed = true;
2287                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2288                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2289                                 // strictly increasing by one, so decrement it here.
2290                                 self.latest_monitor_update_id = monitor_update.update_id;
2291                                 monitor_update.updates.append(&mut additional_update.updates);
2292                         }
2293                         // TODO: Call maybe_propose_first_closing_signed on restoration (or call it here and
2294                         // re-send the message on restoration)
2295                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA".to_owned())));
2296                 }
2297
2298                 let (commitment_signed, closing_signed) = if need_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
2299                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
2300                         // we'll send one right away when we get the revoke_and_ack when we
2301                         // free_holding_cell_htlcs().
2302                         let (msg, mut additional_update) = self.send_commitment_no_status_check(logger).map_err(|e| (None, e))?;
2303                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2304                         // strictly increasing by one, so decrement it here.
2305                         self.latest_monitor_update_id = monitor_update.update_id;
2306                         monitor_update.updates.append(&mut additional_update.updates);
2307                         (Some(msg), None)
2308                 } else if !need_commitment {
2309                         (None, self.maybe_propose_first_closing_signed(fee_estimator))
2310                 } else { (None, None) };
2311
2312                 Ok((msgs::RevokeAndACK {
2313                         channel_id: self.channel_id,
2314                         per_commitment_secret,
2315                         next_per_commitment_point,
2316                 }, commitment_signed, closing_signed, monitor_update))
2317         }
2318
2319         /// Public version of the below, checking relevant preconditions first.
2320         /// If we're not in a state where freeing the holding cell makes sense, this is a no-op and
2321         /// returns `(None, Vec::new())`.
2322         pub fn maybe_free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2323                 if self.channel_state >= ChannelState::ChannelFunded as u32 &&
2324                    (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2325                         self.free_holding_cell_htlcs(logger)
2326                 } else { Ok((None, Vec::new())) }
2327         }
2328
2329         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
2330         /// fulfilling or failing the last pending HTLC)
2331         fn free_holding_cell_htlcs<L: Deref>(&mut self, logger: &L) -> Result<(Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>), ChannelError> where L::Target: Logger {
2332                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2333                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
2334                         log_trace!(logger, "Freeing holding cell with {} HTLC updates{}", self.holding_cell_htlc_updates.len(), if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" });
2335
2336                         let mut monitor_update = ChannelMonitorUpdate {
2337                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
2338                                 updates: Vec::new(),
2339                         };
2340
2341                         let mut htlc_updates = Vec::new();
2342                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
2343                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
2344                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
2345                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
2346                         let mut htlcs_to_fail = Vec::new();
2347                         for htlc_update in htlc_updates.drain(..) {
2348                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
2349                                 // fee races with adding too many outputs which push our total payments just over
2350                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
2351                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
2352                                 // to rebalance channels.
2353                                 match &htlc_update {
2354                                         &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
2355                                                 match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone()) {
2356                                                         Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
2357                                                         Err(e) => {
2358                                                                 match e {
2359                                                                         ChannelError::Ignore(ref msg) => {
2360                                                                                 log_info!(logger, "Failed to send HTLC with payment_hash {} due to {}", log_bytes!(payment_hash.0), msg);
2361                                                                                 // If we fail to send here, then this HTLC should
2362                                                                                 // be failed backwards. Failing to send here
2363                                                                                 // indicates that this HTLC may keep being put back
2364                                                                                 // into the holding cell without ever being
2365                                                                                 // successfully forwarded/failed/fulfilled, causing
2366                                                                                 // our counterparty to eventually close on us.
2367                                                                                 htlcs_to_fail.push((source.clone(), *payment_hash));
2368                                                                         },
2369                                                                         _ => {
2370                                                                                 panic!("Got a non-IgnoreError action trying to send holding cell HTLC");
2371                                                                         },
2372                                                                 }
2373                                                         }
2374                                                 }
2375                                         },
2376                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
2377                                                 match self.get_update_fulfill_htlc(htlc_id, *payment_preimage, logger) {
2378                                                         Ok((update_fulfill_msg_option, additional_monitor_update_opt)) => {
2379                                                                 update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
2380                                                                 if let Some(mut additional_monitor_update) = additional_monitor_update_opt {
2381                                                                         monitor_update.updates.append(&mut additional_monitor_update.updates);
2382                                                                 }
2383                                                         },
2384                                                         Err(e) => {
2385                                                                 if let ChannelError::Ignore(_) = e {}
2386                                                                 else {
2387                                                                         panic!("Got a non-IgnoreError action trying to fulfill holding cell HTLC");
2388                                                                 }
2389                                                         }
2390                                                 }
2391                                         },
2392                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2393                                                 match self.get_update_fail_htlc(htlc_id, err_packet.clone(), logger) {
2394                                                         Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
2395                                                         Err(e) => {
2396                                                                 if let ChannelError::Ignore(_) = e {}
2397                                                                 else {
2398                                                                         panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2399                                                                 }
2400                                                         }
2401                                                 }
2402                                         },
2403                                 }
2404                         }
2405                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2406                                 return Ok((None, htlcs_to_fail));
2407                         }
2408                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee {
2409                                 self.pending_update_fee = self.holding_cell_update_fee.take();
2410                                 Some(msgs::UpdateFee {
2411                                         channel_id: self.channel_id,
2412                                         feerate_per_kw: feerate as u32,
2413                                 })
2414                         } else {
2415                                 None
2416                         };
2417
2418                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2419                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2420                         // but we want them to be strictly increasing by one, so reset it here.
2421                         self.latest_monitor_update_id = monitor_update.update_id;
2422                         monitor_update.updates.append(&mut additional_update.updates);
2423
2424                         Ok((Some((msgs::CommitmentUpdate {
2425                                 update_add_htlcs,
2426                                 update_fulfill_htlcs,
2427                                 update_fail_htlcs,
2428                                 update_fail_malformed_htlcs: Vec::new(),
2429                                 update_fee,
2430                                 commitment_signed,
2431                         }, monitor_update)), htlcs_to_fail))
2432                 } else {
2433                         Ok((None, Vec::new()))
2434                 }
2435         }
2436
2437         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2438         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2439         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2440         /// generating an appropriate error *after* the channel state has been updated based on the
2441         /// revoke_and_ack message.
2442         pub fn revoke_and_ack<F: Deref, L: Deref>(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &F, logger: &L) -> Result<(Option<msgs::CommitmentUpdate>, Vec<(PendingHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option<msgs::ClosingSigned>, ChannelMonitorUpdate, Vec<(HTLCSource, PaymentHash)>), ChannelError>
2443                 where F::Target: FeeEstimator,
2444                                         L::Target: Logger,
2445         {
2446                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2447                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state".to_owned()));
2448                 }
2449                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2450                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish".to_owned()));
2451                 }
2452                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2453                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_owned()));
2454                 }
2455
2456                 if let Some(counterparty_prev_commitment_point) = self.counterparty_prev_commitment_point {
2457                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret".to_owned())) != counterparty_prev_commitment_point {
2458                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey".to_owned()));
2459                         }
2460                 }
2461
2462                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
2463                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
2464                         // haven't given them a new commitment transaction to broadcast). We should probably
2465                         // take advantage of this by updating our channel monitor, sending them an error, and
2466                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
2467                         // lot of work, and there's some chance this is all a misunderstanding anyway.
2468                         // We have to do *something*, though, since our signer may get mad at us for otherwise
2469                         // jumping a remote commitment number, so best to just force-close and move on.
2470                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack".to_owned()));
2471                 }
2472
2473                 #[cfg(any(test, feature = "fuzztarget"))]
2474                 {
2475                         *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
2476                         *self.next_remote_commitment_tx_fee_info_cached.lock().unwrap() = None;
2477                 }
2478
2479                 self.commitment_secrets.provide_secret(self.cur_counterparty_commitment_transaction_number + 1, msg.per_commitment_secret)
2480                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one".to_owned()))?;
2481                 self.latest_monitor_update_id += 1;
2482                 let mut monitor_update = ChannelMonitorUpdate {
2483                         update_id: self.latest_monitor_update_id,
2484                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
2485                                 idx: self.cur_counterparty_commitment_transaction_number + 1,
2486                                 secret: msg.per_commitment_secret,
2487                         }],
2488                 };
2489
2490                 // Update state now that we've passed all the can-fail calls...
2491                 // (note that we may still fail to generate the new commitment_signed message, but that's
2492                 // OK, we step the channel here and *then* if the new generation fails we can fail the
2493                 // channel based on that, but stepping stuff here should be safe either way.
2494                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
2495                 self.counterparty_prev_commitment_point = self.counterparty_cur_commitment_point;
2496                 self.counterparty_cur_commitment_point = Some(msg.next_per_commitment_point);
2497                 self.cur_counterparty_commitment_transaction_number -= 1;
2498
2499                 log_trace!(logger, "Updating HTLCs on receipt of RAA...");
2500                 let mut to_forward_infos = Vec::new();
2501                 let mut revoked_htlcs = Vec::new();
2502                 let mut update_fail_htlcs = Vec::new();
2503                 let mut update_fail_malformed_htlcs = Vec::new();
2504                 let mut require_commitment = false;
2505                 let mut value_to_self_msat_diff: i64 = 0;
2506
2507                 {
2508                         // Take references explicitly so that we can hold multiple references to self.
2509                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
2510                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
2511
2512                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
2513                         pending_inbound_htlcs.retain(|htlc| {
2514                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2515                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
2516                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
2517                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
2518                                         }
2519                                         false
2520                                 } else { true }
2521                         });
2522                         pending_outbound_htlcs.retain(|htlc| {
2523                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) = &htlc.state {
2524                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
2525                                         if let Some(reason) = fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
2526                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
2527                                         } else {
2528                                                 // They fulfilled, so we sent them money
2529                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
2530                                         }
2531                                         false
2532                                 } else { true }
2533                         });
2534                         for htlc in pending_inbound_htlcs.iter_mut() {
2535                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
2536                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to Committed", log_bytes!(htlc.payment_hash.0));
2537                                         true
2538                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
2539                                         log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
2540                                         true
2541                                 } else { false };
2542                                 if swap {
2543                                         let mut state = InboundHTLCState::Committed;
2544                                         mem::swap(&mut state, &mut htlc.state);
2545
2546                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
2547                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
2548                                                 require_commitment = true;
2549                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
2550                                                 match forward_info {
2551                                                         PendingHTLCStatus::Fail(fail_msg) => {
2552                                                                 require_commitment = true;
2553                                                                 match fail_msg {
2554                                                                         HTLCFailureMsg::Relay(msg) => {
2555                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
2556                                                                                 update_fail_htlcs.push(msg)
2557                                                                         },
2558                                                                         HTLCFailureMsg::Malformed(msg) => {
2559                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
2560                                                                                 update_fail_malformed_htlcs.push(msg)
2561                                                                         },
2562                                                                 }
2563                                                         },
2564                                                         PendingHTLCStatus::Forward(forward_info) => {
2565                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
2566                                                                 htlc.state = InboundHTLCState::Committed;
2567                                                         }
2568                                                 }
2569                                         }
2570                                 }
2571                         }
2572                         for htlc in pending_outbound_htlcs.iter_mut() {
2573                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
2574                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
2575                                         htlc.state = OutboundHTLCState::Committed;
2576                                 }
2577                                 if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
2578                                         Some(fail_reason.take())
2579                                 } else { None } {
2580                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
2581                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
2582                                         require_commitment = true;
2583                                 }
2584                         }
2585                 }
2586                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
2587
2588                 if self.is_outbound() {
2589                         if let Some(feerate) = self.pending_update_fee.take() {
2590                                 self.feerate_per_kw = feerate;
2591                         }
2592                 } else {
2593                         if let Some(feerate) = self.pending_update_fee {
2594                                 // Because a node cannot send two commitment_signeds in a row without getting a
2595                                 // revoke_and_ack from us (as it would otherwise not know the per_commitment_point
2596                                 // it should use to create keys with) and because a node can't send a
2597                                 // commitment_signed without changes, checking if the feerate is equal to the
2598                                 // pending feerate update is sufficient to detect require_commitment.
2599                                 if feerate == self.feerate_per_kw {
2600                                         require_commitment = true;
2601                                         self.pending_update_fee = None;
2602                                 }
2603                         }
2604                 }
2605
2606                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
2607                         // We can't actually generate a new commitment transaction (incl by freeing holding
2608                         // cells) while we can't update the monitor, so we just return what we have.
2609                         if require_commitment {
2610                                 self.monitor_pending_commitment_signed = true;
2611                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
2612                                 // which does not update state, but we're definitely now awaiting a remote revoke
2613                                 // before we can step forward any more, so set it here.
2614                                 let (_, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2615                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2616                                 // strictly increasing by one, so decrement it here.
2617                                 self.latest_monitor_update_id = monitor_update.update_id;
2618                                 monitor_update.updates.append(&mut additional_update.updates);
2619                         }
2620                         self.monitor_pending_forwards.append(&mut to_forward_infos);
2621                         self.monitor_pending_failures.append(&mut revoked_htlcs);
2622                         return Ok((None, Vec::new(), Vec::new(), None, monitor_update, Vec::new()))
2623                 }
2624
2625                 match self.free_holding_cell_htlcs(logger)? {
2626                         (Some((mut commitment_update, mut additional_update)), htlcs_to_fail) => {
2627                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
2628                                 for fail_msg in update_fail_htlcs.drain(..) {
2629                                         commitment_update.update_fail_htlcs.push(fail_msg);
2630                                 }
2631                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
2632                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
2633                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
2634                                 }
2635
2636                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
2637                                 // strictly increasing by one, so decrement it here.
2638                                 self.latest_monitor_update_id = monitor_update.update_id;
2639                                 monitor_update.updates.append(&mut additional_update.updates);
2640
2641                                 Ok((Some(commitment_update), to_forward_infos, revoked_htlcs, None, monitor_update, htlcs_to_fail))
2642                         },
2643                         (None, htlcs_to_fail) => {
2644                                 if require_commitment {
2645                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check(logger)?;
2646
2647                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2648                                         // strictly increasing by one, so decrement it here.
2649                                         self.latest_monitor_update_id = monitor_update.update_id;
2650                                         monitor_update.updates.append(&mut additional_update.updates);
2651
2652                                         Ok((Some(msgs::CommitmentUpdate {
2653                                                 update_add_htlcs: Vec::new(),
2654                                                 update_fulfill_htlcs: Vec::new(),
2655                                                 update_fail_htlcs,
2656                                                 update_fail_malformed_htlcs,
2657                                                 update_fee: None,
2658                                                 commitment_signed
2659                                         }), to_forward_infos, revoked_htlcs, None, monitor_update, htlcs_to_fail))
2660                                 } else {
2661                                         Ok((None, to_forward_infos, revoked_htlcs, self.maybe_propose_first_closing_signed(fee_estimator), monitor_update, htlcs_to_fail))
2662                                 }
2663                         }
2664                 }
2665
2666         }
2667
2668         /// Adds a pending update to this channel. See the doc for send_htlc for
2669         /// further details on the optionness of the return value.
2670         /// You MUST call send_commitment prior to any other calls on this Channel
2671         fn send_update_fee(&mut self, feerate_per_kw: u32) -> Option<msgs::UpdateFee> {
2672                 if !self.is_outbound() {
2673                         panic!("Cannot send fee from inbound channel");
2674                 }
2675                 if !self.is_usable() {
2676                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
2677                 }
2678                 if !self.is_live() {
2679                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
2680                 }
2681
2682                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2683                         self.holding_cell_update_fee = Some(feerate_per_kw);
2684                         return None;
2685                 }
2686
2687                 debug_assert!(self.pending_update_fee.is_none());
2688                 self.pending_update_fee = Some(feerate_per_kw);
2689
2690                 Some(msgs::UpdateFee {
2691                         channel_id: self.channel_id,
2692                         feerate_per_kw,
2693                 })
2694         }
2695
2696         pub fn send_update_fee_and_commit<L: Deref>(&mut self, feerate_per_kw: u32, logger: &L) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
2697                 match self.send_update_fee(feerate_per_kw) {
2698                         Some(update_fee) => {
2699                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
2700                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
2701                         },
2702                         None => Ok(None)
2703                 }
2704         }
2705
2706         /// Removes any uncommitted inbound HTLCs and resets the state of uncommitted outbound HTLC
2707         /// updates, to be used on peer disconnection. After this, update_*_htlc messages need to be
2708         /// resent.
2709         /// No further message handling calls may be made until a channel_reestablish dance has
2710         /// completed.
2711         pub fn remove_uncommitted_htlcs_and_mark_paused<L: Deref>(&mut self, logger: &L)  where L::Target: Logger {
2712                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2713                 if self.channel_state < ChannelState::FundingSent as u32 {
2714                         self.channel_state = ChannelState::ShutdownComplete as u32;
2715                         return;
2716                 }
2717                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
2718                 // will be retransmitted.
2719                 self.last_sent_closing_fee = None;
2720
2721                 let mut inbound_drop_count = 0;
2722                 self.pending_inbound_htlcs.retain(|htlc| {
2723                         match htlc.state {
2724                                 InboundHTLCState::RemoteAnnounced(_) => {
2725                                         // They sent us an update_add_htlc but we never got the commitment_signed.
2726                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
2727                                         // this HTLC accordingly
2728                                         inbound_drop_count += 1;
2729                                         false
2730                                 },
2731                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
2732                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
2733                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
2734                                         // in response to it yet, so don't touch it.
2735                                         true
2736                                 },
2737                                 InboundHTLCState::Committed => true,
2738                                 InboundHTLCState::LocalRemoved(_) => {
2739                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
2740                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
2741                                         // (that we missed). Keep this around for now and if they tell us they missed
2742                                         // the commitment_signed we can re-transmit the update then.
2743                                         true
2744                                 },
2745                         }
2746                 });
2747                 self.next_counterparty_htlc_id -= inbound_drop_count;
2748
2749                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2750                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
2751                                 // They sent us an update to remove this but haven't yet sent the corresponding
2752                                 // commitment_signed, we need to move it back to Committed and they can re-send
2753                                 // the update upon reconnection.
2754                                 htlc.state = OutboundHTLCState::Committed;
2755                         }
2756                 }
2757
2758                 self.channel_state |= ChannelState::PeerDisconnected as u32;
2759                 log_debug!(logger, "Peer disconnection resulted in {} remote-announced HTLC drops on channel {}", inbound_drop_count, log_bytes!(self.channel_id()));
2760         }
2761
2762         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
2763         /// updates are partially paused.
2764         /// This must be called immediately after the call which generated the ChannelMonitor update
2765         /// which failed. The messages which were generated from that call which generated the
2766         /// monitor update failure must *not* have been sent to the remote end, and must instead
2767         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
2768         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool, mut pending_forwards: Vec<(PendingHTLCInfo, u64)>, mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>) {
2769                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2770                 self.monitor_pending_revoke_and_ack = resend_raa;
2771                 self.monitor_pending_commitment_signed = resend_commitment;
2772                 assert!(self.monitor_pending_forwards.is_empty());
2773                 mem::swap(&mut pending_forwards, &mut self.monitor_pending_forwards);
2774                 assert!(self.monitor_pending_failures.is_empty());
2775                 mem::swap(&mut pending_fails, &mut self.monitor_pending_failures);
2776                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
2777         }
2778
2779         /// Indicates that the latest ChannelMonitor update has been committed by the client
2780         /// successfully and we should restore normal operation. Returns messages which should be sent
2781         /// to the remote side.
2782         pub fn monitor_updating_restored<L: Deref>(&mut self, logger: &L) -> (Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, RAACommitmentOrder, Vec<(PendingHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option<Transaction>, Option<msgs::FundingLocked>) where L::Target: Logger {
2783                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
2784                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
2785
2786                 let funding_broadcastable = if self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.is_outbound() {
2787                         self.funding_transaction.take()
2788                 } else { None };
2789
2790                 // We will never broadcast the funding transaction when we're in MonitorUpdateFailed (and
2791                 // we assume the user never directly broadcasts the funding transaction and waits for us to
2792                 // do it). Thus, we can only ever hit monitor_pending_funding_locked when we're an inbound
2793                 // channel which failed to persist the monitor on funding_created, and we got the funding
2794                 // transaction confirmed before the monitor was persisted.
2795                 let funding_locked = if self.monitor_pending_funding_locked {
2796                         assert!(!self.is_outbound(), "Funding transaction broadcast by the local client before it should have - LDK didn't do it!");
2797                         self.monitor_pending_funding_locked = false;
2798                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
2799                         Some(msgs::FundingLocked {
2800                                 channel_id: self.channel_id(),
2801                                 next_per_commitment_point,
2802                         })
2803                 } else { None };
2804
2805                 let mut forwards = Vec::new();
2806                 mem::swap(&mut forwards, &mut self.monitor_pending_forwards);
2807                 let mut failures = Vec::new();
2808                 mem::swap(&mut failures, &mut self.monitor_pending_failures);
2809
2810                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
2811                         self.monitor_pending_revoke_and_ack = false;
2812                         self.monitor_pending_commitment_signed = false;
2813                         return (None, None, RAACommitmentOrder::RevokeAndACKFirst, forwards, failures, funding_broadcastable, funding_locked);
2814                 }
2815
2816                 let raa = if self.monitor_pending_revoke_and_ack {
2817                         Some(self.get_last_revoke_and_ack())
2818                 } else { None };
2819                 let commitment_update = if self.monitor_pending_commitment_signed {
2820                         Some(self.get_last_commitment_update(logger))
2821                 } else { None };
2822
2823                 self.monitor_pending_revoke_and_ack = false;
2824                 self.monitor_pending_commitment_signed = false;
2825                 let order = self.resend_order.clone();
2826                 log_trace!(logger, "Restored monitor updating resulting in {}{} commitment update and {} RAA, with {} first",
2827                         if funding_broadcastable.is_some() { "a funding broadcastable, " } else { "" },
2828                         if commitment_update.is_some() { "a" } else { "no" },
2829                         if raa.is_some() { "an" } else { "no" },
2830                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
2831                 (raa, commitment_update, order, forwards, failures, funding_broadcastable, funding_locked)
2832         }
2833
2834         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
2835                 where F::Target: FeeEstimator
2836         {
2837                 if self.is_outbound() {
2838                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee".to_owned()));
2839                 }
2840                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2841                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish".to_owned()));
2842                 }
2843                 Channel::<Signer>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
2844                 self.pending_update_fee = Some(msg.feerate_per_kw);
2845                 self.update_time_counter += 1;
2846                 Ok(())
2847         }
2848
2849         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
2850                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
2851                 let per_commitment_secret = self.holder_signer.release_commitment_secret(self.cur_holder_commitment_transaction_number + 2);
2852                 msgs::RevokeAndACK {
2853                         channel_id: self.channel_id,
2854                         per_commitment_secret,
2855                         next_per_commitment_point,
2856                 }
2857         }
2858
2859         fn get_last_commitment_update<L: Deref>(&self, logger: &L) -> msgs::CommitmentUpdate where L::Target: Logger {
2860                 let mut update_add_htlcs = Vec::new();
2861                 let mut update_fulfill_htlcs = Vec::new();
2862                 let mut update_fail_htlcs = Vec::new();
2863                 let mut update_fail_malformed_htlcs = Vec::new();
2864
2865                 for htlc in self.pending_outbound_htlcs.iter() {
2866                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
2867                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
2868                                         channel_id: self.channel_id(),
2869                                         htlc_id: htlc.htlc_id,
2870                                         amount_msat: htlc.amount_msat,
2871                                         payment_hash: htlc.payment_hash,
2872                                         cltv_expiry: htlc.cltv_expiry,
2873                                         onion_routing_packet: (**onion_packet).clone(),
2874                                 });
2875                         }
2876                 }
2877
2878                 for htlc in self.pending_inbound_htlcs.iter() {
2879                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2880                                 match reason {
2881                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
2882                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
2883                                                         channel_id: self.channel_id(),
2884                                                         htlc_id: htlc.htlc_id,
2885                                                         reason: err_packet.clone()
2886                                                 });
2887                                         },
2888                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
2889                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
2890                                                         channel_id: self.channel_id(),
2891                                                         htlc_id: htlc.htlc_id,
2892                                                         sha256_of_onion: sha256_of_onion.clone(),
2893                                                         failure_code: failure_code.clone(),
2894                                                 });
2895                                         },
2896                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
2897                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
2898                                                         channel_id: self.channel_id(),
2899                                                         htlc_id: htlc.htlc_id,
2900                                                         payment_preimage: payment_preimage.clone(),
2901                                                 });
2902                                         },
2903                                 }
2904                         }
2905                 }
2906
2907                 log_trace!(logger, "Regenerated latest commitment update with {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
2908                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
2909                 msgs::CommitmentUpdate {
2910                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2911                         update_fee: None,
2912                         commitment_signed: self.send_commitment_no_state_update(logger).expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
2913                 }
2914         }
2915
2916         /// May panic if some calls other than message-handling calls (which will all Err immediately)
2917         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
2918         pub fn channel_reestablish<L: Deref>(&mut self, msg: &msgs::ChannelReestablish, logger: &L) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitorUpdate>, RAACommitmentOrder, Vec<(HTLCSource, PaymentHash)>, Option<msgs::Shutdown>), ChannelError> where L::Target: Logger {
2919                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
2920                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
2921                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
2922                         // just close here instead of trying to recover.
2923                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect".to_owned()));
2924                 }
2925
2926                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
2927                         msg.next_local_commitment_number == 0 {
2928                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish".to_owned()));
2929                 }
2930
2931                 if msg.next_remote_commitment_number > 0 {
2932                         match msg.data_loss_protect {
2933                                 OptionalField::Present(ref data_loss) => {
2934                                         let expected_point = self.holder_signer.get_per_commitment_point(INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1, &self.secp_ctx);
2935                                         let given_secret = SecretKey::from_slice(&data_loss.your_last_per_commitment_secret)
2936                                                 .map_err(|_| ChannelError::Close("Peer sent a garbage channel_reestablish with unparseable secret key".to_owned()))?;
2937                                         if expected_point != PublicKey::from_secret_key(&self.secp_ctx, &given_secret) {
2938                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided".to_owned()));
2939                                         }
2940                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
2941                                                 return Err(ChannelError::CloseDelayBroadcast(
2942                                                         "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting".to_owned()
2943                                                 ));
2944                                         }
2945                                 },
2946                                 OptionalField::Absent => {}
2947                         }
2948                 }
2949
2950                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
2951                 // remaining cases either succeed or ErrorMessage-fail).
2952                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
2953
2954                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
2955                         Some(msgs::Shutdown {
2956                                 channel_id: self.channel_id,
2957                                 scriptpubkey: self.get_closing_scriptpubkey(),
2958                         })
2959                 } else { None };
2960
2961                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
2962                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
2963                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
2964                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2965                                 if msg.next_remote_commitment_number != 0 {
2966                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet".to_owned()));
2967                                 }
2968                                 // Short circuit the whole handler as there is nothing we can resend them
2969                                 return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, Vec::new(), shutdown_msg));
2970                         }
2971
2972                         // We have OurFundingLocked set!
2973                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
2974                         return Ok((Some(msgs::FundingLocked {
2975                                 channel_id: self.channel_id(),
2976                                 next_per_commitment_point,
2977                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, Vec::new(), shutdown_msg));
2978                 }
2979
2980                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number {
2981                         // Remote isn't waiting on any RevokeAndACK from us!
2982                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
2983                         None
2984                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_holder_commitment_transaction_number {
2985                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2986                                 self.monitor_pending_revoke_and_ack = true;
2987                                 None
2988                         } else {
2989                                 Some(self.get_last_revoke_and_ack())
2990                         }
2991                 } else {
2992                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction".to_owned()));
2993                 };
2994
2995                 // We increment cur_counterparty_commitment_transaction_number only upon receipt of
2996                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
2997                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
2998                 // the corresponding revoke_and_ack back yet.
2999                 let next_counterparty_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
3000
3001                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number == 1 {
3002                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
3003                         let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3004                         Some(msgs::FundingLocked {
3005                                 channel_id: self.channel_id(),
3006                                 next_per_commitment_point,
3007                         })
3008                 } else { None };
3009
3010                 if msg.next_local_commitment_number == next_counterparty_commitment_number {
3011                         if required_revoke.is_some() {
3012                                 log_debug!(logger, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
3013                         } else {
3014                                 log_debug!(logger, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
3015                         }
3016
3017                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
3018                                 // We're up-to-date and not waiting on a remote revoke (if we are our
3019                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
3020                                 // have received some updates while we were disconnected. Free the holding cell
3021                                 // now!
3022                                 match self.free_holding_cell_htlcs(logger) {
3023                                         Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)),
3024                                         Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast(_)) => panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
3025                                         Ok((Some((commitment_update, monitor_update)), htlcs_to_fail)) => {
3026                                                 return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(monitor_update), self.resend_order.clone(), htlcs_to_fail, shutdown_msg));
3027                                         },
3028                                         Ok((None, htlcs_to_fail)) => {
3029                                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), htlcs_to_fail, shutdown_msg));
3030                                         },
3031                                 }
3032                         } else {
3033                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3034                         }
3035                 } else if msg.next_local_commitment_number == next_counterparty_commitment_number - 1 {
3036                         if required_revoke.is_some() {
3037                                 log_debug!(logger, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
3038                         } else {
3039                                 log_debug!(logger, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
3040                         }
3041
3042                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
3043                                 self.monitor_pending_commitment_signed = true;
3044                                 return Ok((resend_funding_locked, None, None, None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3045                         }
3046
3047                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update(logger)), None, self.resend_order.clone(), Vec::new(), shutdown_msg));
3048                 } else {
3049                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction".to_owned()));
3050                 }
3051         }
3052
3053         fn maybe_propose_first_closing_signed<F: Deref>(&mut self, fee_estimator: &F) -> Option<msgs::ClosingSigned>
3054                 where F::Target: FeeEstimator
3055         {
3056                 if !self.is_outbound() || !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() ||
3057                                 self.channel_state & (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32) != BOTH_SIDES_SHUTDOWN_MASK ||
3058                                 self.last_sent_closing_fee.is_some() || self.pending_update_fee.is_some() {
3059                         return None;
3060                 }
3061
3062                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3063                 if self.feerate_per_kw > proposed_feerate {
3064                         proposed_feerate = self.feerate_per_kw;
3065                 }
3066                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3067                 let proposed_total_fee_satoshis = proposed_feerate as u64 * tx_weight / 1000;
3068
3069                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
3070                 let sig = self.holder_signer
3071                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3072                         .ok();
3073                 assert!(closing_tx.get_weight() as u64 <= tx_weight);
3074                 if sig.is_none() { return None; }
3075
3076                 self.last_sent_closing_fee = Some((proposed_feerate, total_fee_satoshis, sig.clone().unwrap()));
3077                 Some(msgs::ClosingSigned {
3078                         channel_id: self.channel_id,
3079                         fee_satoshis: total_fee_satoshis,
3080                         signature: sig.unwrap(),
3081                 })
3082         }
3083
3084         pub fn shutdown<F: Deref>(&mut self, fee_estimator: &F, their_features: &InitFeatures, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
3085                 where F::Target: FeeEstimator
3086         {
3087                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3088                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish".to_owned()));
3089                 }
3090                 if self.channel_state < ChannelState::FundingSent as u32 {
3091                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
3092                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
3093                         // can do that via error message without getting a connection fail anyway...
3094                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation".to_owned()));
3095                 }
3096                 for htlc in self.pending_inbound_htlcs.iter() {
3097                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3098                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs".to_owned()));
3099                         }
3100                 }
3101                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3102
3103                 if is_unsupported_shutdown_script(&their_features, &msg.scriptpubkey) {
3104                         return Err(ChannelError::Close(format!("Got a nonstandard scriptpubkey ({}) from remote peer", msg.scriptpubkey.to_bytes().to_hex())));
3105                 }
3106
3107                 if self.counterparty_shutdown_scriptpubkey.is_some() {
3108                         if Some(&msg.scriptpubkey) != self.counterparty_shutdown_scriptpubkey.as_ref() {
3109                                 return Err(ChannelError::Close(format!("Got shutdown request with a scriptpubkey ({}) which did not match their previous scriptpubkey.", msg.scriptpubkey.to_bytes().to_hex())));
3110                         }
3111                 } else {
3112                         self.counterparty_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
3113                 }
3114
3115                 // From here on out, we may not fail!
3116
3117                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
3118                 self.update_time_counter += 1;
3119
3120                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
3121                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
3122                 // cell HTLCs and return them to fail the payment.
3123                 self.holding_cell_update_fee = None;
3124                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3125                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3126                         match htlc_update {
3127                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3128                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3129                                         false
3130                                 },
3131                                 _ => true
3132                         }
3133                 });
3134                 // If we have any LocalAnnounced updates we'll probably just get back a update_fail_htlc
3135                 // immediately after the commitment dance, but we can send a Shutdown cause we won't send
3136                 // any further commitment updates after we set LocalShutdownSent.
3137
3138                 let shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
3139                         None
3140                 } else {
3141                         Some(msgs::Shutdown {
3142                                 channel_id: self.channel_id,
3143                                 scriptpubkey: self.get_closing_scriptpubkey(),
3144                         })
3145                 };
3146
3147                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
3148                 self.update_time_counter += 1;
3149
3150                 Ok((shutdown, self.maybe_propose_first_closing_signed(fee_estimator), dropped_outbound_htlcs))
3151         }
3152
3153         fn build_signed_closing_transaction(&self, tx: &mut Transaction, counterparty_sig: &Signature, sig: &Signature) {
3154                 if tx.input.len() != 1 { panic!("Tried to sign closing transaction that had input count != 1!"); }
3155                 if tx.input[0].witness.len() != 0 { panic!("Tried to re-sign closing transaction"); }
3156                 if tx.output.len() > 2 { panic!("Tried to sign bogus closing transaction"); }
3157
3158                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
3159
3160                 let funding_key = self.get_holder_pubkeys().funding_pubkey.serialize();
3161                 let counterparty_funding_key = self.counterparty_funding_pubkey().serialize();
3162                 if funding_key[..] < counterparty_funding_key[..] {
3163                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3164                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3165                 } else {
3166                         tx.input[0].witness.push(counterparty_sig.serialize_der().to_vec());
3167                         tx.input[0].witness.push(sig.serialize_der().to_vec());
3168                 }
3169                 tx.input[0].witness[1].push(SigHashType::All as u8);
3170                 tx.input[0].witness[2].push(SigHashType::All as u8);
3171
3172                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
3173         }
3174
3175         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
3176                 where F::Target: FeeEstimator
3177         {
3178                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
3179                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown".to_owned()));
3180                 }
3181                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
3182                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish".to_owned()));
3183                 }
3184                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
3185                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs".to_owned()));
3186                 }
3187                 if msg.fee_satoshis > 21_000_000 * 1_0000_0000 { //this is required to stop potential overflow in build_closing_transaction
3188                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee".to_owned()));
3189                 }
3190
3191                 let funding_redeemscript = self.get_funding_redeemscript();
3192                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
3193                 if used_total_fee != msg.fee_satoshis {
3194                         return Err(ChannelError::Close(format!("Remote sent us a closing_signed with a fee greater than the value they can claim. Fee in message: {}", msg.fee_satoshis)));
3195                 }
3196                 let mut sighash = hash_to_message!(&bip143::SigHashCache::new(&closing_tx).signature_hash(0, &funding_redeemscript, self.channel_value_satoshis, SigHashType::All)[..]);
3197
3198                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.get_counterparty_pubkeys().funding_pubkey) {
3199                         Ok(_) => {},
3200                         Err(_e) => {
3201                                 // The remote end may have decided to revoke their output due to inconsistent dust
3202                                 // limits, so check for that case by re-checking the signature here.
3203                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
3204                                 sighash = hash_to_message!(&bip143::SigHashCache::new(&closing_tx).signature_hash(0, &funding_redeemscript, self.channel_value_satoshis, SigHashType::All)[..]);
3205                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.counterparty_funding_pubkey()), "Invalid closing tx signature from peer".to_owned());
3206                         },
3207                 };
3208
3209                 let closing_tx_max_weight = self.get_closing_transaction_weight(
3210                         if let Some(oup) = closing_tx.output.get(0) { Some(&oup.script_pubkey) } else { None },
3211                         if let Some(oup) = closing_tx.output.get(1) { Some(&oup.script_pubkey) } else { None });
3212                 if let Some((_, last_fee, sig)) = self.last_sent_closing_fee {
3213                         if last_fee == msg.fee_satoshis {
3214                                 self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
3215                                 assert!(closing_tx.get_weight() as u64 <= closing_tx_max_weight);
3216                                 debug_assert!(closing_tx.get_weight() as u64 >= closing_tx_max_weight - 2);
3217                                 self.channel_state = ChannelState::ShutdownComplete as u32;
3218                                 self.update_time_counter += 1;
3219                                 return Ok((None, Some(closing_tx)));
3220                         }
3221                 }
3222
3223                 macro_rules! propose_new_feerate {
3224                         ($new_feerate: expr) => {
3225                                 let tx_weight = self.get_closing_transaction_weight(Some(&self.get_closing_scriptpubkey()), Some(self.counterparty_shutdown_scriptpubkey.as_ref().unwrap()));
3226                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate as u64 * tx_weight / 1000, false);
3227                                 let sig = self.holder_signer
3228                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3229                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
3230                                 assert!(closing_tx.get_weight() as u64 <= tx_weight);
3231                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee, sig.clone()));
3232                                 return Ok((Some(msgs::ClosingSigned {
3233                                         channel_id: self.channel_id,
3234                                         fee_satoshis: used_total_fee,
3235                                         signature: sig,
3236                                 }), None))
3237                         }
3238                 }
3239
3240                 let mut min_feerate = 253;
3241                 if self.is_outbound() {
3242                         let max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
3243                         if (msg.fee_satoshis as u64) > max_feerate as u64 * closing_tx_max_weight / 1000 {
3244                                 if let Some((last_feerate, _, _)) = self.last_sent_closing_fee {
3245                                         if max_feerate <= last_feerate {
3246                                                 return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wanted something higher ({}) than our Normal feerate ({})", last_feerate, max_feerate)));
3247                                         }
3248                                 }
3249                                 propose_new_feerate!(max_feerate);
3250                         }
3251                 } else {
3252                         min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
3253                 }
3254                 if (msg.fee_satoshis as u64) < min_feerate as u64 * closing_tx_max_weight / 1000 {
3255                         if let Some((last_feerate, _, _)) = self.last_sent_closing_fee {
3256                                 if min_feerate >= last_feerate {
3257                                         return Err(ChannelError::Close(format!("Unable to come to consensus about closing feerate, remote wanted something lower ({}) than our Background feerate ({}).", last_feerate, min_feerate)));
3258                                 }
3259                         }
3260                         propose_new_feerate!(min_feerate);
3261                 }
3262
3263                 let sig = self.holder_signer
3264                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
3265                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction".to_owned()))?;
3266                 self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &sig);
3267                 assert!(closing_tx.get_weight() as u64 <= closing_tx_max_weight);
3268                 debug_assert!(closing_tx.get_weight() as u64 >= closing_tx_max_weight - 2);
3269
3270                 self.channel_state = ChannelState::ShutdownComplete as u32;
3271                 self.update_time_counter += 1;
3272
3273                 Ok((Some(msgs::ClosingSigned {
3274                         channel_id: self.channel_id,
3275                         fee_satoshis: msg.fee_satoshis,
3276                         signature: sig,
3277                 }), Some(closing_tx)))
3278         }
3279
3280         // Public utilities:
3281
3282         pub fn channel_id(&self) -> [u8; 32] {
3283                 self.channel_id
3284         }
3285
3286         /// Gets the "user_id" value passed into the construction of this channel. It has no special
3287         /// meaning and exists only to allow users to have a persistent identifier of a channel.
3288         pub fn get_user_id(&self) -> u64 {
3289                 self.user_id
3290         }
3291
3292         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
3293         /// is_usable() returns true).
3294         /// Allowed in any state (including after shutdown)
3295         pub fn get_short_channel_id(&self) -> Option<u64> {
3296                 self.short_channel_id
3297         }
3298
3299         /// Returns the funding_txo we either got from our peer, or were given by
3300         /// get_outbound_funding_created.
3301         pub fn get_funding_txo(&self) -> Option<OutPoint> {
3302                 self.channel_transaction_parameters.funding_outpoint
3303         }
3304
3305         fn get_holder_selected_contest_delay(&self) -> u16 {
3306                 self.channel_transaction_parameters.holder_selected_contest_delay
3307         }
3308
3309         fn get_holder_pubkeys(&self) -> &ChannelPublicKeys {
3310                 &self.channel_transaction_parameters.holder_pubkeys
3311         }
3312
3313         fn get_counterparty_selected_contest_delay(&self) -> u16 {
3314                 self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().selected_contest_delay
3315         }
3316
3317         fn get_counterparty_pubkeys(&self) -> &ChannelPublicKeys {
3318                 &self.channel_transaction_parameters.counterparty_parameters.as_ref().unwrap().pubkeys
3319         }
3320
3321         /// Allowed in any state (including after shutdown)
3322         pub fn get_counterparty_node_id(&self) -> PublicKey {
3323                 self.counterparty_node_id
3324         }
3325
3326         /// Allowed in any state (including after shutdown)
3327         #[cfg(test)]
3328         pub fn get_holder_htlc_minimum_msat(&self) -> u64 {
3329                 self.holder_htlc_minimum_msat
3330         }
3331
3332         /// Allowed in any state (including after shutdown)
3333         pub fn get_announced_htlc_max_msat(&self) -> u64 {
3334                 return cmp::min(
3335                         // Upper bound by capacity. We make it a bit less than full capacity to prevent attempts
3336                         // to use full capacity. This is an effort to reduce routing failures, because in many cases
3337                         // channel might have been used to route very small values (either by honest users or as DoS).
3338                         self.channel_value_satoshis * 1000 * 9 / 10,
3339
3340                         Channel::<Signer>::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis)
3341                 );
3342         }
3343
3344         /// Allowed in any state (including after shutdown)
3345         pub fn get_counterparty_htlc_minimum_msat(&self) -> u64 {
3346                 self.counterparty_htlc_minimum_msat
3347         }
3348
3349         pub fn get_value_satoshis(&self) -> u64 {
3350                 self.channel_value_satoshis
3351         }
3352
3353         pub fn get_fee_proportional_millionths(&self) -> u32 {
3354                 self.config.fee_proportional_millionths
3355         }
3356
3357         pub fn get_cltv_expiry_delta(&self) -> u16 {
3358                 cmp::max(self.config.cltv_expiry_delta, MIN_CLTV_EXPIRY_DELTA)
3359         }
3360
3361         #[cfg(test)]
3362         pub fn get_feerate(&self) -> u32 {
3363                 self.feerate_per_kw
3364         }
3365
3366         pub fn get_cur_holder_commitment_transaction_number(&self) -> u64 {
3367                 self.cur_holder_commitment_transaction_number + 1
3368         }
3369
3370         pub fn get_cur_counterparty_commitment_transaction_number(&self) -> u64 {
3371                 self.cur_counterparty_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
3372         }
3373
3374         pub fn get_revoked_counterparty_commitment_transaction_number(&self) -> u64 {
3375                 self.cur_counterparty_commitment_transaction_number + 2
3376         }
3377
3378         #[cfg(test)]
3379         pub fn get_signer(&self) -> &Signer {
3380                 &self.holder_signer
3381         }
3382
3383         #[cfg(test)]
3384         pub fn get_value_stat(&self) -> ChannelValueStat {
3385                 ChannelValueStat {
3386                         value_to_self_msat: self.value_to_self_msat,
3387                         channel_value_msat: self.channel_value_satoshis * 1000,
3388                         channel_reserve_msat: self.counterparty_selected_channel_reserve_satoshis * 1000,
3389                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
3390                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
3391                         holding_cell_outbound_amount_msat: {
3392                                 let mut res = 0;
3393                                 for h in self.holding_cell_htlc_updates.iter() {
3394                                         match h {
3395                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
3396                                                         res += amount_msat;
3397                                                 }
3398                                                 _ => {}
3399                                         }
3400                                 }
3401                                 res
3402                         },
3403                         counterparty_max_htlc_value_in_flight_msat: self.counterparty_max_htlc_value_in_flight_msat,
3404                         counterparty_dust_limit_msat: self.counterparty_dust_limit_satoshis * 1000,
3405                 }
3406         }
3407
3408         /// Allowed in any state (including after shutdown)
3409         pub fn get_update_time_counter(&self) -> u32 {
3410                 self.update_time_counter
3411         }
3412
3413         pub fn get_latest_monitor_update_id(&self) -> u64 {
3414                 self.latest_monitor_update_id
3415         }
3416
3417         pub fn should_announce(&self) -> bool {
3418                 self.config.announced_channel
3419         }
3420
3421         pub fn is_outbound(&self) -> bool {
3422                 self.channel_transaction_parameters.is_outbound_from_holder
3423         }
3424
3425         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
3426         /// Allowed in any state (including after shutdown)
3427         pub fn get_holder_fee_base_msat<F: Deref>(&self, fee_estimator: &F) -> u32
3428                 where F::Target: FeeEstimator
3429         {
3430                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
3431                 // output value back into a transaction with the regular channel output:
3432
3433                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
3434                 let mut res = self.feerate_per_kw as u64 * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
3435
3436                 if self.is_outbound() {
3437                         // + the marginal fee increase cost to us in the commitment transaction:
3438                         res += self.feerate_per_kw as u64 * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
3439                 }
3440
3441                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
3442                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) as u64 * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
3443
3444                 res as u32
3445         }
3446
3447         /// Returns true if we've ever received a message from the remote end for this Channel
3448         pub fn have_received_message(&self) -> bool {
3449                 self.channel_state > (ChannelState::OurInitSent as u32)
3450         }
3451
3452         /// Returns true if this channel is fully established and not known to be closing.
3453         /// Allowed in any state (including after shutdown)
3454         pub fn is_usable(&self) -> bool {
3455                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
3456                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
3457         }
3458
3459         /// Returns true if this channel is currently available for use. This is a superset of
3460         /// is_usable() and considers things like the channel being temporarily disabled.
3461         /// Allowed in any state (including after shutdown)
3462         pub fn is_live(&self) -> bool {
3463                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32) == 0)
3464         }
3465
3466         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
3467         /// Allowed in any state (including after shutdown)
3468         pub fn is_awaiting_monitor_update(&self) -> bool {
3469                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
3470         }
3471
3472         /// Returns true if funding_created was sent/received.
3473         pub fn is_funding_initiated(&self) -> bool {
3474                 self.channel_state >= ChannelState::FundingSent as u32
3475         }
3476
3477         /// Returns true if this channel is fully shut down. True here implies that no further actions
3478         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
3479         /// will be handled appropriately by the chain monitor.
3480         pub fn is_shutdown(&self) -> bool {
3481                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
3482                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
3483                         true
3484                 } else { false }
3485         }
3486
3487         pub fn channel_update_status(&self) -> ChannelUpdateStatus {
3488                 self.channel_update_status
3489         }
3490
3491         pub fn set_channel_update_status(&mut self, status: ChannelUpdateStatus) {
3492                 self.channel_update_status = status;
3493         }
3494
3495         fn check_get_funding_locked(&mut self, height: u32) -> Option<msgs::FundingLocked> {
3496                 if self.funding_tx_confirmation_height == 0 {
3497                         return None;
3498                 }
3499
3500                 let funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
3501                 if funding_tx_confirmations <= 0 {
3502                         self.funding_tx_confirmation_height = 0;
3503                 }
3504
3505                 if funding_tx_confirmations < self.minimum_depth as i64 {
3506                         return None;
3507                 }
3508
3509                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
3510                 let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
3511                         self.channel_state |= ChannelState::OurFundingLocked as u32;
3512                         true
3513                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
3514                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
3515                         self.update_time_counter += 1;
3516                         true
3517                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
3518                         // We got a reorg but not enough to trigger a force close, just ignore.
3519                         false
3520                 } else if self.channel_state < ChannelState::ChannelFunded as u32 {
3521                         panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
3522                 } else {
3523                         // We got a reorg but not enough to trigger a force close, just ignore.
3524                         false
3525                 };
3526
3527                 if need_commitment_update {
3528                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
3529                                 let next_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3530                                 return Some(msgs::FundingLocked {
3531                                         channel_id: self.channel_id,
3532                                         next_per_commitment_point,
3533                                 });
3534                         } else {
3535                                 self.monitor_pending_funding_locked = true;
3536                         }
3537                 }
3538                 None
3539         }
3540
3541         /// When a transaction is confirmed, we check whether it is or spends the funding transaction
3542         /// In the first case, we store the confirmation height and calculating the short channel id.
3543         /// In the second, we simply return an Err indicating we need to be force-closed now.
3544         pub fn transactions_confirmed<L: Deref>(&mut self, block_hash: &BlockHash, height: u32, txdata: &TransactionData, logger: &L)
3545                         -> Result<Option<msgs::FundingLocked>, msgs::ErrorMessage> where L::Target: Logger {
3546                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
3547                 for &(index_in_block, tx) in txdata.iter() {
3548                         if let Some(funding_txo) = self.get_funding_txo() {
3549                                 // If we haven't yet sent a funding_locked, but are in FundingSent (ignoring
3550                                 // whether they've sent a funding_locked or not), check if we should send one.
3551                                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
3552                                         if tx.txid() == funding_txo.txid {
3553                                                 let txo_idx = funding_txo.index as usize;
3554                                                 if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
3555                                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
3556                                                         if self.is_outbound() {
3557                                                                 // If we generated the funding transaction and it doesn't match what it
3558                                                                 // should, the client is really broken and we should just panic and
3559                                                                 // tell them off. That said, because hash collisions happen with high
3560                                                                 // probability in fuzztarget mode, if we're fuzzing we just close the
3561                                                                 // channel and move on.
3562                                                                 #[cfg(not(feature = "fuzztarget"))]
3563                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3564                                                         }
3565                                                         self.update_time_counter += 1;
3566                                                         return Err(msgs::ErrorMessage {
3567                                                                 channel_id: self.channel_id(),
3568                                                                 data: "funding tx had wrong script/value or output index".to_owned()
3569                                                         });
3570                                                 } else {
3571                                                         if self.is_outbound() {
3572                                                                 for input in tx.input.iter() {
3573                                                                         if input.witness.is_empty() {
3574                                                                                 // We generated a malleable funding transaction, implying we've
3575                                                                                 // just exposed ourselves to funds loss to our counterparty.
3576                                                                                 #[cfg(not(feature = "fuzztarget"))]
3577                                                                                 panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3578                                                                         }
3579                                                                 }
3580                                                         }
3581                                                         self.funding_tx_confirmation_height = height;
3582                                                         self.funding_tx_confirmed_in = Some(*block_hash);
3583                                                         self.short_channel_id = match scid_from_parts(height as u64, index_in_block as u64, txo_idx as u64) {
3584                                                                 Ok(scid) => Some(scid),
3585                                                                 Err(_) => panic!("Block was bogus - either height was > 16 million, had > 16 million transactions, or had > 65k outputs"),
3586                                                         }
3587                                                 }
3588                                         }
3589                                         // If we allow 1-conf funding, we may need to check for funding_locked here and
3590                                         // send it immediately instead of waiting for a best_block_updated call (which
3591                                         // may have already happened for this block).
3592                                         if let Some(funding_locked) = self.check_get_funding_locked(height) {
3593                                                 return Ok(Some(funding_locked));
3594                                         }
3595                                 }
3596                                 for inp in tx.input.iter() {
3597                                         if inp.previous_output == funding_txo.into_bitcoin_outpoint() {
3598                                                 log_trace!(logger, "Detected channel-closing tx {} spending {}:{}, closing channel {}", tx.txid(), inp.previous_output.txid, inp.previous_output.vout, log_bytes!(self.channel_id()));
3599                                                 return Err(msgs::ErrorMessage {
3600                                                         channel_id: self.channel_id(),
3601                                                         data: "Commitment or closing transaction was confirmed on chain.".to_owned()
3602                                                 });
3603                                         }
3604                                 }
3605                         }
3606                 }
3607                 Ok(None)
3608         }
3609
3610         /// When a new block is connected, we check the height of the block against outbound holding
3611         /// cell HTLCs in case we need to give up on them prematurely and time them out. Everything
3612         /// else (e.g. commitment transaction broadcasts, HTLC transaction broadcasting, etc) is
3613         /// handled by the ChannelMonitor.
3614         ///
3615         /// If we return Err, the channel may have been closed, at which point the standard
3616         /// requirements apply - no calls may be made except those explicitly stated to be allowed
3617         /// post-shutdown.
3618         ///
3619         /// May return some HTLCs (and their payment_hash) which have timed out and should be failed
3620         /// back.
3621         pub fn best_block_updated(&mut self, height: u32, highest_header_time: u32) -> Result<(Option<msgs::FundingLocked>, Vec<(HTLCSource, PaymentHash)>), msgs::ErrorMessage> {
3622                 let mut timed_out_htlcs = Vec::new();
3623                 let unforwarded_htlc_cltv_limit = height + HTLC_FAIL_BACK_BUFFER;
3624                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3625                         match htlc_update {
3626                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, ref cltv_expiry, .. } => {
3627                                         if *cltv_expiry <= unforwarded_htlc_cltv_limit {
3628                                                 timed_out_htlcs.push((source.clone(), payment_hash.clone()));
3629                                                 false
3630                                         } else { true }
3631                                 },
3632                                 _ => true
3633                         }
3634                 });
3635
3636                 self.update_time_counter = cmp::max(self.update_time_counter, highest_header_time);
3637
3638                 if let Some(funding_locked) = self.check_get_funding_locked(height) {
3639                         return Ok((Some(funding_locked), timed_out_htlcs));
3640                 }
3641
3642                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
3643                 if non_shutdown_state >= ChannelState::ChannelFunded as u32 ||
3644                    (non_shutdown_state & ChannelState::OurFundingLocked as u32) == ChannelState::OurFundingLocked as u32 {
3645                         let mut funding_tx_confirmations = height as i64 - self.funding_tx_confirmation_height as i64 + 1;
3646                         if self.funding_tx_confirmation_height == 0 {
3647                                 // Note that check_get_funding_locked may reset funding_tx_confirmation_height to
3648                                 // zero if it has been reorged out, however in either case, our state flags
3649                                 // indicate we've already sent a funding_locked
3650                                 funding_tx_confirmations = 0;
3651                         }
3652
3653                         // If we've sent funding_locked (or have both sent and received funding_locked), and
3654                         // the funding transaction's confirmation count has dipped below minimum_depth / 2,
3655                         // close the channel and hope we can get the latest state on chain (because presumably
3656                         // the funding transaction is at least still in the mempool of most nodes).
3657                         if funding_tx_confirmations < self.minimum_depth as i64 / 2 {
3658                                 return Err(msgs::ErrorMessage {
3659                                         channel_id: self.channel_id(),
3660                                         data: format!("Funding transaction was un-confirmed. Locked at {} confs, now have {} confs.", self.minimum_depth, funding_tx_confirmations),
3661                                 });
3662                         }
3663                 }
3664
3665                 Ok((None, timed_out_htlcs))
3666         }
3667
3668         /// Indicates the funding transaction is no longer confirmed in the main chain. This may
3669         /// force-close the channel, but may also indicate a harmless reorganization of a block or two
3670         /// before the channel has reached funding_locked and we can just wait for more blocks.
3671         pub fn funding_transaction_unconfirmed(&mut self) -> Result<(), msgs::ErrorMessage> {
3672                 if self.funding_tx_confirmation_height != 0 {
3673                         // We handle the funding disconnection by calling best_block_updated with a height one
3674                         // below where our funding was connected, implying a reorg back to conf_height - 1.
3675                         let reorg_height = self.funding_tx_confirmation_height - 1;
3676                         // We use the time field to bump the current time we set on channel updates if its
3677                         // larger. If we don't know that time has moved forward, we can just set it to the last
3678                         // time we saw and it will be ignored.
3679                         let best_time = self.update_time_counter;
3680                         match self.best_block_updated(reorg_height, best_time) {
3681                                 Ok((funding_locked, timed_out_htlcs)) => {
3682                                         assert!(funding_locked.is_none(), "We can't generate a funding with 0 confirmations?");
3683                                         assert!(timed_out_htlcs.is_empty(), "We can't have accepted HTLCs with a timeout before our funding confirmation?");
3684                                         Ok(())
3685                                 },
3686                                 Err(e) => Err(e)
3687                         }
3688                 } else {
3689                         // We never learned about the funding confirmation anyway, just ignore
3690                         Ok(())
3691                 }
3692         }
3693
3694         // Methods to get unprompted messages to send to the remote end (or where we already returned
3695         // something in the handler for the message that prompted this message):
3696
3697         pub fn get_open_channel(&self, chain_hash: BlockHash) -> msgs::OpenChannel {
3698                 if !self.is_outbound() {
3699                         panic!("Tried to open a channel for an inbound channel?");
3700                 }
3701                 if self.channel_state != ChannelState::OurInitSent as u32 {
3702                         panic!("Cannot generate an open_channel after we've moved forward");
3703                 }
3704
3705                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3706                         panic!("Tried to send an open_channel for a channel that has already advanced");
3707                 }
3708
3709                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3710                 let keys = self.get_holder_pubkeys();
3711
3712                 msgs::OpenChannel {
3713                         chain_hash,
3714                         temporary_channel_id: self.channel_id,
3715                         funding_satoshis: self.channel_value_satoshis,
3716                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
3717                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
3718                         max_htlc_value_in_flight_msat: Channel::<Signer>::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3719                         channel_reserve_satoshis: Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis),
3720                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
3721                         feerate_per_kw: self.feerate_per_kw as u32,
3722                         to_self_delay: self.get_holder_selected_contest_delay(),
3723                         max_accepted_htlcs: OUR_MAX_HTLCS,
3724                         funding_pubkey: keys.funding_pubkey,
3725                         revocation_basepoint: keys.revocation_basepoint,
3726                         payment_point: keys.payment_point,
3727                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
3728                         htlc_basepoint: keys.htlc_basepoint,
3729                         first_per_commitment_point,
3730                         channel_flags: if self.config.announced_channel {1} else {0},
3731                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3732                 }
3733         }
3734
3735         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
3736                 if self.is_outbound() {
3737                         panic!("Tried to send accept_channel for an outbound channel?");
3738                 }
3739                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
3740                         panic!("Tried to send accept_channel after channel had moved forward");
3741                 }
3742                 if self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3743                         panic!("Tried to send an accept_channel for a channel that has already advanced");
3744                 }
3745
3746                 let first_per_commitment_point = self.holder_signer.get_per_commitment_point(self.cur_holder_commitment_transaction_number, &self.secp_ctx);
3747                 let keys = self.get_holder_pubkeys();
3748
3749                 msgs::AcceptChannel {
3750                         temporary_channel_id: self.channel_id,
3751                         dust_limit_satoshis: self.holder_dust_limit_satoshis,
3752                         max_htlc_value_in_flight_msat: Channel::<Signer>::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3753                         channel_reserve_satoshis: Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis),
3754                         htlc_minimum_msat: self.holder_htlc_minimum_msat,
3755                         minimum_depth: self.minimum_depth,
3756                         to_self_delay: self.get_holder_selected_contest_delay(),
3757                         max_accepted_htlcs: OUR_MAX_HTLCS,
3758                         funding_pubkey: keys.funding_pubkey,
3759                         revocation_basepoint: keys.revocation_basepoint,
3760                         payment_point: keys.payment_point,
3761                         delayed_payment_basepoint: keys.delayed_payment_basepoint,
3762                         htlc_basepoint: keys.htlc_basepoint,
3763                         first_per_commitment_point,
3764                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3765                 }
3766         }
3767
3768         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
3769         fn get_outbound_funding_created_signature<L: Deref>(&mut self, logger: &L) -> Result<Signature, ChannelError> where L::Target: Logger {
3770                 let counterparty_keys = self.build_remote_transaction_keys()?;
3771                 let counterparty_initial_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, false, self.feerate_per_kw, logger).0;
3772                 Ok(self.holder_signer.sign_counterparty_commitment(&counterparty_initial_commitment_tx, &self.secp_ctx)
3773                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?.0)
3774         }
3775
3776         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
3777         /// a funding_created message for the remote peer.
3778         /// Panics if called at some time other than immediately after initial handshake, if called twice,
3779         /// or if called on an inbound channel.
3780         /// Note that channel_id changes during this call!
3781         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
3782         /// If an Err is returned, it is a ChannelError::Close.
3783         pub fn get_outbound_funding_created<L: Deref>(&mut self, funding_transaction: Transaction, funding_txo: OutPoint, logger: &L) -> Result<msgs::FundingCreated, ChannelError> where L::Target: Logger {
3784                 if !self.is_outbound() {
3785                         panic!("Tried to create outbound funding_created message on an inbound channel!");
3786                 }
3787                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
3788                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
3789                 }
3790                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
3791                                 self.cur_counterparty_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
3792                                 self.cur_holder_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3793                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
3794                 }
3795
3796                 self.channel_transaction_parameters.funding_outpoint = Some(funding_txo);
3797                 self.holder_signer.ready_channel(&self.channel_transaction_parameters);
3798
3799                 let signature = match self.get_outbound_funding_created_signature(logger) {
3800                         Ok(res) => res,
3801                         Err(e) => {
3802                                 log_error!(logger, "Got bad signatures: {:?}!", e);
3803                                 self.channel_transaction_parameters.funding_outpoint = None;
3804                                 return Err(e);
3805                         }
3806                 };
3807
3808                 let temporary_channel_id = self.channel_id;
3809
3810                 // Now that we're past error-generating stuff, update our local state:
3811
3812                 self.channel_state = ChannelState::FundingCreated as u32;
3813                 self.channel_id = funding_txo.to_channel_id();
3814                 self.funding_transaction = Some(funding_transaction);
3815
3816                 Ok(msgs::FundingCreated {
3817                         temporary_channel_id,
3818                         funding_txid: funding_txo.txid,
3819                         funding_output_index: funding_txo.index,
3820                         signature
3821                 })
3822         }
3823
3824         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
3825         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
3826         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
3827         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
3828         /// Will only fail if we're not in a state where channel_announcement may be sent (including
3829         /// closing).
3830         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
3831         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
3832         ///
3833         /// This will only return ChannelError::Ignore upon failure.
3834         pub fn get_channel_announcement(&self, node_id: PublicKey, chain_hash: BlockHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
3835                 if !self.config.announced_channel {
3836                         return Err(ChannelError::Ignore("Channel is not available for public announcements".to_owned()));
3837                 }
3838                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
3839                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked".to_owned()));
3840                 }
3841                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
3842                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing".to_owned()));
3843                 }
3844
3845                 let were_node_one = node_id.serialize()[..] < self.counterparty_node_id.serialize()[..];
3846
3847                 let msg = msgs::UnsignedChannelAnnouncement {
3848                         features: ChannelFeatures::known(),
3849                         chain_hash,
3850                         short_channel_id: self.get_short_channel_id().unwrap(),
3851                         node_id_1: if were_node_one { node_id } else { self.get_counterparty_node_id() },
3852                         node_id_2: if were_node_one { self.get_counterparty_node_id() } else { node_id },
3853                         bitcoin_key_1: if were_node_one { self.get_holder_pubkeys().funding_pubkey } else { self.counterparty_funding_pubkey().clone() },
3854                         bitcoin_key_2: if were_node_one { self.counterparty_funding_pubkey().clone() } else { self.get_holder_pubkeys().funding_pubkey },
3855                         excess_data: Vec::new(),
3856                 };
3857
3858                 let sig = self.holder_signer.sign_channel_announcement(&msg, &self.secp_ctx)
3859                         .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement".to_owned()))?;
3860
3861                 Ok((msg, sig))
3862         }
3863
3864         /// Signs the given channel announcement, returning a ChannelError::Ignore if no keys are
3865         /// available.
3866         fn sign_channel_announcement(&self, our_node_secret: &SecretKey, our_node_id: PublicKey, msghash: secp256k1::Message, announcement: msgs::UnsignedChannelAnnouncement, our_bitcoin_sig: Signature) -> Result<msgs::ChannelAnnouncement, ChannelError> {
3867                 if let Some((their_node_sig, their_bitcoin_sig)) = self.announcement_sigs {
3868                         let were_node_one = announcement.node_id_1 == our_node_id;
3869
3870                         let our_node_sig = self.secp_ctx.sign(&msghash, our_node_secret);
3871                         Ok(msgs::ChannelAnnouncement {
3872                                 node_signature_1: if were_node_one { our_node_sig } else { their_node_sig },
3873                                 node_signature_2: if were_node_one { their_node_sig } else { our_node_sig },
3874                                 bitcoin_signature_1: if were_node_one { our_bitcoin_sig } else { their_bitcoin_sig },
3875                                 bitcoin_signature_2: if were_node_one { their_bitcoin_sig } else { our_bitcoin_sig },
3876                                 contents: announcement,
3877                         })
3878                 } else {
3879                         Err(ChannelError::Ignore("Attempted to sign channel announcement before we'd received announcement_signatures".to_string()))
3880                 }
3881         }
3882
3883         /// Processes an incoming announcement_signatures message, providing a fully-signed
3884         /// channel_announcement message which we can broadcast and storing our counterparty's
3885         /// signatures for later reconstruction/rebroadcast of the channel_announcement.
3886         pub fn announcement_signatures(&mut self, our_node_secret: &SecretKey, our_node_id: PublicKey, chain_hash: BlockHash, msg: &msgs::AnnouncementSignatures) -> Result<msgs::ChannelAnnouncement, ChannelError> {
3887                 let (announcement, our_bitcoin_sig) = self.get_channel_announcement(our_node_id.clone(), chain_hash)?;
3888
3889                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
3890
3891                 if self.secp_ctx.verify(&msghash, &msg.node_signature, &self.get_counterparty_node_id()).is_err() {
3892                         return Err(ChannelError::Close(format!(
3893                                 "Bad announcement_signatures. Failed to verify node_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_node_key is {:?}",
3894                                  &announcement, self.get_counterparty_node_id())));
3895                 }
3896                 if self.secp_ctx.verify(&msghash, &msg.bitcoin_signature, self.counterparty_funding_pubkey()).is_err() {
3897                         return Err(ChannelError::Close(format!(
3898                                 "Bad announcement_signatures. Failed to verify bitcoin_signature. UnsignedChannelAnnouncement used for verification is {:?}. their_bitcoin_key is ({:?})",
3899                                 &announcement, self.counterparty_funding_pubkey())));
3900                 }
3901
3902                 self.announcement_sigs = Some((msg.node_signature, msg.bitcoin_signature));
3903
3904                 self.sign_channel_announcement(our_node_secret, our_node_id, msghash, announcement, our_bitcoin_sig)
3905         }
3906
3907         /// Gets a signed channel_announcement for this channel, if we previously received an
3908         /// announcement_signatures from our counterparty.
3909         pub fn get_signed_channel_announcement(&self, our_node_secret: &SecretKey, our_node_id: PublicKey, chain_hash: BlockHash) -> Option<msgs::ChannelAnnouncement> {
3910                 let (announcement, our_bitcoin_sig) = match self.get_channel_announcement(our_node_id.clone(), chain_hash) {
3911                         Ok(res) => res,
3912                         Err(_) => return None,
3913                 };
3914                 let msghash = hash_to_message!(&Sha256d::hash(&announcement.encode()[..])[..]);
3915                 match self.sign_channel_announcement(our_node_secret, our_node_id, msghash, announcement, our_bitcoin_sig) {
3916                         Ok(res) => Some(res),
3917                         Err(_) => None,
3918                 }
3919         }
3920
3921         /// May panic if called on a channel that wasn't immediately-previously
3922         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
3923         pub fn get_channel_reestablish<L: Deref>(&self, logger: &L) -> msgs::ChannelReestablish where L::Target: Logger {
3924                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
3925                 assert_ne!(self.cur_counterparty_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
3926                 // Prior to static_remotekey, my_current_per_commitment_point was critical to claiming
3927                 // current to_remote balances. However, it no longer has any use, and thus is now simply
3928                 // set to a dummy (but valid, as required by the spec) public key.
3929                 // fuzztarget mode marks a subset of pubkeys as invalid so that we can hit "invalid pubkey"
3930                 // branches, but we unwrap it below, so we arbitrarily select a dummy pubkey which is both
3931                 // valid, and valid in fuzztarget mode's arbitrary validity criteria:
3932                 let mut pk = [2; 33]; pk[1] = 0xff;
3933                 let dummy_pubkey = PublicKey::from_slice(&pk).unwrap();
3934                 let data_loss_protect = if self.cur_counterparty_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
3935                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_counterparty_commitment_transaction_number + 2).unwrap();
3936                         log_trace!(logger, "Enough info to generate a Data Loss Protect with per_commitment_secret {}", log_bytes!(remote_last_secret));
3937                         OptionalField::Present(DataLossProtect {
3938                                 your_last_per_commitment_secret: remote_last_secret,
3939                                 my_current_per_commitment_point: dummy_pubkey
3940                         })
3941                 } else {
3942                         log_info!(logger, "Sending a data_loss_protect with no previous remote per_commitment_secret");
3943                         OptionalField::Present(DataLossProtect {
3944                                 your_last_per_commitment_secret: [0;32],
3945                                 my_current_per_commitment_point: dummy_pubkey,
3946                         })
3947                 };
3948                 msgs::ChannelReestablish {
3949                         channel_id: self.channel_id(),
3950                         // The protocol has two different commitment number concepts - the "commitment
3951                         // transaction number", which starts from 0 and counts up, and the "revocation key
3952                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
3953                         // commitment transaction numbers by the index which will be used to reveal the
3954                         // revocation key for that commitment transaction, which means we have to convert them
3955                         // to protocol-level commitment numbers here...
3956
3957                         // next_local_commitment_number is the next commitment_signed number we expect to
3958                         // receive (indicating if they need to resend one that we missed).
3959                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_holder_commitment_transaction_number,
3960                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
3961                         // receive, however we track it by the next commitment number for a remote transaction
3962                         // (which is one further, as they always revoke previous commitment transaction, not
3963                         // the one we send) so we have to decrement by 1. Note that if
3964                         // cur_counterparty_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
3965                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
3966                         // overflow here.
3967                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_counterparty_commitment_transaction_number - 1,
3968                         data_loss_protect,
3969                 }
3970         }
3971
3972
3973         // Send stuff to our remote peers:
3974
3975         /// Adds a pending outbound HTLC to this channel, note that you probably want
3976         /// send_htlc_and_commit instead cause you'll want both messages at once.
3977         ///
3978         /// This returns an optional UpdateAddHTLC as we may be in a state where we cannot add HTLCs on
3979         /// the wire:
3980         /// * In cases where we're waiting on the remote peer to send us a revoke_and_ack, we
3981         ///   wouldn't be able to determine what they actually ACK'ed if we have two sets of updates
3982         ///   awaiting ACK.
3983         /// * In cases where we're marked MonitorUpdateFailed, we cannot commit to a new state as we
3984         ///   may not yet have sent the previous commitment update messages and will need to regenerate
3985         ///   them.
3986         ///
3987         /// You MUST call send_commitment prior to calling any other methods on this Channel!
3988         ///
3989         /// If an Err is returned, it's a ChannelError::Ignore!
3990         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> {
3991                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
3992                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
3993                 }
3994                 let channel_total_msat = self.channel_value_satoshis * 1000;
3995                 if amount_msat > channel_total_msat {
3996                         return Err(ChannelError::Ignore(format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
3997                 }
3998
3999                 if amount_msat == 0 {
4000                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC".to_owned()));
4001                 }
4002
4003                 if amount_msat < self.counterparty_htlc_minimum_msat {
4004                         return Err(ChannelError::Ignore(format!("Cannot send less than their minimum HTLC value ({})", self.counterparty_htlc_minimum_msat)));
4005                 }
4006
4007                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) != 0 {
4008                         // Note that this should never really happen, if we're !is_live() on receipt of an
4009                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
4010                         // the user to send directly into a !is_live() channel. However, if we
4011                         // disconnected during the time the previous hop was doing the commitment dance we may
4012                         // end up getting here after the forwarding delay. In any case, returning an
4013                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
4014                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected from channel counterparty".to_owned()));
4015                 }
4016
4017                 let (outbound_htlc_count, htlc_outbound_value_msat) = self.get_outbound_pending_htlc_stats();
4018                 if outbound_htlc_count + 1 > self.counterparty_max_accepted_htlcs as u32 {
4019                         return Err(ChannelError::Ignore(format!("Cannot push more than their max accepted HTLCs ({})", self.counterparty_max_accepted_htlcs)));
4020                 }
4021                 // Check their_max_htlc_value_in_flight_msat
4022                 if htlc_outbound_value_msat + amount_msat > self.counterparty_max_htlc_value_in_flight_msat {
4023                         return Err(ChannelError::Ignore(format!("Cannot send value that would put us over the max HTLC value in flight our peer will accept ({})", self.counterparty_max_htlc_value_in_flight_msat)));
4024                 }
4025
4026                 if !self.is_outbound() {
4027                         // Check that we won't violate the remote channel reserve by adding this HTLC.
4028                         let counterparty_balance_msat = self.channel_value_satoshis * 1000 - self.value_to_self_msat;
4029                         let holder_selected_chan_reserve_msat = Channel::<Signer>::get_holder_selected_channel_reserve_satoshis(self.channel_value_satoshis);
4030                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4031                         let counterparty_commit_tx_fee_msat = self.next_remote_commit_tx_fee_msat(htlc_candidate, None);
4032                         if counterparty_balance_msat < holder_selected_chan_reserve_msat + counterparty_commit_tx_fee_msat {
4033                                 return Err(ChannelError::Ignore("Cannot send value that would put counterparty balance under holder-announced channel reserve value".to_owned()));
4034                         }
4035                 }
4036
4037                 let pending_value_to_self_msat = self.value_to_self_msat - htlc_outbound_value_msat;
4038                 if pending_value_to_self_msat < amount_msat {
4039                         return Err(ChannelError::Ignore(format!("Cannot send value that would overdraw remaining funds. Amount: {}, pending value to self {}", amount_msat, pending_value_to_self_msat)));
4040                 }
4041
4042                 // `2 *` and extra HTLC are for the fee spike buffer.
4043                 let commit_tx_fee_msat = if self.is_outbound() {
4044                         let htlc_candidate = HTLCCandidate::new(amount_msat, HTLCInitiator::LocalOffered);
4045                         2 * self.next_local_commit_tx_fee_msat(htlc_candidate, Some(()))
4046                 } else { 0 };
4047                 if pending_value_to_self_msat - amount_msat < commit_tx_fee_msat {
4048                         return Err(ChannelError::Ignore(format!("Cannot send value that would not leave enough to pay for fees. Pending value to self: {}. local_commit_tx_fee {}", pending_value_to_self_msat, commit_tx_fee_msat)));
4049                 }
4050
4051                 // Check self.counterparty_selected_channel_reserve_satoshis (the amount we must keep as
4052                 // reserve for the remote to have something to claim if we misbehave)
4053                 let chan_reserve_msat = self.counterparty_selected_channel_reserve_satoshis * 1000;
4054                 if pending_value_to_self_msat - amount_msat - commit_tx_fee_msat < chan_reserve_msat {
4055                         return Err(ChannelError::Ignore(format!("Cannot send value that would put our balance under counterparty-announced channel reserve value ({})", chan_reserve_msat)));
4056                 }
4057
4058                 // Now update local state:
4059                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
4060                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
4061                                 amount_msat,
4062                                 payment_hash,
4063                                 cltv_expiry,
4064                                 source,
4065                                 onion_routing_packet,
4066                         });
4067                         return Ok(None);
4068                 }
4069
4070                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
4071                         htlc_id: self.next_holder_htlc_id,
4072                         amount_msat,
4073                         payment_hash: payment_hash.clone(),
4074                         cltv_expiry,
4075                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
4076                         source,
4077                 });
4078
4079                 let res = msgs::UpdateAddHTLC {
4080                         channel_id: self.channel_id,
4081                         htlc_id: self.next_holder_htlc_id,
4082                         amount_msat,
4083                         payment_hash,
4084                         cltv_expiry,
4085                         onion_routing_packet,
4086                 };
4087                 self.next_holder_htlc_id += 1;
4088
4089                 Ok(Some(res))
4090         }
4091
4092         /// Creates a signed commitment transaction to send to the remote peer.
4093         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
4094         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
4095         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
4096         pub fn send_commitment<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
4097                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
4098                         panic!("Cannot create commitment tx until channel is fully established");
4099                 }
4100                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
4101                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
4102                 }
4103                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
4104                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
4105                 }
4106                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
4107                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
4108                 }
4109                 let mut have_updates = self.pending_update_fee.is_some();
4110                 for htlc in self.pending_outbound_htlcs.iter() {
4111                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
4112                                 have_updates = true;
4113                         }
4114                         if have_updates { break; }
4115                 }
4116                 for htlc in self.pending_inbound_htlcs.iter() {
4117                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
4118                                 have_updates = true;
4119                         }
4120                         if have_updates { break; }
4121                 }
4122                 if !have_updates {
4123                         panic!("Cannot create commitment tx until we have some updates to send");
4124                 }
4125                 self.send_commitment_no_status_check(logger)
4126         }
4127         /// Only fails in case of bad keys
4128         fn send_commitment_no_status_check<L: Deref>(&mut self, logger: &L) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> where L::Target: Logger {
4129                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
4130                 // fail to generate this, we still are at least at a position where upgrading their status
4131                 // is acceptable.
4132                 for htlc in self.pending_inbound_htlcs.iter_mut() {
4133                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
4134                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
4135                         } else { None };
4136                         if let Some(state) = new_state {
4137                                 htlc.state = state;
4138                         }
4139                 }
4140                 for htlc in self.pending_outbound_htlcs.iter_mut() {
4141                         if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
4142                                 Some(fail_reason.take())
4143                         } else { None } {
4144                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
4145                         }
4146                 }
4147                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
4148
4149                 let (res, counterparty_commitment_txid, htlcs) = match self.send_commitment_no_state_update(logger) {
4150                         Ok((res, (counterparty_commitment_tx, mut htlcs))) => {
4151                                 // Update state now that we've passed all the can-fail calls...
4152                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
4153                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
4154                                 (res, counterparty_commitment_tx, htlcs_no_ref)
4155                         },
4156                         Err(e) => return Err(e),
4157                 };
4158
4159                 self.latest_monitor_update_id += 1;
4160                 let monitor_update = ChannelMonitorUpdate {
4161                         update_id: self.latest_monitor_update_id,
4162                         updates: vec![ChannelMonitorUpdateStep::LatestCounterpartyCommitmentTXInfo {
4163                                 commitment_txid: counterparty_commitment_txid,
4164                                 htlc_outputs: htlcs.clone(),
4165                                 commitment_number: self.cur_counterparty_commitment_transaction_number,
4166                                 their_revocation_point: self.counterparty_cur_commitment_point.unwrap()
4167                         }]
4168                 };
4169                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
4170                 Ok((res, monitor_update))
4171         }
4172
4173         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
4174         /// when we shouldn't change HTLC/channel state.
4175         fn send_commitment_no_state_update<L: Deref>(&self, logger: &L) -> Result<(msgs::CommitmentSigned, (Txid, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> where L::Target: Logger {
4176                 let mut feerate_per_kw = self.feerate_per_kw;
4177                 if let Some(feerate) = self.pending_update_fee {
4178                         if self.is_outbound() {
4179                                 feerate_per_kw = feerate;
4180                         }
4181                 }
4182
4183                 let counterparty_keys = self.build_remote_transaction_keys()?;
4184                 let counterparty_commitment_tx = self.build_commitment_transaction(self.cur_counterparty_commitment_transaction_number, &counterparty_keys, false, true, feerate_per_kw, logger);
4185                 let counterparty_commitment_txid = counterparty_commitment_tx.0.trust().txid();
4186                 let (signature, htlc_signatures);
4187
4188                 #[cfg(any(test, feature = "fuzztarget"))]
4189                 {
4190                         if !self.is_outbound() {
4191                                 let projected_commit_tx_info = self.next_remote_commitment_tx_fee_info_cached.lock().unwrap().take();
4192                                 *self.next_local_commitment_tx_fee_info_cached.lock().unwrap() = None;
4193                                 if let Some(info) = projected_commit_tx_info {
4194                                         let total_pending_htlcs = self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len();
4195                                         if info.total_pending_htlcs == total_pending_htlcs
4196                                                 && info.next_holder_htlc_id == self.next_holder_htlc_id
4197                                                 && info.next_counterparty_htlc_id == self.next_counterparty_htlc_id
4198                                                 && info.feerate == self.feerate_per_kw {
4199                                                         let actual_fee = self.commit_tx_fee_msat(counterparty_commitment_tx.1);
4200                                                         assert_eq!(actual_fee, info.fee);
4201                                                 }
4202                                 }
4203                         }
4204                 }
4205
4206                 {
4207                         let mut htlcs = Vec::with_capacity(counterparty_commitment_tx.2.len());
4208                         for &(ref htlc, _) in counterparty_commitment_tx.2.iter() {
4209                                 htlcs.push(htlc);
4210                         }
4211
4212                         let res = self.holder_signer.sign_counterparty_commitment(&counterparty_commitment_tx.0, &self.secp_ctx)
4213                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed".to_owned()))?;
4214                         signature = res.0;
4215                         htlc_signatures = res.1;
4216
4217                         log_trace!(logger, "Signed remote commitment tx {} (txid {}) with redeemscript {} -> {}",
4218                                 encode::serialize_hex(&counterparty_commitment_tx.0.trust().built_transaction().transaction),
4219                                 &counterparty_commitment_txid,
4220                                 encode::serialize_hex(&self.get_funding_redeemscript()),
4221                                 log_bytes!(signature.serialize_compact()[..]));
4222
4223                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
4224                                 log_trace!(logger, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {}",
4225                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&counterparty_commitment_txid, feerate_per_kw, self.get_holder_selected_contest_delay(), htlc, &counterparty_keys.broadcaster_delayed_payment_key, &counterparty_keys.revocation_key)),
4226                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, &counterparty_keys)),
4227                                         log_bytes!(counterparty_keys.broadcaster_htlc_key.serialize()),
4228                                         log_bytes!(htlc_sig.serialize_compact()[..]));
4229                         }
4230                 }
4231
4232                 Ok((msgs::CommitmentSigned {
4233                         channel_id: self.channel_id,
4234                         signature,
4235                         htlc_signatures,
4236                 }, (counterparty_commitment_txid, counterparty_commitment_tx.2)))
4237         }
4238
4239         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
4240         /// to send to the remote peer in one go.
4241         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
4242         /// more info.
4243         pub fn send_htlc_and_commit<L: Deref>(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket, logger: &L) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> where L::Target: Logger {
4244                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet)? {
4245                         Some(update_add_htlc) => {
4246                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check(logger)?;
4247                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
4248                         },
4249                         None => Ok(None)
4250                 }
4251         }
4252
4253         /// Get forwarding information for the counterparty.
4254         pub fn counterparty_forwarding_info(&self) -> Option<CounterpartyForwardingInfo> {
4255                 self.counterparty_forwarding_info.clone()
4256         }
4257
4258         pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
4259                 let usable_channel_value_msat = (self.channel_value_satoshis - self.counterparty_selected_channel_reserve_satoshis) * 1000;
4260                 if msg.contents.htlc_minimum_msat >= usable_channel_value_msat {
4261                         return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
4262                 }
4263                 self.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
4264                         fee_base_msat: msg.contents.fee_base_msat,
4265                         fee_proportional_millionths: msg.contents.fee_proportional_millionths,
4266                         cltv_expiry_delta: msg.contents.cltv_expiry_delta
4267                 });
4268
4269                 Ok(())
4270         }
4271
4272         /// Begins the shutdown process, getting a message for the remote peer and returning all
4273         /// holding cell HTLCs for payment failure.
4274         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<(HTLCSource, PaymentHash)>), APIError> {
4275                 for htlc in self.pending_outbound_htlcs.iter() {
4276                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
4277                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first".to_owned()});
4278                         }
4279                 }
4280                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
4281                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
4282                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress".to_owned()});
4283                         }
4284                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
4285                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote".to_owned()});
4286                         }
4287                 }
4288                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
4289                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
4290                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?".to_owned()});
4291                 }
4292
4293                 let closing_script = self.get_closing_scriptpubkey();
4294
4295                 // From here on out, we may not fail!
4296                 if self.channel_state < ChannelState::FundingSent as u32 {
4297                         self.channel_state = ChannelState::ShutdownComplete as u32;
4298                 } else {
4299                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
4300                 }
4301                 self.update_time_counter += 1;
4302
4303                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
4304                 // our shutdown until we've committed all of the pending changes.
4305                 self.holding_cell_update_fee = None;
4306                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
4307                 self.holding_cell_htlc_updates.retain(|htlc_update| {
4308                         match htlc_update {
4309                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
4310                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
4311                                         false
4312                                 },
4313                                 _ => true
4314                         }
4315                 });
4316
4317                 Ok((msgs::Shutdown {
4318                         channel_id: self.channel_id,
4319                         scriptpubkey: closing_script,
4320                 }, dropped_outbound_htlcs))
4321         }
4322
4323         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
4324         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
4325         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
4326         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
4327         /// immediately (others we will have to allow to time out).
4328         pub fn force_shutdown(&mut self, should_broadcast: bool) -> (Option<(OutPoint, ChannelMonitorUpdate)>, Vec<(HTLCSource, PaymentHash)>) {
4329                 // Note that we MUST only generate a monitor update that indicates force-closure - we're
4330                 // called during initialization prior to the chain_monitor in the encompassing ChannelManager
4331                 // being fully configured in some cases. Thus, its likely any monitor events we generate will
4332                 // be delayed in being processed! See the docs for `ChannelManagerReadArgs` for more.
4333                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
4334
4335                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
4336                 // return them to fail the payment.
4337                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
4338                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
4339                         match htlc_update {
4340                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
4341                                         dropped_outbound_htlcs.push((source, payment_hash));
4342                                 },
4343                                 _ => {}
4344                         }
4345                 }
4346                 let monitor_update = if let Some(funding_txo) = self.get_funding_txo() {
4347                         // If we haven't yet exchanged funding signatures (ie channel_state < FundingSent),
4348                         // returning a channel monitor update here would imply a channel monitor update before
4349                         // we even registered the channel monitor to begin with, which is invalid.
4350                         // Thus, if we aren't actually at a point where we could conceivably broadcast the
4351                         // funding transaction, don't return a funding txo (which prevents providing the
4352                         // monitor update to the user, even if we return one).
4353                         // See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
4354                         if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::ChannelFunded as u32 | ChannelState::ShutdownComplete as u32) != 0 {
4355                                 self.latest_monitor_update_id += 1;
4356                                 Some((funding_txo, ChannelMonitorUpdate {
4357                                         update_id: self.latest_monitor_update_id,
4358                                         updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
4359                                 }))
4360                         } else { None }
4361                 } else { None };
4362
4363                 self.channel_state = ChannelState::ShutdownComplete as u32;
4364                 self.update_time_counter += 1;
4365                 (monitor_update, dropped_outbound_htlcs)
4366         }
4367 }
4368
4369 fn is_unsupported_shutdown_script(their_features: &InitFeatures, script: &Script) -> bool {
4370         // We restrain shutdown scripts to standards forms to avoid transactions not propagating on the p2p tx-relay network
4371
4372         // BOLT 2 says we must only send a scriptpubkey of certain standard forms,
4373         // which for a a BIP-141-compliant witness program is at max 42 bytes in length.
4374         // So don't let the remote peer feed us some super fee-heavy script.
4375         let is_script_too_long = script.len() > 42;
4376         if is_script_too_long {
4377                 return true;
4378         }
4379
4380         if their_features.supports_shutdown_anysegwit() && script.is_witness_program() && script.as_bytes()[0] != OP_PUSHBYTES_0.into_u8() {
4381                 return false;
4382         }
4383
4384         return !script.is_p2pkh() && !script.is_p2sh() && !script.is_v0_p2wpkh() && !script.is_v0_p2wsh()
4385 }
4386
4387 const SERIALIZATION_VERSION: u8 = 1;
4388 const MIN_SERIALIZATION_VERSION: u8 = 1;
4389
4390 impl_writeable_tlv_based_enum!(InboundHTLCRemovalReason,;
4391         (0, FailRelay),
4392         (1, FailMalformed),
4393         (2, Fulfill),
4394 );
4395
4396 impl Writeable for ChannelUpdateStatus {
4397         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
4398                 // We only care about writing out the current state as it was announced, ie only either
4399                 // Enabled or Disabled. In the case of DisabledStaged, we most recently announced the
4400                 // channel as enabled, so we write 0. For EnabledStaged, we similarly write a 1.
4401                 match self {
4402                         ChannelUpdateStatus::Enabled => 0u8.write(writer)?,
4403                         ChannelUpdateStatus::DisabledStaged => 0u8.write(writer)?,
4404                         ChannelUpdateStatus::EnabledStaged => 1u8.write(writer)?,
4405                         ChannelUpdateStatus::Disabled => 1u8.write(writer)?,
4406                 }
4407                 Ok(())
4408         }
4409 }
4410
4411 impl Readable for ChannelUpdateStatus {
4412         fn read<R: ::std::io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
4413                 Ok(match <u8 as Readable>::read(reader)? {
4414                         0 => ChannelUpdateStatus::Enabled,
4415                         1 => ChannelUpdateStatus::Disabled,
4416                         _ => return Err(DecodeError::InvalidValue),
4417                 })
4418         }
4419 }
4420
4421 impl<Signer: Sign> Writeable for Channel<Signer> {
4422         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
4423                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
4424                 // called.
4425
4426                 write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
4427
4428                 self.user_id.write(writer)?;
4429                 self.config.write(writer)?;
4430
4431                 self.channel_id.write(writer)?;
4432                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
4433                 self.channel_value_satoshis.write(writer)?;
4434
4435                 self.latest_monitor_update_id.write(writer)?;
4436
4437                 let mut key_data = VecWriter(Vec::new());
4438                 self.holder_signer.write(&mut key_data)?;
4439                 assert!(key_data.0.len() < core::usize::MAX);
4440                 assert!(key_data.0.len() < core::u32::MAX as usize);
4441                 (key_data.0.len() as u32).write(writer)?;
4442                 writer.write_all(&key_data.0[..])?;
4443
4444                 self.shutdown_pubkey.write(writer)?;
4445                 self.destination_script.write(writer)?;
4446
4447                 self.cur_holder_commitment_transaction_number.write(writer)?;
4448                 self.cur_counterparty_commitment_transaction_number.write(writer)?;
4449                 self.value_to_self_msat.write(writer)?;
4450
4451                 let mut dropped_inbound_htlcs = 0;
4452                 for htlc in self.pending_inbound_htlcs.iter() {
4453                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
4454                                 dropped_inbound_htlcs += 1;
4455                         }
4456                 }
4457                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
4458                 for htlc in self.pending_inbound_htlcs.iter() {
4459                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
4460                                 continue; // Drop
4461                         }
4462                         htlc.htlc_id.write(writer)?;
4463                         htlc.amount_msat.write(writer)?;
4464                         htlc.cltv_expiry.write(writer)?;
4465                         htlc.payment_hash.write(writer)?;
4466                         match &htlc.state {
4467                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
4468                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
4469                                         1u8.write(writer)?;
4470                                         htlc_state.write(writer)?;
4471                                 },
4472                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
4473                                         2u8.write(writer)?;
4474                                         htlc_state.write(writer)?;
4475                                 },
4476                                 &InboundHTLCState::Committed => {
4477                                         3u8.write(writer)?;
4478                                 },
4479                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
4480                                         4u8.write(writer)?;
4481                                         removal_reason.write(writer)?;
4482                                 },
4483                         }
4484                 }
4485
4486                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
4487                 for htlc in self.pending_outbound_htlcs.iter() {
4488                         htlc.htlc_id.write(writer)?;
4489                         htlc.amount_msat.write(writer)?;
4490                         htlc.cltv_expiry.write(writer)?;
4491                         htlc.payment_hash.write(writer)?;
4492                         htlc.source.write(writer)?;
4493                         match &htlc.state {
4494                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
4495                                         0u8.write(writer)?;
4496                                         onion_packet.write(writer)?;
4497                                 },
4498                                 &OutboundHTLCState::Committed => {
4499                                         1u8.write(writer)?;
4500                                 },
4501                                 &OutboundHTLCState::RemoteRemoved(_) => {
4502                                         // Treat this as a Committed because we haven't received the CS - they'll
4503                                         // resend the claim/fail on reconnect as we all (hopefully) the missing CS.
4504                                         1u8.write(writer)?;
4505                                 },
4506                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref fail_reason) => {
4507                                         3u8.write(writer)?;
4508                                         fail_reason.write(writer)?;
4509                                 },
4510                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) => {
4511                                         4u8.write(writer)?;
4512                                         fail_reason.write(writer)?;
4513                                 },
4514                         }
4515                 }
4516
4517                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
4518                 for update in self.holding_cell_htlc_updates.iter() {
4519                         match update {
4520                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
4521                                         0u8.write(writer)?;
4522                                         amount_msat.write(writer)?;
4523                                         cltv_expiry.write(writer)?;
4524                                         payment_hash.write(writer)?;
4525                                         source.write(writer)?;
4526                                         onion_routing_packet.write(writer)?;
4527                                 },
4528                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
4529                                         1u8.write(writer)?;
4530                                         payment_preimage.write(writer)?;
4531                                         htlc_id.write(writer)?;
4532                                 },
4533                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
4534                                         2u8.write(writer)?;
4535                                         htlc_id.write(writer)?;
4536                                         err_packet.write(writer)?;
4537                                 }
4538                         }
4539                 }
4540
4541                 match self.resend_order {
4542                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
4543                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
4544                 }
4545
4546                 self.monitor_pending_funding_locked.write(writer)?;
4547                 self.monitor_pending_revoke_and_ack.write(writer)?;
4548                 self.monitor_pending_commitment_signed.write(writer)?;
4549
4550                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
4551                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
4552                         pending_forward.write(writer)?;
4553                         htlc_id.write(writer)?;
4554                 }
4555
4556                 (self.monitor_pending_failures.len() as u64).write(writer)?;
4557                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
4558                         htlc_source.write(writer)?;
4559                         payment_hash.write(writer)?;
4560                         fail_reason.write(writer)?;
4561                 }
4562
4563                 self.pending_update_fee.write(writer)?;
4564                 self.holding_cell_update_fee.write(writer)?;
4565
4566                 self.next_holder_htlc_id.write(writer)?;
4567                 (self.next_counterparty_htlc_id - dropped_inbound_htlcs).write(writer)?;
4568                 self.update_time_counter.write(writer)?;
4569                 self.feerate_per_kw.write(writer)?;
4570
4571                 match self.last_sent_closing_fee {
4572                         Some((feerate, fee, sig)) => {
4573                                 1u8.write(writer)?;
4574                                 feerate.write(writer)?;
4575                                 fee.write(writer)?;
4576                                 sig.write(writer)?;
4577                         },
4578                         None => 0u8.write(writer)?,
4579                 }
4580
4581                 self.funding_tx_confirmed_in.write(writer)?;
4582                 self.funding_tx_confirmation_height.write(writer)?;
4583                 self.short_channel_id.write(writer)?;
4584
4585                 self.counterparty_dust_limit_satoshis.write(writer)?;
4586                 self.holder_dust_limit_satoshis.write(writer)?;
4587                 self.counterparty_max_htlc_value_in_flight_msat.write(writer)?;
4588                 self.counterparty_selected_channel_reserve_satoshis.write(writer)?;
4589                 self.counterparty_htlc_minimum_msat.write(writer)?;
4590                 self.holder_htlc_minimum_msat.write(writer)?;
4591                 self.counterparty_max_accepted_htlcs.write(writer)?;
4592                 self.minimum_depth.write(writer)?;
4593
4594                 match &self.counterparty_forwarding_info {
4595                         Some(info) => {
4596                                 1u8.write(writer)?;
4597                                 info.fee_base_msat.write(writer)?;
4598                                 info.fee_proportional_millionths.write(writer)?;
4599                                 info.cltv_expiry_delta.write(writer)?;
4600                         },
4601                         None => 0u8.write(writer)?
4602                 }
4603
4604                 self.channel_transaction_parameters.write(writer)?;
4605                 self.funding_transaction.write(writer)?;
4606
4607                 self.counterparty_cur_commitment_point.write(writer)?;
4608                 self.counterparty_prev_commitment_point.write(writer)?;
4609                 self.counterparty_node_id.write(writer)?;
4610
4611                 self.counterparty_shutdown_scriptpubkey.write(writer)?;
4612
4613                 self.commitment_secrets.write(writer)?;
4614
4615                 self.channel_update_status.write(writer)?;
4616
4617                 write_tlv_fields!(writer, {}, {(0, self.announcement_sigs)});
4618
4619                 Ok(())
4620         }
4621 }
4622
4623 const MAX_ALLOC_SIZE: usize = 64*1024;
4624 impl<'a, Signer: Sign, K: Deref> ReadableArgs<&'a K> for Channel<Signer>
4625                 where K::Target: KeysInterface<Signer = Signer> {
4626         fn read<R : ::std::io::Read>(reader: &mut R, keys_source: &'a K) -> Result<Self, DecodeError> {
4627                 let _ver = read_ver_prefix!(reader, SERIALIZATION_VERSION);
4628
4629                 let user_id = Readable::read(reader)?;
4630                 let config: ChannelConfig = Readable::read(reader)?;
4631
4632                 let channel_id = Readable::read(reader)?;
4633                 let channel_state = Readable::read(reader)?;
4634                 let channel_value_satoshis = Readable::read(reader)?;
4635
4636                 let latest_monitor_update_id = Readable::read(reader)?;
4637
4638                 let keys_len: u32 = Readable::read(reader)?;
4639                 let mut keys_data = Vec::with_capacity(cmp::min(keys_len as usize, MAX_ALLOC_SIZE));
4640                 while keys_data.len() != keys_len as usize {
4641                         // Read 1KB at a time to avoid accidentally allocating 4GB on corrupted channel keys
4642                         let mut data = [0; 1024];
4643                         let read_slice = &mut data[0..cmp::min(1024, keys_len as usize - keys_data.len())];
4644                         reader.read_exact(read_slice)?;
4645                         keys_data.extend_from_slice(read_slice);
4646                 }
4647                 let holder_signer = keys_source.read_chan_signer(&keys_data)?;
4648
4649                 let shutdown_pubkey = Readable::read(reader)?;
4650                 let destination_script = Readable::read(reader)?;
4651
4652                 let cur_holder_commitment_transaction_number = Readable::read(reader)?;
4653                 let cur_counterparty_commitment_transaction_number = Readable::read(reader)?;
4654                 let value_to_self_msat = Readable::read(reader)?;
4655
4656                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
4657                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
4658                 for _ in 0..pending_inbound_htlc_count {
4659                         pending_inbound_htlcs.push(InboundHTLCOutput {
4660                                 htlc_id: Readable::read(reader)?,
4661                                 amount_msat: Readable::read(reader)?,
4662                                 cltv_expiry: Readable::read(reader)?,
4663                                 payment_hash: Readable::read(reader)?,
4664                                 state: match <u8 as Readable>::read(reader)? {
4665                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
4666                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
4667                                         3 => InboundHTLCState::Committed,
4668                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
4669                                         _ => return Err(DecodeError::InvalidValue),
4670                                 },
4671                         });
4672                 }
4673
4674                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
4675                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
4676                 for _ in 0..pending_outbound_htlc_count {
4677                         pending_outbound_htlcs.push(OutboundHTLCOutput {
4678                                 htlc_id: Readable::read(reader)?,
4679                                 amount_msat: Readable::read(reader)?,
4680                                 cltv_expiry: Readable::read(reader)?,
4681                                 payment_hash: Readable::read(reader)?,
4682                                 source: Readable::read(reader)?,
4683                                 state: match <u8 as Readable>::read(reader)? {
4684                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
4685                                         1 => OutboundHTLCState::Committed,
4686                                         2 => OutboundHTLCState::RemoteRemoved(Readable::read(reader)?),
4687                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove(Readable::read(reader)?),
4688                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke(Readable::read(reader)?),
4689                                         _ => return Err(DecodeError::InvalidValue),
4690                                 },
4691                         });
4692                 }
4693
4694                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
4695                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
4696                 for _ in 0..holding_cell_htlc_update_count {
4697                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
4698                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
4699                                         amount_msat: Readable::read(reader)?,
4700                                         cltv_expiry: Readable::read(reader)?,
4701                                         payment_hash: Readable::read(reader)?,
4702                                         source: Readable::read(reader)?,
4703                                         onion_routing_packet: Readable::read(reader)?,
4704                                 },
4705                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
4706                                         payment_preimage: Readable::read(reader)?,
4707                                         htlc_id: Readable::read(reader)?,
4708                                 },
4709                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
4710                                         htlc_id: Readable::read(reader)?,
4711                                         err_packet: Readable::read(reader)?,
4712                                 },
4713                                 _ => return Err(DecodeError::InvalidValue),
4714                         });
4715                 }
4716
4717                 let resend_order = match <u8 as Readable>::read(reader)? {
4718                         0 => RAACommitmentOrder::CommitmentFirst,
4719                         1 => RAACommitmentOrder::RevokeAndACKFirst,
4720                         _ => return Err(DecodeError::InvalidValue),
4721                 };
4722
4723                 let monitor_pending_funding_locked = Readable::read(reader)?;
4724                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
4725                 let monitor_pending_commitment_signed = Readable::read(reader)?;
4726
4727                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
4728                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
4729                 for _ in 0..monitor_pending_forwards_count {
4730                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
4731                 }
4732
4733                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
4734                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
4735                 for _ in 0..monitor_pending_failures_count {
4736                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
4737                 }
4738
4739                 let pending_update_fee = Readable::read(reader)?;
4740                 let holding_cell_update_fee = Readable::read(reader)?;
4741
4742                 let next_holder_htlc_id = Readable::read(reader)?;
4743                 let next_counterparty_htlc_id = Readable::read(reader)?;
4744                 let update_time_counter = Readable::read(reader)?;
4745                 let feerate_per_kw = Readable::read(reader)?;
4746
4747                 let last_sent_closing_fee = match <u8 as Readable>::read(reader)? {
4748                         0 => None,
4749                         1 => Some((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?)),
4750                         _ => return Err(DecodeError::InvalidValue),
4751                 };
4752
4753                 let funding_tx_confirmed_in = Readable::read(reader)?;
4754                 let funding_tx_confirmation_height = Readable::read(reader)?;
4755                 let short_channel_id = Readable::read(reader)?;
4756
4757                 let counterparty_dust_limit_satoshis = Readable::read(reader)?;
4758                 let holder_dust_limit_satoshis = Readable::read(reader)?;
4759                 let counterparty_max_htlc_value_in_flight_msat = Readable::read(reader)?;
4760                 let counterparty_selected_channel_reserve_satoshis = Readable::read(reader)?;
4761                 let counterparty_htlc_minimum_msat = Readable::read(reader)?;
4762                 let holder_htlc_minimum_msat = Readable::read(reader)?;
4763                 let counterparty_max_accepted_htlcs = Readable::read(reader)?;
4764                 let minimum_depth = Readable::read(reader)?;
4765
4766                 let counterparty_forwarding_info = match <u8 as Readable>::read(reader)? {
4767                         0 => None,
4768                         1 => Some(CounterpartyForwardingInfo {
4769                                 fee_base_msat: Readable::read(reader)?,
4770                                 fee_proportional_millionths: Readable::read(reader)?,
4771                                 cltv_expiry_delta: Readable::read(reader)?,
4772                         }),
4773                         _ => return Err(DecodeError::InvalidValue),
4774                 };
4775
4776                 let channel_parameters = Readable::read(reader)?;
4777                 let funding_transaction = Readable::read(reader)?;
4778
4779                 let counterparty_cur_commitment_point = Readable::read(reader)?;
4780
4781                 let counterparty_prev_commitment_point = Readable::read(reader)?;
4782                 let counterparty_node_id = Readable::read(reader)?;
4783
4784                 let counterparty_shutdown_scriptpubkey = Readable::read(reader)?;
4785                 let commitment_secrets = Readable::read(reader)?;
4786
4787                 let channel_update_status = Readable::read(reader)?;
4788
4789                 let mut announcement_sigs = None;
4790                 read_tlv_fields!(reader, {}, {(0, announcement_sigs)});
4791
4792                 let mut secp_ctx = Secp256k1::new();
4793                 secp_ctx.seeded_randomize(&keys_source.get_secure_random_bytes());
4794
4795                 Ok(Channel {
4796                         user_id,
4797
4798                         config,
4799                         channel_id,
4800                         channel_state,
4801                         secp_ctx,
4802                         channel_value_satoshis,
4803
4804                         latest_monitor_update_id,
4805
4806                         holder_signer,
4807                         shutdown_pubkey,
4808                         destination_script,
4809
4810                         cur_holder_commitment_transaction_number,
4811                         cur_counterparty_commitment_transaction_number,
4812                         value_to_self_msat,
4813
4814                         pending_inbound_htlcs,
4815                         pending_outbound_htlcs,
4816                         holding_cell_htlc_updates,
4817
4818                         resend_order,
4819
4820                         monitor_pending_funding_locked,
4821                         monitor_pending_revoke_and_ack,
4822                         monitor_pending_commitment_signed,
4823                         monitor_pending_forwards,
4824                         monitor_pending_failures,
4825
4826                         pending_update_fee,
4827                         holding_cell_update_fee,
4828                         next_holder_htlc_id,
4829                         next_counterparty_htlc_id,
4830                         update_time_counter,
4831                         feerate_per_kw,
4832
4833                         #[cfg(debug_assertions)]
4834                         holder_max_commitment_tx_output: ::std::sync::Mutex::new((0, 0)),
4835                         #[cfg(debug_assertions)]
4836                         counterparty_max_commitment_tx_output: ::std::sync::Mutex::new((0, 0)),
4837
4838                         last_sent_closing_fee,
4839
4840                         funding_tx_confirmed_in,
4841                         funding_tx_confirmation_height,
4842                         short_channel_id,
4843
4844                         counterparty_dust_limit_satoshis,
4845                         holder_dust_limit_satoshis,
4846                         counterparty_max_htlc_value_in_flight_msat,
4847                         counterparty_selected_channel_reserve_satoshis,
4848                         counterparty_htlc_minimum_msat,
4849                         holder_htlc_minimum_msat,
4850                         counterparty_max_accepted_htlcs,
4851                         minimum_depth,
4852
4853                         counterparty_forwarding_info,
4854
4855                         channel_transaction_parameters: channel_parameters,
4856                         funding_transaction,
4857
4858                         counterparty_cur_commitment_point,
4859                         counterparty_prev_commitment_point,
4860                         counterparty_node_id,
4861
4862                         counterparty_shutdown_scriptpubkey,
4863
4864                         commitment_secrets,
4865
4866                         channel_update_status,
4867
4868                         announcement_sigs,
4869
4870                         #[cfg(any(test, feature = "fuzztarget"))]
4871                         next_local_commitment_tx_fee_info_cached: Mutex::new(None),
4872                         #[cfg(any(test, feature = "fuzztarget"))]
4873                         next_remote_commitment_tx_fee_info_cached: Mutex::new(None),
4874                 })
4875         }
4876 }
4877
4878 #[cfg(test)]
4879 mod tests {
4880         use bitcoin::util::bip143;
4881         use bitcoin::consensus::encode::serialize;
4882         use bitcoin::blockdata::script::{Script, Builder};
4883         use bitcoin::blockdata::transaction::{Transaction, TxOut, SigHashType};
4884         use bitcoin::blockdata::constants::genesis_block;
4885         use bitcoin::blockdata::opcodes;
4886         use bitcoin::network::constants::Network;
4887         use bitcoin::hashes::hex::FromHex;
4888         use hex;
4889         use ln::{PaymentPreimage, PaymentHash};
4890         use ln::channelmanager::{BestBlock, HTLCSource};
4891         use ln::channel::{Channel,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,HTLCCandidate,HTLCInitiator,TxCreationKeys};
4892         use ln::channel::MAX_FUNDING_SATOSHIS;
4893         use ln::features::InitFeatures;
4894         use ln::msgs::{ChannelUpdate, DataLossProtect, DecodeError, OptionalField, UnsignedChannelUpdate};
4895         use ln::chan_utils;
4896         use ln::chan_utils::{ChannelPublicKeys, HolderCommitmentTransaction, CounterpartyChannelTransactionParameters, HTLC_SUCCESS_TX_WEIGHT, HTLC_TIMEOUT_TX_WEIGHT};
4897         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
4898         use chain::keysinterface::{InMemorySigner, KeysInterface, BaseSign};
4899         use chain::transaction::OutPoint;
4900         use util::config::UserConfig;
4901         use util::enforcing_trait_impls::EnforcingSigner;
4902         use util::test_utils;
4903         use util::logger::Logger;
4904         use bitcoin::secp256k1::{Secp256k1, Message, Signature, All};
4905         use bitcoin::secp256k1::ffi::Signature as FFISignature;
4906         use bitcoin::secp256k1::key::{SecretKey,PublicKey};
4907         use bitcoin::secp256k1::recovery::RecoverableSignature;
4908         use bitcoin::hashes::sha256::Hash as Sha256;
4909         use bitcoin::hashes::Hash;
4910         use bitcoin::hash_types::{Txid, WPubkeyHash};
4911         use std::sync::Arc;
4912         use prelude::*;
4913
4914         struct TestFeeEstimator {
4915                 fee_est: u32
4916         }
4917         impl FeeEstimator for TestFeeEstimator {
4918                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u32 {
4919                         self.fee_est
4920                 }
4921         }
4922
4923         #[test]
4924         fn test_max_funding_satoshis() {
4925                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
4926                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
4927         }
4928
4929         struct Keys {
4930                 signer: InMemorySigner,
4931         }
4932         impl KeysInterface for Keys {
4933                 type Signer = InMemorySigner;
4934
4935                 fn get_node_secret(&self) -> SecretKey { panic!(); }
4936                 fn get_destination_script(&self) -> Script {
4937                         let secp_ctx = Secp256k1::signing_only();
4938                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4939                         let channel_monitor_claim_key_hash = WPubkeyHash::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
4940                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&channel_monitor_claim_key_hash[..]).into_script()
4941                 }
4942
4943                 fn get_shutdown_pubkey(&self) -> PublicKey {
4944                         let secp_ctx = Secp256k1::signing_only();
4945                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4946                         PublicKey::from_secret_key(&secp_ctx, &channel_close_key)
4947                 }
4948
4949                 fn get_channel_signer(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemorySigner {
4950                         self.signer.clone()
4951                 }
4952                 fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
4953                 fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
4954                 fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> { panic!(); }
4955         }
4956
4957         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
4958                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
4959         }
4960
4961         // Check that, during channel creation, we use the same feerate in the open channel message
4962         // as we do in the Channel object creation itself.
4963         #[test]
4964         fn test_open_channel_msg_fee() {
4965                 let original_fee = 253;
4966                 let mut fee_est = TestFeeEstimator{fee_est: original_fee };
4967                 let secp_ctx = Secp256k1::new();
4968                 let seed = [42; 32];
4969                 let network = Network::Testnet;
4970                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
4971
4972                 let node_a_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
4973                 let config = UserConfig::default();
4974                 let node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_a_node_id, 10000000, 100000, 42, &config).unwrap();
4975
4976                 // Now change the fee so we can check that the fee in the open_channel message is the
4977                 // same as the old fee.
4978                 fee_est.fee_est = 500;
4979                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
4980                 assert_eq!(open_channel_msg.feerate_per_kw, original_fee);
4981         }
4982
4983         #[test]
4984         fn test_holder_vs_counterparty_dust_limit() {
4985                 // Test that when calculating the local and remote commitment transaction fees, the correct
4986                 // dust limits are used.
4987                 let feeest = TestFeeEstimator{fee_est: 15000};
4988                 let secp_ctx = Secp256k1::new();
4989                 let seed = [42; 32];
4990                 let network = Network::Testnet;
4991                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
4992
4993                 // Go through the flow of opening a channel between two nodes, making sure
4994                 // they have different dust limits.
4995
4996                 // Create Node A's channel pointing to Node B's pubkey
4997                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
4998                 let config = UserConfig::default();
4999                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, 10000000, 100000, 42, &config).unwrap();
5000
5001                 // Create Node B's channel by receiving Node A's open_channel message
5002                 // Make sure A's dust limit is as we expect.
5003                 let open_channel_msg = node_a_chan.get_open_channel(genesis_block(network).header.block_hash());
5004                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
5005                 let node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, InitFeatures::known(), &open_channel_msg, 7, &config).unwrap();
5006
5007                 // Node B --> Node A: accept channel, explicitly setting B's dust limit.
5008                 let mut accept_channel_msg = node_b_chan.get_accept_channel();
5009                 accept_channel_msg.dust_limit_satoshis = 546;
5010                 node_a_chan.accept_channel(&accept_channel_msg, &config, InitFeatures::known()).unwrap();
5011                 node_a_chan.holder_dust_limit_satoshis = 1560;
5012
5013                 // Put some inbound and outbound HTLCs in A's channel.
5014                 let htlc_amount_msat = 11_092_000; // put an amount below A's effective dust limit but above B's.
5015                 node_a_chan.pending_inbound_htlcs.push(InboundHTLCOutput {
5016                         htlc_id: 0,
5017                         amount_msat: htlc_amount_msat,
5018                         payment_hash: PaymentHash(Sha256::hash(&[42; 32]).into_inner()),
5019                         cltv_expiry: 300000000,
5020                         state: InboundHTLCState::Committed,
5021                 });
5022
5023                 node_a_chan.pending_outbound_htlcs.push(OutboundHTLCOutput {
5024                         htlc_id: 1,
5025                         amount_msat: htlc_amount_msat, // put an amount below A's dust amount but above B's.
5026                         payment_hash: PaymentHash(Sha256::hash(&[43; 32]).into_inner()),
5027                         cltv_expiry: 200000000,
5028                         state: OutboundHTLCState::Committed,
5029                         source: HTLCSource::OutboundRoute {
5030                                 path: Vec::new(),
5031                                 session_priv: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
5032                                 first_hop_htlc_msat: 548,
5033                         }
5034                 });
5035
5036                 // Make sure when Node A calculates their local commitment transaction, none of the HTLCs pass
5037                 // the dust limit check.
5038                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
5039                 let local_commit_tx_fee = node_a_chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
5040                 let local_commit_fee_0_htlcs = node_a_chan.commit_tx_fee_msat(0);
5041                 assert_eq!(local_commit_tx_fee, local_commit_fee_0_htlcs);
5042
5043                 // Finally, make sure that when Node A calculates the remote's commitment transaction fees, all
5044                 // of the HTLCs are seen to be above the dust limit.
5045                 node_a_chan.channel_transaction_parameters.is_outbound_from_holder = false;
5046                 let remote_commit_fee_3_htlcs = node_a_chan.commit_tx_fee_msat(3);
5047                 let htlc_candidate = HTLCCandidate::new(htlc_amount_msat, HTLCInitiator::LocalOffered);
5048                 let remote_commit_tx_fee = node_a_chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
5049                 assert_eq!(remote_commit_tx_fee, remote_commit_fee_3_htlcs);
5050         }
5051
5052         #[test]
5053         fn test_timeout_vs_success_htlc_dust_limit() {
5054                 // Make sure that when `next_remote_commit_tx_fee_msat` and `next_local_commit_tx_fee_msat`
5055                 // calculate the real dust limits for HTLCs (i.e. the dust limit given by the counterparty
5056                 // *plus* the fees paid for the HTLC) they don't swap `HTLC_SUCCESS_TX_WEIGHT` for
5057                 // `HTLC_TIMEOUT_TX_WEIGHT`, and vice versa.
5058                 let fee_est = TestFeeEstimator{fee_est: 253 };
5059                 let secp_ctx = Secp256k1::new();
5060                 let seed = [42; 32];
5061                 let network = Network::Testnet;
5062                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5063
5064                 let node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5065                 let config = UserConfig::default();
5066                 let mut chan = Channel::<EnforcingSigner>::new_outbound(&&fee_est, &&keys_provider, node_id, 10000000, 100000, 42, &config).unwrap();
5067
5068                 let commitment_tx_fee_0_htlcs = chan.commit_tx_fee_msat(0);
5069                 let commitment_tx_fee_1_htlc = chan.commit_tx_fee_msat(1);
5070
5071                 // If HTLC_SUCCESS_TX_WEIGHT and HTLC_TIMEOUT_TX_WEIGHT were swapped: then this HTLC would be
5072                 // counted as dust when it shouldn't be.
5073                 let htlc_amt_above_timeout = ((253 * HTLC_TIMEOUT_TX_WEIGHT / 1000) + chan.holder_dust_limit_satoshis + 1) * 1000;
5074                 let htlc_candidate = HTLCCandidate::new(htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
5075                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
5076                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
5077
5078                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
5079                 let dust_htlc_amt_below_success = ((253 * HTLC_SUCCESS_TX_WEIGHT / 1000) + chan.holder_dust_limit_satoshis - 1) * 1000;
5080                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_below_success, HTLCInitiator::RemoteOffered);
5081                 let commitment_tx_fee = chan.next_local_commit_tx_fee_msat(htlc_candidate, None);
5082                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
5083
5084                 chan.channel_transaction_parameters.is_outbound_from_holder = false;
5085
5086                 // If swapped: this HTLC would be counted as non-dust when it shouldn't be.
5087                 let dust_htlc_amt_above_timeout = ((253 * HTLC_TIMEOUT_TX_WEIGHT / 1000) + chan.counterparty_dust_limit_satoshis + 1) * 1000;
5088                 let htlc_candidate = HTLCCandidate::new(dust_htlc_amt_above_timeout, HTLCInitiator::LocalOffered);
5089                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
5090                 assert_eq!(commitment_tx_fee, commitment_tx_fee_0_htlcs);
5091
5092                 // If swapped: this HTLC would be counted as dust when it shouldn't be.
5093                 let htlc_amt_below_success = ((253 * HTLC_SUCCESS_TX_WEIGHT / 1000) + chan.counterparty_dust_limit_satoshis - 1) * 1000;
5094                 let htlc_candidate = HTLCCandidate::new(htlc_amt_below_success, HTLCInitiator::RemoteOffered);
5095                 let commitment_tx_fee = chan.next_remote_commit_tx_fee_msat(htlc_candidate, None);
5096                 assert_eq!(commitment_tx_fee, commitment_tx_fee_1_htlc);
5097         }
5098
5099         #[test]
5100         fn channel_reestablish_no_updates() {
5101                 let feeest = TestFeeEstimator{fee_est: 15000};
5102                 let logger = test_utils::TestLogger::new();
5103                 let secp_ctx = Secp256k1::new();
5104                 let seed = [42; 32];
5105                 let network = Network::Testnet;
5106                 let best_block = BestBlock::from_genesis(network);
5107                 let chain_hash = best_block.block_hash();
5108                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5109
5110                 // Go through the flow of opening a channel between two nodes.
5111
5112                 // Create Node A's channel pointing to Node B's pubkey
5113                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5114                 let config = UserConfig::default();
5115                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, 10000000, 100000, 42, &config).unwrap();
5116
5117                 // Create Node B's channel by receiving Node A's open_channel message
5118                 let open_channel_msg = node_a_chan.get_open_channel(chain_hash);
5119                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[7; 32]).unwrap());
5120                 let mut node_b_chan = Channel::<EnforcingSigner>::new_from_req(&&feeest, &&keys_provider, node_b_node_id, InitFeatures::known(), &open_channel_msg, 7, &config).unwrap();
5121
5122                 // Node B --> Node A: accept channel
5123                 let accept_channel_msg = node_b_chan.get_accept_channel();
5124                 node_a_chan.accept_channel(&accept_channel_msg, &config, InitFeatures::known()).unwrap();
5125
5126                 // Node A --> Node B: funding created
5127                 let output_script = node_a_chan.get_funding_redeemscript();
5128                 let tx = Transaction { version: 1, lock_time: 0, input: Vec::new(), output: vec![TxOut {
5129                         value: 10000000, script_pubkey: output_script.clone(),
5130                 }]};
5131                 let funding_outpoint = OutPoint{ txid: tx.txid(), index: 0 };
5132                 let funding_created_msg = node_a_chan.get_outbound_funding_created(tx.clone(), funding_outpoint, &&logger).unwrap();
5133                 let (funding_signed_msg, _) = node_b_chan.funding_created(&funding_created_msg, best_block, &&logger).unwrap();
5134
5135                 // Node B --> Node A: funding signed
5136                 let _ = node_a_chan.funding_signed(&funding_signed_msg, best_block, &&logger);
5137
5138                 // Now disconnect the two nodes and check that the commitment point in
5139                 // Node B's channel_reestablish message is sane.
5140                 node_b_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
5141                 let msg = node_b_chan.get_channel_reestablish(&&logger);
5142                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
5143                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
5144                 match msg.data_loss_protect {
5145                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
5146                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
5147                         },
5148                         _ => panic!()
5149                 }
5150
5151                 // Check that the commitment point in Node A's channel_reestablish message
5152                 // is sane.
5153                 node_a_chan.remove_uncommitted_htlcs_and_mark_paused(&&logger);
5154                 let msg = node_a_chan.get_channel_reestablish(&&logger);
5155                 assert_eq!(msg.next_local_commitment_number, 1); // now called next_commitment_number
5156                 assert_eq!(msg.next_remote_commitment_number, 0); // now called next_revocation_number
5157                 match msg.data_loss_protect {
5158                         OptionalField::Present(DataLossProtect { your_last_per_commitment_secret, .. }) => {
5159                                 assert_eq!(your_last_per_commitment_secret, [0; 32]);
5160                         },
5161                         _ => panic!()
5162                 }
5163         }
5164
5165         #[test]
5166         fn channel_update() {
5167                 let feeest = TestFeeEstimator{fee_est: 15000};
5168                 let secp_ctx = Secp256k1::new();
5169                 let seed = [42; 32];
5170                 let network = Network::Testnet;
5171                 let chain_hash = genesis_block(network).header.block_hash();
5172                 let keys_provider = test_utils::TestKeysInterface::new(&seed, network);
5173
5174                 // Create a channel.
5175                 let node_b_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5176                 let config = UserConfig::default();
5177                 let mut node_a_chan = Channel::<EnforcingSigner>::new_outbound(&&feeest, &&keys_provider, node_b_node_id, 10000000, 100000, 42, &config).unwrap();
5178                 assert!(node_a_chan.counterparty_forwarding_info.is_none());
5179                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1); // the default
5180                 assert!(node_a_chan.counterparty_forwarding_info().is_none());
5181
5182                 // Make sure that receiving a channel update will update the Channel as expected.
5183                 let update = ChannelUpdate {
5184                         contents: UnsignedChannelUpdate {
5185                                 chain_hash,
5186                                 short_channel_id: 0,
5187                                 timestamp: 0,
5188                                 flags: 0,
5189                                 cltv_expiry_delta: 100,
5190                                 htlc_minimum_msat: 5,
5191                                 htlc_maximum_msat: OptionalField::Absent,
5192                                 fee_base_msat: 110,
5193                                 fee_proportional_millionths: 11,
5194                                 excess_data: Vec::new(),
5195                         },
5196                         signature: Signature::from(unsafe { FFISignature::new() })
5197                 };
5198                 node_a_chan.channel_update(&update).unwrap();
5199
5200                 // The counterparty can send an update with a higher minimum HTLC, but that shouldn't
5201                 // change our official htlc_minimum_msat.
5202                 assert_eq!(node_a_chan.holder_htlc_minimum_msat, 1);
5203                 match node_a_chan.counterparty_forwarding_info() {
5204                         Some(info) => {
5205                                 assert_eq!(info.cltv_expiry_delta, 100);
5206                                 assert_eq!(info.fee_base_msat, 110);
5207                                 assert_eq!(info.fee_proportional_millionths, 11);
5208                         },
5209                         None => panic!("expected counterparty forwarding info to be Some")
5210                 }
5211         }
5212
5213         #[test]
5214         fn outbound_commitment_test() {
5215                 // Test vectors from BOLT 3 Appendix C:
5216                 let feeest = TestFeeEstimator{fee_est: 15000};
5217                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
5218                 let secp_ctx = Secp256k1::new();
5219
5220                 let mut signer = InMemorySigner::new(
5221                         &secp_ctx,
5222                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
5223                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
5224                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
5225                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
5226                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
5227
5228                         // These aren't set in the test vectors:
5229                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
5230                         10_000_000,
5231                         [0; 32]
5232                 );
5233
5234                 assert_eq!(signer.pubkeys().funding_pubkey.serialize()[..],
5235                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
5236                 let keys_provider = Keys { signer: signer.clone() };
5237
5238                 let counterparty_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
5239                 let mut config = UserConfig::default();
5240                 config.channel_options.announced_channel = false;
5241                 let mut chan = Channel::<InMemorySigner>::new_outbound(&&feeest, &&keys_provider, counterparty_node_id, 10_000_000, 100000, 42, &config).unwrap(); // Nothing uses their network key in this test
5242                 chan.holder_dust_limit_satoshis = 546;
5243
5244                 let funding_info = OutPoint{ txid: Txid::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), index: 0 };
5245
5246                 let counterparty_pubkeys = ChannelPublicKeys {
5247                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
5248                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
5249                         payment_point: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
5250                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
5251                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
5252                 };
5253                 chan.channel_transaction_parameters.counterparty_parameters = Some(
5254                         CounterpartyChannelTransactionParameters {
5255                                 pubkeys: counterparty_pubkeys.clone(),
5256                                 selected_contest_delay: 144
5257                         });
5258                 chan.channel_transaction_parameters.funding_outpoint = Some(funding_info);
5259                 signer.ready_channel(&chan.channel_transaction_parameters);
5260
5261                 assert_eq!(counterparty_pubkeys.payment_point.serialize()[..],
5262                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
5263
5264                 assert_eq!(counterparty_pubkeys.funding_pubkey.serialize()[..],
5265                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
5266
5267                 assert_eq!(counterparty_pubkeys.htlc_basepoint.serialize()[..],
5268                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
5269
5270                 // We can't just use build_holder_transaction_keys here as the per_commitment_secret is not
5271                 // derived from a commitment_seed, so instead we copy it here and call
5272                 // build_commitment_transaction.
5273                 let delayed_payment_base = &chan.holder_signer.pubkeys().delayed_payment_basepoint;
5274                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
5275                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
5276                 let htlc_basepoint = &chan.holder_signer.pubkeys().htlc_basepoint;
5277                 let keys = TxCreationKeys::derive_new(&secp_ctx, &per_commitment_point, delayed_payment_base, htlc_basepoint, &counterparty_pubkeys.revocation_basepoint, &counterparty_pubkeys.htlc_basepoint).unwrap();
5278
5279                 macro_rules! test_commitment {
5280                         ( $counterparty_sig_hex: expr, $sig_hex: expr, $tx_hex: expr, {
5281                                 $( { $htlc_idx: expr, $counterparty_htlc_sig_hex: expr, $htlc_sig_hex: expr, $htlc_tx_hex: expr } ), *
5282                         } ) => { {
5283                                 let (commitment_tx, htlcs): (_, Vec<HTLCOutputInCommitment>) = {
5284                                         let mut res = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw, &logger);
5285
5286                                         let htlcs = res.2.drain(..)
5287                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
5288                                                 .collect();
5289                                         (res.0, htlcs)
5290                                 };
5291                                 let trusted_tx = commitment_tx.trust();
5292                                 let unsigned_tx = trusted_tx.built_transaction();
5293                                 let redeemscript = chan.get_funding_redeemscript();
5294                                 let counterparty_signature = Signature::from_der(&hex::decode($counterparty_sig_hex).unwrap()[..]).unwrap();
5295                                 let sighash = unsigned_tx.get_sighash_all(&redeemscript, chan.channel_value_satoshis);
5296                                 secp_ctx.verify(&sighash, &counterparty_signature, chan.counterparty_funding_pubkey()).unwrap();
5297
5298                                 let mut per_htlc: Vec<(HTLCOutputInCommitment, Option<Signature>)> = Vec::new();
5299                                 per_htlc.clear(); // Don't warn about excess mut for no-HTLC calls
5300                                 let mut counterparty_htlc_sigs = Vec::new();
5301                                 counterparty_htlc_sigs.clear(); // Don't warn about excess mut for no-HTLC calls
5302                                 $({
5303                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
5304                                         per_htlc.push((htlcs[$htlc_idx].clone(), Some(remote_signature)));
5305                                         counterparty_htlc_sigs.push(remote_signature);
5306                                 })*
5307                                 assert_eq!(htlcs.len(), per_htlc.len());
5308
5309                                 let holder_commitment_tx = HolderCommitmentTransaction::new(
5310                                         commitment_tx.clone(),
5311                                         counterparty_signature,
5312                                         counterparty_htlc_sigs,
5313                                         &chan.holder_signer.pubkeys().funding_pubkey,
5314                                         chan.counterparty_funding_pubkey()
5315                                 );
5316                                 let (holder_sig, htlc_sigs) = signer.sign_holder_commitment_and_htlcs(&holder_commitment_tx, &secp_ctx).unwrap();
5317                                 assert_eq!(Signature::from_der(&hex::decode($sig_hex).unwrap()[..]).unwrap(), holder_sig, "holder_sig");
5318
5319                                 let funding_redeemscript = chan.get_funding_redeemscript();
5320                                 let tx = holder_commitment_tx.add_holder_sig(&funding_redeemscript, holder_sig);
5321                                 assert_eq!(serialize(&tx)[..], hex::decode($tx_hex).unwrap()[..], "tx");
5322
5323                                 // ((htlc, counterparty_sig), (index, holder_sig))
5324                                 let mut htlc_sig_iter = holder_commitment_tx.htlcs().iter().zip(&holder_commitment_tx.counterparty_htlc_sigs).zip(htlc_sigs.iter().enumerate());
5325
5326                                 $({
5327                                         let remote_signature = Signature::from_der(&hex::decode($counterparty_htlc_sig_hex).unwrap()[..]).unwrap();
5328
5329                                         let ref htlc = htlcs[$htlc_idx];
5330                                         let htlc_tx = chan.build_htlc_transaction(&unsigned_tx.txid, &htlc, true, &keys, chan.feerate_per_kw);
5331                                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
5332                                         let htlc_sighash = Message::from_slice(&bip143::SigHashCache::new(&htlc_tx).signature_hash(0, &htlc_redeemscript, htlc.amount_msat / 1000, SigHashType::All)[..]).unwrap();
5333                                         secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.countersignatory_htlc_key).unwrap();
5334
5335                                         let mut preimage: Option<PaymentPreimage> = None;
5336                                         if !htlc.offered {
5337                                                 for i in 0..5 {
5338                                                         let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
5339                                                         if out == htlc.payment_hash {
5340                                                                 preimage = Some(PaymentPreimage([i; 32]));
5341                                                         }
5342                                                 }
5343
5344                                                 assert!(preimage.is_some());
5345                                         }
5346
5347                                         let htlc_sig = htlc_sig_iter.next().unwrap();
5348                                         assert_eq!((htlc_sig.0).0.transaction_output_index, Some($htlc_idx), "output index");
5349
5350                                         let signature = Signature::from_der(&hex::decode($htlc_sig_hex).unwrap()[..]).unwrap();
5351                                         assert_eq!(signature, *(htlc_sig.1).1, "htlc sig");
5352                                         let index = (htlc_sig.1).0;
5353                                         let channel_parameters = chan.channel_transaction_parameters.as_holder_broadcastable();
5354                                         let trusted_tx = holder_commitment_tx.trust();
5355                                         assert_eq!(serialize(&trusted_tx.get_signed_htlc_tx(&channel_parameters, index, &(htlc_sig.0).1, (htlc_sig.1).1, &preimage))[..],
5356                                                         hex::decode($htlc_tx_hex).unwrap()[..], "htlc tx");
5357                                 })*
5358                                 assert!(htlc_sig_iter.next().is_none());
5359                         } }
5360                 }
5361
5362                 // simple commitment tx with no HTLCs
5363                 chan.value_to_self_msat = 7000000000;
5364
5365                 test_commitment!("3045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b0",
5366                                                  "30440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae055647142",
5367                                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48454a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220616210b2cc4d3afb601013c373bbd8aac54febd9f15400379a8cb65ce7deca60022034236c010991beb7ff770510561ae8dc885b8d38d1947248c38f2ae05564714201483045022100c3127b33dcc741dd6b05b1e63cbd1a9a7d816f37af9b6756fa2376b056f032370220408b96279808fe57eb7e463710804cdf4f108388bc5cf722d8c848d2c7f9f3b001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
5368
5369                 chan.pending_inbound_htlcs.push({
5370                         let mut out = InboundHTLCOutput{
5371                                 htlc_id: 0,
5372                                 amount_msat: 1000000,
5373                                 cltv_expiry: 500,
5374                                 payment_hash: PaymentHash([0; 32]),
5375                                 state: InboundHTLCState::Committed,
5376                         };
5377                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
5378                         out
5379                 });
5380                 chan.pending_inbound_htlcs.push({
5381                         let mut out = InboundHTLCOutput{
5382                                 htlc_id: 1,
5383                                 amount_msat: 2000000,
5384                                 cltv_expiry: 501,
5385                                 payment_hash: PaymentHash([0; 32]),
5386                                 state: InboundHTLCState::Committed,
5387                         };
5388                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
5389                         out
5390                 });
5391                 chan.pending_outbound_htlcs.push({
5392                         let mut out = OutboundHTLCOutput{
5393                                 htlc_id: 2,
5394                                 amount_msat: 2000000,
5395                                 cltv_expiry: 502,
5396                                 payment_hash: PaymentHash([0; 32]),
5397                                 state: OutboundHTLCState::Committed,
5398                                 source: HTLCSource::dummy(),
5399                         };
5400                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
5401                         out
5402                 });
5403                 chan.pending_outbound_htlcs.push({
5404                         let mut out = OutboundHTLCOutput{
5405                                 htlc_id: 3,
5406                                 amount_msat: 3000000,
5407                                 cltv_expiry: 503,
5408                                 payment_hash: PaymentHash([0; 32]),
5409                                 state: OutboundHTLCState::Committed,
5410                                 source: HTLCSource::dummy(),
5411                         };
5412                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
5413                         out
5414                 });
5415                 chan.pending_inbound_htlcs.push({
5416                         let mut out = InboundHTLCOutput{
5417                                 htlc_id: 4,
5418                                 amount_msat: 4000000,
5419                                 cltv_expiry: 504,
5420                                 payment_hash: PaymentHash([0; 32]),
5421                                 state: InboundHTLCState::Committed,
5422                         };
5423                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
5424                         out
5425                 });
5426
5427                 // commitment tx with all five HTLCs untrimmed (minimum feerate)
5428                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5429                 chan.feerate_per_kw = 0;
5430
5431                 test_commitment!("3044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e5",
5432                                  "304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea",
5433                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206fc2d1f10ea59951eefac0b4b7c396a3c3d87b71ff0b019796ef4535beaf36f902201765b0181e514d04f4c8ad75659d7037be26cdb3f8bb6f78fe61decef484c3ea01473044022009b048187705a8cbc9ad73adbe5af148c3d012e1f067961486c822c7af08158c022006d66f3704cfab3eb2dc49dae24e4aa22a6910fc9b424007583204e3621af2e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5434
5435                                   { 0,
5436                                   "3045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b",
5437                                   "30440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce",
5438                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b00000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d9e29616b8f3959f1d3d7f7ce893ffedcdc407717d0de8e37d808c91d3a7c50d022078c3033f6d00095c8720a4bc943c1b45727818c082e4e3ddbc6d3116435b624b014730440220636de5682ef0c5b61f124ec74e8aa2461a69777521d6998295dcea36bc3338110220165285594b23c50b28b82df200234566628a27bcd17f7f14404bd865354eb3ce012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
5439
5440                                   { 1,
5441                                   "30440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f896004",
5442                                   "3045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f",
5443                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b01000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220649fe8b20e67e46cbb0d09b4acea87dbec001b39b08dee7bdd0b1f03922a8640022037c462dff79df501cecfdb12ea7f4de91f99230bb544726f6e04527b1f89600401483045022100803159dee7935dba4a1d36a61055ce8fd62caa528573cc221ae288515405a252022029c59e7cffce374fe860100a4a63787e105c3cf5156d40b12dd53ff55ac8cf3f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5444
5445                                   { 2,
5446                                   "30440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d43352",
5447                                   "3045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa",
5448                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b02000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220770fc321e97a19f38985f2e7732dd9fe08d16a2efa4bcbc0429400a447faf49102204d40b417f3113e1b0944ae0986f517564ab4acd3d190503faf97a6e420d4335201483045022100a437cc2ce77400ecde441b3398fea3c3ad8bdad8132be818227fe3c5b8345989022069d45e7fa0ae551ec37240845e2c561ceb2567eacf3076a6a43a502d05865faa012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
5449
5450                                   { 3,
5451                                   "304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c1363",
5452                                   "304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac7487",
5453                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b03000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207bcbf4f60a9829b05d2dbab84ed593e0291836be715dc7db6b72a64caf646af802201e489a5a84f7c5cc130398b841d138d031a5137ac8f4c49c770a4959dc3c13630147304402203121d9b9c055f354304b016a36662ee99e1110d9501cb271b087ddb6f382c2c80220549882f3f3b78d9c492de47543cb9a697cecc493174726146536c5954dac748701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5454
5455                                   { 4,
5456                                   "3044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b87",
5457                                   "3045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95",
5458                                   "02000000000101ab84ff284f162cfbfef241f853b47d4368d171f9e2a1445160cd591c4c7d882b04000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022076dca5cb81ba7e466e349b7128cdba216d4d01659e29b96025b9524aaf0d1899022060de85697b88b21c749702b7d2cfa7dfeaa1f472c8f1d7d9c23f2bf968464b8701483045022100d9080f103cc92bac15ec42464a95f070c7fb6925014e673ee2ea1374d36a7f7502200c65294d22eb20d48564954d5afe04a385551919d8b2ddb4ae2459daaeee1d95012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5459                 } );
5460
5461                 // commitment tx with seven outputs untrimmed (maximum feerate)
5462                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5463                 chan.feerate_per_kw = 647;
5464
5465                 test_commitment!("3045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee",
5466                                  "30450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb7",
5467                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221009ec15c687898bb4da8b3a833e5ab8bfc51ec6e9202aaa8e66611edfd4a85ed1102203d7183e45078b9735c93450bc3415d3e5a8c576141a711ec6ddcb4a893926bb701483045022100a135f9e8a5ed25f7277446c67956b00ce6f610ead2bdec2c2f686155b7814772022059f1f6e1a8b336a68efcc1af3fe4d422d4827332b5b067501b099c47b7b5b5ee01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5468
5469                                   { 0,
5470                                   "30450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f",
5471                                   "30440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b",
5472                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008437627f9ad84ac67052e2a414a4367b8556fd1f94d8b02590f89f50525cd33502205b9c21ff6e7fc864f2352746ad8ba59182510819acb644e25b8a12fc37bbf24f014730440220344b0deb055230d01703e6c7acd45853c4af2328b49b5d8af4f88a060733406602202ea64f2a43d5751edfe75503cbc35a62e3141b5ed032fa03360faf4ca66f670b012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000" },
5473
5474                                   { 1,
5475                                   "304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c",
5476                                   "30450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f",
5477                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe0100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205a67f92bf6845cf2892b48d874ac1daf88a36495cf8a06f93d83180d930a6f75022031da1621d95c3f335cc06a3056cf960199dae600b7cf89088f65fc53cdbef28c014830450221009e5e3822b0185c6799a95288c597b671d6cc69ab80f43740f00c6c3d0752bdda02206da947a74bd98f3175324dc56fdba86cc783703a120a6f0297537e60632f4c7f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5478
5479                                   { 2,
5480                                   "30440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c8",
5481                                   "3045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673",
5482                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220437e21766054a3eef7f65690c5bcfa9920babbc5af92b819f772f6ea96df6c7402207173622024bd97328cfb26c6665e25c2f5d67c319443ccdc60c903217005d8c801483045022100fcfc47e36b712624677626cef3dc1d67f6583bd46926a6398fe6b00b0c9a37760220525788257b187fc775c6370d04eadf34d06f3650a63f8df851cee0ecb47a1673012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
5483
5484                                   { 3,
5485                                   "304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c64",
5486                                   "3045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee",
5487                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207436e10737e4df499fc051686d3e11a5bb2310e4d1f1e691d287cef66514791202207cb58e71a6b7a42dd001b7e3ae672ea4f71ea3e1cd412b742e9124abb0739c6401483045022100e78211b8409afb7255ffe37337da87f38646f1faebbdd61bc1920d69e3ead67a02201a626305adfcd16bfb7e9340928d9b6305464eab4aa4c4a3af6646e9b9f69dee01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5488
5489                                   { 4,
5490                                   "30450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca",
5491                                   "3044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9",
5492                                   "020000000001012cfb3e4788c206881d38f2996b6cb2109b5935acb527d14bdaa7b908afa9b2fe04000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009acd6a827a76bfee50806178dfe0495cd4e1d9c58279c194c7b01520fe68cb8d022024d439047c368883e570997a7d40f0b430cb5a742f507965e7d3063ae3feccca01473044022048762cf546bbfe474f1536365ea7c416e3c0389d60558bc9412cb148fb6ab68202207215d7083b75c96ff9d2b08c59c34e287b66820f530b486a9aa4cdd9c347d5b9012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5493                 } );
5494
5495                 // commitment tx with six outputs untrimmed (minimum feerate)
5496                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5497                 chan.feerate_per_kw = 648;
5498
5499                 test_commitment!("304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e5",
5500                                  "3045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e9",
5501                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4844e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100b15f72908ba3382a34ca5b32519240a22300cc6015b6f9418635fb41f3d01d8802207adb331b9ed1575383dca0f2355e86c173802feecf8298fbea53b9d4610583e90147304402203948f900a5506b8de36a4d8502f94f21dd84fd9c2314ab427d52feaa7a0a19f2022059b6a37a4adaa2c5419dc8aea63c6e2a2ec4c4bde46207f6dc1fcd22152fc6e501475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5502
5503                                   { 0,
5504                                   "3045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e0",
5505                                   "304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec6",
5506                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a031202f3be94678f0e998622ee95ebb6ada8da1e9a5110228b5e04a747351e4022010ca6a21e18314ed53cfaae3b1f51998552a61a468e596368829a50ce40110e00148304502210097e1873b57267730154595187a34949d3744f52933070c74757005e61ce2112e02204ecfba2aa42d4f14bdf8bad4206bb97217b702e6c433e0e1b0ce6587e6d46ec601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5507
5508                                   { 1,
5509                                   "304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d384124",
5510                                   "3044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae",
5511                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402202361012a634aee7835c5ecdd6413dcffa8f404b7e77364c792cff984e4ee71e90220715c5e90baa08daa45a7439b1ee4fa4843ed77b19c058240b69406606d38412401473044022019de73b00f1d818fb388e83b2c8c31f6bce35ac624e215bc12f88f9dc33edf48022006ff814bb9f700ee6abc3294e146fac3efd4f13f0005236b41c0a946ee00c9ae012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
5512
5513                                   { 2,
5514                                   "304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc625532989",
5515                                   "3045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e2260796",
5516                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e8e82cd71ed4febeb593732c260456836e97d81896153ecd2b3cf320ca6861702202dd4a30f68f98ced7cc56a36369ac1fdd978248c5ff4ed204fc00cc62553298901483045022100bd0be6100c4fd8f102ec220e1b053e4c4e2ecca25615490150007b40d314dc3902201a1e0ea266965b43164d9e6576f58fa6726d42883dd1c3996d2925c2e226079601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5517
5518                                   { 3,
5519                                   "3044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be",
5520                                   "3045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6",
5521                                   "020000000001010f44041fdfba175987cf4e6135ba2a154e3b7fb96483dc0ed5efc0678e5b6bf103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022024cd52e4198c8ae0e414a86d86b5a65ea7450f2eb4e783096736d93395eca5ce022078f0094745b45be4d4b2b04dd5978c9e66ba49109e5704403e84aaf5f387d6be01483045022100bbfb9d0a946d420807c86e985d636cceb16e71c3694ed186316251a00cbd807202207773223f9a337e145f64673825be9b30d07ef1542c82188b264bedcf7cda78c6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5522                 } );
5523
5524                 // commitment tx with six outputs untrimmed (maximum feerate)
5525                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5526                 chan.feerate_per_kw = 2069;
5527
5528                 test_commitment!("304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc",
5529                                  "3045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e33",
5530                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48477956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100ad9a9bbbb75d506ca3b716b336ee3cf975dd7834fcf129d7dd188146eb58a8b4022061a759ee417339f7fe2ea1e8deb83abb6a74db31a09b7648a932a639cda23e330148304502210090b96a2498ce0c0f2fadbec2aab278fed54c1a7838df793ec4d2c78d96ec096202204fdd439c50f90d483baa7b68feeef4bd33bc277695405447bcd0bfb2ca34d7bc01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5531
5532                                   { 0,
5533                                   "3045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f699",
5534                                   "3045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d",
5535                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f33513ee38abf1c582876f921f8fddc06acff48e04515532a32d3938de938ffd02203aa308a2c1863b7d6fdf53159a1465bf2e115c13152546cc5d74483ceaa7f69901483045022100a637902a5d4c9ba9e7c472a225337d5aac9e2e3f6744f76e237132e7619ba0400220035c60d784a031c0d9f6df66b7eab8726a5c25397399ee4aa960842059eb3f9d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5536
5537                                   { 1,
5538                                   "3045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df",
5539                                   "3045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61",
5540                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ce07682cf4b90093c22dc2d9ab2a77ad6803526b655ef857221cc96af5c9e0bf02200f501cee22e7a268af40b555d15a8237c9f36ad67ef1841daf9f6a0267b1e6df01483045022100e57e46234f8782d3ff7aa593b4f7446fb5316c842e693dc63ee324fd49f6a1c302204a2f7b44c48bd26e1554422afae13153eb94b29d3687b733d18930615fb2db61012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
5541
5542                                   { 2,
5543                                   "3045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e0",
5544                                   "3044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c18",
5545                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e3e35492e55f82ec0bc2f317ffd7a486d1f7024330fe9743c3559fc39f32ef0c02203d1d4db651fc388a91d5ad8ecdd8e83673063bc8eefe27cfd8c189090e3a23e001473044022068613fb1b98eb3aec7f44c5b115b12343c2f066c4277c82b5f873dfe68f37f50022028109b4650f3f528ca4bfe9a467aff2e3e43893b61b5159157119d5d95cf1c1801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5546
5547                                   { 3,
5548                                   "304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df",
5549                                   "3045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33",
5550                                   "02000000000101adbe717a63fb658add30ada1e6e12ed257637581898abe475c11d7bbcd65bd4d03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207475aeb0212ef9bf5130b60937817ad88c9a87976988ef1f323f026148cc4a850220739fea17ad3257dcad72e509c73eebe86bee30b178467b9fdab213d631b109df01483045022100d315522e09e7d53d2a659a79cb67fef56d6c4bddf3f46df6772d0d20a7beb7c8022070bcc17e288607b6a72be0bd83368bb6d53488db266c1cdb4d72214e4f02ac33012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5551                 } );
5552
5553                 // commitment tx with five outputs untrimmed (minimum feerate)
5554                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5555                 chan.feerate_per_kw = 2070;
5556
5557                 test_commitment!("304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c",
5558                                  "3044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c1",
5559                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022001014419b5ba00e083ac4e0a85f19afc848aacac2d483b4b525d15e2ae5adbfe022015ebddad6ee1e72b47cb09f3e78459da5be01ccccd95dceca0e056a00cc773c10147304402204ca1ba260dee913d318271d86e10ca0f5883026fb5653155cff600fb40895223022037b145204b7054a40e08bb1fefbd826f827b40838d3e501423bcc57924bcb50c01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5560
5561                                   { 0,
5562                                   "304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b",
5563                                   "30440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e5",
5564                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff0000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402205f6b6d12d8d2529fb24f4445630566cf4abbd0f9330ab6c2bdb94222d6a2a0c502202f556258ae6f05b193749e4c541dfcc13b525a5422f6291f073f15617ba8579b014730440220150b11069454da70caf2492ded9e0065c9a57f25ac2a4c52657b1d15b6c6ed85022068a38833b603c8892717206383611bad210f1cbb4b1f87ea29c6c65b9e1cb3e501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5565
5566                                   { 1,
5567                                   "3045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546",
5568                                   "30450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c6",
5569                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f960dfb1c9aee7ce1437efa65b523e399383e8149790e05d8fed27ff6e42fe0002202fe8613e062ffe0b0c518cc4101fba1c6de70f64a5bcc7ae663f2efae43b8546014830450221009a6ed18e6873bc3644332a6ee21c152a5b102821865350df7a8c74451a51f9f2022050d801fb4895d7d7fbf452824c0168347f5c0cbe821cf6a97a63af5b8b2563c601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5570
5571                                   { 2,
5572                                   "3045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504",
5573                                   "30440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502",
5574                                   "02000000000101403ad7602b43293497a3a2235a12ecefda4f3a1f1d06e49b1786d945685de1ff02000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ae5fc7717ae684bc1fcf9020854e5dbe9842c9e7472879ac06ff95ac2bb10e4e022057728ada4c00083a3e65493fb5d50a232165948a1a0f530ef63185c2c8c56504014730440220408ad3009827a8fccf774cb285587686bfb2ed041f89a89453c311ce9c8ee0f902203c7392d9f8306d3a46522a66bd2723a7eb2628cb2d9b34d4c104f1766bf37502012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5575                 } );
5576
5577                 // commitment tx with five outputs untrimmed (maximum feerate)
5578                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5579                 chan.feerate_per_kw = 2194;
5580
5581                 test_commitment!("304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb3",
5582                                  "3044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d398",
5583                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e48440966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022072c2e2b1c899b2242656a537dde2892fa3801be0d6df0a87836c550137acde8302201654aa1974d37a829083c3ba15088689f30b56d6a4f6cb14c7bad0ee3116d3980147304402204bb3d6e279d71d9da414c82de42f1f954267c762b2e2eb8b76bc3be4ea07d4b0022014febc009c5edc8c3fc5d94015de163200f780046f1c293bfed8568f08b70fb301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5584
5585                                   { 0,
5586                                   "3045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de8450",
5587                                   "304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e0154301",
5588                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100939726680351a7856c1bc386d4a1f422c7d29bd7b56afc139570f508474e6c40022023175a799ccf44c017fbaadb924c40b2a12115a5b7d0dfd3228df803a2de84500148304502210099c98c2edeeee6ec0fb5f3bea8b79bb016a2717afa9b5072370f34382de281d302206f5e2980a995e045cf90a547f0752a7ee99d48547bc135258fe7bc07e015430101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000" },
5589
5590                                   { 1,
5591                                   "3044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a0",
5592                                   "3045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b77",
5593                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022021bb883bf324553d085ba2e821cad80c28ef8b303dbead8f98e548783c02d1600220638f9ef2a9bba25869afc923f4b5dc38be3bb459f9efa5d869392d5f7779a4a001483045022100fd85bd7697b89c08ec12acc8ba89b23090637d83abd26ca37e01ae93e67c367302202b551fe69386116c47f984aab9c8dfd25d864dcde5d3389cfbef2447a85c4b7701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5594
5595                                   { 2,
5596                                   "3045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b",
5597                                   "30450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3",
5598                                   "02000000000101153cd825fdb3aa624bfe513e8031d5d08c5e582fb3d1d1fe8faf27d3eed410cd020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9e6f0454aa598b905a35e641a70cc9f67b5f38cc4b00843a041238c4a9f1c4a0220260a2822a62da97e44583e837245995ca2e36781769c52f19e498efbdcca262b014830450221008a9f2ea24cd455c2b64c1472a5fa83865b0a5f49a62b661801e884cf2849af8302204d44180e50bf6adfcf1c1e581d75af91aba4e28681ce4a5ee5f3cbf65eca10f3012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5599                 } );
5600
5601                 // commitment tx with four outputs untrimmed (minimum feerate)
5602                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5603                 chan.feerate_per_kw = 2195;
5604
5605                 test_commitment!("304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce403",
5606                                  "3044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d1767",
5607                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022044d592025b610c0d678f65032e87035cdfe89d1598c522cc32524ae8172417c30220749fef9d5b2ae8cdd91ece442ba8809bc891efedae2291e578475f97715d17670147304402201a8c1b1f9671cd9e46c7323a104d7047cc48d3ee80d40d4512e0c72b8dc65666022066d7f9a2ce18c9eb22d2739ffcce05721c767f9b607622a31b6ea5793ddce40301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5608
5609                                   { 0,
5610                                   "3045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e",
5611                                   "3045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d76",
5612                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e57b845066a06ee7c2cbfc29eabffe52daa9bf6f6de760066d04df9f9b250e0002202ffb197f0e6e0a77a75a9aff27014bd3de83b7f748d7efef986abe655e1dd50e01483045022100ecc8c6529d0b2316d046f0f0757c1e1c25a636db168ec4f3aa1b9278df685dc0022067ae6b65e936f1337091f7b18a15935b608c5f2cdddb2f892ed0babfdd376d7601008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5613
5614                                   { 1,
5615                                   "3045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a",
5616                                   "3044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82",
5617                                   "020000000001018130a10f09b13677ba2885a8bca32860f3a952e5912b829a473639b5a2c07b900100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d193b7ecccad8057571620a0b1ffa6c48e9483311723b59cf536043b20bc51550220546d4bd37b3b101ecda14f6c907af46ec391abce1cd9c7ce22b1a62b534f2f2a01473044022014d66f11f9cacf923807eba49542076c5fe5cccf252fb08fe98c78ef3ca6ab5402201b290dbe043cc512d9d78de074a5a129b8759bc6a6c546b190d120b690bd6e82012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5618                 } );
5619
5620                 // commitment tx with four outputs untrimmed (maximum feerate)
5621                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5622                 chan.feerate_per_kw = 3702;
5623
5624                 test_commitment!("304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee40169",
5625                                  "3045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf75",
5626                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4846f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100e5efb73c32d32da2d79702299b6317de6fb24a60476e3855926d78484dd1b3c802203557cb66a42c944ef06e00bcc4da35a5bcb2f185aab0f8e403e519e1d66aaf750148304502210092a587aeb777f869e7ff0d7898ea619ee26a3dacd1f3672b945eea600be431100220077ee9eae3528d15251f2a52b607b189820e57a6ccfac8d1af502b132ee4016901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5627
5628                                   { 0,
5629                                   "304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb89",
5630                                   "304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f",
5631                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206fa54c11f98c3bae1e93df43fc7affeb05b476bf8060c03e29c377c69bc08e8b0220672701cce50d5c379ff45a5d2cfe48ac44973adb066ac32608e21221d869bb890147304402206e36c683ebf2cb16bcef3d5439cf8b53cd97280a365ed8acd7abb85a8ba5f21c02206e8621edfc2a5766cbc96eb67fd501127ff163eb6b85518a39f7d4974aef126f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000" },
5632
5633                                   { 1,
5634                                   "3044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb5817",
5635                                   "304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc",
5636                                   "020000000001018db483bff65c70ee71d8282aeec5a880e2e2b39e45772bda5460403095c62e3f0100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022057649739b0eb74d541ead0dfdb3d4b2c15aa192720031044c3434c67812e5ca902201e5ede42d960ae551707f4a6b34b09393cf4dee2418507daa022e3550dbb58170147304402207faad26678c8850e01b4a0696d60841f7305e1832b786110ee9075cb92ed14a30220516ef8ee5dfa80824ea28cbcec0dd95f8b847146257c16960db98507db15ffdc012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5637                 } );
5638
5639                 // commitment tx with three outputs untrimmed (minimum feerate)
5640                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5641                 chan.feerate_per_kw = 3703;
5642
5643                 test_commitment!("3045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e",
5644                                  "304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e1",
5645                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402201b736d1773a124c745586217a75bed5f66c05716fbe8c7db4fdb3c3069741cdd02205083f39c321c1bcadfc8d97e3c791a66273d936abac0c6a2fde2ed46019508e101483045022100b495d239772a237ff2cf354b1b11be152fd852704cb184e7356d13f2fb1e5e430220723db5cdb9cbd6ead7bfd3deb419cf41053a932418cbb22a67b581f40bc1f13e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5646
5647                                   { 0,
5648                                   "3045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a",
5649                                   "3045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05",
5650                                   "0200000000010120060e4a29579d429f0f27c17ee5f1ee282f20d706d6f90b63d35946d8f3029a0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c34c61735f93f2e324cc873c3b248111ccf8f6db15d5969583757010d4ad2b4602207867bb919b2ddd6387873e425345c9b7fd18d1d66aba41f3607bc2896ef3c30a01483045022100988c143e2110067117d2321bdd4bd16ca1734c98b29290d129384af0962b634e02206c1b02478878c5f547018b833986578f90c3e9be669fe5788ad0072a55acbb05012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5651                 } );
5652
5653                 // commitment tx with three outputs untrimmed (maximum feerate)
5654                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5655                 chan.feerate_per_kw = 4914;
5656
5657                 test_commitment!("3045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c95244",
5658                                  "3045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c19",
5659                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100d72638bc6308b88bb6d45861aae83e5b9ff6e10986546e13bce769c70036e2620220320be7c6d66d22f30b9fcd52af66531505b1310ca3b848c19285b38d8a1a8c1901483045022100b4b16d5f8cc9fc4c1aff48831e832a0d8990e133978a66e302c133550954a44d022073573ce127e2200d316f6b612803a5c0c97b8d20e1e44dbe2ac0dd2fb8c9524401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5660
5661                                   { 0,
5662                                   "3045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374",
5663                                   "30440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10",
5664                                   "02000000000101a9172908eace869cc35128c31fc2ab502f72e4dff31aab23e0244c4b04b11ab00000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100f43591c156038ba217756006bb3c55f7d113a325cdd7d9303c82115372858d68022016355b5aadf222bc8d12e426c75f4a03423917b2443a103eb2a498a3a2234374014730440220585dee80fafa264beac535c3c0bb5838ac348b156fdc982f86adc08dfc9bfd250220130abb82f9f295cc9ef423dcfef772fde2acd85d9df48cc538981d26a10a9c10012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000" }
5665                 } );
5666
5667                 // commitment tx with two outputs untrimmed (minimum feerate)
5668                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5669                 chan.feerate_per_kw = 4915;
5670
5671                 test_commitment!("304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a720",
5672                                  "30450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf5",
5673                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004830450221008a953551f4d67cb4df3037207fc082ddaf6be84d417b0bd14c80aab66f1b01a402207508796dc75034b2dee876fe01dc05a08b019f3e5d689ac8842ade2f1befccf50147304402203a286936e74870ca1459c700c71202af0381910a6bfab687ef494ef1bc3e02c902202506c362d0e3bee15e802aa729bf378e051644648253513f1c085b264cc2a72001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
5674
5675                 // commitment tx with two outputs untrimmed (maximum feerate)
5676                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5677                 chan.feerate_per_kw = 9651180;
5678
5679                 test_commitment!("304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd3",
5680                                  "3045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de",
5681                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e4840400483045022100e11b638c05c650c2f63a421d36ef8756c5ce82f2184278643520311cdf50aa200220259565fb9c8e4a87ccaf17f27a3b9ca4f20625754a0920d9c6c239d8156a11de0147304402200a8544eba1d216f5c5e530597665fa9bec56943c0f66d98fc3d028df52d84f7002201e45fa5c6bc3a506cc2553e7d1c0043a9811313fc39c954692c0d47cfce2bbd301475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
5682
5683                 // commitment tx with one output untrimmed (minimum feerate)
5684                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5685                 chan.feerate_per_kw = 9651181;
5686
5687                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
5688                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
5689                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
5690
5691                 // commitment tx with fee greater than funder amount
5692                 chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
5693                 chan.feerate_per_kw = 9651936;
5694
5695                 test_commitment!("304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a2",
5696                                  "304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a379",
5697                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484040047304402207e8d51e0c570a5868a78414f4e0cbfaed1106b171b9581542c30718ee4eb95ba02203af84194c97adf98898c9afe2f2ed4a7f8dba05a2dfab28ac9d9c604aa49a3790147304402202ade0142008309eb376736575ad58d03e5b115499709c6db0b46e36ff394b492022037b63d78d66404d6504d4c4ac13be346f3d1802928a6d3ad95a6a944227161a201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {});
5698
5699                 // commitment tx with 3 htlc outputs, 2 offered having the same amount and preimage
5700                 chan.value_to_self_msat = 7_000_000_000 - 2_000_000;
5701                 chan.feerate_per_kw = 253;
5702                 chan.pending_inbound_htlcs.clear();
5703                 chan.pending_inbound_htlcs.push({
5704                         let mut out = InboundHTLCOutput{
5705                                 htlc_id: 1,
5706                                 amount_msat: 2000000,
5707                                 cltv_expiry: 501,
5708                                 payment_hash: PaymentHash([0; 32]),
5709                                 state: InboundHTLCState::Committed,
5710                         };
5711                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
5712                         out
5713                 });
5714                 chan.pending_outbound_htlcs.clear();
5715                 chan.pending_outbound_htlcs.push({
5716                         let mut out = OutboundHTLCOutput{
5717                                 htlc_id: 6,
5718                                 amount_msat: 5000000,
5719                                 cltv_expiry: 506,
5720                                 payment_hash: PaymentHash([0; 32]),
5721                                 state: OutboundHTLCState::Committed,
5722                                 source: HTLCSource::dummy(),
5723                         };
5724                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
5725                         out
5726                 });
5727                 chan.pending_outbound_htlcs.push({
5728                         let mut out = OutboundHTLCOutput{
5729                                 htlc_id: 5,
5730                                 amount_msat: 5000000,
5731                                 cltv_expiry: 505,
5732                                 payment_hash: PaymentHash([0; 32]),
5733                                 state: OutboundHTLCState::Committed,
5734                                 source: HTLCSource::dummy(),
5735                         };
5736                         out.payment_hash.0 = Sha256::hash(&hex::decode("0505050505050505050505050505050505050505050505050505050505050505").unwrap()).into_inner();
5737                         out
5738                 });
5739
5740                 test_commitment!("30440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df9",
5741                                  "3045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f",
5742                                  "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2d8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121b8813000000000000220020305c12e1a0bc21e283c131cea1c66d68857d28b7b2fce0a6fbc40c164852121bc0c62d0000000000160014cc1b07838e387deacd0e5232e1e8b49f4c29e484a79f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100c4f1d60b6fca9febc8b39de1a31e84c5f7c4b41c97239ef05f4350aa484c6b5e02200c5134ac8b20eb7a29d0dd4a501f6aa8fefb8489171f4cb408bd2a32324ab03f014730440220048705bec5288d28b3f29344b8d124853b1af423a568664d2c6f02c8ea886525022060f998a461052a2476b912db426ea2a06700953a241135c7957f2e79bc222df901475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220", {
5743
5744                                   { 0,
5745                                   "304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c6",
5746                                   "304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c",
5747                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc34000000000000000000011f070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050048304502210081cbb94121761d34c189cd4e6a281feea6f585060ad0ba2632e8d6b3c6bb8a6c02201007981bbd16539d63df2805b5568f1f5688cd2a885d04706f50db9b77ba13c60148304502210090ed76aeb21b53236a598968abc66e2024691d07b62f53ddbeca8f93144af9c602205f873af5a0c10e62690e9aba09740550f194a9dc455ba4c1c23f6cde7704674c012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000" },
5748                                   { 1,
5749                                   "304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5",
5750                                   "30450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d39",
5751                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3401000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201d0f09d2bf7bc245a4f17980e1e9164290df16c70c6a2ff1592f5030d6108581022061e744a7dc151b36bf0aff7a4f1812ba90b8b03633bb979a270d19858fd960c5014830450221009aef000d2e843a4202c1b1a2bf554abc9a7902bf49b2cb0759bc507456b7ebad02204e7c3d193ede2fd2b4cd6b39f51a920e581e35575e357e44d7b699c40ce61d3901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868f9010000" },
5752                                   { 2,
5753                                   "30440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f",
5754                                   "30440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e511",
5755                                   "0200000000010189a326e23addc28323dbadcb4e71c2c17088b6e8fa184103e552f44075dddc3402000000000000000001e1120000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220010bf035d5823596e50dce2076a4d9f942d8d28031c9c428b901a02b6b8140de02203250e8e4a08bc5b4ecdca4d0eedf98223e02e3ac1c0206b3a7ffdb374aa21e5f014730440220073de0067b88e425b3018b30366bfeda0ccb703118ccd3d02ead08c0f53511d002203fac50ac0e4cf8a3af0b4b1b12e801650591f748f8ddf1e089c160f10b69e51101008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9142002cc93ebefbb1b73f0af055dcc27a0b504ad7688ac6868fa010000" }
5756                 } );
5757         }
5758
5759         #[test]
5760         fn test_per_commitment_secret_gen() {
5761                 // Test vectors from BOLT 3 Appendix D:
5762
5763                 let mut seed = [0; 32];
5764                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
5765                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
5766                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
5767
5768                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
5769                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
5770                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
5771
5772                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
5773                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
5774
5775                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
5776                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
5777
5778                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
5779                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
5780                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
5781         }
5782
5783         #[test]
5784         fn test_key_derivation() {
5785                 // Test vectors from BOLT 3 Appendix E:
5786                 let secp_ctx = Secp256k1::new();
5787
5788                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
5789                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
5790
5791                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
5792                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
5793
5794                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
5795                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
5796
5797                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
5798                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
5799
5800                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
5801                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
5802
5803                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
5804                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
5805
5806                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
5807                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
5808         }
5809 }