_ Git - rust-lightning/blob - lightning/src/ln/channel.rs

   1 use bitcoin::blockdata::block::BlockHeader;
   2 use bitcoin::blockdata::script::{Script,Builder};
   3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
   4 use bitcoin::blockdata::opcodes;
   5 use bitcoin::util::hash::BitcoinHash;
   6 use bitcoin::util::bip143;
   7 use bitcoin::consensus::encode;
   8
   9 use bitcoin_hashes::{Hash, HashEngine};
  10 use bitcoin_hashes::sha256::Hash as Sha256;
  11 use bitcoin_hashes::hash160::Hash as Hash160;
  12 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
  13
  14 use secp256k1::key::{PublicKey,SecretKey};
  15 use secp256k1::{Secp256k1,Signature};
  16 use secp256k1;
  17
  18 use ln::features::{ChannelFeatures, InitFeatures};
  19 use ln::msgs;
  20 use ln::msgs::{DecodeError, OptionalField, DataLossProtect};
  21 use ln::channelmonitor::{ChannelMonitor, ChannelMonitorUpdate, ChannelMonitorUpdateStep};
  22 use ln::channelmanager::{PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingHTLCInfo, RAACommitmentOrder, PaymentPreimage, PaymentHash, BREAKDOWN_TIMEOUT, MAX_LOCAL_BREAKDOWN_TIMEOUT};
  23 use ln::chan_utils::{CounterpartyCommitmentSecrets, LocalCommitmentTransaction, TxCreationKeys, HTLCOutputInCommitment, HTLC_SUCCESS_TX_WEIGHT, HTLC_TIMEOUT_TX_WEIGHT, make_funding_redeemscript, ChannelPublicKeys};
  24 use ln::chan_utils;
  25 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
  26 use chain::transaction::OutPoint;
  27 use chain::keysinterface::{ChannelKeys, KeysInterface};
  28 use util::transaction_utils;
  29 use util::ser::{Readable, ReadableArgs, Writeable, Writer};
  30 use util::logger::{Logger, LogHolder};
  31 use util::errors::APIError;
  32 use util::config::{UserConfig,ChannelConfig};
  33
  34 use std;
  35 use std::default::Default;
  36 use std::{cmp,mem,fmt};
  37 use std::sync::{Arc};
  38 use std::ops::Deref;
  39
  40 #[cfg(test)]
  41 pub struct ChannelValueStat {
  42         pub value_to_self_msat: u64,
  43         pub channel_value_msat: u64,
  44         pub channel_reserve_msat: u64,
  45         pub pending_outbound_htlcs_amount_msat: u64,
  46         pub pending_inbound_htlcs_amount_msat: u64,
  47         pub holding_cell_outbound_amount_msat: u64,
  48         pub their_max_htlc_value_in_flight_msat: u64, // outgoing
  49 }
  50
  51 enum InboundHTLCRemovalReason {
  52         FailRelay(msgs::OnionErrorPacket),
  53         FailMalformed(([u8; 32], u16)),
  54         Fulfill(PaymentPreimage),
  55 }
  56
  57 enum InboundHTLCState {
  58         /// Added by remote, to be included in next local commitment tx.
  59         RemoteAnnounced(PendingHTLCStatus),
  60         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
  61         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
  62         /// accept this HTLC. Implies AwaitingRemoteRevoke.
  63         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
  64         /// a remote revoke_and_ack on a previous state before we can do so.
  65         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
  66         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
  67         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
  68         /// accept this HTLC. Implies AwaitingRemoteRevoke.
  69         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
  70         /// revoke_and_ack.
  71         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
  72         Committed,
  73         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
  74         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
  75         /// we'll drop it.
  76         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
  77         /// commitment transaction without it as otherwise we'll have to force-close the channel to
  78         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
  79         /// anyway). That said, ChannelMonitor does this for us (see
  80         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
  81         /// local state before then, once we're sure that the next commitment_signed and
  82         /// ChannelMonitor::provide_latest_local_commitment_tx_info will not include this HTLC.
  83         LocalRemoved(InboundHTLCRemovalReason),
  84 }
  85
  86 struct InboundHTLCOutput {
  87         htlc_id: u64,
  88         amount_msat: u64,
  89         cltv_expiry: u32,
  90         payment_hash: PaymentHash,
  91         state: InboundHTLCState,
  92 }
  93
  94 enum OutboundHTLCState {
  95         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
  96         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
  97         /// we will promote to Committed (note that they may not accept it until the next time we
  98         /// revoke, but we don't really care about that:
  99         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
 100         ///    money back (though we won't), and,
 101         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
 102         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
 103         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
 104         ///    we'll never get out of sync).
 105         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
 106         /// OutboundHTLCOutput's size just for a temporary bit
 107         LocalAnnounced(Box<msgs::OnionPacket>),
 108         Committed,
 109         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
 110         /// the change (though they'll need to revoke before we fail the payment).
 111         RemoteRemoved(Option<HTLCFailReason>),
 112         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 113         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 114         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 115         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
 116         /// remote revoke_and_ack on a previous state before we can do so.
 117         AwaitingRemoteRevokeToRemove(Option<HTLCFailReason>),
 118         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 119         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 120         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 121         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
 122         /// revoke_and_ack to drop completely.
 123         AwaitingRemovedRemoteRevoke(Option<HTLCFailReason>),
 124 }
 125
 126 struct OutboundHTLCOutput {
 127         htlc_id: u64,
 128         amount_msat: u64,
 129         cltv_expiry: u32,
 130         payment_hash: PaymentHash,
 131         state: OutboundHTLCState,
 132         source: HTLCSource,
 133 }
 134
 135 /// See AwaitingRemoteRevoke ChannelState for more info
 136 enum HTLCUpdateAwaitingACK {
 137         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
 138                 // always outbound
 139                 amount_msat: u64,
 140                 cltv_expiry: u32,
 141                 payment_hash: PaymentHash,
 142                 source: HTLCSource,
 143                 onion_routing_packet: msgs::OnionPacket,
 144         },
 145         ClaimHTLC {
 146                 payment_preimage: PaymentPreimage,
 147                 htlc_id: u64,
 148         },
 149         FailHTLC {
 150                 htlc_id: u64,
 151                 err_packet: msgs::OnionErrorPacket,
 152         },
 153 }
 154
 155 /// There are a few "states" and then a number of flags which can be applied:
 156 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
 157 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
 158 /// move on to ChannelFunded.
 159 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
 160 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
 161 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
 162 enum ChannelState {
 163         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
 164         OurInitSent = (1 << 0),
 165         /// Implies we have received their open_channel/accept_channel message
 166         TheirInitSent = (1 << 1),
 167         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
 168         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
 169         /// upon receipt of funding_created, so simply skip this state.
 170         FundingCreated = 4,
 171         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
 172         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
 173         /// and our counterparty consider the funding transaction confirmed.
 174         FundingSent = 8,
 175         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
 176         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 177         TheirFundingLocked = (1 << 4),
 178         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
 179         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 180         OurFundingLocked = (1 << 5),
 181         ChannelFunded = 64,
 182         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
 183         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
 184         /// dance.
 185         PeerDisconnected = (1 << 7),
 186         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
 187         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
 188         /// outbound messages until they've managed to do so.
 189         MonitorUpdateFailed = (1 << 8),
 190         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
 191         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
 192         /// messages as then we will be unable to determine which HTLCs they included in their
 193         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
 194         /// later.
 195         /// Flag is set on ChannelFunded.
 196         AwaitingRemoteRevoke = (1 << 9),
 197         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
 198         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
 199         /// to respond with our own shutdown message when possible.
 200         RemoteShutdownSent = (1 << 10),
 201         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
 202         /// point, we may not add any new HTLCs to the channel.
 203         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
 204         /// us their shutdown.
 205         LocalShutdownSent = (1 << 11),
 206         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
 207         /// to drop us, but we store this anyway.
 208         ShutdownComplete = 4096,
 209 }
 210 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
 211 const MULTI_STATE_FLAGS: u32 = (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32);
 212
 213 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
 214
 215 /// Liveness is called to fluctuate given peer disconnecton/monitor failures/closing.
 216 /// If channel is public, network should have a liveness view announced by us on a
 217 /// best-effort, which means we may filter out some status transitions to avoid spam.
 218 /// See further timer_chan_freshness_every_min.
 219 #[derive(PartialEq)]
 220 enum UpdateStatus {
 221         /// Status has been gossiped.
 222         Fresh,
 223         /// Status has been changed.
 224         DisabledMarked,
 225         /// Status has been marked to be gossiped at next flush
 226         DisabledStaged,
 227 }
 228
 229 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
 230 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
 231 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
 232 // inbound channel.
 233 pub(super) struct Channel<ChanSigner: ChannelKeys> {
 234         config: ChannelConfig,
 235
 236         user_id: u64,
 237
 238         channel_id: [u8; 32],
 239         channel_state: u32,
 240         channel_outbound: bool,
 241         secp_ctx: Secp256k1<secp256k1::All>,
 242         channel_value_satoshis: u64,
 243
 244         latest_monitor_update_id: u64,
 245
 246         #[cfg(not(test))]
 247         local_keys: ChanSigner,
 248         #[cfg(test)]
 249         pub(super) local_keys: ChanSigner,
 250         shutdown_pubkey: PublicKey,
 251         destination_script: Script,
 252
 253         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
 254         // generation start at 0 and count up...this simplifies some parts of implementation at the
 255         // cost of others, but should really just be changed.
 256
 257         cur_local_commitment_transaction_number: u64,
 258         cur_remote_commitment_transaction_number: u64,
 259         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
 260         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
 261         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
 262         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
 263
 264         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
 265         /// need to ensure we resend them in the order we originally generated them. Note that because
 266         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
 267         /// sufficient to simply set this to the opposite of any message we are generating as we
 268         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
 269         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
 270         /// send it first.
 271         resend_order: RAACommitmentOrder,
 272
 273         monitor_pending_funding_locked: bool,
 274         monitor_pending_revoke_and_ack: bool,
 275         monitor_pending_commitment_signed: bool,
 276         monitor_pending_forwards: Vec<(PendingHTLCInfo, u64)>,
 277         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
 278
 279         // pending_update_fee is filled when sending and receiving update_fee
 280         // For outbound channel, feerate_per_kw is updated with the value from
 281         // pending_update_fee when revoke_and_ack is received
 282         //
 283         // For inbound channel, feerate_per_kw is updated when it receives
 284         // commitment_signed and revoke_and_ack is generated
 285         // The pending value is kept when another pair of update_fee and commitment_signed
 286         // is received during AwaitingRemoteRevoke and relieved when the expected
 287         // revoke_and_ack is received and new commitment_signed is generated to be
 288         // sent to the funder. Otherwise, the pending value is removed when receiving
 289         // commitment_signed.
 290         pending_update_fee: Option<u64>,
 291         // update_fee() during ChannelState::AwaitingRemoteRevoke is hold in
 292         // holdina_cell_update_fee then moved to pending_udpate_fee when revoke_and_ack
 293         // is received. holding_cell_update_fee is updated when there are additional
 294         // update_fee() during ChannelState::AwaitingRemoteRevoke.
 295         holding_cell_update_fee: Option<u64>,
 296         next_local_htlc_id: u64,
 297         next_remote_htlc_id: u64,
 298         update_time_counter: u32,
 299         feerate_per_kw: u64,
 300
 301         #[cfg(debug_assertions)]
 302         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
 303         max_commitment_tx_output_local: ::std::sync::Mutex<(u64, u64)>,
 304         #[cfg(debug_assertions)]
 305         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
 306         max_commitment_tx_output_remote: ::std::sync::Mutex<(u64, u64)>,
 307
 308         last_sent_closing_fee: Option<(u64, u64, Signature)>, // (feerate, fee, our_sig)
 309
 310         funding_txo: Option<OutPoint>,
 311
 312         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
 313         /// to detect unconfirmation after a serialize-unserialize roundtrip where we may not see a full
 314         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
 315         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
 316         funding_tx_confirmed_in: Option<Sha256dHash>,
 317         short_channel_id: Option<u64>,
 318         /// Used to deduplicate block_connected callbacks, also used to verify consistency during
 319         /// ChannelManager deserialization (hence pub(super))
 320         pub(super) last_block_connected: Sha256dHash,
 321         funding_tx_confirmations: u64,
 322
 323         their_dust_limit_satoshis: u64,
 324         #[cfg(test)]
 325         pub(super) our_dust_limit_satoshis: u64,
 326         #[cfg(not(test))]
 327         our_dust_limit_satoshis: u64,
 328         #[cfg(test)]
 329         pub(super) their_max_htlc_value_in_flight_msat: u64,
 330         #[cfg(not(test))]
 331         their_max_htlc_value_in_flight_msat: u64,
 332         //get_our_max_htlc_value_in_flight_msat(): u64,
 333         /// minimum channel reserve for **self** to maintain - set by them.
 334         their_channel_reserve_satoshis: u64,
 335         //get_our_channel_reserve_satoshis(): u64,
 336         their_htlc_minimum_msat: u64,
 337         our_htlc_minimum_msat: u64,
 338         their_to_self_delay: u16,
 339         our_to_self_delay: u16,
 340         #[cfg(test)]
 341         pub their_max_accepted_htlcs: u16,
 342         #[cfg(not(test))]
 343         their_max_accepted_htlcs: u16,
 344         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
 345         minimum_depth: u32,
 346
 347         their_pubkeys: Option<ChannelPublicKeys>,
 348
 349         their_cur_commitment_point: Option<PublicKey>,
 350
 351         their_prev_commitment_point: Option<PublicKey>,
 352         their_node_id: PublicKey,
 353
 354         their_shutdown_scriptpubkey: Option<Script>,
 355
 356         /// Used exclusively to broadcast the latest local state, mostly a historical quirk that this
 357         /// is here:
 358         channel_monitor: Option<ChannelMonitor<ChanSigner>>,
 359         commitment_secrets: CounterpartyCommitmentSecrets,
 360
 361         network_sync: UpdateStatus,
 362
 363         logger: Arc<Logger>,
 364 }
 365
 366 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
 367 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
 368 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
 369 /// really allow for this, so instead we're stuck closing it out at that point.
 370 const UNCONF_THRESHOLD: u32 = 6;
 371 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
 372 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
 373
 374 #[cfg(not(test))]
 375 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
 376 #[cfg(test)]
 377 pub const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
 378 #[cfg(not(test))]
 379 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 380 #[cfg(test)]
 381 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 382
 383 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
 384 /// it's 2^24.
 385 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
 386
 387 /// Used to return a simple Error back to ChannelManager. Will get converted to a
 388 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
 389 /// channel_id in ChannelManager.
 390 pub(super) enum ChannelError {
 391         Ignore(&'static str),
 392         Close(&'static str),
 393         CloseDelayBroadcast {
 394                 msg: &'static str,
 395                 update: ChannelMonitorUpdate,
 396         },
 397 }
 398
 399 impl fmt::Debug for ChannelError {
 400         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 401                 match self {
 402                         &ChannelError::Ignore(e) => write!(f, "Ignore : {}", e),
 403                         &ChannelError::Close(e) => write!(f, "Close : {}", e),
 404                         &ChannelError::CloseDelayBroadcast { msg, .. } => write!(f, "CloseDelayBroadcast : {}", msg)
 405                 }
 406         }
 407 }
 408
 409 macro_rules! secp_check {
 410         ($res: expr, $err: expr) => {
 411                 match $res {
 412                         Ok(thing) => thing,
 413                         Err(_) => return Err(ChannelError::Close($err)),
 414                 }
 415         };
 416 }
 417
 418 impl<ChanSigner: ChannelKeys> Channel<ChanSigner> {
 419         // Convert constants + channel value to limits:
 420         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
 421                 channel_value_satoshis * 1000 / 10 //TODO
 422         }
 423
 424         /// Returns a minimum channel reserve value **they** need to maintain
 425         ///
 426         /// Guaranteed to return a value no larger than channel_value_satoshis
 427         pub(crate) fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
 428                 let (q, _) = channel_value_satoshis.overflowing_div(100);
 429                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
 430         }
 431
 432         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
 433                 cmp::max(at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000, 546) //TODO
 434         }
 435
 436         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
 437                 1000 // TODO
 438         }
 439
 440         // Constructors:
 441         pub fn new_outbound<K: Deref, F: Deref>(fee_estimator: &F, keys_provider: &K, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel<ChanSigner>, APIError>
 442         where K::Target: KeysInterface<ChanKeySigner = ChanSigner>,
 443               F::Target: FeeEstimator,
 444         {
 445                 let chan_keys = keys_provider.get_channel_keys(false, channel_value_satoshis);
 446
 447                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
 448                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
 449                 }
 450
 451                 if push_msat > channel_value_satoshis * 1000 {
 452                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
 453                 }
 454                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
 455                         return Err(APIError::APIMisuseError{err: "Configured with an unreasonable our_to_self_delay putting user funds at risks"});
 456                 }
 457
 458
 459                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 460                 if Channel::<ChanSigner>::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::<ChanSigner>::derive_our_dust_limit_satoshis(background_feerate) {
 461                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
 462                 }
 463
 464                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
 465
 466                 Ok(Channel {
 467                         user_id: user_id,
 468                         config: config.channel_options.clone(),
 469
 470                         channel_id: keys_provider.get_channel_id(),
 471                         channel_state: ChannelState::OurInitSent as u32,
 472                         channel_outbound: true,
 473                         secp_ctx: Secp256k1::new(),
 474                         channel_value_satoshis: channel_value_satoshis,
 475
 476                         latest_monitor_update_id: 0,
 477
 478                         local_keys: chan_keys,
 479                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 480                         destination_script: keys_provider.get_destination_script(),
 481
 482                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 483                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 484                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
 485
 486                         pending_inbound_htlcs: Vec::new(),
 487                         pending_outbound_htlcs: Vec::new(),
 488                         holding_cell_htlc_updates: Vec::new(),
 489                         pending_update_fee: None,
 490                         holding_cell_update_fee: None,
 491                         next_local_htlc_id: 0,
 492                         next_remote_htlc_id: 0,
 493                         update_time_counter: 1,
 494
 495                         resend_order: RAACommitmentOrder::CommitmentFirst,
 496
 497                         monitor_pending_funding_locked: false,
 498                         monitor_pending_revoke_and_ack: false,
 499                         monitor_pending_commitment_signed: false,
 500                         monitor_pending_forwards: Vec::new(),
 501                         monitor_pending_failures: Vec::new(),
 502
 503                         #[cfg(debug_assertions)]
 504                         max_commitment_tx_output_local: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 505                         #[cfg(debug_assertions)]
 506                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 507
 508                         last_sent_closing_fee: None,
 509
 510                         funding_txo: None,
 511                         funding_tx_confirmed_in: None,
 512                         short_channel_id: None,
 513                         last_block_connected: Default::default(),
 514                         funding_tx_confirmations: 0,
 515
 516                         feerate_per_kw: feerate,
 517                         their_dust_limit_satoshis: 0,
 518                         our_dust_limit_satoshis: Channel::<ChanSigner>::derive_our_dust_limit_satoshis(background_feerate),
 519                         their_max_htlc_value_in_flight_msat: 0,
 520                         their_channel_reserve_satoshis: 0,
 521                         their_htlc_minimum_msat: 0,
 522                         our_htlc_minimum_msat: Channel::<ChanSigner>::derive_our_htlc_minimum_msat(feerate),
 523                         their_to_self_delay: 0,
 524                         our_to_self_delay: config.own_channel_config.our_to_self_delay,
 525                         their_max_accepted_htlcs: 0,
 526                         minimum_depth: 0, // Filled in in accept_channel
 527
 528                         their_pubkeys: None,
 529                         their_cur_commitment_point: None,
 530
 531                         their_prev_commitment_point: None,
 532                         their_node_id: their_node_id,
 533
 534                         their_shutdown_scriptpubkey: None,
 535
 536                         channel_monitor: None,
 537                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
 538
 539                         network_sync: UpdateStatus::Fresh,
 540
 541                         logger,
 542                 })
 543         }
 544
 545         fn check_remote_fee<F: Deref>(fee_estimator: &F, feerate_per_kw: u32) -> Result<(), ChannelError>
 546                 where F::Target: FeeEstimator
 547         {
 548                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
 549                         return Err(ChannelError::Close("Peer's feerate much too low"));
 550                 }
 551                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
 552                         return Err(ChannelError::Close("Peer's feerate much too high"));
 553                 }
 554                 Ok(())
 555         }
 556
 557         /// Creates a new channel from a remote sides' request for one.
 558         /// Assumes chain_hash has already been checked and corresponds with what we expect!
 559         pub fn new_from_req<K: Deref, F: Deref>(fee_estimator: &F, keys_provider: &K, their_node_id: PublicKey, their_features: InitFeatures, msg: &msgs::OpenChannel, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel<ChanSigner>, ChannelError>
 560                 where K::Target: KeysInterface<ChanKeySigner = ChanSigner>,
 561           F::Target: FeeEstimator
 562         {
 563                 let mut chan_keys = keys_provider.get_channel_keys(true, msg.funding_satoshis);
 564                 let their_pubkeys = ChannelPublicKeys {
 565                         funding_pubkey: msg.funding_pubkey,
 566                         revocation_basepoint: msg.revocation_basepoint,
 567                         payment_basepoint: msg.payment_basepoint,
 568                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
 569                         htlc_basepoint: msg.htlc_basepoint
 570                 };
 571                 chan_keys.set_remote_channel_pubkeys(&their_pubkeys);
 572                 let mut local_config = (*config).channel_options.clone();
 573
 574                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
 575                         return Err(ChannelError::Close("Configured with an unreasonable our_to_self_delay putting user funds at risks"));
 576                 }
 577
 578                 // Check sanity of message fields:
 579                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
 580                         return Err(ChannelError::Close("funding value > 2^24"));
 581                 }
 582                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
 583                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
 584                 }
 585                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
 586                         return Err(ChannelError::Close("push_msat larger than funding value"));
 587                 }
 588                 if msg.dust_limit_satoshis > msg.funding_satoshis {
 589                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
 590                 }
 591                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
 592                         return Err(ChannelError::Close("Bogus; channel reserve is less than dust limit"));
 593                 }
 594                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
 595                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
 596                 }
 597                 Channel::<ChanSigner>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
 598
 599                 if msg.to_self_delay > config.peer_channel_config_limits.their_to_self_delay || msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
 600                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
 601                 }
 602                 if msg.max_accepted_htlcs < 1 {
 603                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
 604                 }
 605                 if msg.max_accepted_htlcs > 483 {
 606                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
 607                 }
 608
 609                 // Now check against optional parameters as set by config...
 610                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
 611                         return Err(ChannelError::Close("funding satoshis is less than the user specified limit"));
 612                 }
 613                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
 614                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
 615                 }
 616                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
 617                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
 618                 }
 619                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
 620                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
 621                 }
 622                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
 623                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
 624                 }
 625                 if msg.dust_limit_satoshis < config.peer_channel_config_limits.min_dust_limit_satoshis {
 626                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
 627                 }
 628                 if msg.dust_limit_satoshis > config.peer_channel_config_limits.max_dust_limit_satoshis {
 629                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
 630                 }
 631
 632                 // Convert things into internal flags and prep our state:
 633
 634                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
 635                 if config.peer_channel_config_limits.force_announced_channel_preference {
 636                         if local_config.announced_channel != their_announce {
 637                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours"));
 638                         }
 639                 }
 640                 // we either accept their preference or the preferences match
 641                 local_config.announced_channel = their_announce;
 642
 643                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 644
 645                 let our_dust_limit_satoshis = Channel::<ChanSigner>::derive_our_dust_limit_satoshis(background_feerate);
 646                 let our_channel_reserve_satoshis = Channel::<ChanSigner>::get_our_channel_reserve_satoshis(msg.funding_satoshis);
 647                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
 648                         return Err(ChannelError::Close("Suitable channel reserve not found. aborting"));
 649                 }
 650                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
 651                         return Err(ChannelError::Close("channel_reserve_satoshis too small"));
 652                 }
 653                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
 654                         return Err(ChannelError::Close("Dust limit too high for our channel reserve"));
 655                 }
 656
 657                 // check if the funder's amount for the initial commitment tx is sufficient
 658                 // for full fee payment
 659                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
 660                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
 661                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
 662                 }
 663
 664                 let to_local_msat = msg.push_msat;
 665                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
 666                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
 667                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
 668                 }
 669
 670                 let their_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
 671                         match &msg.shutdown_scriptpubkey {
 672                                 &OptionalField::Present(ref script) => {
 673                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. We enforce it while receiving shutdown msg
 674                                         if script.is_p2pkh() || script.is_p2sh() || script.is_v0_p2wsh() || script.is_v0_p2wpkh() {
 675                                                 Some(script.clone())
 676                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
 677                                         } else if script.len() == 0 {
 678                                                 None
 679                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
 680                                         } else {
 681                                                 return Err(ChannelError::Close("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format"));
 682                                         }
 683                                 },
 684                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
 685                                 &OptionalField::Absent => {
 686                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out"));
 687                                 }
 688                         }
 689                 } else { None };
 690
 691                 let chan = Channel {
 692                         user_id: user_id,
 693                         config: local_config,
 694
 695                         channel_id: msg.temporary_channel_id,
 696                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
 697                         channel_outbound: false,
 698                         secp_ctx: Secp256k1::new(),
 699
 700                         latest_monitor_update_id: 0,
 701
 702                         local_keys: chan_keys,
 703                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 704                         destination_script: keys_provider.get_destination_script(),
 705
 706                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 707                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 708                         value_to_self_msat: msg.push_msat,
 709
 710                         pending_inbound_htlcs: Vec::new(),
 711                         pending_outbound_htlcs: Vec::new(),
 712                         holding_cell_htlc_updates: Vec::new(),
 713                         pending_update_fee: None,
 714                         holding_cell_update_fee: None,
 715                         next_local_htlc_id: 0,
 716                         next_remote_htlc_id: 0,
 717                         update_time_counter: 1,
 718
 719                         resend_order: RAACommitmentOrder::CommitmentFirst,
 720
 721                         monitor_pending_funding_locked: false,
 722                         monitor_pending_revoke_and_ack: false,
 723                         monitor_pending_commitment_signed: false,
 724                         monitor_pending_forwards: Vec::new(),
 725                         monitor_pending_failures: Vec::new(),
 726
 727                         #[cfg(debug_assertions)]
 728                         max_commitment_tx_output_local: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 729                         #[cfg(debug_assertions)]
 730                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 731
 732                         last_sent_closing_fee: None,
 733
 734                         funding_txo: None,
 735                         funding_tx_confirmed_in: None,
 736                         short_channel_id: None,
 737                         last_block_connected: Default::default(),
 738                         funding_tx_confirmations: 0,
 739
 740                         feerate_per_kw: msg.feerate_per_kw as u64,
 741                         channel_value_satoshis: msg.funding_satoshis,
 742                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
 743                         our_dust_limit_satoshis: our_dust_limit_satoshis,
 744                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
 745                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
 746                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
 747                         our_htlc_minimum_msat: Channel::<ChanSigner>::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
 748                         their_to_self_delay: msg.to_self_delay,
 749                         our_to_self_delay: config.own_channel_config.our_to_self_delay,
 750                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
 751                         minimum_depth: config.own_channel_config.minimum_depth,
 752
 753                         their_pubkeys: Some(their_pubkeys),
 754                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
 755
 756                         their_prev_commitment_point: None,
 757                         their_node_id: their_node_id,
 758
 759                         their_shutdown_scriptpubkey,
 760
 761                         channel_monitor: None,
 762                         commitment_secrets: CounterpartyCommitmentSecrets::new(),
 763
 764                         network_sync: UpdateStatus::Fresh,
 765
 766                         logger,
 767                 };
 768
 769                 Ok(chan)
 770         }
 771
 772         // Utilities to derive keys:
 773
 774         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
 775                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed(), idx);
 776                 SecretKey::from_slice(&res).unwrap()
 777         }
 778
 779         // Utilities to build transactions:
 780
 781         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
 782                 let mut sha = Sha256::engine();
 783                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.payment_base_key());
 784
 785                 let their_payment_basepoint = &self.their_pubkeys.as_ref().unwrap().payment_basepoint.serialize();
 786                 if self.channel_outbound {
 787                         sha.input(&our_payment_basepoint.serialize());
 788                         sha.input(their_payment_basepoint);
 789                 } else {
 790                         sha.input(their_payment_basepoint);
 791                         sha.input(&our_payment_basepoint.serialize());
 792                 }
 793                 let res = Sha256::from_engine(sha).into_inner();
 794
 795                 ((res[26] as u64) << 5*8) |
 796                 ((res[27] as u64) << 4*8) |
 797                 ((res[28] as u64) << 3*8) |
 798                 ((res[29] as u64) << 2*8) |
 799                 ((res[30] as u64) << 1*8) |
 800                 ((res[31] as u64) << 0*8)
 801         }
 802
 803         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
 804         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
 805         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
 806         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
 807         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
 808         /// an HTLC to a).
 809         /// @local is used only to convert relevant internal structures which refer to remote vs local
 810         /// to decide value of outputs and direction of HTLCs.
 811         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
 812         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
 813         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
 814         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
 815         /// which peer generated this transaction and "to whom" this transaction flows.
 816         /// Returns (the transaction built, the number of HTLC outputs which were present in the
 817         /// transaction, the list of HTLCs which were not ignored when building the transaction).
 818         /// Note that below-dust HTLCs are included in the third return value, but not the second, and
 819         /// sources are provided only for outbound HTLCs in the third return value.
 820         #[inline]
 821         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, feerate_per_kw: u64) -> (Transaction, usize, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>) {
 822                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (INITIAL_COMMITMENT_NUMBER - commitment_number);
 823
 824                 let txins = {
 825                         let mut ins: Vec<TxIn> = Vec::new();
 826                         ins.push(TxIn {
 827                                 previous_output: self.funding_txo.unwrap().into_bitcoin_outpoint(),
 828                                 script_sig: Script::new(),
 829                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
 830                                 witness: Vec::new(),
 831                         });
 832                         ins
 833                 };
 834
 835                 let mut txouts: Vec<(TxOut, Option<(HTLCOutputInCommitment, Option<&HTLCSource>)>)> = Vec::with_capacity(self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len() + 2);
 836                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
 837
 838                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
 839                 let mut remote_htlc_total_msat = 0;
 840                 let mut local_htlc_total_msat = 0;
 841                 let mut value_to_self_msat_offset = 0;
 842
 843                 log_trace!(self, "Building commitment transaction number {} (really {} xor {}) for {}, generated by {} with fee {}...", commitment_number, (INITIAL_COMMITMENT_NUMBER - commitment_number), self.get_commitment_transaction_number_obscure_factor(), if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
 844
 845                 macro_rules! get_htlc_in_commitment {
 846                         ($htlc: expr, $offered: expr) => {
 847                                 HTLCOutputInCommitment {
 848                                         offered: $offered,
 849                                         amount_msat: $htlc.amount_msat,
 850                                         cltv_expiry: $htlc.cltv_expiry,
 851                                         payment_hash: $htlc.payment_hash,
 852                                         transaction_output_index: None
 853                                 }
 854                         }
 855                 }
 856
 857                 macro_rules! add_htlc_output {
 858                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
 859                                 if $outbound == local { // "offered HTLC output"
 860                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
 861                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
 862                                                 log_trace!(self, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 863                                                 txouts.push((TxOut {
 864                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
 865                                                         value: $htlc.amount_msat / 1000
 866                                                 }, Some((htlc_in_tx, $source))));
 867                                         } else {
 868                                                 log_trace!(self, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 869                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 870                                         }
 871                                 } else {
 872                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
 873                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
 874                                                 log_trace!(self, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 875                                                 txouts.push((TxOut { // "received HTLC output"
 876                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
 877                                                         value: $htlc.amount_msat / 1000
 878                                                 }, Some((htlc_in_tx, $source))));
 879                                         } else {
 880                                                 log_trace!(self, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 881                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 882                                         }
 883                                 }
 884                         }
 885                 }
 886
 887                 for ref htlc in self.pending_inbound_htlcs.iter() {
 888                         let (include, state_name) = match htlc.state {
 889                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
 890                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
 891                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
 892                                 InboundHTLCState::Committed => (true, "Committed"),
 893                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
 894                         };
 895
 896                         if include {
 897                                 add_htlc_output!(htlc, false, None, state_name);
 898                                 remote_htlc_total_msat += htlc.amount_msat;
 899                         } else {
 900                                 log_trace!(self, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 901                                 match &htlc.state {
 902                                         &InboundHTLCState::LocalRemoved(ref reason) => {
 903                                                 if generated_by_local {
 904                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
 905                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
 906                                                         }
 907                                                 }
 908                                         },
 909                                         _ => {},
 910                                 }
 911                         }
 912                 }
 913
 914                 for ref htlc in self.pending_outbound_htlcs.iter() {
 915                         let (include, state_name) = match htlc.state {
 916                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
 917                                 OutboundHTLCState::Committed => (true, "Committed"),
 918                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
 919                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
 920                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
 921                         };
 922
 923                         if include {
 924                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
 925                                 local_htlc_total_msat += htlc.amount_msat;
 926                         } else {
 927                                 log_trace!(self, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 928                                 match htlc.state {
 929                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(None)|OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) => {
 930                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
 931                                         },
 932                                         OutboundHTLCState::RemoteRemoved(None) => {
 933                                                 if !generated_by_local {
 934                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
 935                                                 }
 936                                         },
 937                                         _ => {},
 938                                 }
 939                         }
 940                 }
 941
 942                 let value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
 943                 assert!(value_to_self_msat >= 0);
 944                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
 945                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
 946                 // "violate" their reserve value by couting those against it. Thus, we have to convert
 947                 // everything to i64 before subtracting as otherwise we can overflow.
 948                 let value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
 949                 assert!(value_to_remote_msat >= 0);
 950
 951                 #[cfg(debug_assertions)]
 952                 {
 953                         // Make sure that the to_self/to_remote is always either past the appropriate
 954                         // channel_reserve *or* it is making progress towards it.
 955                         let mut max_commitment_tx_output = if generated_by_local {
 956                                 self.max_commitment_tx_output_local.lock().unwrap()
 957                         } else {
 958                                 self.max_commitment_tx_output_remote.lock().unwrap()
 959                         };
 960                         debug_assert!(max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.their_channel_reserve_satoshis as i64);
 961                         max_commitment_tx_output.0 = cmp::max(max_commitment_tx_output.0, value_to_self_msat as u64);
 962                         debug_assert!(max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= Channel::<ChanSigner>::get_our_channel_reserve_satoshis(self.channel_value_satoshis) as i64);
 963                         max_commitment_tx_output.1 = cmp::max(max_commitment_tx_output.1, value_to_remote_msat as u64);
 964                 }
 965
 966                 let total_fee: u64 = feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
 967                 let (value_to_self, value_to_remote) = if self.channel_outbound {
 968                         (value_to_self_msat / 1000 - total_fee as i64, value_to_remote_msat / 1000)
 969                 } else {
 970                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - total_fee as i64)
 971                 };
 972
 973                 let value_to_a = if local { value_to_self } else { value_to_remote };
 974                 let value_to_b = if local { value_to_remote } else { value_to_self };
 975
 976                 if value_to_a >= (dust_limit_satoshis as i64) {
 977                         log_trace!(self, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
 978                         txouts.push((TxOut {
 979                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
 980                                                                                        if local { self.their_to_self_delay } else { self.our_to_self_delay },
 981                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
 982                                 value: value_to_a as u64
 983                         }, None));
 984                 }
 985
 986                 if value_to_b >= (dust_limit_satoshis as i64) {
 987                         log_trace!(self, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
 988                         txouts.push((TxOut {
 989                                 script_pubkey: Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0)
 990                                                              .push_slice(&Hash160::hash(&keys.b_payment_key.serialize())[..])
 991                                                              .into_script(),
 992                                 value: value_to_b as u64
 993                         }, None));
 994                 }
 995
 996                 transaction_utils::sort_outputs(&mut txouts, |a, b| {
 997                         if let &Some(ref a_htlc) = a {
 998                                 if let &Some(ref b_htlc) = b {
 999                                         a_htlc.0.cltv_expiry.cmp(&b_htlc.0.cltv_expiry)
1000                                                 // Note that due to hash collisions, we have to have a fallback comparison
1001                                                 // here for fuzztarget mode (otherwise at least chanmon_fail_consistency
1002                                                 // may fail)!
1003                                                 .then(a_htlc.0.payment_hash.0.cmp(&b_htlc.0.payment_hash.0))
1004                                 // For non-HTLC outputs, if they're copying our SPK we don't really care if we
1005                                 // close the channel due to mismatches - they're doing something dumb:
1006                                 } else { cmp::Ordering::Equal }
1007                         } else { cmp::Ordering::Equal }
1008                 });
1009
1010                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
1011                 let mut htlcs_included: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(txouts.len() + included_dust_htlcs.len());
1012                 for (idx, mut out) in txouts.drain(..).enumerate() {
1013                         outputs.push(out.0);
1014                         if let Some((mut htlc, source_option)) = out.1.take() {
1015                                 htlc.transaction_output_index = Some(idx as u32);
1016                                 htlcs_included.push((htlc, source_option));
1017                         }
1018                 }
1019                 let non_dust_htlc_count = htlcs_included.len();
1020                 htlcs_included.append(&mut included_dust_htlcs);
1021
1022                 (Transaction {
1023                         version: 2,
1024                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
1025                         input: txins,
1026                         output: outputs,
1027                 }, non_dust_htlc_count, htlcs_included)
1028         }
1029
1030         #[inline]
1031         fn get_closing_scriptpubkey(&self) -> Script {
1032                 let our_channel_close_key_hash = Hash160::hash(&self.shutdown_pubkey.serialize());
1033                 Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
1034         }
1035
1036         #[inline]
1037         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
1038                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
1039         }
1040
1041         #[inline]
1042         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
1043                 let txins = {
1044                         let mut ins: Vec<TxIn> = Vec::new();
1045                         ins.push(TxIn {
1046                                 previous_output: self.funding_txo.unwrap().into_bitcoin_outpoint(),
1047                                 script_sig: Script::new(),
1048                                 sequence: 0xffffffff,
1049                                 witness: Vec::new(),
1050                         });
1051                         ins
1052                 };
1053
1054                 assert!(self.pending_inbound_htlcs.is_empty());
1055                 assert!(self.pending_outbound_htlcs.is_empty());
1056                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
1057
1058                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1059                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
1060                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
1061
1062                 if value_to_self < 0 {
1063                         assert!(self.channel_outbound);
1064                         total_fee_satoshis += (-value_to_self) as u64;
1065                 } else if value_to_remote < 0 {
1066                         assert!(!self.channel_outbound);
1067                         total_fee_satoshis += (-value_to_remote) as u64;
1068                 }
1069
1070                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
1071                         txouts.push((TxOut {
1072                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
1073                                 value: value_to_remote as u64
1074                         }, ()));
1075                 }
1076
1077                 if value_to_self as u64 > self.our_dust_limit_satoshis {
1078                         txouts.push((TxOut {
1079                                 script_pubkey: self.get_closing_scriptpubkey(),
1080                                 value: value_to_self as u64
1081                         }, ()));
1082                 }
1083
1084                 transaction_utils::sort_outputs(&mut txouts, |_, _| { cmp::Ordering::Equal }); // Ordering doesnt matter if they used our pubkey...
1085
1086                 let mut outputs: Vec<TxOut> = Vec::new();
1087                 for out in txouts.drain(..) {
1088                         outputs.push(out.0);
1089                 }
1090
1091                 (Transaction {
1092                         version: 2,
1093                         lock_time: 0,
1094                         input: txins,
1095                         output: outputs,
1096                 }, total_fee_satoshis)
1097         }
1098
1099         #[inline]
1100         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1101         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1102         /// our counterparty!)
1103         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
1104         /// TODO Some magic rust shit to compile-time check this?
1105         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1106                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
1107                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.delayed_payment_base_key());
1108                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.htlc_base_key());
1109                 let their_pubkeys = self.their_pubkeys.as_ref().unwrap();
1110
1111                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &their_pubkeys.revocation_basepoint, &their_pubkeys.payment_basepoint, &their_pubkeys.htlc_basepoint), "Local tx keys generation got bogus keys"))
1112         }
1113
1114         #[inline]
1115         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1116         /// will sign and send to our counterparty.
1117         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1118         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1119                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1120                 //may see payments to it!
1121                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.payment_base_key());
1122                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.revocation_base_key());
1123                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.htlc_base_key());
1124                 let their_pubkeys = self.their_pubkeys.as_ref().unwrap();
1125
1126                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &their_pubkeys.delayed_payment_basepoint, &their_pubkeys.htlc_basepoint, &revocation_basepoint, &payment_basepoint, &htlc_basepoint), "Remote tx keys generation got bogus keys"))
1127         }
1128
1129         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1130         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1131         /// Panics if called before accept_channel/new_from_req
1132         pub fn get_funding_redeemscript(&self) -> Script {
1133                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key());
1134                 make_funding_redeemscript(&our_funding_key, self.their_funding_pubkey())
1135         }
1136
1137         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
1138         /// @local is used only to convert relevant internal structures which refer to remote vs local
1139         /// to decide value of outputs and direction of HTLCs.
1140         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys, feerate_per_kw: u64) -> Transaction {
1141                 chan_utils::build_htlc_transaction(prev_hash, feerate_per_kw, if local { self.their_to_self_delay } else { self.our_to_self_delay }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
1142         }
1143
1144         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1145         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1146         /// Ok(_) if debug assertions are turned on and preconditions are met.
1147         fn get_update_fulfill_htlc(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitorUpdate>), ChannelError> {
1148                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1149                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1150                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1151                 // either.
1152                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1153                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1154                 }
1155                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1156
1157                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1158
1159                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1160                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1161                 // these, but for now we just have to treat them as normal.
1162
1163                 let mut pending_idx = std::usize::MAX;
1164                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1165                         if htlc.htlc_id == htlc_id_arg {
1166                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1167                                 match htlc.state {
1168                                         InboundHTLCState::Committed => {},
1169                                         InboundHTLCState::LocalRemoved(ref reason) => {
1170                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1171                                                 } else {
1172                                                         log_warn!(self, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1173                                                 }
1174                                                 return Ok((None, None));
1175                                         },
1176                                         _ => {
1177                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1178                                                 // Don't return in release mode here so that we can update channel_monitor
1179                                         }
1180                                 }
1181                                 pending_idx = idx;
1182                                 break;
1183                         }
1184                 }
1185                 if pending_idx == std::usize::MAX {
1186                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1187                 }
1188
1189                 // Now update local state:
1190                 //
1191                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1192                 // can claim it even if the channel hits the chain before we see their next commitment.
1193                 self.latest_monitor_update_id += 1;
1194                 let monitor_update = ChannelMonitorUpdate {
1195                         update_id: self.latest_monitor_update_id,
1196                         updates: vec![ChannelMonitorUpdateStep::PaymentPreimage {
1197                                 payment_preimage: payment_preimage_arg.clone(),
1198                         }],
1199                 };
1200                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
1201
1202                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1203                         for pending_update in self.holding_cell_htlc_updates.iter() {
1204                                 match pending_update {
1205                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1206                                                 if htlc_id_arg == htlc_id {
1207                                                         return Ok((None, None));
1208                                                 }
1209                                         },
1210                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1211                                                 if htlc_id_arg == htlc_id {
1212                                                         log_warn!(self, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1213                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1214                                                         // rare enough it may not be worth the complexity burden.
1215                                                         return Ok((None, Some(monitor_update)));
1216                                                 }
1217                                         },
1218                                         _ => {}
1219                                 }
1220                         }
1221                         log_trace!(self, "Adding HTLC claim to holding_cell! Current state: {}", self.channel_state);
1222                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1223                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1224                         });
1225                         return Ok((None, Some(monitor_update)));
1226                 }
1227
1228                 {
1229                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1230                         if let InboundHTLCState::Committed = htlc.state {
1231                         } else {
1232                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1233                                 return Ok((None, Some(monitor_update)));
1234                         }
1235                         log_trace!(self, "Upgrading HTLC {} to LocalRemoved with a Fulfill!", log_bytes!(htlc.payment_hash.0));
1236                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1237                 }
1238
1239                 Ok((Some(msgs::UpdateFulfillHTLC {
1240                         channel_id: self.channel_id(),
1241                         htlc_id: htlc_id_arg,
1242                         payment_preimage: payment_preimage_arg,
1243                 }), Some(monitor_update)))
1244         }
1245
1246         pub fn get_update_fulfill_htlc_and_commit(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitorUpdate>), ChannelError> {
1247                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage)? {
1248                         (Some(update_fulfill_htlc), Some(mut monitor_update)) => {
1249                                 let (commitment, mut additional_update) = self.send_commitment_no_status_check()?;
1250                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1251                                 // strictly increasing by one, so decrement it here.
1252                                 self.latest_monitor_update_id = monitor_update.update_id;
1253                                 monitor_update.updates.append(&mut additional_update.updates);
1254                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1255                         },
1256                         (Some(update_fulfill_htlc), None) => {
1257                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1258                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1259                         },
1260                         (None, Some(monitor_update)) => Ok((None, Some(monitor_update))),
1261                         (None, None) => Ok((None, None))
1262                 }
1263         }
1264
1265         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1266         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1267         /// Ok(_) if debug assertions are turned on and preconditions are met.
1268         pub fn get_update_fail_htlc(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> {
1269                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1270                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1271                 }
1272                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1273
1274                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1275                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1276                 // these, but for now we just have to treat them as normal.
1277
1278                 let mut pending_idx = std::usize::MAX;
1279                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1280                         if htlc.htlc_id == htlc_id_arg {
1281                                 match htlc.state {
1282                                         InboundHTLCState::Committed => {},
1283                                         InboundHTLCState::LocalRemoved(_) => {
1284                                                 return Ok(None);
1285                                         },
1286                                         _ => {
1287                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1288                                                 return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1289                                         }
1290                                 }
1291                                 pending_idx = idx;
1292                         }
1293                 }
1294                 if pending_idx == std::usize::MAX {
1295                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1296                 }
1297
1298                 // Now update local state:
1299                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1300                         for pending_update in self.holding_cell_htlc_updates.iter() {
1301                                 match pending_update {
1302                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1303                                                 if htlc_id_arg == htlc_id {
1304                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1305                                                 }
1306                                         },
1307                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1308                                                 if htlc_id_arg == htlc_id {
1309                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1310                                                 }
1311                                         },
1312                                         _ => {}
1313                                 }
1314                         }
1315                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1316                                 htlc_id: htlc_id_arg,
1317                                 err_packet,
1318                         });
1319                         return Ok(None);
1320                 }
1321
1322                 {
1323                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1324                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1325                 }
1326
1327                 Ok(Some(msgs::UpdateFailHTLC {
1328                         channel_id: self.channel_id(),
1329                         htlc_id: htlc_id_arg,
1330                         reason: err_packet
1331                 }))
1332         }
1333
1334         // Message handlers:
1335
1336         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig, their_features: InitFeatures) -> Result<(), ChannelError> {
1337                 // Check sanity of message fields:
1338                 if !self.channel_outbound {
1339                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer"));
1340                 }
1341                 if self.channel_state != ChannelState::OurInitSent as u32 {
1342                         return Err(ChannelError::Close("Got an accept_channel message at a strange time"));
1343                 }
1344                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1345                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1346                 }
1347                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1348                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
1349                 }
1350                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1351                         return Err(ChannelError::Close("Bogus channel_reserve and dust_limit"));
1352                 }
1353                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1354                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1355                 }
1356                 if msg.dust_limit_satoshis > Channel::<ChanSigner>::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1357                         return Err(ChannelError::Close("Dust limit is bigger than our channel reverse"));
1358                 }
1359                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1360                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
1361                 }
1362                 if msg.to_self_delay > config.peer_channel_config_limits.their_to_self_delay || msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1363                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
1364                 }
1365                 if msg.max_accepted_htlcs < 1 {
1366                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel"));
1367                 }
1368                 if msg.max_accepted_htlcs > 483 {
1369                         return Err(ChannelError::Close("max_accepted_htlcs > 483"));
1370                 }
1371
1372                 // Now check against optional parameters as set by config...
1373                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1374                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
1375                 }
1376                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1377                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
1378                 }
1379                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1380                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
1381                 }
1382                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1383                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
1384                 }
1385                 if msg.dust_limit_satoshis < config.peer_channel_config_limits.min_dust_limit_satoshis {
1386                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
1387                 }
1388                 if msg.dust_limit_satoshis > config.peer_channel_config_limits.max_dust_limit_satoshis {
1389                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
1390                 }
1391                 if msg.minimum_depth > config.peer_channel_config_limits.max_minimum_depth {
1392                         return Err(ChannelError::Close("We consider the minimum depth to be unreasonably large"));
1393                 }
1394
1395                 let their_shutdown_scriptpubkey = if their_features.supports_upfront_shutdown_script() {
1396                         match &msg.shutdown_scriptpubkey {
1397                                 &OptionalField::Present(ref script) => {
1398                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. We enforce it while receiving shutdown msg
1399                                         if script.is_p2pkh() || script.is_p2sh() || script.is_v0_p2wsh() || script.is_v0_p2wpkh() {
1400                                                 Some(script.clone())
1401                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1402                                         } else if script.len() == 0 {
1403                                                 None
1404                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
1405                                         } else {
1406                                                 return Err(ChannelError::Close("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format"));
1407                                         }
1408                                 },
1409                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1410                                 &OptionalField::Absent => {
1411                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out"));
1412                                 }
1413                         }
1414                 } else { None };
1415
1416                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1417                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1418                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1419                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1420                 self.their_to_self_delay = msg.to_self_delay;
1421                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1422                 self.minimum_depth = msg.minimum_depth;
1423
1424                 let their_pubkeys = ChannelPublicKeys {
1425                         funding_pubkey: msg.funding_pubkey,
1426                         revocation_basepoint: msg.revocation_basepoint,
1427                         payment_basepoint: msg.payment_basepoint,
1428                         delayed_payment_basepoint: msg.delayed_payment_basepoint,
1429                         htlc_basepoint: msg.htlc_basepoint
1430                 };
1431
1432                 self.local_keys.set_remote_channel_pubkeys(&their_pubkeys);
1433                 self.their_pubkeys = Some(their_pubkeys);
1434
1435                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1436                 self.their_shutdown_scriptpubkey = their_shutdown_scriptpubkey;
1437
1438                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1439
1440                 Ok(())
1441         }
1442
1443         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, LocalCommitmentTransaction, Signature, TxCreationKeys), ChannelError> {
1444                 let funding_script = self.get_funding_redeemscript();
1445
1446                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1447                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1448                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
1449
1450                 // They sign the "local" commitment transaction...
1451                 secp_check!(self.secp_ctx.verify(&local_sighash, &sig, self.their_funding_pubkey()), "Invalid funding_created signature from peer");
1452
1453                 let localtx = LocalCommitmentTransaction::new_missing_local_sig(local_initial_commitment_tx, sig, &PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()), self.their_funding_pubkey());
1454
1455                 let remote_keys = self.build_remote_transaction_keys()?;
1456                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
1457                 let remote_signature = self.local_keys.sign_remote_commitment(self.feerate_per_kw, &remote_initial_commitment_tx, &remote_keys, &Vec::new(), self.our_to_self_delay, &self.secp_ctx)
1458                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed"))?.0;
1459
1460                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1461                 Ok((remote_initial_commitment_tx, localtx, remote_signature, local_keys))
1462         }
1463
1464         fn their_funding_pubkey(&self) -> &PublicKey {
1465                 &self.their_pubkeys.as_ref().expect("their_funding_pubkey() only allowed after accept_channel").funding_pubkey
1466         }
1467
1468         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor<ChanSigner>), ChannelError> {
1469                 if self.channel_outbound {
1470                         return Err(ChannelError::Close("Received funding_created for an outbound channel?"));
1471                 }
1472                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1473                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1474                         // remember the channel, so it's safe to just send an error_message here and drop the
1475                         // channel.
1476                         return Err(ChannelError::Close("Received funding_created after we got the channel!"));
1477                 }
1478                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1479                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1480                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1481                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1482                 }
1483
1484                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1485                 self.funding_txo = Some(funding_txo.clone());
1486
1487                 let (remote_initial_commitment_tx, local_initial_commitment_tx, our_signature, local_keys) = match self.funding_created_signature(&msg.signature) {
1488                         Ok(res) => res,
1489                         Err(e) => {
1490                                 self.funding_txo = None;
1491                                 return Err(e);
1492                         }
1493                 };
1494
1495                 // Now that we're past error-generating stuff, update our local state:
1496
1497                 let their_pubkeys = self.their_pubkeys.as_ref().unwrap();
1498                 let funding_redeemscript = self.get_funding_redeemscript();
1499                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
1500                 macro_rules! create_monitor {
1501                         () => { {
1502                                 let mut channel_monitor = ChannelMonitor::new(self.local_keys.clone(),
1503                                                                               &self.shutdown_pubkey, self.our_to_self_delay,
1504                                                                               &self.destination_script, (funding_txo, funding_txo_script.clone()),
1505                                                                               &their_pubkeys.htlc_basepoint, &their_pubkeys.delayed_payment_basepoint,
1506                                                                               self.their_to_self_delay, funding_redeemscript.clone(), self.channel_value_satoshis,
1507                                                                               self.get_commitment_transaction_number_obscure_factor(),
1508                                                                               self.logger.clone());
1509
1510                                 channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
1511                                 channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys.clone(), self.feerate_per_kw, Vec::new()).unwrap();
1512                                 channel_monitor
1513                         } }
1514                 }
1515
1516                 self.channel_monitor = Some(create_monitor!());
1517                 let channel_monitor = create_monitor!();
1518
1519                 self.channel_state = ChannelState::FundingSent as u32;
1520                 self.channel_id = funding_txo.to_channel_id();
1521                 self.cur_remote_commitment_transaction_number -= 1;
1522                 self.cur_local_commitment_transaction_number -= 1;
1523
1524                 Ok((msgs::FundingSigned {
1525                         channel_id: self.channel_id,
1526                         signature: our_signature
1527                 }, channel_monitor))
1528         }
1529
1530         /// Handles a funding_signed message from the remote end.
1531         /// If this call is successful, broadcast the funding transaction (and not before!)
1532         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitorUpdate, (Option<ChannelMonitorUpdate>, ChannelError)> {
1533                 if !self.channel_outbound {
1534                         return Err((None, ChannelError::Close("Received funding_signed for an inbound channel?")));
1535                 }
1536                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
1537                         return Err((None, ChannelError::Close("Received funding_signed in strange state!")));
1538                 }
1539                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
1540                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER - 1 ||
1541                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1542                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1543                 }
1544
1545                 let funding_script = self.get_funding_redeemscript();
1546
1547                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number).map_err(|e| (None, e))?;
1548                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1549                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
1550
1551                 let their_funding_pubkey = &self.their_pubkeys.as_ref().unwrap().funding_pubkey;
1552
1553                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1554                 if let Err(_) = self.secp_ctx.verify(&local_sighash, &msg.signature, their_funding_pubkey) {
1555                         return Err((None, ChannelError::Close("Invalid funding_signed signature from peer")));
1556                 }
1557
1558                 self.latest_monitor_update_id += 1;
1559                 let monitor_update = ChannelMonitorUpdate {
1560                         update_id: self.latest_monitor_update_id,
1561                         updates: vec![ChannelMonitorUpdateStep::LatestLocalCommitmentTXInfo {
1562                                 commitment_tx: LocalCommitmentTransaction::new_missing_local_sig(local_initial_commitment_tx, &msg.signature, &PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()), their_funding_pubkey),
1563                                 local_keys, feerate_per_kw: self.feerate_per_kw, htlc_outputs: Vec::new(),
1564                         }]
1565                 };
1566                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
1567                 self.channel_state = ChannelState::FundingSent as u32 | (self.channel_state & (ChannelState::MonitorUpdateFailed as u32));
1568                 self.cur_local_commitment_transaction_number -= 1;
1569
1570                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1571                         Ok(monitor_update)
1572                 } else {
1573                         Err((Some(monitor_update),
1574                                 ChannelError::Ignore("Previous monitor update failure prevented funding_signed from allowing funding broadcast")))
1575                 }
1576         }
1577
1578         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), ChannelError> {
1579                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1580                         return Err(ChannelError::Close("Peer sent funding_locked when we needed a channel_reestablish"));
1581                 }
1582
1583                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
1584
1585                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1586                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1587                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1588                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
1589                         self.update_time_counter += 1;
1590                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
1591                                  // Note that funding_signed/funding_created will have decremented both by 1!
1592                                  self.cur_local_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
1593                                  self.cur_remote_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
1594                                 // If we reconnected before sending our funding locked they may still resend theirs:
1595                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
1596                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
1597                         if self.their_cur_commitment_point != Some(msg.next_per_commitment_point) {
1598                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point"));
1599                         }
1600                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
1601                         return Ok(());
1602                 } else {
1603                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time"));
1604                 }
1605
1606                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1607                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1608                 Ok(())
1609         }
1610
1611         /// Returns (inbound_htlc_count, htlc_inbound_value_msat)
1612         fn get_inbound_pending_htlc_stats(&self) -> (u32, u64) {
1613                 let mut htlc_inbound_value_msat = 0;
1614                 for ref htlc in self.pending_inbound_htlcs.iter() {
1615                         htlc_inbound_value_msat += htlc.amount_msat;
1616                 }
1617                 (self.pending_inbound_htlcs.len() as u32, htlc_inbound_value_msat)
1618         }
1619
1620         /// Returns (outbound_htlc_count, htlc_outbound_value_msat) *including* pending adds in our
1621         /// holding cell.
1622         fn get_outbound_pending_htlc_stats(&self) -> (u32, u64) {
1623                 let mut htlc_outbound_value_msat = 0;
1624                 for ref htlc in self.pending_outbound_htlcs.iter() {
1625                         htlc_outbound_value_msat += htlc.amount_msat;
1626                 }
1627
1628                 let mut htlc_outbound_count = self.pending_outbound_htlcs.len();
1629                 for update in self.holding_cell_htlc_updates.iter() {
1630                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
1631                                 htlc_outbound_count += 1;
1632                                 htlc_outbound_value_msat += amount_msat;
1633                         }
1634                 }
1635
1636                 (htlc_outbound_count as u32, htlc_outbound_value_msat)
1637         }
1638
1639         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
1640         /// Doesn't bother handling the
1641         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
1642         /// corner case properly.
1643         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
1644                 // Note that we have to handle overflow due to the above case.
1645                 (cmp::min(self.channel_value_satoshis as i64 * 1000 - self.value_to_self_msat as i64 - self.get_inbound_pending_htlc_stats().1 as i64, 0) as u64,
1646                 cmp::min(self.value_to_self_msat as i64 - self.get_outbound_pending_htlc_stats().1 as i64, 0) as u64)
1647         }
1648
1649         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), ChannelError> {
1650                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1651                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state"));
1652                 }
1653                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1654                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish"));
1655                 }
1656                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1657                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel"));
1658                 }
1659                 if msg.amount_msat == 0 {
1660                         return Err(ChannelError::Close("Remote side tried to send a 0-msat HTLC"));
1661                 }
1662                 if msg.amount_msat < self.our_htlc_minimum_msat {
1663                         return Err(ChannelError::Close("Remote side tried to send less than our minimum HTLC value"));
1664                 }
1665
1666                 let (inbound_htlc_count, htlc_inbound_value_msat) = self.get_inbound_pending_htlc_stats();
1667                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1668                         return Err(ChannelError::Close("Remote tried to push more than our max accepted HTLCs"));
1669                 }
1670                 // Check our_max_htlc_value_in_flight_msat
1671                 if htlc_inbound_value_msat + msg.amount_msat > Channel::<ChanSigner>::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1672                         return Err(ChannelError::Close("Remote HTLC add would put them over our max HTLC value"));
1673                 }
1674                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1675                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1676                 // something if we punish them for broadcasting an old state).
1677                 // Note that we don't really care about having a small/no to_remote output in our local
1678                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
1679                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
1680                 // present in the next commitment transaction we send them (at least for fulfilled ones,
1681                 // failed ones won't modify value_to_self).
1682                 // Note that we will send HTLCs which another instance of rust-lightning would think
1683                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
1684                 // Channel state once they will not be present in the next received commitment
1685                 // transaction).
1686                 let mut removed_outbound_total_msat = 0;
1687                 for ref htlc in self.pending_outbound_htlcs.iter() {
1688                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(None) = htlc.state {
1689                                 removed_outbound_total_msat += htlc.amount_msat;
1690                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) = htlc.state {
1691                                 removed_outbound_total_msat += htlc.amount_msat;
1692                         }
1693                 }
1694                 if htlc_inbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::<ChanSigner>::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 + removed_outbound_total_msat {
1695                         return Err(ChannelError::Close("Remote HTLC add would put them over their reserve value"));
1696                 }
1697                 if self.next_remote_htlc_id != msg.htlc_id {
1698                         return Err(ChannelError::Close("Remote skipped HTLC ID"));
1699                 }
1700                 if msg.cltv_expiry >= 500000000 {
1701                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height"));
1702                 }
1703
1704                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1705
1706                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
1707                         if let PendingHTLCStatus::Forward(_) = pending_forward_state {
1708                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
1709                         }
1710                 }
1711
1712                 // Now update local state:
1713                 self.next_remote_htlc_id += 1;
1714                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
1715                         htlc_id: msg.htlc_id,
1716                         amount_msat: msg.amount_msat,
1717                         payment_hash: msg.payment_hash,
1718                         cltv_expiry: msg.cltv_expiry,
1719                         state: InboundHTLCState::RemoteAnnounced(pending_forward_state),
1720                 });
1721                 Ok(())
1722         }
1723
1724         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
1725         #[inline]
1726         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentHash>, fail_reason: Option<HTLCFailReason>) -> Result<&HTLCSource, ChannelError> {
1727                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1728                         if htlc.htlc_id == htlc_id {
1729                                 match check_preimage {
1730                                         None => {},
1731                                         Some(payment_hash) =>
1732                                                 if payment_hash != htlc.payment_hash {
1733                                                         return Err(ChannelError::Close("Remote tried to fulfill HTLC with an incorrect preimage"));
1734                                                 }
1735                                 };
1736                                 match htlc.state {
1737                                         OutboundHTLCState::LocalAnnounced(_) =>
1738                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC before it had been committed")),
1739                                         OutboundHTLCState::Committed => {
1740                                                 htlc.state = OutboundHTLCState::RemoteRemoved(fail_reason);
1741                                         },
1742                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
1743                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC that they'd already fulfilled/failed")),
1744                                 }
1745                                 return Ok(&htlc.source);
1746                         }
1747                 }
1748                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find"))
1749         }
1750
1751         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<HTLCSource, ChannelError> {
1752                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1753                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state"));
1754                 }
1755                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1756                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish"));
1757                 }
1758
1759                 let payment_hash = PaymentHash(Sha256::hash(&msg.payment_preimage.0[..]).into_inner());
1760                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None).map(|source| source.clone())
1761         }
1762
1763         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1764                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1765                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state"));
1766                 }
1767                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1768                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish"));
1769                 }
1770
1771                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1772                 Ok(())
1773         }
1774
1775         pub fn update_fail_malformed_htlc<'a>(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1776                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1777                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state"));
1778                 }
1779                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1780                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish"));
1781                 }
1782
1783                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1784                 Ok(())
1785         }
1786
1787         pub fn commitment_signed<F: Deref>(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &F) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, Option<msgs::ClosingSigned>, ChannelMonitorUpdate), (Option<ChannelMonitorUpdate>, ChannelError)> where F::Target: FeeEstimator {
1788                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1789                         return Err((None, ChannelError::Close("Got commitment signed message when channel was not in an operational state")));
1790                 }
1791                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1792                         return Err((None, ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish")));
1793                 }
1794                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1795                         return Err((None, ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds")));
1796                 }
1797
1798                 let funding_script = self.get_funding_redeemscript();
1799
1800                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number).map_err(|e| (None, e))?;
1801
1802                 let mut update_fee = false;
1803                 let feerate_per_kw = if !self.channel_outbound && self.pending_update_fee.is_some() {
1804                         update_fee = true;
1805                         self.pending_update_fee.unwrap()
1806                 } else {
1807                         self.feerate_per_kw
1808                 };
1809
1810                 let mut local_commitment_tx = {
1811                         let mut commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, feerate_per_kw);
1812                         let htlcs_cloned: Vec<_> = commitment_tx.2.drain(..).map(|htlc| (htlc.0, htlc.1.map(|h| h.clone()))).collect();
1813                         (commitment_tx.0, commitment_tx.1, htlcs_cloned)
1814                 };
1815                 let local_commitment_txid = local_commitment_tx.0.txid();
1816                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]);
1817                 log_trace!(self, "Checking commitment tx signature {} by key {} against tx {} with redeemscript {}", log_bytes!(msg.signature.serialize_compact()[..]), log_bytes!(self.their_funding_pubkey().serialize()), encode::serialize_hex(&local_commitment_tx.0), encode::serialize_hex(&funding_script));
1818                 if let Err(_) = self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey()) {
1819                         return Err((None, ChannelError::Close("Invalid commitment tx signature from peer")));
1820                 }
1821
1822                 //If channel fee was updated by funder confirm funder can afford the new fee rate when applied to the current local commitment transaction
1823                 if update_fee {
1824                         let num_htlcs = local_commitment_tx.1;
1825                         let total_fee: u64 = feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
1826
1827                         if self.channel_value_satoshis - self.value_to_self_msat / 1000 < total_fee + self.their_channel_reserve_satoshis {
1828                                 return Err((None, ChannelError::Close("Funding remote cannot afford proposed new fee")));
1829                         }
1830                 }
1831
1832                 if msg.htlc_signatures.len() != local_commitment_tx.1 {
1833                         return Err((None, ChannelError::Close("Got wrong number of HTLC signatures from remote")));
1834                 }
1835
1836                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.2.len());
1837                 for (idx, (htlc, source)) in local_commitment_tx.2.drain(..).enumerate() {
1838                         if let Some(_) = htlc.transaction_output_index {
1839                                 let htlc_tx = self.build_htlc_transaction(&local_commitment_txid, &htlc, true, &local_keys, feerate_per_kw);
1840                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1841                                 log_trace!(self, "Checking HTLC tx signature {} by key {} against tx {} with redeemscript {}", log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(local_keys.b_htlc_key.serialize()), encode::serialize_hex(&htlc_tx), encode::serialize_hex(&htlc_redeemscript));
1842                                 let htlc_sighash = hash_to_message!(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]);
1843                                 if let Err(_) = self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key) {
1844                                         return Err((None, ChannelError::Close("Invalid HTLC tx signature from peer")));
1845                                 }
1846                                 htlcs_and_sigs.push((htlc, Some(msg.htlc_signatures[idx]), source));
1847                         } else {
1848                                 htlcs_and_sigs.push((htlc, None, source));
1849                         }
1850                 }
1851
1852                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1853                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed(), self.cur_local_commitment_transaction_number + 1);
1854
1855                 // Update state now that we've passed all the can-fail calls...
1856                 let mut need_our_commitment = false;
1857                 if !self.channel_outbound {
1858                         if let Some(fee_update) = self.pending_update_fee {
1859                                 self.feerate_per_kw = fee_update;
1860                                 // We later use the presence of pending_update_fee to indicate we should generate a
1861                                 // commitment_signed upon receipt of revoke_and_ack, so we can only set it to None
1862                                 // if we're not awaiting a revoke (ie will send a commitment_signed now).
1863                                 if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) == 0 {
1864                                         need_our_commitment = true;
1865                                         self.pending_update_fee = None;
1866                                 }
1867                         }
1868                 }
1869
1870                 let their_funding_pubkey = self.their_pubkeys.as_ref().unwrap().funding_pubkey;
1871
1872                 self.latest_monitor_update_id += 1;
1873                 let mut monitor_update = ChannelMonitorUpdate {
1874                         update_id: self.latest_monitor_update_id,
1875                         updates: vec![ChannelMonitorUpdateStep::LatestLocalCommitmentTXInfo {
1876                                 commitment_tx: LocalCommitmentTransaction::new_missing_local_sig(local_commitment_tx.0, &msg.signature, &PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()), &their_funding_pubkey),
1877                                 local_keys, feerate_per_kw: self.feerate_per_kw, htlc_outputs: htlcs_and_sigs
1878                         }]
1879                 };
1880                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
1881
1882                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1883                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
1884                                 Some(forward_info.clone())
1885                         } else { None };
1886                         if let Some(forward_info) = new_forward {
1887                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
1888                                 need_our_commitment = true;
1889                         }
1890                 }
1891                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1892                         if let Some(fail_reason) = if let &mut OutboundHTLCState::RemoteRemoved(ref mut fail_reason) = &mut htlc.state {
1893                                 Some(fail_reason.take())
1894                         } else { None } {
1895                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(fail_reason);
1896                                 need_our_commitment = true;
1897                         }
1898                 }
1899
1900                 self.cur_local_commitment_transaction_number -= 1;
1901                 // Note that if we need_our_commitment & !AwaitingRemoteRevoke we'll call
1902                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
1903                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
1904
1905                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
1906                         // In case we initially failed monitor updating without requiring a response, we need
1907                         // to make sure the RAA gets sent first.
1908                         self.monitor_pending_revoke_and_ack = true;
1909                         if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1910                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
1911                                 // the corresponding HTLC status updates so that get_last_commitment_update
1912                                 // includes the right HTLCs.
1913                                 self.monitor_pending_commitment_signed = true;
1914                                 let (_, mut additional_update) = self.send_commitment_no_status_check().map_err(|e| (None, e))?;
1915                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1916                                 // strictly increasing by one, so decrement it here.
1917                                 self.latest_monitor_update_id = monitor_update.update_id;
1918                                 monitor_update.updates.append(&mut additional_update.updates);
1919                         }
1920                         // TODO: Call maybe_propose_first_closing_signed on restoration (or call it here and
1921                         // re-send the message on restoration)
1922                         return Err((Some(monitor_update), ChannelError::Ignore("Previous monitor update failure prevented generation of RAA")));
1923                 }
1924
1925                 let (our_commitment_signed, closing_signed) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1926                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1927                         // we'll send one right away when we get the revoke_and_ack when we
1928                         // free_holding_cell_htlcs().
1929                         let (msg, mut additional_update) = self.send_commitment_no_status_check().map_err(|e| (None, e))?;
1930                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
1931                         // strictly increasing by one, so decrement it here.
1932                         self.latest_monitor_update_id = monitor_update.update_id;
1933                         monitor_update.updates.append(&mut additional_update.updates);
1934                         (Some(msg), None)
1935                 } else if !need_our_commitment {
1936                         (None, self.maybe_propose_first_closing_signed(fee_estimator))
1937                 } else { (None, None) };
1938
1939                 Ok((msgs::RevokeAndACK {
1940                         channel_id: self.channel_id,
1941                         per_commitment_secret: per_commitment_secret,
1942                         next_per_commitment_point: next_per_commitment_point,
1943                 }, our_commitment_signed, closing_signed, monitor_update))
1944         }
1945
1946         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1947         /// fulfilling or failing the last pending HTLC)
1948         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitorUpdate)>, ChannelError> {
1949                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
1950                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
1951                         log_trace!(self, "Freeing holding cell with {} HTLC updates{}", self.holding_cell_htlc_updates.len(), if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" });
1952
1953                         let mut monitor_update = ChannelMonitorUpdate {
1954                                 update_id: self.latest_monitor_update_id + 1, // We don't increment this yet!
1955                                 updates: Vec::new(),
1956                         };
1957
1958                         let mut htlc_updates = Vec::new();
1959                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1960                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1961                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1962                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1963                         let mut err = None;
1964                         for htlc_update in htlc_updates.drain(..) {
1965                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1966                                 // fee races with adding too many outputs which push our total payments just over
1967                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
1968                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
1969                                 // to rebalance channels.
1970                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1971                                         self.holding_cell_htlc_updates.push(htlc_update);
1972                                 } else {
1973                                         match &htlc_update {
1974                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
1975                                                         match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone()) {
1976                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1977                                                                 Err(e) => {
1978                                                                         match e {
1979                                                                                 ChannelError::Ignore(ref msg) => {
1980                                                                                         log_info!(self, "Failed to send HTLC with payment_hash {} due to {}", log_bytes!(payment_hash.0), msg);
1981                                                                                 },
1982                                                                                 _ => {
1983                                                                                         log_info!(self, "Failed to send HTLC with payment_hash {} resulting in a channel closure during holding_cell freeing", log_bytes!(payment_hash.0));
1984                                                                                 },
1985                                                                         }
1986                                                                         err = Some(e);
1987                                                                 }
1988                                                         }
1989                                                 },
1990                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
1991                                                         match self.get_update_fulfill_htlc(htlc_id, *payment_preimage) {
1992                                                                 Ok((update_fulfill_msg_option, additional_monitor_update_opt)) => {
1993                                                                         update_fulfill_htlcs.push(update_fulfill_msg_option.unwrap());
1994                                                                         if let Some(mut additional_monitor_update) = additional_monitor_update_opt {
1995                                                                                 monitor_update.updates.append(&mut additional_monitor_update.updates);
1996                                                                         }
1997                                                                 },
1998                                                                 Err(e) => {
1999                                                                         if let ChannelError::Ignore(_) = e {}
2000                                                                         else {
2001                                                                                 panic!("Got a non-IgnoreError action trying to fulfill holding cell HTLC");
2002                                                                         }
2003                                                                 }
2004                                                         }
2005                                                 },
2006                                                 &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
2007                                                         match self.get_update_fail_htlc(htlc_id, err_packet.clone()) {
2008                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
2009                                                                 Err(e) => {
2010                                                                         if let ChannelError::Ignore(_) = e {}
2011                                                                         else {
2012                                                                                 panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
2013                                                                         }
2014                                                                 }
2015                                                         }
2016                                                 },
2017                                         }
2018                                         if err.is_some() {
2019                                                 self.holding_cell_htlc_updates.push(htlc_update);
2020                                                 if let Some(ChannelError::Ignore(_)) = err {
2021                                                         // If we failed to add the HTLC, but got an Ignore error, we should
2022                                                         // still send the new commitment_signed, so reset the err to None.
2023                                                         err = None;
2024                                                 }
2025                                         }
2026                                 }
2027                         }
2028                         //TODO: Need to examine the type of err - if it's a fee issue or similar we may want to
2029                         //fail it back the route, if it's a temporary issue we can ignore it...
2030                         match err {
2031                                 None => {
2032                                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2033                                                 // This should never actually happen and indicates we got some Errs back
2034                                                 // from update_fulfill_htlc/update_fail_htlc, but we handle it anyway in
2035                                                 // case there is some strange way to hit duplicate HTLC removes.
2036                                                 return Ok(None);
2037                                         }
2038                                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee {
2039                                                         self.pending_update_fee = self.holding_cell_update_fee.take();
2040                                                         Some(msgs::UpdateFee {
2041                                                                 channel_id: self.channel_id,
2042                                                                 feerate_per_kw: feerate as u32,
2043                                                         })
2044                                                 } else {
2045                                                         None
2046                                                 };
2047
2048                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check()?;
2049                                         // send_commitment_no_status_check and get_update_fulfill_htlc may bump latest_monitor_id
2050                                         // but we want them to be strictly increasing by one, so reset it here.
2051                                         self.latest_monitor_update_id = monitor_update.update_id;
2052                                         monitor_update.updates.append(&mut additional_update.updates);
2053
2054                                         Ok(Some((msgs::CommitmentUpdate {
2055                                                 update_add_htlcs,
2056                                                 update_fulfill_htlcs,
2057                                                 update_fail_htlcs,
2058                                                 update_fail_malformed_htlcs: Vec::new(),
2059                                                 update_fee: update_fee,
2060                                                 commitment_signed,
2061                                         }, monitor_update)))
2062                                 },
2063                                 Some(e) => Err(e)
2064                         }
2065                 } else {
2066                         Ok(None)
2067                 }
2068         }
2069
2070         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2071         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2072         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2073         /// generating an appropriate error *after* the channel state has been updated based on the
2074         /// revoke_and_ack message.
2075         pub fn revoke_and_ack<F: Deref>(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &F) -> Result<(Option<msgs::CommitmentUpdate>, Vec<(PendingHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option<msgs::ClosingSigned>, ChannelMonitorUpdate), ChannelError>
2076                 where F::Target: FeeEstimator
2077         {
2078                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2079                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state"));
2080                 }
2081                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2082                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish"));
2083                 }
2084                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2085                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds"));
2086                 }
2087
2088                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
2089                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret")) != their_prev_commitment_point {
2090                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey"));
2091                         }
2092                 }
2093
2094                 if self.channel_state & ChannelState::AwaitingRemoteRevoke as u32 == 0 {
2095                         // Our counterparty seems to have burned their coins to us (by revoking a state when we
2096                         // haven't given them a new commitment transaction to broadcast). We should probably
2097                         // take advantage of this by updating our channel monitor, sending them an error, and
2098                         // waiting for them to broadcast their latest (now-revoked claim). But, that would be a
2099                         // lot of work, and there's some chance this is all a misunderstanding anyway.
2100                         // We have to do *something*, though, since our signer may get mad at us for otherwise
2101                         // jumping a remote commitment number, so best to just force-close and move on.
2102                         return Err(ChannelError::Close("Received an unexpected revoke_and_ack"));
2103                 }
2104
2105                 self.commitment_secrets.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret)
2106                         .map_err(|_| ChannelError::Close("Previous secrets did not match new one"))?;
2107                 self.latest_monitor_update_id += 1;
2108                 let mut monitor_update = ChannelMonitorUpdate {
2109                         update_id: self.latest_monitor_update_id,
2110                         updates: vec![ChannelMonitorUpdateStep::CommitmentSecret {
2111                                 idx: self.cur_remote_commitment_transaction_number + 1,
2112                                 secret: msg.per_commitment_secret,
2113                         }],
2114                 };
2115                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
2116
2117                 // Update state now that we've passed all the can-fail calls...
2118                 // (note that we may still fail to generate the new commitment_signed message, but that's
2119                 // OK, we step the channel here and *then* if the new generation fails we can fail the
2120                 // channel based on that, but stepping stuff here should be safe either way.
2121                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
2122                 self.their_prev_commitment_point = self.their_cur_commitment_point;
2123                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
2124                 self.cur_remote_commitment_transaction_number -= 1;
2125
2126                 log_trace!(self, "Updating HTLCs on receipt of RAA...");
2127                 let mut to_forward_infos = Vec::new();
2128                 let mut revoked_htlcs = Vec::new();
2129                 let mut update_fail_htlcs = Vec::new();
2130                 let mut update_fail_malformed_htlcs = Vec::new();
2131                 let mut require_commitment = false;
2132                 let mut value_to_self_msat_diff: i64 = 0;
2133
2134                 {
2135                         // Take references explicitly so that we can hold multiple references to self.
2136                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
2137                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
2138                         let logger = LogHolder { logger: &self.logger };
2139
2140                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
2141                         pending_inbound_htlcs.retain(|htlc| {
2142                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2143                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
2144                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
2145                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
2146                                         }
2147                                         false
2148                                 } else { true }
2149                         });
2150                         pending_outbound_htlcs.retain(|htlc| {
2151                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) = &htlc.state {
2152                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
2153                                         if let Some(reason) = fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
2154                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
2155                                         } else {
2156                                                 // They fulfilled, so we sent them money
2157                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
2158                                         }
2159                                         false
2160                                 } else { true }
2161                         });
2162                         for htlc in pending_inbound_htlcs.iter_mut() {
2163                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
2164                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to Committed", log_bytes!(htlc.payment_hash.0));
2165                                         true
2166                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
2167                                         log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
2168                                         true
2169                                 } else { false };
2170                                 if swap {
2171                                         let mut state = InboundHTLCState::Committed;
2172                                         mem::swap(&mut state, &mut htlc.state);
2173
2174                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
2175                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
2176                                                 require_commitment = true;
2177                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
2178                                                 match forward_info {
2179                                                         PendingHTLCStatus::Fail(fail_msg) => {
2180                                                                 require_commitment = true;
2181                                                                 match fail_msg {
2182                                                                         HTLCFailureMsg::Relay(msg) => {
2183                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
2184                                                                                 update_fail_htlcs.push(msg)
2185                                                                         },
2186                                                                         HTLCFailureMsg::Malformed(msg) => {
2187                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
2188                                                                                 update_fail_malformed_htlcs.push(msg)
2189                                                                         },
2190                                                                 }
2191                                                         },
2192                                                         PendingHTLCStatus::Forward(forward_info) => {
2193                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
2194                                                                 htlc.state = InboundHTLCState::Committed;
2195                                                         }
2196                                                 }
2197                                         }
2198                                 }
2199                         }
2200                         for htlc in pending_outbound_htlcs.iter_mut() {
2201                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
2202                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
2203                                         htlc.state = OutboundHTLCState::Committed;
2204                                 }
2205                                 if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
2206                                         Some(fail_reason.take())
2207                                 } else { None } {
2208                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
2209                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
2210                                         require_commitment = true;
2211                                 }
2212                         }
2213                 }
2214                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
2215
2216                 if self.channel_outbound {
2217                         if let Some(feerate) = self.pending_update_fee.take() {
2218                                 self.feerate_per_kw = feerate;
2219                         }
2220                 } else {
2221                         if let Some(feerate) = self.pending_update_fee {
2222                                 // Because a node cannot send two commitment_signeds in a row without getting a
2223                                 // revoke_and_ack from us (as it would otherwise not know the per_commitment_point
2224                                 // it should use to create keys with) and because a node can't send a
2225                                 // commitment_signed without changes, checking if the feerate is equal to the
2226                                 // pending feerate update is sufficient to detect require_commitment.
2227                                 if feerate == self.feerate_per_kw {
2228                                         require_commitment = true;
2229                                         self.pending_update_fee = None;
2230                                 }
2231                         }
2232                 }
2233
2234                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
2235                         // We can't actually generate a new commitment transaction (incl by freeing holding
2236                         // cells) while we can't update the monitor, so we just return what we have.
2237                         if require_commitment {
2238                                 self.monitor_pending_commitment_signed = true;
2239                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
2240                                 // which does not update state, but we're definitely now awaiting a remote revoke
2241                                 // before we can step forward any more, so set it here.
2242                                 let (_, mut additional_update) = self.send_commitment_no_status_check()?;
2243                                 // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2244                                 // strictly increasing by one, so decrement it here.
2245                                 self.latest_monitor_update_id = monitor_update.update_id;
2246                                 monitor_update.updates.append(&mut additional_update.updates);
2247                         }
2248                         self.monitor_pending_forwards.append(&mut to_forward_infos);
2249                         self.monitor_pending_failures.append(&mut revoked_htlcs);
2250                         return Ok((None, Vec::new(), Vec::new(), None, monitor_update))
2251                 }
2252
2253                 match self.free_holding_cell_htlcs()? {
2254                         Some((mut commitment_update, mut additional_update)) => {
2255                                 commitment_update.update_fail_htlcs.reserve(update_fail_htlcs.len());
2256                                 for fail_msg in update_fail_htlcs.drain(..) {
2257                                         commitment_update.update_fail_htlcs.push(fail_msg);
2258                                 }
2259                                 commitment_update.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
2260                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
2261                                         commitment_update.update_fail_malformed_htlcs.push(fail_msg);
2262                                 }
2263
2264                                 // free_holding_cell_htlcs may bump latest_monitor_id multiple times but we want them to be
2265                                 // strictly increasing by one, so decrement it here.
2266                                 self.latest_monitor_update_id = monitor_update.update_id;
2267                                 monitor_update.updates.append(&mut additional_update.updates);
2268
2269                                 Ok((Some(commitment_update), to_forward_infos, revoked_htlcs, None, monitor_update))
2270                         },
2271                         None => {
2272                                 if require_commitment {
2273                                         let (commitment_signed, mut additional_update) = self.send_commitment_no_status_check()?;
2274
2275                                         // send_commitment_no_status_check may bump latest_monitor_id but we want them to be
2276                                         // strictly increasing by one, so decrement it here.
2277                                         self.latest_monitor_update_id = monitor_update.update_id;
2278                                         monitor_update.updates.append(&mut additional_update.updates);
2279
2280                                         Ok((Some(msgs::CommitmentUpdate {
2281                                                 update_add_htlcs: Vec::new(),
2282                                                 update_fulfill_htlcs: Vec::new(),
2283                                                 update_fail_htlcs,
2284                                                 update_fail_malformed_htlcs,
2285                                                 update_fee: None,
2286                                                 commitment_signed
2287                                         }), to_forward_infos, revoked_htlcs, None, monitor_update))
2288                                 } else {
2289                                         Ok((None, to_forward_infos, revoked_htlcs, self.maybe_propose_first_closing_signed(fee_estimator), monitor_update))
2290                                 }
2291                         }
2292                 }
2293
2294         }
2295
2296         /// Adds a pending update to this channel. See the doc for send_htlc for
2297         /// further details on the optionness of the return value.
2298         /// You MUST call send_commitment prior to any other calls on this Channel
2299         fn send_update_fee(&mut self, feerate_per_kw: u64) -> Option<msgs::UpdateFee> {
2300                 if !self.channel_outbound {
2301                         panic!("Cannot send fee from inbound channel");
2302                 }
2303                 if !self.is_usable() {
2304                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
2305                 }
2306                 if !self.is_live() {
2307                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
2308                 }
2309
2310                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2311                         self.holding_cell_update_fee = Some(feerate_per_kw);
2312                         return None;
2313                 }
2314
2315                 debug_assert!(self.pending_update_fee.is_none());
2316                 self.pending_update_fee = Some(feerate_per_kw);
2317
2318                 Some(msgs::UpdateFee {
2319                         channel_id: self.channel_id,
2320                         feerate_per_kw: feerate_per_kw as u32,
2321                 })
2322         }
2323
2324         pub fn send_update_fee_and_commit(&mut self, feerate_per_kw: u64) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> {
2325                 match self.send_update_fee(feerate_per_kw) {
2326                         Some(update_fee) => {
2327                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2328                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
2329                         },
2330                         None => Ok(None)
2331                 }
2332         }
2333
2334         /// Removes any uncommitted HTLCs, to be used on peer disconnection, including any pending
2335         /// HTLCs that we intended to add but haven't as we were waiting on a remote revoke.
2336         /// Returns the set of PendingHTLCStatuses from remote uncommitted HTLCs (which we're
2337         /// implicitly dropping) and the payment_hashes of HTLCs we tried to add but are dropping.
2338         /// No further message handling calls may be made until a channel_reestablish dance has
2339         /// completed.
2340         pub fn remove_uncommitted_htlcs_and_mark_paused(&mut self) -> Vec<(HTLCSource, PaymentHash)> {
2341                 let mut outbound_drops = Vec::new();
2342
2343                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2344                 if self.channel_state < ChannelState::FundingSent as u32 {
2345                         self.channel_state = ChannelState::ShutdownComplete as u32;
2346                         return outbound_drops;
2347                 }
2348                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
2349                 // will be retransmitted.
2350                 self.last_sent_closing_fee = None;
2351
2352                 let mut inbound_drop_count = 0;
2353                 self.pending_inbound_htlcs.retain(|htlc| {
2354                         match htlc.state {
2355                                 InboundHTLCState::RemoteAnnounced(_) => {
2356                                         // They sent us an update_add_htlc but we never got the commitment_signed.
2357                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
2358                                         // this HTLC accordingly
2359                                         inbound_drop_count += 1;
2360                                         false
2361                                 },
2362                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
2363                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
2364                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
2365                                         // in response to it yet, so don't touch it.
2366                                         true
2367                                 },
2368                                 InboundHTLCState::Committed => true,
2369                                 InboundHTLCState::LocalRemoved(_) => {
2370                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
2371                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
2372                                         // (that we missed). Keep this around for now and if they tell us they missed
2373                                         // the commitment_signed we can re-transmit the update then.
2374                                         true
2375                                 },
2376                         }
2377                 });
2378                 self.next_remote_htlc_id -= inbound_drop_count;
2379
2380                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2381                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
2382                                 // They sent us an update to remove this but haven't yet sent the corresponding
2383                                 // commitment_signed, we need to move it back to Committed and they can re-send
2384                                 // the update upon reconnection.
2385                                 htlc.state = OutboundHTLCState::Committed;
2386                         }
2387                 }
2388
2389                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2390                         match htlc_update {
2391                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2392                                         outbound_drops.push((source.clone(), payment_hash.clone()));
2393                                         false
2394                                 },
2395                                 &HTLCUpdateAwaitingACK::ClaimHTLC {..} | &HTLCUpdateAwaitingACK::FailHTLC {..} => true,
2396                         }
2397                 });
2398                 self.channel_state |= ChannelState::PeerDisconnected as u32;
2399                 log_debug!(self, "Peer disconnection resulted in {} remote-announced HTLC drops and {} waiting-to-locally-announced HTLC drops on channel {}", outbound_drops.len(), inbound_drop_count, log_bytes!(self.channel_id()));
2400                 outbound_drops
2401         }
2402
2403         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
2404         /// updates are partially paused.
2405         /// This must be called immediately after the call which generated the ChannelMonitor update
2406         /// which failed. The messages which were generated from that call which generated the
2407         /// monitor update failure must *not* have been sent to the remote end, and must instead
2408         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
2409         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool, mut pending_forwards: Vec<(PendingHTLCInfo, u64)>, mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>) {
2410                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2411                 self.monitor_pending_revoke_and_ack = resend_raa;
2412                 self.monitor_pending_commitment_signed = resend_commitment;
2413                 assert!(self.monitor_pending_forwards.is_empty());
2414                 mem::swap(&mut pending_forwards, &mut self.monitor_pending_forwards);
2415                 assert!(self.monitor_pending_failures.is_empty());
2416                 mem::swap(&mut pending_fails, &mut self.monitor_pending_failures);
2417                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
2418         }
2419
2420         /// Indicates that the latest ChannelMonitor update has been committed by the client
2421         /// successfully and we should restore normal operation. Returns messages which should be sent
2422         /// to the remote side.
2423         pub fn monitor_updating_restored(&mut self) -> (Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, RAACommitmentOrder, Vec<(PendingHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, bool, Option<msgs::FundingLocked>) {
2424                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
2425                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
2426
2427                 let needs_broadcast_safe = self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.channel_outbound;
2428
2429                 // Because we will never generate a FundingBroadcastSafe event when we're in
2430                 // MonitorUpdateFailed, if we assume the user only broadcast the funding transaction when
2431                 // they received the FundingBroadcastSafe event, we can only ever hit
2432                 // monitor_pending_funding_locked when we're an inbound channel which failed to persist the
2433                 // monitor on funding_created, and we even got the funding transaction confirmed before the
2434                 // monitor was persisted.
2435                 let funding_locked = if self.monitor_pending_funding_locked {
2436                         assert!(!self.channel_outbound, "Funding transaction broadcast without FundingBroadcastSafe!");
2437                         self.monitor_pending_funding_locked = false;
2438                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2439                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2440                         Some(msgs::FundingLocked {
2441                                 channel_id: self.channel_id(),
2442                                 next_per_commitment_point: next_per_commitment_point,
2443                         })
2444                 } else { None };
2445
2446                 let mut forwards = Vec::new();
2447                 mem::swap(&mut forwards, &mut self.monitor_pending_forwards);
2448                 let mut failures = Vec::new();
2449                 mem::swap(&mut failures, &mut self.monitor_pending_failures);
2450
2451                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
2452                         self.monitor_pending_revoke_and_ack = false;
2453                         self.monitor_pending_commitment_signed = false;
2454                         return (None, None, RAACommitmentOrder::RevokeAndACKFirst, forwards, failures, needs_broadcast_safe, funding_locked);
2455                 }
2456
2457                 let raa = if self.monitor_pending_revoke_and_ack {
2458                         Some(self.get_last_revoke_and_ack())
2459                 } else { None };
2460                 let commitment_update = if self.monitor_pending_commitment_signed {
2461                         Some(self.get_last_commitment_update())
2462                 } else { None };
2463
2464                 self.monitor_pending_revoke_and_ack = false;
2465                 self.monitor_pending_commitment_signed = false;
2466                 let order = self.resend_order.clone();
2467                 log_trace!(self, "Restored monitor updating resulting in {}{} commitment update and {} RAA, with {} first",
2468                         if needs_broadcast_safe { "a funding broadcast safe, " } else { "" },
2469                         if commitment_update.is_some() { "a" } else { "no" },
2470                         if raa.is_some() { "an" } else { "no" },
2471                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
2472                 (raa, commitment_update, order, forwards, failures, needs_broadcast_safe, funding_locked)
2473         }
2474
2475         pub fn update_fee<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::UpdateFee) -> Result<(), ChannelError>
2476                 where F::Target: FeeEstimator
2477         {
2478                 if self.channel_outbound {
2479                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee"));
2480                 }
2481                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2482                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish"));
2483                 }
2484                 Channel::<ChanSigner>::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
2485                 self.pending_update_fee = Some(msg.feerate_per_kw as u64);
2486                 self.update_time_counter += 1;
2487                 Ok(())
2488         }
2489
2490         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
2491                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number));
2492                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed(), self.cur_local_commitment_transaction_number + 2);
2493                 msgs::RevokeAndACK {
2494                         channel_id: self.channel_id,
2495                         per_commitment_secret,
2496                         next_per_commitment_point,
2497                 }
2498         }
2499
2500         fn get_last_commitment_update(&self) -> msgs::CommitmentUpdate {
2501                 let mut update_add_htlcs = Vec::new();
2502                 let mut update_fulfill_htlcs = Vec::new();
2503                 let mut update_fail_htlcs = Vec::new();
2504                 let mut update_fail_malformed_htlcs = Vec::new();
2505
2506                 for htlc in self.pending_outbound_htlcs.iter() {
2507                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
2508                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
2509                                         channel_id: self.channel_id(),
2510                                         htlc_id: htlc.htlc_id,
2511                                         amount_msat: htlc.amount_msat,
2512                                         payment_hash: htlc.payment_hash,
2513                                         cltv_expiry: htlc.cltv_expiry,
2514                                         onion_routing_packet: (**onion_packet).clone(),
2515                                 });
2516                         }
2517                 }
2518
2519                 for htlc in self.pending_inbound_htlcs.iter() {
2520                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2521                                 match reason {
2522                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
2523                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
2524                                                         channel_id: self.channel_id(),
2525                                                         htlc_id: htlc.htlc_id,
2526                                                         reason: err_packet.clone()
2527                                                 });
2528                                         },
2529                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
2530                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
2531                                                         channel_id: self.channel_id(),
2532                                                         htlc_id: htlc.htlc_id,
2533                                                         sha256_of_onion: sha256_of_onion.clone(),
2534                                                         failure_code: failure_code.clone(),
2535                                                 });
2536                                         },
2537                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
2538                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
2539                                                         channel_id: self.channel_id(),
2540                                                         htlc_id: htlc.htlc_id,
2541                                                         payment_preimage: payment_preimage.clone(),
2542                                                 });
2543                                         },
2544                                 }
2545                         }
2546                 }
2547
2548                 log_trace!(self, "Regenerated latest commitment update with {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
2549                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
2550                 msgs::CommitmentUpdate {
2551                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2552                         update_fee: None,
2553                         commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
2554                 }
2555         }
2556
2557         /// May panic if some calls other than message-handling calls (which will all Err immediately)
2558         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
2559         pub fn channel_reestablish(&mut self, msg: &msgs::ChannelReestablish) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitorUpdate>, RAACommitmentOrder, Option<msgs::Shutdown>), ChannelError> {
2560                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
2561                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
2562                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
2563                         // just close here instead of trying to recover.
2564                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect"));
2565                 }
2566
2567                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
2568                         msg.next_local_commitment_number == 0 {
2569                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish"));
2570                 }
2571
2572                 if msg.next_remote_commitment_number > 0 {
2573                         match msg.data_loss_protect {
2574                                 OptionalField::Present(ref data_loss) => {
2575                                         if chan_utils::build_commitment_secret(self.local_keys.commitment_seed(), INITIAL_COMMITMENT_NUMBER - msg.next_remote_commitment_number + 1) != data_loss.your_last_per_commitment_secret {
2576                                                 return Err(ChannelError::Close("Peer sent a garbage channel_reestablish with secret key not matching the commitment height provided"));
2577                                         }
2578                                         if msg.next_remote_commitment_number > INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number {
2579                                                 self.latest_monitor_update_id += 1;
2580                                                 let monitor_update = ChannelMonitorUpdate {
2581                                                         update_id: self.latest_monitor_update_id,
2582                                                         updates: vec![ChannelMonitorUpdateStep::RescueRemoteCommitmentTXInfo {
2583                                                                 their_current_per_commitment_point: data_loss.my_current_per_commitment_point
2584                                                         }]
2585                                                 };
2586                                                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
2587                                                 return Err(ChannelError::CloseDelayBroadcast {
2588                                                         msg: "We have fallen behind - we have received proof that if we broadcast remote is going to claim our funds - we can't do any automated broadcasting",
2589                                                         update: monitor_update
2590                                                 });
2591                                         }
2592                                 },
2593                                 OptionalField::Absent => {}
2594                         }
2595                 }
2596
2597                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
2598                 // remaining cases either succeed or ErrorMessage-fail).
2599                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
2600
2601                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
2602                         Some(msgs::Shutdown {
2603                                 channel_id: self.channel_id,
2604                                 scriptpubkey: self.get_closing_scriptpubkey(),
2605                         })
2606                 } else { None };
2607
2608                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
2609                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
2610                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
2611                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2612                                 if msg.next_remote_commitment_number != 0 {
2613                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet"));
2614                                 }
2615                                 // Short circuit the whole handler as there is nothing we can resend them
2616                                 return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2617                         }
2618
2619                         // We have OurFundingLocked set!
2620                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2621                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2622                         return Ok((Some(msgs::FundingLocked {
2623                                 channel_id: self.channel_id(),
2624                                 next_per_commitment_point: next_per_commitment_point,
2625                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2626                 }
2627
2628                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number {
2629                         // Remote isn't waiting on any RevokeAndACK from us!
2630                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
2631                         None
2632                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_local_commitment_transaction_number {
2633                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2634                                 self.monitor_pending_revoke_and_ack = true;
2635                                 None
2636                         } else {
2637                                 Some(self.get_last_revoke_and_ack())
2638                         }
2639                 } else {
2640                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction"));
2641                 };
2642
2643                 // We increment cur_remote_commitment_transaction_number only upon receipt of
2644                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
2645                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
2646                 // the corresponding revoke_and_ack back yet.
2647                 let our_next_remote_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
2648
2649                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number == 1 {
2650                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
2651                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2652                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2653                         Some(msgs::FundingLocked {
2654                                 channel_id: self.channel_id(),
2655                                 next_per_commitment_point: next_per_commitment_point,
2656                         })
2657                 } else { None };
2658
2659                 if msg.next_local_commitment_number == our_next_remote_commitment_number {
2660                         if required_revoke.is_some() {
2661                                 log_debug!(self, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
2662                         } else {
2663                                 log_debug!(self, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
2664                         }
2665
2666                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2667                                 // We're up-to-date and not waiting on a remote revoke (if we are our
2668                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
2669                                 // have received some updates while we were disconnected. Free the holding cell
2670                                 // now!
2671                                 match self.free_holding_cell_htlcs() {
2672                                         Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)),
2673                                         Err(ChannelError::Ignore(_)) | Err(ChannelError::CloseDelayBroadcast { .. }) => panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
2674                                         Ok(Some((commitment_update, monitor_update))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(monitor_update), self.resend_order.clone(), shutdown_msg)),
2675                                         Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), shutdown_msg)),
2676                                 }
2677                         } else {
2678                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), shutdown_msg));
2679                         }
2680                 } else if msg.next_local_commitment_number == our_next_remote_commitment_number - 1 {
2681                         if required_revoke.is_some() {
2682                                 log_debug!(self, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
2683                         } else {
2684                                 log_debug!(self, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
2685                         }
2686
2687                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2688                                 self.monitor_pending_commitment_signed = true;
2689                                 return Ok((resend_funding_locked, None, None, None, self.resend_order.clone(), shutdown_msg));
2690                         }
2691
2692                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, self.resend_order.clone(), shutdown_msg));
2693                 } else {
2694                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"));
2695                 }
2696         }
2697
2698         fn maybe_propose_first_closing_signed<F: Deref>(&mut self, fee_estimator: &F) -> Option<msgs::ClosingSigned>
2699                 where F::Target: FeeEstimator
2700         {
2701                 if !self.channel_outbound || !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() ||
2702                                 self.channel_state & (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32) != BOTH_SIDES_SHUTDOWN_MASK ||
2703                                 self.last_sent_closing_fee.is_some() || self.pending_update_fee.is_some() {
2704                         return None;
2705                 }
2706
2707                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2708                 if self.feerate_per_kw > proposed_feerate {
2709                         proposed_feerate = self.feerate_per_kw;
2710                 }
2711                 let tx_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2712                 let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
2713
2714                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
2715                 let our_sig = self.local_keys
2716                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
2717                         .ok();
2718                 if our_sig.is_none() { return None; }
2719
2720                 self.last_sent_closing_fee = Some((proposed_feerate, total_fee_satoshis, our_sig.clone().unwrap()));
2721                 Some(msgs::ClosingSigned {
2722                         channel_id: self.channel_id,
2723                         fee_satoshis: total_fee_satoshis,
2724                         signature: our_sig.unwrap(),
2725                 })
2726         }
2727
2728         pub fn shutdown<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<(HTLCSource, PaymentHash)>), ChannelError>
2729                 where F::Target: FeeEstimator
2730         {
2731                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2732                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish"));
2733                 }
2734                 if self.channel_state < ChannelState::FundingSent as u32 {
2735                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
2736                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
2737                         // can do that via error message without getting a connection fail anyway...
2738                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation"));
2739                 }
2740                 for htlc in self.pending_inbound_htlcs.iter() {
2741                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
2742                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs"));
2743                         }
2744                 }
2745                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2746
2747                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
2748                 // 34 bytes in length, so don't let the remote peer feed us some super fee-heavy script.
2749                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
2750                         return Err(ChannelError::Close("Got shutdown_scriptpubkey of absurd length from remote peer"));
2751                 }
2752
2753                 //Check shutdown_scriptpubkey form as BOLT says we must
2754                 if !msg.scriptpubkey.is_p2pkh() && !msg.scriptpubkey.is_p2sh() && !msg.scriptpubkey.is_v0_p2wpkh() && !msg.scriptpubkey.is_v0_p2wsh() {
2755                         return Err(ChannelError::Close("Got a nonstandard scriptpubkey from remote peer"));
2756                 }
2757
2758                 if self.their_shutdown_scriptpubkey.is_some() {
2759                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
2760                                 return Err(ChannelError::Close("Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey"));
2761                         }
2762                 } else {
2763                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
2764                 }
2765
2766                 // From here on out, we may not fail!
2767
2768                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
2769                 self.update_time_counter += 1;
2770
2771                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2772                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2773                 // cell HTLCs and return them to fail the payment.
2774                 self.holding_cell_update_fee = None;
2775                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2776                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2777                         match htlc_update {
2778                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2779                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
2780                                         false
2781                                 },
2782                                 _ => true
2783                         }
2784                 });
2785                 // If we have any LocalAnnounced updates we'll probably just get back a update_fail_htlc
2786                 // immediately after the commitment dance, but we can send a Shutdown cause we won't send
2787                 // any further commitment updates after we set LocalShutdownSent.
2788
2789                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
2790                         None
2791                 } else {
2792                         Some(msgs::Shutdown {
2793                                 channel_id: self.channel_id,
2794                                 scriptpubkey: self.get_closing_scriptpubkey(),
2795                         })
2796                 };
2797
2798                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
2799                 self.update_time_counter += 1;
2800
2801                 Ok((our_shutdown, self.maybe_propose_first_closing_signed(fee_estimator), dropped_outbound_htlcs))
2802         }
2803
2804         fn build_signed_closing_transaction(&self, tx: &mut Transaction, their_sig: &Signature, our_sig: &Signature) {
2805                 if tx.input.len() != 1 { panic!("Tried to sign closing transaction that had input count != 1!"); }
2806                 if tx.input[0].witness.len() != 0 { panic!("Tried to re-sign closing transaction"); }
2807                 if tx.output.len() > 2 { panic!("Tried to sign bogus closing transaction"); }
2808
2809                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
2810
2811                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()).serialize();
2812                 let their_funding_key = self.their_funding_pubkey().serialize();
2813                 if our_funding_key[..] < their_funding_key[..] {
2814                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
2815                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
2816                 } else {
2817                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
2818                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
2819                 }
2820                 tx.input[0].witness[1].push(SigHashType::All as u8);
2821                 tx.input[0].witness[2].push(SigHashType::All as u8);
2822
2823                 tx.input[0].witness.push(self.get_funding_redeemscript().into_bytes());
2824         }
2825
2826         pub fn closing_signed<F: Deref>(&mut self, fee_estimator: &F, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError>
2827                 where F::Target: FeeEstimator
2828         {
2829                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
2830                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown"));
2831                 }
2832                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2833                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish"));
2834                 }
2835                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
2836                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs"));
2837                 }
2838                 if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction
2839                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee"));
2840                 }
2841
2842                 let funding_redeemscript = self.get_funding_redeemscript();
2843                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
2844                 if used_total_fee != msg.fee_satoshis {
2845                         return Err(ChannelError::Close("Remote sent us a closing_signed with a fee greater than the value they can claim"));
2846                 }
2847                 let mut sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2848
2849                 let their_funding_pubkey = &self.their_pubkeys.as_ref().unwrap().funding_pubkey;
2850
2851                 match self.secp_ctx.verify(&sighash, &msg.signature, their_funding_pubkey) {
2852                         Ok(_) => {},
2853                         Err(_e) => {
2854                                 // The remote end may have decided to revoke their output due to inconsistent dust
2855                                 // limits, so check for that case by re-checking the signature here.
2856                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
2857                                 sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2858                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, self.their_funding_pubkey()), "Invalid closing tx signature from peer");
2859                         },
2860                 };
2861
2862                 if let Some((_, last_fee, our_sig)) = self.last_sent_closing_fee {
2863                         if last_fee == msg.fee_satoshis {
2864                                 self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &our_sig);
2865                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2866                                 self.update_time_counter += 1;
2867                                 return Ok((None, Some(closing_tx)));
2868                         }
2869                 }
2870
2871                 macro_rules! propose_new_feerate {
2872                         ($new_feerate: expr) => {
2873                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2874                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
2875                                 let our_sig = self.local_keys
2876                                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
2877                                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction"))?;
2878                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee, our_sig.clone()));
2879                                 return Ok((Some(msgs::ClosingSigned {
2880                                         channel_id: self.channel_id,
2881                                         fee_satoshis: used_total_fee,
2882                                         signature: our_sig,
2883                                 }), None))
2884                         }
2885                 }
2886
2887                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight() as u64;
2888                 if self.channel_outbound {
2889                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
2890                         if proposed_sat_per_kw > our_max_feerate {
2891                                 if let Some((last_feerate, _, _)) = self.last_sent_closing_fee {
2892                                         if our_max_feerate <= last_feerate {
2893                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate"));
2894                                         }
2895                                 }
2896                                 propose_new_feerate!(our_max_feerate);
2897                         }
2898                 } else {
2899                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2900                         if proposed_sat_per_kw < our_min_feerate {
2901                                 if let Some((last_feerate, _, _)) = self.last_sent_closing_fee {
2902                                         if our_min_feerate >= last_feerate {
2903                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate"));
2904                                         }
2905                                 }
2906                                 propose_new_feerate!(our_min_feerate);
2907                         }
2908                 }
2909
2910                 let our_sig = self.local_keys
2911                         .sign_closing_transaction(&closing_tx, &self.secp_ctx)
2912                         .map_err(|_| ChannelError::Close("External signer refused to sign closing transaction"))?;
2913                 self.build_signed_closing_transaction(&mut closing_tx, &msg.signature, &our_sig);
2914
2915                 self.channel_state = ChannelState::ShutdownComplete as u32;
2916                 self.update_time_counter += 1;
2917
2918                 Ok((Some(msgs::ClosingSigned {
2919                         channel_id: self.channel_id,
2920                         fee_satoshis: msg.fee_satoshis,
2921                         signature: our_sig,
2922                 }), Some(closing_tx)))
2923         }
2924
2925         // Public utilities:
2926
2927         pub fn channel_id(&self) -> [u8; 32] {
2928                 self.channel_id
2929         }
2930
2931         /// Gets the "user_id" value passed into the construction of this channel. It has no special
2932         /// meaning and exists only to allow users to have a persistent identifier of a channel.
2933         pub fn get_user_id(&self) -> u64 {
2934                 self.user_id
2935         }
2936
2937         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
2938         pub fn channel_monitor(&mut self) -> &mut ChannelMonitor<ChanSigner> {
2939                 if self.channel_state < ChannelState::FundingCreated as u32 {
2940                         panic!("Can't get a channel monitor until funding has been created");
2941                 }
2942                 self.channel_monitor.as_mut().unwrap()
2943         }
2944
2945         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
2946         /// is_usable() returns true).
2947         /// Allowed in any state (including after shutdown)
2948         pub fn get_short_channel_id(&self) -> Option<u64> {
2949                 self.short_channel_id
2950         }
2951
2952         /// Returns the funding_txo we either got from our peer, or were given by
2953         /// get_outbound_funding_created.
2954         pub fn get_funding_txo(&self) -> Option<OutPoint> {
2955                 self.funding_txo
2956         }
2957
2958         /// Allowed in any state (including after shutdown)
2959         pub fn get_their_node_id(&self) -> PublicKey {
2960                 self.their_node_id
2961         }
2962
2963         /// Allowed in any state (including after shutdown)
2964         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
2965                 self.our_htlc_minimum_msat
2966         }
2967
2968         /// Allowed in any state (including after shutdown)
2969         pub fn get_their_htlc_minimum_msat(&self) -> u64 {
2970                 self.our_htlc_minimum_msat
2971         }
2972
2973         pub fn get_value_satoshis(&self) -> u64 {
2974                 self.channel_value_satoshis
2975         }
2976
2977         pub fn get_fee_proportional_millionths(&self) -> u32 {
2978                 self.config.fee_proportional_millionths
2979         }
2980
2981         #[cfg(test)]
2982         pub fn get_feerate(&self) -> u64 {
2983                 self.feerate_per_kw
2984         }
2985
2986         pub fn get_cur_local_commitment_transaction_number(&self) -> u64 {
2987                 self.cur_local_commitment_transaction_number + 1
2988         }
2989
2990         pub fn get_cur_remote_commitment_transaction_number(&self) -> u64 {
2991                 self.cur_remote_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
2992         }
2993
2994         pub fn get_revoked_remote_commitment_transaction_number(&self) -> u64 {
2995                 self.cur_remote_commitment_transaction_number + 2
2996         }
2997
2998         #[cfg(test)]
2999         pub fn get_local_keys(&self) -> &ChanSigner {
3000                 &self.local_keys
3001         }
3002
3003         #[cfg(test)]
3004         pub fn get_value_stat(&self) -> ChannelValueStat {
3005                 ChannelValueStat {
3006                         value_to_self_msat: self.value_to_self_msat,
3007                         channel_value_msat: self.channel_value_satoshis * 1000,
3008                         channel_reserve_msat: self.their_channel_reserve_satoshis * 1000,
3009                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
3010                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
3011                         holding_cell_outbound_amount_msat: {
3012                                 let mut res = 0;
3013                                 for h in self.holding_cell_htlc_updates.iter() {
3014                                         match h {
3015                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
3016                                                         res += amount_msat;
3017                                                 }
3018                                                 _ => {}
3019                                         }
3020                                 }
3021                                 res
3022                         },
3023                         their_max_htlc_value_in_flight_msat: self.their_max_htlc_value_in_flight_msat,
3024                 }
3025         }
3026
3027         /// Allowed in any state (including after shutdown)
3028         pub fn get_update_time_counter(&self) -> u32 {
3029                 self.update_time_counter
3030         }
3031
3032         pub fn get_latest_monitor_update_id(&self) -> u64 {
3033                 self.latest_monitor_update_id
3034         }
3035
3036         pub fn should_announce(&self) -> bool {
3037                 self.config.announced_channel
3038         }
3039
3040         pub fn is_outbound(&self) -> bool {
3041                 self.channel_outbound
3042         }
3043
3044         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
3045         /// Allowed in any state (including after shutdown)
3046         pub fn get_our_fee_base_msat<F: Deref>(&self, fee_estimator: &F) -> u32
3047                 where F::Target: FeeEstimator
3048         {
3049                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
3050                 // output value back into a transaction with the regular channel output:
3051
3052                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
3053                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
3054
3055                 if self.channel_outbound {
3056                         // + the marginal fee increase cost to us in the commitment transaction:
3057                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
3058                 }
3059
3060                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
3061                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
3062
3063                 res as u32
3064         }
3065
3066         /// Returns true if we've ever received a message from the remote end for this Channel
3067         pub fn have_received_message(&self) -> bool {
3068                 self.channel_state > (ChannelState::OurInitSent as u32)
3069         }
3070
3071         /// Returns true if this channel is fully established and not known to be closing.
3072         /// Allowed in any state (including after shutdown)
3073         pub fn is_usable(&self) -> bool {
3074                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
3075                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
3076         }
3077
3078         /// Returns true if this channel is currently available for use. This is a superset of
3079         /// is_usable() and considers things like the channel being temporarily disabled.
3080         /// Allowed in any state (including after shutdown)
3081         pub fn is_live(&self) -> bool {
3082                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) == 0)
3083         }
3084
3085         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
3086         /// Allowed in any state (including after shutdown)
3087         pub fn is_awaiting_monitor_update(&self) -> bool {
3088                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
3089         }
3090
3091         /// Returns true if funding_created was sent/received.
3092         pub fn is_funding_initiated(&self) -> bool {
3093                 self.channel_state >= ChannelState::FundingCreated as u32
3094         }
3095
3096         /// Returns true if this channel is fully shut down. True here implies that no further actions
3097         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
3098         /// will be handled appropriately by the chain monitor.
3099         pub fn is_shutdown(&self) -> bool {
3100                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
3101                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
3102                         true
3103                 } else { false }
3104         }
3105
3106         pub fn to_disabled_staged(&mut self) {
3107                 self.network_sync = UpdateStatus::DisabledStaged;
3108         }
3109
3110         pub fn to_disabled_marked(&mut self) {
3111                 self.network_sync = UpdateStatus::DisabledMarked;
3112         }
3113
3114         pub fn to_fresh(&mut self) {
3115                 self.network_sync = UpdateStatus::Fresh;
3116         }
3117
3118         pub fn is_disabled_staged(&self) -> bool {
3119                 self.network_sync == UpdateStatus::DisabledStaged
3120         }
3121
3122         pub fn is_disabled_marked(&self) -> bool {
3123                 self.network_sync == UpdateStatus::DisabledMarked
3124         }
3125
3126         /// Called by channelmanager based on chain blocks being connected.
3127         /// Note that we only need to use this to detect funding_signed, anything else is handled by
3128         /// the channel_monitor.
3129         /// In case of Err, the channel may have been closed, at which point the standard requirements
3130         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
3131         /// Only returns an ErrorAction of DisconnectPeer, if Err.
3132         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, msgs::ErrorMessage> {
3133                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
3134                 if header.bitcoin_hash() != self.last_block_connected {
3135                         if self.funding_tx_confirmations > 0 {
3136                                 self.funding_tx_confirmations += 1;
3137                         }
3138                 }
3139                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
3140                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
3141                                 if tx.txid() == self.funding_txo.unwrap().txid {
3142                                         let txo_idx = self.funding_txo.unwrap().index as usize;
3143                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
3144                                                         tx.output[txo_idx].value != self.channel_value_satoshis {
3145                                                 if self.channel_outbound {
3146                                                         // If we generated the funding transaction and it doesn't match what it
3147                                                         // should, the client is really broken and we should just panic and
3148                                                         // tell them off. That said, because hash collisions happen with high
3149                                                         // probability in fuzztarget mode, if we're fuzzing we just close the
3150                                                         // channel and move on.
3151                                                         #[cfg(not(feature = "fuzztarget"))]
3152                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3153                                                 }
3154                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
3155                                                 self.update_time_counter += 1;
3156                                                 return Err(msgs::ErrorMessage {
3157                                                         channel_id: self.channel_id(),
3158                                                         data: "funding tx had wrong script/value".to_owned()
3159                                                 });
3160                                         } else {
3161                                                 if self.channel_outbound {
3162                                                         for input in tx.input.iter() {
3163                                                                 if input.witness.is_empty() {
3164                                                                         // We generated a malleable funding transaction, implying we've
3165                                                                         // just exposed ourselves to funds loss to our counterparty.
3166                                                                         #[cfg(not(feature = "fuzztarget"))]
3167                                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3168                                                                 }
3169                                                         }
3170                                                 }
3171                                                 self.funding_tx_confirmations = 1;
3172                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
3173                                                                              ((*index_in_block as u64) << (2*8)) |
3174                                                                              ((txo_idx as u64)         << (0*8)));
3175                                         }
3176                                 }
3177                         }
3178                 }
3179                 if header.bitcoin_hash() != self.last_block_connected {
3180                         self.last_block_connected = header.bitcoin_hash();
3181                         self.update_time_counter = cmp::max(self.update_time_counter, header.time);
3182                         if let Some(channel_monitor) = self.channel_monitor.as_mut() {
3183                                 channel_monitor.last_block_hash = self.last_block_connected;
3184                         }
3185                         if self.funding_tx_confirmations > 0 {
3186                                 if self.funding_tx_confirmations == self.minimum_depth as u64 {
3187                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
3188                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
3189                                                 true
3190                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
3191                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
3192                                                 self.update_time_counter += 1;
3193                                                 true
3194                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
3195                                                 // We got a reorg but not enough to trigger a force close, just update
3196                                                 // funding_tx_confirmed_in and return.
3197                                                 false
3198                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
3199                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
3200                                         } else {
3201                                                 // We got a reorg but not enough to trigger a force close, just update
3202                                                 // funding_tx_confirmed_in and return.
3203                                                 false
3204                                         };
3205                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
3206
3207                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
3208                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
3209                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
3210                                         //a protocol oversight, but I assume I'm just missing something.
3211                                         if need_commitment_update {
3212                                                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
3213                                                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3214                                                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
3215                                                         return Ok(Some(msgs::FundingLocked {
3216                                                                 channel_id: self.channel_id,
3217                                                                 next_per_commitment_point: next_per_commitment_point,
3218                                                         }));
3219                                                 } else {
3220                                                         self.monitor_pending_funding_locked = true;
3221                                                         return Ok(None);
3222                                                 }
3223                                         }
3224                                 }
3225                         }
3226                 }
3227                 Ok(None)
3228         }
3229
3230         /// Called by channelmanager based on chain blocks being disconnected.
3231         /// Returns true if we need to close the channel now due to funding transaction
3232         /// unconfirmation/reorg.
3233         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
3234                 if self.funding_tx_confirmations > 0 {
3235                         self.funding_tx_confirmations -= 1;
3236                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
3237                                 return true;
3238                         }
3239                 }
3240                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
3241                         self.funding_tx_confirmations = self.minimum_depth as u64 - 1;
3242                 }
3243                 self.last_block_connected = header.bitcoin_hash();
3244                 if let Some(channel_monitor) = self.channel_monitor.as_mut() {
3245                         channel_monitor.last_block_hash = self.last_block_connected;
3246                 }
3247                 false
3248         }
3249
3250         // Methods to get unprompted messages to send to the remote end (or where we already returned
3251         // something in the handler for the message that prompted this message):
3252
3253         pub fn get_open_channel<F: Deref>(&self, chain_hash: Sha256dHash, fee_estimator: &F) -> msgs::OpenChannel
3254                 where F::Target: FeeEstimator
3255         {
3256                 if !self.channel_outbound {
3257                         panic!("Tried to open a channel for an inbound channel?");
3258                 }
3259                 if self.channel_state != ChannelState::OurInitSent as u32 {
3260                         panic!("Cannot generate an open_channel after we've moved forward");
3261                 }
3262
3263                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3264                         panic!("Tried to send an open_channel for a channel that has already advanced");
3265                 }
3266
3267                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3268
3269                 msgs::OpenChannel {
3270                         chain_hash: chain_hash,
3271                         temporary_channel_id: self.channel_id,
3272                         funding_satoshis: self.channel_value_satoshis,
3273                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
3274                         dust_limit_satoshis: self.our_dust_limit_satoshis,
3275                         max_htlc_value_in_flight_msat: Channel::<ChanSigner>::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3276                         channel_reserve_satoshis: Channel::<ChanSigner>::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
3277                         htlc_minimum_msat: self.our_htlc_minimum_msat,
3278                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
3279                         to_self_delay: self.our_to_self_delay,
3280                         max_accepted_htlcs: OUR_MAX_HTLCS,
3281                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()),
3282                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.revocation_base_key()),
3283                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.payment_base_key()),
3284                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.delayed_payment_base_key()),
3285                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.htlc_base_key()),
3286                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
3287                         channel_flags: if self.config.announced_channel {1} else {0},
3288                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3289                 }
3290         }
3291
3292         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
3293                 if self.channel_outbound {
3294                         panic!("Tried to send accept_channel for an outbound channel?");
3295                 }
3296                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
3297                         panic!("Tried to send accept_channel after channel had moved forward");
3298                 }
3299                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3300                         panic!("Tried to send an accept_channel for a channel that has already advanced");
3301                 }
3302
3303                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3304
3305                 msgs::AcceptChannel {
3306                         temporary_channel_id: self.channel_id,
3307                         dust_limit_satoshis: self.our_dust_limit_satoshis,
3308                         max_htlc_value_in_flight_msat: Channel::<ChanSigner>::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3309                         channel_reserve_satoshis: Channel::<ChanSigner>::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
3310                         htlc_minimum_msat: self.our_htlc_minimum_msat,
3311                         minimum_depth: self.minimum_depth,
3312                         to_self_delay: self.our_to_self_delay,
3313                         max_accepted_htlcs: OUR_MAX_HTLCS,
3314                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key()),
3315                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.revocation_base_key()),
3316                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.payment_base_key()),
3317                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.delayed_payment_base_key()),
3318                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.htlc_base_key()),
3319                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
3320                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3321                 }
3322         }
3323
3324         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
3325         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), ChannelError> {
3326                 let remote_keys = self.build_remote_transaction_keys()?;
3327                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
3328                 Ok((self.local_keys.sign_remote_commitment(self.feerate_per_kw, &remote_initial_commitment_tx, &remote_keys, &Vec::new(), self.our_to_self_delay, &self.secp_ctx)
3329                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed"))?.0, remote_initial_commitment_tx))
3330         }
3331
3332         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
3333         /// a funding_created message for the remote peer.
3334         /// Panics if called at some time other than immediately after initial handshake, if called twice,
3335         /// or if called on an inbound channel.
3336         /// Note that channel_id changes during this call!
3337         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
3338         /// If an Err is returned, it is a ChannelError::Close.
3339         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor<ChanSigner>), ChannelError> {
3340                 if !self.channel_outbound {
3341                         panic!("Tried to create outbound funding_created message on an inbound channel!");
3342                 }
3343                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
3344                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
3345                 }
3346                 if self.commitment_secrets.get_min_seen_secret() != (1 << 48) ||
3347                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
3348                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3349                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
3350                 }
3351
3352                 self.funding_txo = Some(funding_txo.clone());
3353                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
3354                         Ok(res) => res,
3355                         Err(e) => {
3356                                 log_error!(self, "Got bad signatures: {:?}!", e);
3357                                 self.funding_txo = None;
3358                                 return Err(e);
3359                         }
3360                 };
3361
3362                 let temporary_channel_id = self.channel_id;
3363
3364                 // Now that we're past error-generating stuff, update our local state:
3365
3366                 let their_pubkeys = self.their_pubkeys.as_ref().unwrap();
3367                 let funding_redeemscript = self.get_funding_redeemscript();
3368                 let funding_txo_script = funding_redeemscript.to_v0_p2wsh();
3369                 macro_rules! create_monitor {
3370                         () => { {
3371                                 let mut channel_monitor = ChannelMonitor::new(self.local_keys.clone(),
3372                                                                               &self.shutdown_pubkey, self.our_to_self_delay,
3373                                                                               &self.destination_script, (funding_txo, funding_txo_script.clone()),
3374                                                                               &their_pubkeys.htlc_basepoint, &their_pubkeys.delayed_payment_basepoint,
3375                                                                               self.their_to_self_delay, funding_redeemscript.clone(), self.channel_value_satoshis,
3376                                                                               self.get_commitment_transaction_number_obscure_factor(),
3377                                                                               self.logger.clone());
3378
3379                                 channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
3380                                 channel_monitor
3381                         } }
3382                 }
3383
3384                 self.channel_monitor = Some(create_monitor!());
3385                 let channel_monitor = create_monitor!();
3386
3387                 self.channel_state = ChannelState::FundingCreated as u32;
3388                 self.channel_id = funding_txo.to_channel_id();
3389                 self.cur_remote_commitment_transaction_number -= 1;
3390
3391                 Ok((msgs::FundingCreated {
3392                         temporary_channel_id: temporary_channel_id,
3393                         funding_txid: funding_txo.txid,
3394                         funding_output_index: funding_txo.index,
3395                         signature: our_signature
3396                 }, channel_monitor))
3397         }
3398
3399         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
3400         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
3401         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
3402         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
3403         /// Will only fail if we're not in a state where channel_announcement may be sent (including
3404         /// closing).
3405         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
3406         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
3407         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
3408                 if !self.config.announced_channel {
3409                         return Err(ChannelError::Ignore("Channel is not available for public announcements"));
3410                 }
3411                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
3412                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked"));
3413                 }
3414                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
3415                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing"));
3416                 }
3417
3418                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
3419                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, self.local_keys.funding_key());
3420
3421                 let msg = msgs::UnsignedChannelAnnouncement {
3422                         features: ChannelFeatures::supported(),
3423                         chain_hash: chain_hash,
3424                         short_channel_id: self.get_short_channel_id().unwrap(),
3425                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
3426                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
3427                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey().clone() },
3428                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey().clone() } else { our_bitcoin_key },
3429                         excess_data: Vec::new(),
3430                 };
3431
3432                 let sig = self.local_keys.sign_channel_announcement(&msg, &self.secp_ctx)
3433                         .map_err(|_| ChannelError::Ignore("Signer rejected channel_announcement"))?;
3434
3435                 Ok((msg, sig))
3436         }
3437
3438         /// May panic if called on a channel that wasn't immediately-previously
3439         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
3440         pub fn get_channel_reestablish(&self) -> msgs::ChannelReestablish {
3441                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
3442                 assert_ne!(self.cur_remote_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
3443                 let data_loss_protect = if self.cur_remote_commitment_transaction_number + 1 < INITIAL_COMMITMENT_NUMBER {
3444                         let remote_last_secret = self.commitment_secrets.get_secret(self.cur_remote_commitment_transaction_number + 2).unwrap();
3445                         log_trace!(self, "Enough info to generate a Data Loss Protect with per_commitment_secret {}", log_bytes!(remote_last_secret));
3446                         OptionalField::Present(DataLossProtect {
3447                                 your_last_per_commitment_secret: remote_last_secret,
3448                                 my_current_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number + 1))
3449                         })
3450                 } else {
3451                         log_debug!(self, "We don't seen yet any revoked secret, if this channnel has already been updated it means we are fallen-behind, you should wait for other peer closing");
3452                         OptionalField::Present(DataLossProtect {
3453                                 your_last_per_commitment_secret: [0;32],
3454                                 my_current_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number))
3455                         })
3456                 };
3457                 msgs::ChannelReestablish {
3458                         channel_id: self.channel_id(),
3459                         // The protocol has two different commitment number concepts - the "commitment
3460                         // transaction number", which starts from 0 and counts up, and the "revocation key
3461                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
3462                         // commitment transaction numbers by the index which will be used to reveal the
3463                         // revocation key for that commitment transaction, which means we have to convert them
3464                         // to protocol-level commitment numbers here...
3465
3466                         // next_local_commitment_number is the next commitment_signed number we expect to
3467                         // receive (indicating if they need to resend one that we missed).
3468                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number,
3469                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
3470                         // receive, however we track it by the next commitment number for a remote transaction
3471                         // (which is one further, as they always revoke previous commitment transaction, not
3472                         // the one we send) so we have to decrement by 1. Note that if
3473                         // cur_remote_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
3474                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
3475                         // overflow here.
3476                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number - 1,
3477                         data_loss_protect,
3478                 }
3479         }
3480
3481
3482         // Send stuff to our remote peers:
3483
3484         /// Adds a pending outbound HTLC to this channel, note that you probably want
3485         /// send_htlc_and_commit instead cause you'll want both messages at once.
3486         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
3487         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
3488         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
3489         /// You MUST call send_commitment prior to any other calls on this Channel
3490         /// If an Err is returned, it's a ChannelError::Ignore!
3491         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> {
3492                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
3493                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down"));
3494                 }
3495
3496                 if amount_msat > self.channel_value_satoshis * 1000 {
3497                         return Err(ChannelError::Ignore("Cannot send more than the total value of the channel"));
3498                 }
3499
3500                 if amount_msat == 0 {
3501                         return Err(ChannelError::Ignore("Cannot send 0-msat HTLC"));
3502                 }
3503
3504                 if amount_msat < self.their_htlc_minimum_msat {
3505                         return Err(ChannelError::Ignore("Cannot send less than their minimum HTLC value"));
3506                 }
3507
3508                 if (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3509                         // Note that this should never really happen, if we're !is_live() on receipt of an
3510                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
3511                         // the user to send directly into a !is_live() channel. However, if we
3512                         // disconnected during the time the previous hop was doing the commitment dance we may
3513                         // end up getting here after the forwarding delay. In any case, returning an
3514                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
3515                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected/frozen for channel monitor update"));
3516                 }
3517
3518                 let (outbound_htlc_count, htlc_outbound_value_msat) = self.get_outbound_pending_htlc_stats();
3519                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
3520                         return Err(ChannelError::Ignore("Cannot push more than their max accepted HTLCs"));
3521                 }
3522                 // Check their_max_htlc_value_in_flight_msat
3523                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
3524                         return Err(ChannelError::Ignore("Cannot send value that would put us over the max HTLC value in flight our peer will accept"));
3525                 }
3526
3527                 // Check self.their_channel_reserve_satoshis (the amount we must keep as
3528                 // reserve for them to have something to claim if we misbehave)
3529                 if self.value_to_self_msat < self.their_channel_reserve_satoshis * 1000 + amount_msat + htlc_outbound_value_msat {
3530                         return Err(ChannelError::Ignore("Cannot send value that would put us over their reserve value"));
3531                 }
3532
3533                 //TODO: Check cltv_expiry? Do this in channel manager?
3534
3535                 // Now update local state:
3536                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3537                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
3538                                 amount_msat: amount_msat,
3539                                 payment_hash: payment_hash,
3540                                 cltv_expiry: cltv_expiry,
3541                                 source,
3542                                 onion_routing_packet: onion_routing_packet,
3543                         });
3544                         return Ok(None);
3545                 }
3546
3547                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
3548                         htlc_id: self.next_local_htlc_id,
3549                         amount_msat: amount_msat,
3550                         payment_hash: payment_hash.clone(),
3551                         cltv_expiry: cltv_expiry,
3552                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
3553                         source,
3554                 });
3555
3556                 let res = msgs::UpdateAddHTLC {
3557                         channel_id: self.channel_id,
3558                         htlc_id: self.next_local_htlc_id,
3559                         amount_msat: amount_msat,
3560                         payment_hash: payment_hash,
3561                         cltv_expiry: cltv_expiry,
3562                         onion_routing_packet: onion_routing_packet,
3563                 };
3564                 self.next_local_htlc_id += 1;
3565
3566                 Ok(Some(res))
3567         }
3568
3569         /// Creates a signed commitment transaction to send to the remote peer.
3570         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
3571         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
3572         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
3573         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> {
3574                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3575                         panic!("Cannot create commitment tx until channel is fully established");
3576                 }
3577                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3578                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
3579                 }
3580                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
3581                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3582                 }
3583                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
3584                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3585                 }
3586                 let mut have_updates = self.pending_update_fee.is_some();
3587                 for htlc in self.pending_outbound_htlcs.iter() {
3588                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3589                                 have_updates = true;
3590                         }
3591                         if have_updates { break; }
3592                 }
3593                 for htlc in self.pending_inbound_htlcs.iter() {
3594                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
3595                                 have_updates = true;
3596                         }
3597                         if have_updates { break; }
3598                 }
3599                 if !have_updates {
3600                         panic!("Cannot create commitment tx until we have some updates to send");
3601                 }
3602                 self.send_commitment_no_status_check()
3603         }
3604         /// Only fails in case of bad keys
3605         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitorUpdate), ChannelError> {
3606                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
3607                 // fail to generate this, we still are at least at a position where upgrading their status
3608                 // is acceptable.
3609                 for htlc in self.pending_inbound_htlcs.iter_mut() {
3610                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
3611                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
3612                         } else { None };
3613                         if let Some(state) = new_state {
3614                                 htlc.state = state;
3615                         }
3616                 }
3617                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3618                         if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
3619                                 Some(fail_reason.take())
3620                         } else { None } {
3621                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
3622                         }
3623                 }
3624                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
3625
3626                 let (res, remote_commitment_tx, htlcs) = match self.send_commitment_no_state_update() {
3627                         Ok((res, (remote_commitment_tx, mut htlcs))) => {
3628                                 // Update state now that we've passed all the can-fail calls...
3629                                 let htlcs_no_ref: Vec<(HTLCOutputInCommitment, Option<Box<HTLCSource>>)> =
3630                                         htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
3631                                 (res, remote_commitment_tx, htlcs_no_ref)
3632                         },
3633                         Err(e) => return Err(e),
3634                 };
3635
3636                 self.latest_monitor_update_id += 1;
3637                 let monitor_update = ChannelMonitorUpdate {
3638                         update_id: self.latest_monitor_update_id,
3639                         updates: vec![ChannelMonitorUpdateStep::LatestRemoteCommitmentTXInfo {
3640                                 unsigned_commitment_tx: remote_commitment_tx.clone(),
3641                                 htlc_outputs: htlcs.clone(),
3642                                 commitment_number: self.cur_remote_commitment_transaction_number,
3643                                 their_revocation_point: self.their_cur_commitment_point.unwrap()
3644                         }]
3645                 };
3646                 self.channel_monitor.as_mut().unwrap().update_monitor_ooo(monitor_update.clone()).unwrap();
3647                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
3648                 Ok((res, monitor_update))
3649         }
3650
3651         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
3652         /// when we shouldn't change HTLC/channel state.
3653         fn send_commitment_no_state_update(&self) -> Result<(msgs::CommitmentSigned, (Transaction, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> {
3654                 let mut feerate_per_kw = self.feerate_per_kw;
3655                 if let Some(feerate) = self.pending_update_fee {
3656                         if self.channel_outbound {
3657                                 feerate_per_kw = feerate;
3658                         }
3659                 }
3660
3661                 let remote_keys = self.build_remote_transaction_keys()?;
3662                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true, feerate_per_kw);
3663                 let (signature, htlc_signatures);
3664
3665                 {
3666                         let mut htlcs = Vec::with_capacity(remote_commitment_tx.2.len());
3667                         for &(ref htlc, _) in remote_commitment_tx.2.iter() {
3668                                 htlcs.push(htlc);
3669                         }
3670
3671                         let res = self.local_keys.sign_remote_commitment(feerate_per_kw, &remote_commitment_tx.0, &remote_keys, &htlcs, self.our_to_self_delay, &self.secp_ctx)
3672                                 .map_err(|_| ChannelError::Close("Failed to get signatures for new commitment_signed"))?;
3673                         signature = res.0;
3674                         htlc_signatures = res.1;
3675
3676                         log_trace!(self, "Signed remote commitment tx {} with redeemscript {} -> {}",
3677                                 encode::serialize_hex(&remote_commitment_tx.0),
3678                                 encode::serialize_hex(&self.get_funding_redeemscript()),
3679                                 log_bytes!(signature.serialize_compact()[..]));
3680
3681                         for (ref htlc_sig, ref htlc) in htlc_signatures.iter().zip(htlcs) {
3682                                 log_trace!(self, "Signed remote HTLC tx {} with redeemscript {} with pubkey {} -> {}",
3683                                         encode::serialize_hex(&chan_utils::build_htlc_transaction(&remote_commitment_tx.0.txid(), feerate_per_kw, self.our_to_self_delay, htlc, &remote_keys.a_delayed_payment_key, &remote_keys.revocation_key)),
3684                                         encode::serialize_hex(&chan_utils::get_htlc_redeemscript(&htlc, &remote_keys)),
3685                                         log_bytes!(remote_keys.a_htlc_key.serialize()),
3686                                         log_bytes!(htlc_sig.serialize_compact()[..]));
3687                         }
3688                 }
3689
3690                 Ok((msgs::CommitmentSigned {
3691                         channel_id: self.channel_id,
3692                         signature,
3693                         htlc_signatures,
3694                 }, (remote_commitment_tx.0, remote_commitment_tx.2)))
3695         }
3696
3697         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
3698         /// to send to the remote peer in one go.
3699         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
3700         /// more info.
3701         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitorUpdate)>, ChannelError> {
3702                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet)? {
3703                         Some(update_add_htlc) => {
3704                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
3705                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
3706                         },
3707                         None => Ok(None)
3708                 }
3709         }
3710
3711         /// Begins the shutdown process, getting a message for the remote peer and returning all
3712         /// holding cell HTLCs for payment failure.
3713         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<(HTLCSource, PaymentHash)>), APIError> {
3714                 for htlc in self.pending_outbound_htlcs.iter() {
3715                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3716                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first"});
3717                         }
3718                 }
3719                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
3720                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
3721                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress"});
3722                         }
3723                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
3724                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote"});
3725                         }
3726                 }
3727                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3728                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
3729                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?"});
3730                 }
3731
3732                 let our_closing_script = self.get_closing_scriptpubkey();
3733
3734                 // From here on out, we may not fail!
3735                 if self.channel_state < ChannelState::FundingSent as u32 {
3736                         self.channel_state = ChannelState::ShutdownComplete as u32;
3737                 } else {
3738                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
3739                 }
3740                 self.update_time_counter += 1;
3741
3742                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
3743                 // our shutdown until we've committed all of the pending changes.
3744                 self.holding_cell_update_fee = None;
3745                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3746                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3747                         match htlc_update {
3748                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3749                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3750                                         false
3751                                 },
3752                                 _ => true
3753                         }
3754                 });
3755
3756                 Ok((msgs::Shutdown {
3757                         channel_id: self.channel_id,
3758                         scriptpubkey: our_closing_script,
3759                 }, dropped_outbound_htlcs))
3760         }
3761
3762         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
3763         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
3764         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
3765         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
3766         /// immediately (others we will have to allow to time out).
3767         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<(HTLCSource, PaymentHash)>) {
3768                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
3769
3770                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
3771                 // return them to fail the payment.
3772                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3773                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
3774                         match htlc_update {
3775                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
3776                                         dropped_outbound_htlcs.push((source, payment_hash));
3777                                 },
3778                                 _ => {}
3779                         }
3780                 }
3781
3782                 for _htlc in self.pending_outbound_htlcs.drain(..) {
3783                         //TODO: Do something with the remaining HTLCs
3784                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
3785                         //which correspond)
3786                 }
3787
3788                 self.channel_state = ChannelState::ShutdownComplete as u32;
3789                 self.update_time_counter += 1;
3790                 if self.channel_monitor.is_some() {
3791                         (self.channel_monitor.as_mut().unwrap().get_latest_local_commitment_txn(), dropped_outbound_htlcs)
3792                 } else {
3793                         // We aren't even signed funding yet, so can't broadcast anything
3794                         (Vec::new(), dropped_outbound_htlcs)
3795                 }
3796         }
3797 }
3798
3799 const SERIALIZATION_VERSION: u8 = 1;
3800 const MIN_SERIALIZATION_VERSION: u8 = 1;
3801
3802 impl Writeable for InboundHTLCRemovalReason {
3803         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3804                 match self {
3805                         &InboundHTLCRemovalReason::FailRelay(ref error_packet) => {
3806                                 0u8.write(writer)?;
3807                                 error_packet.write(writer)?;
3808                         },
3809                         &InboundHTLCRemovalReason::FailMalformed((ref onion_hash, ref err_code)) => {
3810                                 1u8.write(writer)?;
3811                                 onion_hash.write(writer)?;
3812                                 err_code.write(writer)?;
3813                         },
3814                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3815                                 2u8.write(writer)?;
3816                                 payment_preimage.write(writer)?;
3817                         },
3818                 }
3819                 Ok(())
3820         }
3821 }
3822
3823 impl Readable for InboundHTLCRemovalReason {
3824         fn read<R: ::std::io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
3825                 Ok(match <u8 as Readable>::read(reader)? {
3826                         0 => InboundHTLCRemovalReason::FailRelay(Readable::read(reader)?),
3827                         1 => InboundHTLCRemovalReason::FailMalformed((Readable::read(reader)?, Readable::read(reader)?)),
3828                         2 => InboundHTLCRemovalReason::Fulfill(Readable::read(reader)?),
3829                         _ => return Err(DecodeError::InvalidValue),
3830                 })
3831         }
3832 }
3833
3834 impl<ChanSigner: ChannelKeys + Writeable> Writeable for Channel<ChanSigner> {
3835         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3836                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
3837                 // called but include holding cell updates (and obviously we don't modify self).
3838
3839                 writer.write_all(&[SERIALIZATION_VERSION; 1])?;
3840                 writer.write_all(&[MIN_SERIALIZATION_VERSION; 1])?;
3841
3842                 self.user_id.write(writer)?;
3843                 self.config.write(writer)?;
3844
3845                 self.channel_id.write(writer)?;
3846                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
3847                 self.channel_outbound.write(writer)?;
3848                 self.channel_value_satoshis.write(writer)?;
3849
3850                 self.latest_monitor_update_id.write(writer)?;
3851
3852                 self.local_keys.write(writer)?;
3853                 self.shutdown_pubkey.write(writer)?;
3854                 self.destination_script.write(writer)?;
3855
3856                 self.cur_local_commitment_transaction_number.write(writer)?;
3857                 self.cur_remote_commitment_transaction_number.write(writer)?;
3858                 self.value_to_self_msat.write(writer)?;
3859
3860                 let mut dropped_inbound_htlcs = 0;
3861                 for htlc in self.pending_inbound_htlcs.iter() {
3862                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3863                                 dropped_inbound_htlcs += 1;
3864                         }
3865                 }
3866                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
3867                 for htlc in self.pending_inbound_htlcs.iter() {
3868                         if let &InboundHTLCState::RemoteAnnounced(_) = &htlc.state {
3869                                 continue; // Drop
3870                         }
3871                         htlc.htlc_id.write(writer)?;
3872                         htlc.amount_msat.write(writer)?;
3873                         htlc.cltv_expiry.write(writer)?;
3874                         htlc.payment_hash.write(writer)?;
3875                         match &htlc.state {
3876                                 &InboundHTLCState::RemoteAnnounced(_) => unreachable!(),
3877                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
3878                                         1u8.write(writer)?;
3879                                         htlc_state.write(writer)?;
3880                                 },
3881                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
3882                                         2u8.write(writer)?;
3883                                         htlc_state.write(writer)?;
3884                                 },
3885                                 &InboundHTLCState::Committed => {
3886                                         3u8.write(writer)?;
3887                                 },
3888                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
3889                                         4u8.write(writer)?;
3890                                         removal_reason.write(writer)?;
3891                                 },
3892                         }
3893                 }
3894
3895                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
3896                 for htlc in self.pending_outbound_htlcs.iter() {
3897                         htlc.htlc_id.write(writer)?;
3898                         htlc.amount_msat.write(writer)?;
3899                         htlc.cltv_expiry.write(writer)?;
3900                         htlc.payment_hash.write(writer)?;
3901                         htlc.source.write(writer)?;
3902                         match &htlc.state {
3903                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
3904                                         0u8.write(writer)?;
3905                                         onion_packet.write(writer)?;
3906                                 },
3907                                 &OutboundHTLCState::Committed => {
3908                                         1u8.write(writer)?;
3909                                 },
3910                                 &OutboundHTLCState::RemoteRemoved(ref fail_reason) => {
3911                                         2u8.write(writer)?;
3912                                         fail_reason.write(writer)?;
3913                                 },
3914                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref fail_reason) => {
3915                                         3u8.write(writer)?;
3916                                         fail_reason.write(writer)?;
3917                                 },
3918                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) => {
3919                                         4u8.write(writer)?;
3920                                         fail_reason.write(writer)?;
3921                                 },
3922                         }
3923                 }
3924
3925                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
3926                 for update in self.holding_cell_htlc_updates.iter() {
3927                         match update {
3928                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
3929                                         0u8.write(writer)?;
3930                                         amount_msat.write(writer)?;
3931                                         cltv_expiry.write(writer)?;
3932                                         payment_hash.write(writer)?;
3933                                         source.write(writer)?;
3934                                         onion_routing_packet.write(writer)?;
3935                                 },
3936                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
3937                                         1u8.write(writer)?;
3938                                         payment_preimage.write(writer)?;
3939                                         htlc_id.write(writer)?;
3940                                 },
3941                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
3942                                         2u8.write(writer)?;
3943                                         htlc_id.write(writer)?;
3944                                         err_packet.write(writer)?;
3945                                 }
3946                         }
3947                 }
3948
3949                 match self.resend_order {
3950                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
3951                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
3952                 }
3953
3954                 self.monitor_pending_funding_locked.write(writer)?;
3955                 self.monitor_pending_revoke_and_ack.write(writer)?;
3956                 self.monitor_pending_commitment_signed.write(writer)?;
3957
3958                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
3959                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
3960                         pending_forward.write(writer)?;
3961                         htlc_id.write(writer)?;
3962                 }
3963
3964                 (self.monitor_pending_failures.len() as u64).write(writer)?;
3965                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
3966                         htlc_source.write(writer)?;
3967                         payment_hash.write(writer)?;
3968                         fail_reason.write(writer)?;
3969                 }
3970
3971                 self.pending_update_fee.write(writer)?;
3972                 self.holding_cell_update_fee.write(writer)?;
3973
3974                 self.next_local_htlc_id.write(writer)?;
3975                 (self.next_remote_htlc_id - dropped_inbound_htlcs).write(writer)?;
3976                 self.update_time_counter.write(writer)?;
3977                 self.feerate_per_kw.write(writer)?;
3978
3979                 match self.last_sent_closing_fee {
3980                         Some((feerate, fee, sig)) => {
3981                                 1u8.write(writer)?;
3982                                 feerate.write(writer)?;
3983                                 fee.write(writer)?;
3984                                 sig.write(writer)?;
3985                         },
3986                         None => 0u8.write(writer)?,
3987                 }
3988
3989                 self.funding_txo.write(writer)?;
3990                 self.funding_tx_confirmed_in.write(writer)?;
3991                 self.short_channel_id.write(writer)?;
3992
3993                 self.last_block_connected.write(writer)?;
3994                 self.funding_tx_confirmations.write(writer)?;
3995
3996                 self.their_dust_limit_satoshis.write(writer)?;
3997                 self.our_dust_limit_satoshis.write(writer)?;
3998                 self.their_max_htlc_value_in_flight_msat.write(writer)?;
3999                 self.their_channel_reserve_satoshis.write(writer)?;
4000                 self.their_htlc_minimum_msat.write(writer)?;
4001                 self.our_htlc_minimum_msat.write(writer)?;
4002                 self.their_to_self_delay.write(writer)?;
4003                 self.our_to_self_delay.write(writer)?;
4004                 self.their_max_accepted_htlcs.write(writer)?;
4005                 self.minimum_depth.write(writer)?;
4006
4007                 self.their_pubkeys.write(writer)?;
4008                 self.their_cur_commitment_point.write(writer)?;
4009
4010                 self.their_prev_commitment_point.write(writer)?;
4011                 self.their_node_id.write(writer)?;
4012
4013                 self.their_shutdown_scriptpubkey.write(writer)?;
4014
4015                 self.commitment_secrets.write(writer)?;
4016
4017                 self.channel_monitor.as_ref().unwrap().write_for_disk(writer)?;
4018                 Ok(())
4019         }
4020 }
4021
4022 impl<ChanSigner: ChannelKeys + Readable> ReadableArgs<Arc<Logger>> for Channel<ChanSigner> {
4023         fn read<R : ::std::io::Read>(reader: &mut R, logger: Arc<Logger>) -> Result<Self, DecodeError> {
4024                 let _ver: u8 = Readable::read(reader)?;
4025                 let min_ver: u8 = Readable::read(reader)?;
4026                 if min_ver > SERIALIZATION_VERSION {
4027                         return Err(DecodeError::UnknownVersion);
4028                 }
4029
4030                 let user_id = Readable::read(reader)?;
4031                 let config: ChannelConfig = Readable::read(reader)?;
4032
4033                 let channel_id = Readable::read(reader)?;
4034                 let channel_state = Readable::read(reader)?;
4035                 let channel_outbound = Readable::read(reader)?;
4036                 let channel_value_satoshis = Readable::read(reader)?;
4037
4038                 let latest_monitor_update_id = Readable::read(reader)?;
4039
4040                 let local_keys = Readable::read(reader)?;
4041                 let shutdown_pubkey = Readable::read(reader)?;
4042                 let destination_script = Readable::read(reader)?;
4043
4044                 let cur_local_commitment_transaction_number = Readable::read(reader)?;
4045                 let cur_remote_commitment_transaction_number = Readable::read(reader)?;
4046                 let value_to_self_msat = Readable::read(reader)?;
4047
4048                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
4049                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
4050                 for _ in 0..pending_inbound_htlc_count {
4051                         pending_inbound_htlcs.push(InboundHTLCOutput {
4052                                 htlc_id: Readable::read(reader)?,
4053                                 amount_msat: Readable::read(reader)?,
4054                                 cltv_expiry: Readable::read(reader)?,
4055                                 payment_hash: Readable::read(reader)?,
4056                                 state: match <u8 as Readable>::read(reader)? {
4057                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
4058                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
4059                                         3 => InboundHTLCState::Committed,
4060                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
4061                                         _ => return Err(DecodeError::InvalidValue),
4062                                 },
4063                         });
4064                 }
4065
4066                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
4067                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
4068                 for _ in 0..pending_outbound_htlc_count {
4069                         pending_outbound_htlcs.push(OutboundHTLCOutput {
4070                                 htlc_id: Readable::read(reader)?,
4071                                 amount_msat: Readable::read(reader)?,
4072                                 cltv_expiry: Readable::read(reader)?,
4073                                 payment_hash: Readable::read(reader)?,
4074                                 source: Readable::read(reader)?,
4075                                 state: match <u8 as Readable>::read(reader)? {
4076                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
4077                                         1 => OutboundHTLCState::Committed,
4078                                         2 => OutboundHTLCState::RemoteRemoved(Readable::read(reader)?),
4079                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove(Readable::read(reader)?),
4080                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke(Readable::read(reader)?),
4081                                         _ => return Err(DecodeError::InvalidValue),
4082                                 },
4083                         });
4084                 }
4085
4086                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
4087                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
4088                 for _ in 0..holding_cell_htlc_update_count {
4089                         holding_cell_htlc_updates.push(match <u8 as Readable>::read(reader)? {
4090                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
4091                                         amount_msat: Readable::read(reader)?,
4092                                         cltv_expiry: Readable::read(reader)?,
4093                                         payment_hash: Readable::read(reader)?,
4094                                         source: Readable::read(reader)?,
4095                                         onion_routing_packet: Readable::read(reader)?,
4096                                 },
4097                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
4098                                         payment_preimage: Readable::read(reader)?,
4099                                         htlc_id: Readable::read(reader)?,
4100                                 },
4101                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
4102                                         htlc_id: Readable::read(reader)?,
4103                                         err_packet: Readable::read(reader)?,
4104                                 },
4105                                 _ => return Err(DecodeError::InvalidValue),
4106                         });
4107                 }
4108
4109                 let resend_order = match <u8 as Readable>::read(reader)? {
4110                         0 => RAACommitmentOrder::CommitmentFirst,
4111                         1 => RAACommitmentOrder::RevokeAndACKFirst,
4112                         _ => return Err(DecodeError::InvalidValue),
4113                 };
4114
4115                 let monitor_pending_funding_locked = Readable::read(reader)?;
4116                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
4117                 let monitor_pending_commitment_signed = Readable::read(reader)?;
4118
4119                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
4120                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
4121                 for _ in 0..monitor_pending_forwards_count {
4122                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
4123                 }
4124
4125                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
4126                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
4127                 for _ in 0..monitor_pending_failures_count {
4128                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
4129                 }
4130
4131                 let pending_update_fee = Readable::read(reader)?;
4132                 let holding_cell_update_fee = Readable::read(reader)?;
4133
4134                 let next_local_htlc_id = Readable::read(reader)?;
4135                 let next_remote_htlc_id = Readable::read(reader)?;
4136                 let update_time_counter = Readable::read(reader)?;
4137                 let feerate_per_kw = Readable::read(reader)?;
4138
4139                 let last_sent_closing_fee = match <u8 as Readable>::read(reader)? {
4140                         0 => None,
4141                         1 => Some((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?)),
4142                         _ => return Err(DecodeError::InvalidValue),
4143                 };
4144
4145                 let funding_txo = Readable::read(reader)?;
4146                 let funding_tx_confirmed_in = Readable::read(reader)?;
4147                 let short_channel_id = Readable::read(reader)?;
4148
4149                 let last_block_connected = Readable::read(reader)?;
4150                 let funding_tx_confirmations = Readable::read(reader)?;
4151
4152                 let their_dust_limit_satoshis = Readable::read(reader)?;
4153                 let our_dust_limit_satoshis = Readable::read(reader)?;
4154                 let their_max_htlc_value_in_flight_msat = Readable::read(reader)?;
4155                 let their_channel_reserve_satoshis = Readable::read(reader)?;
4156                 let their_htlc_minimum_msat = Readable::read(reader)?;
4157                 let our_htlc_minimum_msat = Readable::read(reader)?;
4158                 let their_to_self_delay = Readable::read(reader)?;
4159                 let our_to_self_delay = Readable::read(reader)?;
4160                 let their_max_accepted_htlcs = Readable::read(reader)?;
4161                 let minimum_depth = Readable::read(reader)?;
4162
4163                 let their_pubkeys = Readable::read(reader)?;
4164                 let their_cur_commitment_point = Readable::read(reader)?;
4165
4166                 let their_prev_commitment_point = Readable::read(reader)?;
4167                 let their_node_id = Readable::read(reader)?;
4168
4169                 let their_shutdown_scriptpubkey = Readable::read(reader)?;
4170                 let commitment_secrets = Readable::read(reader)?;
4171
4172                 let (monitor_last_block, channel_monitor) = ReadableArgs::read(reader, logger.clone())?;
4173                 // We drop the ChannelMonitor's last block connected hash cause we don't actually bother
4174                 // doing full block connection operations on the internal ChannelMonitor copies
4175                 if monitor_last_block != last_block_connected {
4176                         return Err(DecodeError::InvalidValue);
4177                 }
4178
4179                 Ok(Channel {
4180                         user_id,
4181
4182                         config,
4183                         channel_id,
4184                         channel_state,
4185                         channel_outbound,
4186                         secp_ctx: Secp256k1::new(),
4187                         channel_value_satoshis,
4188
4189                         latest_monitor_update_id,
4190
4191                         local_keys,
4192                         shutdown_pubkey,
4193                         destination_script,
4194
4195                         cur_local_commitment_transaction_number,
4196                         cur_remote_commitment_transaction_number,
4197                         value_to_self_msat,
4198
4199                         pending_inbound_htlcs,
4200                         pending_outbound_htlcs,
4201                         holding_cell_htlc_updates,
4202
4203                         resend_order,
4204
4205                         monitor_pending_funding_locked,
4206                         monitor_pending_revoke_and_ack,
4207                         monitor_pending_commitment_signed,
4208                         monitor_pending_forwards,
4209                         monitor_pending_failures,
4210
4211                         pending_update_fee,
4212                         holding_cell_update_fee,
4213                         next_local_htlc_id,
4214                         next_remote_htlc_id,
4215                         update_time_counter,
4216                         feerate_per_kw,
4217
4218                         #[cfg(debug_assertions)]
4219                         max_commitment_tx_output_local: ::std::sync::Mutex::new((0, 0)),
4220                         #[cfg(debug_assertions)]
4221                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((0, 0)),
4222
4223                         last_sent_closing_fee,
4224
4225                         funding_txo,
4226                         funding_tx_confirmed_in,
4227                         short_channel_id,
4228                         last_block_connected,
4229                         funding_tx_confirmations,
4230
4231                         their_dust_limit_satoshis,
4232                         our_dust_limit_satoshis,
4233                         their_max_htlc_value_in_flight_msat,
4234                         their_channel_reserve_satoshis,
4235                         their_htlc_minimum_msat,
4236                         our_htlc_minimum_msat,
4237                         their_to_self_delay,
4238                         our_to_self_delay,
4239                         their_max_accepted_htlcs,
4240                         minimum_depth,
4241
4242                         their_pubkeys,
4243                         their_cur_commitment_point,
4244
4245                         their_prev_commitment_point,
4246                         their_node_id,
4247
4248                         their_shutdown_scriptpubkey,
4249
4250                         channel_monitor: Some(channel_monitor),
4251                         commitment_secrets,
4252
4253                         network_sync: UpdateStatus::Fresh,
4254
4255                         logger,
4256                 })
4257         }
4258 }
4259
4260 #[cfg(test)]
4261 mod tests {
4262         use bitcoin::util::bip143;
4263         use bitcoin::consensus::encode::serialize;
4264         use bitcoin::blockdata::script::{Script, Builder};
4265         use bitcoin::blockdata::transaction::Transaction;
4266         use bitcoin::blockdata::opcodes;
4267         use bitcoin_hashes::hex::FromHex;
4268         use hex;
4269         use ln::channelmanager::{HTLCSource, PaymentPreimage, PaymentHash};
4270         use ln::channel::{Channel,ChannelKeys,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,TxCreationKeys};
4271         use ln::channel::MAX_FUNDING_SATOSHIS;
4272         use ln::chan_utils;
4273         use ln::chan_utils::{LocalCommitmentTransaction, ChannelPublicKeys};
4274         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
4275         use chain::keysinterface::{InMemoryChannelKeys, KeysInterface};
4276         use chain::transaction::OutPoint;
4277         use util::config::UserConfig;
4278         use util::test_utils;
4279         use util::logger::Logger;
4280         use secp256k1::{Secp256k1, Message, Signature, All};
4281         use secp256k1::key::{SecretKey,PublicKey};
4282         use bitcoin_hashes::sha256::Hash as Sha256;
4283         use bitcoin_hashes::sha256d::Hash as Sha256dHash;
4284         use bitcoin_hashes::hash160::Hash as Hash160;
4285         use bitcoin_hashes::Hash;
4286         use std::sync::Arc;
4287
4288         struct TestFeeEstimator {
4289                 fee_est: u64
4290         }
4291         impl FeeEstimator for TestFeeEstimator {
4292                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
4293                         self.fee_est
4294                 }
4295         }
4296
4297         #[test]
4298         fn test_max_funding_satoshis() {
4299                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
4300                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
4301         }
4302
4303         struct Keys {
4304                 chan_keys: InMemoryChannelKeys,
4305         }
4306         impl KeysInterface for Keys {
4307                 type ChanKeySigner = InMemoryChannelKeys;
4308
4309                 fn get_node_secret(&self) -> SecretKey { panic!(); }
4310                 fn get_destination_script(&self) -> Script {
4311                         let secp_ctx = Secp256k1::signing_only();
4312                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4313                         let our_channel_monitor_claim_key_hash = Hash160::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
4314                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script()
4315                 }
4316
4317                 fn get_shutdown_pubkey(&self) -> PublicKey {
4318                         let secp_ctx = Secp256k1::signing_only();
4319                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4320                         PublicKey::from_secret_key(&secp_ctx, &channel_close_key)
4321                 }
4322
4323                 fn get_channel_keys(&self, _inbound: bool, _channel_value_satoshis: u64) -> InMemoryChannelKeys {
4324                         self.chan_keys.clone()
4325                 }
4326                 fn get_onion_rand(&self) -> (SecretKey, [u8; 32]) { panic!(); }
4327                 fn get_channel_id(&self) -> [u8; 32] { [0; 32] }
4328         }
4329
4330         fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {
4331                 PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode(hex).unwrap()[..]).unwrap())
4332         }
4333
4334         #[test]
4335         fn outbound_commitment_test() {
4336                 // Test vectors from BOLT 3 Appendix C:
4337                 let feeest = TestFeeEstimator{fee_est: 15000};
4338                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
4339                 let secp_ctx = Secp256k1::new();
4340
4341                 let chan_keys = InMemoryChannelKeys::new(
4342                         &secp_ctx,
4343                         SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
4344                         SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
4345                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
4346                         SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
4347                         SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
4348
4349                         // These aren't set in the test vectors:
4350                         [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
4351                         7000000000,
4352                 );
4353
4354                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, chan_keys.funding_key()).serialize()[..],
4355                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
4356                 let keys_provider = Keys { chan_keys };
4357
4358                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
4359                 let mut config = UserConfig::default();
4360                 config.channel_options.announced_channel = false;
4361                 let mut chan = Channel::<InMemoryChannelKeys>::new_outbound(&&feeest, &&keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test
4362                 chan.their_to_self_delay = 144;
4363                 chan.our_dust_limit_satoshis = 546;
4364
4365                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
4366                 chan.funding_txo = Some(funding_info);
4367
4368                 let their_pubkeys = ChannelPublicKeys {
4369                         funding_pubkey: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
4370                         revocation_basepoint: PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap(),
4371                         payment_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444"),
4372                         delayed_payment_basepoint: public_from_secret_hex(&secp_ctx, "1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13"),
4373                         htlc_basepoint: public_from_secret_hex(&secp_ctx, "4444444444444444444444444444444444444444444444444444444444444444")
4374                 };
4375
4376                 assert_eq!(their_pubkeys.payment_basepoint.serialize()[..],
4377                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
4378
4379                 assert_eq!(their_pubkeys.funding_pubkey.serialize()[..],
4380                            hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
4381
4382                 assert_eq!(their_pubkeys.htlc_basepoint.serialize()[..],
4383                            hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
4384
4385                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
4386                 // derived from a commitment_seed, so instead we copy it here and call
4387                 // build_commitment_transaction.
4388                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, chan.local_keys.delayed_payment_base_key());
4389                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4390                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4391                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, chan.local_keys.htlc_base_key());
4392                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &their_pubkeys.revocation_basepoint, &their_pubkeys.payment_basepoint, &their_pubkeys.htlc_basepoint).unwrap();
4393
4394                 chan.their_pubkeys = Some(their_pubkeys);
4395
4396                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
4397
4398                 macro_rules! test_commitment {
4399                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
4400                                 unsigned_tx = {
4401                                         let mut res = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw);
4402                                         let htlcs = res.2.drain(..)
4403                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
4404                                                 .collect();
4405                                         (res.0, htlcs)
4406                                 };
4407                                 let redeemscript = chan.get_funding_redeemscript();
4408                                 let their_signature = Signature::from_der(&hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4409                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &redeemscript, chan.channel_value_satoshis)[..]).unwrap();
4410                                 secp_ctx.verify(&sighash, &their_signature, chan.their_funding_pubkey()).unwrap();
4411
4412                                 let mut localtx = LocalCommitmentTransaction::new_missing_local_sig(unsigned_tx.0.clone(), &their_signature, &PublicKey::from_secret_key(&secp_ctx, chan.local_keys.funding_key()), chan.their_funding_pubkey());
4413                                 localtx.add_local_sig(chan.local_keys.funding_key(), &redeemscript, chan.channel_value_satoshis, &chan.secp_ctx);
4414
4415                                 assert_eq!(serialize(localtx.with_valid_witness())[..],
4416                                                 hex::decode($tx_hex).unwrap()[..]);
4417                         };
4418                 }
4419
4420                 macro_rules! test_htlc_output {
4421                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
4422                                 let remote_signature = Signature::from_der(&hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4423
4424                                 let ref htlc = unsigned_tx.1[$htlc_idx];
4425                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys, chan.feerate_per_kw);
4426                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
4427                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
4428                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
4429
4430                                 let mut preimage: Option<PaymentPreimage> = None;
4431                                 if !htlc.offered {
4432                                         for i in 0..5 {
4433                                                 let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
4434                                                 if out == htlc.payment_hash {
4435                                                         preimage = Some(PaymentPreimage([i; 32]));
4436                                                 }
4437                                         }
4438
4439                                         assert!(preimage.is_some());
4440                                 }
4441
4442                                 chan_utils::sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys.a_htlc_key, &keys.b_htlc_key, &keys.revocation_key, &keys.per_commitment_point, chan.local_keys.htlc_base_key(), &chan.secp_ctx).unwrap();
4443                                 assert_eq!(serialize(&htlc_tx)[..],
4444                                                 hex::decode($tx_hex).unwrap()[..]);
4445                         };
4446                 }
4447
4448                 {
4449                         // simple commitment tx with no HTLCs
4450                         chan.value_to_self_msat = 7000000000;
4451
4452                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
4453                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
4454                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4455                 }
4456
4457                 chan.pending_inbound_htlcs.push({
4458                         let mut out = InboundHTLCOutput{
4459                                 htlc_id: 0,
4460                                 amount_msat: 1000000,
4461                                 cltv_expiry: 500,
4462                                 payment_hash: PaymentHash([0; 32]),
4463                                 state: InboundHTLCState::Committed,
4464                         };
4465                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
4466                         out
4467                 });
4468                 chan.pending_inbound_htlcs.push({
4469                         let mut out = InboundHTLCOutput{
4470                                 htlc_id: 1,
4471                                 amount_msat: 2000000,
4472                                 cltv_expiry: 501,
4473                                 payment_hash: PaymentHash([0; 32]),
4474                                 state: InboundHTLCState::Committed,
4475                         };
4476                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
4477                         out
4478                 });
4479                 chan.pending_outbound_htlcs.push({
4480                         let mut out = OutboundHTLCOutput{
4481                                 htlc_id: 2,
4482                                 amount_msat: 2000000,
4483                                 cltv_expiry: 502,
4484                                 payment_hash: PaymentHash([0; 32]),
4485                                 state: OutboundHTLCState::Committed,
4486                                 source: HTLCSource::dummy(),
4487                         };
4488                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
4489                         out
4490                 });
4491                 chan.pending_outbound_htlcs.push({
4492                         let mut out = OutboundHTLCOutput{
4493                                 htlc_id: 3,
4494                                 amount_msat: 3000000,
4495                                 cltv_expiry: 503,
4496                                 payment_hash: PaymentHash([0; 32]),
4497                                 state: OutboundHTLCState::Committed,
4498                                 source: HTLCSource::dummy(),
4499                         };
4500                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
4501                         out
4502                 });
4503                 chan.pending_inbound_htlcs.push({
4504                         let mut out = InboundHTLCOutput{
4505                                 htlc_id: 4,
4506                                 amount_msat: 4000000,
4507                                 cltv_expiry: 504,
4508                                 payment_hash: PaymentHash([0; 32]),
4509                                 state: InboundHTLCState::Committed,
4510                         };
4511                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
4512                         out
4513                 });
4514
4515                 {
4516                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
4517                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4518                         chan.feerate_per_kw = 0;
4519
4520                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
4521                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
4522                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4523
4524                         assert_eq!(unsigned_tx.1.len(), 5);
4525
4526                         test_htlc_output!(0,
4527                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
4528                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
4529                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4530
4531                         test_htlc_output!(1,
4532                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
4533                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
4534                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4535
4536                         test_htlc_output!(2,
4537                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
4538                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
4539                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4540
4541                         test_htlc_output!(3,
4542                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
4543                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
4544                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4545
4546                         test_htlc_output!(4,
4547                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
4548                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
4549                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4550                 }
4551
4552                 {
4553                         // commitment tx with seven outputs untrimmed (maximum feerate)
4554                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4555                         chan.feerate_per_kw = 647;
4556
4557                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
4558                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
4559                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4560
4561                         assert_eq!(unsigned_tx.1.len(), 5);
4562
4563                         test_htlc_output!(0,
4564                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
4565                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
4566                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4567
4568                         test_htlc_output!(1,
4569                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
4570                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
4571                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4572
4573                         test_htlc_output!(2,
4574                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
4575                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
4576                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4577
4578                         test_htlc_output!(3,
4579                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
4580                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
4581                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4582
4583                         test_htlc_output!(4,
4584                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
4585                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
4586                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4587                 }
4588
4589                 {
4590                         // commitment tx with six outputs untrimmed (minimum feerate)
4591                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4592                         chan.feerate_per_kw = 648;
4593
4594                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
4595                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
4596                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4597
4598                         assert_eq!(unsigned_tx.1.len(), 4);
4599
4600                         test_htlc_output!(0,
4601                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
4602                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
4603                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4604
4605                         test_htlc_output!(1,
4606                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
4607                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
4608                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4609
4610                         test_htlc_output!(2,
4611                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
4612                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
4613                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4614
4615                         test_htlc_output!(3,
4616                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
4617                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
4618                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4619                 }
4620
4621                 {
4622                         // commitment tx with six outputs untrimmed (maximum feerate)
4623                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4624                         chan.feerate_per_kw = 2069;
4625
4626                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
4627                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
4628                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4629
4630                         assert_eq!(unsigned_tx.1.len(), 4);
4631
4632                         test_htlc_output!(0,
4633                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
4634                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
4635                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4636
4637                         test_htlc_output!(1,
4638                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
4639                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
4640                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4641
4642                         test_htlc_output!(2,
4643                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
4644                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
4645                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4646
4647                         test_htlc_output!(3,
4648                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
4649                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
4650                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4651                 }
4652
4653                 {
4654                         // commitment tx with five outputs untrimmed (minimum feerate)
4655                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4656                         chan.feerate_per_kw = 2070;
4657
4658                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
4659                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
4660                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4661
4662                         assert_eq!(unsigned_tx.1.len(), 3);
4663
4664                         test_htlc_output!(0,
4665                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
4666                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
4667                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4668
4669                         test_htlc_output!(1,
4670                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
4671                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
4672                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4673
4674                         test_htlc_output!(2,
4675                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
4676                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
4677                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4678                 }
4679
4680                 {
4681                         // commitment tx with five outputs untrimmed (maximum feerate)
4682                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4683                         chan.feerate_per_kw = 2194;
4684
4685                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
4686                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
4687                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4688
4689                         assert_eq!(unsigned_tx.1.len(), 3);
4690
4691                         test_htlc_output!(0,
4692                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
4693                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
4694                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4695
4696                         test_htlc_output!(1,
4697                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
4698                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
4699                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4700
4701                         test_htlc_output!(2,
4702                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
4703                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
4704                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4705                 }
4706
4707                 {
4708                         // commitment tx with four outputs untrimmed (minimum feerate)
4709                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4710                         chan.feerate_per_kw = 2195;
4711
4712                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
4713                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
4714                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4715
4716                         assert_eq!(unsigned_tx.1.len(), 2);
4717
4718                         test_htlc_output!(0,
4719                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
4720                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
4721                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4722
4723                         test_htlc_output!(1,
4724                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
4725                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
4726                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4727                 }
4728
4729                 {
4730                         // commitment tx with four outputs untrimmed (maximum feerate)
4731                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4732                         chan.feerate_per_kw = 3702;
4733
4734                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
4735                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
4736                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4737
4738                         assert_eq!(unsigned_tx.1.len(), 2);
4739
4740                         test_htlc_output!(0,
4741                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
4742                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
4743                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4744
4745                         test_htlc_output!(1,
4746                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
4747                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
4748                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4749                 }
4750
4751                 {
4752                         // commitment tx with three outputs untrimmed (minimum feerate)
4753                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4754                         chan.feerate_per_kw = 3703;
4755
4756                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
4757                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
4758                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4759
4760                         assert_eq!(unsigned_tx.1.len(), 1);
4761
4762                         test_htlc_output!(0,
4763                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
4764                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
4765                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4766                 }
4767
4768                 {
4769                         // commitment tx with three outputs untrimmed (maximum feerate)
4770                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4771                         chan.feerate_per_kw = 4914;
4772
4773                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
4774                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
4775                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4776
4777                         assert_eq!(unsigned_tx.1.len(), 1);
4778
4779                         test_htlc_output!(0,
4780                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
4781                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
4782                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4783                 }
4784
4785                 {
4786                         // commitment tx with two outputs untrimmed (minimum feerate)
4787                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4788                         chan.feerate_per_kw = 4915;
4789
4790                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
4791                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
4792                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4793
4794                         assert_eq!(unsigned_tx.1.len(), 0);
4795                 }
4796
4797                 {
4798                         // commitment tx with two outputs untrimmed (maximum feerate)
4799                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4800                         chan.feerate_per_kw = 9651180;
4801
4802                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
4803                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
4804                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4805
4806                         assert_eq!(unsigned_tx.1.len(), 0);
4807                 }
4808
4809                 {
4810                         // commitment tx with one output untrimmed (minimum feerate)
4811                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4812                         chan.feerate_per_kw = 9651181;
4813
4814                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4815                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4816                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4817
4818                         assert_eq!(unsigned_tx.1.len(), 0);
4819                 }
4820
4821                 {
4822                         // commitment tx with fee greater than funder amount
4823                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4824                         chan.feerate_per_kw = 9651936;
4825
4826                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4827                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4828                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4829
4830                         assert_eq!(unsigned_tx.1.len(), 0);
4831                 }
4832         }
4833
4834         #[test]
4835         fn test_per_commitment_secret_gen() {
4836                 // Test vectors from BOLT 3 Appendix D:
4837
4838                 let mut seed = [0; 32];
4839                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4840                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
4841                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
4842
4843                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
4844                 assert_eq!(chan_utils::build_commitment_secret(&seed, 281474976710655),
4845                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
4846
4847                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0xaaaaaaaaaaa),
4848                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
4849
4850                 assert_eq!(chan_utils::build_commitment_secret(&seed, 0x555555555555),
4851                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
4852
4853                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4854                 assert_eq!(chan_utils::build_commitment_secret(&seed, 1),
4855                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
4856         }
4857
4858         #[test]
4859         fn test_key_derivation() {
4860                 // Test vectors from BOLT 3 Appendix E:
4861                 let secp_ctx = Secp256k1::new();
4862
4863                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
4864                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4865
4866                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
4867                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
4868
4869                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4870                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
4871
4872                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4873                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
4874
4875                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
4876                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
4877
4878                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4879                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
4880
4881                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
4882                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
4883         }
4884 }