Check all outputs meet the dust threshold in check_spends!()
[rust-lightning] / lightning / src / ln / functional_test_utils.rs
1 // This file is Copyright its original authors, visible in version control
2 // history.
3 //
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
8 // licenses.
9
10 //! A bunch of useful utilities for building networks of nodes and exchanging messages between
11 //! nodes for functional tests.
12
13 use chain::{BestBlock, Confirm, Listen, Watch};
14 use chain::channelmonitor::ChannelMonitor;
15 use chain::transaction::OutPoint;
16 use ln::{PaymentPreimage, PaymentHash, PaymentSecret};
17 use ln::channelmanager::{ChainParameters, ChannelManager, ChannelManagerReadArgs, RAACommitmentOrder, PaymentSendFailure};
18 use routing::router::{Route, get_route};
19 use routing::network_graph::{NetGraphMsgHandler, NetworkGraph};
20 use ln::features::{InitFeatures, InvoiceFeatures};
21 use ln::msgs;
22 use ln::msgs::{ChannelMessageHandler,RoutingMessageHandler};
23 use util::enforcing_trait_impls::EnforcingSigner;
24 use util::test_utils;
25 use util::test_utils::TestChainMonitor;
26 use util::events::{Event, MessageSendEvent, MessageSendEventsProvider, PaymentPurpose};
27 use util::errors::APIError;
28 use util::config::UserConfig;
29 use util::ser::{ReadableArgs, Writeable, Readable};
30
31 use bitcoin::blockdata::block::{Block, BlockHeader};
32 use bitcoin::blockdata::constants::genesis_block;
33 use bitcoin::blockdata::transaction::{Transaction, TxOut};
34 use bitcoin::network::constants::Network;
35
36 use bitcoin::hashes::sha256::Hash as Sha256;
37 use bitcoin::hashes::Hash;
38 use bitcoin::hash_types::BlockHash;
39
40 use bitcoin::secp256k1::key::PublicKey;
41
42 use io;
43 use prelude::*;
44 use core::cell::RefCell;
45 use std::rc::Rc;
46 use sync::{Arc, Mutex};
47 use core::mem;
48
49 pub const CHAN_CONFIRM_DEPTH: u32 = 10;
50
51 /// Mine the given transaction in the next block and then mine CHAN_CONFIRM_DEPTH - 1 blocks on
52 /// top, giving the given transaction CHAN_CONFIRM_DEPTH confirmations.
53 pub fn confirm_transaction<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction) {
54         confirm_transaction_at(node, tx, node.best_block_info().1 + 1);
55         connect_blocks(node, CHAN_CONFIRM_DEPTH - 1);
56 }
57 /// Mine a signle block containing the given transaction
58 pub fn mine_transaction<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction) {
59         let height = node.best_block_info().1 + 1;
60         confirm_transaction_at(node, tx, height);
61 }
62 /// Mine the given transaction at the given height, mining blocks as required to build to that
63 /// height
64 pub fn confirm_transaction_at<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &Transaction, conf_height: u32) {
65         let first_connect_height = node.best_block_info().1 + 1;
66         assert!(first_connect_height <= conf_height);
67         if conf_height > first_connect_height {
68                 connect_blocks(node, conf_height - first_connect_height);
69         }
70         let mut block = Block {
71                 header: BlockHeader { version: 0x20000000, prev_blockhash: node.best_block_hash(), merkle_root: Default::default(), time: conf_height, bits: 42, nonce: 42 },
72                 txdata: Vec::new(),
73         };
74         for _ in 0..*node.network_chan_count.borrow() { // Make sure we don't end up with channels at the same short id by offsetting by chan_count
75                 block.txdata.push(Transaction { version: 0, lock_time: 0, input: Vec::new(), output: Vec::new() });
76         }
77         block.txdata.push(tx.clone());
78         connect_block(node, &block);
79 }
80
81 /// The possible ways we may notify a ChannelManager of a new block
82 #[derive(Clone, Copy, PartialEq)]
83 pub enum ConnectStyle {
84         /// Calls best_block_updated first, detecting transactions in the block only after receiving the
85         /// header and height information.
86         BestBlockFirst,
87         /// The same as BestBlockFirst, however when we have multiple blocks to connect, we only
88         /// make a single best_block_updated call.
89         BestBlockFirstSkippingBlocks,
90         /// Calls transactions_confirmed first, detecting transactions in the block before updating the
91         /// header and height information.
92         TransactionsFirst,
93         /// The same as TransactionsFirst, however when we have multiple blocks to connect, we only
94         /// make a single best_block_updated call.
95         TransactionsFirstSkippingBlocks,
96         /// Provides the full block via the chain::Listen interface. In the current code this is
97         /// equivalent to TransactionsFirst with some additional assertions.
98         FullBlockViaListen,
99 }
100
101 pub fn connect_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, depth: u32) -> BlockHash {
102         let skip_intermediaries = match *node.connect_style.borrow() {
103                 ConnectStyle::BestBlockFirstSkippingBlocks|ConnectStyle::TransactionsFirstSkippingBlocks => true,
104                 _ => false,
105         };
106
107         let height = node.best_block_info().1 + 1;
108         let mut block = Block {
109                 header: BlockHeader { version: 0x2000000, prev_blockhash: node.best_block_hash(), merkle_root: Default::default(), time: height, bits: 42, nonce: 42 },
110                 txdata: vec![],
111         };
112         assert!(depth >= 1);
113         for i in 1..depth {
114                 do_connect_block(node, &block, skip_intermediaries);
115                 block = Block {
116                         header: BlockHeader { version: 0x20000000, prev_blockhash: block.header.block_hash(), merkle_root: Default::default(), time: height + i, bits: 42, nonce: 42 },
117                         txdata: vec![],
118                 };
119         }
120         connect_block(node, &block);
121         block.header.block_hash()
122 }
123
124 pub fn connect_block<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, block: &Block) {
125         do_connect_block(node, block, false);
126 }
127
128 fn do_connect_block<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, block: &Block, skip_intermediaries: bool) {
129         let height = node.best_block_info().1 + 1;
130         if !skip_intermediaries {
131                 let txdata: Vec<_> = block.txdata.iter().enumerate().collect();
132                 match *node.connect_style.borrow() {
133                         ConnectStyle::BestBlockFirst|ConnectStyle::BestBlockFirstSkippingBlocks => {
134                                 node.chain_monitor.chain_monitor.best_block_updated(&block.header, height);
135                                 node.chain_monitor.chain_monitor.transactions_confirmed(&block.header, &txdata, height);
136                                 node.node.best_block_updated(&block.header, height);
137                                 node.node.transactions_confirmed(&block.header, &txdata, height);
138                         },
139                         ConnectStyle::TransactionsFirst|ConnectStyle::TransactionsFirstSkippingBlocks => {
140                                 node.chain_monitor.chain_monitor.transactions_confirmed(&block.header, &txdata, height);
141                                 node.chain_monitor.chain_monitor.best_block_updated(&block.header, height);
142                                 node.node.transactions_confirmed(&block.header, &txdata, height);
143                                 node.node.best_block_updated(&block.header, height);
144                         },
145                         ConnectStyle::FullBlockViaListen => {
146                                 node.chain_monitor.chain_monitor.block_connected(&block, height);
147                                 node.node.block_connected(&block, height);
148                         }
149                 }
150         }
151         node.node.test_process_background_events();
152         node.blocks.lock().unwrap().push((block.header, height));
153 }
154
155 pub fn disconnect_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, count: u32) {
156         for i in 0..count {
157                 let orig_header = node.blocks.lock().unwrap().pop().unwrap();
158                 assert!(orig_header.1 > 0); // Cannot disconnect genesis
159                 let prev_header = node.blocks.lock().unwrap().last().unwrap().clone();
160
161                 match *node.connect_style.borrow() {
162                         ConnectStyle::FullBlockViaListen => {
163                                 node.chain_monitor.chain_monitor.block_disconnected(&orig_header.0, orig_header.1);
164                                 Listen::block_disconnected(node.node, &orig_header.0, orig_header.1);
165                         },
166                         ConnectStyle::BestBlockFirstSkippingBlocks|ConnectStyle::TransactionsFirstSkippingBlocks => {
167                                 if i == count - 1 {
168                                         node.chain_monitor.chain_monitor.best_block_updated(&prev_header.0, prev_header.1);
169                                         node.node.best_block_updated(&prev_header.0, prev_header.1);
170                                 }
171                         },
172                         _ => {
173                                 node.chain_monitor.chain_monitor.best_block_updated(&prev_header.0, prev_header.1);
174                                 node.node.best_block_updated(&prev_header.0, prev_header.1);
175                         },
176                 }
177         }
178 }
179
180 pub fn disconnect_all_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>) {
181         let count = node.blocks.lock().unwrap().len() as u32 - 1;
182         disconnect_blocks(node, count);
183 }
184
185 pub struct TestChanMonCfg {
186         pub tx_broadcaster: test_utils::TestBroadcaster,
187         pub fee_estimator: test_utils::TestFeeEstimator,
188         pub chain_source: test_utils::TestChainSource,
189         pub persister: test_utils::TestPersister,
190         pub logger: test_utils::TestLogger,
191         pub keys_manager: test_utils::TestKeysInterface,
192 }
193
194 pub struct NodeCfg<'a> {
195         pub chain_source: &'a test_utils::TestChainSource,
196         pub tx_broadcaster: &'a test_utils::TestBroadcaster,
197         pub fee_estimator: &'a test_utils::TestFeeEstimator,
198         pub chain_monitor: test_utils::TestChainMonitor<'a>,
199         pub keys_manager: &'a test_utils::TestKeysInterface,
200         pub logger: &'a test_utils::TestLogger,
201         pub node_seed: [u8; 32],
202         pub features: InitFeatures,
203 }
204
205 pub struct Node<'a, 'b: 'a, 'c: 'b> {
206         pub chain_source: &'c test_utils::TestChainSource,
207         pub tx_broadcaster: &'c test_utils::TestBroadcaster,
208         pub chain_monitor: &'b test_utils::TestChainMonitor<'c>,
209         pub keys_manager: &'b test_utils::TestKeysInterface,
210         pub node: &'a ChannelManager<EnforcingSigner, &'b TestChainMonitor<'c>, &'c test_utils::TestBroadcaster, &'b test_utils::TestKeysInterface, &'c test_utils::TestFeeEstimator, &'c test_utils::TestLogger>,
211         pub net_graph_msg_handler: NetGraphMsgHandler<&'c test_utils::TestChainSource, &'c test_utils::TestLogger>,
212         pub node_seed: [u8; 32],
213         pub network_payment_count: Rc<RefCell<u8>>,
214         pub network_chan_count: Rc<RefCell<u32>>,
215         pub logger: &'c test_utils::TestLogger,
216         pub blocks: Arc<Mutex<Vec<(BlockHeader, u32)>>>,
217         pub connect_style: Rc<RefCell<ConnectStyle>>,
218 }
219 impl<'a, 'b, 'c> Node<'a, 'b, 'c> {
220         pub fn best_block_hash(&self) -> BlockHash {
221                 self.blocks.lock().unwrap().last().unwrap().0.block_hash()
222         }
223         pub fn best_block_info(&self) -> (BlockHash, u32) {
224                 self.blocks.lock().unwrap().last().map(|(a, b)| (a.block_hash(), *b)).unwrap()
225         }
226         pub fn get_block_header(&self, height: u32) -> BlockHeader {
227                 self.blocks.lock().unwrap()[height as usize].0
228         }
229 }
230
231 impl<'a, 'b, 'c> Drop for Node<'a, 'b, 'c> {
232         fn drop(&mut self) {
233                 if !::std::thread::panicking() {
234                         // Check that we processed all pending events
235                         assert!(self.node.get_and_clear_pending_msg_events().is_empty());
236                         assert!(self.node.get_and_clear_pending_events().is_empty());
237                         assert!(self.chain_monitor.added_monitors.lock().unwrap().is_empty());
238
239                         // Check that if we serialize the Router, we can deserialize it again.
240                         {
241                                 let mut w = test_utils::TestVecWriter(Vec::new());
242                                 let network_graph_ser = self.net_graph_msg_handler.network_graph.read().unwrap();
243                                 network_graph_ser.write(&mut w).unwrap();
244                                 let network_graph_deser = <NetworkGraph>::read(&mut io::Cursor::new(&w.0)).unwrap();
245                                 assert!(network_graph_deser == *self.net_graph_msg_handler.network_graph.read().unwrap());
246                                 let net_graph_msg_handler = NetGraphMsgHandler::from_net_graph(
247                                         Some(self.chain_source), self.logger, network_graph_deser
248                                 );
249                                 let mut chan_progress = 0;
250                                 loop {
251                                         let orig_announcements = self.net_graph_msg_handler.get_next_channel_announcements(chan_progress, 255);
252                                         let deserialized_announcements = net_graph_msg_handler.get_next_channel_announcements(chan_progress, 255);
253                                         assert!(orig_announcements == deserialized_announcements);
254                                         chan_progress = match orig_announcements.last() {
255                                                 Some(announcement) => announcement.0.contents.short_channel_id + 1,
256                                                 None => break,
257                                         };
258                                 }
259                                 let mut node_progress = None;
260                                 loop {
261                                         let orig_announcements = self.net_graph_msg_handler.get_next_node_announcements(node_progress.as_ref(), 255);
262                                         let deserialized_announcements = net_graph_msg_handler.get_next_node_announcements(node_progress.as_ref(), 255);
263                                         assert!(orig_announcements == deserialized_announcements);
264                                         node_progress = match orig_announcements.last() {
265                                                 Some(announcement) => Some(announcement.contents.node_id),
266                                                 None => break,
267                                         };
268                                 }
269                         }
270
271                         // Check that if we serialize and then deserialize all our channel monitors we get the
272                         // same set of outputs to watch for on chain as we have now. Note that if we write
273                         // tests that fully close channels and remove the monitors at some point this may break.
274                         let feeest = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
275                         let mut deserialized_monitors = Vec::new();
276                         {
277                                 let old_monitors = self.chain_monitor.chain_monitor.monitors.read().unwrap();
278                                 for (_, old_monitor) in old_monitors.iter() {
279                                         let mut w = test_utils::TestVecWriter(Vec::new());
280                                         old_monitor.write(&mut w).unwrap();
281                                         let (_, deserialized_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
282                                                 &mut io::Cursor::new(&w.0), self.keys_manager).unwrap();
283                                         deserialized_monitors.push(deserialized_monitor);
284                                 }
285                         }
286
287                         // Before using all the new monitors to check the watch outpoints, use the full set of
288                         // them to ensure we can write and reload our ChannelManager.
289                         {
290                                 let mut channel_monitors = HashMap::new();
291                                 for monitor in deserialized_monitors.iter_mut() {
292                                         channel_monitors.insert(monitor.get_funding_txo().0, monitor);
293                                 }
294
295                                 let mut w = test_utils::TestVecWriter(Vec::new());
296                                 self.node.write(&mut w).unwrap();
297                                 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut io::Cursor::new(w.0), ChannelManagerReadArgs {
298                                         default_config: *self.node.get_current_default_configuration(),
299                                         keys_manager: self.keys_manager,
300                                         fee_estimator: &test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) },
301                                         chain_monitor: self.chain_monitor,
302                                         tx_broadcaster: &test_utils::TestBroadcaster {
303                                                 txn_broadcasted: Mutex::new(self.tx_broadcaster.txn_broadcasted.lock().unwrap().clone()),
304                                                 blocks: Arc::new(Mutex::new(self.tx_broadcaster.blocks.lock().unwrap().clone())),
305                                         },
306                                         logger: &self.logger,
307                                         channel_monitors,
308                                 }).unwrap();
309                         }
310
311                         let persister = test_utils::TestPersister::new();
312                         let broadcaster = test_utils::TestBroadcaster {
313                                 txn_broadcasted: Mutex::new(self.tx_broadcaster.txn_broadcasted.lock().unwrap().clone()),
314                                 blocks: Arc::new(Mutex::new(self.tx_broadcaster.blocks.lock().unwrap().clone())),
315                         };
316                         let chain_source = test_utils::TestChainSource::new(Network::Testnet);
317                         let chain_monitor = test_utils::TestChainMonitor::new(Some(&chain_source), &broadcaster, &self.logger, &feeest, &persister, &self.keys_manager);
318                         for deserialized_monitor in deserialized_monitors.drain(..) {
319                                 if let Err(_) = chain_monitor.watch_channel(deserialized_monitor.get_funding_txo().0, deserialized_monitor) {
320                                         panic!();
321                                 }
322                         }
323                         assert_eq!(*chain_source.watched_txn.lock().unwrap(), *self.chain_source.watched_txn.lock().unwrap());
324                         assert_eq!(*chain_source.watched_outputs.lock().unwrap(), *self.chain_source.watched_outputs.lock().unwrap());
325                 }
326         }
327 }
328
329 pub fn create_chan_between_nodes<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
330         create_chan_between_nodes_with_value(node_a, node_b, 100000, 10001, a_flags, b_flags)
331 }
332
333 pub fn create_chan_between_nodes_with_value<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
334         let (funding_locked, channel_id, tx) = create_chan_between_nodes_with_value_a(node_a, node_b, channel_value, push_msat, a_flags, b_flags);
335         let (announcement, as_update, bs_update) = create_chan_between_nodes_with_value_b(node_a, node_b, &funding_locked);
336         (announcement, as_update, bs_update, channel_id, tx)
337 }
338
339 macro_rules! get_revoke_commit_msgs {
340         ($node: expr, $node_id: expr) => {
341                 {
342                         let events = $node.node.get_and_clear_pending_msg_events();
343                         assert_eq!(events.len(), 2);
344                         (match events[0] {
345                                 MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
346                                         assert_eq!(*node_id, $node_id);
347                                         (*msg).clone()
348                                 },
349                                 _ => panic!("Unexpected event"),
350                         }, match events[1] {
351                                 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
352                                         assert_eq!(*node_id, $node_id);
353                                         assert!(updates.update_add_htlcs.is_empty());
354                                         assert!(updates.update_fulfill_htlcs.is_empty());
355                                         assert!(updates.update_fail_htlcs.is_empty());
356                                         assert!(updates.update_fail_malformed_htlcs.is_empty());
357                                         assert!(updates.update_fee.is_none());
358                                         updates.commitment_signed.clone()
359                                 },
360                                 _ => panic!("Unexpected event"),
361                         })
362                 }
363         }
364 }
365
366 /// Get an specific event message from the pending events queue.
367 #[macro_export]
368 macro_rules! get_event_msg {
369         ($node: expr, $event_type: path, $node_id: expr) => {
370                 {
371                         let events = $node.node.get_and_clear_pending_msg_events();
372                         assert_eq!(events.len(), 1);
373                         match events[0] {
374                                 $event_type { ref node_id, ref msg } => {
375                                         assert_eq!(*node_id, $node_id);
376                                         (*msg).clone()
377                                 },
378                                 _ => panic!("Unexpected event"),
379                         }
380                 }
381         }
382 }
383
384 /// Get a specific event from the pending events queue.
385 #[macro_export]
386 macro_rules! get_event {
387         ($node: expr, $event_type: path) => {
388                 {
389                         let mut events = $node.node.get_and_clear_pending_events();
390                         assert_eq!(events.len(), 1);
391                         let ev = events.pop().unwrap();
392                         match ev {
393                                 $event_type { .. } => {
394                                         ev
395                                 },
396                                 _ => panic!("Unexpected event"),
397                         }
398                 }
399         }
400 }
401
402 #[cfg(test)]
403 macro_rules! get_htlc_update_msgs {
404         ($node: expr, $node_id: expr) => {
405                 {
406                         let events = $node.node.get_and_clear_pending_msg_events();
407                         assert_eq!(events.len(), 1);
408                         match events[0] {
409                                 MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
410                                         assert_eq!(*node_id, $node_id);
411                                         (*updates).clone()
412                                 },
413                                 _ => panic!("Unexpected event"),
414                         }
415                 }
416         }
417 }
418
419 #[cfg(test)]
420 macro_rules! get_channel_ref {
421         ($node: expr, $lock: ident, $channel_id: expr) => {
422                 {
423                         $lock = $node.node.channel_state.lock().unwrap();
424                         $lock.by_id.get_mut(&$channel_id).unwrap()
425                 }
426         }
427 }
428
429 #[cfg(test)]
430 macro_rules! get_feerate {
431         ($node: expr, $channel_id: expr) => {
432                 {
433                         let mut lock;
434                         let chan = get_channel_ref!($node, lock, $channel_id);
435                         chan.get_feerate()
436                 }
437         }
438 }
439
440 /// Returns any local commitment transactions for the channel.
441 #[macro_export]
442 macro_rules! get_local_commitment_txn {
443         ($node: expr, $channel_id: expr) => {
444                 {
445                         let monitors = $node.chain_monitor.chain_monitor.monitors.read().unwrap();
446                         let mut commitment_txn = None;
447                         for (funding_txo, monitor) in monitors.iter() {
448                                 if funding_txo.to_channel_id() == $channel_id {
449                                         commitment_txn = Some(monitor.unsafe_get_latest_holder_commitment_txn(&$node.logger));
450                                         break;
451                                 }
452                         }
453                         commitment_txn.unwrap()
454                 }
455         }
456 }
457
458 /// Check the error from attempting a payment.
459 #[macro_export]
460 macro_rules! unwrap_send_err {
461         ($res: expr, $all_failed: expr, $type: pat, $check: expr) => {
462                 match &$res {
463                         &Err(PaymentSendFailure::AllFailedRetrySafe(ref fails)) if $all_failed => {
464                                 assert_eq!(fails.len(), 1);
465                                 match fails[0] {
466                                         $type => { $check },
467                                         _ => panic!(),
468                                 }
469                         },
470                         &Err(PaymentSendFailure::PartialFailure(ref fails)) if !$all_failed => {
471                                 assert_eq!(fails.len(), 1);
472                                 match fails[0] {
473                                         Err($type) => { $check },
474                                         _ => panic!(),
475                                 }
476                         },
477                         _ => panic!(),
478                 }
479         }
480 }
481
482 /// Check whether N channel monitor(s) have been added.
483 #[macro_export]
484 macro_rules! check_added_monitors {
485         ($node: expr, $count: expr) => {
486                 {
487                         let mut added_monitors = $node.chain_monitor.added_monitors.lock().unwrap();
488                         assert_eq!(added_monitors.len(), $count);
489                         added_monitors.clear();
490                 }
491         }
492 }
493
494 pub fn create_funding_transaction<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, expected_chan_value: u64, expected_user_chan_id: u64) -> ([u8; 32], Transaction, OutPoint) {
495         let chan_id = *node.network_chan_count.borrow();
496
497         let events = node.node.get_and_clear_pending_events();
498         assert_eq!(events.len(), 1);
499         match events[0] {
500                 Event::FundingGenerationReady { ref temporary_channel_id, ref channel_value_satoshis, ref output_script, user_channel_id } => {
501                         assert_eq!(*channel_value_satoshis, expected_chan_value);
502                         assert_eq!(user_channel_id, expected_user_chan_id);
503
504                         let tx = Transaction { version: chan_id as i32, lock_time: 0, input: Vec::new(), output: vec![TxOut {
505                                 value: *channel_value_satoshis, script_pubkey: output_script.clone(),
506                         }]};
507                         let funding_outpoint = OutPoint { txid: tx.txid(), index: 0 };
508                         (*temporary_channel_id, tx, funding_outpoint)
509                 },
510                 _ => panic!("Unexpected event"),
511         }
512 }
513
514 pub fn create_chan_between_nodes_with_value_init<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> Transaction {
515         node_a.node.create_channel(node_b.node.get_our_node_id(), channel_value, push_msat, 42, None).unwrap();
516         node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), a_flags, &get_event_msg!(node_a, MessageSendEvent::SendOpenChannel, node_b.node.get_our_node_id()));
517         node_a.node.handle_accept_channel(&node_b.node.get_our_node_id(), b_flags, &get_event_msg!(node_b, MessageSendEvent::SendAcceptChannel, node_a.node.get_our_node_id()));
518
519         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(node_a, channel_value, 42);
520
521         node_a.node.funding_transaction_generated(&temporary_channel_id, tx.clone()).unwrap();
522         check_added_monitors!(node_a, 0);
523
524         node_b.node.handle_funding_created(&node_a.node.get_our_node_id(), &get_event_msg!(node_a, MessageSendEvent::SendFundingCreated, node_b.node.get_our_node_id()));
525         {
526                 let mut added_monitors = node_b.chain_monitor.added_monitors.lock().unwrap();
527                 assert_eq!(added_monitors.len(), 1);
528                 assert_eq!(added_monitors[0].0, funding_output);
529                 added_monitors.clear();
530         }
531
532         node_a.node.handle_funding_signed(&node_b.node.get_our_node_id(), &get_event_msg!(node_b, MessageSendEvent::SendFundingSigned, node_a.node.get_our_node_id()));
533         {
534                 let mut added_monitors = node_a.chain_monitor.added_monitors.lock().unwrap();
535                 assert_eq!(added_monitors.len(), 1);
536                 assert_eq!(added_monitors[0].0, funding_output);
537                 added_monitors.clear();
538         }
539
540         let events_4 = node_a.node.get_and_clear_pending_events();
541         assert_eq!(events_4.len(), 0);
542
543         assert_eq!(node_a.tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
544         assert_eq!(node_a.tx_broadcaster.txn_broadcasted.lock().unwrap()[0], tx);
545         node_a.tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
546
547         tx
548 }
549
550 pub fn create_chan_between_nodes_with_value_confirm_first<'a, 'b, 'c, 'd>(node_recv: &'a Node<'b, 'c, 'c>, node_conf: &'a Node<'b, 'c, 'd>, tx: &Transaction, conf_height: u32) {
551         confirm_transaction_at(node_conf, tx, conf_height);
552         connect_blocks(node_conf, CHAN_CONFIRM_DEPTH - 1);
553         node_recv.node.handle_funding_locked(&node_conf.node.get_our_node_id(), &get_event_msg!(node_conf, MessageSendEvent::SendFundingLocked, node_recv.node.get_our_node_id()));
554 }
555
556 pub fn create_chan_between_nodes_with_value_confirm_second<'a, 'b, 'c>(node_recv: &Node<'a, 'b, 'c>, node_conf: &Node<'a, 'b, 'c>) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32]) {
557         let channel_id;
558         let events_6 = node_conf.node.get_and_clear_pending_msg_events();
559         assert_eq!(events_6.len(), 2);
560         ((match events_6[0] {
561                 MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
562                         channel_id = msg.channel_id.clone();
563                         assert_eq!(*node_id, node_recv.node.get_our_node_id());
564                         msg.clone()
565                 },
566                 _ => panic!("Unexpected event"),
567         }, match events_6[1] {
568                 MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
569                         assert_eq!(*node_id, node_recv.node.get_our_node_id());
570                         msg.clone()
571                 },
572                 _ => panic!("Unexpected event"),
573         }), channel_id)
574 }
575
576 pub fn create_chan_between_nodes_with_value_confirm<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, tx: &Transaction) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32]) {
577         let conf_height = core::cmp::max(node_a.best_block_info().1 + 1, node_b.best_block_info().1 + 1);
578         create_chan_between_nodes_with_value_confirm_first(node_a, node_b, tx, conf_height);
579         confirm_transaction_at(node_a, tx, conf_height);
580         connect_blocks(node_a, CHAN_CONFIRM_DEPTH - 1);
581         create_chan_between_nodes_with_value_confirm_second(node_b, node_a)
582 }
583
584 pub fn create_chan_between_nodes_with_value_a<'a, 'b, 'c, 'd>(node_a: &'a Node<'b, 'c, 'd>, node_b: &'a Node<'b, 'c, 'd>, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> ((msgs::FundingLocked, msgs::AnnouncementSignatures), [u8; 32], Transaction) {
585         let tx = create_chan_between_nodes_with_value_init(node_a, node_b, channel_value, push_msat, a_flags, b_flags);
586         let (msgs, chan_id) = create_chan_between_nodes_with_value_confirm(node_a, node_b, &tx);
587         (msgs, chan_id, tx)
588 }
589
590 pub fn create_chan_between_nodes_with_value_b<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, as_funding_msgs: &(msgs::FundingLocked, msgs::AnnouncementSignatures)) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate) {
591         node_b.node.handle_funding_locked(&node_a.node.get_our_node_id(), &as_funding_msgs.0);
592         let bs_announcement_sigs = get_event_msg!(node_b, MessageSendEvent::SendAnnouncementSignatures, node_a.node.get_our_node_id());
593         node_b.node.handle_announcement_signatures(&node_a.node.get_our_node_id(), &as_funding_msgs.1);
594
595         let events_7 = node_b.node.get_and_clear_pending_msg_events();
596         assert_eq!(events_7.len(), 1);
597         let (announcement, bs_update) = match events_7[0] {
598                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
599                         (msg, update_msg)
600                 },
601                 _ => panic!("Unexpected event"),
602         };
603
604         node_a.node.handle_announcement_signatures(&node_b.node.get_our_node_id(), &bs_announcement_sigs);
605         let events_8 = node_a.node.get_and_clear_pending_msg_events();
606         assert_eq!(events_8.len(), 1);
607         let as_update = match events_8[0] {
608                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
609                         assert!(*announcement == *msg);
610                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
611                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
612                         update_msg
613                 },
614                 _ => panic!("Unexpected event"),
615         };
616
617         *node_a.network_chan_count.borrow_mut() += 1;
618
619         ((*announcement).clone(), (*as_update).clone(), (*bs_update).clone())
620 }
621
622 pub fn create_announced_chan_between_nodes<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
623         create_announced_chan_between_nodes_with_value(nodes, a, b, 100000, 10001, a_flags, b_flags)
624 }
625
626 pub fn create_announced_chan_between_nodes_with_value<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, channel_value: u64, push_msat: u64, a_flags: InitFeatures, b_flags: InitFeatures) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction) {
627         let chan_announcement = create_chan_between_nodes_with_value(&nodes[a], &nodes[b], channel_value, push_msat, a_flags, b_flags);
628         update_nodes_with_chan_announce(nodes, a, b, &chan_announcement.0, &chan_announcement.1, &chan_announcement.2);
629         (chan_announcement.1, chan_announcement.2, chan_announcement.3, chan_announcement.4)
630 }
631
632 pub fn update_nodes_with_chan_announce<'a, 'b, 'c, 'd>(nodes: &'a Vec<Node<'b, 'c, 'd>>, a: usize, b: usize, ann: &msgs::ChannelAnnouncement, upd_1: &msgs::ChannelUpdate, upd_2: &msgs::ChannelUpdate) {
633         nodes[a].node.broadcast_node_announcement([0, 0, 0], [0; 32], Vec::new());
634         let a_events = nodes[a].node.get_and_clear_pending_msg_events();
635         assert!(a_events.len() >= 2);
636
637         // ann should be re-generated by broadcast_node_announcement - check that we have it.
638         let mut found_ann_1 = false;
639         for event in a_events.iter() {
640                 match event {
641                         MessageSendEvent::BroadcastChannelAnnouncement { ref msg, .. } => {
642                                 if msg == ann { found_ann_1 = true; }
643                         },
644                         MessageSendEvent::BroadcastNodeAnnouncement { .. } => {},
645                         _ => panic!("Unexpected event {:?}", event),
646                 }
647         }
648         assert!(found_ann_1);
649
650         let a_node_announcement = match a_events.last().unwrap() {
651                 MessageSendEvent::BroadcastNodeAnnouncement { ref msg } => {
652                         (*msg).clone()
653                 },
654                 _ => panic!("Unexpected event"),
655         };
656
657         nodes[b].node.broadcast_node_announcement([1, 1, 1], [1; 32], Vec::new());
658         let b_events = nodes[b].node.get_and_clear_pending_msg_events();
659         assert!(b_events.len() >= 2);
660
661         // ann should be re-generated by broadcast_node_announcement - check that we have it.
662         let mut found_ann_2 = false;
663         for event in b_events.iter() {
664                 match event {
665                         MessageSendEvent::BroadcastChannelAnnouncement { ref msg, .. } => {
666                                 if msg == ann { found_ann_2 = true; }
667                         },
668                         MessageSendEvent::BroadcastNodeAnnouncement { .. } => {},
669                         _ => panic!("Unexpected event"),
670                 }
671         }
672         assert!(found_ann_2);
673
674         let b_node_announcement = match b_events.last().unwrap() {
675                 MessageSendEvent::BroadcastNodeAnnouncement { ref msg } => {
676                         (*msg).clone()
677                 },
678                 _ => panic!("Unexpected event"),
679         };
680
681         for node in nodes {
682                 assert!(node.net_graph_msg_handler.handle_channel_announcement(ann).unwrap());
683                 node.net_graph_msg_handler.handle_channel_update(upd_1).unwrap();
684                 node.net_graph_msg_handler.handle_channel_update(upd_2).unwrap();
685                 node.net_graph_msg_handler.handle_node_announcement(&a_node_announcement).unwrap();
686                 node.net_graph_msg_handler.handle_node_announcement(&b_node_announcement).unwrap();
687         }
688 }
689
690 macro_rules! check_spends {
691         ($tx: expr, $($spends_txn: expr),*) => {
692                 {
693                         $(
694                         for outp in $spends_txn.output.iter() {
695                                 assert!(outp.value >= outp.script_pubkey.dust_value().as_sat(), "Input tx output didn't meet dust limit");
696                         }
697                         )*
698                         for outp in $tx.output.iter() {
699                                 assert!(outp.value >= outp.script_pubkey.dust_value().as_sat(), "Spending tx output didn't meet dust limit");
700                         }
701                         let get_output = |out_point: &bitcoin::blockdata::transaction::OutPoint| {
702                                 $(
703                                         if out_point.txid == $spends_txn.txid() {
704                                                 return $spends_txn.output.get(out_point.vout as usize).cloned()
705                                         }
706                                 )*
707                                 None
708                         };
709                         let mut total_value_in = 0;
710                         for input in $tx.input.iter() {
711                                 total_value_in += get_output(&input.previous_output).unwrap().value;
712                         }
713                         let mut total_value_out = 0;
714                         for output in $tx.output.iter() {
715                                 total_value_out += output.value;
716                         }
717                         let min_fee = ($tx.get_weight() as u64 + 3) / 4; // One sat per vbyte (ie per weight/4, rounded up)
718                         // Input amount - output amount = fee, so check that out + min_fee is smaller than input
719                         assert!(total_value_out + min_fee <= total_value_in);
720                         $tx.verify(get_output).unwrap();
721                 }
722         }
723 }
724
725 macro_rules! get_closing_signed_broadcast {
726         ($node: expr, $dest_pubkey: expr) => {
727                 {
728                         let events = $node.get_and_clear_pending_msg_events();
729                         assert!(events.len() == 1 || events.len() == 2);
730                         (match events[events.len() - 1] {
731                                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
732                                         assert_eq!(msg.contents.flags & 2, 2);
733                                         msg.clone()
734                                 },
735                                 _ => panic!("Unexpected event"),
736                         }, if events.len() == 2 {
737                                 match events[0] {
738                                         MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
739                                                 assert_eq!(*node_id, $dest_pubkey);
740                                                 Some(msg.clone())
741                                         },
742                                         _ => panic!("Unexpected event"),
743                                 }
744                         } else { None })
745                 }
746         }
747 }
748
749 /// Check that a channel's closing channel update has been broadcasted, and optionally
750 /// check whether an error message event has occurred.
751 #[macro_export]
752 macro_rules! check_closed_broadcast {
753         ($node: expr, $with_error_msg: expr) => {{
754                 let events = $node.node.get_and_clear_pending_msg_events();
755                 assert_eq!(events.len(), if $with_error_msg { 2 } else { 1 });
756                 match events[0] {
757                         MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
758                                 assert_eq!(msg.contents.flags & 2, 2);
759                         },
760                         _ => panic!("Unexpected event"),
761                 }
762                 if $with_error_msg {
763                         match events[1] {
764                                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg }, node_id: _ } => {
765                                         // TODO: Check node_id
766                                         Some(msg.clone())
767                                 },
768                                 _ => panic!("Unexpected event"),
769                         }
770                 } else { None }
771         }}
772 }
773
774 pub fn close_channel<'a, 'b, 'c>(outbound_node: &Node<'a, 'b, 'c>, inbound_node: &Node<'a, 'b, 'c>, channel_id: &[u8; 32], funding_tx: Transaction, close_inbound_first: bool) -> (msgs::ChannelUpdate, msgs::ChannelUpdate, Transaction) {
775         let (node_a, broadcaster_a, struct_a) = if close_inbound_first { (&inbound_node.node, &inbound_node.tx_broadcaster, inbound_node) } else { (&outbound_node.node, &outbound_node.tx_broadcaster, outbound_node) };
776         let (node_b, broadcaster_b, struct_b) = if close_inbound_first { (&outbound_node.node, &outbound_node.tx_broadcaster, outbound_node) } else { (&inbound_node.node, &inbound_node.tx_broadcaster, inbound_node) };
777         let (tx_a, tx_b);
778
779         node_a.close_channel(channel_id).unwrap();
780         node_b.handle_shutdown(&node_a.get_our_node_id(), &InitFeatures::known(), &get_event_msg!(struct_a, MessageSendEvent::SendShutdown, node_b.get_our_node_id()));
781
782         let events_1 = node_b.get_and_clear_pending_msg_events();
783         assert!(events_1.len() >= 1);
784         let shutdown_b = match events_1[0] {
785                 MessageSendEvent::SendShutdown { ref node_id, ref msg } => {
786                         assert_eq!(node_id, &node_a.get_our_node_id());
787                         msg.clone()
788                 },
789                 _ => panic!("Unexpected event"),
790         };
791
792         let closing_signed_b = if !close_inbound_first {
793                 assert_eq!(events_1.len(), 1);
794                 None
795         } else {
796                 Some(match events_1[1] {
797                         MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
798                                 assert_eq!(node_id, &node_a.get_our_node_id());
799                                 msg.clone()
800                         },
801                         _ => panic!("Unexpected event"),
802                 })
803         };
804
805         node_a.handle_shutdown(&node_b.get_our_node_id(), &InitFeatures::known(), &shutdown_b);
806         let (as_update, bs_update) = if close_inbound_first {
807                 assert!(node_a.get_and_clear_pending_msg_events().is_empty());
808                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &closing_signed_b.unwrap());
809
810                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &get_event_msg!(struct_a, MessageSendEvent::SendClosingSigned, node_b.get_our_node_id()));
811                 assert_eq!(broadcaster_b.txn_broadcasted.lock().unwrap().len(), 1);
812                 tx_b = broadcaster_b.txn_broadcasted.lock().unwrap().remove(0);
813                 let (bs_update, closing_signed_b) = get_closing_signed_broadcast!(node_b, node_a.get_our_node_id());
814
815                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &closing_signed_b.unwrap());
816                 let (as_update, none_a) = get_closing_signed_broadcast!(node_a, node_b.get_our_node_id());
817                 assert!(none_a.is_none());
818                 assert_eq!(broadcaster_a.txn_broadcasted.lock().unwrap().len(), 1);
819                 tx_a = broadcaster_a.txn_broadcasted.lock().unwrap().remove(0);
820                 (as_update, bs_update)
821         } else {
822                 let closing_signed_a = get_event_msg!(struct_a, MessageSendEvent::SendClosingSigned, node_b.get_our_node_id());
823
824                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &closing_signed_a);
825                 node_a.handle_closing_signed(&node_b.get_our_node_id(), &get_event_msg!(struct_b, MessageSendEvent::SendClosingSigned, node_a.get_our_node_id()));
826
827                 assert_eq!(broadcaster_a.txn_broadcasted.lock().unwrap().len(), 1);
828                 tx_a = broadcaster_a.txn_broadcasted.lock().unwrap().remove(0);
829                 let (as_update, closing_signed_a) = get_closing_signed_broadcast!(node_a, node_b.get_our_node_id());
830
831                 node_b.handle_closing_signed(&node_a.get_our_node_id(), &closing_signed_a.unwrap());
832                 let (bs_update, none_b) = get_closing_signed_broadcast!(node_b, node_a.get_our_node_id());
833                 assert!(none_b.is_none());
834                 assert_eq!(broadcaster_b.txn_broadcasted.lock().unwrap().len(), 1);
835                 tx_b = broadcaster_b.txn_broadcasted.lock().unwrap().remove(0);
836                 (as_update, bs_update)
837         };
838         assert_eq!(tx_a, tx_b);
839         check_spends!(tx_a, funding_tx);
840
841         (as_update, bs_update, tx_a)
842 }
843
844 pub struct SendEvent {
845         pub node_id: PublicKey,
846         pub msgs: Vec<msgs::UpdateAddHTLC>,
847         pub commitment_msg: msgs::CommitmentSigned,
848 }
849 impl SendEvent {
850         pub fn from_commitment_update(node_id: PublicKey, updates: msgs::CommitmentUpdate) -> SendEvent {
851                 assert!(updates.update_fulfill_htlcs.is_empty());
852                 assert!(updates.update_fail_htlcs.is_empty());
853                 assert!(updates.update_fail_malformed_htlcs.is_empty());
854                 assert!(updates.update_fee.is_none());
855                 SendEvent { node_id: node_id, msgs: updates.update_add_htlcs, commitment_msg: updates.commitment_signed }
856         }
857
858         pub fn from_event(event: MessageSendEvent) -> SendEvent {
859                 match event {
860                         MessageSendEvent::UpdateHTLCs { node_id, updates } => SendEvent::from_commitment_update(node_id, updates),
861                         _ => panic!("Unexpected event type!"),
862                 }
863         }
864
865         pub fn from_node<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>) -> SendEvent {
866                 let mut events = node.node.get_and_clear_pending_msg_events();
867                 assert_eq!(events.len(), 1);
868                 SendEvent::from_event(events.pop().unwrap())
869         }
870 }
871
872 macro_rules! commitment_signed_dance {
873         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr, true /* skip last step */) => {
874                 {
875                         check_added_monitors!($node_a, 0);
876                         assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
877                         $node_a.node.handle_commitment_signed(&$node_b.node.get_our_node_id(), &$commitment_signed);
878                         check_added_monitors!($node_a, 1);
879                         commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, false);
880                 }
881         };
882         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, true /* return extra message */, true /* return last RAA */) => {
883                 {
884                         let (as_revoke_and_ack, as_commitment_signed) = get_revoke_commit_msgs!($node_a, $node_b.node.get_our_node_id());
885                         check_added_monitors!($node_b, 0);
886                         assert!($node_b.node.get_and_clear_pending_msg_events().is_empty());
887                         $node_b.node.handle_revoke_and_ack(&$node_a.node.get_our_node_id(), &as_revoke_and_ack);
888                         assert!($node_b.node.get_and_clear_pending_msg_events().is_empty());
889                         check_added_monitors!($node_b, 1);
890                         $node_b.node.handle_commitment_signed(&$node_a.node.get_our_node_id(), &as_commitment_signed);
891                         let (bs_revoke_and_ack, extra_msg_option) = {
892                                 let events = $node_b.node.get_and_clear_pending_msg_events();
893                                 assert!(events.len() <= 2);
894                                 (match events[0] {
895                                         MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
896                                                 assert_eq!(*node_id, $node_a.node.get_our_node_id());
897                                                 (*msg).clone()
898                                         },
899                                         _ => panic!("Unexpected event"),
900                                 }, events.get(1).map(|e| e.clone()))
901                         };
902                         check_added_monitors!($node_b, 1);
903                         if $fail_backwards {
904                                 assert!($node_a.node.get_and_clear_pending_events().is_empty());
905                                 assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
906                         }
907                         (extra_msg_option, bs_revoke_and_ack)
908                 }
909         };
910         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr, true /* skip last step */, false /* return extra message */, true /* return last RAA */) => {
911                 {
912                         check_added_monitors!($node_a, 0);
913                         assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
914                         $node_a.node.handle_commitment_signed(&$node_b.node.get_our_node_id(), &$commitment_signed);
915                         check_added_monitors!($node_a, 1);
916                         let (extra_msg_option, bs_revoke_and_ack) = commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true, true);
917                         assert!(extra_msg_option.is_none());
918                         bs_revoke_and_ack
919                 }
920         };
921         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, true /* return extra message */) => {
922                 {
923                         let (extra_msg_option, bs_revoke_and_ack) = commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true, true);
924                         $node_a.node.handle_revoke_and_ack(&$node_b.node.get_our_node_id(), &bs_revoke_and_ack);
925                         check_added_monitors!($node_a, 1);
926                         extra_msg_option
927                 }
928         };
929         ($node_a: expr, $node_b: expr, (), $fail_backwards: expr, true /* skip last step */, false /* no extra message */) => {
930                 {
931                         assert!(commitment_signed_dance!($node_a, $node_b, (), $fail_backwards, true, true).is_none());
932                 }
933         };
934         ($node_a: expr, $node_b: expr, $commitment_signed: expr, $fail_backwards: expr) => {
935                 {
936                         commitment_signed_dance!($node_a, $node_b, $commitment_signed, $fail_backwards, true);
937                         if $fail_backwards {
938                                 expect_pending_htlcs_forwardable!($node_a);
939                                 check_added_monitors!($node_a, 1);
940
941                                 let channel_state = $node_a.node.channel_state.lock().unwrap();
942                                 assert_eq!(channel_state.pending_msg_events.len(), 1);
943                                 if let MessageSendEvent::UpdateHTLCs { ref node_id, .. } = channel_state.pending_msg_events[0] {
944                                         assert_ne!(*node_id, $node_b.node.get_our_node_id());
945                                 } else { panic!("Unexpected event"); }
946                         } else {
947                                 assert!($node_a.node.get_and_clear_pending_msg_events().is_empty());
948                         }
949                 }
950         }
951 }
952
953 /// Get a payment preimage and hash.
954 #[macro_export]
955 macro_rules! get_payment_preimage_hash {
956         ($dest_node: expr) => {
957                 {
958                         let payment_preimage = PaymentPreimage([*$dest_node.network_payment_count.borrow(); 32]);
959                         *$dest_node.network_payment_count.borrow_mut() += 1;
960                         let payment_hash = PaymentHash(Sha256::hash(&payment_preimage.0[..]).into_inner());
961                         let payment_secret = $dest_node.node.create_inbound_payment_for_hash(payment_hash, None, 7200, 0).unwrap();
962                         (payment_preimage, payment_hash, payment_secret)
963                 }
964         }
965 }
966
967 #[cfg(test)]
968 macro_rules! get_route_and_payment_hash {
969         ($send_node: expr, $recv_node: expr, $recv_value: expr) => {{
970                 let (payment_preimage, payment_hash, payment_secret) = get_payment_preimage_hash!($recv_node);
971                 let net_graph_msg_handler = &$send_node.net_graph_msg_handler;
972                 let route = get_route(&$send_node.node.get_our_node_id(),
973                         &net_graph_msg_handler.network_graph.read().unwrap(),
974                         &$recv_node.node.get_our_node_id(), None, None, &Vec::new(), $recv_value, TEST_FINAL_CLTV, $send_node.logger).unwrap();
975                 (route, payment_hash, payment_preimage, payment_secret)
976         }}
977 }
978
979 macro_rules! expect_pending_htlcs_forwardable_ignore {
980         ($node: expr) => {{
981                 let events = $node.node.get_and_clear_pending_events();
982                 assert_eq!(events.len(), 1);
983                 match events[0] {
984                         Event::PendingHTLCsForwardable { .. } => { },
985                         _ => panic!("Unexpected event"),
986                 };
987         }}
988 }
989
990 macro_rules! expect_pending_htlcs_forwardable {
991         ($node: expr) => {{
992                 expect_pending_htlcs_forwardable_ignore!($node);
993                 $node.node.process_pending_htlc_forwards();
994         }}
995 }
996
997 #[cfg(any(test, feature = "unstable"))]
998 macro_rules! expect_payment_received {
999         ($node: expr, $expected_payment_hash: expr, $expected_payment_secret: expr, $expected_recv_value: expr) => {
1000                 let events = $node.node.get_and_clear_pending_events();
1001                 assert_eq!(events.len(), 1);
1002                 match events[0] {
1003                         Event::PaymentReceived { ref payment_hash, ref purpose, amt } => {
1004                                 assert_eq!($expected_payment_hash, *payment_hash);
1005                                 assert_eq!($expected_recv_value, amt);
1006                                 match purpose {
1007                                         PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1008                                                 assert!(payment_preimage.is_none());
1009                                                 assert_eq!($expected_payment_secret, *payment_secret);
1010                                         },
1011                                         _ => {},
1012                                 }
1013                         },
1014                         _ => panic!("Unexpected event"),
1015                 }
1016         }
1017 }
1018
1019 macro_rules! expect_payment_sent {
1020         ($node: expr, $expected_payment_preimage: expr) => {
1021                 let events = $node.node.get_and_clear_pending_events();
1022                 assert_eq!(events.len(), 1);
1023                 match events[0] {
1024                         Event::PaymentSent { ref payment_preimage } => {
1025                                 assert_eq!($expected_payment_preimage, *payment_preimage);
1026                         },
1027                         _ => panic!("Unexpected event"),
1028                 }
1029         }
1030 }
1031
1032 macro_rules! expect_payment_forwarded {
1033         ($node: expr, $expected_fee: expr, $upstream_force_closed: expr) => {
1034                 let events = $node.node.get_and_clear_pending_events();
1035                 assert_eq!(events.len(), 1);
1036                 match events[0] {
1037                         Event::PaymentForwarded { fee_earned_msat, claim_from_onchain_tx } => {
1038                                 assert_eq!(fee_earned_msat, $expected_fee);
1039                                 assert_eq!(claim_from_onchain_tx, $upstream_force_closed);
1040                         },
1041                         _ => panic!("Unexpected event"),
1042                 }
1043         }
1044 }
1045
1046 #[cfg(test)]
1047 macro_rules! expect_payment_failure_chan_update {
1048         ($node: expr, $scid: expr, $chan_closed: expr) => {
1049                 let events = $node.node.get_and_clear_pending_msg_events();
1050                 assert_eq!(events.len(), 1);
1051                 match events[0] {
1052                         MessageSendEvent::PaymentFailureNetworkUpdate { ref update } => {
1053                                 match update {
1054                                         &HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg } if !$chan_closed => {
1055                                                 assert_eq!(msg.contents.short_channel_id, $scid);
1056                                                 assert_eq!(msg.contents.flags & 2, 0);
1057                                         },
1058                                         &HTLCFailChannelUpdate::ChannelClosed { short_channel_id, is_permanent } if $chan_closed => {
1059                                                 assert_eq!(short_channel_id, $scid);
1060                                                 assert!(is_permanent);
1061                                         },
1062                                         _ => panic!("Unexpected update type"),
1063                                 }
1064                         },
1065                         _ => panic!("Unexpected event"),
1066                 }
1067         }
1068 }
1069
1070 #[cfg(test)]
1071 macro_rules! expect_payment_failed {
1072         ($node: expr, $expected_payment_hash: expr, $rejected_by_dest: expr $(, $expected_error_code: expr, $expected_error_data: expr)*) => {
1073                 let events = $node.node.get_and_clear_pending_events();
1074                 assert_eq!(events.len(), 1);
1075                 match events[0] {
1076                         Event::PaymentFailed { ref payment_hash, rejected_by_dest, ref error_code, ref error_data } => {
1077                                 assert_eq!(*payment_hash, $expected_payment_hash, "unexpected payment_hash");
1078                                 assert_eq!(rejected_by_dest, $rejected_by_dest, "unexpected rejected_by_dest value");
1079                                 assert!(error_code.is_some(), "expected error_code.is_some() = true");
1080                                 assert!(error_data.is_some(), "expected error_data.is_some() = true");
1081                                 $(
1082                                         assert_eq!(error_code.unwrap(), $expected_error_code, "unexpected error code");
1083                                         assert_eq!(&error_data.as_ref().unwrap()[..], $expected_error_data, "unexpected error data");
1084                                 )*
1085                         },
1086                         _ => panic!("Unexpected event"),
1087                 }
1088         }
1089 }
1090
1091 pub fn send_along_route_with_secret<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, route: Route, expected_paths: &[&[&Node<'a, 'b, 'c>]], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: PaymentSecret) {
1092         origin_node.node.send_payment(&route, our_payment_hash, &Some(our_payment_secret)).unwrap();
1093         check_added_monitors!(origin_node, expected_paths.len());
1094         pass_along_route(origin_node, expected_paths, recv_value, our_payment_hash, our_payment_secret);
1095 }
1096
1097 pub fn pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_path: &[&Node<'a, 'b, 'c>], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: Option<PaymentSecret>, ev: MessageSendEvent, payment_received_expected: bool, expected_preimage: Option<PaymentPreimage>) {
1098         let mut payment_event = SendEvent::from_event(ev);
1099         let mut prev_node = origin_node;
1100
1101         for (idx, &node) in expected_path.iter().enumerate() {
1102                 assert_eq!(node.node.get_our_node_id(), payment_event.node_id);
1103
1104                 node.node.handle_update_add_htlc(&prev_node.node.get_our_node_id(), &payment_event.msgs[0]);
1105                 check_added_monitors!(node, 0);
1106                 commitment_signed_dance!(node, prev_node, payment_event.commitment_msg, false);
1107
1108                 expect_pending_htlcs_forwardable!(node);
1109
1110                 if idx == expected_path.len() - 1 {
1111                         let events_2 = node.node.get_and_clear_pending_events();
1112                         if payment_received_expected {
1113                                 assert_eq!(events_2.len(), 1);
1114                                 match events_2[0] {
1115                                         Event::PaymentReceived { ref payment_hash, ref purpose, amt} => {
1116                                                 assert_eq!(our_payment_hash, *payment_hash);
1117                                                 match &purpose {
1118                                                         PaymentPurpose::InvoicePayment { payment_preimage, payment_secret, .. } => {
1119                                                                 assert_eq!(expected_preimage, *payment_preimage);
1120                                                                 assert_eq!(our_payment_secret.unwrap(), *payment_secret);
1121                                                         },
1122                                                         PaymentPurpose::SpontaneousPayment(payment_preimage) => {
1123                                                                 assert_eq!(expected_preimage.unwrap(), *payment_preimage);
1124                                                                 assert!(our_payment_secret.is_none());
1125                                                         },
1126                                                 }
1127                                                 assert_eq!(amt, recv_value);
1128                                         },
1129                                         _ => panic!("Unexpected event"),
1130                                 }
1131                         } else {
1132                                 assert!(events_2.is_empty());
1133                         }
1134                 } else {
1135                         let mut events_2 = node.node.get_and_clear_pending_msg_events();
1136                         assert_eq!(events_2.len(), 1);
1137                         check_added_monitors!(node, 1);
1138                         payment_event = SendEvent::from_event(events_2.remove(0));
1139                         assert_eq!(payment_event.msgs.len(), 1);
1140                 }
1141
1142                 prev_node = node;
1143         }
1144 }
1145
1146 pub fn pass_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&[&Node<'a, 'b, 'c>]], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: PaymentSecret) {
1147         let mut events = origin_node.node.get_and_clear_pending_msg_events();
1148         assert_eq!(events.len(), expected_route.len());
1149         for (path_idx, (ev, expected_path)) in events.drain(..).zip(expected_route.iter()).enumerate() {
1150                 // Once we've gotten through all the HTLCs, the last one should result in a
1151                 // PaymentReceived (but each previous one should not!), .
1152                 let expect_payment = path_idx == expected_route.len() - 1;
1153                 pass_along_path(origin_node, expected_path, recv_value, our_payment_hash.clone(), Some(our_payment_secret), ev, expect_payment, None);
1154         }
1155 }
1156
1157 pub fn send_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, route: Route, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64) -> (PaymentPreimage, PaymentHash, PaymentSecret) {
1158         let (our_payment_preimage, our_payment_hash, our_payment_secret) = get_payment_preimage_hash!(expected_route.last().unwrap());
1159         send_along_route_with_secret(origin_node, route, &[expected_route], recv_value, our_payment_hash, our_payment_secret);
1160         (our_payment_preimage, our_payment_hash, our_payment_secret)
1161 }
1162
1163 pub fn claim_payment_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_paths: &[&[&Node<'a, 'b, 'c>]], skip_last: bool, our_payment_preimage: PaymentPreimage) {
1164         for path in expected_paths.iter() {
1165                 assert_eq!(path.last().unwrap().node.get_our_node_id(), expected_paths[0].last().unwrap().node.get_our_node_id());
1166         }
1167         assert!(expected_paths[0].last().unwrap().node.claim_funds(our_payment_preimage));
1168         check_added_monitors!(expected_paths[0].last().unwrap(), expected_paths.len());
1169
1170         macro_rules! msgs_from_ev {
1171                 ($ev: expr) => {
1172                         match $ev {
1173                                 &MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
1174                                         assert!(update_add_htlcs.is_empty());
1175                                         assert_eq!(update_fulfill_htlcs.len(), 1);
1176                                         assert!(update_fail_htlcs.is_empty());
1177                                         assert!(update_fail_malformed_htlcs.is_empty());
1178                                         assert!(update_fee.is_none());
1179                                         ((update_fulfill_htlcs[0].clone(), commitment_signed.clone()), node_id.clone())
1180                                 },
1181                                 _ => panic!("Unexpected event"),
1182                         }
1183                 }
1184         }
1185         let mut per_path_msgs: Vec<((msgs::UpdateFulfillHTLC, msgs::CommitmentSigned), PublicKey)> = Vec::with_capacity(expected_paths.len());
1186         let events = expected_paths[0].last().unwrap().node.get_and_clear_pending_msg_events();
1187         assert_eq!(events.len(), expected_paths.len());
1188         for ev in events.iter() {
1189                 per_path_msgs.push(msgs_from_ev!(ev));
1190         }
1191
1192         for (expected_route, (path_msgs, next_hop)) in expected_paths.iter().zip(per_path_msgs.drain(..)) {
1193                 let mut next_msgs = Some(path_msgs);
1194                 let mut expected_next_node = next_hop;
1195
1196                 macro_rules! last_update_fulfill_dance {
1197                         ($node: expr, $prev_node: expr) => {
1198                                 {
1199                                         $node.node.handle_update_fulfill_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1200                                         check_added_monitors!($node, 0);
1201                                         assert!($node.node.get_and_clear_pending_msg_events().is_empty());
1202                                         commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, false);
1203                                 }
1204                         }
1205                 }
1206                 macro_rules! mid_update_fulfill_dance {
1207                         ($node: expr, $prev_node: expr, $new_msgs: expr) => {
1208                                 {
1209                                         $node.node.handle_update_fulfill_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1210                                         let fee = $node.node.channel_state.lock().unwrap().by_id.get(&next_msgs.as_ref().unwrap().0.channel_id).unwrap().config.forwarding_fee_base_msat;
1211                                         expect_payment_forwarded!($node, Some(fee as u64), false);
1212                                         check_added_monitors!($node, 1);
1213                                         let new_next_msgs = if $new_msgs {
1214                                                 let events = $node.node.get_and_clear_pending_msg_events();
1215                                                 assert_eq!(events.len(), 1);
1216                                                 let (res, nexthop) = msgs_from_ev!(&events[0]);
1217                                                 expected_next_node = nexthop;
1218                                                 Some(res)
1219                                         } else {
1220                                                 assert!($node.node.get_and_clear_pending_msg_events().is_empty());
1221                                                 None
1222                                         };
1223                                         commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, false);
1224                                         next_msgs = new_next_msgs;
1225                                 }
1226                         }
1227                 }
1228
1229                 let mut prev_node = expected_route.last().unwrap();
1230                 for (idx, node) in expected_route.iter().rev().enumerate().skip(1) {
1231                         assert_eq!(expected_next_node, node.node.get_our_node_id());
1232                         let update_next_msgs = !skip_last || idx != expected_route.len() - 1;
1233                         if next_msgs.is_some() {
1234                                 mid_update_fulfill_dance!(node, prev_node, update_next_msgs);
1235                         } else {
1236                                 assert!(!update_next_msgs);
1237                                 assert!(node.node.get_and_clear_pending_msg_events().is_empty());
1238                         }
1239                         if !skip_last && idx == expected_route.len() - 1 {
1240                                 assert_eq!(expected_next_node, origin_node.node.get_our_node_id());
1241                         }
1242
1243                         prev_node = node;
1244                 }
1245
1246                 if !skip_last {
1247                         last_update_fulfill_dance!(origin_node, expected_route.first().unwrap());
1248                         expect_payment_sent!(origin_node, our_payment_preimage);
1249                 }
1250         }
1251 }
1252
1253 pub fn claim_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], our_payment_preimage: PaymentPreimage) {
1254         claim_payment_along_route(origin_node, &[expected_route], false, our_payment_preimage);
1255 }
1256
1257 pub const TEST_FINAL_CLTV: u32 = 70;
1258
1259 pub fn route_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64) -> (PaymentPreimage, PaymentHash, PaymentSecret) {
1260         let net_graph_msg_handler = &origin_node.net_graph_msg_handler;
1261         let route = get_route(&origin_node.node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(),
1262                 &expected_route.last().unwrap().node.get_our_node_id(), Some(InvoiceFeatures::known()),
1263                 Some(&origin_node.node.list_usable_channels().iter().collect::<Vec<_>>()), &[],
1264                 recv_value, TEST_FINAL_CLTV, origin_node.logger).unwrap();
1265         assert_eq!(route.paths.len(), 1);
1266         assert_eq!(route.paths[0].len(), expected_route.len());
1267         for (node, hop) in expected_route.iter().zip(route.paths[0].iter()) {
1268                 assert_eq!(hop.pubkey, node.node.get_our_node_id());
1269         }
1270
1271         send_along_route(origin_node, route, expected_route, recv_value)
1272 }
1273
1274 pub fn route_over_limit<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64)  {
1275         let net_graph_msg_handler = &origin_node.net_graph_msg_handler;
1276         let route = get_route(&origin_node.node.get_our_node_id(), &net_graph_msg_handler.network_graph.read().unwrap(), &expected_route.last().unwrap().node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), recv_value, TEST_FINAL_CLTV, origin_node.logger).unwrap();
1277         assert_eq!(route.paths.len(), 1);
1278         assert_eq!(route.paths[0].len(), expected_route.len());
1279         for (node, hop) in expected_route.iter().zip(route.paths[0].iter()) {
1280                 assert_eq!(hop.pubkey, node.node.get_our_node_id());
1281         }
1282
1283         let (_, our_payment_hash, our_payment_preimage) = get_payment_preimage_hash!(expected_route.last().unwrap());
1284         unwrap_send_err!(origin_node.node.send_payment(&route, our_payment_hash, &Some(our_payment_preimage)), true, APIError::ChannelUnavailable { ref err },
1285                 assert!(err.contains("Cannot send value that would put us over the max HTLC value in flight our peer will accept")));
1286 }
1287
1288 pub fn send_payment<'a, 'b, 'c>(origin: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], recv_value: u64)  {
1289         let our_payment_preimage = route_payment(&origin, expected_route, recv_value).0;
1290         claim_payment(&origin, expected_route, our_payment_preimage);
1291 }
1292
1293 pub fn fail_payment_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], skip_last: bool, our_payment_hash: PaymentHash)  {
1294         assert!(expected_route.last().unwrap().node.fail_htlc_backwards(&our_payment_hash));
1295         expect_pending_htlcs_forwardable!(expected_route.last().unwrap());
1296         check_added_monitors!(expected_route.last().unwrap(), 1);
1297
1298         let mut next_msgs: Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned)> = None;
1299         macro_rules! update_fail_dance {
1300                 ($node: expr, $prev_node: expr, $last_node: expr) => {
1301                         {
1302                                 $node.node.handle_update_fail_htlc(&$prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
1303                                 commitment_signed_dance!($node, $prev_node, next_msgs.as_ref().unwrap().1, !$last_node);
1304                                 if skip_last && $last_node {
1305                                         expect_pending_htlcs_forwardable!($node);
1306                                 }
1307                         }
1308                 }
1309         }
1310
1311         let mut expected_next_node = expected_route.last().unwrap().node.get_our_node_id();
1312         let mut prev_node = expected_route.last().unwrap();
1313         for (idx, node) in expected_route.iter().rev().enumerate() {
1314                 assert_eq!(expected_next_node, node.node.get_our_node_id());
1315                 if next_msgs.is_some() {
1316                         // We may be the "last node" for the purpose of the commitment dance if we're
1317                         // skipping the last node (implying it is disconnected) and we're the
1318                         // second-to-last node!
1319                         update_fail_dance!(node, prev_node, skip_last && idx == expected_route.len() - 1);
1320                 }
1321
1322                 let events = node.node.get_and_clear_pending_msg_events();
1323                 if !skip_last || idx != expected_route.len() - 1 {
1324                         assert_eq!(events.len(), 1);
1325                         match events[0] {
1326                                 MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
1327                                         assert!(update_add_htlcs.is_empty());
1328                                         assert!(update_fulfill_htlcs.is_empty());
1329                                         assert_eq!(update_fail_htlcs.len(), 1);
1330                                         assert!(update_fail_malformed_htlcs.is_empty());
1331                                         assert!(update_fee.is_none());
1332                                         expected_next_node = node_id.clone();
1333                                         next_msgs = Some((update_fail_htlcs[0].clone(), commitment_signed.clone()));
1334                                 },
1335                                 _ => panic!("Unexpected event"),
1336                         }
1337                 } else {
1338                         assert!(events.is_empty());
1339                 }
1340                 if !skip_last && idx == expected_route.len() - 1 {
1341                         assert_eq!(expected_next_node, origin_node.node.get_our_node_id());
1342                 }
1343
1344                 prev_node = node;
1345         }
1346
1347         if !skip_last {
1348                 update_fail_dance!(origin_node, expected_route.first().unwrap(), true);
1349
1350                 let events = origin_node.node.get_and_clear_pending_events();
1351                 assert_eq!(events.len(), 1);
1352                 match events[0] {
1353                         Event::PaymentFailed { payment_hash, rejected_by_dest, .. } => {
1354                                 assert_eq!(payment_hash, our_payment_hash);
1355                                 assert!(rejected_by_dest);
1356                         },
1357                         _ => panic!("Unexpected event"),
1358                 }
1359         }
1360 }
1361
1362 pub fn fail_payment<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&Node<'a, 'b, 'c>], our_payment_hash: PaymentHash)  {
1363         fail_payment_along_route(origin_node, expected_route, false, our_payment_hash);
1364 }
1365
1366 pub fn create_chanmon_cfgs(node_count: usize) -> Vec<TestChanMonCfg> {
1367         let mut chan_mon_cfgs = Vec::new();
1368         for i in 0..node_count {
1369                 let tx_broadcaster = test_utils::TestBroadcaster {
1370                         txn_broadcasted: Mutex::new(Vec::new()),
1371                         blocks: Arc::new(Mutex::new(vec![(genesis_block(Network::Testnet).header, 0)])),
1372                 };
1373                 let fee_estimator = test_utils::TestFeeEstimator { sat_per_kw: Mutex::new(253) };
1374                 let chain_source = test_utils::TestChainSource::new(Network::Testnet);
1375                 let logger = test_utils::TestLogger::with_id(format!("node {}", i));
1376                 let persister = test_utils::TestPersister::new();
1377                 let seed = [i as u8; 32];
1378                 let keys_manager = test_utils::TestKeysInterface::new(&seed, Network::Testnet);
1379
1380                 chan_mon_cfgs.push(TestChanMonCfg{ tx_broadcaster, fee_estimator, chain_source, logger, persister, keys_manager });
1381         }
1382
1383         chan_mon_cfgs
1384 }
1385
1386 pub fn create_node_cfgs<'a>(node_count: usize, chanmon_cfgs: &'a Vec<TestChanMonCfg>) -> Vec<NodeCfg<'a>> {
1387         let mut nodes = Vec::new();
1388
1389         for i in 0..node_count {
1390                 let chain_monitor = test_utils::TestChainMonitor::new(Some(&chanmon_cfgs[i].chain_source), &chanmon_cfgs[i].tx_broadcaster, &chanmon_cfgs[i].logger, &chanmon_cfgs[i].fee_estimator, &chanmon_cfgs[i].persister, &chanmon_cfgs[i].keys_manager);
1391                 let seed = [i as u8; 32];
1392                 nodes.push(NodeCfg {
1393                         chain_source: &chanmon_cfgs[i].chain_source,
1394                         logger: &chanmon_cfgs[i].logger,
1395                         tx_broadcaster: &chanmon_cfgs[i].tx_broadcaster,
1396                         fee_estimator: &chanmon_cfgs[i].fee_estimator,
1397                         chain_monitor,
1398                         keys_manager: &chanmon_cfgs[i].keys_manager,
1399                         node_seed: seed,
1400                         features: InitFeatures::known(),
1401                 });
1402         }
1403
1404         nodes
1405 }
1406
1407 pub fn test_default_channel_config() -> UserConfig {
1408         let mut default_config = UserConfig::default();
1409         // Set cltv_expiry_delta slightly lower to keep the final CLTV values inside one byte in our
1410         // tests so that our script-length checks don't fail (see ACCEPTED_HTLC_SCRIPT_WEIGHT).
1411         default_config.channel_options.cltv_expiry_delta = 6*6;
1412         default_config.channel_options.announced_channel = true;
1413         default_config.peer_channel_config_limits.force_announced_channel_preference = false;
1414         // When most of our tests were written, the default HTLC minimum was fixed at 1000.
1415         // It now defaults to 1, so we simply set it to the expected value here.
1416         default_config.own_channel_config.our_htlc_minimum_msat = 1000;
1417         // When most of our tests were written, we didn't have the notion of a `max_dust_htlc_exposure_msat`,
1418         // It now defaults to 5_000_000 msat; to avoid interfering with tests we bump it to 50_000_000 msat.
1419         default_config.channel_options.max_dust_htlc_exposure_msat = 50_000_000;
1420         default_config
1421 }
1422
1423 pub fn create_node_chanmgrs<'a, 'b>(node_count: usize, cfgs: &'a Vec<NodeCfg<'b>>, node_config: &[Option<UserConfig>]) -> Vec<ChannelManager<EnforcingSigner, &'a TestChainMonitor<'b>, &'b test_utils::TestBroadcaster, &'a test_utils::TestKeysInterface, &'b test_utils::TestFeeEstimator, &'b test_utils::TestLogger>> {
1424         let mut chanmgrs = Vec::new();
1425         for i in 0..node_count {
1426                 let network = Network::Testnet;
1427                 let params = ChainParameters {
1428                         network,
1429                         best_block: BestBlock::from_genesis(network),
1430                 };
1431                 let node = ChannelManager::new(cfgs[i].fee_estimator, &cfgs[i].chain_monitor, cfgs[i].tx_broadcaster, cfgs[i].logger, cfgs[i].keys_manager,
1432                         if node_config[i].is_some() { node_config[i].clone().unwrap() } else { test_default_channel_config() }, params);
1433                 chanmgrs.push(node);
1434         }
1435
1436         chanmgrs
1437 }
1438
1439 pub fn create_network<'a, 'b: 'a, 'c: 'b>(node_count: usize, cfgs: &'b Vec<NodeCfg<'c>>, chan_mgrs: &'a Vec<ChannelManager<EnforcingSigner, &'b TestChainMonitor<'c>, &'c test_utils::TestBroadcaster, &'b test_utils::TestKeysInterface, &'c test_utils::TestFeeEstimator, &'c test_utils::TestLogger>>) -> Vec<Node<'a, 'b, 'c>> {
1440         let mut nodes = Vec::new();
1441         let chan_count = Rc::new(RefCell::new(0));
1442         let payment_count = Rc::new(RefCell::new(0));
1443         let connect_style = Rc::new(RefCell::new(ConnectStyle::FullBlockViaListen));
1444
1445         for i in 0..node_count {
1446                 let net_graph_msg_handler = NetGraphMsgHandler::new(cfgs[i].chain_source.genesis_hash, None, cfgs[i].logger);
1447                 nodes.push(Node{ chain_source: cfgs[i].chain_source,
1448                                  tx_broadcaster: cfgs[i].tx_broadcaster, chain_monitor: &cfgs[i].chain_monitor,
1449                                  keys_manager: &cfgs[i].keys_manager, node: &chan_mgrs[i], net_graph_msg_handler,
1450                                  node_seed: cfgs[i].node_seed, network_chan_count: chan_count.clone(),
1451                                  network_payment_count: payment_count.clone(), logger: cfgs[i].logger,
1452                                  blocks: Arc::clone(&cfgs[i].tx_broadcaster.blocks),
1453                                  connect_style: Rc::clone(&connect_style),
1454                 })
1455         }
1456
1457         for i in 0..node_count {
1458                 for j in (i+1)..node_count {
1459                         nodes[i].node.peer_connected(&nodes[j].node.get_our_node_id(), &msgs::Init { features: cfgs[j].features.clone() });
1460                         nodes[j].node.peer_connected(&nodes[i].node.get_our_node_id(), &msgs::Init { features: cfgs[i].features.clone() });
1461                 }
1462         }
1463
1464         nodes
1465 }
1466
1467 // Note that the following only works for CLTV values up to 128
1468 pub const ACCEPTED_HTLC_SCRIPT_WEIGHT: usize = 137; //Here we have a diff due to HTLC CLTV expiry being < 2^15 in test
1469 pub const OFFERED_HTLC_SCRIPT_WEIGHT: usize = 133;
1470
1471 #[derive(PartialEq)]
1472 pub enum HTLCType { NONE, TIMEOUT, SUCCESS }
1473 /// Tests that the given node has broadcast transactions for the given Channel
1474 ///
1475 /// First checks that the latest holder commitment tx has been broadcast, unless an explicit
1476 /// commitment_tx is provided, which may be used to test that a remote commitment tx was
1477 /// broadcast and the revoked outputs were claimed.
1478 ///
1479 /// Next tests that there is (or is not) a transaction that spends the commitment transaction
1480 /// that appears to be the type of HTLC transaction specified in has_htlc_tx.
1481 ///
1482 /// All broadcast transactions must be accounted for in one of the above three types of we'll
1483 /// also fail.
1484 pub fn test_txn_broadcast<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, chan: &(msgs::ChannelUpdate, msgs::ChannelUpdate, [u8; 32], Transaction), commitment_tx: Option<Transaction>, has_htlc_tx: HTLCType) -> Vec<Transaction>  {
1485         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1486         assert!(node_txn.len() >= if commitment_tx.is_some() { 0 } else { 1 } + if has_htlc_tx == HTLCType::NONE { 0 } else { 1 });
1487
1488         let mut res = Vec::with_capacity(2);
1489         node_txn.retain(|tx| {
1490                 if tx.input.len() == 1 && tx.input[0].previous_output.txid == chan.3.txid() {
1491                         check_spends!(tx, chan.3);
1492                         if commitment_tx.is_none() {
1493                                 res.push(tx.clone());
1494                         }
1495                         false
1496                 } else { true }
1497         });
1498         if let Some(explicit_tx) = commitment_tx {
1499                 res.push(explicit_tx.clone());
1500         }
1501
1502         assert_eq!(res.len(), 1);
1503
1504         if has_htlc_tx != HTLCType::NONE {
1505                 node_txn.retain(|tx| {
1506                         if tx.input.len() == 1 && tx.input[0].previous_output.txid == res[0].txid() {
1507                                 check_spends!(tx, res[0]);
1508                                 if has_htlc_tx == HTLCType::TIMEOUT {
1509                                         assert!(tx.lock_time != 0);
1510                                 } else {
1511                                         assert!(tx.lock_time == 0);
1512                                 }
1513                                 res.push(tx.clone());
1514                                 false
1515                         } else { true }
1516                 });
1517                 assert!(res.len() == 2 || res.len() == 3);
1518                 if res.len() == 3 {
1519                         assert_eq!(res[1], res[2]);
1520                 }
1521         }
1522
1523         assert!(node_txn.is_empty());
1524         res
1525 }
1526
1527 /// Tests that the given node has broadcast a claim transaction against the provided revoked
1528 /// HTLC transaction.
1529 pub fn test_revoked_htlc_claim_txn_broadcast<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, revoked_tx: Transaction, commitment_revoked_tx: Transaction)  {
1530         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1531         // We may issue multiple claiming transaction on revoked outputs due to block rescan
1532         // for revoked htlc outputs
1533         if node_txn.len() != 1 && node_txn.len() != 2 && node_txn.len() != 3 { assert!(false); }
1534         node_txn.retain(|tx| {
1535                 if tx.input.len() == 1 && tx.input[0].previous_output.txid == revoked_tx.txid() {
1536                         check_spends!(tx, revoked_tx);
1537                         false
1538                 } else { true }
1539         });
1540         node_txn.retain(|tx| {
1541                 check_spends!(tx, commitment_revoked_tx);
1542                 false
1543         });
1544         assert!(node_txn.is_empty());
1545 }
1546
1547 pub fn check_preimage_claim<'a, 'b, 'c>(node: &Node<'a, 'b, 'c>, prev_txn: &Vec<Transaction>) -> Vec<Transaction>  {
1548         let mut node_txn = node.tx_broadcaster.txn_broadcasted.lock().unwrap();
1549
1550         assert!(node_txn.len() >= 1);
1551         assert_eq!(node_txn[0].input.len(), 1);
1552         let mut found_prev = false;
1553
1554         for tx in prev_txn {
1555                 if node_txn[0].input[0].previous_output.txid == tx.txid() {
1556                         check_spends!(node_txn[0], tx);
1557                         assert!(node_txn[0].input[0].witness[2].len() > 106); // must spend an htlc output
1558                         assert_eq!(tx.input.len(), 1); // must spend a commitment tx
1559
1560                         found_prev = true;
1561                         break;
1562                 }
1563         }
1564         assert!(found_prev);
1565
1566         let mut res = Vec::new();
1567         mem::swap(&mut *node_txn, &mut res);
1568         res
1569 }
1570
1571 pub fn handle_announce_close_broadcast_events<'a, 'b, 'c>(nodes: &Vec<Node<'a, 'b, 'c>>, a: usize, b: usize, needs_err_handle: bool, expected_error: &str)  {
1572         let events_1 = nodes[a].node.get_and_clear_pending_msg_events();
1573         assert_eq!(events_1.len(), 2);
1574         let as_update = match events_1[0] {
1575                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
1576                         msg.clone()
1577                 },
1578                 _ => panic!("Unexpected event"),
1579         };
1580         match events_1[1] {
1581                 MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
1582                         assert_eq!(node_id, nodes[b].node.get_our_node_id());
1583                         assert_eq!(msg.data, expected_error);
1584                         if needs_err_handle {
1585                                 nodes[b].node.handle_error(&nodes[a].node.get_our_node_id(), msg);
1586                         }
1587                 },
1588                 _ => panic!("Unexpected event"),
1589         }
1590
1591         let events_2 = nodes[b].node.get_and_clear_pending_msg_events();
1592         assert_eq!(events_2.len(), if needs_err_handle { 1 } else { 2 });
1593         let bs_update = match events_2[0] {
1594                 MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
1595                         msg.clone()
1596                 },
1597                 _ => panic!("Unexpected event"),
1598         };
1599         if !needs_err_handle {
1600                 match events_2[1] {
1601                         MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
1602                                 assert_eq!(node_id, nodes[a].node.get_our_node_id());
1603                                 assert_eq!(msg.data, expected_error);
1604                         },
1605                         _ => panic!("Unexpected event"),
1606                 }
1607         }
1608
1609         for node in nodes {
1610                 node.net_graph_msg_handler.handle_channel_update(&as_update).unwrap();
1611                 node.net_graph_msg_handler.handle_channel_update(&bs_update).unwrap();
1612         }
1613 }
1614
1615 pub fn get_announce_close_broadcast_events<'a, 'b, 'c>(nodes: &Vec<Node<'a, 'b, 'c>>, a: usize, b: usize)  {
1616         handle_announce_close_broadcast_events(nodes, a, b, false, "Commitment or closing transaction was confirmed on chain.");
1617 }
1618
1619 #[cfg(test)]
1620 macro_rules! get_channel_value_stat {
1621         ($node: expr, $channel_id: expr) => {{
1622                 let chan_lock = $node.node.channel_state.lock().unwrap();
1623                 let chan = chan_lock.by_id.get(&$channel_id).unwrap();
1624                 chan.get_value_stat()
1625         }}
1626 }
1627
1628 macro_rules! get_chan_reestablish_msgs {
1629         ($src_node: expr, $dst_node: expr) => {
1630                 {
1631                         let mut res = Vec::with_capacity(1);
1632                         for msg in $src_node.node.get_and_clear_pending_msg_events() {
1633                                 if let MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } = msg {
1634                                         assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1635                                         res.push(msg.clone());
1636                                 } else {
1637                                         panic!("Unexpected event")
1638                                 }
1639                         }
1640                         res
1641                 }
1642         }
1643 }
1644
1645 macro_rules! handle_chan_reestablish_msgs {
1646         ($src_node: expr, $dst_node: expr) => {
1647                 {
1648                         let msg_events = $src_node.node.get_and_clear_pending_msg_events();
1649                         let mut idx = 0;
1650                         let funding_locked = if let Some(&MessageSendEvent::SendFundingLocked { ref node_id, ref msg }) = msg_events.get(0) {
1651                                 idx += 1;
1652                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1653                                 Some(msg.clone())
1654                         } else {
1655                                 None
1656                         };
1657
1658                         if let Some(&MessageSendEvent::SendAnnouncementSignatures { ref node_id, msg: _ }) = msg_events.get(idx) {
1659                                 idx += 1;
1660                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1661                         }
1662
1663                         let mut revoke_and_ack = None;
1664                         let mut commitment_update = None;
1665                         let order = if let Some(ev) = msg_events.get(idx) {
1666                                 match ev {
1667                                         &MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1668                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1669                                                 revoke_and_ack = Some(msg.clone());
1670                                                 idx += 1;
1671                                                 RAACommitmentOrder::RevokeAndACKFirst
1672                                         },
1673                                         &MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1674                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1675                                                 commitment_update = Some(updates.clone());
1676                                                 idx += 1;
1677                                                 RAACommitmentOrder::CommitmentFirst
1678                                         },
1679                                         &MessageSendEvent::SendChannelUpdate { .. } => RAACommitmentOrder::CommitmentFirst,
1680                                         _ => panic!("Unexpected event"),
1681                                 }
1682                         } else {
1683                                 RAACommitmentOrder::CommitmentFirst
1684                         };
1685
1686                         if let Some(ev) = msg_events.get(idx) {
1687                                 match ev {
1688                                         &MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
1689                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1690                                                 assert!(revoke_and_ack.is_none());
1691                                                 revoke_and_ack = Some(msg.clone());
1692                                                 idx += 1;
1693                                         },
1694                                         &MessageSendEvent::UpdateHTLCs { ref node_id, ref updates } => {
1695                                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1696                                                 assert!(commitment_update.is_none());
1697                                                 commitment_update = Some(updates.clone());
1698                                                 idx += 1;
1699                                         },
1700                                         &MessageSendEvent::SendChannelUpdate { .. } => {},
1701                                         _ => panic!("Unexpected event"),
1702                                 }
1703                         }
1704
1705                         if let Some(&MessageSendEvent::SendChannelUpdate { ref node_id, ref msg }) = msg_events.get(idx) {
1706                                 assert_eq!(*node_id, $dst_node.node.get_our_node_id());
1707                                 assert_eq!(msg.contents.flags & 2, 0); // "disabled" flag must not be set as we just reconnected.
1708                         }
1709
1710                         (funding_locked, revoke_and_ack, commitment_update, order)
1711                 }
1712         }
1713 }
1714
1715 /// pending_htlc_adds includes both the holding cell and in-flight update_add_htlcs, whereas
1716 /// for claims/fails they are separated out.
1717 pub fn reconnect_nodes<'a, 'b, 'c>(node_a: &Node<'a, 'b, 'c>, node_b: &Node<'a, 'b, 'c>, send_funding_locked: (bool, bool), pending_htlc_adds: (i64, i64), pending_htlc_claims: (usize, usize), pending_htlc_fails: (usize, usize), pending_cell_htlc_claims: (usize, usize), pending_cell_htlc_fails: (usize, usize), pending_raa: (bool, bool))  {
1718         node_a.node.peer_connected(&node_b.node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1719         let reestablish_1 = get_chan_reestablish_msgs!(node_a, node_b);
1720         node_b.node.peer_connected(&node_a.node.get_our_node_id(), &msgs::Init { features: InitFeatures::empty() });
1721         let reestablish_2 = get_chan_reestablish_msgs!(node_b, node_a);
1722
1723         if send_funding_locked.0 {
1724                 // If a expects a funding_locked, it better not think it has received a revoke_and_ack
1725                 // from b
1726                 for reestablish in reestablish_1.iter() {
1727                         assert_eq!(reestablish.next_remote_commitment_number, 0);
1728                 }
1729         }
1730         if send_funding_locked.1 {
1731                 // If b expects a funding_locked, it better not think it has received a revoke_and_ack
1732                 // from a
1733                 for reestablish in reestablish_2.iter() {
1734                         assert_eq!(reestablish.next_remote_commitment_number, 0);
1735                 }
1736         }
1737         if send_funding_locked.0 || send_funding_locked.1 {
1738                 // If we expect any funding_locked's, both sides better have set
1739                 // next_holder_commitment_number to 1
1740                 for reestablish in reestablish_1.iter() {
1741                         assert_eq!(reestablish.next_local_commitment_number, 1);
1742                 }
1743                 for reestablish in reestablish_2.iter() {
1744                         assert_eq!(reestablish.next_local_commitment_number, 1);
1745                 }
1746         }
1747
1748         let mut resp_1 = Vec::new();
1749         for msg in reestablish_1 {
1750                 node_b.node.handle_channel_reestablish(&node_a.node.get_our_node_id(), &msg);
1751                 resp_1.push(handle_chan_reestablish_msgs!(node_b, node_a));
1752         }
1753         if pending_cell_htlc_claims.0 != 0 || pending_cell_htlc_fails.0 != 0 {
1754                 check_added_monitors!(node_b, 1);
1755         } else {
1756                 check_added_monitors!(node_b, 0);
1757         }
1758
1759         let mut resp_2 = Vec::new();
1760         for msg in reestablish_2 {
1761                 node_a.node.handle_channel_reestablish(&node_b.node.get_our_node_id(), &msg);
1762                 resp_2.push(handle_chan_reestablish_msgs!(node_a, node_b));
1763         }
1764         if pending_cell_htlc_claims.1 != 0 || pending_cell_htlc_fails.1 != 0 {
1765                 check_added_monitors!(node_a, 1);
1766         } else {
1767                 check_added_monitors!(node_a, 0);
1768         }
1769
1770         // We don't yet support both needing updates, as that would require a different commitment dance:
1771         assert!((pending_htlc_adds.0 == 0 && pending_htlc_claims.0 == 0 && pending_htlc_fails.0 == 0 &&
1772                          pending_cell_htlc_claims.0 == 0 && pending_cell_htlc_fails.0 == 0) ||
1773                         (pending_htlc_adds.1 == 0 && pending_htlc_claims.1 == 0 && pending_htlc_fails.1 == 0 &&
1774                          pending_cell_htlc_claims.1 == 0 && pending_cell_htlc_fails.1 == 0));
1775
1776         for chan_msgs in resp_1.drain(..) {
1777                 if send_funding_locked.0 {
1778                         node_a.node.handle_funding_locked(&node_b.node.get_our_node_id(), &chan_msgs.0.unwrap());
1779                         let announcement_event = node_a.node.get_and_clear_pending_msg_events();
1780                         if !announcement_event.is_empty() {
1781                                 assert_eq!(announcement_event.len(), 1);
1782                                 if let MessageSendEvent::SendAnnouncementSignatures { .. } = announcement_event[0] {
1783                                         //TODO: Test announcement_sigs re-sending
1784                                 } else { panic!("Unexpected event!"); }
1785                         }
1786                 } else {
1787                         assert!(chan_msgs.0.is_none());
1788                 }
1789                 if pending_raa.0 {
1790                         assert!(chan_msgs.3 == RAACommitmentOrder::RevokeAndACKFirst);
1791                         node_a.node.handle_revoke_and_ack(&node_b.node.get_our_node_id(), &chan_msgs.1.unwrap());
1792                         assert!(node_a.node.get_and_clear_pending_msg_events().is_empty());
1793                         check_added_monitors!(node_a, 1);
1794                 } else {
1795                         assert!(chan_msgs.1.is_none());
1796                 }
1797                 if pending_htlc_adds.0 != 0 || pending_htlc_claims.0 != 0 || pending_htlc_fails.0 != 0 || pending_cell_htlc_claims.0 != 0 || pending_cell_htlc_fails.0 != 0 {
1798                         let commitment_update = chan_msgs.2.unwrap();
1799                         if pending_htlc_adds.0 != -1 { // We use -1 to denote a response commitment_signed
1800                                 assert_eq!(commitment_update.update_add_htlcs.len(), pending_htlc_adds.0 as usize);
1801                         } else {
1802                                 assert!(commitment_update.update_add_htlcs.is_empty());
1803                         }
1804                         assert_eq!(commitment_update.update_fulfill_htlcs.len(), pending_htlc_claims.0 + pending_cell_htlc_claims.0);
1805                         assert_eq!(commitment_update.update_fail_htlcs.len(), pending_htlc_fails.0 + pending_cell_htlc_fails.0);
1806                         assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
1807                         for update_add in commitment_update.update_add_htlcs {
1808                                 node_a.node.handle_update_add_htlc(&node_b.node.get_our_node_id(), &update_add);
1809                         }
1810                         for update_fulfill in commitment_update.update_fulfill_htlcs {
1811                                 node_a.node.handle_update_fulfill_htlc(&node_b.node.get_our_node_id(), &update_fulfill);
1812                         }
1813                         for update_fail in commitment_update.update_fail_htlcs {
1814                                 node_a.node.handle_update_fail_htlc(&node_b.node.get_our_node_id(), &update_fail);
1815                         }
1816
1817                         if pending_htlc_adds.0 != -1 { // We use -1 to denote a response commitment_signed
1818                                 commitment_signed_dance!(node_a, node_b, commitment_update.commitment_signed, false);
1819                         } else {
1820                                 node_a.node.handle_commitment_signed(&node_b.node.get_our_node_id(), &commitment_update.commitment_signed);
1821                                 check_added_monitors!(node_a, 1);
1822                                 let as_revoke_and_ack = get_event_msg!(node_a, MessageSendEvent::SendRevokeAndACK, node_b.node.get_our_node_id());
1823                                 // No commitment_signed so get_event_msg's assert(len == 1) passes
1824                                 node_b.node.handle_revoke_and_ack(&node_a.node.get_our_node_id(), &as_revoke_and_ack);
1825                                 assert!(node_b.node.get_and_clear_pending_msg_events().is_empty());
1826                                 check_added_monitors!(node_b, 1);
1827                         }
1828                 } else {
1829                         assert!(chan_msgs.2.is_none());
1830                 }
1831         }
1832
1833         for chan_msgs in resp_2.drain(..) {
1834                 if send_funding_locked.1 {
1835                         node_b.node.handle_funding_locked(&node_a.node.get_our_node_id(), &chan_msgs.0.unwrap());
1836                         let announcement_event = node_b.node.get_and_clear_pending_msg_events();
1837                         if !announcement_event.is_empty() {
1838                                 assert_eq!(announcement_event.len(), 1);
1839                                 if let MessageSendEvent::SendAnnouncementSignatures { .. } = announcement_event[0] {
1840                                         //TODO: Test announcement_sigs re-sending
1841                                 } else { panic!("Unexpected event!"); }
1842                         }
1843                 } else {
1844                         assert!(chan_msgs.0.is_none());
1845                 }
1846                 if pending_raa.1 {
1847                         assert!(chan_msgs.3 == RAACommitmentOrder::RevokeAndACKFirst);
1848                         node_b.node.handle_revoke_and_ack(&node_a.node.get_our_node_id(), &chan_msgs.1.unwrap());
1849                         assert!(node_b.node.get_and_clear_pending_msg_events().is_empty());
1850                         check_added_monitors!(node_b, 1);
1851                 } else {
1852                         assert!(chan_msgs.1.is_none());
1853                 }
1854                 if pending_htlc_adds.1 != 0 || pending_htlc_claims.1 != 0 || pending_htlc_fails.1 != 0 || pending_cell_htlc_claims.1 != 0 || pending_cell_htlc_fails.1 != 0 {
1855                         let commitment_update = chan_msgs.2.unwrap();
1856                         if pending_htlc_adds.1 != -1 { // We use -1 to denote a response commitment_signed
1857                                 assert_eq!(commitment_update.update_add_htlcs.len(), pending_htlc_adds.1 as usize);
1858                         }
1859                         assert_eq!(commitment_update.update_fulfill_htlcs.len(), pending_htlc_claims.1 + pending_cell_htlc_claims.1);
1860                         assert_eq!(commitment_update.update_fail_htlcs.len(), pending_htlc_fails.1 + pending_cell_htlc_fails.1);
1861                         assert!(commitment_update.update_fail_malformed_htlcs.is_empty());
1862                         for update_add in commitment_update.update_add_htlcs {
1863                                 node_b.node.handle_update_add_htlc(&node_a.node.get_our_node_id(), &update_add);
1864                         }
1865                         for update_fulfill in commitment_update.update_fulfill_htlcs {
1866                                 node_b.node.handle_update_fulfill_htlc(&node_a.node.get_our_node_id(), &update_fulfill);
1867                         }
1868                         for update_fail in commitment_update.update_fail_htlcs {
1869                                 node_b.node.handle_update_fail_htlc(&node_a.node.get_our_node_id(), &update_fail);
1870                         }
1871
1872                         if pending_htlc_adds.1 != -1 { // We use -1 to denote a response commitment_signed
1873                                 commitment_signed_dance!(node_b, node_a, commitment_update.commitment_signed, false);
1874                         } else {
1875                                 node_b.node.handle_commitment_signed(&node_a.node.get_our_node_id(), &commitment_update.commitment_signed);
1876                                 check_added_monitors!(node_b, 1);
1877                                 let bs_revoke_and_ack = get_event_msg!(node_b, MessageSendEvent::SendRevokeAndACK, node_a.node.get_our_node_id());
1878                                 // No commitment_signed so get_event_msg's assert(len == 1) passes
1879                                 node_a.node.handle_revoke_and_ack(&node_b.node.get_our_node_id(), &bs_revoke_and_ack);
1880                                 assert!(node_a.node.get_and_clear_pending_msg_events().is_empty());
1881                                 check_added_monitors!(node_a, 1);
1882                         }
1883                 } else {
1884                         assert!(chan_msgs.2.is_none());
1885                 }
1886         }
1887 }