_ Git - rust-lightning/blob - lightning/src/ln/msgs.rs

   1 //! Wire messages, traits representing wire message handlers, and a few error types live here.
   2 //!
   3 //! For a normal node you probably don't need to use anything here, however, if you wish to split a
   4 //! node into an internet-facing route/message socket handling daemon and a separate daemon (or
   5 //! server entirely) which handles only channel-related messages you may wish to implement
   6 //! ChannelMessageHandler yourself and use it to re-serialize messages and pass them across
   7 //! daemons/servers.
   8 //!
   9 //! Note that if you go with such an architecture (instead of passing raw socket events to a
  10 //! non-internet-facing system) you trust the frontend internet-facing system to not lie about the
  11 //! source node_id of the message, however this does allow you to significantly reduce bandwidth
  12 //! between the systems as routing messages can represent a significant chunk of bandwidth usage
  13 //! (especially for non-channel-publicly-announcing nodes). As an alternate design which avoids
  14 //! this issue, if you have sufficient bidirectional bandwidth between your systems, you may send
  15 //! raw socket events into your non-internet-facing system and then send routing events back to
  16 //! track the network on the less-secure system.
  17
  18 use secp256k1::key::PublicKey;
  19 use secp256k1::Signature;
  20 use secp256k1;
  21 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
  22 use bitcoin::blockdata::script::Script;
  23
  24 use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
  25
  26 use std::error::Error;
  27 use std::{cmp, fmt};
  28 use std::io::Read;
  29 use std::result::Result;
  30
  31 use util::events;
  32 use util::ser::{Readable, Writeable, Writer};
  33
  34 use ln::channelmanager::{PaymentPreimage, PaymentHash};
  35
  36 /// An error in decoding a message or struct.
  37 #[derive(Debug)]
  38 pub enum DecodeError {
  39         /// A version byte specified something we don't know how to handle.
  40         /// Includes unknown realm byte in an OnionHopData packet
  41         UnknownVersion,
  42         /// Unknown feature mandating we fail to parse message
  43         UnknownRequiredFeature,
  44         /// Value was invalid, eg a byte which was supposed to be a bool was something other than a 0
  45         /// or 1, a public key/private key/signature was invalid, text wasn't UTF-8, etc
  46         InvalidValue,
  47         /// Buffer too short
  48         ShortRead,
  49         /// node_announcement included more than one address of a given type!
  50         ExtraAddressesPerType,
  51         /// A length descriptor in the packet didn't describe the later data correctly
  52         BadLengthDescriptor,
  53         /// Error from std::io
  54         Io(::std::io::Error),
  55 }
  56
  57 /// An init message to be sent or received from a peer
  58 pub struct Init {
  59         #[cfg(not(feature = "fuzztarget"))]
  60         pub(crate) features: InitFeatures,
  61         #[cfg(feature = "fuzztarget")]
  62         pub features: InitFeatures,
  63 }
  64
  65 /// An error message to be sent or received from a peer
  66 #[derive(Clone)]
  67 pub struct ErrorMessage {
  68         pub(crate) channel_id: [u8; 32],
  69         pub(crate) data: String,
  70 }
  71
  72 /// A ping message to be sent or received from a peer
  73 pub struct Ping {
  74         pub(crate) ponglen: u16,
  75         pub(crate) byteslen: u16,
  76 }
  77
  78 /// A pong message to be sent or received from a peer
  79 pub struct Pong {
  80         pub(crate) byteslen: u16,
  81 }
  82
  83 /// An open_channel message to be sent or received from a peer
  84 #[derive(Clone)]
  85 pub struct OpenChannel {
  86         pub(crate) chain_hash: Sha256dHash,
  87         pub(crate) temporary_channel_id: [u8; 32],
  88         pub(crate) funding_satoshis: u64,
  89         pub(crate) push_msat: u64,
  90         pub(crate) dust_limit_satoshis: u64,
  91         pub(crate) max_htlc_value_in_flight_msat: u64,
  92         pub(crate) channel_reserve_satoshis: u64,
  93         pub(crate) htlc_minimum_msat: u64,
  94         pub(crate) feerate_per_kw: u32,
  95         pub(crate) to_self_delay: u16,
  96         pub(crate) max_accepted_htlcs: u16,
  97         pub(crate) funding_pubkey: PublicKey,
  98         pub(crate) revocation_basepoint: PublicKey,
  99         pub(crate) payment_basepoint: PublicKey,
 100         pub(crate) delayed_payment_basepoint: PublicKey,
 101         pub(crate) htlc_basepoint: PublicKey,
 102         pub(crate) first_per_commitment_point: PublicKey,
 103         pub(crate) channel_flags: u8,
 104         pub(crate) shutdown_scriptpubkey: OptionalField<Script>,
 105 }
 106
 107 /// An accept_channel message to be sent or received from a peer
 108 #[derive(Clone)]
 109 pub struct AcceptChannel {
 110         pub(crate) temporary_channel_id: [u8; 32],
 111         pub(crate) dust_limit_satoshis: u64,
 112         pub(crate) max_htlc_value_in_flight_msat: u64,
 113         pub(crate) channel_reserve_satoshis: u64,
 114         pub(crate) htlc_minimum_msat: u64,
 115         pub(crate) minimum_depth: u32,
 116         pub(crate) to_self_delay: u16,
 117         pub(crate) max_accepted_htlcs: u16,
 118         pub(crate) funding_pubkey: PublicKey,
 119         pub(crate) revocation_basepoint: PublicKey,
 120         pub(crate) payment_basepoint: PublicKey,
 121         pub(crate) delayed_payment_basepoint: PublicKey,
 122         pub(crate) htlc_basepoint: PublicKey,
 123         pub(crate) first_per_commitment_point: PublicKey,
 124         pub(crate) shutdown_scriptpubkey: OptionalField<Script>
 125 }
 126
 127 /// A funding_created message to be sent or received from a peer
 128 #[derive(Clone)]
 129 pub struct FundingCreated {
 130         pub(crate) temporary_channel_id: [u8; 32],
 131         pub(crate) funding_txid: Sha256dHash,
 132         pub(crate) funding_output_index: u16,
 133         pub(crate) signature: Signature,
 134 }
 135
 136 /// A funding_signed message to be sent or received from a peer
 137 #[derive(Clone)]
 138 pub struct FundingSigned {
 139         pub(crate) channel_id: [u8; 32],
 140         pub(crate) signature: Signature,
 141 }
 142
 143 /// A funding_locked message to be sent or received from a peer
 144 #[derive(Clone, PartialEq)]
 145 #[allow(missing_docs)]
 146 pub struct FundingLocked {
 147         pub channel_id: [u8; 32],
 148         pub next_per_commitment_point: PublicKey,
 149 }
 150
 151 /// A shutdown message to be sent or received from a peer
 152 #[derive(Clone, PartialEq)]
 153 pub struct Shutdown {
 154         pub(crate) channel_id: [u8; 32],
 155         pub(crate) scriptpubkey: Script,
 156 }
 157
 158 /// A closing_signed message to be sent or received from a peer
 159 #[derive(Clone, PartialEq)]
 160 pub struct ClosingSigned {
 161         pub(crate) channel_id: [u8; 32],
 162         pub(crate) fee_satoshis: u64,
 163         pub(crate) signature: Signature,
 164 }
 165
 166 /// An update_add_htlc message to be sent or received from a peer
 167 #[derive(Clone, PartialEq)]
 168 pub struct UpdateAddHTLC {
 169         pub(crate) channel_id: [u8; 32],
 170         pub(crate) htlc_id: u64,
 171         pub(crate) amount_msat: u64,
 172         pub(crate) payment_hash: PaymentHash,
 173         pub(crate) cltv_expiry: u32,
 174         pub(crate) onion_routing_packet: OnionPacket,
 175 }
 176
 177 /// An update_fulfill_htlc message to be sent or received from a peer
 178 #[derive(Clone, PartialEq)]
 179 pub struct UpdateFulfillHTLC {
 180         pub(crate) channel_id: [u8; 32],
 181         pub(crate) htlc_id: u64,
 182         pub(crate) payment_preimage: PaymentPreimage,
 183 }
 184
 185 /// An update_fail_htlc message to be sent or received from a peer
 186 #[derive(Clone, PartialEq)]
 187 pub struct UpdateFailHTLC {
 188         pub(crate) channel_id: [u8; 32],
 189         pub(crate) htlc_id: u64,
 190         pub(crate) reason: OnionErrorPacket,
 191 }
 192
 193 /// An update_fail_malformed_htlc message to be sent or received from a peer
 194 #[derive(Clone, PartialEq)]
 195 pub struct UpdateFailMalformedHTLC {
 196         pub(crate) channel_id: [u8; 32],
 197         pub(crate) htlc_id: u64,
 198         pub(crate) sha256_of_onion: [u8; 32],
 199         pub(crate) failure_code: u16,
 200 }
 201
 202 /// A commitment_signed message to be sent or received from a peer
 203 #[derive(Clone, PartialEq)]
 204 pub struct CommitmentSigned {
 205         pub(crate) channel_id: [u8; 32],
 206         pub(crate) signature: Signature,
 207         pub(crate) htlc_signatures: Vec<Signature>,
 208 }
 209
 210 /// A revoke_and_ack message to be sent or received from a peer
 211 #[derive(Clone, PartialEq)]
 212 pub struct RevokeAndACK {
 213         pub(crate) channel_id: [u8; 32],
 214         pub(crate) per_commitment_secret: [u8; 32],
 215         pub(crate) next_per_commitment_point: PublicKey,
 216 }
 217
 218 /// An update_fee message to be sent or received from a peer
 219 #[derive(PartialEq, Clone)]
 220 pub struct UpdateFee {
 221         pub(crate) channel_id: [u8; 32],
 222         pub(crate) feerate_per_kw: u32,
 223 }
 224
 225 #[derive(PartialEq, Clone)]
 226 pub(crate) struct DataLossProtect {
 227         pub(crate) your_last_per_commitment_secret: [u8; 32],
 228         pub(crate) my_current_per_commitment_point: PublicKey,
 229 }
 230
 231 /// A channel_reestablish message to be sent or received from a peer
 232 #[derive(PartialEq, Clone)]
 233 pub struct ChannelReestablish {
 234         pub(crate) channel_id: [u8; 32],
 235         pub(crate) next_local_commitment_number: u64,
 236         pub(crate) next_remote_commitment_number: u64,
 237         pub(crate) data_loss_protect: OptionalField<DataLossProtect>,
 238 }
 239
 240 /// An announcement_signatures message to be sent or received from a peer
 241 #[derive(PartialEq, Clone, Debug)]
 242 pub struct AnnouncementSignatures {
 243         pub(crate) channel_id: [u8; 32],
 244         pub(crate) short_channel_id: u64,
 245         pub(crate) node_signature: Signature,
 246         pub(crate) bitcoin_signature: Signature,
 247 }
 248
 249 /// An address which can be used to connect to a remote peer
 250 #[derive(Clone, PartialEq, Debug)]
 251 pub enum NetAddress {
 252         /// An IPv4 address/port on which the peer is listening.
 253         IPv4 {
 254                 /// The 4-byte IPv4 address
 255                 addr: [u8; 4],
 256                 /// The port on which the node is listening
 257                 port: u16,
 258         },
 259         /// An IPv6 address/port on which the peer is listening.
 260         IPv6 {
 261                 /// The 16-byte IPv6 address
 262                 addr: [u8; 16],
 263                 /// The port on which the node is listening
 264                 port: u16,
 265         },
 266         /// An old-style Tor onion address/port on which the peer is listening.
 267         OnionV2 {
 268                 /// The bytes (usually encoded in base32 with ".onion" appended)
 269                 addr: [u8; 10],
 270                 /// The port on which the node is listening
 271                 port: u16,
 272         },
 273         /// A new-style Tor onion address/port on which the peer is listening.
 274         /// To create the human-readable "hostname", concatenate ed25519_pubkey, checksum, and version,
 275         /// wrap as base32 and append ".onion".
 276         OnionV3 {
 277                 /// The ed25519 long-term public key of the peer
 278                 ed25519_pubkey: [u8; 32],
 279                 /// The checksum of the pubkey and version, as included in the onion address
 280                 checksum: u16,
 281                 /// The version byte, as defined by the Tor Onion v3 spec.
 282                 version: u8,
 283                 /// The port on which the node is listening
 284                 port: u16,
 285         },
 286 }
 287 impl NetAddress {
 288         fn get_id(&self) -> u8 {
 289                 match self {
 290                         &NetAddress::IPv4 {..} => { 1 },
 291                         &NetAddress::IPv6 {..} => { 2 },
 292                         &NetAddress::OnionV2 {..} => { 3 },
 293                         &NetAddress::OnionV3 {..} => { 4 },
 294                 }
 295         }
 296
 297         /// Strict byte-length of address descriptor, 1-byte type not recorded
 298         fn len(&self) -> u16 {
 299                 match self {
 300                         &NetAddress::IPv4 { .. } => { 6 },
 301                         &NetAddress::IPv6 { .. } => { 18 },
 302                         &NetAddress::OnionV2 { .. } => { 12 },
 303                         &NetAddress::OnionV3 { .. } => { 37 },
 304                 }
 305         }
 306 }
 307
 308 impl Writeable for NetAddress {
 309         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
 310                 match self {
 311                         &NetAddress::IPv4 { ref addr, ref port } => {
 312                                 1u8.write(writer)?;
 313                                 addr.write(writer)?;
 314                                 port.write(writer)?;
 315                         },
 316                         &NetAddress::IPv6 { ref addr, ref port } => {
 317                                 2u8.write(writer)?;
 318                                 addr.write(writer)?;
 319                                 port.write(writer)?;
 320                         },
 321                         &NetAddress::OnionV2 { ref addr, ref port } => {
 322                                 3u8.write(writer)?;
 323                                 addr.write(writer)?;
 324                                 port.write(writer)?;
 325                         },
 326                         &NetAddress::OnionV3 { ref ed25519_pubkey, ref checksum, ref version, ref port } => {
 327                                 4u8.write(writer)?;
 328                                 ed25519_pubkey.write(writer)?;
 329                                 checksum.write(writer)?;
 330                                 version.write(writer)?;
 331                                 port.write(writer)?;
 332                         }
 333                 }
 334                 Ok(())
 335         }
 336 }
 337
 338 impl<R: ::std::io::Read>  Readable<R> for Result<NetAddress, u8> {
 339         fn read(reader: &mut R) -> Result<Result<NetAddress, u8>, DecodeError> {
 340                 let byte = <u8 as Readable<R>>::read(reader)?;
 341                 match byte {
 342                         1 => {
 343                                 Ok(Ok(NetAddress::IPv4 {
 344                                         addr: Readable::read(reader)?,
 345                                         port: Readable::read(reader)?,
 346                                 }))
 347                         },
 348                         2 => {
 349                                 Ok(Ok(NetAddress::IPv6 {
 350                                         addr: Readable::read(reader)?,
 351                                         port: Readable::read(reader)?,
 352                                 }))
 353                         },
 354                         3 => {
 355                                 Ok(Ok(NetAddress::OnionV2 {
 356                                         addr: Readable::read(reader)?,
 357                                         port: Readable::read(reader)?,
 358                                 }))
 359                         },
 360                         4 => {
 361                                 Ok(Ok(NetAddress::OnionV3 {
 362                                         ed25519_pubkey: Readable::read(reader)?,
 363                                         checksum: Readable::read(reader)?,
 364                                         version: Readable::read(reader)?,
 365                                         port: Readable::read(reader)?,
 366                                 }))
 367                         },
 368                         _ => return Ok(Err(byte)),
 369                 }
 370         }
 371 }
 372
 373 // Only exposed as broadcast of node_announcement should be filtered by node_id
 374 /// The unsigned part of a node_announcement
 375 #[derive(PartialEq, Clone, Debug)]
 376 pub struct UnsignedNodeAnnouncement {
 377         pub(crate) features: NodeFeatures,
 378         pub(crate) timestamp: u32,
 379         /// The node_id this announcement originated from (don't rebroadcast the node_announcement back
 380         /// to this node).
 381         pub        node_id: PublicKey,
 382         pub(crate) rgb: [u8; 3],
 383         pub(crate) alias: [u8; 32],
 384         /// List of addresses on which this node is reachable. Note that you may only have up to one
 385         /// address of each type, if you have more, they may be silently discarded or we may panic!
 386         pub(crate) addresses: Vec<NetAddress>,
 387         pub(crate) excess_address_data: Vec<u8>,
 388         pub(crate) excess_data: Vec<u8>,
 389 }
 390 #[derive(PartialEq, Clone)]
 391 /// A node_announcement message to be sent or received from a peer
 392 pub struct NodeAnnouncement {
 393         pub(crate) signature: Signature,
 394         pub(crate) contents: UnsignedNodeAnnouncement,
 395 }
 396
 397 // Only exposed as broadcast of channel_announcement should be filtered by node_id
 398 /// The unsigned part of a channel_announcement
 399 #[derive(PartialEq, Clone, Debug)]
 400 pub struct UnsignedChannelAnnouncement {
 401         pub(crate) features: ChannelFeatures,
 402         pub(crate) chain_hash: Sha256dHash,
 403         pub(crate) short_channel_id: u64,
 404         /// One of the two node_ids which are endpoints of this channel
 405         pub        node_id_1: PublicKey,
 406         /// The other of the two node_ids which are endpoints of this channel
 407         pub        node_id_2: PublicKey,
 408         pub(crate) bitcoin_key_1: PublicKey,
 409         pub(crate) bitcoin_key_2: PublicKey,
 410         pub(crate) excess_data: Vec<u8>,
 411 }
 412 /// A channel_announcement message to be sent or received from a peer
 413 #[derive(PartialEq, Clone, Debug)]
 414 pub struct ChannelAnnouncement {
 415         pub(crate) node_signature_1: Signature,
 416         pub(crate) node_signature_2: Signature,
 417         pub(crate) bitcoin_signature_1: Signature,
 418         pub(crate) bitcoin_signature_2: Signature,
 419         pub(crate) contents: UnsignedChannelAnnouncement,
 420 }
 421
 422 #[derive(PartialEq, Clone, Debug)]
 423 pub(crate) struct UnsignedChannelUpdate {
 424         pub(crate) chain_hash: Sha256dHash,
 425         pub(crate) short_channel_id: u64,
 426         pub(crate) timestamp: u32,
 427         pub(crate) flags: u16,
 428         pub(crate) cltv_expiry_delta: u16,
 429         pub(crate) htlc_minimum_msat: u64,
 430         pub(crate) fee_base_msat: u32,
 431         pub(crate) fee_proportional_millionths: u32,
 432         pub(crate) excess_data: Vec<u8>,
 433 }
 434 /// A channel_update message to be sent or received from a peer
 435 #[derive(PartialEq, Clone, Debug)]
 436 pub struct ChannelUpdate {
 437         pub(crate) signature: Signature,
 438         pub(crate) contents: UnsignedChannelUpdate,
 439 }
 440
 441 /// Used to put an error message in a LightningError
 442 #[derive(Clone)]
 443 pub enum ErrorAction {
 444         /// The peer took some action which made us think they were useless. Disconnect them.
 445         DisconnectPeer {
 446                 /// An error message which we should make an effort to send before we disconnect.
 447                 msg: Option<ErrorMessage>
 448         },
 449         /// The peer did something harmless that we weren't able to process, just log and ignore
 450         IgnoreError,
 451         /// The peer did something incorrect. Tell them.
 452         SendErrorMessage {
 453                 /// The message to send.
 454                 msg: ErrorMessage
 455         },
 456 }
 457
 458 /// An Err type for failure to process messages.
 459 pub struct LightningError {
 460         /// A human-readable message describing the error
 461         pub err: &'static str,
 462         /// The action which should be taken against the offending peer.
 463         pub action: ErrorAction,
 464 }
 465
 466 /// Struct used to return values from revoke_and_ack messages, containing a bunch of commitment
 467 /// transaction updates if they were pending.
 468 #[derive(PartialEq, Clone)]
 469 pub struct CommitmentUpdate {
 470         /// update_add_htlc messages which should be sent
 471         pub update_add_htlcs: Vec<UpdateAddHTLC>,
 472         /// update_fulfill_htlc messages which should be sent
 473         pub update_fulfill_htlcs: Vec<UpdateFulfillHTLC>,
 474         /// update_fail_htlc messages which should be sent
 475         pub update_fail_htlcs: Vec<UpdateFailHTLC>,
 476         /// update_fail_malformed_htlc messages which should be sent
 477         pub update_fail_malformed_htlcs: Vec<UpdateFailMalformedHTLC>,
 478         /// An update_fee message which should be sent
 479         pub update_fee: Option<UpdateFee>,
 480         /// Finally, the commitment_signed message which should be sent
 481         pub commitment_signed: CommitmentSigned,
 482 }
 483
 484 /// The information we received from a peer along the route of a payment we originated. This is
 485 /// returned by ChannelMessageHandler::handle_update_fail_htlc to be passed into
 486 /// RoutingMessageHandler::handle_htlc_fail_channel_update to update our network map.
 487 #[derive(Clone)]
 488 pub enum HTLCFailChannelUpdate {
 489         /// We received an error which included a full ChannelUpdate message.
 490         ChannelUpdateMessage {
 491                 /// The unwrapped message we received
 492                 msg: ChannelUpdate,
 493         },
 494         /// We received an error which indicated only that a channel has been closed
 495         ChannelClosed {
 496                 /// The short_channel_id which has now closed.
 497                 short_channel_id: u64,
 498                 /// when this true, this channel should be permanently removed from the
 499                 /// consideration. Otherwise, this channel can be restored as new channel_update is received
 500                 is_permanent: bool,
 501         },
 502         /// We received an error which indicated only that a node has failed
 503         NodeFailure {
 504                 /// The node_id that has failed.
 505                 node_id: PublicKey,
 506                 /// when this true, node should be permanently removed from the
 507                 /// consideration. Otherwise, the channels connected to this node can be
 508                 /// restored as new channel_update is received
 509                 is_permanent: bool,
 510         }
 511 }
 512
 513 /// Messages could have optional fields to use with extended features
 514 /// As we wish to serialize these differently from Option<T>s (Options get a tag byte, but
 515 /// OptionalFeild simply gets Present if there are enough bytes to read into it), we have a
 516 /// separate enum type for them.
 517 #[derive(Clone, PartialEq)]
 518 pub enum OptionalField<T> {
 519         /// Optional field is included in message
 520         Present(T),
 521         /// Optional field is absent in message
 522         Absent
 523 }
 524
 525 /// A trait to describe an object which can receive channel messages.
 526 ///
 527 /// Messages MAY be called in parallel when they originate from different their_node_ids, however
 528 /// they MUST NOT be called in parallel when the two calls have the same their_node_id.
 529 pub trait ChannelMessageHandler : events::MessageSendEventsProvider + Send + Sync {
 530         //Channel init:
 531         /// Handle an incoming open_channel message from the given peer.
 532         fn handle_open_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &OpenChannel);
 533         /// Handle an incoming accept_channel message from the given peer.
 534         fn handle_accept_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &AcceptChannel);
 535         /// Handle an incoming funding_created message from the given peer.
 536         fn handle_funding_created(&self, their_node_id: &PublicKey, msg: &FundingCreated);
 537         /// Handle an incoming funding_signed message from the given peer.
 538         fn handle_funding_signed(&self, their_node_id: &PublicKey, msg: &FundingSigned);
 539         /// Handle an incoming funding_locked message from the given peer.
 540         fn handle_funding_locked(&self, their_node_id: &PublicKey, msg: &FundingLocked);
 541
 542         // Channl close:
 543         /// Handle an incoming shutdown message from the given peer.
 544         fn handle_shutdown(&self, their_node_id: &PublicKey, msg: &Shutdown);
 545         /// Handle an incoming closing_signed message from the given peer.
 546         fn handle_closing_signed(&self, their_node_id: &PublicKey, msg: &ClosingSigned);
 547
 548         // HTLC handling:
 549         /// Handle an incoming update_add_htlc message from the given peer.
 550         fn handle_update_add_htlc(&self, their_node_id: &PublicKey, msg: &UpdateAddHTLC);
 551         /// Handle an incoming update_fulfill_htlc message from the given peer.
 552         fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFulfillHTLC);
 553         /// Handle an incoming update_fail_htlc message from the given peer.
 554         fn handle_update_fail_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailHTLC);
 555         /// Handle an incoming update_fail_malformed_htlc message from the given peer.
 556         fn handle_update_fail_malformed_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailMalformedHTLC);
 557         /// Handle an incoming commitment_signed message from the given peer.
 558         fn handle_commitment_signed(&self, their_node_id: &PublicKey, msg: &CommitmentSigned);
 559         /// Handle an incoming revoke_and_ack message from the given peer.
 560         fn handle_revoke_and_ack(&self, their_node_id: &PublicKey, msg: &RevokeAndACK);
 561
 562         /// Handle an incoming update_fee message from the given peer.
 563         fn handle_update_fee(&self, their_node_id: &PublicKey, msg: &UpdateFee);
 564
 565         // Channel-to-announce:
 566         /// Handle an incoming announcement_signatures message from the given peer.
 567         fn handle_announcement_signatures(&self, their_node_id: &PublicKey, msg: &AnnouncementSignatures);
 568
 569         // Connection loss/reestablish:
 570         /// Indicates a connection to the peer failed/an existing connection was lost. If no connection
 571         /// is believed to be possible in the future (eg they're sending us messages we don't
 572         /// understand or indicate they require unknown feature bits), no_connection_possible is set
 573         /// and any outstanding channels should be failed.
 574         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
 575
 576         /// Handle a peer reconnecting, possibly generating channel_reestablish message(s).
 577         fn peer_connected(&self, their_node_id: &PublicKey, msg: &Init);
 578         /// Handle an incoming channel_reestablish message from the given peer.
 579         fn handle_channel_reestablish(&self, their_node_id: &PublicKey, msg: &ChannelReestablish);
 580
 581         // Error:
 582         /// Handle an incoming error message from the given peer.
 583         fn handle_error(&self, their_node_id: &PublicKey, msg: &ErrorMessage);
 584 }
 585
 586 /// A trait to describe an object which can receive routing messages.
 587 pub trait RoutingMessageHandler : Send + Sync {
 588         /// Handle an incoming node_announcement message, returning true if it should be forwarded on,
 589         /// false or returning an Err otherwise.
 590         fn handle_node_announcement(&self, msg: &NodeAnnouncement) -> Result<bool, LightningError>;
 591         /// Handle a channel_announcement message, returning true if it should be forwarded on, false
 592         /// or returning an Err otherwise.
 593         fn handle_channel_announcement(&self, msg: &ChannelAnnouncement) -> Result<bool, LightningError>;
 594         /// Handle an incoming channel_update message, returning true if it should be forwarded on,
 595         /// false or returning an Err otherwise.
 596         fn handle_channel_update(&self, msg: &ChannelUpdate) -> Result<bool, LightningError>;
 597         /// Handle some updates to the route graph that we learned due to an outbound failed payment.
 598         fn handle_htlc_fail_channel_update(&self, update: &HTLCFailChannelUpdate);
 599         /// Gets a subset of the channel announcements and updates required to dump our routing table
 600         /// to a remote node, starting at the short_channel_id indicated by starting_point and
 601         /// including batch_amount entries.
 602         fn get_next_channel_announcements(&self, starting_point: u64, batch_amount: u8) -> Vec<(ChannelAnnouncement, ChannelUpdate, ChannelUpdate)>;
 603         /// Gets a subset of the node announcements required to dump our routing table to a remote node,
 604         /// starting at the node *after* the provided publickey and including batch_amount entries.
 605         /// If None is provided for starting_point, we start at the first node.
 606         fn get_next_node_announcements(&self, starting_point: Option<&PublicKey>, batch_amount: u8) -> Vec<NodeAnnouncement>;
 607         /// Returns whether a full sync should be requested from a peer.
 608         fn should_request_full_sync(&self, node_id: &PublicKey) -> bool;
 609 }
 610
 611 mod fuzzy_internal_msgs {
 612         // These types aren't intended to be pub, but are exposed for direct fuzzing (as we deserialize
 613         // them from untrusted input):
 614
 615         pub(crate) enum OnionHopDataFormat {
 616                 Legacy, // aka Realm-0
 617                 // Some tests expect to be able to generate bogus non-deserializable OnionHopDatas. In the
 618                 // future we can use bogus TLV attributes, but for now we have to expose a "bogus realm"
 619                 // option.
 620                 #[cfg(test)]
 621                 BogusRealm(u8),
 622         }
 623
 624         pub struct OnionHopData {
 625                 pub(crate) format: OnionHopDataFormat,
 626                 pub(crate) short_channel_id: u64,
 627                 pub(crate) amt_to_forward: u64,
 628                 pub(crate) outgoing_cltv_value: u32,
 629                 // 12 bytes of 0-padding
 630                 pub(crate) hmac: [u8; 32],
 631         }
 632
 633         pub struct DecodedOnionErrorPacket {
 634                 pub(crate) hmac: [u8; 32],
 635                 pub(crate) failuremsg: Vec<u8>,
 636                 pub(crate) pad: Vec<u8>,
 637         }
 638 }
 639 #[cfg(feature = "fuzztarget")]
 640 pub use self::fuzzy_internal_msgs::*;
 641 #[cfg(not(feature = "fuzztarget"))]
 642 pub(crate) use self::fuzzy_internal_msgs::*;
 643
 644 #[derive(Clone)]
 645 pub(crate) struct OnionPacket {
 646         pub(crate) version: u8,
 647         /// In order to ensure we always return an error on Onion decode in compliance with BOLT 4, we
 648         /// have to deserialize OnionPackets contained in UpdateAddHTLCs even if the ephemeral public
 649         /// key (here) is bogus, so we hold a Result instead of a PublicKey as we'd like.
 650         pub(crate) public_key: Result<PublicKey, secp256k1::Error>,
 651         pub(crate) hop_data: [u8; 20*65],
 652         pub(crate) hmac: [u8; 32],
 653 }
 654
 655 impl PartialEq for OnionPacket {
 656         fn eq(&self, other: &OnionPacket) -> bool {
 657                 for (i, j) in self.hop_data.iter().zip(other.hop_data.iter()) {
 658                         if i != j { return false; }
 659                 }
 660                 self.version == other.version &&
 661                         self.public_key == other.public_key &&
 662                         self.hmac == other.hmac
 663         }
 664 }
 665
 666 #[derive(Clone, PartialEq)]
 667 pub(crate) struct OnionErrorPacket {
 668         // This really should be a constant size slice, but the spec lets these things be up to 128KB?
 669         // (TODO) We limit it in decode to much lower...
 670         pub(crate) data: Vec<u8>,
 671 }
 672
 673 impl Error for DecodeError {
 674         fn description(&self) -> &str {
 675                 match *self {
 676                         DecodeError::UnknownVersion => "Unknown realm byte in Onion packet",
 677                         DecodeError::UnknownRequiredFeature => "Unknown required feature preventing decode",
 678                         DecodeError::InvalidValue => "Nonsense bytes didn't map to the type they were interpreted as",
 679                         DecodeError::ShortRead => "Packet extended beyond the provided bytes",
 680                         DecodeError::ExtraAddressesPerType => "More than one address of a single type",
 681                         DecodeError::BadLengthDescriptor => "A length descriptor in the packet didn't describe the later data correctly",
 682                         DecodeError::Io(ref e) => e.description(),
 683                 }
 684         }
 685 }
 686 impl fmt::Display for DecodeError {
 687         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 688                 f.write_str(self.description())
 689         }
 690 }
 691
 692 impl fmt::Debug for LightningError {
 693         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
 694                 f.write_str(self.err)
 695         }
 696 }
 697
 698 impl From<::std::io::Error> for DecodeError {
 699         fn from(e: ::std::io::Error) -> Self {
 700                 if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
 701                         DecodeError::ShortRead
 702                 } else {
 703                         DecodeError::Io(e)
 704                 }
 705         }
 706 }
 707
 708 impl Writeable for OptionalField<Script> {
 709         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 710                 match *self {
 711                         OptionalField::Present(ref script) => {
 712                                 // Note that Writeable for script includes the 16-bit length tag for us
 713                                 script.write(w)?;
 714                         },
 715                         OptionalField::Absent => {}
 716                 }
 717                 Ok(())
 718         }
 719 }
 720
 721 impl<R: Read> Readable<R> for OptionalField<Script> {
 722         fn read(r: &mut R) -> Result<Self, DecodeError> {
 723                 match <u16 as Readable<R>>::read(r) {
 724                         Ok(len) => {
 725                                 let mut buf = vec![0; len as usize];
 726                                 r.read_exact(&mut buf)?;
 727                                 Ok(OptionalField::Present(Script::from(buf)))
 728                         },
 729                         Err(DecodeError::ShortRead) => Ok(OptionalField::Absent),
 730                         Err(e) => Err(e)
 731                 }
 732         }
 733 }
 734
 735 impl_writeable_len_match!(AcceptChannel, {
 736                 {AcceptChannel{ shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 270 + 2 + script.len()},
 737                 {_, 270}
 738         }, {
 739         temporary_channel_id,
 740         dust_limit_satoshis,
 741         max_htlc_value_in_flight_msat,
 742         channel_reserve_satoshis,
 743         htlc_minimum_msat,
 744         minimum_depth,
 745         to_self_delay,
 746         max_accepted_htlcs,
 747         funding_pubkey,
 748         revocation_basepoint,
 749         payment_basepoint,
 750         delayed_payment_basepoint,
 751         htlc_basepoint,
 752         first_per_commitment_point,
 753         shutdown_scriptpubkey
 754 });
 755
 756 impl_writeable!(AnnouncementSignatures, 32+8+64*2, {
 757         channel_id,
 758         short_channel_id,
 759         node_signature,
 760         bitcoin_signature
 761 });
 762
 763 impl Writeable for ChannelReestablish {
 764         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 765                 w.size_hint(if let OptionalField::Present(..) = self.data_loss_protect { 32+2*8+33+32 } else { 32+2*8 });
 766                 self.channel_id.write(w)?;
 767                 self.next_local_commitment_number.write(w)?;
 768                 self.next_remote_commitment_number.write(w)?;
 769                 match self.data_loss_protect {
 770                         OptionalField::Present(ref data_loss_protect) => {
 771                                 (*data_loss_protect).your_last_per_commitment_secret.write(w)?;
 772                                 (*data_loss_protect).my_current_per_commitment_point.write(w)?;
 773                         },
 774                         OptionalField::Absent => {}
 775                 }
 776                 Ok(())
 777         }
 778 }
 779
 780 impl<R: Read> Readable<R> for ChannelReestablish{
 781         fn read(r: &mut R) -> Result<Self, DecodeError> {
 782                 Ok(Self {
 783                         channel_id: Readable::read(r)?,
 784                         next_local_commitment_number: Readable::read(r)?,
 785                         next_remote_commitment_number: Readable::read(r)?,
 786                         data_loss_protect: {
 787                                 match <[u8; 32] as Readable<R>>::read(r) {
 788                                         Ok(your_last_per_commitment_secret) =>
 789                                                 OptionalField::Present(DataLossProtect {
 790                                                         your_last_per_commitment_secret,
 791                                                         my_current_per_commitment_point: Readable::read(r)?,
 792                                                 }),
 793                                         Err(DecodeError::ShortRead) => OptionalField::Absent,
 794                                         Err(e) => return Err(e)
 795                                 }
 796                         }
 797                 })
 798         }
 799 }
 800
 801 impl_writeable!(ClosingSigned, 32+8+64, {
 802         channel_id,
 803         fee_satoshis,
 804         signature
 805 });
 806
 807 impl_writeable_len_match!(CommitmentSigned, {
 808                 { CommitmentSigned { ref htlc_signatures, .. }, 32+64+2+htlc_signatures.len()*64 }
 809         }, {
 810         channel_id,
 811         signature,
 812         htlc_signatures
 813 });
 814
 815 impl_writeable_len_match!(DecodedOnionErrorPacket, {
 816                 { DecodedOnionErrorPacket { ref failuremsg, ref pad, .. }, 32 + 4 + failuremsg.len() + pad.len() }
 817         }, {
 818         hmac,
 819         failuremsg,
 820         pad
 821 });
 822
 823 impl_writeable!(FundingCreated, 32+32+2+64, {
 824         temporary_channel_id,
 825         funding_txid,
 826         funding_output_index,
 827         signature
 828 });
 829
 830 impl_writeable!(FundingSigned, 32+64, {
 831         channel_id,
 832         signature
 833 });
 834
 835 impl_writeable!(FundingLocked, 32+33, {
 836         channel_id,
 837         next_per_commitment_point
 838 });
 839
 840 impl Writeable for Init {
 841         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 842                 // global_features gets the bottom 13 bits of our features, and local_features gets all of
 843                 // our relevant feature bits. This keeps us compatible with old nodes.
 844                 self.features.write_up_to_13(w)?;
 845                 self.features.write(w)
 846         }
 847 }
 848
 849 impl<R: Read> Readable<R> for Init {
 850         fn read(r: &mut R) -> Result<Self, DecodeError> {
 851                 let global_features: InitFeatures = Readable::read(r)?;
 852                 let features: InitFeatures = Readable::read(r)?;
 853                 Ok(Init {
 854                         features: features.or(global_features),
 855                 })
 856         }
 857 }
 858
 859 impl_writeable_len_match!(OpenChannel, {
 860                 { OpenChannel { shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 319 + 2 + script.len() },
 861                 { _, 319 }
 862         }, {
 863         chain_hash,
 864         temporary_channel_id,
 865         funding_satoshis,
 866         push_msat,
 867         dust_limit_satoshis,
 868         max_htlc_value_in_flight_msat,
 869         channel_reserve_satoshis,
 870         htlc_minimum_msat,
 871         feerate_per_kw,
 872         to_self_delay,
 873         max_accepted_htlcs,
 874         funding_pubkey,
 875         revocation_basepoint,
 876         payment_basepoint,
 877         delayed_payment_basepoint,
 878         htlc_basepoint,
 879         first_per_commitment_point,
 880         channel_flags,
 881         shutdown_scriptpubkey
 882 });
 883
 884 impl_writeable!(RevokeAndACK, 32+32+33, {
 885         channel_id,
 886         per_commitment_secret,
 887         next_per_commitment_point
 888 });
 889
 890 impl_writeable_len_match!(Shutdown, {
 891                 { Shutdown { ref scriptpubkey, .. }, 32 + 2 + scriptpubkey.len() }
 892         }, {
 893         channel_id,
 894         scriptpubkey
 895 });
 896
 897 impl_writeable_len_match!(UpdateFailHTLC, {
 898                 { UpdateFailHTLC { ref reason, .. }, 32 + 10 + reason.data.len() }
 899         }, {
 900         channel_id,
 901         htlc_id,
 902         reason
 903 });
 904
 905 impl_writeable!(UpdateFailMalformedHTLC, 32+8+32+2, {
 906         channel_id,
 907         htlc_id,
 908         sha256_of_onion,
 909         failure_code
 910 });
 911
 912 impl_writeable!(UpdateFee, 32+4, {
 913         channel_id,
 914         feerate_per_kw
 915 });
 916
 917 impl_writeable!(UpdateFulfillHTLC, 32+8+32, {
 918         channel_id,
 919         htlc_id,
 920         payment_preimage
 921 });
 922
 923 impl_writeable_len_match!(OnionErrorPacket, {
 924                 { OnionErrorPacket { ref data, .. }, 2 + data.len() }
 925         }, {
 926         data
 927 });
 928
 929 impl Writeable for OnionPacket {
 930         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 931                 w.size_hint(1 + 33 + 20*65 + 32);
 932                 self.version.write(w)?;
 933                 match self.public_key {
 934                         Ok(pubkey) => pubkey.write(w)?,
 935                         Err(_) => [0u8;33].write(w)?,
 936                 }
 937                 w.write_all(&self.hop_data)?;
 938                 self.hmac.write(w)?;
 939                 Ok(())
 940         }
 941 }
 942
 943 impl<R: Read> Readable<R> for OnionPacket {
 944         fn read(r: &mut R) -> Result<Self, DecodeError> {
 945                 Ok(OnionPacket {
 946                         version: Readable::read(r)?,
 947                         public_key: {
 948                                 let mut buf = [0u8;33];
 949                                 r.read_exact(&mut buf)?;
 950                                 PublicKey::from_slice(&buf)
 951                         },
 952                         hop_data: Readable::read(r)?,
 953                         hmac: Readable::read(r)?,
 954                 })
 955         }
 956 }
 957
 958 impl_writeable!(UpdateAddHTLC, 32+8+8+32+4+1366, {
 959         channel_id,
 960         htlc_id,
 961         amount_msat,
 962         payment_hash,
 963         cltv_expiry,
 964         onion_routing_packet
 965 });
 966
 967 impl Writeable for OnionHopData {
 968         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
 969                 w.size_hint(65);
 970                 match self.format {
 971                         OnionHopDataFormat::Legacy => 0u8.write(w)?,
 972                         #[cfg(test)]
 973                         OnionHopDataFormat::BogusRealm(v) => v.write(w)?,
 974                 }
 975                 self.short_channel_id.write(w)?;
 976                 self.amt_to_forward.write(w)?;
 977                 self.outgoing_cltv_value.write(w)?;
 978                 w.write_all(&[0;12])?;
 979                 self.hmac.write(w)?;
 980                 Ok(())
 981         }
 982 }
 983
 984 impl<R: Read> Readable<R> for OnionHopData {
 985         fn read(r: &mut R) -> Result<Self, DecodeError> {
 986                 Ok(OnionHopData {
 987                         format: {
 988                                 let r: u8 = Readable::read(r)?;
 989                                 if r != 0 {
 990                                         return Err(DecodeError::UnknownVersion);
 991                                 }
 992                                 OnionHopDataFormat::Legacy
 993                         },
 994                         short_channel_id: Readable::read(r)?,
 995                         amt_to_forward: Readable::read(r)?,
 996                         outgoing_cltv_value: {
 997                                 let v: u32 = Readable::read(r)?;
 998                                 r.read_exact(&mut [0; 12])?;
 999                                 v
1000                         },
1001                         hmac: Readable::read(r)?,
1002                 })
1003         }
1004 }
1005
1006 impl Writeable for Ping {
1007         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1008                 w.size_hint(self.byteslen as usize + 4);
1009                 self.ponglen.write(w)?;
1010                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1011                 Ok(())
1012         }
1013 }
1014
1015 impl<R: Read> Readable<R> for Ping {
1016         fn read(r: &mut R) -> Result<Self, DecodeError> {
1017                 Ok(Ping {
1018                         ponglen: Readable::read(r)?,
1019                         byteslen: {
1020                                 let byteslen = Readable::read(r)?;
1021                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1022                                 byteslen
1023                         }
1024                 })
1025         }
1026 }
1027
1028 impl Writeable for Pong {
1029         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1030                 w.size_hint(self.byteslen as usize + 2);
1031                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1032                 Ok(())
1033         }
1034 }
1035
1036 impl<R: Read> Readable<R> for Pong {
1037         fn read(r: &mut R) -> Result<Self, DecodeError> {
1038                 Ok(Pong {
1039                         byteslen: {
1040                                 let byteslen = Readable::read(r)?;
1041                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1042                                 byteslen
1043                         }
1044                 })
1045         }
1046 }
1047
1048 impl Writeable for UnsignedChannelAnnouncement {
1049         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1050                 w.size_hint(2 + 2*32 + 4*33 + self.features.byte_count() + self.excess_data.len());
1051                 self.features.write(w)?;
1052                 self.chain_hash.write(w)?;
1053                 self.short_channel_id.write(w)?;
1054                 self.node_id_1.write(w)?;
1055                 self.node_id_2.write(w)?;
1056                 self.bitcoin_key_1.write(w)?;
1057                 self.bitcoin_key_2.write(w)?;
1058                 w.write_all(&self.excess_data[..])?;
1059                 Ok(())
1060         }
1061 }
1062
1063 impl<R: Read> Readable<R> for UnsignedChannelAnnouncement {
1064         fn read(r: &mut R) -> Result<Self, DecodeError> {
1065                 Ok(Self {
1066                         features: Readable::read(r)?,
1067                         chain_hash: Readable::read(r)?,
1068                         short_channel_id: Readable::read(r)?,
1069                         node_id_1: Readable::read(r)?,
1070                         node_id_2: Readable::read(r)?,
1071                         bitcoin_key_1: Readable::read(r)?,
1072                         bitcoin_key_2: Readable::read(r)?,
1073                         excess_data: {
1074                                 let mut excess_data = vec![];
1075                                 r.read_to_end(&mut excess_data)?;
1076                                 excess_data
1077                         },
1078                 })
1079         }
1080 }
1081
1082 impl_writeable_len_match!(ChannelAnnouncement, {
1083                 { ChannelAnnouncement { contents: UnsignedChannelAnnouncement {ref features, ref excess_data, ..}, .. },
1084                         2 + 2*32 + 4*33 + features.byte_count() + excess_data.len() + 4*64 }
1085         }, {
1086         node_signature_1,
1087         node_signature_2,
1088         bitcoin_signature_1,
1089         bitcoin_signature_2,
1090         contents
1091 });
1092
1093 impl Writeable for UnsignedChannelUpdate {
1094         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1095                 w.size_hint(64 + self.excess_data.len());
1096                 self.chain_hash.write(w)?;
1097                 self.short_channel_id.write(w)?;
1098                 self.timestamp.write(w)?;
1099                 self.flags.write(w)?;
1100                 self.cltv_expiry_delta.write(w)?;
1101                 self.htlc_minimum_msat.write(w)?;
1102                 self.fee_base_msat.write(w)?;
1103                 self.fee_proportional_millionths.write(w)?;
1104                 w.write_all(&self.excess_data[..])?;
1105                 Ok(())
1106         }
1107 }
1108
1109 impl<R: Read> Readable<R> for UnsignedChannelUpdate {
1110         fn read(r: &mut R) -> Result<Self, DecodeError> {
1111                 Ok(Self {
1112                         chain_hash: Readable::read(r)?,
1113                         short_channel_id: Readable::read(r)?,
1114                         timestamp: Readable::read(r)?,
1115                         flags: Readable::read(r)?,
1116                         cltv_expiry_delta: Readable::read(r)?,
1117                         htlc_minimum_msat: Readable::read(r)?,
1118                         fee_base_msat: Readable::read(r)?,
1119                         fee_proportional_millionths: Readable::read(r)?,
1120                         excess_data: {
1121                                 let mut excess_data = vec![];
1122                                 r.read_to_end(&mut excess_data)?;
1123                                 excess_data
1124                         },
1125                 })
1126         }
1127 }
1128
1129 impl_writeable_len_match!(ChannelUpdate, {
1130                 { ChannelUpdate { contents: UnsignedChannelUpdate {ref excess_data, ..}, .. },
1131                         64 + excess_data.len() + 64 }
1132         }, {
1133         signature,
1134         contents
1135 });
1136
1137 impl Writeable for ErrorMessage {
1138         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1139                 w.size_hint(32 + 2 + self.data.len());
1140                 self.channel_id.write(w)?;
1141                 (self.data.len() as u16).write(w)?;
1142                 w.write_all(self.data.as_bytes())?;
1143                 Ok(())
1144         }
1145 }
1146
1147 impl<R: Read> Readable<R> for ErrorMessage {
1148         fn read(r: &mut R) -> Result<Self, DecodeError> {
1149                 Ok(Self {
1150                         channel_id: Readable::read(r)?,
1151                         data: {
1152                                 let mut sz: usize = <u16 as Readable<R>>::read(r)? as usize;
1153                                 let mut data = vec![];
1154                                 let data_len = r.read_to_end(&mut data)?;
1155                                 sz = cmp::min(data_len, sz);
1156                                 match String::from_utf8(data[..sz as usize].to_vec()) {
1157                                         Ok(s) => s,
1158                                         Err(_) => return Err(DecodeError::InvalidValue),
1159                                 }
1160                         }
1161                 })
1162         }
1163 }
1164
1165 impl Writeable for UnsignedNodeAnnouncement {
1166         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1167                 w.size_hint(64 + 76 + self.features.byte_count() + self.addresses.len()*38 + self.excess_address_data.len() + self.excess_data.len());
1168                 self.features.write(w)?;
1169                 self.timestamp.write(w)?;
1170                 self.node_id.write(w)?;
1171                 w.write_all(&self.rgb)?;
1172                 self.alias.write(w)?;
1173
1174                 let mut addrs_to_encode = self.addresses.clone();
1175                 addrs_to_encode.sort_unstable_by(|a, b| { a.get_id().cmp(&b.get_id()) });
1176                 addrs_to_encode.dedup_by(|a, b| { a.get_id() == b.get_id() });
1177                 let mut addr_len = 0;
1178                 for addr in &addrs_to_encode {
1179                         addr_len += 1 + addr.len();
1180                 }
1181                 (addr_len + self.excess_address_data.len() as u16).write(w)?;
1182                 for addr in addrs_to_encode {
1183                         addr.write(w)?;
1184                 }
1185                 w.write_all(&self.excess_address_data[..])?;
1186                 w.write_all(&self.excess_data[..])?;
1187                 Ok(())
1188         }
1189 }
1190
1191 impl<R: Read> Readable<R> for UnsignedNodeAnnouncement {
1192         fn read(r: &mut R) -> Result<Self, DecodeError> {
1193                 let features: NodeFeatures = Readable::read(r)?;
1194                 let timestamp: u32 = Readable::read(r)?;
1195                 let node_id: PublicKey = Readable::read(r)?;
1196                 let mut rgb = [0; 3];
1197                 r.read_exact(&mut rgb)?;
1198                 let alias: [u8; 32] = Readable::read(r)?;
1199
1200                 let addr_len: u16 = Readable::read(r)?;
1201                 let mut addresses: Vec<NetAddress> = Vec::with_capacity(4);
1202                 let mut addr_readpos = 0;
1203                 let mut excess = false;
1204                 let mut excess_byte = 0;
1205                 loop {
1206                         if addr_len <= addr_readpos { break; }
1207                         match Readable::read(r) {
1208                                 Ok(Ok(addr)) => {
1209                                         match addr {
1210                                                 NetAddress::IPv4 { .. } => {
1211                                                         if addresses.len() > 0 {
1212                                                                 return Err(DecodeError::ExtraAddressesPerType);
1213                                                         }
1214                                                 },
1215                                                 NetAddress::IPv6 { .. } => {
1216                                                         if addresses.len() > 1 || (addresses.len() == 1 && addresses[0].get_id() != 1) {
1217                                                                 return Err(DecodeError::ExtraAddressesPerType);
1218                                                         }
1219                                                 },
1220                                                 NetAddress::OnionV2 { .. } => {
1221                                                         if addresses.len() > 2 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 2) {
1222                                                                 return Err(DecodeError::ExtraAddressesPerType);
1223                                                         }
1224                                                 },
1225                                                 NetAddress::OnionV3 { .. } => {
1226                                                         if addresses.len() > 3 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 3) {
1227                                                                 return Err(DecodeError::ExtraAddressesPerType);
1228                                                         }
1229                                                 },
1230                                         }
1231                                         if addr_len < addr_readpos + 1 + addr.len() {
1232                                                 return Err(DecodeError::BadLengthDescriptor);
1233                                         }
1234                                         addr_readpos += (1 + addr.len()) as u16;
1235                                         addresses.push(addr);
1236                                 },
1237                                 Ok(Err(unknown_descriptor)) => {
1238                                         excess = true;
1239                                         excess_byte = unknown_descriptor;
1240                                         break;
1241                                 },
1242                                 Err(DecodeError::ShortRead) => return Err(DecodeError::BadLengthDescriptor),
1243                                 Err(e) => return Err(e),
1244                         }
1245                 }
1246
1247                 let mut excess_data = vec![];
1248                 let excess_address_data = if addr_readpos < addr_len {
1249                         let mut excess_address_data = vec![0; (addr_len - addr_readpos) as usize];
1250                         r.read_exact(&mut excess_address_data[if excess { 1 } else { 0 }..])?;
1251                         if excess {
1252                                 excess_address_data[0] = excess_byte;
1253                         }
1254                         excess_address_data
1255                 } else {
1256                         if excess {
1257                                 excess_data.push(excess_byte);
1258                         }
1259                         Vec::new()
1260                 };
1261                 r.read_to_end(&mut excess_data)?;
1262                 Ok(UnsignedNodeAnnouncement {
1263                         features,
1264                         timestamp,
1265                         node_id,
1266                         rgb,
1267                         alias,
1268                         addresses,
1269                         excess_address_data,
1270                         excess_data,
1271                 })
1272         }
1273 }
1274
1275 impl_writeable_len_match!(NodeAnnouncement, {
1276                 { NodeAnnouncement { contents: UnsignedNodeAnnouncement { ref features, ref addresses, ref excess_address_data, ref excess_data, ..}, .. },
1277                         64 + 76 + features.byte_count() + addresses.len()*38 + excess_address_data.len() + excess_data.len() }
1278         }, {
1279         signature,
1280         contents
1281 });
1282
1283 #[cfg(test)]
1284 mod tests {
1285         use hex;
1286         use ln::msgs;
1287         use ln::msgs::{ChannelFeatures, InitFeatures, NodeFeatures, OptionalField, OnionErrorPacket};
1288         use ln::channelmanager::{PaymentPreimage, PaymentHash};
1289         use util::ser::Writeable;
1290
1291         use bitcoin_hashes::sha256d::Hash as Sha256dHash;
1292         use bitcoin_hashes::hex::FromHex;
1293         use bitcoin::util::address::Address;
1294         use bitcoin::network::constants::Network;
1295         use bitcoin::blockdata::script::Builder;
1296         use bitcoin::blockdata::opcodes;
1297
1298         use secp256k1::key::{PublicKey,SecretKey};
1299         use secp256k1::{Secp256k1, Message};
1300
1301         #[test]
1302         fn encoding_channel_reestablish_no_secret() {
1303                 let cr = msgs::ChannelReestablish {
1304                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1305                         next_local_commitment_number: 3,
1306                         next_remote_commitment_number: 4,
1307                         data_loss_protect: OptionalField::Absent,
1308                 };
1309
1310                 let encoded_value = cr.encode();
1311                 assert_eq!(
1312                         encoded_value,
1313                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4]
1314                 );
1315         }
1316
1317         #[test]
1318         fn encoding_channel_reestablish_with_secret() {
1319                 let public_key = {
1320                         let secp_ctx = Secp256k1::new();
1321                         PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()[..]).unwrap())
1322                 };
1323
1324                 let cr = msgs::ChannelReestablish {
1325                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1326                         next_local_commitment_number: 3,
1327                         next_remote_commitment_number: 4,
1328                         data_loss_protect: OptionalField::Present(msgs::DataLossProtect { your_last_per_commitment_secret: [9;32], my_current_per_commitment_point: public_key}),
1329                 };
1330
1331                 let encoded_value = cr.encode();
1332                 assert_eq!(
1333                         encoded_value,
1334                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 3, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5, 101, 215, 30, 24, 52, 96, 72, 25, 255, 156, 23, 245, 233, 213, 221, 7, 143]
1335                 );
1336         }
1337
1338         macro_rules! get_keys_from {
1339                 ($slice: expr, $secp_ctx: expr) => {
1340                         {
1341                                 let privkey = SecretKey::from_slice(&hex::decode($slice).unwrap()[..]).unwrap();
1342                                 let pubkey = PublicKey::from_secret_key(&$secp_ctx, &privkey);
1343                                 (privkey, pubkey)
1344                         }
1345                 }
1346         }
1347
1348         macro_rules! get_sig_on {
1349                 ($privkey: expr, $ctx: expr, $string: expr) => {
1350                         {
1351                                 let sighash = Message::from_slice(&$string.into_bytes()[..]).unwrap();
1352                                 $ctx.sign(&sighash, &$privkey)
1353                         }
1354                 }
1355         }
1356
1357         #[test]
1358         fn encoding_announcement_signatures() {
1359                 let secp_ctx = Secp256k1::new();
1360                 let (privkey, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1361                 let sig_1 = get_sig_on!(privkey, secp_ctx, String::from("01010101010101010101010101010101"));
1362                 let sig_2 = get_sig_on!(privkey, secp_ctx, String::from("02020202020202020202020202020202"));
1363                 let announcement_signatures = msgs::AnnouncementSignatures {
1364                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1365                         short_channel_id: 2316138423780173,
1366                         node_signature: sig_1,
1367                         bitcoin_signature: sig_2,
1368                 };
1369
1370                 let encoded_value = announcement_signatures.encode();
1371                 assert_eq!(encoded_value, hex::decode("040000000000000005000000000000000600000000000000070000000000000000083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073acf9953cef4700860f5967838eba2bae89288ad188ebf8b20bf995c3ea53a26df1876d0a3a0e13172ba286a673140190c02ba9da60a2e43a745188c8a83c7f3ef").unwrap());
1372         }
1373
1374         fn do_encoding_channel_announcement(unknown_features_bits: bool, non_bitcoin_chain_hash: bool, excess_data: bool) {
1375                 let secp_ctx = Secp256k1::new();
1376                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1377                 let (privkey_2, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1378                 let (privkey_3, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1379                 let (privkey_4, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1380                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1381                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1382                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1383                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1384                 let mut features = ChannelFeatures::supported();
1385                 if unknown_features_bits {
1386                         features = ChannelFeatures::from_le_bytes(vec![0xFF, 0xFF]);
1387                 }
1388                 let unsigned_channel_announcement = msgs::UnsignedChannelAnnouncement {
1389                         features,
1390                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1391                         short_channel_id: 2316138423780173,
1392                         node_id_1: pubkey_1,
1393                         node_id_2: pubkey_2,
1394                         bitcoin_key_1: pubkey_3,
1395                         bitcoin_key_2: pubkey_4,
1396                         excess_data: if excess_data { vec![10, 0, 0, 20, 0, 0, 30, 0, 0, 40] } else { Vec::new() },
1397                 };
1398                 let channel_announcement = msgs::ChannelAnnouncement {
1399                         node_signature_1: sig_1,
1400                         node_signature_2: sig_2,
1401                         bitcoin_signature_1: sig_3,
1402                         bitcoin_signature_2: sig_4,
1403                         contents: unsigned_channel_announcement,
1404                 };
1405                 let encoded_value = channel_announcement.encode();
1406                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a1735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap();
1407                 if unknown_features_bits {
1408                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1409                 } else {
1410                         target_value.append(&mut hex::decode("0000").unwrap());
1411                 }
1412                 if non_bitcoin_chain_hash {
1413                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1414                 } else {
1415                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1416                 }
1417                 target_value.append(&mut hex::decode("00083a840000034d031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b").unwrap());
1418                 if excess_data {
1419                         target_value.append(&mut hex::decode("0a00001400001e000028").unwrap());
1420                 }
1421                 assert_eq!(encoded_value, target_value);
1422         }
1423
1424         #[test]
1425         fn encoding_channel_announcement() {
1426                 do_encoding_channel_announcement(false, false, false);
1427                 do_encoding_channel_announcement(true, false, false);
1428                 do_encoding_channel_announcement(true, true, false);
1429                 do_encoding_channel_announcement(true, true, true);
1430                 do_encoding_channel_announcement(false, true, true);
1431                 do_encoding_channel_announcement(false, false, true);
1432                 do_encoding_channel_announcement(false, true, false);
1433                 do_encoding_channel_announcement(true, false, true);
1434         }
1435
1436         fn do_encoding_node_announcement(unknown_features_bits: bool, ipv4: bool, ipv6: bool, onionv2: bool, onionv3: bool, excess_address_data: bool, excess_data: bool) {
1437                 let secp_ctx = Secp256k1::new();
1438                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1439                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1440                 let features = if unknown_features_bits {
1441                         NodeFeatures::from_le_bytes(vec![0xFF, 0xFF])
1442                 } else {
1443                         // Set to some features we may support
1444                         NodeFeatures::from_le_bytes(vec![2 | 1 << 5])
1445                 };
1446                 let mut addresses = Vec::new();
1447                 if ipv4 {
1448                         addresses.push(msgs::NetAddress::IPv4 {
1449                                 addr: [255, 254, 253, 252],
1450                                 port: 9735
1451                         });
1452                 }
1453                 if ipv6 {
1454                         addresses.push(msgs::NetAddress::IPv6 {
1455                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240],
1456                                 port: 9735
1457                         });
1458                 }
1459                 if onionv2 {
1460                         addresses.push(msgs::NetAddress::OnionV2 {
1461                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246],
1462                                 port: 9735
1463                         });
1464                 }
1465                 if onionv3 {
1466                         addresses.push(msgs::NetAddress::OnionV3 {
1467                                 ed25519_pubkey: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240, 239, 238, 237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224],
1468                                 checksum: 32,
1469                                 version: 16,
1470                                 port: 9735
1471                         });
1472                 }
1473                 let mut addr_len = 0;
1474                 for addr in &addresses {
1475                         addr_len += addr.len() + 1;
1476                 }
1477                 let unsigned_node_announcement = msgs::UnsignedNodeAnnouncement {
1478                         features,
1479                         timestamp: 20190119,
1480                         node_id: pubkey_1,
1481                         rgb: [32; 3],
1482                         alias: [16;32],
1483                         addresses,
1484                         excess_address_data: if excess_address_data { vec![33, 108, 40, 11, 83, 149, 162, 84, 110, 126, 75, 38, 99, 224, 79, 129, 22, 34, 241, 90, 79, 146, 232, 58, 162, 233, 43, 162, 165, 115, 193, 57, 20, 44, 84, 174, 99, 7, 42, 30, 193, 238, 125, 192, 192, 75, 222, 92, 132, 120, 6, 23, 42, 160, 92, 146, 194, 42, 232, 227, 8, 209, 210, 105] } else { Vec::new() },
1485                         excess_data: if excess_data { vec![59, 18, 204, 25, 92, 224, 162, 209, 189, 166, 168, 139, 239, 161, 159, 160, 127, 81, 202, 167, 92, 232, 56, 55, 242, 137, 101, 96, 11, 138, 172, 171, 8, 85, 255, 176, 231, 65, 236, 95, 124, 65, 66, 30, 152, 41, 169, 212, 134, 17, 200, 200, 49, 247, 27, 229, 234, 115, 230, 101, 148, 151, 127, 253] } else { Vec::new() },
1486                 };
1487                 addr_len += unsigned_node_announcement.excess_address_data.len() as u16;
1488                 let node_announcement = msgs::NodeAnnouncement {
1489                         signature: sig_1,
1490                         contents: unsigned_node_announcement,
1491                 };
1492                 let encoded_value = node_announcement.encode();
1493                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1494                 if unknown_features_bits {
1495                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1496                 } else {
1497                         target_value.append(&mut hex::decode("000122").unwrap());
1498                 }
1499                 target_value.append(&mut hex::decode("013413a7031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f2020201010101010101010101010101010101010101010101010101010101010101010").unwrap());
1500                 target_value.append(&mut vec![(addr_len >> 8) as u8, addr_len as u8]);
1501                 if ipv4 {
1502                         target_value.append(&mut hex::decode("01fffefdfc2607").unwrap());
1503                 }
1504                 if ipv6 {
1505                         target_value.append(&mut hex::decode("02fffefdfcfbfaf9f8f7f6f5f4f3f2f1f02607").unwrap());
1506                 }
1507                 if onionv2 {
1508                         target_value.append(&mut hex::decode("03fffefdfcfbfaf9f8f7f62607").unwrap());
1509                 }
1510                 if onionv3 {
1511                         target_value.append(&mut hex::decode("04fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e00020102607").unwrap());
1512                 }
1513                 if excess_address_data {
1514                         target_value.append(&mut hex::decode("216c280b5395a2546e7e4b2663e04f811622f15a4f92e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d269").unwrap());
1515                 }
1516                 if excess_data {
1517                         target_value.append(&mut hex::decode("3b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1518                 }
1519                 assert_eq!(encoded_value, target_value);
1520         }
1521
1522         #[test]
1523         fn encoding_node_announcement() {
1524                 do_encoding_node_announcement(true, true, true, true, true, true, true);
1525                 do_encoding_node_announcement(false, false, false, false, false, false, false);
1526                 do_encoding_node_announcement(false, true, false, false, false, false, false);
1527                 do_encoding_node_announcement(false, false, true, false, false, false, false);
1528                 do_encoding_node_announcement(false, false, false, true, false, false, false);
1529                 do_encoding_node_announcement(false, false, false, false, true, false, false);
1530                 do_encoding_node_announcement(false, false, false, false, false, true, false);
1531                 do_encoding_node_announcement(false, true, false, true, false, true, false);
1532                 do_encoding_node_announcement(false, false, true, false, true, false, false);
1533         }
1534
1535         fn do_encoding_channel_update(non_bitcoin_chain_hash: bool, direction: bool, disable: bool, htlc_maximum_msat: bool) {
1536                 let secp_ctx = Secp256k1::new();
1537                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1538                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1539                 let unsigned_channel_update = msgs::UnsignedChannelUpdate {
1540                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1541                         short_channel_id: 2316138423780173,
1542                         timestamp: 20190119,
1543                         flags: if direction { 1 } else { 0 } | if disable { 1 << 1 } else { 0 } | if htlc_maximum_msat { 1 << 8 } else { 0 },
1544                         cltv_expiry_delta: 144,
1545                         htlc_minimum_msat: 1000000,
1546                         fee_base_msat: 10000,
1547                         fee_proportional_millionths: 20,
1548                         excess_data: if htlc_maximum_msat { vec![0, 0, 0, 0, 59, 154, 202, 0] } else { Vec::new() }
1549                 };
1550                 let channel_update = msgs::ChannelUpdate {
1551                         signature: sig_1,
1552                         contents: unsigned_channel_update
1553                 };
1554                 let encoded_value = channel_update.encode();
1555                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1556                 if non_bitcoin_chain_hash {
1557                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1558                 } else {
1559                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1560                 }
1561                 target_value.append(&mut hex::decode("00083a840000034d013413a7").unwrap());
1562                 if htlc_maximum_msat {
1563                         target_value.append(&mut hex::decode("01").unwrap());
1564                 } else {
1565                         target_value.append(&mut hex::decode("00").unwrap());
1566                 }
1567                 target_value.append(&mut hex::decode("00").unwrap());
1568                 if direction {
1569                         let flag = target_value.last_mut().unwrap();
1570                         *flag = 1;
1571                 }
1572                 if disable {
1573                         let flag = target_value.last_mut().unwrap();
1574                         *flag = *flag | 1 << 1;
1575                 }
1576                 target_value.append(&mut hex::decode("009000000000000f42400000271000000014").unwrap());
1577                 if htlc_maximum_msat {
1578                         target_value.append(&mut hex::decode("000000003b9aca00").unwrap());
1579                 }
1580                 assert_eq!(encoded_value, target_value);
1581         }
1582
1583         #[test]
1584         fn encoding_channel_update() {
1585                 do_encoding_channel_update(false, false, false, false);
1586                 do_encoding_channel_update(true, false, false, false);
1587                 do_encoding_channel_update(false, true, false, false);
1588                 do_encoding_channel_update(false, false, true, false);
1589                 do_encoding_channel_update(false, false, false, true);
1590                 do_encoding_channel_update(true, true, true, true);
1591         }
1592
1593         fn do_encoding_open_channel(non_bitcoin_chain_hash: bool, random_bit: bool, shutdown: bool) {
1594                 let secp_ctx = Secp256k1::new();
1595                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1596                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1597                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1598                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1599                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1600                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1601                 let open_channel = msgs::OpenChannel {
1602                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1603                         temporary_channel_id: [2; 32],
1604                         funding_satoshis: 1311768467284833366,
1605                         push_msat: 2536655962884945560,
1606                         dust_limit_satoshis: 3608586615801332854,
1607                         max_htlc_value_in_flight_msat: 8517154655701053848,
1608                         channel_reserve_satoshis: 8665828695742877976,
1609                         htlc_minimum_msat: 2316138423780173,
1610                         feerate_per_kw: 821716,
1611                         to_self_delay: 49340,
1612                         max_accepted_htlcs: 49340,
1613                         funding_pubkey: pubkey_1,
1614                         revocation_basepoint: pubkey_2,
1615                         payment_basepoint: pubkey_3,
1616                         delayed_payment_basepoint: pubkey_4,
1617                         htlc_basepoint: pubkey_5,
1618                         first_per_commitment_point: pubkey_6,
1619                         channel_flags: if random_bit { 1 << 5 } else { 0 },
1620                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1621                 };
1622                 let encoded_value = open_channel.encode();
1623                 let mut target_value = Vec::new();
1624                 if non_bitcoin_chain_hash {
1625                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1626                 } else {
1627                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1628                 }
1629                 target_value.append(&mut hex::decode("02020202020202020202020202020202020202020202020202020202020202021234567890123456233403289122369832144668701144767633030896203198784335490624111800083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap());
1630                 if random_bit {
1631                         target_value.append(&mut hex::decode("20").unwrap());
1632                 } else {
1633                         target_value.append(&mut hex::decode("00").unwrap());
1634                 }
1635                 if shutdown {
1636                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1637                 }
1638                 assert_eq!(encoded_value, target_value);
1639         }
1640
1641         #[test]
1642         fn encoding_open_channel() {
1643                 do_encoding_open_channel(false, false, false);
1644                 do_encoding_open_channel(true, false, false);
1645                 do_encoding_open_channel(false, true, false);
1646                 do_encoding_open_channel(false, false, true);
1647                 do_encoding_open_channel(true, true, true);
1648         }
1649
1650         fn do_encoding_accept_channel(shutdown: bool) {
1651                 let secp_ctx = Secp256k1::new();
1652                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1653                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1654                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1655                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1656                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1657                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1658                 let accept_channel = msgs::AcceptChannel {
1659                         temporary_channel_id: [2; 32],
1660                         dust_limit_satoshis: 1311768467284833366,
1661                         max_htlc_value_in_flight_msat: 2536655962884945560,
1662                         channel_reserve_satoshis: 3608586615801332854,
1663                         htlc_minimum_msat: 2316138423780173,
1664                         minimum_depth: 821716,
1665                         to_self_delay: 49340,
1666                         max_accepted_htlcs: 49340,
1667                         funding_pubkey: pubkey_1,
1668                         revocation_basepoint: pubkey_2,
1669                         payment_basepoint: pubkey_3,
1670                         delayed_payment_basepoint: pubkey_4,
1671                         htlc_basepoint: pubkey_5,
1672                         first_per_commitment_point: pubkey_6,
1673                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1674                 };
1675                 let encoded_value = accept_channel.encode();
1676                 let mut target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020212345678901234562334032891223698321446687011447600083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap();
1677                 if shutdown {
1678                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1679                 }
1680                 assert_eq!(encoded_value, target_value);
1681         }
1682
1683         #[test]
1684         fn encoding_accept_channel() {
1685                 do_encoding_accept_channel(false);
1686                 do_encoding_accept_channel(true);
1687         }
1688
1689         #[test]
1690         fn encoding_funding_created() {
1691                 let secp_ctx = Secp256k1::new();
1692                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1693                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1694                 let funding_created = msgs::FundingCreated {
1695                         temporary_channel_id: [2; 32],
1696                         funding_txid: Sha256dHash::from_hex("c2d4449afa8d26140898dd54d3390b057ba2a5afcf03ba29d7dc0d8b9ffe966e").unwrap(),
1697                         funding_output_index: 255,
1698                         signature: sig_1,
1699                 };
1700                 let encoded_value = funding_created.encode();
1701                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202026e96fe9f8b0ddcd729ba03cfafa5a27b050b39d354dd980814268dfa9a44d4c200ffd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1702                 assert_eq!(encoded_value, target_value);
1703         }
1704
1705         #[test]
1706         fn encoding_funding_signed() {
1707                 let secp_ctx = Secp256k1::new();
1708                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1709                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1710                 let funding_signed = msgs::FundingSigned {
1711                         channel_id: [2; 32],
1712                         signature: sig_1,
1713                 };
1714                 let encoded_value = funding_signed.encode();
1715                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1716                 assert_eq!(encoded_value, target_value);
1717         }
1718
1719         #[test]
1720         fn encoding_funding_locked() {
1721                 let secp_ctx = Secp256k1::new();
1722                 let (_, pubkey_1,) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1723                 let funding_locked = msgs::FundingLocked {
1724                         channel_id: [2; 32],
1725                         next_per_commitment_point: pubkey_1,
1726                 };
1727                 let encoded_value = funding_locked.encode();
1728                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1729                 assert_eq!(encoded_value, target_value);
1730         }
1731
1732         fn do_encoding_shutdown(script_type: u8) {
1733                 let secp_ctx = Secp256k1::new();
1734                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1735                 let script = Builder::new().push_opcode(opcodes::OP_TRUE).into_script();
1736                 let shutdown = msgs::Shutdown {
1737                         channel_id: [2; 32],
1738                         scriptpubkey: if script_type == 1 { Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else if script_type == 2 { Address::p2sh(&script, Network::Testnet).script_pubkey() } else if script_type == 3 { Address::p2wpkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else { Address::p2wsh(&script, Network::Testnet).script_pubkey() },
1739                 };
1740                 let encoded_value = shutdown.encode();
1741                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap();
1742                 if script_type == 1 {
1743                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1744                 } else if script_type == 2 {
1745                         target_value.append(&mut hex::decode("0017a914da1745e9b549bd0bfa1a569971c77eba30cd5a4b87").unwrap());
1746                 } else if script_type == 3 {
1747                         target_value.append(&mut hex::decode("0016001479b000887626b294a914501a4cd226b58b235983").unwrap());
1748                 } else if script_type == 4 {
1749                         target_value.append(&mut hex::decode("002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc33260").unwrap());
1750                 }
1751                 assert_eq!(encoded_value, target_value);
1752         }
1753
1754         #[test]
1755         fn encoding_shutdown() {
1756                 do_encoding_shutdown(1);
1757                 do_encoding_shutdown(2);
1758                 do_encoding_shutdown(3);
1759                 do_encoding_shutdown(4);
1760         }
1761
1762         #[test]
1763         fn encoding_closing_signed() {
1764                 let secp_ctx = Secp256k1::new();
1765                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1766                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1767                 let closing_signed = msgs::ClosingSigned {
1768                         channel_id: [2; 32],
1769                         fee_satoshis: 2316138423780173,
1770                         signature: sig_1,
1771                 };
1772                 let encoded_value = closing_signed.encode();
1773                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1774                 assert_eq!(encoded_value, target_value);
1775         }
1776
1777         #[test]
1778         fn encoding_update_add_htlc() {
1779                 let secp_ctx = Secp256k1::new();
1780                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1781                 let onion_routing_packet = msgs::OnionPacket {
1782                         version: 255,
1783                         public_key: Ok(pubkey_1),
1784                         hop_data: [1; 20*65],
1785                         hmac: [2; 32]
1786                 };
1787                 let update_add_htlc = msgs::UpdateAddHTLC {
1788                         channel_id: [2; 32],
1789                         htlc_id: 2316138423780173,
1790                         amount_msat: 3608586615801332854,
1791                         payment_hash: PaymentHash([1; 32]),
1792                         cltv_expiry: 821716,
1793                         onion_routing_packet
1794                 };
1795                 let encoded_value = update_add_htlc.encode();
1796                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d32144668701144760101010101010101010101010101010101010101010101010101010101010101000c89d4ff031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010202020202020202020202020202020202020202020202020202020202020202").unwrap();
1797                 assert_eq!(encoded_value, target_value);
1798         }
1799
1800         #[test]
1801         fn encoding_update_fulfill_htlc() {
1802                 let update_fulfill_htlc = msgs::UpdateFulfillHTLC {
1803                         channel_id: [2; 32],
1804                         htlc_id: 2316138423780173,
1805                         payment_preimage: PaymentPreimage([1; 32]),
1806                 };
1807                 let encoded_value = update_fulfill_htlc.encode();
1808                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d0101010101010101010101010101010101010101010101010101010101010101").unwrap();
1809                 assert_eq!(encoded_value, target_value);
1810         }
1811
1812         #[test]
1813         fn encoding_update_fail_htlc() {
1814                 let reason = OnionErrorPacket {
1815                         data: [1; 32].to_vec(),
1816                 };
1817                 let update_fail_htlc = msgs::UpdateFailHTLC {
1818                         channel_id: [2; 32],
1819                         htlc_id: 2316138423780173,
1820                         reason
1821                 };
1822                 let encoded_value = update_fail_htlc.encode();
1823                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d00200101010101010101010101010101010101010101010101010101010101010101").unwrap();
1824                 assert_eq!(encoded_value, target_value);
1825         }
1826
1827         #[test]
1828         fn encoding_update_fail_malformed_htlc() {
1829                 let update_fail_malformed_htlc = msgs::UpdateFailMalformedHTLC {
1830                         channel_id: [2; 32],
1831                         htlc_id: 2316138423780173,
1832                         sha256_of_onion: [1; 32],
1833                         failure_code: 255
1834                 };
1835                 let encoded_value = update_fail_malformed_htlc.encode();
1836                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d010101010101010101010101010101010101010101010101010101010101010100ff").unwrap();
1837                 assert_eq!(encoded_value, target_value);
1838         }
1839
1840         fn do_encoding_commitment_signed(htlcs: bool) {
1841                 let secp_ctx = Secp256k1::new();
1842                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1843                 let (privkey_2, _) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1844                 let (privkey_3, _) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1845                 let (privkey_4, _) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1846                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1847                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1848                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1849                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1850                 let commitment_signed = msgs::CommitmentSigned {
1851                         channel_id: [2; 32],
1852                         signature: sig_1,
1853                         htlc_signatures: if htlcs { vec![sig_2, sig_3, sig_4] } else { Vec::new() },
1854                 };
1855                 let encoded_value = commitment_signed.encode();
1856                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1857                 if htlcs {
1858                         target_value.append(&mut hex::decode("00031735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1859                 } else {
1860                         target_value.append(&mut hex::decode("0000").unwrap());
1861                 }
1862                 assert_eq!(encoded_value, target_value);
1863         }
1864
1865         #[test]
1866         fn encoding_commitment_signed() {
1867                 do_encoding_commitment_signed(true);
1868                 do_encoding_commitment_signed(false);
1869         }
1870
1871         #[test]
1872         fn encoding_revoke_and_ack() {
1873                 let secp_ctx = Secp256k1::new();
1874                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1875                 let raa = msgs::RevokeAndACK {
1876                         channel_id: [2; 32],
1877                         per_commitment_secret: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
1878                         next_per_commitment_point: pubkey_1,
1879                 };
1880                 let encoded_value = raa.encode();
1881                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202020101010101010101010101010101010101010101010101010101010101010101031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1882                 assert_eq!(encoded_value, target_value);
1883         }
1884
1885         #[test]
1886         fn encoding_update_fee() {
1887                 let update_fee = msgs::UpdateFee {
1888                         channel_id: [2; 32],
1889                         feerate_per_kw: 20190119,
1890                 };
1891                 let encoded_value = update_fee.encode();
1892                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202013413a7").unwrap();
1893                 assert_eq!(encoded_value, target_value);
1894         }
1895
1896         #[test]
1897         fn encoding_init() {
1898                 assert_eq!(msgs::Init {
1899                         features: InitFeatures::from_le_bytes(vec![0xFF, 0xFF, 0xFF]),
1900                 }.encode(), hex::decode("00023fff0003ffffff").unwrap());
1901                 assert_eq!(msgs::Init {
1902                         features: InitFeatures::from_le_bytes(vec![0xFF]),
1903                 }.encode(), hex::decode("0001ff0001ff").unwrap());
1904                 assert_eq!(msgs::Init {
1905                         features: InitFeatures::from_le_bytes(vec![]),
1906                 }.encode(), hex::decode("00000000").unwrap());
1907         }
1908
1909         #[test]
1910         fn encoding_error() {
1911                 let error = msgs::ErrorMessage {
1912                         channel_id: [2; 32],
1913                         data: String::from("rust-lightning"),
1914                 };
1915                 let encoded_value = error.encode();
1916                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
1917                 assert_eq!(encoded_value, target_value);
1918         }
1919
1920         #[test]
1921         fn encoding_ping() {
1922                 let ping = msgs::Ping {
1923                         ponglen: 64,
1924                         byteslen: 64
1925                 };
1926                 let encoded_value = ping.encode();
1927                 let target_value = hex::decode("0040004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1928                 assert_eq!(encoded_value, target_value);
1929         }
1930
1931         #[test]
1932         fn encoding_pong() {
1933                 let pong = msgs::Pong {
1934                         byteslen: 64
1935                 };
1936                 let encoded_value = pong.encode();
1937                 let target_value = hex::decode("004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1938                 assert_eq!(encoded_value, target_value);
1939         }
1940 }