Move BogusHopData generation into test instead of OnionHopData.
[rust-lightning] / lightning / src / ln / msgs.rs
1 //! Wire messages, traits representing wire message handlers, and a few error types live here.
2 //!
3 //! For a normal node you probably don't need to use anything here, however, if you wish to split a
4 //! node into an internet-facing route/message socket handling daemon and a separate daemon (or
5 //! server entirely) which handles only channel-related messages you may wish to implement
6 //! ChannelMessageHandler yourself and use it to re-serialize messages and pass them across
7 //! daemons/servers.
8 //!
9 //! Note that if you go with such an architecture (instead of passing raw socket events to a
10 //! non-internet-facing system) you trust the frontend internet-facing system to not lie about the
11 //! source node_id of the message, however this does allow you to significantly reduce bandwidth
12 //! between the systems as routing messages can represent a significant chunk of bandwidth usage
13 //! (especially for non-channel-publicly-announcing nodes). As an alternate design which avoids
14 //! this issue, if you have sufficient bidirectional bandwidth between your systems, you may send
15 //! raw socket events into your non-internet-facing system and then send routing events back to
16 //! track the network on the less-secure system.
17
18 use secp256k1::key::PublicKey;
19 use secp256k1::Signature;
20 use secp256k1;
21 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
22 use bitcoin::blockdata::script::Script;
23
24 use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
25
26 use std::error::Error;
27 use std::{cmp, fmt};
28 use std::io::Read;
29 use std::result::Result;
30
31 use util::events;
32 use util::ser::{Readable, Writeable, Writer};
33
34 use ln::channelmanager::{PaymentPreimage, PaymentHash};
35
36 /// An error in decoding a message or struct.
37 #[derive(Debug)]
38 pub enum DecodeError {
39         /// A version byte specified something we don't know how to handle.
40         /// Includes unknown realm byte in an OnionHopData packet
41         UnknownVersion,
42         /// Unknown feature mandating we fail to parse message
43         UnknownRequiredFeature,
44         /// Value was invalid, eg a byte which was supposed to be a bool was something other than a 0
45         /// or 1, a public key/private key/signature was invalid, text wasn't UTF-8, etc
46         InvalidValue,
47         /// Buffer too short
48         ShortRead,
49         /// node_announcement included more than one address of a given type!
50         ExtraAddressesPerType,
51         /// A length descriptor in the packet didn't describe the later data correctly
52         BadLengthDescriptor,
53         /// Error from std::io
54         Io(::std::io::Error),
55 }
56
57 /// An init message to be sent or received from a peer
58 pub struct Init {
59         #[cfg(not(feature = "fuzztarget"))]
60         pub(crate) features: InitFeatures,
61         #[cfg(feature = "fuzztarget")]
62         pub features: InitFeatures,
63 }
64
65 /// An error message to be sent or received from a peer
66 #[derive(Clone)]
67 pub struct ErrorMessage {
68         pub(crate) channel_id: [u8; 32],
69         pub(crate) data: String,
70 }
71
72 /// A ping message to be sent or received from a peer
73 pub struct Ping {
74         pub(crate) ponglen: u16,
75         pub(crate) byteslen: u16,
76 }
77
78 /// A pong message to be sent or received from a peer
79 pub struct Pong {
80         pub(crate) byteslen: u16,
81 }
82
83 /// An open_channel message to be sent or received from a peer
84 #[derive(Clone)]
85 pub struct OpenChannel {
86         pub(crate) chain_hash: Sha256dHash,
87         pub(crate) temporary_channel_id: [u8; 32],
88         pub(crate) funding_satoshis: u64,
89         pub(crate) push_msat: u64,
90         pub(crate) dust_limit_satoshis: u64,
91         pub(crate) max_htlc_value_in_flight_msat: u64,
92         pub(crate) channel_reserve_satoshis: u64,
93         pub(crate) htlc_minimum_msat: u64,
94         pub(crate) feerate_per_kw: u32,
95         pub(crate) to_self_delay: u16,
96         pub(crate) max_accepted_htlcs: u16,
97         pub(crate) funding_pubkey: PublicKey,
98         pub(crate) revocation_basepoint: PublicKey,
99         pub(crate) payment_basepoint: PublicKey,
100         pub(crate) delayed_payment_basepoint: PublicKey,
101         pub(crate) htlc_basepoint: PublicKey,
102         pub(crate) first_per_commitment_point: PublicKey,
103         pub(crate) channel_flags: u8,
104         pub(crate) shutdown_scriptpubkey: OptionalField<Script>,
105 }
106
107 /// An accept_channel message to be sent or received from a peer
108 #[derive(Clone)]
109 pub struct AcceptChannel {
110         pub(crate) temporary_channel_id: [u8; 32],
111         pub(crate) dust_limit_satoshis: u64,
112         pub(crate) max_htlc_value_in_flight_msat: u64,
113         pub(crate) channel_reserve_satoshis: u64,
114         pub(crate) htlc_minimum_msat: u64,
115         pub(crate) minimum_depth: u32,
116         pub(crate) to_self_delay: u16,
117         pub(crate) max_accepted_htlcs: u16,
118         pub(crate) funding_pubkey: PublicKey,
119         pub(crate) revocation_basepoint: PublicKey,
120         pub(crate) payment_basepoint: PublicKey,
121         pub(crate) delayed_payment_basepoint: PublicKey,
122         pub(crate) htlc_basepoint: PublicKey,
123         pub(crate) first_per_commitment_point: PublicKey,
124         pub(crate) shutdown_scriptpubkey: OptionalField<Script>
125 }
126
127 /// A funding_created message to be sent or received from a peer
128 #[derive(Clone)]
129 pub struct FundingCreated {
130         pub(crate) temporary_channel_id: [u8; 32],
131         pub(crate) funding_txid: Sha256dHash,
132         pub(crate) funding_output_index: u16,
133         pub(crate) signature: Signature,
134 }
135
136 /// A funding_signed message to be sent or received from a peer
137 #[derive(Clone)]
138 pub struct FundingSigned {
139         pub(crate) channel_id: [u8; 32],
140         pub(crate) signature: Signature,
141 }
142
143 /// A funding_locked message to be sent or received from a peer
144 #[derive(Clone, PartialEq)]
145 #[allow(missing_docs)]
146 pub struct FundingLocked {
147         pub channel_id: [u8; 32],
148         pub next_per_commitment_point: PublicKey,
149 }
150
151 /// A shutdown message to be sent or received from a peer
152 #[derive(Clone, PartialEq)]
153 pub struct Shutdown {
154         pub(crate) channel_id: [u8; 32],
155         pub(crate) scriptpubkey: Script,
156 }
157
158 /// A closing_signed message to be sent or received from a peer
159 #[derive(Clone, PartialEq)]
160 pub struct ClosingSigned {
161         pub(crate) channel_id: [u8; 32],
162         pub(crate) fee_satoshis: u64,
163         pub(crate) signature: Signature,
164 }
165
166 /// An update_add_htlc message to be sent or received from a peer
167 #[derive(Clone, PartialEq)]
168 pub struct UpdateAddHTLC {
169         pub(crate) channel_id: [u8; 32],
170         pub(crate) htlc_id: u64,
171         pub(crate) amount_msat: u64,
172         pub(crate) payment_hash: PaymentHash,
173         pub(crate) cltv_expiry: u32,
174         pub(crate) onion_routing_packet: OnionPacket,
175 }
176
177 /// An update_fulfill_htlc message to be sent or received from a peer
178 #[derive(Clone, PartialEq)]
179 pub struct UpdateFulfillHTLC {
180         pub(crate) channel_id: [u8; 32],
181         pub(crate) htlc_id: u64,
182         pub(crate) payment_preimage: PaymentPreimage,
183 }
184
185 /// An update_fail_htlc message to be sent or received from a peer
186 #[derive(Clone, PartialEq)]
187 pub struct UpdateFailHTLC {
188         pub(crate) channel_id: [u8; 32],
189         pub(crate) htlc_id: u64,
190         pub(crate) reason: OnionErrorPacket,
191 }
192
193 /// An update_fail_malformed_htlc message to be sent or received from a peer
194 #[derive(Clone, PartialEq)]
195 pub struct UpdateFailMalformedHTLC {
196         pub(crate) channel_id: [u8; 32],
197         pub(crate) htlc_id: u64,
198         pub(crate) sha256_of_onion: [u8; 32],
199         pub(crate) failure_code: u16,
200 }
201
202 /// A commitment_signed message to be sent or received from a peer
203 #[derive(Clone, PartialEq)]
204 pub struct CommitmentSigned {
205         pub(crate) channel_id: [u8; 32],
206         pub(crate) signature: Signature,
207         pub(crate) htlc_signatures: Vec<Signature>,
208 }
209
210 /// A revoke_and_ack message to be sent or received from a peer
211 #[derive(Clone, PartialEq)]
212 pub struct RevokeAndACK {
213         pub(crate) channel_id: [u8; 32],
214         pub(crate) per_commitment_secret: [u8; 32],
215         pub(crate) next_per_commitment_point: PublicKey,
216 }
217
218 /// An update_fee message to be sent or received from a peer
219 #[derive(PartialEq, Clone)]
220 pub struct UpdateFee {
221         pub(crate) channel_id: [u8; 32],
222         pub(crate) feerate_per_kw: u32,
223 }
224
225 #[derive(PartialEq, Clone)]
226 pub(crate) struct DataLossProtect {
227         pub(crate) your_last_per_commitment_secret: [u8; 32],
228         pub(crate) my_current_per_commitment_point: PublicKey,
229 }
230
231 /// A channel_reestablish message to be sent or received from a peer
232 #[derive(PartialEq, Clone)]
233 pub struct ChannelReestablish {
234         pub(crate) channel_id: [u8; 32],
235         pub(crate) next_local_commitment_number: u64,
236         pub(crate) next_remote_commitment_number: u64,
237         pub(crate) data_loss_protect: OptionalField<DataLossProtect>,
238 }
239
240 /// An announcement_signatures message to be sent or received from a peer
241 #[derive(PartialEq, Clone, Debug)]
242 pub struct AnnouncementSignatures {
243         pub(crate) channel_id: [u8; 32],
244         pub(crate) short_channel_id: u64,
245         pub(crate) node_signature: Signature,
246         pub(crate) bitcoin_signature: Signature,
247 }
248
249 /// An address which can be used to connect to a remote peer
250 #[derive(Clone, PartialEq, Debug)]
251 pub enum NetAddress {
252         /// An IPv4 address/port on which the peer is listening.
253         IPv4 {
254                 /// The 4-byte IPv4 address
255                 addr: [u8; 4],
256                 /// The port on which the node is listening
257                 port: u16,
258         },
259         /// An IPv6 address/port on which the peer is listening.
260         IPv6 {
261                 /// The 16-byte IPv6 address
262                 addr: [u8; 16],
263                 /// The port on which the node is listening
264                 port: u16,
265         },
266         /// An old-style Tor onion address/port on which the peer is listening.
267         OnionV2 {
268                 /// The bytes (usually encoded in base32 with ".onion" appended)
269                 addr: [u8; 10],
270                 /// The port on which the node is listening
271                 port: u16,
272         },
273         /// A new-style Tor onion address/port on which the peer is listening.
274         /// To create the human-readable "hostname", concatenate ed25519_pubkey, checksum, and version,
275         /// wrap as base32 and append ".onion".
276         OnionV3 {
277                 /// The ed25519 long-term public key of the peer
278                 ed25519_pubkey: [u8; 32],
279                 /// The checksum of the pubkey and version, as included in the onion address
280                 checksum: u16,
281                 /// The version byte, as defined by the Tor Onion v3 spec.
282                 version: u8,
283                 /// The port on which the node is listening
284                 port: u16,
285         },
286 }
287 impl NetAddress {
288         fn get_id(&self) -> u8 {
289                 match self {
290                         &NetAddress::IPv4 {..} => { 1 },
291                         &NetAddress::IPv6 {..} => { 2 },
292                         &NetAddress::OnionV2 {..} => { 3 },
293                         &NetAddress::OnionV3 {..} => { 4 },
294                 }
295         }
296
297         /// Strict byte-length of address descriptor, 1-byte type not recorded
298         fn len(&self) -> u16 {
299                 match self {
300                         &NetAddress::IPv4 { .. } => { 6 },
301                         &NetAddress::IPv6 { .. } => { 18 },
302                         &NetAddress::OnionV2 { .. } => { 12 },
303                         &NetAddress::OnionV3 { .. } => { 37 },
304                 }
305         }
306 }
307
308 impl Writeable for NetAddress {
309         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
310                 match self {
311                         &NetAddress::IPv4 { ref addr, ref port } => {
312                                 1u8.write(writer)?;
313                                 addr.write(writer)?;
314                                 port.write(writer)?;
315                         },
316                         &NetAddress::IPv6 { ref addr, ref port } => {
317                                 2u8.write(writer)?;
318                                 addr.write(writer)?;
319                                 port.write(writer)?;
320                         },
321                         &NetAddress::OnionV2 { ref addr, ref port } => {
322                                 3u8.write(writer)?;
323                                 addr.write(writer)?;
324                                 port.write(writer)?;
325                         },
326                         &NetAddress::OnionV3 { ref ed25519_pubkey, ref checksum, ref version, ref port } => {
327                                 4u8.write(writer)?;
328                                 ed25519_pubkey.write(writer)?;
329                                 checksum.write(writer)?;
330                                 version.write(writer)?;
331                                 port.write(writer)?;
332                         }
333                 }
334                 Ok(())
335         }
336 }
337
338 impl<R: ::std::io::Read>  Readable<R> for Result<NetAddress, u8> {
339         fn read(reader: &mut R) -> Result<Result<NetAddress, u8>, DecodeError> {
340                 let byte = <u8 as Readable<R>>::read(reader)?;
341                 match byte {
342                         1 => {
343                                 Ok(Ok(NetAddress::IPv4 {
344                                         addr: Readable::read(reader)?,
345                                         port: Readable::read(reader)?,
346                                 }))
347                         },
348                         2 => {
349                                 Ok(Ok(NetAddress::IPv6 {
350                                         addr: Readable::read(reader)?,
351                                         port: Readable::read(reader)?,
352                                 }))
353                         },
354                         3 => {
355                                 Ok(Ok(NetAddress::OnionV2 {
356                                         addr: Readable::read(reader)?,
357                                         port: Readable::read(reader)?,
358                                 }))
359                         },
360                         4 => {
361                                 Ok(Ok(NetAddress::OnionV3 {
362                                         ed25519_pubkey: Readable::read(reader)?,
363                                         checksum: Readable::read(reader)?,
364                                         version: Readable::read(reader)?,
365                                         port: Readable::read(reader)?,
366                                 }))
367                         },
368                         _ => return Ok(Err(byte)),
369                 }
370         }
371 }
372
373 // Only exposed as broadcast of node_announcement should be filtered by node_id
374 /// The unsigned part of a node_announcement
375 #[derive(PartialEq, Clone, Debug)]
376 pub struct UnsignedNodeAnnouncement {
377         pub(crate) features: NodeFeatures,
378         pub(crate) timestamp: u32,
379         /// The node_id this announcement originated from (don't rebroadcast the node_announcement back
380         /// to this node).
381         pub        node_id: PublicKey,
382         pub(crate) rgb: [u8; 3],
383         pub(crate) alias: [u8; 32],
384         /// List of addresses on which this node is reachable. Note that you may only have up to one
385         /// address of each type, if you have more, they may be silently discarded or we may panic!
386         pub(crate) addresses: Vec<NetAddress>,
387         pub(crate) excess_address_data: Vec<u8>,
388         pub(crate) excess_data: Vec<u8>,
389 }
390 #[derive(PartialEq, Clone)]
391 /// A node_announcement message to be sent or received from a peer
392 pub struct NodeAnnouncement {
393         pub(crate) signature: Signature,
394         pub(crate) contents: UnsignedNodeAnnouncement,
395 }
396
397 // Only exposed as broadcast of channel_announcement should be filtered by node_id
398 /// The unsigned part of a channel_announcement
399 #[derive(PartialEq, Clone, Debug)]
400 pub struct UnsignedChannelAnnouncement {
401         pub(crate) features: ChannelFeatures,
402         pub(crate) chain_hash: Sha256dHash,
403         pub(crate) short_channel_id: u64,
404         /// One of the two node_ids which are endpoints of this channel
405         pub        node_id_1: PublicKey,
406         /// The other of the two node_ids which are endpoints of this channel
407         pub        node_id_2: PublicKey,
408         pub(crate) bitcoin_key_1: PublicKey,
409         pub(crate) bitcoin_key_2: PublicKey,
410         pub(crate) excess_data: Vec<u8>,
411 }
412 /// A channel_announcement message to be sent or received from a peer
413 #[derive(PartialEq, Clone, Debug)]
414 pub struct ChannelAnnouncement {
415         pub(crate) node_signature_1: Signature,
416         pub(crate) node_signature_2: Signature,
417         pub(crate) bitcoin_signature_1: Signature,
418         pub(crate) bitcoin_signature_2: Signature,
419         pub(crate) contents: UnsignedChannelAnnouncement,
420 }
421
422 #[derive(PartialEq, Clone, Debug)]
423 pub(crate) struct UnsignedChannelUpdate {
424         pub(crate) chain_hash: Sha256dHash,
425         pub(crate) short_channel_id: u64,
426         pub(crate) timestamp: u32,
427         pub(crate) flags: u16,
428         pub(crate) cltv_expiry_delta: u16,
429         pub(crate) htlc_minimum_msat: u64,
430         pub(crate) fee_base_msat: u32,
431         pub(crate) fee_proportional_millionths: u32,
432         pub(crate) excess_data: Vec<u8>,
433 }
434 /// A channel_update message to be sent or received from a peer
435 #[derive(PartialEq, Clone, Debug)]
436 pub struct ChannelUpdate {
437         pub(crate) signature: Signature,
438         pub(crate) contents: UnsignedChannelUpdate,
439 }
440
441 /// Used to put an error message in a LightningError
442 #[derive(Clone)]
443 pub enum ErrorAction {
444         /// The peer took some action which made us think they were useless. Disconnect them.
445         DisconnectPeer {
446                 /// An error message which we should make an effort to send before we disconnect.
447                 msg: Option<ErrorMessage>
448         },
449         /// The peer did something harmless that we weren't able to process, just log and ignore
450         IgnoreError,
451         /// The peer did something incorrect. Tell them.
452         SendErrorMessage {
453                 /// The message to send.
454                 msg: ErrorMessage
455         },
456 }
457
458 /// An Err type for failure to process messages.
459 pub struct LightningError {
460         /// A human-readable message describing the error
461         pub err: &'static str,
462         /// The action which should be taken against the offending peer.
463         pub action: ErrorAction,
464 }
465
466 /// Struct used to return values from revoke_and_ack messages, containing a bunch of commitment
467 /// transaction updates if they were pending.
468 #[derive(PartialEq, Clone)]
469 pub struct CommitmentUpdate {
470         /// update_add_htlc messages which should be sent
471         pub update_add_htlcs: Vec<UpdateAddHTLC>,
472         /// update_fulfill_htlc messages which should be sent
473         pub update_fulfill_htlcs: Vec<UpdateFulfillHTLC>,
474         /// update_fail_htlc messages which should be sent
475         pub update_fail_htlcs: Vec<UpdateFailHTLC>,
476         /// update_fail_malformed_htlc messages which should be sent
477         pub update_fail_malformed_htlcs: Vec<UpdateFailMalformedHTLC>,
478         /// An update_fee message which should be sent
479         pub update_fee: Option<UpdateFee>,
480         /// Finally, the commitment_signed message which should be sent
481         pub commitment_signed: CommitmentSigned,
482 }
483
484 /// The information we received from a peer along the route of a payment we originated. This is
485 /// returned by ChannelMessageHandler::handle_update_fail_htlc to be passed into
486 /// RoutingMessageHandler::handle_htlc_fail_channel_update to update our network map.
487 #[derive(Clone)]
488 pub enum HTLCFailChannelUpdate {
489         /// We received an error which included a full ChannelUpdate message.
490         ChannelUpdateMessage {
491                 /// The unwrapped message we received
492                 msg: ChannelUpdate,
493         },
494         /// We received an error which indicated only that a channel has been closed
495         ChannelClosed {
496                 /// The short_channel_id which has now closed.
497                 short_channel_id: u64,
498                 /// when this true, this channel should be permanently removed from the
499                 /// consideration. Otherwise, this channel can be restored as new channel_update is received
500                 is_permanent: bool,
501         },
502         /// We received an error which indicated only that a node has failed
503         NodeFailure {
504                 /// The node_id that has failed.
505                 node_id: PublicKey,
506                 /// when this true, node should be permanently removed from the
507                 /// consideration. Otherwise, the channels connected to this node can be
508                 /// restored as new channel_update is received
509                 is_permanent: bool,
510         }
511 }
512
513 /// Messages could have optional fields to use with extended features
514 /// As we wish to serialize these differently from Option<T>s (Options get a tag byte, but
515 /// OptionalFeild simply gets Present if there are enough bytes to read into it), we have a
516 /// separate enum type for them.
517 #[derive(Clone, PartialEq)]
518 pub enum OptionalField<T> {
519         /// Optional field is included in message
520         Present(T),
521         /// Optional field is absent in message
522         Absent
523 }
524
525 /// A trait to describe an object which can receive channel messages.
526 ///
527 /// Messages MAY be called in parallel when they originate from different their_node_ids, however
528 /// they MUST NOT be called in parallel when the two calls have the same their_node_id.
529 pub trait ChannelMessageHandler : events::MessageSendEventsProvider + Send + Sync {
530         //Channel init:
531         /// Handle an incoming open_channel message from the given peer.
532         fn handle_open_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &OpenChannel);
533         /// Handle an incoming accept_channel message from the given peer.
534         fn handle_accept_channel(&self, their_node_id: &PublicKey, their_features: InitFeatures, msg: &AcceptChannel);
535         /// Handle an incoming funding_created message from the given peer.
536         fn handle_funding_created(&self, their_node_id: &PublicKey, msg: &FundingCreated);
537         /// Handle an incoming funding_signed message from the given peer.
538         fn handle_funding_signed(&self, their_node_id: &PublicKey, msg: &FundingSigned);
539         /// Handle an incoming funding_locked message from the given peer.
540         fn handle_funding_locked(&self, their_node_id: &PublicKey, msg: &FundingLocked);
541
542         // Channl close:
543         /// Handle an incoming shutdown message from the given peer.
544         fn handle_shutdown(&self, their_node_id: &PublicKey, msg: &Shutdown);
545         /// Handle an incoming closing_signed message from the given peer.
546         fn handle_closing_signed(&self, their_node_id: &PublicKey, msg: &ClosingSigned);
547
548         // HTLC handling:
549         /// Handle an incoming update_add_htlc message from the given peer.
550         fn handle_update_add_htlc(&self, their_node_id: &PublicKey, msg: &UpdateAddHTLC);
551         /// Handle an incoming update_fulfill_htlc message from the given peer.
552         fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFulfillHTLC);
553         /// Handle an incoming update_fail_htlc message from the given peer.
554         fn handle_update_fail_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailHTLC);
555         /// Handle an incoming update_fail_malformed_htlc message from the given peer.
556         fn handle_update_fail_malformed_htlc(&self, their_node_id: &PublicKey, msg: &UpdateFailMalformedHTLC);
557         /// Handle an incoming commitment_signed message from the given peer.
558         fn handle_commitment_signed(&self, their_node_id: &PublicKey, msg: &CommitmentSigned);
559         /// Handle an incoming revoke_and_ack message from the given peer.
560         fn handle_revoke_and_ack(&self, their_node_id: &PublicKey, msg: &RevokeAndACK);
561
562         /// Handle an incoming update_fee message from the given peer.
563         fn handle_update_fee(&self, their_node_id: &PublicKey, msg: &UpdateFee);
564
565         // Channel-to-announce:
566         /// Handle an incoming announcement_signatures message from the given peer.
567         fn handle_announcement_signatures(&self, their_node_id: &PublicKey, msg: &AnnouncementSignatures);
568
569         // Connection loss/reestablish:
570         /// Indicates a connection to the peer failed/an existing connection was lost. If no connection
571         /// is believed to be possible in the future (eg they're sending us messages we don't
572         /// understand or indicate they require unknown feature bits), no_connection_possible is set
573         /// and any outstanding channels should be failed.
574         fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool);
575
576         /// Handle a peer reconnecting, possibly generating channel_reestablish message(s).
577         fn peer_connected(&self, their_node_id: &PublicKey, msg: &Init);
578         /// Handle an incoming channel_reestablish message from the given peer.
579         fn handle_channel_reestablish(&self, their_node_id: &PublicKey, msg: &ChannelReestablish);
580
581         // Error:
582         /// Handle an incoming error message from the given peer.
583         fn handle_error(&self, their_node_id: &PublicKey, msg: &ErrorMessage);
584 }
585
586 /// A trait to describe an object which can receive routing messages.
587 pub trait RoutingMessageHandler : Send + Sync {
588         /// Handle an incoming node_announcement message, returning true if it should be forwarded on,
589         /// false or returning an Err otherwise.
590         fn handle_node_announcement(&self, msg: &NodeAnnouncement) -> Result<bool, LightningError>;
591         /// Handle a channel_announcement message, returning true if it should be forwarded on, false
592         /// or returning an Err otherwise.
593         fn handle_channel_announcement(&self, msg: &ChannelAnnouncement) -> Result<bool, LightningError>;
594         /// Handle an incoming channel_update message, returning true if it should be forwarded on,
595         /// false or returning an Err otherwise.
596         fn handle_channel_update(&self, msg: &ChannelUpdate) -> Result<bool, LightningError>;
597         /// Handle some updates to the route graph that we learned due to an outbound failed payment.
598         fn handle_htlc_fail_channel_update(&self, update: &HTLCFailChannelUpdate);
599         /// Gets a subset of the channel announcements and updates required to dump our routing table
600         /// to a remote node, starting at the short_channel_id indicated by starting_point and
601         /// including batch_amount entries.
602         fn get_next_channel_announcements(&self, starting_point: u64, batch_amount: u8) -> Vec<(ChannelAnnouncement, ChannelUpdate, ChannelUpdate)>;
603         /// Gets a subset of the node announcements required to dump our routing table to a remote node,
604         /// starting at the node *after* the provided publickey and including batch_amount entries.
605         /// If None is provided for starting_point, we start at the first node.
606         fn get_next_node_announcements(&self, starting_point: Option<&PublicKey>, batch_amount: u8) -> Vec<NodeAnnouncement>;
607         /// Returns whether a full sync should be requested from a peer.
608         fn should_request_full_sync(&self, node_id: &PublicKey) -> bool;
609 }
610
611 mod fuzzy_internal_msgs {
612         // These types aren't intended to be pub, but are exposed for direct fuzzing (as we deserialize
613         // them from untrusted input):
614
615         pub(crate) enum OnionHopDataFormat {
616                 Legacy, // aka Realm-0
617         }
618
619         pub struct OnionHopData {
620                 pub(crate) format: OnionHopDataFormat,
621                 pub(crate) short_channel_id: u64,
622                 pub(crate) amt_to_forward: u64,
623                 pub(crate) outgoing_cltv_value: u32,
624                 // 12 bytes of 0-padding
625         }
626
627         pub struct DecodedOnionErrorPacket {
628                 pub(crate) hmac: [u8; 32],
629                 pub(crate) failuremsg: Vec<u8>,
630                 pub(crate) pad: Vec<u8>,
631         }
632 }
633 #[cfg(feature = "fuzztarget")]
634 pub use self::fuzzy_internal_msgs::*;
635 #[cfg(not(feature = "fuzztarget"))]
636 pub(crate) use self::fuzzy_internal_msgs::*;
637
638 #[derive(Clone)]
639 pub(crate) struct OnionPacket {
640         pub(crate) version: u8,
641         /// In order to ensure we always return an error on Onion decode in compliance with BOLT 4, we
642         /// have to deserialize OnionPackets contained in UpdateAddHTLCs even if the ephemeral public
643         /// key (here) is bogus, so we hold a Result instead of a PublicKey as we'd like.
644         pub(crate) public_key: Result<PublicKey, secp256k1::Error>,
645         pub(crate) hop_data: [u8; 20*65],
646         pub(crate) hmac: [u8; 32],
647 }
648
649 impl PartialEq for OnionPacket {
650         fn eq(&self, other: &OnionPacket) -> bool {
651                 for (i, j) in self.hop_data.iter().zip(other.hop_data.iter()) {
652                         if i != j { return false; }
653                 }
654                 self.version == other.version &&
655                         self.public_key == other.public_key &&
656                         self.hmac == other.hmac
657         }
658 }
659
660 #[derive(Clone, PartialEq)]
661 pub(crate) struct OnionErrorPacket {
662         // This really should be a constant size slice, but the spec lets these things be up to 128KB?
663         // (TODO) We limit it in decode to much lower...
664         pub(crate) data: Vec<u8>,
665 }
666
667 impl Error for DecodeError {
668         fn description(&self) -> &str {
669                 match *self {
670                         DecodeError::UnknownVersion => "Unknown realm byte in Onion packet",
671                         DecodeError::UnknownRequiredFeature => "Unknown required feature preventing decode",
672                         DecodeError::InvalidValue => "Nonsense bytes didn't map to the type they were interpreted as",
673                         DecodeError::ShortRead => "Packet extended beyond the provided bytes",
674                         DecodeError::ExtraAddressesPerType => "More than one address of a single type",
675                         DecodeError::BadLengthDescriptor => "A length descriptor in the packet didn't describe the later data correctly",
676                         DecodeError::Io(ref e) => e.description(),
677                 }
678         }
679 }
680 impl fmt::Display for DecodeError {
681         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
682                 f.write_str(self.description())
683         }
684 }
685
686 impl fmt::Debug for LightningError {
687         fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
688                 f.write_str(self.err)
689         }
690 }
691
692 impl From<::std::io::Error> for DecodeError {
693         fn from(e: ::std::io::Error) -> Self {
694                 if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
695                         DecodeError::ShortRead
696                 } else {
697                         DecodeError::Io(e)
698                 }
699         }
700 }
701
702 impl Writeable for OptionalField<Script> {
703         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
704                 match *self {
705                         OptionalField::Present(ref script) => {
706                                 // Note that Writeable for script includes the 16-bit length tag for us
707                                 script.write(w)?;
708                         },
709                         OptionalField::Absent => {}
710                 }
711                 Ok(())
712         }
713 }
714
715 impl<R: Read> Readable<R> for OptionalField<Script> {
716         fn read(r: &mut R) -> Result<Self, DecodeError> {
717                 match <u16 as Readable<R>>::read(r) {
718                         Ok(len) => {
719                                 let mut buf = vec![0; len as usize];
720                                 r.read_exact(&mut buf)?;
721                                 Ok(OptionalField::Present(Script::from(buf)))
722                         },
723                         Err(DecodeError::ShortRead) => Ok(OptionalField::Absent),
724                         Err(e) => Err(e)
725                 }
726         }
727 }
728
729 impl_writeable_len_match!(AcceptChannel, {
730                 {AcceptChannel{ shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 270 + 2 + script.len()},
731                 {_, 270}
732         }, {
733         temporary_channel_id,
734         dust_limit_satoshis,
735         max_htlc_value_in_flight_msat,
736         channel_reserve_satoshis,
737         htlc_minimum_msat,
738         minimum_depth,
739         to_self_delay,
740         max_accepted_htlcs,
741         funding_pubkey,
742         revocation_basepoint,
743         payment_basepoint,
744         delayed_payment_basepoint,
745         htlc_basepoint,
746         first_per_commitment_point,
747         shutdown_scriptpubkey
748 });
749
750 impl_writeable!(AnnouncementSignatures, 32+8+64*2, {
751         channel_id,
752         short_channel_id,
753         node_signature,
754         bitcoin_signature
755 });
756
757 impl Writeable for ChannelReestablish {
758         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
759                 w.size_hint(if let OptionalField::Present(..) = self.data_loss_protect { 32+2*8+33+32 } else { 32+2*8 });
760                 self.channel_id.write(w)?;
761                 self.next_local_commitment_number.write(w)?;
762                 self.next_remote_commitment_number.write(w)?;
763                 match self.data_loss_protect {
764                         OptionalField::Present(ref data_loss_protect) => {
765                                 (*data_loss_protect).your_last_per_commitment_secret.write(w)?;
766                                 (*data_loss_protect).my_current_per_commitment_point.write(w)?;
767                         },
768                         OptionalField::Absent => {}
769                 }
770                 Ok(())
771         }
772 }
773
774 impl<R: Read> Readable<R> for ChannelReestablish{
775         fn read(r: &mut R) -> Result<Self, DecodeError> {
776                 Ok(Self {
777                         channel_id: Readable::read(r)?,
778                         next_local_commitment_number: Readable::read(r)?,
779                         next_remote_commitment_number: Readable::read(r)?,
780                         data_loss_protect: {
781                                 match <[u8; 32] as Readable<R>>::read(r) {
782                                         Ok(your_last_per_commitment_secret) =>
783                                                 OptionalField::Present(DataLossProtect {
784                                                         your_last_per_commitment_secret,
785                                                         my_current_per_commitment_point: Readable::read(r)?,
786                                                 }),
787                                         Err(DecodeError::ShortRead) => OptionalField::Absent,
788                                         Err(e) => return Err(e)
789                                 }
790                         }
791                 })
792         }
793 }
794
795 impl_writeable!(ClosingSigned, 32+8+64, {
796         channel_id,
797         fee_satoshis,
798         signature
799 });
800
801 impl_writeable_len_match!(CommitmentSigned, {
802                 { CommitmentSigned { ref htlc_signatures, .. }, 32+64+2+htlc_signatures.len()*64 }
803         }, {
804         channel_id,
805         signature,
806         htlc_signatures
807 });
808
809 impl_writeable_len_match!(DecodedOnionErrorPacket, {
810                 { DecodedOnionErrorPacket { ref failuremsg, ref pad, .. }, 32 + 4 + failuremsg.len() + pad.len() }
811         }, {
812         hmac,
813         failuremsg,
814         pad
815 });
816
817 impl_writeable!(FundingCreated, 32+32+2+64, {
818         temporary_channel_id,
819         funding_txid,
820         funding_output_index,
821         signature
822 });
823
824 impl_writeable!(FundingSigned, 32+64, {
825         channel_id,
826         signature
827 });
828
829 impl_writeable!(FundingLocked, 32+33, {
830         channel_id,
831         next_per_commitment_point
832 });
833
834 impl Writeable for Init {
835         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
836                 // global_features gets the bottom 13 bits of our features, and local_features gets all of
837                 // our relevant feature bits. This keeps us compatible with old nodes.
838                 self.features.write_up_to_13(w)?;
839                 self.features.write(w)
840         }
841 }
842
843 impl<R: Read> Readable<R> for Init {
844         fn read(r: &mut R) -> Result<Self, DecodeError> {
845                 let global_features: InitFeatures = Readable::read(r)?;
846                 let features: InitFeatures = Readable::read(r)?;
847                 Ok(Init {
848                         features: features.or(global_features),
849                 })
850         }
851 }
852
853 impl_writeable_len_match!(OpenChannel, {
854                 { OpenChannel { shutdown_scriptpubkey: OptionalField::Present(ref script), .. }, 319 + 2 + script.len() },
855                 { _, 319 }
856         }, {
857         chain_hash,
858         temporary_channel_id,
859         funding_satoshis,
860         push_msat,
861         dust_limit_satoshis,
862         max_htlc_value_in_flight_msat,
863         channel_reserve_satoshis,
864         htlc_minimum_msat,
865         feerate_per_kw,
866         to_self_delay,
867         max_accepted_htlcs,
868         funding_pubkey,
869         revocation_basepoint,
870         payment_basepoint,
871         delayed_payment_basepoint,
872         htlc_basepoint,
873         first_per_commitment_point,
874         channel_flags,
875         shutdown_scriptpubkey
876 });
877
878 impl_writeable!(RevokeAndACK, 32+32+33, {
879         channel_id,
880         per_commitment_secret,
881         next_per_commitment_point
882 });
883
884 impl_writeable_len_match!(Shutdown, {
885                 { Shutdown { ref scriptpubkey, .. }, 32 + 2 + scriptpubkey.len() }
886         }, {
887         channel_id,
888         scriptpubkey
889 });
890
891 impl_writeable_len_match!(UpdateFailHTLC, {
892                 { UpdateFailHTLC { ref reason, .. }, 32 + 10 + reason.data.len() }
893         }, {
894         channel_id,
895         htlc_id,
896         reason
897 });
898
899 impl_writeable!(UpdateFailMalformedHTLC, 32+8+32+2, {
900         channel_id,
901         htlc_id,
902         sha256_of_onion,
903         failure_code
904 });
905
906 impl_writeable!(UpdateFee, 32+4, {
907         channel_id,
908         feerate_per_kw
909 });
910
911 impl_writeable!(UpdateFulfillHTLC, 32+8+32, {
912         channel_id,
913         htlc_id,
914         payment_preimage
915 });
916
917 impl_writeable_len_match!(OnionErrorPacket, {
918                 { OnionErrorPacket { ref data, .. }, 2 + data.len() }
919         }, {
920         data
921 });
922
923 impl Writeable for OnionPacket {
924         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
925                 w.size_hint(1 + 33 + 20*65 + 32);
926                 self.version.write(w)?;
927                 match self.public_key {
928                         Ok(pubkey) => pubkey.write(w)?,
929                         Err(_) => [0u8;33].write(w)?,
930                 }
931                 w.write_all(&self.hop_data)?;
932                 self.hmac.write(w)?;
933                 Ok(())
934         }
935 }
936
937 impl<R: Read> Readable<R> for OnionPacket {
938         fn read(r: &mut R) -> Result<Self, DecodeError> {
939                 Ok(OnionPacket {
940                         version: Readable::read(r)?,
941                         public_key: {
942                                 let mut buf = [0u8;33];
943                                 r.read_exact(&mut buf)?;
944                                 PublicKey::from_slice(&buf)
945                         },
946                         hop_data: Readable::read(r)?,
947                         hmac: Readable::read(r)?,
948                 })
949         }
950 }
951
952 impl_writeable!(UpdateAddHTLC, 32+8+8+32+4+1366, {
953         channel_id,
954         htlc_id,
955         amount_msat,
956         payment_hash,
957         cltv_expiry,
958         onion_routing_packet
959 });
960
961 impl Writeable for OnionHopData {
962         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
963                 w.size_hint(33);
964                 match self.format {
965                         OnionHopDataFormat::Legacy => 0u8.write(w)?,
966                 }
967                 self.short_channel_id.write(w)?;
968                 self.amt_to_forward.write(w)?;
969                 self.outgoing_cltv_value.write(w)?;
970                 w.write_all(&[0;12])?;
971                 Ok(())
972         }
973 }
974
975 impl<R: Read> Readable<R> for OnionHopData {
976         fn read(r: &mut R) -> Result<Self, DecodeError> {
977                 Ok(OnionHopData {
978                         format: {
979                                 let r: u8 = Readable::read(r)?;
980                                 if r != 0 {
981                                         return Err(DecodeError::UnknownVersion);
982                                 }
983                                 OnionHopDataFormat::Legacy
984                         },
985                         short_channel_id: Readable::read(r)?,
986                         amt_to_forward: Readable::read(r)?,
987                         outgoing_cltv_value: {
988                                 let v: u32 = Readable::read(r)?;
989                                 r.read_exact(&mut [0; 12])?;
990                                 v
991                         },
992                 })
993         }
994 }
995
996 impl Writeable for Ping {
997         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
998                 w.size_hint(self.byteslen as usize + 4);
999                 self.ponglen.write(w)?;
1000                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1001                 Ok(())
1002         }
1003 }
1004
1005 impl<R: Read> Readable<R> for Ping {
1006         fn read(r: &mut R) -> Result<Self, DecodeError> {
1007                 Ok(Ping {
1008                         ponglen: Readable::read(r)?,
1009                         byteslen: {
1010                                 let byteslen = Readable::read(r)?;
1011                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1012                                 byteslen
1013                         }
1014                 })
1015         }
1016 }
1017
1018 impl Writeable for Pong {
1019         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1020                 w.size_hint(self.byteslen as usize + 2);
1021                 vec![0u8; self.byteslen as usize].write(w)?; // size-unchecked write
1022                 Ok(())
1023         }
1024 }
1025
1026 impl<R: Read> Readable<R> for Pong {
1027         fn read(r: &mut R) -> Result<Self, DecodeError> {
1028                 Ok(Pong {
1029                         byteslen: {
1030                                 let byteslen = Readable::read(r)?;
1031                                 r.read_exact(&mut vec![0u8; byteslen as usize][..])?;
1032                                 byteslen
1033                         }
1034                 })
1035         }
1036 }
1037
1038 impl Writeable for UnsignedChannelAnnouncement {
1039         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1040                 w.size_hint(2 + 2*32 + 4*33 + self.features.byte_count() + self.excess_data.len());
1041                 self.features.write(w)?;
1042                 self.chain_hash.write(w)?;
1043                 self.short_channel_id.write(w)?;
1044                 self.node_id_1.write(w)?;
1045                 self.node_id_2.write(w)?;
1046                 self.bitcoin_key_1.write(w)?;
1047                 self.bitcoin_key_2.write(w)?;
1048                 w.write_all(&self.excess_data[..])?;
1049                 Ok(())
1050         }
1051 }
1052
1053 impl<R: Read> Readable<R> for UnsignedChannelAnnouncement {
1054         fn read(r: &mut R) -> Result<Self, DecodeError> {
1055                 Ok(Self {
1056                         features: Readable::read(r)?,
1057                         chain_hash: Readable::read(r)?,
1058                         short_channel_id: Readable::read(r)?,
1059                         node_id_1: Readable::read(r)?,
1060                         node_id_2: Readable::read(r)?,
1061                         bitcoin_key_1: Readable::read(r)?,
1062                         bitcoin_key_2: Readable::read(r)?,
1063                         excess_data: {
1064                                 let mut excess_data = vec![];
1065                                 r.read_to_end(&mut excess_data)?;
1066                                 excess_data
1067                         },
1068                 })
1069         }
1070 }
1071
1072 impl_writeable_len_match!(ChannelAnnouncement, {
1073                 { ChannelAnnouncement { contents: UnsignedChannelAnnouncement {ref features, ref excess_data, ..}, .. },
1074                         2 + 2*32 + 4*33 + features.byte_count() + excess_data.len() + 4*64 }
1075         }, {
1076         node_signature_1,
1077         node_signature_2,
1078         bitcoin_signature_1,
1079         bitcoin_signature_2,
1080         contents
1081 });
1082
1083 impl Writeable for UnsignedChannelUpdate {
1084         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1085                 w.size_hint(64 + self.excess_data.len());
1086                 self.chain_hash.write(w)?;
1087                 self.short_channel_id.write(w)?;
1088                 self.timestamp.write(w)?;
1089                 self.flags.write(w)?;
1090                 self.cltv_expiry_delta.write(w)?;
1091                 self.htlc_minimum_msat.write(w)?;
1092                 self.fee_base_msat.write(w)?;
1093                 self.fee_proportional_millionths.write(w)?;
1094                 w.write_all(&self.excess_data[..])?;
1095                 Ok(())
1096         }
1097 }
1098
1099 impl<R: Read> Readable<R> for UnsignedChannelUpdate {
1100         fn read(r: &mut R) -> Result<Self, DecodeError> {
1101                 Ok(Self {
1102                         chain_hash: Readable::read(r)?,
1103                         short_channel_id: Readable::read(r)?,
1104                         timestamp: Readable::read(r)?,
1105                         flags: Readable::read(r)?,
1106                         cltv_expiry_delta: Readable::read(r)?,
1107                         htlc_minimum_msat: Readable::read(r)?,
1108                         fee_base_msat: Readable::read(r)?,
1109                         fee_proportional_millionths: Readable::read(r)?,
1110                         excess_data: {
1111                                 let mut excess_data = vec![];
1112                                 r.read_to_end(&mut excess_data)?;
1113                                 excess_data
1114                         },
1115                 })
1116         }
1117 }
1118
1119 impl_writeable_len_match!(ChannelUpdate, {
1120                 { ChannelUpdate { contents: UnsignedChannelUpdate {ref excess_data, ..}, .. },
1121                         64 + excess_data.len() + 64 }
1122         }, {
1123         signature,
1124         contents
1125 });
1126
1127 impl Writeable for ErrorMessage {
1128         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1129                 w.size_hint(32 + 2 + self.data.len());
1130                 self.channel_id.write(w)?;
1131                 (self.data.len() as u16).write(w)?;
1132                 w.write_all(self.data.as_bytes())?;
1133                 Ok(())
1134         }
1135 }
1136
1137 impl<R: Read> Readable<R> for ErrorMessage {
1138         fn read(r: &mut R) -> Result<Self, DecodeError> {
1139                 Ok(Self {
1140                         channel_id: Readable::read(r)?,
1141                         data: {
1142                                 let mut sz: usize = <u16 as Readable<R>>::read(r)? as usize;
1143                                 let mut data = vec![];
1144                                 let data_len = r.read_to_end(&mut data)?;
1145                                 sz = cmp::min(data_len, sz);
1146                                 match String::from_utf8(data[..sz as usize].to_vec()) {
1147                                         Ok(s) => s,
1148                                         Err(_) => return Err(DecodeError::InvalidValue),
1149                                 }
1150                         }
1151                 })
1152         }
1153 }
1154
1155 impl Writeable for UnsignedNodeAnnouncement {
1156         fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
1157                 w.size_hint(64 + 76 + self.features.byte_count() + self.addresses.len()*38 + self.excess_address_data.len() + self.excess_data.len());
1158                 self.features.write(w)?;
1159                 self.timestamp.write(w)?;
1160                 self.node_id.write(w)?;
1161                 w.write_all(&self.rgb)?;
1162                 self.alias.write(w)?;
1163
1164                 let mut addrs_to_encode = self.addresses.clone();
1165                 addrs_to_encode.sort_unstable_by(|a, b| { a.get_id().cmp(&b.get_id()) });
1166                 addrs_to_encode.dedup_by(|a, b| { a.get_id() == b.get_id() });
1167                 let mut addr_len = 0;
1168                 for addr in &addrs_to_encode {
1169                         addr_len += 1 + addr.len();
1170                 }
1171                 (addr_len + self.excess_address_data.len() as u16).write(w)?;
1172                 for addr in addrs_to_encode {
1173                         addr.write(w)?;
1174                 }
1175                 w.write_all(&self.excess_address_data[..])?;
1176                 w.write_all(&self.excess_data[..])?;
1177                 Ok(())
1178         }
1179 }
1180
1181 impl<R: Read> Readable<R> for UnsignedNodeAnnouncement {
1182         fn read(r: &mut R) -> Result<Self, DecodeError> {
1183                 let features: NodeFeatures = Readable::read(r)?;
1184                 let timestamp: u32 = Readable::read(r)?;
1185                 let node_id: PublicKey = Readable::read(r)?;
1186                 let mut rgb = [0; 3];
1187                 r.read_exact(&mut rgb)?;
1188                 let alias: [u8; 32] = Readable::read(r)?;
1189
1190                 let addr_len: u16 = Readable::read(r)?;
1191                 let mut addresses: Vec<NetAddress> = Vec::with_capacity(4);
1192                 let mut addr_readpos = 0;
1193                 let mut excess = false;
1194                 let mut excess_byte = 0;
1195                 loop {
1196                         if addr_len <= addr_readpos { break; }
1197                         match Readable::read(r) {
1198                                 Ok(Ok(addr)) => {
1199                                         match addr {
1200                                                 NetAddress::IPv4 { .. } => {
1201                                                         if addresses.len() > 0 {
1202                                                                 return Err(DecodeError::ExtraAddressesPerType);
1203                                                         }
1204                                                 },
1205                                                 NetAddress::IPv6 { .. } => {
1206                                                         if addresses.len() > 1 || (addresses.len() == 1 && addresses[0].get_id() != 1) {
1207                                                                 return Err(DecodeError::ExtraAddressesPerType);
1208                                                         }
1209                                                 },
1210                                                 NetAddress::OnionV2 { .. } => {
1211                                                         if addresses.len() > 2 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 2) {
1212                                                                 return Err(DecodeError::ExtraAddressesPerType);
1213                                                         }
1214                                                 },
1215                                                 NetAddress::OnionV3 { .. } => {
1216                                                         if addresses.len() > 3 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 3) {
1217                                                                 return Err(DecodeError::ExtraAddressesPerType);
1218                                                         }
1219                                                 },
1220                                         }
1221                                         if addr_len < addr_readpos + 1 + addr.len() {
1222                                                 return Err(DecodeError::BadLengthDescriptor);
1223                                         }
1224                                         addr_readpos += (1 + addr.len()) as u16;
1225                                         addresses.push(addr);
1226                                 },
1227                                 Ok(Err(unknown_descriptor)) => {
1228                                         excess = true;
1229                                         excess_byte = unknown_descriptor;
1230                                         break;
1231                                 },
1232                                 Err(DecodeError::ShortRead) => return Err(DecodeError::BadLengthDescriptor),
1233                                 Err(e) => return Err(e),
1234                         }
1235                 }
1236
1237                 let mut excess_data = vec![];
1238                 let excess_address_data = if addr_readpos < addr_len {
1239                         let mut excess_address_data = vec![0; (addr_len - addr_readpos) as usize];
1240                         r.read_exact(&mut excess_address_data[if excess { 1 } else { 0 }..])?;
1241                         if excess {
1242                                 excess_address_data[0] = excess_byte;
1243                         }
1244                         excess_address_data
1245                 } else {
1246                         if excess {
1247                                 excess_data.push(excess_byte);
1248                         }
1249                         Vec::new()
1250                 };
1251                 r.read_to_end(&mut excess_data)?;
1252                 Ok(UnsignedNodeAnnouncement {
1253                         features,
1254                         timestamp,
1255                         node_id,
1256                         rgb,
1257                         alias,
1258                         addresses,
1259                         excess_address_data,
1260                         excess_data,
1261                 })
1262         }
1263 }
1264
1265 impl_writeable_len_match!(NodeAnnouncement, {
1266                 { NodeAnnouncement { contents: UnsignedNodeAnnouncement { ref features, ref addresses, ref excess_address_data, ref excess_data, ..}, .. },
1267                         64 + 76 + features.byte_count() + addresses.len()*38 + excess_address_data.len() + excess_data.len() }
1268         }, {
1269         signature,
1270         contents
1271 });
1272
1273 #[cfg(test)]
1274 mod tests {
1275         use hex;
1276         use ln::msgs;
1277         use ln::msgs::{ChannelFeatures, InitFeatures, NodeFeatures, OptionalField, OnionErrorPacket};
1278         use ln::channelmanager::{PaymentPreimage, PaymentHash};
1279         use util::ser::Writeable;
1280
1281         use bitcoin_hashes::sha256d::Hash as Sha256dHash;
1282         use bitcoin_hashes::hex::FromHex;
1283         use bitcoin::util::address::Address;
1284         use bitcoin::network::constants::Network;
1285         use bitcoin::blockdata::script::Builder;
1286         use bitcoin::blockdata::opcodes;
1287
1288         use secp256k1::key::{PublicKey,SecretKey};
1289         use secp256k1::{Secp256k1, Message};
1290
1291         #[test]
1292         fn encoding_channel_reestablish_no_secret() {
1293                 let cr = msgs::ChannelReestablish {
1294                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1295                         next_local_commitment_number: 3,
1296                         next_remote_commitment_number: 4,
1297                         data_loss_protect: OptionalField::Absent,
1298                 };
1299
1300                 let encoded_value = cr.encode();
1301                 assert_eq!(
1302                         encoded_value,
1303                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4]
1304                 );
1305         }
1306
1307         #[test]
1308         fn encoding_channel_reestablish_with_secret() {
1309                 let public_key = {
1310                         let secp_ctx = Secp256k1::new();
1311                         PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()[..]).unwrap())
1312                 };
1313
1314                 let cr = msgs::ChannelReestablish {
1315                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1316                         next_local_commitment_number: 3,
1317                         next_remote_commitment_number: 4,
1318                         data_loss_protect: OptionalField::Present(msgs::DataLossProtect { your_last_per_commitment_secret: [9;32], my_current_per_commitment_point: public_key}),
1319                 };
1320
1321                 let encoded_value = cr.encode();
1322                 assert_eq!(
1323                         encoded_value,
1324                         vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 4, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 3, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5, 101, 215, 30, 24, 52, 96, 72, 25, 255, 156, 23, 245, 233, 213, 221, 7, 143]
1325                 );
1326         }
1327
1328         macro_rules! get_keys_from {
1329                 ($slice: expr, $secp_ctx: expr) => {
1330                         {
1331                                 let privkey = SecretKey::from_slice(&hex::decode($slice).unwrap()[..]).unwrap();
1332                                 let pubkey = PublicKey::from_secret_key(&$secp_ctx, &privkey);
1333                                 (privkey, pubkey)
1334                         }
1335                 }
1336         }
1337
1338         macro_rules! get_sig_on {
1339                 ($privkey: expr, $ctx: expr, $string: expr) => {
1340                         {
1341                                 let sighash = Message::from_slice(&$string.into_bytes()[..]).unwrap();
1342                                 $ctx.sign(&sighash, &$privkey)
1343                         }
1344                 }
1345         }
1346
1347         #[test]
1348         fn encoding_announcement_signatures() {
1349                 let secp_ctx = Secp256k1::new();
1350                 let (privkey, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1351                 let sig_1 = get_sig_on!(privkey, secp_ctx, String::from("01010101010101010101010101010101"));
1352                 let sig_2 = get_sig_on!(privkey, secp_ctx, String::from("02020202020202020202020202020202"));
1353                 let announcement_signatures = msgs::AnnouncementSignatures {
1354                         channel_id: [4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0],
1355                         short_channel_id: 2316138423780173,
1356                         node_signature: sig_1,
1357                         bitcoin_signature: sig_2,
1358                 };
1359
1360                 let encoded_value = announcement_signatures.encode();
1361                 assert_eq!(encoded_value, hex::decode("040000000000000005000000000000000600000000000000070000000000000000083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073acf9953cef4700860f5967838eba2bae89288ad188ebf8b20bf995c3ea53a26df1876d0a3a0e13172ba286a673140190c02ba9da60a2e43a745188c8a83c7f3ef").unwrap());
1362         }
1363
1364         fn do_encoding_channel_announcement(unknown_features_bits: bool, non_bitcoin_chain_hash: bool, excess_data: bool) {
1365                 let secp_ctx = Secp256k1::new();
1366                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1367                 let (privkey_2, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1368                 let (privkey_3, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1369                 let (privkey_4, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1370                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1371                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1372                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1373                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1374                 let mut features = ChannelFeatures::supported();
1375                 if unknown_features_bits {
1376                         features = ChannelFeatures::from_le_bytes(vec![0xFF, 0xFF]);
1377                 }
1378                 let unsigned_channel_announcement = msgs::UnsignedChannelAnnouncement {
1379                         features,
1380                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1381                         short_channel_id: 2316138423780173,
1382                         node_id_1: pubkey_1,
1383                         node_id_2: pubkey_2,
1384                         bitcoin_key_1: pubkey_3,
1385                         bitcoin_key_2: pubkey_4,
1386                         excess_data: if excess_data { vec![10, 0, 0, 20, 0, 0, 30, 0, 0, 40] } else { Vec::new() },
1387                 };
1388                 let channel_announcement = msgs::ChannelAnnouncement {
1389                         node_signature_1: sig_1,
1390                         node_signature_2: sig_2,
1391                         bitcoin_signature_1: sig_3,
1392                         bitcoin_signature_2: sig_4,
1393                         contents: unsigned_channel_announcement,
1394                 };
1395                 let encoded_value = channel_announcement.encode();
1396                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a1735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap();
1397                 if unknown_features_bits {
1398                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1399                 } else {
1400                         target_value.append(&mut hex::decode("0000").unwrap());
1401                 }
1402                 if non_bitcoin_chain_hash {
1403                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1404                 } else {
1405                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1406                 }
1407                 target_value.append(&mut hex::decode("00083a840000034d031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b").unwrap());
1408                 if excess_data {
1409                         target_value.append(&mut hex::decode("0a00001400001e000028").unwrap());
1410                 }
1411                 assert_eq!(encoded_value, target_value);
1412         }
1413
1414         #[test]
1415         fn encoding_channel_announcement() {
1416                 do_encoding_channel_announcement(false, false, false);
1417                 do_encoding_channel_announcement(true, false, false);
1418                 do_encoding_channel_announcement(true, true, false);
1419                 do_encoding_channel_announcement(true, true, true);
1420                 do_encoding_channel_announcement(false, true, true);
1421                 do_encoding_channel_announcement(false, false, true);
1422                 do_encoding_channel_announcement(false, true, false);
1423                 do_encoding_channel_announcement(true, false, true);
1424         }
1425
1426         fn do_encoding_node_announcement(unknown_features_bits: bool, ipv4: bool, ipv6: bool, onionv2: bool, onionv3: bool, excess_address_data: bool, excess_data: bool) {
1427                 let secp_ctx = Secp256k1::new();
1428                 let (privkey_1, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1429                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1430                 let features = if unknown_features_bits {
1431                         NodeFeatures::from_le_bytes(vec![0xFF, 0xFF])
1432                 } else {
1433                         // Set to some features we may support
1434                         NodeFeatures::from_le_bytes(vec![2 | 1 << 5])
1435                 };
1436                 let mut addresses = Vec::new();
1437                 if ipv4 {
1438                         addresses.push(msgs::NetAddress::IPv4 {
1439                                 addr: [255, 254, 253, 252],
1440                                 port: 9735
1441                         });
1442                 }
1443                 if ipv6 {
1444                         addresses.push(msgs::NetAddress::IPv6 {
1445                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240],
1446                                 port: 9735
1447                         });
1448                 }
1449                 if onionv2 {
1450                         addresses.push(msgs::NetAddress::OnionV2 {
1451                                 addr: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246],
1452                                 port: 9735
1453                         });
1454                 }
1455                 if onionv3 {
1456                         addresses.push(msgs::NetAddress::OnionV3 {
1457                                 ed25519_pubkey: [255, 254, 253, 252, 251, 250, 249, 248, 247, 246, 245, 244, 243, 242, 241, 240, 239, 238, 237, 236, 235, 234, 233, 232, 231, 230, 229, 228, 227, 226, 225, 224],
1458                                 checksum: 32,
1459                                 version: 16,
1460                                 port: 9735
1461                         });
1462                 }
1463                 let mut addr_len = 0;
1464                 for addr in &addresses {
1465                         addr_len += addr.len() + 1;
1466                 }
1467                 let unsigned_node_announcement = msgs::UnsignedNodeAnnouncement {
1468                         features,
1469                         timestamp: 20190119,
1470                         node_id: pubkey_1,
1471                         rgb: [32; 3],
1472                         alias: [16;32],
1473                         addresses,
1474                         excess_address_data: if excess_address_data { vec![33, 108, 40, 11, 83, 149, 162, 84, 110, 126, 75, 38, 99, 224, 79, 129, 22, 34, 241, 90, 79, 146, 232, 58, 162, 233, 43, 162, 165, 115, 193, 57, 20, 44, 84, 174, 99, 7, 42, 30, 193, 238, 125, 192, 192, 75, 222, 92, 132, 120, 6, 23, 42, 160, 92, 146, 194, 42, 232, 227, 8, 209, 210, 105] } else { Vec::new() },
1475                         excess_data: if excess_data { vec![59, 18, 204, 25, 92, 224, 162, 209, 189, 166, 168, 139, 239, 161, 159, 160, 127, 81, 202, 167, 92, 232, 56, 55, 242, 137, 101, 96, 11, 138, 172, 171, 8, 85, 255, 176, 231, 65, 236, 95, 124, 65, 66, 30, 152, 41, 169, 212, 134, 17, 200, 200, 49, 247, 27, 229, 234, 115, 230, 101, 148, 151, 127, 253] } else { Vec::new() },
1476                 };
1477                 addr_len += unsigned_node_announcement.excess_address_data.len() as u16;
1478                 let node_announcement = msgs::NodeAnnouncement {
1479                         signature: sig_1,
1480                         contents: unsigned_node_announcement,
1481                 };
1482                 let encoded_value = node_announcement.encode();
1483                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1484                 if unknown_features_bits {
1485                         target_value.append(&mut hex::decode("0002ffff").unwrap());
1486                 } else {
1487                         target_value.append(&mut hex::decode("000122").unwrap());
1488                 }
1489                 target_value.append(&mut hex::decode("013413a7031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f2020201010101010101010101010101010101010101010101010101010101010101010").unwrap());
1490                 target_value.append(&mut vec![(addr_len >> 8) as u8, addr_len as u8]);
1491                 if ipv4 {
1492                         target_value.append(&mut hex::decode("01fffefdfc2607").unwrap());
1493                 }
1494                 if ipv6 {
1495                         target_value.append(&mut hex::decode("02fffefdfcfbfaf9f8f7f6f5f4f3f2f1f02607").unwrap());
1496                 }
1497                 if onionv2 {
1498                         target_value.append(&mut hex::decode("03fffefdfcfbfaf9f8f7f62607").unwrap());
1499                 }
1500                 if onionv3 {
1501                         target_value.append(&mut hex::decode("04fffefdfcfbfaf9f8f7f6f5f4f3f2f1f0efeeedecebeae9e8e7e6e5e4e3e2e1e00020102607").unwrap());
1502                 }
1503                 if excess_address_data {
1504                         target_value.append(&mut hex::decode("216c280b5395a2546e7e4b2663e04f811622f15a4f92e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d269").unwrap());
1505                 }
1506                 if excess_data {
1507                         target_value.append(&mut hex::decode("3b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1508                 }
1509                 assert_eq!(encoded_value, target_value);
1510         }
1511
1512         #[test]
1513         fn encoding_node_announcement() {
1514                 do_encoding_node_announcement(true, true, true, true, true, true, true);
1515                 do_encoding_node_announcement(false, false, false, false, false, false, false);
1516                 do_encoding_node_announcement(false, true, false, false, false, false, false);
1517                 do_encoding_node_announcement(false, false, true, false, false, false, false);
1518                 do_encoding_node_announcement(false, false, false, true, false, false, false);
1519                 do_encoding_node_announcement(false, false, false, false, true, false, false);
1520                 do_encoding_node_announcement(false, false, false, false, false, true, false);
1521                 do_encoding_node_announcement(false, true, false, true, false, true, false);
1522                 do_encoding_node_announcement(false, false, true, false, true, false, false);
1523         }
1524
1525         fn do_encoding_channel_update(non_bitcoin_chain_hash: bool, direction: bool, disable: bool, htlc_maximum_msat: bool) {
1526                 let secp_ctx = Secp256k1::new();
1527                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1528                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1529                 let unsigned_channel_update = msgs::UnsignedChannelUpdate {
1530                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1531                         short_channel_id: 2316138423780173,
1532                         timestamp: 20190119,
1533                         flags: if direction { 1 } else { 0 } | if disable { 1 << 1 } else { 0 } | if htlc_maximum_msat { 1 << 8 } else { 0 },
1534                         cltv_expiry_delta: 144,
1535                         htlc_minimum_msat: 1000000,
1536                         fee_base_msat: 10000,
1537                         fee_proportional_millionths: 20,
1538                         excess_data: if htlc_maximum_msat { vec![0, 0, 0, 0, 59, 154, 202, 0] } else { Vec::new() }
1539                 };
1540                 let channel_update = msgs::ChannelUpdate {
1541                         signature: sig_1,
1542                         contents: unsigned_channel_update
1543                 };
1544                 let encoded_value = channel_update.encode();
1545                 let mut target_value = hex::decode("d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1546                 if non_bitcoin_chain_hash {
1547                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1548                 } else {
1549                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1550                 }
1551                 target_value.append(&mut hex::decode("00083a840000034d013413a7").unwrap());
1552                 if htlc_maximum_msat {
1553                         target_value.append(&mut hex::decode("01").unwrap());
1554                 } else {
1555                         target_value.append(&mut hex::decode("00").unwrap());
1556                 }
1557                 target_value.append(&mut hex::decode("00").unwrap());
1558                 if direction {
1559                         let flag = target_value.last_mut().unwrap();
1560                         *flag = 1;
1561                 }
1562                 if disable {
1563                         let flag = target_value.last_mut().unwrap();
1564                         *flag = *flag | 1 << 1;
1565                 }
1566                 target_value.append(&mut hex::decode("009000000000000f42400000271000000014").unwrap());
1567                 if htlc_maximum_msat {
1568                         target_value.append(&mut hex::decode("000000003b9aca00").unwrap());
1569                 }
1570                 assert_eq!(encoded_value, target_value);
1571         }
1572
1573         #[test]
1574         fn encoding_channel_update() {
1575                 do_encoding_channel_update(false, false, false, false);
1576                 do_encoding_channel_update(true, false, false, false);
1577                 do_encoding_channel_update(false, true, false, false);
1578                 do_encoding_channel_update(false, false, true, false);
1579                 do_encoding_channel_update(false, false, false, true);
1580                 do_encoding_channel_update(true, true, true, true);
1581         }
1582
1583         fn do_encoding_open_channel(non_bitcoin_chain_hash: bool, random_bit: bool, shutdown: bool) {
1584                 let secp_ctx = Secp256k1::new();
1585                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1586                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1587                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1588                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1589                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1590                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1591                 let open_channel = msgs::OpenChannel {
1592                         chain_hash: if !non_bitcoin_chain_hash { Sha256dHash::from_hex("6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000").unwrap() } else { Sha256dHash::from_hex("000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943").unwrap() },
1593                         temporary_channel_id: [2; 32],
1594                         funding_satoshis: 1311768467284833366,
1595                         push_msat: 2536655962884945560,
1596                         dust_limit_satoshis: 3608586615801332854,
1597                         max_htlc_value_in_flight_msat: 8517154655701053848,
1598                         channel_reserve_satoshis: 8665828695742877976,
1599                         htlc_minimum_msat: 2316138423780173,
1600                         feerate_per_kw: 821716,
1601                         to_self_delay: 49340,
1602                         max_accepted_htlcs: 49340,
1603                         funding_pubkey: pubkey_1,
1604                         revocation_basepoint: pubkey_2,
1605                         payment_basepoint: pubkey_3,
1606                         delayed_payment_basepoint: pubkey_4,
1607                         htlc_basepoint: pubkey_5,
1608                         first_per_commitment_point: pubkey_6,
1609                         channel_flags: if random_bit { 1 << 5 } else { 0 },
1610                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1611                 };
1612                 let encoded_value = open_channel.encode();
1613                 let mut target_value = Vec::new();
1614                 if non_bitcoin_chain_hash {
1615                         target_value.append(&mut hex::decode("43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000").unwrap());
1616                 } else {
1617                         target_value.append(&mut hex::decode("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap());
1618                 }
1619                 target_value.append(&mut hex::decode("02020202020202020202020202020202020202020202020202020202020202021234567890123456233403289122369832144668701144767633030896203198784335490624111800083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap());
1620                 if random_bit {
1621                         target_value.append(&mut hex::decode("20").unwrap());
1622                 } else {
1623                         target_value.append(&mut hex::decode("00").unwrap());
1624                 }
1625                 if shutdown {
1626                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1627                 }
1628                 assert_eq!(encoded_value, target_value);
1629         }
1630
1631         #[test]
1632         fn encoding_open_channel() {
1633                 do_encoding_open_channel(false, false, false);
1634                 do_encoding_open_channel(true, false, false);
1635                 do_encoding_open_channel(false, true, false);
1636                 do_encoding_open_channel(false, false, true);
1637                 do_encoding_open_channel(true, true, true);
1638         }
1639
1640         fn do_encoding_accept_channel(shutdown: bool) {
1641                 let secp_ctx = Secp256k1::new();
1642                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1643                 let (_, pubkey_2) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1644                 let (_, pubkey_3) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1645                 let (_, pubkey_4) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1646                 let (_, pubkey_5) = get_keys_from!("0505050505050505050505050505050505050505050505050505050505050505", secp_ctx);
1647                 let (_, pubkey_6) = get_keys_from!("0606060606060606060606060606060606060606060606060606060606060606", secp_ctx);
1648                 let accept_channel = msgs::AcceptChannel {
1649                         temporary_channel_id: [2; 32],
1650                         dust_limit_satoshis: 1311768467284833366,
1651                         max_htlc_value_in_flight_msat: 2536655962884945560,
1652                         channel_reserve_satoshis: 3608586615801332854,
1653                         htlc_minimum_msat: 2316138423780173,
1654                         minimum_depth: 821716,
1655                         to_self_delay: 49340,
1656                         max_accepted_htlcs: 49340,
1657                         funding_pubkey: pubkey_1,
1658                         revocation_basepoint: pubkey_2,
1659                         payment_basepoint: pubkey_3,
1660                         delayed_payment_basepoint: pubkey_4,
1661                         htlc_basepoint: pubkey_5,
1662                         first_per_commitment_point: pubkey_6,
1663                         shutdown_scriptpubkey: if shutdown { OptionalField::Present(Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey()) } else { OptionalField::Absent }
1664                 };
1665                 let encoded_value = accept_channel.encode();
1666                 let mut target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020212345678901234562334032891223698321446687011447600083a840000034d000c89d4c0bcc0bc031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f024d4b6cd1361032ca9bd2aeb9d900aa4d45d9ead80ac9423374c451a7254d076602531fe6068134503d2723133227c867ac8fa6c83c537e9a44c3c5bdbdcb1fe33703462779ad4aad39514614751a71085f2f10e1c7a593e4e030efb5b8721ce55b0b0362c0a046dacce86ddd0343c6d3c7c79c2208ba0d9c9cf24a6d046d21d21f90f703f006a18d5653c4edf5391ff23a61f03ff83d237e880ee61187fa9f379a028e0a").unwrap();
1667                 if shutdown {
1668                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1669                 }
1670                 assert_eq!(encoded_value, target_value);
1671         }
1672
1673         #[test]
1674         fn encoding_accept_channel() {
1675                 do_encoding_accept_channel(false);
1676                 do_encoding_accept_channel(true);
1677         }
1678
1679         #[test]
1680         fn encoding_funding_created() {
1681                 let secp_ctx = Secp256k1::new();
1682                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1683                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1684                 let funding_created = msgs::FundingCreated {
1685                         temporary_channel_id: [2; 32],
1686                         funding_txid: Sha256dHash::from_hex("c2d4449afa8d26140898dd54d3390b057ba2a5afcf03ba29d7dc0d8b9ffe966e").unwrap(),
1687                         funding_output_index: 255,
1688                         signature: sig_1,
1689                 };
1690                 let encoded_value = funding_created.encode();
1691                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202026e96fe9f8b0ddcd729ba03cfafa5a27b050b39d354dd980814268dfa9a44d4c200ffd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1692                 assert_eq!(encoded_value, target_value);
1693         }
1694
1695         #[test]
1696         fn encoding_funding_signed() {
1697                 let secp_ctx = Secp256k1::new();
1698                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1699                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1700                 let funding_signed = msgs::FundingSigned {
1701                         channel_id: [2; 32],
1702                         signature: sig_1,
1703                 };
1704                 let encoded_value = funding_signed.encode();
1705                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1706                 assert_eq!(encoded_value, target_value);
1707         }
1708
1709         #[test]
1710         fn encoding_funding_locked() {
1711                 let secp_ctx = Secp256k1::new();
1712                 let (_, pubkey_1,) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1713                 let funding_locked = msgs::FundingLocked {
1714                         channel_id: [2; 32],
1715                         next_per_commitment_point: pubkey_1,
1716                 };
1717                 let encoded_value = funding_locked.encode();
1718                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1719                 assert_eq!(encoded_value, target_value);
1720         }
1721
1722         fn do_encoding_shutdown(script_type: u8) {
1723                 let secp_ctx = Secp256k1::new();
1724                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1725                 let script = Builder::new().push_opcode(opcodes::OP_TRUE).into_script();
1726                 let shutdown = msgs::Shutdown {
1727                         channel_id: [2; 32],
1728                         scriptpubkey: if script_type == 1 { Address::p2pkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else if script_type == 2 { Address::p2sh(&script, Network::Testnet).script_pubkey() } else if script_type == 3 { Address::p2wpkh(&::bitcoin::PublicKey{compressed: true, key: pubkey_1}, Network::Testnet).script_pubkey() } else { Address::p2wsh(&script, Network::Testnet).script_pubkey() },
1729                 };
1730                 let encoded_value = shutdown.encode();
1731                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap();
1732                 if script_type == 1 {
1733                         target_value.append(&mut hex::decode("001976a91479b000887626b294a914501a4cd226b58b23598388ac").unwrap());
1734                 } else if script_type == 2 {
1735                         target_value.append(&mut hex::decode("0017a914da1745e9b549bd0bfa1a569971c77eba30cd5a4b87").unwrap());
1736                 } else if script_type == 3 {
1737                         target_value.append(&mut hex::decode("0016001479b000887626b294a914501a4cd226b58b235983").unwrap());
1738                 } else if script_type == 4 {
1739                         target_value.append(&mut hex::decode("002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc33260").unwrap());
1740                 }
1741                 assert_eq!(encoded_value, target_value);
1742         }
1743
1744         #[test]
1745         fn encoding_shutdown() {
1746                 do_encoding_shutdown(1);
1747                 do_encoding_shutdown(2);
1748                 do_encoding_shutdown(3);
1749                 do_encoding_shutdown(4);
1750         }
1751
1752         #[test]
1753         fn encoding_closing_signed() {
1754                 let secp_ctx = Secp256k1::new();
1755                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1756                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1757                 let closing_signed = msgs::ClosingSigned {
1758                         channel_id: [2; 32],
1759                         fee_satoshis: 2316138423780173,
1760                         signature: sig_1,
1761                 };
1762                 let encoded_value = closing_signed.encode();
1763                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034dd977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1764                 assert_eq!(encoded_value, target_value);
1765         }
1766
1767         #[test]
1768         fn encoding_update_add_htlc() {
1769                 let secp_ctx = Secp256k1::new();
1770                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1771                 let onion_routing_packet = msgs::OnionPacket {
1772                         version: 255,
1773                         public_key: Ok(pubkey_1),
1774                         hop_data: [1; 20*65],
1775                         hmac: [2; 32]
1776                 };
1777                 let update_add_htlc = msgs::UpdateAddHTLC {
1778                         channel_id: [2; 32],
1779                         htlc_id: 2316138423780173,
1780                         amount_msat: 3608586615801332854,
1781                         payment_hash: PaymentHash([1; 32]),
1782                         cltv_expiry: 821716,
1783                         onion_routing_packet
1784                 };
1785                 let encoded_value = update_add_htlc.encode();
1786                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d32144668701144760101010101010101010101010101010101010101010101010101010101010101000c89d4ff031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010202020202020202020202020202020202020202020202020202020202020202").unwrap();
1787                 assert_eq!(encoded_value, target_value);
1788         }
1789
1790         #[test]
1791         fn encoding_update_fulfill_htlc() {
1792                 let update_fulfill_htlc = msgs::UpdateFulfillHTLC {
1793                         channel_id: [2; 32],
1794                         htlc_id: 2316138423780173,
1795                         payment_preimage: PaymentPreimage([1; 32]),
1796                 };
1797                 let encoded_value = update_fulfill_htlc.encode();
1798                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d0101010101010101010101010101010101010101010101010101010101010101").unwrap();
1799                 assert_eq!(encoded_value, target_value);
1800         }
1801
1802         #[test]
1803         fn encoding_update_fail_htlc() {
1804                 let reason = OnionErrorPacket {
1805                         data: [1; 32].to_vec(),
1806                 };
1807                 let update_fail_htlc = msgs::UpdateFailHTLC {
1808                         channel_id: [2; 32],
1809                         htlc_id: 2316138423780173,
1810                         reason
1811                 };
1812                 let encoded_value = update_fail_htlc.encode();
1813                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d00200101010101010101010101010101010101010101010101010101010101010101").unwrap();
1814                 assert_eq!(encoded_value, target_value);
1815         }
1816
1817         #[test]
1818         fn encoding_update_fail_malformed_htlc() {
1819                 let update_fail_malformed_htlc = msgs::UpdateFailMalformedHTLC {
1820                         channel_id: [2; 32],
1821                         htlc_id: 2316138423780173,
1822                         sha256_of_onion: [1; 32],
1823                         failure_code: 255
1824                 };
1825                 let encoded_value = update_fail_malformed_htlc.encode();
1826                 let target_value = hex::decode("020202020202020202020202020202020202020202020202020202020202020200083a840000034d010101010101010101010101010101010101010101010101010101010101010100ff").unwrap();
1827                 assert_eq!(encoded_value, target_value);
1828         }
1829
1830         fn do_encoding_commitment_signed(htlcs: bool) {
1831                 let secp_ctx = Secp256k1::new();
1832                 let (privkey_1, _) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1833                 let (privkey_2, _) = get_keys_from!("0202020202020202020202020202020202020202020202020202020202020202", secp_ctx);
1834                 let (privkey_3, _) = get_keys_from!("0303030303030303030303030303030303030303030303030303030303030303", secp_ctx);
1835                 let (privkey_4, _) = get_keys_from!("0404040404040404040404040404040404040404040404040404040404040404", secp_ctx);
1836                 let sig_1 = get_sig_on!(privkey_1, secp_ctx, String::from("01010101010101010101010101010101"));
1837                 let sig_2 = get_sig_on!(privkey_2, secp_ctx, String::from("01010101010101010101010101010101"));
1838                 let sig_3 = get_sig_on!(privkey_3, secp_ctx, String::from("01010101010101010101010101010101"));
1839                 let sig_4 = get_sig_on!(privkey_4, secp_ctx, String::from("01010101010101010101010101010101"));
1840                 let commitment_signed = msgs::CommitmentSigned {
1841                         channel_id: [2; 32],
1842                         signature: sig_1,
1843                         htlc_signatures: if htlcs { vec![sig_2, sig_3, sig_4] } else { Vec::new() },
1844                 };
1845                 let encoded_value = commitment_signed.encode();
1846                 let mut target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202d977cb9b53d93a6ff64bb5f1e158b4094b66e798fb12911168a3ccdf80a83096340a6a95da0ae8d9f776528eecdbb747eb6b545495a4319ed5378e35b21e073a").unwrap();
1847                 if htlcs {
1848                         target_value.append(&mut hex::decode("00031735b6a427e80d5fe7cd90a2f4ee08dc9c27cda7c35a4172e5d85b12c49d4232537e98f9b1f3c5e6989a8b9644e90e8918127680dbd0d4043510840fc0f1e11a216c280b5395a2546e7e4b2663e04f811622f15a4f91e83aa2e92ba2a573c139142c54ae63072a1ec1ee7dc0c04bde5c847806172aa05c92c22ae8e308d1d2692b12cc195ce0a2d1bda6a88befa19fa07f51caa75ce83837f28965600b8aacab0855ffb0e741ec5f7c41421e9829a9d48611c8c831f71be5ea73e66594977ffd").unwrap());
1849                 } else {
1850                         target_value.append(&mut hex::decode("0000").unwrap());
1851                 }
1852                 assert_eq!(encoded_value, target_value);
1853         }
1854
1855         #[test]
1856         fn encoding_commitment_signed() {
1857                 do_encoding_commitment_signed(true);
1858                 do_encoding_commitment_signed(false);
1859         }
1860
1861         #[test]
1862         fn encoding_revoke_and_ack() {
1863                 let secp_ctx = Secp256k1::new();
1864                 let (_, pubkey_1) = get_keys_from!("0101010101010101010101010101010101010101010101010101010101010101", secp_ctx);
1865                 let raa = msgs::RevokeAndACK {
1866                         channel_id: [2; 32],
1867                         per_commitment_secret: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
1868                         next_per_commitment_point: pubkey_1,
1869                 };
1870                 let encoded_value = raa.encode();
1871                 let target_value = hex::decode("02020202020202020202020202020202020202020202020202020202020202020101010101010101010101010101010101010101010101010101010101010101031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f").unwrap();
1872                 assert_eq!(encoded_value, target_value);
1873         }
1874
1875         #[test]
1876         fn encoding_update_fee() {
1877                 let update_fee = msgs::UpdateFee {
1878                         channel_id: [2; 32],
1879                         feerate_per_kw: 20190119,
1880                 };
1881                 let encoded_value = update_fee.encode();
1882                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202013413a7").unwrap();
1883                 assert_eq!(encoded_value, target_value);
1884         }
1885
1886         #[test]
1887         fn encoding_init() {
1888                 assert_eq!(msgs::Init {
1889                         features: InitFeatures::from_le_bytes(vec![0xFF, 0xFF, 0xFF]),
1890                 }.encode(), hex::decode("00023fff0003ffffff").unwrap());
1891                 assert_eq!(msgs::Init {
1892                         features: InitFeatures::from_le_bytes(vec![0xFF]),
1893                 }.encode(), hex::decode("0001ff0001ff").unwrap());
1894                 assert_eq!(msgs::Init {
1895                         features: InitFeatures::from_le_bytes(vec![]),
1896                 }.encode(), hex::decode("00000000").unwrap());
1897         }
1898
1899         #[test]
1900         fn encoding_error() {
1901                 let error = msgs::ErrorMessage {
1902                         channel_id: [2; 32],
1903                         data: String::from("rust-lightning"),
1904                 };
1905                 let encoded_value = error.encode();
1906                 let target_value = hex::decode("0202020202020202020202020202020202020202020202020202020202020202000e727573742d6c696768746e696e67").unwrap();
1907                 assert_eq!(encoded_value, target_value);
1908         }
1909
1910         #[test]
1911         fn encoding_ping() {
1912                 let ping = msgs::Ping {
1913                         ponglen: 64,
1914                         byteslen: 64
1915                 };
1916                 let encoded_value = ping.encode();
1917                 let target_value = hex::decode("0040004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1918                 assert_eq!(encoded_value, target_value);
1919         }
1920
1921         #[test]
1922         fn encoding_pong() {
1923                 let pong = msgs::Pong {
1924                         byteslen: 64
1925                 };
1926                 let encoded_value = pong.encode();
1927                 let target_value = hex::decode("004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap();
1928                 assert_eq!(encoded_value, target_value);
1929         }
1930 }