Merge pull request #559 from ariard/2020-03-move-local-commitment
[rust-lightning] / lightning / src / ln / onchaintx.rs
1 //! The logic to build claims and bump in-flight transactions until confirmations.
2 //!
3 //! OnchainTxHandler objetcs are fully-part of ChannelMonitor and encapsulates all
4 //! building, tracking, bumping and notifications functions.
5
6 use bitcoin::blockdata::transaction::{Transaction, TxIn, TxOut, SigHashType};
7 use bitcoin::blockdata::transaction::OutPoint as BitcoinOutPoint;
8 use bitcoin::blockdata::script::Script;
9 use bitcoin::util::bip143;
10
11 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
12
13 use secp256k1::Secp256k1;
14 use secp256k1;
15
16 use ln::msgs::DecodeError;
17 use ln::channelmonitor::{ANTI_REORG_DELAY, CLTV_SHARED_CLAIM_BUFFER, InputMaterial, ClaimRequest};
18 use ln::channelmanager::PaymentPreimage;
19 use ln::chan_utils::{HTLCType, LocalCommitmentTransaction};
20 use chain::chaininterface::{FeeEstimator, BroadcasterInterface, ConfirmationTarget, MIN_RELAY_FEE_SAT_PER_1000_WEIGHT};
21 use chain::keysinterface::ChannelKeys;
22 use util::logger::Logger;
23 use util::ser::{ReadableArgs, Readable, Writer, Writeable};
24 use util::byte_utils;
25
26 use std::collections::{HashMap, hash_map};
27 use std::sync::Arc;
28 use std::cmp;
29 use std::ops::Deref;
30
31 const MAX_ALLOC_SIZE: usize = 64*1024;
32
33 /// Upon discovering of some classes of onchain tx by ChannelMonitor, we may have to take actions on it
34 /// once they mature to enough confirmations (ANTI_REORG_DELAY)
35 #[derive(Clone, PartialEq)]
36 enum OnchainEvent {
37         /// Outpoint under claim process by our own tx, once this one get enough confirmations, we remove it from
38         /// bump-txn candidate buffer.
39         Claim {
40                 claim_request: Sha256dHash,
41         },
42         /// Claim tx aggregate multiple claimable outpoints. One of the outpoint may be claimed by a remote party tx.
43         /// In this case, we need to drop the outpoint and regenerate a new claim tx. By safety, we keep tracking
44         /// the outpoint to be sure to resurect it back to the claim tx if reorgs happen.
45         ContentiousOutpoint {
46                 outpoint: BitcoinOutPoint,
47                 input_material: InputMaterial,
48         }
49 }
50
51 /// Higher-level cache structure needed to re-generate bumped claim txn if needed
52 #[derive(Clone, PartialEq)]
53 pub struct ClaimTxBumpMaterial {
54         // At every block tick, used to check if pending claiming tx is taking too
55         // much time for confirmation and we need to bump it.
56         height_timer: Option<u32>,
57         // Tracked in case of reorg to wipe out now-superflous bump material
58         feerate_previous: u64,
59         // Soonest timelocks among set of outpoints claimed, used to compute
60         // a priority of not feerate
61         soonest_timelock: u32,
62         // Cache of script, pubkey, sig or key to solve claimable outputs scriptpubkey.
63         per_input_material: HashMap<BitcoinOutPoint, InputMaterial>,
64 }
65
66 impl Writeable for ClaimTxBumpMaterial  {
67         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
68                 self.height_timer.write(writer)?;
69                 writer.write_all(&byte_utils::be64_to_array(self.feerate_previous))?;
70                 writer.write_all(&byte_utils::be32_to_array(self.soonest_timelock))?;
71                 writer.write_all(&byte_utils::be64_to_array(self.per_input_material.len() as u64))?;
72                 for (outp, tx_material) in self.per_input_material.iter() {
73                         outp.write(writer)?;
74                         tx_material.write(writer)?;
75                 }
76                 Ok(())
77         }
78 }
79
80 impl Readable for ClaimTxBumpMaterial {
81         fn read<R: ::std::io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
82                 let height_timer = Readable::read(reader)?;
83                 let feerate_previous = Readable::read(reader)?;
84                 let soonest_timelock = Readable::read(reader)?;
85                 let per_input_material_len: u64 = Readable::read(reader)?;
86                 let mut per_input_material = HashMap::with_capacity(cmp::min(per_input_material_len as usize, MAX_ALLOC_SIZE / 128));
87                 for _ in 0 ..per_input_material_len {
88                         let outpoint = Readable::read(reader)?;
89                         let input_material = Readable::read(reader)?;
90                         per_input_material.insert(outpoint, input_material);
91                 }
92                 Ok(Self { height_timer, feerate_previous, soonest_timelock, per_input_material })
93         }
94 }
95
96 #[derive(PartialEq)]
97 pub(super) enum InputDescriptors {
98         RevokedOfferedHTLC,
99         RevokedReceivedHTLC,
100         OfferedHTLC,
101         ReceivedHTLC,
102         RevokedOutput, // either a revoked to_local output on commitment tx, a revoked HTLC-Timeout output or a revoked HTLC-Success output
103 }
104
105 macro_rules! subtract_high_prio_fee {
106         ($self: ident, $fee_estimator: expr, $value: expr, $predicted_weight: expr, $used_feerate: expr) => {
107                 {
108                         $used_feerate = $fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority);
109                         let mut fee = $used_feerate * ($predicted_weight as u64) / 1000;
110                         if $value <= fee {
111                                 $used_feerate = $fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
112                                 fee = $used_feerate * ($predicted_weight as u64) / 1000;
113                                 if $value <= fee {
114                                         $used_feerate = $fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
115                                         fee = $used_feerate * ($predicted_weight as u64) / 1000;
116                                         if $value <= fee {
117                                                 log_error!($self, "Failed to generate an on-chain punishment tx as even low priority fee ({} sat) was more than the entire claim balance ({} sat)",
118                                                         fee, $value);
119                                                 false
120                                         } else {
121                                                 log_warn!($self, "Used low priority fee for on-chain punishment tx as high priority fee was more than the entire claim balance ({} sat)",
122                                                         $value);
123                                                 $value -= fee;
124                                                 true
125                                         }
126                                 } else {
127                                         log_warn!($self, "Used medium priority fee for on-chain punishment tx as high priority fee was more than the entire claim balance ({} sat)",
128                                                 $value);
129                                         $value -= fee;
130                                         true
131                                 }
132                         } else {
133                                 $value -= fee;
134                                 true
135                         }
136                 }
137         }
138 }
139
140
141 /// OnchainTxHandler receives claiming requests, aggregates them if it's sound, broadcast and
142 /// do RBF bumping if possible.
143 pub struct OnchainTxHandler<ChanSigner: ChannelKeys> {
144         destination_script: Script,
145         funding_redeemscript: Script,
146         local_commitment: Option<LocalCommitmentTransaction>,
147         prev_local_commitment: Option<LocalCommitmentTransaction>,
148         local_csv: u16,
149
150         key_storage: ChanSigner,
151
152         // Used to track claiming requests. If claim tx doesn't confirm before height timer expiration we need to bump
153         // it (RBF or CPFP). If an input has been part of an aggregate tx at first claim try, we need to keep it within
154         // another bumped aggregate tx to comply with RBF rules. We may have multiple claiming txn in the flight for the
155         // same set of outpoints. One of the outpoints may be spent by a transaction not issued by us. That's why at
156         // block connection we scan all inputs and if any of them is among a set of a claiming request we test for set
157         // equality between spending transaction and claim request. If true, it means transaction was one our claiming one
158         // after a security delay of 6 blocks we remove pending claim request. If false, it means transaction wasn't and
159         // we need to regenerate new claim request with reduced set of still-claimable outpoints.
160         // Key is identifier of the pending claim request, i.e the txid of the initial claiming transaction generated by
161         // us and is immutable until all outpoint of the claimable set are post-anti-reorg-delay solved.
162         // Entry is cache of elements need to generate a bumped claiming transaction (see ClaimTxBumpMaterial)
163         #[cfg(test)] // Used in functional_test to verify sanitization
164         pub pending_claim_requests: HashMap<Sha256dHash, ClaimTxBumpMaterial>,
165         #[cfg(not(test))]
166         pending_claim_requests: HashMap<Sha256dHash, ClaimTxBumpMaterial>,
167
168         // Used to link outpoints claimed in a connected block to a pending claim request.
169         // Key is outpoint than monitor parsing has detected we have keys/scripts to claim
170         // Value is (pending claim request identifier, confirmation_block), identifier
171         // is txid of the initial claiming transaction and is immutable until outpoint is
172         // post-anti-reorg-delay solved, confirmaiton_block is used to erase entry if
173         // block with output gets disconnected.
174         #[cfg(test)] // Used in functional_test to verify sanitization
175         pub claimable_outpoints: HashMap<BitcoinOutPoint, (Sha256dHash, u32)>,
176         #[cfg(not(test))]
177         claimable_outpoints: HashMap<BitcoinOutPoint, (Sha256dHash, u32)>,
178
179         onchain_events_waiting_threshold_conf: HashMap<u32, Vec<OnchainEvent>>,
180
181         secp_ctx: Secp256k1<secp256k1::All>,
182         logger: Arc<Logger>
183 }
184
185 impl<ChanSigner: ChannelKeys + Writeable> OnchainTxHandler<ChanSigner> {
186         pub(crate) fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
187                 self.destination_script.write(writer)?;
188                 self.funding_redeemscript.write(writer)?;
189                 self.local_commitment.write(writer)?;
190                 self.prev_local_commitment.write(writer)?;
191
192                 self.local_csv.write(writer)?;
193
194                 self.key_storage.write(writer)?;
195
196                 writer.write_all(&byte_utils::be64_to_array(self.pending_claim_requests.len() as u64))?;
197                 for (ref ancestor_claim_txid, claim_tx_data) in self.pending_claim_requests.iter() {
198                         ancestor_claim_txid.write(writer)?;
199                         claim_tx_data.write(writer)?;
200                 }
201
202                 writer.write_all(&byte_utils::be64_to_array(self.claimable_outpoints.len() as u64))?;
203                 for (ref outp, ref claim_and_height) in self.claimable_outpoints.iter() {
204                         outp.write(writer)?;
205                         claim_and_height.0.write(writer)?;
206                         claim_and_height.1.write(writer)?;
207                 }
208
209                 writer.write_all(&byte_utils::be64_to_array(self.onchain_events_waiting_threshold_conf.len() as u64))?;
210                 for (ref target, ref events) in self.onchain_events_waiting_threshold_conf.iter() {
211                         writer.write_all(&byte_utils::be32_to_array(**target))?;
212                         writer.write_all(&byte_utils::be64_to_array(events.len() as u64))?;
213                         for ev in events.iter() {
214                                 match *ev {
215                                         OnchainEvent::Claim { ref claim_request } => {
216                                                 writer.write_all(&[0; 1])?;
217                                                 claim_request.write(writer)?;
218                                         },
219                                         OnchainEvent::ContentiousOutpoint { ref outpoint, ref input_material } => {
220                                                 writer.write_all(&[1; 1])?;
221                                                 outpoint.write(writer)?;
222                                                 input_material.write(writer)?;
223                                         }
224                                 }
225                         }
226                 }
227                 Ok(())
228         }
229 }
230
231 impl<ChanSigner: ChannelKeys + Readable> ReadableArgs<Arc<Logger>> for OnchainTxHandler<ChanSigner> {
232         fn read<R: ::std::io::Read>(reader: &mut R, logger: Arc<Logger>) -> Result<Self, DecodeError> {
233                 let destination_script = Readable::read(reader)?;
234                 let funding_redeemscript = Readable::read(reader)?;
235
236                 let local_commitment = Readable::read(reader)?;
237                 let prev_local_commitment = Readable::read(reader)?;
238
239                 let local_csv = Readable::read(reader)?;
240
241                 let key_storage = Readable::read(reader)?;
242
243                 let pending_claim_requests_len: u64 = Readable::read(reader)?;
244                 let mut pending_claim_requests = HashMap::with_capacity(cmp::min(pending_claim_requests_len as usize, MAX_ALLOC_SIZE / 128));
245                 for _ in 0..pending_claim_requests_len {
246                         pending_claim_requests.insert(Readable::read(reader)?, Readable::read(reader)?);
247                 }
248
249                 let claimable_outpoints_len: u64 = Readable::read(reader)?;
250                 let mut claimable_outpoints = HashMap::with_capacity(cmp::min(pending_claim_requests_len as usize, MAX_ALLOC_SIZE / 128));
251                 for _ in 0..claimable_outpoints_len {
252                         let outpoint = Readable::read(reader)?;
253                         let ancestor_claim_txid = Readable::read(reader)?;
254                         let height = Readable::read(reader)?;
255                         claimable_outpoints.insert(outpoint, (ancestor_claim_txid, height));
256                 }
257                 let waiting_threshold_conf_len: u64 = Readable::read(reader)?;
258                 let mut onchain_events_waiting_threshold_conf = HashMap::with_capacity(cmp::min(waiting_threshold_conf_len as usize, MAX_ALLOC_SIZE / 128));
259                 for _ in 0..waiting_threshold_conf_len {
260                         let height_target = Readable::read(reader)?;
261                         let events_len: u64 = Readable::read(reader)?;
262                         let mut events = Vec::with_capacity(cmp::min(events_len as usize, MAX_ALLOC_SIZE / 128));
263                         for _ in 0..events_len {
264                                 let ev = match <u8 as Readable>::read(reader)? {
265                                         0 => {
266                                                 let claim_request = Readable::read(reader)?;
267                                                 OnchainEvent::Claim {
268                                                         claim_request
269                                                 }
270                                         },
271                                         1 => {
272                                                 let outpoint = Readable::read(reader)?;
273                                                 let input_material = Readable::read(reader)?;
274                                                 OnchainEvent::ContentiousOutpoint {
275                                                         outpoint,
276                                                         input_material
277                                                 }
278                                         }
279                                         _ => return Err(DecodeError::InvalidValue),
280                                 };
281                                 events.push(ev);
282                         }
283                         onchain_events_waiting_threshold_conf.insert(height_target, events);
284                 }
285
286                 Ok(OnchainTxHandler {
287                         destination_script,
288                         funding_redeemscript,
289                         local_commitment,
290                         prev_local_commitment,
291                         local_csv,
292                         key_storage,
293                         claimable_outpoints,
294                         pending_claim_requests,
295                         onchain_events_waiting_threshold_conf,
296                         secp_ctx: Secp256k1::new(),
297                         logger,
298                 })
299         }
300 }
301
302 impl<ChanSigner: ChannelKeys> OnchainTxHandler<ChanSigner> {
303         pub(super) fn new(destination_script: Script, keys: ChanSigner, funding_redeemscript: Script, local_csv: u16, logger: Arc<Logger>) -> Self {
304
305                 let key_storage = keys;
306
307                 OnchainTxHandler {
308                         destination_script,
309                         funding_redeemscript,
310                         local_commitment: None,
311                         prev_local_commitment: None,
312                         local_csv,
313                         key_storage,
314                         pending_claim_requests: HashMap::new(),
315                         claimable_outpoints: HashMap::new(),
316                         onchain_events_waiting_threshold_conf: HashMap::new(),
317
318                         secp_ctx: Secp256k1::new(),
319                         logger,
320                 }
321         }
322
323         pub(super) fn get_witnesses_weight(inputs: &[InputDescriptors]) -> usize {
324                 let mut tx_weight = 2; // count segwit flags
325                 for inp in inputs {
326                         // We use expected weight (and not actual) as signatures and time lock delays may vary
327                         tx_weight +=  match inp {
328                                 // number_of_witness_elements + sig_length + revocation_sig + pubkey_length + revocationpubkey + witness_script_length + witness_script
329                                 &InputDescriptors::RevokedOfferedHTLC => {
330                                         1 + 1 + 73 + 1 + 33 + 1 + 133
331                                 },
332                                 // number_of_witness_elements + sig_length + revocation_sig + pubkey_length + revocationpubkey + witness_script_length + witness_script
333                                 &InputDescriptors::RevokedReceivedHTLC => {
334                                         1 + 1 + 73 + 1 + 33 + 1 + 139
335                                 },
336                                 // number_of_witness_elements + sig_length + remotehtlc_sig  + preimage_length + preimage + witness_script_length + witness_script
337                                 &InputDescriptors::OfferedHTLC => {
338                                         1 + 1 + 73 + 1 + 32 + 1 + 133
339                                 },
340                                 // number_of_witness_elements + sig_length + revocation_sig + pubkey_length + revocationpubkey + witness_script_length + witness_script
341                                 &InputDescriptors::ReceivedHTLC => {
342                                         1 + 1 + 73 + 1 + 1 + 1 + 139
343                                 },
344                                 // number_of_witness_elements + sig_length + revocation_sig + true_length + op_true + witness_script_length + witness_script
345                                 &InputDescriptors::RevokedOutput => {
346                                         1 + 1 + 73 + 1 + 1 + 1 + 77
347                                 },
348                         };
349                 }
350                 tx_weight
351         }
352
353         /// In LN, output claimed are time-sensitive, which means we have to spend them before reaching some timelock expiration. At in-channel
354         /// output detection, we generate a first version of a claim tx and associate to it a height timer. A height timer is an absolute block
355         /// height than once reached we should generate a new bumped "version" of the claim tx to be sure than we safely claim outputs before
356         /// than our counterparty can do it too. If timelock expires soon, height timer is going to be scale down in consequence to increase
357         /// frequency of the bump and so increase our bets of success.
358         fn get_height_timer(current_height: u32, timelock_expiration: u32) -> u32 {
359                 if timelock_expiration <= current_height + 3 {
360                         return current_height + 1
361                 } else if timelock_expiration - current_height <= 15 {
362                         return current_height + 3
363                 }
364                 current_height + 15
365         }
366
367         /// Lightning security model (i.e being able to redeem/timeout HTLC or penalize coutnerparty onchain) lays on the assumption of claim transactions getting confirmed before timelock expiration
368         /// (CSV or CLTV following cases). In case of high-fee spikes, claim tx may stuck in the mempool, so you need to bump its feerate quickly using Replace-By-Fee or Child-Pay-For-Parent.
369         fn generate_claim_tx<F: Deref>(&mut self, height: u32, cached_claim_datas: &ClaimTxBumpMaterial, fee_estimator: F) -> Option<(Option<u32>, u64, Transaction)>
370                 where F::Target: FeeEstimator
371         {
372                 if cached_claim_datas.per_input_material.len() == 0 { return None } // But don't prune pending claiming request yet, we may have to resurrect HTLCs
373                 let mut inputs = Vec::new();
374                 for outp in cached_claim_datas.per_input_material.keys() {
375                         log_trace!(self, "Outpoint {}:{}", outp.txid, outp.vout);
376                         inputs.push(TxIn {
377                                 previous_output: *outp,
378                                 script_sig: Script::new(),
379                                 sequence: 0xfffffffd,
380                                 witness: Vec::new(),
381                         });
382                 }
383                 let mut bumped_tx = Transaction {
384                         version: 2,
385                         lock_time: 0,
386                         input: inputs,
387                         output: vec![TxOut {
388                                 script_pubkey: self.destination_script.clone(),
389                                 value: 0
390                         }],
391                 };
392
393                 macro_rules! RBF_bump {
394                         ($amount: expr, $old_feerate: expr, $fee_estimator: expr, $predicted_weight: expr) => {
395                                 {
396                                         let mut used_feerate;
397                                         // If old feerate inferior to actual one given back by Fee Estimator, use it to compute new fee...
398                                         let new_fee = if $old_feerate < $fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) {
399                                                 let mut value = $amount;
400                                                 if subtract_high_prio_fee!(self, $fee_estimator, value, $predicted_weight, used_feerate) {
401                                                         // Overflow check is done in subtract_high_prio_fee
402                                                         $amount - value
403                                                 } else {
404                                                         log_trace!(self, "Can't new-estimation bump new claiming tx, amount {} is too small", $amount);
405                                                         return None;
406                                                 }
407                                         // ...else just increase the previous feerate by 25% (because that's a nice number)
408                                         } else {
409                                                 let fee = $old_feerate * $predicted_weight / 750;
410                                                 if $amount <= fee {
411                                                         log_trace!(self, "Can't 25% bump new claiming tx, amount {} is too small", $amount);
412                                                         return None;
413                                                 }
414                                                 fee
415                                         };
416
417                                         let previous_fee = $old_feerate * $predicted_weight / 1000;
418                                         let min_relay_fee = MIN_RELAY_FEE_SAT_PER_1000_WEIGHT * $predicted_weight / 1000;
419                                         // BIP 125 Opt-in Full Replace-by-Fee Signaling
420                                         //      * 3. The replacement transaction pays an absolute fee of at least the sum paid by the original transactions.
421                                         //      * 4. The replacement transaction must also pay for its own bandwidth at or above the rate set by the node's minimum relay fee setting.
422                                         let new_fee = if new_fee < previous_fee + min_relay_fee {
423                                                 new_fee + previous_fee + min_relay_fee - new_fee
424                                         } else {
425                                                 new_fee
426                                         };
427                                         Some((new_fee, new_fee * 1000 / $predicted_weight))
428                                 }
429                         }
430                 }
431
432                 // Compute new height timer to decide when we need to regenerate a new bumped version of the claim tx (if we
433                 // didn't receive confirmation of it before, or not enough reorg-safe depth on top of it).
434                 let new_timer = Some(Self::get_height_timer(height, cached_claim_datas.soonest_timelock));
435                 let mut inputs_witnesses_weight = 0;
436                 let mut amt = 0;
437                 let mut dynamic_fee = true;
438                 for per_outp_material in cached_claim_datas.per_input_material.values() {
439                         match per_outp_material {
440                                 &InputMaterial::Revoked { ref witness_script, ref is_htlc, ref amount, .. } => {
441                                         inputs_witnesses_weight += Self::get_witnesses_weight(if !is_htlc { &[InputDescriptors::RevokedOutput] } else if HTLCType::scriptlen_to_htlctype(witness_script.len()) == Some(HTLCType::OfferedHTLC) { &[InputDescriptors::RevokedOfferedHTLC] } else if HTLCType::scriptlen_to_htlctype(witness_script.len()) == Some(HTLCType::AcceptedHTLC) { &[InputDescriptors::RevokedReceivedHTLC] } else { unreachable!() });
442                                         amt += *amount;
443                                 },
444                                 &InputMaterial::RemoteHTLC { ref preimage, ref amount, .. } => {
445                                         inputs_witnesses_weight += Self::get_witnesses_weight(if preimage.is_some() { &[InputDescriptors::OfferedHTLC] } else { &[InputDescriptors::ReceivedHTLC] });
446                                         amt += *amount;
447                                 },
448                                 &InputMaterial::LocalHTLC { .. } => {
449                                         dynamic_fee = false;
450                                 },
451                                 &InputMaterial::Funding { .. } => {
452                                         dynamic_fee = false;
453                                 }
454                         }
455                 }
456                 if dynamic_fee {
457                         let predicted_weight = bumped_tx.get_weight() + inputs_witnesses_weight;
458                         let mut new_feerate;
459                         // If old feerate is 0, first iteration of this claim, use normal fee calculation
460                         if cached_claim_datas.feerate_previous != 0 {
461                                 if let Some((new_fee, feerate)) = RBF_bump!(amt, cached_claim_datas.feerate_previous, fee_estimator, predicted_weight as u64) {
462                                         // If new computed fee is superior at the whole claimable amount burn all in fees
463                                         if new_fee > amt {
464                                                 bumped_tx.output[0].value = 0;
465                                         } else {
466                                                 bumped_tx.output[0].value = amt - new_fee;
467                                         }
468                                         new_feerate = feerate;
469                                 } else { return None; }
470                         } else {
471                                 if subtract_high_prio_fee!(self, fee_estimator, amt, predicted_weight, new_feerate) {
472                                         bumped_tx.output[0].value = amt;
473                                 } else { return None; }
474                         }
475                         assert!(new_feerate != 0);
476
477                         for (i, (outp, per_outp_material)) in cached_claim_datas.per_input_material.iter().enumerate() {
478                                 match per_outp_material {
479                                         &InputMaterial::Revoked { ref witness_script, ref pubkey, ref key, ref is_htlc, ref amount } => {
480                                                 let sighash_parts = bip143::SighashComponents::new(&bumped_tx);
481                                                 let sighash = hash_to_message!(&sighash_parts.sighash_all(&bumped_tx.input[i], &witness_script, *amount)[..]);
482                                                 let sig = self.secp_ctx.sign(&sighash, &key);
483                                                 bumped_tx.input[i].witness.push(sig.serialize_der().to_vec());
484                                                 bumped_tx.input[i].witness[0].push(SigHashType::All as u8);
485                                                 if *is_htlc {
486                                                         bumped_tx.input[i].witness.push(pubkey.unwrap().clone().serialize().to_vec());
487                                                 } else {
488                                                         bumped_tx.input[i].witness.push(vec!(1));
489                                                 }
490                                                 bumped_tx.input[i].witness.push(witness_script.clone().into_bytes());
491                                                 log_trace!(self, "Going to broadcast Penalty Transaction {} claiming revoked {} output {} from {} with new feerate {}...", bumped_tx.txid(), if !is_htlc { "to_local" } else if HTLCType::scriptlen_to_htlctype(witness_script.len()) == Some(HTLCType::OfferedHTLC) { "offered" } else if HTLCType::scriptlen_to_htlctype(witness_script.len()) == Some(HTLCType::AcceptedHTLC) { "received" } else { "" }, outp.vout, outp.txid, new_feerate);
492                                         },
493                                         &InputMaterial::RemoteHTLC { ref witness_script, ref key, ref preimage, ref amount, ref locktime } => {
494                                                 if !preimage.is_some() { bumped_tx.lock_time = *locktime }; // Right now we don't aggregate time-locked transaction, if we do we should set lock_time before to avoid breaking hash computation
495                                                 let sighash_parts = bip143::SighashComponents::new(&bumped_tx);
496                                                 let sighash = hash_to_message!(&sighash_parts.sighash_all(&bumped_tx.input[i], &witness_script, *amount)[..]);
497                                                 let sig = self.secp_ctx.sign(&sighash, &key);
498                                                 bumped_tx.input[i].witness.push(sig.serialize_der().to_vec());
499                                                 bumped_tx.input[i].witness[0].push(SigHashType::All as u8);
500                                                 if let &Some(preimage) = preimage {
501                                                         bumped_tx.input[i].witness.push(preimage.clone().0.to_vec());
502                                                 } else {
503                                                         bumped_tx.input[i].witness.push(vec![]);
504                                                 }
505                                                 bumped_tx.input[i].witness.push(witness_script.clone().into_bytes());
506                                                 log_trace!(self, "Going to broadcast Claim Transaction {} claiming remote {} htlc output {} from {} with new feerate {}...", bumped_tx.txid(), if preimage.is_some() { "offered" } else { "received" }, outp.vout, outp.txid, new_feerate);
507                                         },
508                                         _ => unreachable!()
509                                 }
510                         }
511                         log_trace!(self, "...with timer {}", new_timer.unwrap());
512                         assert!(predicted_weight >= bumped_tx.get_weight());
513                         return Some((new_timer, new_feerate, bumped_tx))
514                 } else {
515                         for (_, (outp, per_outp_material)) in cached_claim_datas.per_input_material.iter().enumerate() {
516                                 match per_outp_material {
517                                         &InputMaterial::LocalHTLC { ref preimage, ref amount } => {
518                                                 let mut htlc_tx = None;
519                                                 if let Some(ref mut local_commitment) = self.local_commitment {
520                                                         if local_commitment.txid() == outp.txid {
521                                                                 self.key_storage.sign_htlc_transaction(local_commitment, outp.vout, *preimage, self.local_csv, &self.secp_ctx);
522                                                                 htlc_tx = local_commitment.htlc_with_valid_witness(outp.vout).clone();
523                                                         }
524                                                 }
525                                                 if let Some(ref mut prev_local_commitment) = self.prev_local_commitment {
526                                                         if prev_local_commitment.txid() == outp.txid {
527                                                                 self.key_storage.sign_htlc_transaction(prev_local_commitment, outp.vout, *preimage, self.local_csv, &self.secp_ctx);
528                                                                 htlc_tx = prev_local_commitment.htlc_with_valid_witness(outp.vout).clone();
529                                                         }
530                                                 }
531                                                 if let Some(htlc_tx) = htlc_tx {
532                                                         let feerate = (amount - htlc_tx.output[0].value) * 1000 / htlc_tx.get_weight() as u64;
533                                                         // Timer set to $NEVER given we can't bump tx without anchor outputs
534                                                         log_trace!(self, "Going to broadcast Local HTLC-{} claiming HTLC output {} from {}...", if preimage.is_some() { "Success" } else { "Timeout" }, outp.vout, outp.txid);
535                                                         return Some((None, feerate, htlc_tx));
536                                                 }
537                                                 return None;
538                                         },
539                                         &InputMaterial::Funding { ref channel_value } => {
540                                                 let signed_tx = self.get_fully_signed_local_tx(*channel_value).unwrap();
541                                                 let mut amt_outputs = 0;
542                                                 for outp in signed_tx.output.iter() {
543                                                         amt_outputs += outp.value;
544                                                 }
545                                                 let feerate = (channel_value - amt_outputs) * 1000 / signed_tx.get_weight() as u64;
546                                                 // Timer set to $NEVER given we can't bump tx without anchor outputs
547                                                 log_trace!(self, "Going to broadcast Local Transaction {} claiming funding output {} from {}...", signed_tx.txid(), outp.vout, outp.txid);
548                                                 return Some((None, feerate, signed_tx));
549                                         }
550                                         _ => unreachable!()
551                                 }
552                         }
553                 }
554                 None
555         }
556
557         pub(super) fn block_connected<B: Deref, F: Deref>(&mut self, txn_matched: &[&Transaction], claimable_outpoints: Vec<ClaimRequest>, height: u32, broadcaster: B, fee_estimator: F)
558                 where B::Target: BroadcasterInterface,
559                       F::Target: FeeEstimator
560         {
561                 log_trace!(self, "Block at height {} connected with {} claim requests", height, claimable_outpoints.len());
562                 let mut new_claims = Vec::new();
563                 let mut aggregated_claim = HashMap::new();
564                 let mut aggregated_soonest = ::std::u32::MAX;
565
566                 // Try to aggregate outputs if their timelock expiration isn't imminent (absolute_timelock
567                 // <= CLTV_SHARED_CLAIM_BUFFER) and they don't require an immediate nLockTime (aggregable).
568                 for req in claimable_outpoints {
569                         // Don't claim a outpoint twice that would be bad for privacy and may uselessly lock a CPFP input for a while
570                         if let Some(_) = self.claimable_outpoints.get(&req.outpoint) { log_trace!(self, "Bouncing off outpoint {}:{}, already registered its claiming request", req.outpoint.txid, req.outpoint.vout); } else {
571                                 log_trace!(self, "Test if outpoint can be aggregated with expiration {} against {}", req.absolute_timelock, height + CLTV_SHARED_CLAIM_BUFFER);
572                                 if req.absolute_timelock <= height + CLTV_SHARED_CLAIM_BUFFER || !req.aggregable { // Don't aggregate if outpoint absolute timelock is soon or marked as non-aggregable
573                                         let mut single_input = HashMap::new();
574                                         single_input.insert(req.outpoint, req.witness_data);
575                                         new_claims.push((req.absolute_timelock, single_input));
576                                 } else {
577                                         aggregated_claim.insert(req.outpoint, req.witness_data);
578                                         if req.absolute_timelock < aggregated_soonest {
579                                                 aggregated_soonest = req.absolute_timelock;
580                                         }
581                                 }
582                         }
583                 }
584                 new_claims.push((aggregated_soonest, aggregated_claim));
585
586                 // Generate claim transactions and track them to bump if necessary at
587                 // height timer expiration (i.e in how many blocks we're going to take action).
588                 for claim in new_claims {
589                         let mut claim_material = ClaimTxBumpMaterial { height_timer: None, feerate_previous: 0, soonest_timelock: claim.0, per_input_material: claim.1.clone() };
590                         if let Some((new_timer, new_feerate, tx)) = self.generate_claim_tx(height, &claim_material, &*fee_estimator) {
591                                 claim_material.height_timer = new_timer;
592                                 claim_material.feerate_previous = new_feerate;
593                                 let txid = tx.txid();
594                                 self.pending_claim_requests.insert(txid, claim_material);
595                                 for k in claim.1.keys() {
596                                         log_trace!(self, "Registering claiming request for {}:{}", k.txid, k.vout);
597                                         self.claimable_outpoints.insert(k.clone(), (txid, height));
598                                 }
599                                 log_trace!(self, "Broadcast onchain {}", log_tx!(tx));
600                                 broadcaster.broadcast_transaction(&tx);
601                         }
602                 }
603
604                 let mut bump_candidates = HashMap::new();
605                 for tx in txn_matched {
606                         // Scan all input to verify is one of the outpoint spent is of interest for us
607                         let mut claimed_outputs_material = Vec::new();
608                         for inp in &tx.input {
609                                 if let Some(first_claim_txid_height) = self.claimable_outpoints.get(&inp.previous_output) {
610                                         // If outpoint has claim request pending on it...
611                                         if let Some(claim_material) = self.pending_claim_requests.get_mut(&first_claim_txid_height.0) {
612                                                 //... we need to verify equality between transaction outpoints and claim request
613                                                 // outpoints to know if transaction is the original claim or a bumped one issued
614                                                 // by us.
615                                                 let mut set_equality = true;
616                                                 if claim_material.per_input_material.len() != tx.input.len() {
617                                                         set_equality = false;
618                                                 } else {
619                                                         for (claim_inp, tx_inp) in claim_material.per_input_material.keys().zip(tx.input.iter()) {
620                                                                 if *claim_inp != tx_inp.previous_output {
621                                                                         set_equality = false;
622                                                                 }
623                                                         }
624                                                 }
625
626                                                 macro_rules! clean_claim_request_after_safety_delay {
627                                                         () => {
628                                                                 let new_event = OnchainEvent::Claim { claim_request: first_claim_txid_height.0.clone() };
629                                                                 match self.onchain_events_waiting_threshold_conf.entry(height + ANTI_REORG_DELAY - 1) {
630                                                                         hash_map::Entry::Occupied(mut entry) => {
631                                                                                 if !entry.get().contains(&new_event) {
632                                                                                         entry.get_mut().push(new_event);
633                                                                                 }
634                                                                         },
635                                                                         hash_map::Entry::Vacant(entry) => {
636                                                                                 entry.insert(vec![new_event]);
637                                                                         }
638                                                                 }
639                                                         }
640                                                 }
641
642                                                 // If this is our transaction (or our counterparty spent all the outputs
643                                                 // before we could anyway with same inputs order than us), wait for
644                                                 // ANTI_REORG_DELAY and clean the RBF tracking map.
645                                                 if set_equality {
646                                                         clean_claim_request_after_safety_delay!();
647                                                 } else { // If false, generate new claim request with update outpoint set
648                                                         let mut at_least_one_drop = false;
649                                                         for input in tx.input.iter() {
650                                                                 if let Some(input_material) = claim_material.per_input_material.remove(&input.previous_output) {
651                                                                         claimed_outputs_material.push((input.previous_output, input_material));
652                                                                         at_least_one_drop = true;
653                                                                 }
654                                                                 // If there are no outpoints left to claim in this request, drop it entirely after ANTI_REORG_DELAY.
655                                                                 if claim_material.per_input_material.is_empty() {
656                                                                         clean_claim_request_after_safety_delay!();
657                                                                 }
658                                                         }
659                                                         //TODO: recompute soonest_timelock to avoid wasting a bit on fees
660                                                         if at_least_one_drop {
661                                                                 bump_candidates.insert(first_claim_txid_height.0.clone(), claim_material.clone());
662                                                         }
663                                                 }
664                                                 break; //No need to iterate further, either tx is our or their
665                                         } else {
666                                                 panic!("Inconsistencies between pending_claim_requests map and claimable_outpoints map");
667                                         }
668                                 }
669                         }
670                         for (outpoint, input_material) in claimed_outputs_material.drain(..) {
671                                 let new_event = OnchainEvent::ContentiousOutpoint { outpoint, input_material };
672                                 match self.onchain_events_waiting_threshold_conf.entry(height + ANTI_REORG_DELAY - 1) {
673                                         hash_map::Entry::Occupied(mut entry) => {
674                                                 if !entry.get().contains(&new_event) {
675                                                         entry.get_mut().push(new_event);
676                                                 }
677                                         },
678                                         hash_map::Entry::Vacant(entry) => {
679                                                 entry.insert(vec![new_event]);
680                                         }
681                                 }
682                         }
683                 }
684
685                 // After security delay, either our claim tx got enough confs or outpoint is definetely out of reach
686                 if let Some(events) = self.onchain_events_waiting_threshold_conf.remove(&height) {
687                         for ev in events {
688                                 match ev {
689                                         OnchainEvent::Claim { claim_request } => {
690                                                 // We may remove a whole set of claim outpoints here, as these one may have
691                                                 // been aggregated in a single tx and claimed so atomically
692                                                 if let Some(bump_material) = self.pending_claim_requests.remove(&claim_request) {
693                                                         for outpoint in bump_material.per_input_material.keys() {
694                                                                 self.claimable_outpoints.remove(&outpoint);
695                                                         }
696                                                 }
697                                         },
698                                         OnchainEvent::ContentiousOutpoint { outpoint, .. } => {
699                                                 self.claimable_outpoints.remove(&outpoint);
700                                         }
701                                 }
702                         }
703                 }
704
705                 // Check if any pending claim request must be rescheduled
706                 for (first_claim_txid, ref claim_data) in self.pending_claim_requests.iter() {
707                         if let Some(h) = claim_data.height_timer {
708                                 if h == height {
709                                         bump_candidates.insert(*first_claim_txid, (*claim_data).clone());
710                                 }
711                         }
712                 }
713
714                 // Build, bump and rebroadcast tx accordingly
715                 log_trace!(self, "Bumping {} candidates", bump_candidates.len());
716                 let mut pending_claim_updates = Vec::with_capacity(bump_candidates.len());
717                 for (first_claim_txid, claim_material) in bump_candidates.iter() {
718                         if let Some((new_timer, new_feerate, bump_tx)) = self.generate_claim_tx(height, &claim_material, &*fee_estimator) {
719                                 log_trace!(self, "Broadcast onchain {}", log_tx!(bump_tx));
720                                 broadcaster.broadcast_transaction(&bump_tx);
721                                 pending_claim_updates.push((*first_claim_txid, new_timer, new_feerate));
722                         }
723                 }
724                 for updates in pending_claim_updates {
725                         if let Some(claim_material) = self.pending_claim_requests.get_mut(&updates.0) {
726                                 claim_material.height_timer = updates.1;
727                                 claim_material.feerate_previous = updates.2;
728                         }
729                 }
730         }
731
732         pub(super) fn block_disconnected<B: Deref, F: Deref>(&mut self, height: u32, broadcaster: B, fee_estimator: F)
733                 where B::Target: BroadcasterInterface,
734                       F::Target: FeeEstimator
735         {
736                 let mut bump_candidates = HashMap::new();
737                 if let Some(events) = self.onchain_events_waiting_threshold_conf.remove(&(height + ANTI_REORG_DELAY - 1)) {
738                         //- our claim tx on a commitment tx output
739                         //- resurect outpoint back in its claimable set and regenerate tx
740                         for ev in events {
741                                 match ev {
742                                         OnchainEvent::ContentiousOutpoint { outpoint, input_material } => {
743                                                 if let Some(ancestor_claimable_txid) = self.claimable_outpoints.get(&outpoint) {
744                                                         if let Some(claim_material) = self.pending_claim_requests.get_mut(&ancestor_claimable_txid.0) {
745                                                                 claim_material.per_input_material.insert(outpoint, input_material);
746                                                                 // Using a HashMap guarantee us than if we have multiple outpoints getting
747                                                                 // resurrected only one bump claim tx is going to be broadcast
748                                                                 bump_candidates.insert(ancestor_claimable_txid.clone(), claim_material.clone());
749                                                         }
750                                                 }
751                                         },
752                                         _ => {},
753                                 }
754                         }
755                 }
756                 for (_, claim_material) in bump_candidates.iter_mut() {
757                         if let Some((new_timer, new_feerate, bump_tx)) = self.generate_claim_tx(height, &claim_material, &*fee_estimator) {
758                                 claim_material.height_timer = new_timer;
759                                 claim_material.feerate_previous = new_feerate;
760                                 broadcaster.broadcast_transaction(&bump_tx);
761                         }
762                 }
763                 for (ancestor_claim_txid, claim_material) in bump_candidates.drain() {
764                         self.pending_claim_requests.insert(ancestor_claim_txid.0, claim_material);
765                 }
766                 //TODO: if we implement cross-block aggregated claim transaction we need to refresh set of outpoints and regenerate tx but
767                 // right now if one of the outpoint get disconnected, just erase whole pending claim request.
768                 let mut remove_request = Vec::new();
769                 self.claimable_outpoints.retain(|_, ref v|
770                         if v.1 == height {
771                         remove_request.push(v.0.clone());
772                         false
773                         } else { true });
774                 for req in remove_request {
775                         self.pending_claim_requests.remove(&req);
776                 }
777         }
778
779         pub(super) fn provide_latest_local_tx(&mut self, tx: LocalCommitmentTransaction) -> Result<(), ()> {
780                 // To prevent any unsafe state discrepancy between offchain and onchain, once local
781                 // commitment transaction has been signed due to an event (either block height for
782                 // HTLC-timeout or channel force-closure), don't allow any further update of local
783                 // commitment transaction view to avoid delivery of revocation secret to counterparty
784                 // for the aformentionned signed transaction.
785                 if let Some(ref local_commitment) = self.local_commitment {
786                         if local_commitment.has_local_sig() { return Err(()) }
787                 }
788                 self.prev_local_commitment = self.local_commitment.take();
789                 self.local_commitment = Some(tx);
790                 Ok(())
791         }
792
793         //TODO: getting lastest local transactions should be infaillible and result in us "force-closing the channel", but we may
794         // have empty local commitment transaction if a ChannelMonitor is asked to force-close just after Channel::get_outbound_funding_created,
795         // before providing a initial commitment transaction. For outbound channel, init ChannelMonitor at Channel::funding_signed, there is nothing
796         // to monitor before.
797         pub(super) fn get_fully_signed_local_tx(&mut self, channel_value_satoshis: u64) -> Option<Transaction> {
798                 if let Some(ref mut local_commitment) = self.local_commitment {
799                         self.key_storage.sign_local_commitment(local_commitment, &self.funding_redeemscript, channel_value_satoshis, &self.secp_ctx);
800                         return Some(local_commitment.with_valid_witness().clone());
801                 }
802                 None
803         }
804
805         #[cfg(test)]
806         pub(super) fn get_fully_signed_copy_local_tx(&mut self, channel_value_satoshis: u64) -> Option<Transaction> {
807                 if let Some(ref mut local_commitment) = self.local_commitment {
808                         let mut local_commitment = local_commitment.clone();
809                         self.key_storage.unsafe_sign_local_commitment(&mut local_commitment, &self.funding_redeemscript, channel_value_satoshis, &self.secp_ctx);
810                         return Some(local_commitment.with_valid_witness().clone());
811                 }
812                 None
813         }
814
815         pub(super) fn get_fully_signed_htlc_tx(&mut self, txid: Sha256dHash, htlc_index: u32, preimage: Option<PaymentPreimage>) -> Option<Transaction> {
816                 //TODO: store preimage in OnchainTxHandler
817                 if let Some(ref mut local_commitment) = self.local_commitment {
818                         if local_commitment.txid() == txid {
819                                 self.key_storage.sign_htlc_transaction(local_commitment, htlc_index, preimage, self.local_csv, &self.secp_ctx);
820                                 return local_commitment.htlc_with_valid_witness(htlc_index).clone();
821                         }
822                 }
823                 None
824         }
825 }