_ Git - rust-lightning/blob - lightning/src/ln/peer_handler.rs

   1 //! Top level peer message handling and socket handling logic lives here.
   2 //!
   3 //! Instead of actually servicing sockets ourselves we require that you implement the
   4 //! SocketDescriptor interface and use that to receive actions which you should perform on the
   5 //! socket, and call into PeerManager with bytes read from the socket. The PeerManager will then
   6 //! call into the provided message handlers (probably a ChannelManager and Router) with messages
   7 //! they should handle, and encoding/sending response messages.
   8
   9 use bitcoin::secp256k1::key::{SecretKey,PublicKey};
  10
  11 use ln::features::InitFeatures;
  12 use ln::msgs;
  13 use ln::msgs::ChannelMessageHandler;
  14 use ln::channelmanager::{SimpleArcChannelManager, SimpleRefChannelManager};
  15 use util::ser::VecWriter;
  16 use ln::peer_channel_encryptor::{PeerChannelEncryptor,NextNoiseStep};
  17 use ln::wire;
  18 use ln::wire::Encode;
  19 use util::byte_utils;
  20 use util::events::{MessageSendEvent, MessageSendEventsProvider};
  21 use util::logger::Logger;
  22
  23 use std::collections::{HashMap,hash_map,HashSet,LinkedList};
  24 use std::sync::{Arc, Mutex};
  25 use std::sync::atomic::{AtomicUsize, Ordering};
  26 use std::{cmp,error,hash,fmt};
  27 use std::ops::Deref;
  28
  29 use bitcoin::hashes::sha256::Hash as Sha256;
  30 use bitcoin::hashes::sha256::HashEngine as Sha256Engine;
  31 use bitcoin::hashes::{HashEngine, Hash};
  32
  33 /// Provides references to trait impls which handle different types of messages.
  34 pub struct MessageHandler<CM: Deref> where CM::Target: msgs::ChannelMessageHandler {
  35         /// A message handler which handles messages specific to channels. Usually this is just a
  36         /// ChannelManager object.
  37         pub chan_handler: CM,
  38         /// A message handler which handles messages updating our knowledge of the network channel
  39         /// graph. Usually this is just a Router object.
  40         pub route_handler: Arc<msgs::RoutingMessageHandler>,
  41 }
  42
  43 /// Provides an object which can be used to send data to and which uniquely identifies a connection
  44 /// to a remote host. You will need to be able to generate multiple of these which meet Eq and
  45 /// implement Hash to meet the PeerManager API.
  46 ///
  47 /// For efficiency, Clone should be relatively cheap for this type.
  48 ///
  49 /// You probably want to just extend an int and put a file descriptor in a struct and implement
  50 /// send_data. Note that if you are using a higher-level net library that may call close() itself,
  51 /// be careful to ensure you don't have races whereby you might register a new connection with an
  52 /// fd which is the same as a previous one which has yet to be removed via
  53 /// PeerManager::socket_disconnected().
  54 pub trait SocketDescriptor : cmp::Eq + hash::Hash + Clone {
  55         /// Attempts to send some data from the given slice to the peer.
  56         ///
  57         /// Returns the amount of data which was sent, possibly 0 if the socket has since disconnected.
  58         /// Note that in the disconnected case, socket_disconnected must still fire and further write
  59         /// attempts may occur until that time.
  60         ///
  61         /// If the returned size is smaller than data.len(), a write_available event must
  62         /// trigger the next time more data can be written. Additionally, until the a send_data event
  63         /// completes fully, no further read_events should trigger on the same peer!
  64         ///
  65         /// If a read_event on this descriptor had previously returned true (indicating that read
  66         /// events should be paused to prevent DoS in the send buffer), resume_read may be set
  67         /// indicating that read events on this descriptor should resume. A resume_read of false does
  68         /// *not* imply that further read events should be paused.
  69         fn send_data(&mut self, data: &[u8], resume_read: bool) -> usize;
  70         /// Disconnect the socket pointed to by this SocketDescriptor. Once this function returns, no
  71         /// more calls to write_buffer_space_avail, read_event or socket_disconnected may be made with
  72         /// this descriptor. No socket_disconnected call should be generated as a result of this call,
  73         /// though races may occur whereby disconnect_socket is called after a call to
  74         /// socket_disconnected but prior to socket_disconnected returning.
  75         fn disconnect_socket(&mut self);
  76 }
  77
  78 /// Error for PeerManager errors. If you get one of these, you must disconnect the socket and
  79 /// generate no further read_event/write_buffer_space_avail calls for the descriptor, only
  80 /// triggering a single socket_disconnected call (unless it was provided in response to a
  81 /// new_*_connection event, in which case no such socket_disconnected() must be called and the
  82 /// socket silently disconencted).
  83 pub struct PeerHandleError {
  84         /// Used to indicate that we probably can't make any future connections to this peer, implying
  85         /// we should go ahead and force-close any channels we have with it.
  86         no_connection_possible: bool,
  87 }
  88 impl fmt::Debug for PeerHandleError {
  89         fn fmt(&self, formatter: &mut fmt::Formatter) -> Result<(), fmt::Error> {
  90                 formatter.write_str("Peer Sent Invalid Data")
  91         }
  92 }
  93 impl fmt::Display for PeerHandleError {
  94         fn fmt(&self, formatter: &mut fmt::Formatter) -> Result<(), fmt::Error> {
  95                 formatter.write_str("Peer Sent Invalid Data")
  96         }
  97 }
  98 impl error::Error for PeerHandleError {
  99         fn description(&self) -> &str {
 100                 "Peer Sent Invalid Data"
 101         }
 102 }
 103
 104 enum InitSyncTracker{
 105         NoSyncRequested,
 106         ChannelsSyncing(u64),
 107         NodesSyncing(PublicKey),
 108 }
 109
 110 struct Peer {
 111         channel_encryptor: PeerChannelEncryptor,
 112         outbound: bool,
 113         their_node_id: Option<PublicKey>,
 114         their_features: Option<InitFeatures>,
 115
 116         pending_outbound_buffer: LinkedList<Vec<u8>>,
 117         pending_outbound_buffer_first_msg_offset: usize,
 118         awaiting_write_event: bool,
 119
 120         pending_read_buffer: Vec<u8>,
 121         pending_read_buffer_pos: usize,
 122         pending_read_is_header: bool,
 123
 124         sync_status: InitSyncTracker,
 125
 126         awaiting_pong: bool,
 127 }
 128
 129 impl Peer {
 130         /// Returns true if the channel announcements/updates for the given channel should be
 131         /// forwarded to this peer.
 132         /// If we are sending our routing table to this peer and we have not yet sent channel
 133         /// announcements/updates for the given channel_id then we will send it when we get to that
 134         /// point and we shouldn't send it yet to avoid sending duplicate updates. If we've already
 135         /// sent the old versions, we should send the update, and so return true here.
 136         fn should_forward_channel_announcement(&self, channel_id: u64)->bool{
 137                 match self.sync_status {
 138                         InitSyncTracker::NoSyncRequested => true,
 139                         InitSyncTracker::ChannelsSyncing(i) => i < channel_id,
 140                         InitSyncTracker::NodesSyncing(_) => true,
 141                 }
 142         }
 143
 144         /// Similar to the above, but for node announcements indexed by node_id.
 145         fn should_forward_node_announcement(&self, node_id: PublicKey) -> bool {
 146                 match self.sync_status {
 147                         InitSyncTracker::NoSyncRequested => true,
 148                         InitSyncTracker::ChannelsSyncing(_) => false,
 149                         InitSyncTracker::NodesSyncing(pk) => pk < node_id,
 150                 }
 151         }
 152 }
 153
 154 struct PeerHolder<Descriptor: SocketDescriptor> {
 155         peers: HashMap<Descriptor, Peer>,
 156         /// Added to by do_read_event for cases where we pushed a message onto the send buffer but
 157         /// didn't call do_attempt_write_data to avoid reentrancy. Cleared in process_events()
 158         peers_needing_send: HashSet<Descriptor>,
 159         /// Only add to this set when noise completes:
 160         node_id_to_descriptor: HashMap<PublicKey, Descriptor>,
 161 }
 162
 163 #[cfg(not(any(target_pointer_width = "32", target_pointer_width = "64")))]
 164 fn _check_usize_is_32_or_64() {
 165         // See below, less than 32 bit pointers may be unsafe here!
 166         unsafe { mem::transmute::<*const usize, [u8; 4]>(panic!()); }
 167 }
 168
 169 /// SimpleArcPeerManager is useful when you need a PeerManager with a static lifetime, e.g.
 170 /// when you're using lightning-net-tokio (since tokio::spawn requires parameters with static
 171 /// lifetimes). Other times you can afford a reference, which is more efficient, in which case
 172 /// SimpleRefPeerManager is the more appropriate type. Defining these type aliases prevents
 173 /// issues such as overly long function definitions.
 174 pub type SimpleArcPeerManager<SD, M, T, F> = Arc<PeerManager<SD, SimpleArcChannelManager<M, T, F>>>;
 175
 176 /// SimpleRefPeerManager is a type alias for a PeerManager reference, and is the reference
 177 /// counterpart to the SimpleArcPeerManager type alias. Use this type by default when you don't
 178 /// need a PeerManager with a static lifetime. You'll need a static lifetime in cases such as
 179 /// usage of lightning-net-tokio (since tokio::spawn requires parameters with static lifetimes).
 180 /// But if this is not necessary, using a reference is more efficient. Defining these type aliases
 181 /// helps with issues such as long function definitions.
 182 pub type SimpleRefPeerManager<'a, 'b, 'c, 'd, SD, M, T, F> = PeerManager<SD, SimpleRefChannelManager<'a, 'b, 'c, 'd, M, T, F>>;
 183
 184 /// A PeerManager manages a set of peers, described by their SocketDescriptor and marshalls socket
 185 /// events into messages which it passes on to its MessageHandlers.
 186 ///
 187 /// Rather than using a plain PeerManager, it is preferable to use either a SimpleArcPeerManager
 188 /// a SimpleRefPeerManager, for conciseness. See their documentation for more details, but
 189 /// essentially you should default to using a SimpleRefPeerManager, and use a
 190 /// SimpleArcPeerManager when you require a PeerManager with a static lifetime, such as when
 191 /// you're using lightning-net-tokio.
 192 pub struct PeerManager<Descriptor: SocketDescriptor, CM: Deref> where CM::Target: msgs::ChannelMessageHandler {
 193         message_handler: MessageHandler<CM>,
 194         peers: Mutex<PeerHolder<Descriptor>>,
 195         our_node_secret: SecretKey,
 196         ephemeral_key_midstate: Sha256Engine,
 197
 198         // Usize needs to be at least 32 bits to avoid overflowing both low and high. If usize is 64
 199         // bits we will never realistically count into high:
 200         peer_counter_low: AtomicUsize,
 201         peer_counter_high: AtomicUsize,
 202
 203         logger: Arc<Logger>,
 204 }
 205
 206 macro_rules! encode_msg {
 207         ($msg: expr) => {{
 208                 let mut buffer = VecWriter(Vec::new());
 209                 wire::write($msg, &mut buffer).unwrap();
 210                 buffer.0
 211         }}
 212 }
 213
 214 /// Manages and reacts to connection events. You probably want to use file descriptors as PeerIds.
 215 /// PeerIds may repeat, but only after socket_disconnected() has been called.
 216 impl<Descriptor: SocketDescriptor, CM: Deref> PeerManager<Descriptor, CM> where CM::Target: msgs::ChannelMessageHandler {
 217         /// Constructs a new PeerManager with the given message handlers and node_id secret key
 218         /// ephemeral_random_data is used to derive per-connection ephemeral keys and must be
 219         /// cryptographically secure random bytes.
 220         pub fn new(message_handler: MessageHandler<CM>, our_node_secret: SecretKey, ephemeral_random_data: &[u8; 32], logger: Arc<Logger>) -> PeerManager<Descriptor, CM> {
 221                 let mut ephemeral_key_midstate = Sha256::engine();
 222                 ephemeral_key_midstate.input(ephemeral_random_data);
 223
 224                 PeerManager {
 225                         message_handler: message_handler,
 226                         peers: Mutex::new(PeerHolder {
 227                                 peers: HashMap::new(),
 228                                 peers_needing_send: HashSet::new(),
 229                                 node_id_to_descriptor: HashMap::new()
 230                         }),
 231                         our_node_secret: our_node_secret,
 232                         ephemeral_key_midstate,
 233                         peer_counter_low: AtomicUsize::new(0),
 234                         peer_counter_high: AtomicUsize::new(0),
 235                         logger,
 236                 }
 237         }
 238
 239         /// Get the list of node ids for peers which have completed the initial handshake.
 240         ///
 241         /// For outbound connections, this will be the same as the their_node_id parameter passed in to
 242         /// new_outbound_connection, however entries will only appear once the initial handshake has
 243         /// completed and we are sure the remote peer has the private key for the given node_id.
 244         pub fn get_peer_node_ids(&self) -> Vec<PublicKey> {
 245                 let peers = self.peers.lock().unwrap();
 246                 peers.peers.values().filter_map(|p| {
 247                         if !p.channel_encryptor.is_ready_for_encryption() || p.their_features.is_none() {
 248                                 return None;
 249                         }
 250                         p.their_node_id
 251                 }).collect()
 252         }
 253
 254         fn get_ephemeral_key(&self) -> SecretKey {
 255                 let mut ephemeral_hash = self.ephemeral_key_midstate.clone();
 256                 let low = self.peer_counter_low.fetch_add(1, Ordering::AcqRel);
 257                 let high = if low == 0 {
 258                         self.peer_counter_high.fetch_add(1, Ordering::AcqRel)
 259                 } else {
 260                         self.peer_counter_high.load(Ordering::Acquire)
 261                 };
 262                 ephemeral_hash.input(&byte_utils::le64_to_array(low as u64));
 263                 ephemeral_hash.input(&byte_utils::le64_to_array(high as u64));
 264                 SecretKey::from_slice(&Sha256::from_engine(ephemeral_hash).into_inner()).expect("You broke SHA-256!")
 265         }
 266
 267         /// Indicates a new outbound connection has been established to a node with the given node_id.
 268         /// Note that if an Err is returned here you MUST NOT call socket_disconnected for the new
 269         /// descriptor but must disconnect the connection immediately.
 270         ///
 271         /// Returns a small number of bytes to send to the remote node (currently always 50).
 272         ///
 273         /// Panics if descriptor is duplicative with some other descriptor which has not yet had a
 274         /// socket_disconnected().
 275         pub fn new_outbound_connection(&self, their_node_id: PublicKey, descriptor: Descriptor) -> Result<Vec<u8>, PeerHandleError> {
 276                 let mut peer_encryptor = PeerChannelEncryptor::new_outbound(their_node_id.clone(), self.get_ephemeral_key());
 277                 let res = peer_encryptor.get_act_one().to_vec();
 278                 let pending_read_buffer = [0; 50].to_vec(); // Noise act two is 50 bytes
 279
 280                 let mut peers = self.peers.lock().unwrap();
 281                 if peers.peers.insert(descriptor, Peer {
 282                         channel_encryptor: peer_encryptor,
 283                         outbound: true,
 284                         their_node_id: None,
 285                         their_features: None,
 286
 287                         pending_outbound_buffer: LinkedList::new(),
 288                         pending_outbound_buffer_first_msg_offset: 0,
 289                         awaiting_write_event: false,
 290
 291                         pending_read_buffer: pending_read_buffer,
 292                         pending_read_buffer_pos: 0,
 293                         pending_read_is_header: false,
 294
 295                         sync_status: InitSyncTracker::NoSyncRequested,
 296
 297                         awaiting_pong: false,
 298                 }).is_some() {
 299                         panic!("PeerManager driver duplicated descriptors!");
 300                 };
 301                 Ok(res)
 302         }
 303
 304         /// Indicates a new inbound connection has been established.
 305         ///
 306         /// May refuse the connection by returning an Err, but will never write bytes to the remote end
 307         /// (outbound connector always speaks first). Note that if an Err is returned here you MUST NOT
 308         /// call socket_disconnected for the new descriptor but must disconnect the connection
 309         /// immediately.
 310         ///
 311         /// Panics if descriptor is duplicative with some other descriptor which has not yet had
 312         /// socket_disconnected called.
 313         pub fn new_inbound_connection(&self, descriptor: Descriptor) -> Result<(), PeerHandleError> {
 314                 let peer_encryptor = PeerChannelEncryptor::new_inbound(&self.our_node_secret);
 315                 let pending_read_buffer = [0; 50].to_vec(); // Noise act one is 50 bytes
 316
 317                 let mut peers = self.peers.lock().unwrap();
 318                 if peers.peers.insert(descriptor, Peer {
 319                         channel_encryptor: peer_encryptor,
 320                         outbound: false,
 321                         their_node_id: None,
 322                         their_features: None,
 323
 324                         pending_outbound_buffer: LinkedList::new(),
 325                         pending_outbound_buffer_first_msg_offset: 0,
 326                         awaiting_write_event: false,
 327
 328                         pending_read_buffer: pending_read_buffer,
 329                         pending_read_buffer_pos: 0,
 330                         pending_read_is_header: false,
 331
 332                         sync_status: InitSyncTracker::NoSyncRequested,
 333
 334                         awaiting_pong: false,
 335                 }).is_some() {
 336                         panic!("PeerManager driver duplicated descriptors!");
 337                 };
 338                 Ok(())
 339         }
 340
 341         fn do_attempt_write_data(&self, descriptor: &mut Descriptor, peer: &mut Peer) {
 342                 macro_rules! encode_and_send_msg {
 343                         ($msg: expr) => {
 344                                 {
 345                                         log_trace!(self, "Encoding and sending sync update message of type {} to {}", $msg.type_id(), log_pubkey!(peer.their_node_id.unwrap()));
 346                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!($msg)[..]));
 347                                 }
 348                         }
 349                 }
 350                 const MSG_BUFF_SIZE: usize = 10;
 351                 while !peer.awaiting_write_event {
 352                         if peer.pending_outbound_buffer.len() < MSG_BUFF_SIZE {
 353                                 match peer.sync_status {
 354                                         InitSyncTracker::NoSyncRequested => {},
 355                                         InitSyncTracker::ChannelsSyncing(c) if c < 0xffff_ffff_ffff_ffff => {
 356                                                 let steps = ((MSG_BUFF_SIZE - peer.pending_outbound_buffer.len() + 2) / 3) as u8;
 357                                                 let all_messages = self.message_handler.route_handler.get_next_channel_announcements(c, steps);
 358                                                 for &(ref announce, ref update_a_option, ref update_b_option) in all_messages.iter() {
 359                                                         encode_and_send_msg!(announce);
 360                                                         if let &Some(ref update_a) = update_a_option {
 361                                                                 encode_and_send_msg!(update_a);
 362                                                         }
 363                                                         if let &Some(ref update_b) = update_b_option {
 364                                                                 encode_and_send_msg!(update_b);
 365                                                         }
 366                                                         peer.sync_status = InitSyncTracker::ChannelsSyncing(announce.contents.short_channel_id + 1);
 367                                                 }
 368                                                 if all_messages.is_empty() || all_messages.len() != steps as usize {
 369                                                         peer.sync_status = InitSyncTracker::ChannelsSyncing(0xffff_ffff_ffff_ffff);
 370                                                 }
 371                                         },
 372                                         InitSyncTracker::ChannelsSyncing(c) if c == 0xffff_ffff_ffff_ffff => {
 373                                                 let steps = (MSG_BUFF_SIZE - peer.pending_outbound_buffer.len()) as u8;
 374                                                 let all_messages = self.message_handler.route_handler.get_next_node_announcements(None, steps);
 375                                                 for msg in all_messages.iter() {
 376                                                         encode_and_send_msg!(msg);
 377                                                         peer.sync_status = InitSyncTracker::NodesSyncing(msg.contents.node_id);
 378                                                 }
 379                                                 if all_messages.is_empty() || all_messages.len() != steps as usize {
 380                                                         peer.sync_status = InitSyncTracker::NoSyncRequested;
 381                                                 }
 382                                         },
 383                                         InitSyncTracker::ChannelsSyncing(_) => unreachable!(),
 384                                         InitSyncTracker::NodesSyncing(key) => {
 385                                                 let steps = (MSG_BUFF_SIZE - peer.pending_outbound_buffer.len()) as u8;
 386                                                 let all_messages = self.message_handler.route_handler.get_next_node_announcements(Some(&key), steps);
 387                                                 for msg in all_messages.iter() {
 388                                                         encode_and_send_msg!(msg);
 389                                                         peer.sync_status = InitSyncTracker::NodesSyncing(msg.contents.node_id);
 390                                                 }
 391                                                 if all_messages.is_empty() || all_messages.len() != steps as usize {
 392                                                         peer.sync_status = InitSyncTracker::NoSyncRequested;
 393                                                 }
 394                                         },
 395                                 }
 396                         }
 397
 398                         if {
 399                                 let next_buff = match peer.pending_outbound_buffer.front() {
 400                                         None => return,
 401                                         Some(buff) => buff,
 402                                 };
 403
 404                                 let should_be_reading = peer.pending_outbound_buffer.len() < MSG_BUFF_SIZE;
 405                                 let pending = &next_buff[peer.pending_outbound_buffer_first_msg_offset..];
 406                                 let data_sent = descriptor.send_data(pending, should_be_reading);
 407                                 peer.pending_outbound_buffer_first_msg_offset += data_sent;
 408                                 if peer.pending_outbound_buffer_first_msg_offset == next_buff.len() { true } else { false }
 409                         } {
 410                                 peer.pending_outbound_buffer_first_msg_offset = 0;
 411                                 peer.pending_outbound_buffer.pop_front();
 412                         } else {
 413                                 peer.awaiting_write_event = true;
 414                         }
 415                 }
 416         }
 417
 418         /// Indicates that there is room to write data to the given socket descriptor.
 419         ///
 420         /// May return an Err to indicate that the connection should be closed.
 421         ///
 422         /// Will most likely call send_data on the descriptor passed in (or the descriptor handed into
 423         /// new_*\_connection) before returning. Thus, be very careful with reentrancy issues! The
 424         /// invariants around calling write_buffer_space_avail in case a write did not fully complete
 425         /// must still hold - be ready to call write_buffer_space_avail again if a write call generated
 426         /// here isn't sufficient! Panics if the descriptor was not previously registered in a
 427         /// new_\*_connection event.
 428         pub fn write_buffer_space_avail(&self, descriptor: &mut Descriptor) -> Result<(), PeerHandleError> {
 429                 let mut peers = self.peers.lock().unwrap();
 430                 match peers.peers.get_mut(descriptor) {
 431                         None => panic!("Descriptor for write_event is not already known to PeerManager"),
 432                         Some(peer) => {
 433                                 peer.awaiting_write_event = false;
 434                                 self.do_attempt_write_data(descriptor, peer);
 435                         }
 436                 };
 437                 Ok(())
 438         }
 439
 440         /// Indicates that data was read from the given socket descriptor.
 441         ///
 442         /// May return an Err to indicate that the connection should be closed.
 443         ///
 444         /// Will *not* call back into send_data on any descriptors to avoid reentrancy complexity.
 445         /// Thus, however, you almost certainly want to call process_events() after any read_event to
 446         /// generate send_data calls to handle responses.
 447         ///
 448         /// If Ok(true) is returned, further read_events should not be triggered until a send_data call
 449         /// on this file descriptor has resume_read set (preventing DoS issues in the send buffer).
 450         ///
 451         /// Panics if the descriptor was not previously registered in a new_*_connection event.
 452         pub fn read_event(&self, peer_descriptor: &mut Descriptor, data: &[u8]) -> Result<bool, PeerHandleError> {
 453                 match self.do_read_event(peer_descriptor, data) {
 454                         Ok(res) => Ok(res),
 455                         Err(e) => {
 456                                 self.disconnect_event_internal(peer_descriptor, e.no_connection_possible);
 457                                 Err(e)
 458                         }
 459                 }
 460         }
 461
 462         fn do_read_event(&self, peer_descriptor: &mut Descriptor, data: &[u8]) -> Result<bool, PeerHandleError> {
 463                 let pause_read = {
 464                         let mut peers_lock = self.peers.lock().unwrap();
 465                         let peers = &mut *peers_lock;
 466                         let pause_read = match peers.peers.get_mut(peer_descriptor) {
 467                                 None => panic!("Descriptor for read_event is not already known to PeerManager"),
 468                                 Some(peer) => {
 469                                         assert!(peer.pending_read_buffer.len() > 0);
 470                                         assert!(peer.pending_read_buffer.len() > peer.pending_read_buffer_pos);
 471
 472                                         let mut read_pos = 0;
 473                                         while read_pos < data.len() {
 474                                                 {
 475                                                         let data_to_copy = cmp::min(peer.pending_read_buffer.len() - peer.pending_read_buffer_pos, data.len() - read_pos);
 476                                                         peer.pending_read_buffer[peer.pending_read_buffer_pos..peer.pending_read_buffer_pos + data_to_copy].copy_from_slice(&data[read_pos..read_pos + data_to_copy]);
 477                                                         read_pos += data_to_copy;
 478                                                         peer.pending_read_buffer_pos += data_to_copy;
 479                                                 }
 480
 481                                                 if peer.pending_read_buffer_pos == peer.pending_read_buffer.len() {
 482                                                         peer.pending_read_buffer_pos = 0;
 483
 484                                                         macro_rules! encode_and_send_msg {
 485                                                                 ($msg: expr) => {
 486                                                                         {
 487                                                                                 log_trace!(self, "Encoding and sending message of type {} to {}", $msg.type_id(), log_pubkey!(peer.their_node_id.unwrap()));
 488                                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(&$msg)[..]));
 489                                                                                 peers.peers_needing_send.insert(peer_descriptor.clone());
 490                                                                         }
 491                                                                 }
 492                                                         }
 493
 494                                                         macro_rules! try_potential_handleerror {
 495                                                                 ($thing: expr) => {
 496                                                                         match $thing {
 497                                                                                 Ok(x) => x,
 498                                                                                 Err(e) => {
 499                                                                                         match e.action {
 500                                                                                                 msgs::ErrorAction::DisconnectPeer { msg: _ } => {
 501                                                                                                         //TODO: Try to push msg
 502                                                                                                         log_trace!(self, "Got Err handling message, disconnecting peer because {}", e.err);
 503                                                                                                         return Err(PeerHandleError{ no_connection_possible: false });
 504                                                                                                 },
 505                                                                                                 msgs::ErrorAction::IgnoreError => {
 506                                                                                                         log_trace!(self, "Got Err handling message, ignoring because {}", e.err);
 507                                                                                                         continue;
 508                                                                                                 },
 509                                                                                                 msgs::ErrorAction::SendErrorMessage { msg } => {
 510                                                                                                         log_trace!(self, "Got Err handling message, sending Error message because {}", e.err);
 511                                                                                                         encode_and_send_msg!(msg);
 512                                                                                                         continue;
 513                                                                                                 },
 514                                                                                         }
 515                                                                                 }
 516                                                                         };
 517                                                                 }
 518                                                         }
 519
 520                                                         macro_rules! insert_node_id {
 521                                                                 () => {
 522                                                                         match peers.node_id_to_descriptor.entry(peer.their_node_id.unwrap()) {
 523                                                                                 hash_map::Entry::Occupied(_) => {
 524                                                                                         log_trace!(self, "Got second connection with {}, closing", log_pubkey!(peer.their_node_id.unwrap()));
 525                                                                                         peer.their_node_id = None; // Unset so that we don't generate a peer_disconnected event
 526                                                                                         return Err(PeerHandleError{ no_connection_possible: false })
 527                                                                                 },
 528                                                                                 hash_map::Entry::Vacant(entry) => {
 529                                                                                         log_trace!(self, "Finished noise handshake for connection with {}", log_pubkey!(peer.their_node_id.unwrap()));
 530                                                                                         entry.insert(peer_descriptor.clone())
 531                                                                                 },
 532                                                                         };
 533                                                                 }
 534                                                         }
 535
 536                                                         let next_step = peer.channel_encryptor.get_noise_step();
 537                                                         match next_step {
 538                                                                 NextNoiseStep::ActOne => {
 539                                                                         let act_two = try_potential_handleerror!(peer.channel_encryptor.process_act_one_with_keys(&peer.pending_read_buffer[..], &self.our_node_secret, self.get_ephemeral_key())).to_vec();
 540                                                                         peer.pending_outbound_buffer.push_back(act_two);
 541                                                                         peer.pending_read_buffer = [0; 66].to_vec(); // act three is 66 bytes long
 542                                                                 },
 543                                                                 NextNoiseStep::ActTwo => {
 544                                                                         let (act_three, their_node_id) = try_potential_handleerror!(peer.channel_encryptor.process_act_two(&peer.pending_read_buffer[..], &self.our_node_secret));
 545                                                                         peer.pending_outbound_buffer.push_back(act_three.to_vec());
 546                                                                         peer.pending_read_buffer = [0; 18].to_vec(); // Message length header is 18 bytes
 547                                                                         peer.pending_read_is_header = true;
 548
 549                                                                         peer.their_node_id = Some(their_node_id);
 550                                                                         insert_node_id!();
 551                                                                         let mut features = InitFeatures::supported();
 552                                                                         if self.message_handler.route_handler.should_request_full_sync(&peer.their_node_id.unwrap()) {
 553                                                                                 features.set_initial_routing_sync();
 554                                                                         }
 555
 556                                                                         let resp = msgs::Init { features };
 557                                                                         encode_and_send_msg!(resp);
 558                                                                 },
 559                                                                 NextNoiseStep::ActThree => {
 560                                                                         let their_node_id = try_potential_handleerror!(peer.channel_encryptor.process_act_three(&peer.pending_read_buffer[..]));
 561                                                                         peer.pending_read_buffer = [0; 18].to_vec(); // Message length header is 18 bytes
 562                                                                         peer.pending_read_is_header = true;
 563                                                                         peer.their_node_id = Some(their_node_id);
 564                                                                         insert_node_id!();
 565                                                                 },
 566                                                                 NextNoiseStep::NoiseComplete => {
 567                                                                         if peer.pending_read_is_header {
 568                                                                                 let msg_len = try_potential_handleerror!(peer.channel_encryptor.decrypt_length_header(&peer.pending_read_buffer[..]));
 569                                                                                 peer.pending_read_buffer = Vec::with_capacity(msg_len as usize + 16);
 570                                                                                 peer.pending_read_buffer.resize(msg_len as usize + 16, 0);
 571                                                                                 if msg_len < 2 { // Need at least the message type tag
 572                                                                                         return Err(PeerHandleError{ no_connection_possible: false });
 573                                                                                 }
 574                                                                                 peer.pending_read_is_header = false;
 575                                                                         } else {
 576                                                                                 let msg_data = try_potential_handleerror!(peer.channel_encryptor.decrypt_message(&peer.pending_read_buffer[..]));
 577                                                                                 assert!(msg_data.len() >= 2);
 578
 579                                                                                 // Reset read buffer
 580                                                                                 peer.pending_read_buffer = [0; 18].to_vec();
 581                                                                                 peer.pending_read_is_header = true;
 582
 583                                                                                 let mut reader = ::std::io::Cursor::new(&msg_data[..]);
 584                                                                                 let message_result = wire::read(&mut reader);
 585                                                                                 let message = match message_result {
 586                                                                                         Ok(x) => x,
 587                                                                                         Err(e) => {
 588                                                                                                 match e {
 589                                                                                                         msgs::DecodeError::UnknownVersion => return Err(PeerHandleError { no_connection_possible: false }),
 590                                                                                                         msgs::DecodeError::UnknownRequiredFeature => {
 591                                                                                                                 log_debug!(self, "Got a channel/node announcement with an known required feature flag, you may want to update!");
 592                                                                                                                 continue;
 593                                                                                                         }
 594                                                                                                         msgs::DecodeError::InvalidValue => {
 595                                                                                                                 log_debug!(self, "Got an invalid value while deserializing message");
 596                                                                                                                 return Err(PeerHandleError { no_connection_possible: false });
 597                                                                                                         }
 598                                                                                                         msgs::DecodeError::ShortRead => {
 599                                                                                                                 log_debug!(self, "Deserialization failed due to shortness of message");
 600                                                                                                                 return Err(PeerHandleError { no_connection_possible: false });
 601                                                                                                         }
 602                                                                                                         msgs::DecodeError::BadLengthDescriptor => return Err(PeerHandleError { no_connection_possible: false }),
 603                                                                                                         msgs::DecodeError::Io(_) => return Err(PeerHandleError { no_connection_possible: false }),
 604                                                                                                 }
 605                                                                                         }
 606                                                                                 };
 607
 608                                                                                 log_trace!(self, "Received message of type {} from {}", message.type_id(), log_pubkey!(peer.their_node_id.unwrap()));
 609
 610                                                                                 // Need an Init as first message
 611                                                                                 if let wire::Message::Init(_) = message {
 612                                                                                 } else if peer.their_features.is_none() {
 613                                                                                         log_trace!(self, "Peer {} sent non-Init first message", log_pubkey!(peer.their_node_id.unwrap()));
 614                                                                                         return Err(PeerHandleError{ no_connection_possible: false });
 615                                                                                 }
 616
 617                                                                                 match message {
 618                                                                                         // Setup and Control messages:
 619                                                                                         wire::Message::Init(msg) => {
 620                                                                                                 if msg.features.requires_unknown_bits() {
 621                                                                                                         log_info!(self, "Peer global features required unknown version bits");
 622                                                                                                         return Err(PeerHandleError{ no_connection_possible: true });
 623                                                                                                 }
 624                                                                                                 if msg.features.requires_unknown_bits() {
 625                                                                                                         log_info!(self, "Peer local features required unknown version bits");
 626                                                                                                         return Err(PeerHandleError{ no_connection_possible: true });
 627                                                                                                 }
 628                                                                                                 if peer.their_features.is_some() {
 629                                                                                                         return Err(PeerHandleError{ no_connection_possible: false });
 630                                                                                                 }
 631
 632                                                                                                 log_info!(self, "Received peer Init message: data_loss_protect: {}, initial_routing_sync: {}, upfront_shutdown_script: {}, unkown local flags: {}, unknown global flags: {}",
 633                                                                                                         if msg.features.supports_data_loss_protect() { "supported" } else { "not supported"},
 634                                                                                                         if msg.features.initial_routing_sync() { "requested" } else { "not requested" },
 635                                                                                                         if msg.features.supports_upfront_shutdown_script() { "supported" } else { "not supported"},
 636                                                                                                         if msg.features.supports_unknown_bits() { "present" } else { "none" },
 637                                                                                                         if msg.features.supports_unknown_bits() { "present" } else { "none" });
 638
 639                                                                                                 if msg.features.initial_routing_sync() {
 640                                                                                                         peer.sync_status = InitSyncTracker::ChannelsSyncing(0);
 641                                                                                                         peers.peers_needing_send.insert(peer_descriptor.clone());
 642                                                                                                 }
 643
 644                                                                                                 if !peer.outbound {
 645                                                                                                         let mut features = InitFeatures::supported();
 646                                                                                                         if self.message_handler.route_handler.should_request_full_sync(&peer.their_node_id.unwrap()) {
 647                                                                                                                 features.set_initial_routing_sync();
 648                                                                                                         }
 649
 650                                                                                                         let resp = msgs::Init { features };
 651                                                                                                         encode_and_send_msg!(resp);
 652                                                                                                 }
 653
 654                                                                                                 self.message_handler.chan_handler.peer_connected(&peer.their_node_id.unwrap(), &msg);
 655                                                                                                 peer.their_features = Some(msg.features);
 656                                                                                         },
 657                                                                                         wire::Message::Error(msg) => {
 658                                                                                                 let mut data_is_printable = true;
 659                                                                                                 for b in msg.data.bytes() {
 660                                                                                                         if b < 32 || b > 126 {
 661                                                                                                                 data_is_printable = false;
 662                                                                                                                 break;
 663                                                                                                         }
 664                                                                                                 }
 665
 666                                                                                                 if data_is_printable {
 667                                                                                                         log_debug!(self, "Got Err message from {}: {}", log_pubkey!(peer.their_node_id.unwrap()), msg.data);
 668                                                                                                 } else {
 669                                                                                                         log_debug!(self, "Got Err message from {} with non-ASCII error message", log_pubkey!(peer.their_node_id.unwrap()));
 670                                                                                                 }
 671                                                                                                 self.message_handler.chan_handler.handle_error(&peer.their_node_id.unwrap(), &msg);
 672                                                                                                 if msg.channel_id == [0; 32] {
 673                                                                                                         return Err(PeerHandleError{ no_connection_possible: true });
 674                                                                                                 }
 675                                                                                         },
 676
 677                                                                                         wire::Message::Ping(msg) => {
 678                                                                                                 if msg.ponglen < 65532 {
 679                                                                                                         let resp = msgs::Pong { byteslen: msg.ponglen };
 680                                                                                                         encode_and_send_msg!(resp);
 681                                                                                                 }
 682                                                                                         },
 683                                                                                         wire::Message::Pong(_msg) => {
 684                                                                                                 peer.awaiting_pong = false;
 685                                                                                         },
 686
 687                                                                                         // Channel messages:
 688                                                                                         wire::Message::OpenChannel(msg) => {
 689                                                                                                 self.message_handler.chan_handler.handle_open_channel(&peer.their_node_id.unwrap(), peer.their_features.clone().unwrap(), &msg);
 690                                                                                         },
 691                                                                                         wire::Message::AcceptChannel(msg) => {
 692                                                                                                 self.message_handler.chan_handler.handle_accept_channel(&peer.their_node_id.unwrap(), peer.their_features.clone().unwrap(), &msg);
 693                                                                                         },
 694
 695                                                                                         wire::Message::FundingCreated(msg) => {
 696                                                                                                 self.message_handler.chan_handler.handle_funding_created(&peer.their_node_id.unwrap(), &msg);
 697                                                                                         },
 698                                                                                         wire::Message::FundingSigned(msg) => {
 699                                                                                                 self.message_handler.chan_handler.handle_funding_signed(&peer.their_node_id.unwrap(), &msg);
 700                                                                                         },
 701                                                                                         wire::Message::FundingLocked(msg) => {
 702                                                                                                 self.message_handler.chan_handler.handle_funding_locked(&peer.their_node_id.unwrap(), &msg);
 703                                                                                         },
 704
 705                                                                                         wire::Message::Shutdown(msg) => {
 706                                                                                                 self.message_handler.chan_handler.handle_shutdown(&peer.their_node_id.unwrap(), &msg);
 707                                                                                         },
 708                                                                                         wire::Message::ClosingSigned(msg) => {
 709                                                                                                 self.message_handler.chan_handler.handle_closing_signed(&peer.their_node_id.unwrap(), &msg);
 710                                                                                         },
 711
 712                                                                                         // Commitment messages:
 713                                                                                         wire::Message::UpdateAddHTLC(msg) => {
 714                                                                                                 self.message_handler.chan_handler.handle_update_add_htlc(&peer.their_node_id.unwrap(), &msg);
 715                                                                                         },
 716                                                                                         wire::Message::UpdateFulfillHTLC(msg) => {
 717                                                                                                 self.message_handler.chan_handler.handle_update_fulfill_htlc(&peer.their_node_id.unwrap(), &msg);
 718                                                                                         },
 719                                                                                         wire::Message::UpdateFailHTLC(msg) => {
 720                                                                                                 self.message_handler.chan_handler.handle_update_fail_htlc(&peer.their_node_id.unwrap(), &msg);
 721                                                                                         },
 722                                                                                         wire::Message::UpdateFailMalformedHTLC(msg) => {
 723                                                                                                 self.message_handler.chan_handler.handle_update_fail_malformed_htlc(&peer.their_node_id.unwrap(), &msg);
 724                                                                                         },
 725
 726                                                                                         wire::Message::CommitmentSigned(msg) => {
 727                                                                                                 self.message_handler.chan_handler.handle_commitment_signed(&peer.their_node_id.unwrap(), &msg);
 728                                                                                         },
 729                                                                                         wire::Message::RevokeAndACK(msg) => {
 730                                                                                                 self.message_handler.chan_handler.handle_revoke_and_ack(&peer.their_node_id.unwrap(), &msg);
 731                                                                                         },
 732                                                                                         wire::Message::UpdateFee(msg) => {
 733                                                                                                 self.message_handler.chan_handler.handle_update_fee(&peer.their_node_id.unwrap(), &msg);
 734                                                                                         },
 735                                                                                         wire::Message::ChannelReestablish(msg) => {
 736                                                                                                 self.message_handler.chan_handler.handle_channel_reestablish(&peer.their_node_id.unwrap(), &msg);
 737                                                                                         },
 738
 739                                                                                         // Routing messages:
 740                                                                                         wire::Message::AnnouncementSignatures(msg) => {
 741                                                                                                 self.message_handler.chan_handler.handle_announcement_signatures(&peer.their_node_id.unwrap(), &msg);
 742                                                                                         },
 743                                                                                         wire::Message::ChannelAnnouncement(msg) => {
 744                                                                                                 let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_announcement(&msg));
 745
 746                                                                                                 if should_forward {
 747                                                                                                         // TODO: forward msg along to all our other peers!
 748                                                                                                 }
 749                                                                                         },
 750                                                                                         wire::Message::NodeAnnouncement(msg) => {
 751                                                                                                 let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_node_announcement(&msg));
 752
 753                                                                                                 if should_forward {
 754                                                                                                         // TODO: forward msg along to all our other peers!
 755                                                                                                 }
 756                                                                                         },
 757                                                                                         wire::Message::ChannelUpdate(msg) => {
 758                                                                                                 let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_update(&msg));
 759
 760                                                                                                 if should_forward {
 761                                                                                                         // TODO: forward msg along to all our other peers!
 762                                                                                                 }
 763                                                                                         },
 764
 765                                                                                         // Unknown messages:
 766                                                                                         wire::Message::Unknown(msg_type) if msg_type.is_even() => {
 767                                                                                                 log_debug!(self, "Received unknown even message of type {}, disconnecting peer!", msg_type);
 768                                                                                                 // Fail the channel if message is an even, unknown type as per BOLT #1.
 769                                                                                                 return Err(PeerHandleError{ no_connection_possible: true });
 770                                                                                         },
 771                                                                                         wire::Message::Unknown(msg_type) => {
 772                                                                                                 log_trace!(self, "Received unknown odd message of type {}, ignoring", msg_type);
 773                                                                                         },
 774                                                                                 }
 775                                                                         }
 776                                                                 }
 777                                                         }
 778                                                 }
 779                                         }
 780
 781                                         self.do_attempt_write_data(peer_descriptor, peer);
 782
 783                                         peer.pending_outbound_buffer.len() > 10 // pause_read
 784                                 }
 785                         };
 786
 787                         pause_read
 788                 };
 789
 790                 Ok(pause_read)
 791         }
 792
 793         /// Checks for any events generated by our handlers and processes them. Includes sending most
 794         /// response messages as well as messages generated by calls to handler functions directly (eg
 795         /// functions like ChannelManager::process_pending_htlc_forward or send_payment).
 796         pub fn process_events(&self) {
 797                 {
 798                         // TODO: There are some DoS attacks here where you can flood someone's outbound send
 799                         // buffer by doing things like announcing channels on another node. We should be willing to
 800                         // drop optional-ish messages when send buffers get full!
 801
 802                         let mut events_generated = self.message_handler.chan_handler.get_and_clear_pending_msg_events();
 803                         let mut peers_lock = self.peers.lock().unwrap();
 804                         let peers = &mut *peers_lock;
 805                         for event in events_generated.drain(..) {
 806                                 macro_rules! get_peer_for_forwarding {
 807                                         ($node_id: expr, $handle_no_such_peer: block) => {
 808                                                 {
 809                                                         let descriptor = match peers.node_id_to_descriptor.get($node_id) {
 810                                                                 Some(descriptor) => descriptor.clone(),
 811                                                                 None => {
 812                                                                         $handle_no_such_peer;
 813                                                                         continue;
 814                                                                 },
 815                                                         };
 816                                                         match peers.peers.get_mut(&descriptor) {
 817                                                                 Some(peer) => {
 818                                                                         if peer.their_features.is_none() {
 819                                                                                 $handle_no_such_peer;
 820                                                                                 continue;
 821                                                                         }
 822                                                                         (descriptor, peer)
 823                                                                 },
 824                                                                 None => panic!("Inconsistent peers set state!"),
 825                                                         }
 826                                                 }
 827                                         }
 828                                 }
 829                                 match event {
 830                                         MessageSendEvent::SendAcceptChannel { ref node_id, ref msg } => {
 831                                                 log_trace!(self, "Handling SendAcceptChannel event in peer_handler for node {} for channel {}",
 832                                                                 log_pubkey!(node_id),
 833                                                                 log_bytes!(msg.temporary_channel_id));
 834                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 835                                                                 //TODO: Drop the pending channel? (or just let it timeout, but that sucks)
 836                                                         });
 837                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 838                                                 self.do_attempt_write_data(&mut descriptor, peer);
 839                                         },
 840                                         MessageSendEvent::SendOpenChannel { ref node_id, ref msg } => {
 841                                                 log_trace!(self, "Handling SendOpenChannel event in peer_handler for node {} for channel {}",
 842                                                                 log_pubkey!(node_id),
 843                                                                 log_bytes!(msg.temporary_channel_id));
 844                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 845                                                                 //TODO: Drop the pending channel? (or just let it timeout, but that sucks)
 846                                                         });
 847                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 848                                                 self.do_attempt_write_data(&mut descriptor, peer);
 849                                         },
 850                                         MessageSendEvent::SendFundingCreated { ref node_id, ref msg } => {
 851                                                 log_trace!(self, "Handling SendFundingCreated event in peer_handler for node {} for channel {} (which becomes {})",
 852                                                                 log_pubkey!(node_id),
 853                                                                 log_bytes!(msg.temporary_channel_id),
 854                                                                 log_funding_channel_id!(msg.funding_txid, msg.funding_output_index));
 855                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 856                                                                 //TODO: generate a DiscardFunding event indicating to the wallet that
 857                                                                 //they should just throw away this funding transaction
 858                                                         });
 859                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 860                                                 self.do_attempt_write_data(&mut descriptor, peer);
 861                                         },
 862                                         MessageSendEvent::SendFundingSigned { ref node_id, ref msg } => {
 863                                                 log_trace!(self, "Handling SendFundingSigned event in peer_handler for node {} for channel {}",
 864                                                                 log_pubkey!(node_id),
 865                                                                 log_bytes!(msg.channel_id));
 866                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 867                                                                 //TODO: generate a DiscardFunding event indicating to the wallet that
 868                                                                 //they should just throw away this funding transaction
 869                                                         });
 870                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 871                                                 self.do_attempt_write_data(&mut descriptor, peer);
 872                                         },
 873                                         MessageSendEvent::SendFundingLocked { ref node_id, ref msg } => {
 874                                                 log_trace!(self, "Handling SendFundingLocked event in peer_handler for node {} for channel {}",
 875                                                                 log_pubkey!(node_id),
 876                                                                 log_bytes!(msg.channel_id));
 877                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 878                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 879                                                         });
 880                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 881                                                 self.do_attempt_write_data(&mut descriptor, peer);
 882                                         },
 883                                         MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } => {
 884                                                 log_trace!(self, "Handling SendAnnouncementSignatures event in peer_handler for node {} for channel {})",
 885                                                                 log_pubkey!(node_id),
 886                                                                 log_bytes!(msg.channel_id));
 887                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 888                                                                 //TODO: generate a DiscardFunding event indicating to the wallet that
 889                                                                 //they should just throw away this funding transaction
 890                                                         });
 891                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 892                                                 self.do_attempt_write_data(&mut descriptor, peer);
 893                                         },
 894                                         MessageSendEvent::UpdateHTLCs { ref node_id, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
 895                                                 log_trace!(self, "Handling UpdateHTLCs event in peer_handler for node {} with {} adds, {} fulfills, {} fails for channel {}",
 896                                                                 log_pubkey!(node_id),
 897                                                                 update_add_htlcs.len(),
 898                                                                 update_fulfill_htlcs.len(),
 899                                                                 update_fail_htlcs.len(),
 900                                                                 log_bytes!(commitment_signed.channel_id));
 901                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 902                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 903                                                         });
 904                                                 for msg in update_add_htlcs {
 905                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 906                                                 }
 907                                                 for msg in update_fulfill_htlcs {
 908                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 909                                                 }
 910                                                 for msg in update_fail_htlcs {
 911                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 912                                                 }
 913                                                 for msg in update_fail_malformed_htlcs {
 914                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 915                                                 }
 916                                                 if let &Some(ref msg) = update_fee {
 917                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 918                                                 }
 919                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(commitment_signed)));
 920                                                 self.do_attempt_write_data(&mut descriptor, peer);
 921                                         },
 922                                         MessageSendEvent::SendRevokeAndACK { ref node_id, ref msg } => {
 923                                                 log_trace!(self, "Handling SendRevokeAndACK event in peer_handler for node {} for channel {}",
 924                                                                 log_pubkey!(node_id),
 925                                                                 log_bytes!(msg.channel_id));
 926                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 927                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 928                                                         });
 929                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 930                                                 self.do_attempt_write_data(&mut descriptor, peer);
 931                                         },
 932                                         MessageSendEvent::SendClosingSigned { ref node_id, ref msg } => {
 933                                                 log_trace!(self, "Handling SendClosingSigned event in peer_handler for node {} for channel {}",
 934                                                                 log_pubkey!(node_id),
 935                                                                 log_bytes!(msg.channel_id));
 936                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 937                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 938                                                         });
 939                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 940                                                 self.do_attempt_write_data(&mut descriptor, peer);
 941                                         },
 942                                         MessageSendEvent::SendShutdown { ref node_id, ref msg } => {
 943                                                 log_trace!(self, "Handling Shutdown event in peer_handler for node {} for channel {}",
 944                                                                 log_pubkey!(node_id),
 945                                                                 log_bytes!(msg.channel_id));
 946                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 947                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 948                                                         });
 949                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 950                                                 self.do_attempt_write_data(&mut descriptor, peer);
 951                                         },
 952                                         MessageSendEvent::SendChannelReestablish { ref node_id, ref msg } => {
 953                                                 log_trace!(self, "Handling SendChannelReestablish event in peer_handler for node {} for channel {}",
 954                                                                 log_pubkey!(node_id),
 955                                                                 log_bytes!(msg.channel_id));
 956                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
 957                                                                 //TODO: Do whatever we're gonna do for handling dropped messages
 958                                                         });
 959                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
 960                                                 self.do_attempt_write_data(&mut descriptor, peer);
 961                                         },
 962                                         MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 963                                                 log_trace!(self, "Handling BroadcastChannelAnnouncement event in peer_handler for short channel id {}", msg.contents.short_channel_id);
 964                                                 if self.message_handler.route_handler.handle_channel_announcement(msg).is_ok() && self.message_handler.route_handler.handle_channel_update(update_msg).is_ok() {
 965                                                         let encoded_msg = encode_msg!(msg);
 966                                                         let encoded_update_msg = encode_msg!(update_msg);
 967
 968                                                         for (ref descriptor, ref mut peer) in peers.peers.iter_mut() {
 969                                                                 if !peer.channel_encryptor.is_ready_for_encryption() || peer.their_features.is_none() ||
 970                                                                                 !peer.should_forward_channel_announcement(msg.contents.short_channel_id) {
 971                                                                         continue
 972                                                                 }
 973                                                                 match peer.their_node_id {
 974                                                                         None => continue,
 975                                                                         Some(their_node_id) => {
 976                                                                                 if their_node_id == msg.contents.node_id_1 || their_node_id == msg.contents.node_id_2 {
 977                                                                                         continue
 978                                                                                 }
 979                                                                         }
 980                                                                 }
 981                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
 982                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_update_msg[..]));
 983                                                                 self.do_attempt_write_data(&mut (*descriptor).clone(), peer);
 984                                                         }
 985                                                 }
 986                                         },
 987                                         MessageSendEvent::BroadcastNodeAnnouncement { ref msg } => {
 988                                                 log_trace!(self, "Handling BroadcastNodeAnnouncement event in peer_handler");
 989                                                 if self.message_handler.route_handler.handle_node_announcement(msg).is_ok() {
 990                                                         let encoded_msg = encode_msg!(msg);
 991
 992                                                         for (ref descriptor, ref mut peer) in peers.peers.iter_mut() {
 993                                                                 if !peer.channel_encryptor.is_ready_for_encryption() || peer.their_features.is_none() ||
 994                                                                                 !peer.should_forward_node_announcement(msg.contents.node_id) {
 995                                                                         continue
 996                                                                 }
 997                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
 998                                                                 self.do_attempt_write_data(&mut (*descriptor).clone(), peer);
 999                                                         }
1000                                                 }
1001                                         },
1002                                         MessageSendEvent::BroadcastChannelUpdate { ref msg } => {
1003                                                 log_trace!(self, "Handling BroadcastChannelUpdate event in peer_handler for short channel id {}", msg.contents.short_channel_id);
1004                                                 if self.message_handler.route_handler.handle_channel_update(msg).is_ok() {
1005                                                         let encoded_msg = encode_msg!(msg);
1006
1007                                                         for (ref descriptor, ref mut peer) in peers.peers.iter_mut() {
1008                                                                 if !peer.channel_encryptor.is_ready_for_encryption() || peer.their_features.is_none() ||
1009                                                                                 !peer.should_forward_channel_announcement(msg.contents.short_channel_id)  {
1010                                                                         continue
1011                                                                 }
1012                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
1013                                                                 self.do_attempt_write_data(&mut (*descriptor).clone(), peer);
1014                                                         }
1015                                                 }
1016                                         },
1017                                         MessageSendEvent::PaymentFailureNetworkUpdate { ref update } => {
1018                                                 self.message_handler.route_handler.handle_htlc_fail_channel_update(update);
1019                                         },
1020                                         MessageSendEvent::HandleError { ref node_id, ref action } => {
1021                                                 match *action {
1022                                                         msgs::ErrorAction::DisconnectPeer { ref msg } => {
1023                                                                 if let Some(mut descriptor) = peers.node_id_to_descriptor.remove(node_id) {
1024                                                                         peers.peers_needing_send.remove(&descriptor);
1025                                                                         if let Some(mut peer) = peers.peers.remove(&descriptor) {
1026                                                                                 if let Some(ref msg) = *msg {
1027                                                                                         log_trace!(self, "Handling DisconnectPeer HandleError event in peer_handler for node {} with message {}",
1028                                                                                                         log_pubkey!(node_id),
1029                                                                                                         msg.data);
1030                                                                                         peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
1031                                                                                         // This isn't guaranteed to work, but if there is enough free
1032                                                                                         // room in the send buffer, put the error message there...
1033                                                                                         self.do_attempt_write_data(&mut descriptor, &mut peer);
1034                                                                                 } else {
1035                                                                                         log_trace!(self, "Handling DisconnectPeer HandleError event in peer_handler for node {} with no message", log_pubkey!(node_id));
1036                                                                                 }
1037                                                                         }
1038                                                                         descriptor.disconnect_socket();
1039                                                                         self.message_handler.chan_handler.peer_disconnected(&node_id, false);
1040                                                                 }
1041                                                         },
1042                                                         msgs::ErrorAction::IgnoreError => {},
1043                                                         msgs::ErrorAction::SendErrorMessage { ref msg } => {
1044                                                                 log_trace!(self, "Handling SendErrorMessage HandleError event in peer_handler for node {} with message {}",
1045                                                                                 log_pubkey!(node_id),
1046                                                                                 msg.data);
1047                                                                 let (mut descriptor, peer) = get_peer_for_forwarding!(node_id, {
1048                                                                         //TODO: Do whatever we're gonna do for handling dropped messages
1049                                                                 });
1050                                                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(msg)));
1051                                                                 self.do_attempt_write_data(&mut descriptor, peer);
1052                                                         },
1053                                                 }
1054                                         }
1055                                 }
1056                         }
1057
1058                         for mut descriptor in peers.peers_needing_send.drain() {
1059                                 match peers.peers.get_mut(&descriptor) {
1060                                         Some(peer) => self.do_attempt_write_data(&mut descriptor, peer),
1061                                         None => panic!("Inconsistent peers set state!"),
1062                                 }
1063                         }
1064                 }
1065         }
1066
1067         /// Indicates that the given socket descriptor's connection is now closed.
1068         ///
1069         /// This must only be called if the socket has been disconnected by the peer or your own
1070         /// decision to disconnect it and must NOT be called in any case where other parts of this
1071         /// library (eg PeerHandleError, explicit disconnect_socket calls) instruct you to disconnect
1072         /// the peer.
1073         ///
1074         /// Panics if the descriptor was not previously registered in a successful new_*_connection event.
1075         pub fn socket_disconnected(&self, descriptor: &Descriptor) {
1076                 self.disconnect_event_internal(descriptor, false);
1077         }
1078
1079         fn disconnect_event_internal(&self, descriptor: &Descriptor, no_connection_possible: bool) {
1080                 let mut peers = self.peers.lock().unwrap();
1081                 peers.peers_needing_send.remove(descriptor);
1082                 let peer_option = peers.peers.remove(descriptor);
1083                 match peer_option {
1084                         None => panic!("Descriptor for disconnect_event is not already known to PeerManager"),
1085                         Some(peer) => {
1086                                 match peer.their_node_id {
1087                                         Some(node_id) => {
1088                                                 peers.node_id_to_descriptor.remove(&node_id);
1089                                                 self.message_handler.chan_handler.peer_disconnected(&node_id, no_connection_possible);
1090                                         },
1091                                         None => {}
1092                                 }
1093                         }
1094                 };
1095         }
1096
1097         /// This function should be called roughly once every 30 seconds.
1098         /// It will send pings to each peer and disconnect those which did not respond to the last round of pings.
1099
1100         /// Will most likely call send_data on all of the registered descriptors, thus, be very careful with reentrancy issues!
1101         pub fn timer_tick_occured(&self) {
1102                 let mut peers_lock = self.peers.lock().unwrap();
1103                 {
1104                         let peers = &mut *peers_lock;
1105                         let peers_needing_send = &mut peers.peers_needing_send;
1106                         let node_id_to_descriptor = &mut peers.node_id_to_descriptor;
1107                         let peers = &mut peers.peers;
1108                         let mut descriptors_needing_disconnect = Vec::new();
1109
1110                         peers.retain(|descriptor, peer| {
1111                                 if peer.awaiting_pong {
1112                                         peers_needing_send.remove(descriptor);
1113                                         descriptors_needing_disconnect.push(descriptor.clone());
1114                                         match peer.their_node_id {
1115                                                 Some(node_id) => {
1116                                                         log_trace!(self, "Disconnecting peer with id {} due to ping timeout", node_id);
1117                                                         node_id_to_descriptor.remove(&node_id);
1118                                                         self.message_handler.chan_handler.peer_disconnected(&node_id, false);
1119                                                 }
1120                                                 None => {
1121                                                         // This can't actually happen as we should have hit
1122                                                         // is_ready_for_encryption() previously on this same peer.
1123                                                         unreachable!();
1124                                                 },
1125                                         }
1126                                         return false;
1127                                 }
1128
1129                                 if !peer.channel_encryptor.is_ready_for_encryption() {
1130                                         // The peer needs to complete its handshake before we can exchange messages
1131                                         return true;
1132                                 }
1133
1134                                 let ping = msgs::Ping {
1135                                         ponglen: 0,
1136                                         byteslen: 64,
1137                                 };
1138                                 peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encode_msg!(&ping)));
1139
1140                                 let mut descriptor_clone = descriptor.clone();
1141                                 self.do_attempt_write_data(&mut descriptor_clone, peer);
1142
1143                                 peer.awaiting_pong = true;
1144                                 true
1145                         });
1146
1147                         for mut descriptor in descriptors_needing_disconnect.drain(..) {
1148                                 descriptor.disconnect_socket();
1149                         }
1150                 }
1151         }
1152 }
1153
1154 #[cfg(test)]
1155 mod tests {
1156         use bitcoin::secp256k1::Signature;
1157         use bitcoin::BitcoinHash;
1158         use bitcoin::network::constants::Network;
1159         use bitcoin::blockdata::constants::genesis_block;
1160         use ln::peer_handler::{PeerManager, MessageHandler, SocketDescriptor};
1161         use ln::msgs;
1162         use ln::features::ChannelFeatures;
1163         use util::events;
1164         use util::test_utils;
1165         use util::logger::Logger;
1166
1167         use bitcoin::secp256k1::Secp256k1;
1168         use bitcoin::secp256k1::key::{SecretKey, PublicKey};
1169
1170         use rand::{thread_rng, Rng};
1171
1172         use std;
1173         use std::cmp::min;
1174         use std::sync::{Arc, Mutex};
1175         use std::sync::atomic::{AtomicUsize, Ordering};
1176
1177         #[derive(Clone)]
1178         struct FileDescriptor {
1179                 fd: u16,
1180                 outbound_data: Arc<Mutex<Vec<u8>>>,
1181         }
1182         impl PartialEq for FileDescriptor {
1183                 fn eq(&self, other: &Self) -> bool {
1184                         self.fd == other.fd
1185                 }
1186         }
1187         impl Eq for FileDescriptor { }
1188         impl std::hash::Hash for FileDescriptor {
1189                 fn hash<H: std::hash::Hasher>(&self, hasher: &mut H) {
1190                         self.fd.hash(hasher)
1191                 }
1192         }
1193
1194         impl SocketDescriptor for FileDescriptor {
1195                 fn send_data(&mut self, data: &[u8], _resume_read: bool) -> usize {
1196                         self.outbound_data.lock().unwrap().extend_from_slice(data);
1197                         data.len()
1198                 }
1199
1200                 fn disconnect_socket(&mut self) {}
1201         }
1202
1203         fn create_chan_handlers(peer_count: usize) -> Vec<test_utils::TestChannelMessageHandler> {
1204                 let mut chan_handlers = Vec::new();
1205                 for _ in 0..peer_count {
1206                         let chan_handler = test_utils::TestChannelMessageHandler::new();
1207                         chan_handlers.push(chan_handler);
1208                 }
1209
1210                 chan_handlers
1211         }
1212
1213         fn create_network<'a>(peer_count: usize, chan_handlers: &'a Vec<test_utils::TestChannelMessageHandler>, routing_handlers: Option<&'a Vec<Arc<msgs::RoutingMessageHandler>>>) -> Vec<PeerManager<FileDescriptor, &'a test_utils::TestChannelMessageHandler>> {
1214                 let mut peers = Vec::new();
1215                 let mut rng = thread_rng();
1216                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
1217                 let mut ephemeral_bytes = [0; 32];
1218                 rng.fill_bytes(&mut ephemeral_bytes);
1219
1220                 for i in 0..peer_count {
1221                         let router = if let Some(routers) = routing_handlers { routers[i].clone() } else {
1222                                 Arc::new(test_utils::TestRoutingMessageHandler::new())
1223                         };
1224                         let node_id = {
1225                                 let mut key_slice = [0;32];
1226                                 rng.fill_bytes(&mut key_slice);
1227                                 SecretKey::from_slice(&key_slice).unwrap()
1228                         };
1229                         let msg_handler = MessageHandler { chan_handler: &chan_handlers[i], route_handler: router };
1230                         let peer = PeerManager::new(msg_handler, node_id, &ephemeral_bytes, Arc::clone(&logger));
1231                         peers.push(peer);
1232                 }
1233
1234                 peers
1235         }
1236
1237         fn establish_connection<'a>(peer_a: &PeerManager<FileDescriptor, &'a test_utils::TestChannelMessageHandler>, peer_b: &PeerManager<FileDescriptor, &'a test_utils::TestChannelMessageHandler>) -> (FileDescriptor, FileDescriptor) {
1238                 let secp_ctx = Secp256k1::new();
1239                 let a_id = PublicKey::from_secret_key(&secp_ctx, &peer_a.our_node_secret);
1240                 let mut fd_a = FileDescriptor { fd: 1, outbound_data: Arc::new(Mutex::new(Vec::new())) };
1241                 let mut fd_b = FileDescriptor { fd: 1, outbound_data: Arc::new(Mutex::new(Vec::new())) };
1242                 let initial_data = peer_b.new_outbound_connection(a_id, fd_b.clone()).unwrap();
1243                 peer_a.new_inbound_connection(fd_a.clone()).unwrap();
1244                 assert_eq!(peer_a.read_event(&mut fd_a, &initial_data).unwrap(), false);
1245                 assert_eq!(peer_b.read_event(&mut fd_b, &fd_a.outbound_data.lock().unwrap().split_off(0)).unwrap(), false);
1246                 assert_eq!(peer_a.read_event(&mut fd_a, &fd_b.outbound_data.lock().unwrap().split_off(0)).unwrap(), false);
1247                 (fd_a.clone(), fd_b.clone())
1248         }
1249
1250         #[test]
1251         fn test_disconnect_peer() {
1252                 // Simple test which builds a network of PeerManager, connects and brings them to NoiseState::Finished and
1253                 // push a DisconnectPeer event to remove the node flagged by id
1254                 let chan_handlers = create_chan_handlers(2);
1255                 let chan_handler = test_utils::TestChannelMessageHandler::new();
1256                 let mut peers = create_network(2, &chan_handlers, None);
1257                 establish_connection(&peers[0], &peers[1]);
1258                 assert_eq!(peers[0].peers.lock().unwrap().peers.len(), 1);
1259
1260                 let secp_ctx = Secp256k1::new();
1261                 let their_id = PublicKey::from_secret_key(&secp_ctx, &peers[1].our_node_secret);
1262
1263                 chan_handler.pending_events.lock().unwrap().push(events::MessageSendEvent::HandleError {
1264                         node_id: their_id,
1265                         action: msgs::ErrorAction::DisconnectPeer { msg: None },
1266                 });
1267                 assert_eq!(chan_handler.pending_events.lock().unwrap().len(), 1);
1268                 peers[0].message_handler.chan_handler = &chan_handler;
1269
1270                 peers[0].process_events();
1271                 assert_eq!(peers[0].peers.lock().unwrap().peers.len(), 0);
1272         }
1273
1274         #[test]
1275         fn test_timer_tick_occurred() {
1276                 // Create peers, a vector of two peer managers, perform initial set up and check that peers[0] has one Peer.
1277                 let chan_handlers = create_chan_handlers(2);
1278                 let peers = create_network(2, &chan_handlers, None);
1279                 establish_connection(&peers[0], &peers[1]);
1280                 assert_eq!(peers[0].peers.lock().unwrap().peers.len(), 1);
1281
1282                 // peers[0] awaiting_pong is set to true, but the Peer is still connected
1283                 peers[0].timer_tick_occured();
1284                 assert_eq!(peers[0].peers.lock().unwrap().peers.len(), 1);
1285
1286                 // Since timer_tick_occured() is called again when awaiting_pong is true, all Peers are disconnected
1287                 peers[0].timer_tick_occured();
1288                 assert_eq!(peers[0].peers.lock().unwrap().peers.len(), 0);
1289         }
1290
1291         pub struct TestRoutingMessageHandler {
1292                 pub chan_upds_recvd: AtomicUsize,
1293                 pub chan_anns_recvd: AtomicUsize,
1294                 pub chan_anns_sent: AtomicUsize,
1295         }
1296
1297         impl TestRoutingMessageHandler {
1298                 pub fn new() -> Self {
1299                         TestRoutingMessageHandler {
1300                                 chan_upds_recvd: AtomicUsize::new(0),
1301                                 chan_anns_recvd: AtomicUsize::new(0),
1302                                 chan_anns_sent: AtomicUsize::new(0),
1303                         }
1304                 }
1305
1306         }
1307         impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
1308                 fn handle_node_announcement(&self, _msg: &msgs::NodeAnnouncement) -> Result<bool, msgs::LightningError> {
1309                         Err(msgs::LightningError { err: "", action: msgs::ErrorAction::IgnoreError })
1310                 }
1311                 fn handle_channel_announcement(&self, _msg: &msgs::ChannelAnnouncement) -> Result<bool, msgs::LightningError> {
1312                         self.chan_anns_recvd.fetch_add(1, Ordering::AcqRel);
1313                         Err(msgs::LightningError { err: "", action: msgs::ErrorAction::IgnoreError })
1314                 }
1315                 fn handle_channel_update(&self, _msg: &msgs::ChannelUpdate) -> Result<bool, msgs::LightningError> {
1316                         self.chan_upds_recvd.fetch_add(1, Ordering::AcqRel);
1317                         Err(msgs::LightningError { err: "", action: msgs::ErrorAction::IgnoreError })
1318                 }
1319                 fn handle_htlc_fail_channel_update(&self, _update: &msgs::HTLCFailChannelUpdate) {}
1320                 fn get_next_channel_announcements(&self, starting_point: u64, batch_amount: u8) -> Vec<(msgs::ChannelAnnouncement, Option<msgs::ChannelUpdate>, Option<msgs::ChannelUpdate>)> {
1321                         let mut chan_anns = Vec::new();
1322                         const TOTAL_UPDS: u64 = 100;
1323                         let end: u64 =  min(starting_point + batch_amount as u64, TOTAL_UPDS - self.chan_anns_sent.load(Ordering::Acquire) as u64);
1324                         for i in starting_point..end {
1325                                 let chan_upd_1 = get_dummy_channel_update(i);
1326                                 let chan_upd_2 = get_dummy_channel_update(i);
1327                                 let chan_ann = get_dummy_channel_announcement(i);
1328
1329                                 chan_anns.push((chan_ann, Some(chan_upd_1), Some(chan_upd_2)));
1330                         }
1331
1332                         self.chan_anns_sent.fetch_add(chan_anns.len(), Ordering::AcqRel);
1333                         chan_anns
1334                 }
1335
1336                 fn get_next_node_announcements(&self, _starting_point: Option<&PublicKey>, _batch_amount: u8) -> Vec<msgs::NodeAnnouncement> {
1337                         Vec::new()
1338                 }
1339
1340                 fn should_request_full_sync(&self, _node_id: &PublicKey) -> bool {
1341                         true
1342                 }
1343         }
1344
1345         fn get_dummy_channel_announcement(short_chan_id: u64) -> msgs::ChannelAnnouncement {
1346                 use bitcoin::secp256k1::ffi::Signature as FFISignature;
1347                 let secp_ctx = Secp256k1::new();
1348                 let network = Network::Testnet;
1349                 let node_1_privkey = SecretKey::from_slice(&[42; 32]).unwrap();
1350                 let node_2_privkey = SecretKey::from_slice(&[41; 32]).unwrap();
1351                 let node_1_btckey = SecretKey::from_slice(&[40; 32]).unwrap();
1352                 let node_2_btckey = SecretKey::from_slice(&[39; 32]).unwrap();
1353                 let unsigned_ann = msgs::UnsignedChannelAnnouncement {
1354                         features: ChannelFeatures::supported(),
1355                         chain_hash: genesis_block(network).header.bitcoin_hash(),
1356                         short_channel_id: short_chan_id,
1357                         node_id_1: PublicKey::from_secret_key(&secp_ctx, &node_1_privkey),
1358                         node_id_2: PublicKey::from_secret_key(&secp_ctx, &node_2_privkey),
1359                         bitcoin_key_1: PublicKey::from_secret_key(&secp_ctx, &node_1_btckey),
1360                         bitcoin_key_2: PublicKey::from_secret_key(&secp_ctx, &node_2_btckey),
1361                         excess_data: Vec::new(),
1362                 };
1363
1364                 msgs::ChannelAnnouncement {
1365                         node_signature_1: Signature::from(FFISignature::new()),
1366                         node_signature_2: Signature::from(FFISignature::new()),
1367                         bitcoin_signature_1: Signature::from(FFISignature::new()),
1368                         bitcoin_signature_2: Signature::from(FFISignature::new()),
1369                         contents: unsigned_ann,
1370                 }
1371         }
1372
1373         fn get_dummy_channel_update(short_chan_id: u64) -> msgs::ChannelUpdate {
1374                 use bitcoin::secp256k1::ffi::Signature as FFISignature;
1375                 let network = Network::Testnet;
1376                 msgs::ChannelUpdate {
1377                         signature: Signature::from(FFISignature::new()),
1378                         contents: msgs::UnsignedChannelUpdate {
1379                                 chain_hash: genesis_block(network).header.bitcoin_hash(),
1380                                 short_channel_id: short_chan_id,
1381                                 timestamp: 0,
1382                                 flags: 0,
1383                                 cltv_expiry_delta: 0,
1384                                 htlc_minimum_msat: 0,
1385                                 fee_base_msat: 0,
1386                                 fee_proportional_millionths: 0,
1387                                 excess_data: vec![],
1388                         }
1389                 }
1390         }
1391
1392         #[test]
1393         fn test_do_attempt_write_data() {
1394                 // Create 2 peers with custom TestRoutingMessageHandlers and connect them.
1395                 let chan_handlers = create_chan_handlers(2);
1396                 let mut routing_handlers: Vec<Arc<msgs::RoutingMessageHandler>> = Vec::new();
1397                 let mut routing_handlers_concrete: Vec<Arc<TestRoutingMessageHandler>> = Vec::new();
1398                 for _ in 0..2 {
1399                         let routing_handler = Arc::new(TestRoutingMessageHandler::new());
1400                         routing_handlers.push(routing_handler.clone());
1401                         routing_handlers_concrete.push(routing_handler.clone());
1402                 }
1403                 let peers = create_network(2, &chan_handlers, Some(&routing_handlers));
1404
1405                 // By calling establish_connect, we trigger do_attempt_write_data between
1406                 // the peers. Previously this function would mistakenly enter an infinite loop
1407                 // when there were more channel messages available than could fit into a peer's
1408                 // buffer. This issue would now be detected by this test (because we use custom
1409                 // RoutingMessageHandlers that intentionally return more channel messages
1410                 // than can fit into a peer's buffer).
1411                 let (mut fd_a, mut fd_b) = establish_connection(&peers[0], &peers[1]);
1412
1413                 // Make each peer to read the messages that the other peer just wrote to them.
1414                 peers[1].read_event(&mut fd_b, &fd_a.outbound_data.lock().unwrap().split_off(0)).unwrap();
1415                 peers[0].read_event(&mut fd_a, &fd_b.outbound_data.lock().unwrap().split_off(0)).unwrap();
1416
1417                 // Check that each peer has received the expected number of channel updates and channel
1418                 // announcements.
1419                 assert_eq!(routing_handlers_concrete[0].clone().chan_upds_recvd.load(Ordering::Acquire), 100);
1420                 assert_eq!(routing_handlers_concrete[0].clone().chan_anns_recvd.load(Ordering::Acquire), 50);
1421                 assert_eq!(routing_handlers_concrete[1].clone().chan_upds_recvd.load(Ordering::Acquire), 100);
1422                 assert_eq!(routing_handlers_concrete[1].clone().chan_anns_recvd.load(Ordering::Acquire), 50);
1423         }
1424 }