Use correct default value when comparing to `htlc_maximum_msat`
authorMatt Corallo <git@bluematt.me>
Fri, 15 Dec 2023 22:32:24 +0000 (22:32 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 15 Dec 2023 22:32:24 +0000 (22:32 +0000)
62f866965436fff1a8e98ee655a8a6dcbb8716c1 added two
`htlc_maximum_msat.unwrap_or`s, but used a default value of 0,
spuriously causing all HTLCs to fail if we don't have an htlc
maximum value. This should be mostly harmless, but we should fix it
anyway.

lightning/src/routing/router.rs

index 86c42841027b8320dee54ffc230cae3384d6bd0b..2359c837201e1738e8d301a5d39fb8f75f4417dc 100644 (file)
@@ -102,7 +102,7 @@ impl<G: Deref<Target = NetworkGraph<L>> + Clone, L: Deref, S: Deref, SP: Sized,
                        .filter(|details| details.counterparty.features.supports_route_blinding())
                        .filter(|details| amount_msats <= details.inbound_capacity_msat)
                        .filter(|details| amount_msats >= details.inbound_htlc_minimum_msat.unwrap_or(0))
-                       .filter(|details| amount_msats <= details.inbound_htlc_maximum_msat.unwrap_or(0))
+                       .filter(|details| amount_msats <= details.inbound_htlc_maximum_msat.unwrap_or(u64::MAX))
                        .filter(|details| network_graph
                                        .node(&NodeId::from_pubkey(&details.counterparty.node_id))
                                        .map(|node_info| node_info.channels.len() >= MIN_PEER_CHANNELS)
@@ -139,7 +139,7 @@ impl<G: Deref<Target = NetworkGraph<L>> + Clone, L: Deref, S: Deref, SP: Sized,
                                                features: BlindedHopFeatures::empty(),
                                        },
                                        node_id: details.counterparty.node_id,
-                                       htlc_maximum_msat: details.inbound_htlc_maximum_msat.unwrap_or(0),
+                                       htlc_maximum_msat: details.inbound_htlc_maximum_msat.unwrap_or(u64::MAX),
                                })
                        })
                        .map(|forward_node| {