Update and clarify the reasons for HTLCDestination::FailedPayment
authorMatt Corallo <git@bluematt.me>
Mon, 10 Apr 2023 23:24:01 +0000 (23:24 +0000)
committerMatt Corallo <git@bluematt.me>
Wed, 19 Apr 2023 14:55:48 +0000 (14:55 +0000)
lightning/src/events/mod.rs

index 18d2929178f7f1b7a6b44c3c926d2e8a42c62d6f..4e7919df57b25f748a6c075573bcb86f949d7cb7 100644 (file)
@@ -232,8 +232,11 @@ pub enum HTLCDestination {
        ///
        /// Some of the reasons may include:
        /// * HTLC Timeouts
-       /// * Expected MPP amount has already been reached
-       /// * Claimable amount does not match expected amount
+       /// * Excess HTLCs for a payment that we have already fully received, over-paying for the
+       ///   payment,
+       /// * The counterparty node modified the HTLC in transit,
+       /// * A probing attack where an intermediary node is trying to detect if we are the ultimate
+       ///   recipient for a payment.
        FailedPayment {
                /// The payment hash of the payment we attempted to process.
                payment_hash: PaymentHash