PeerMan: rename drop_gossip util to be more accurate
authorValentine Wallace <vwallace@protonmail.com>
Thu, 25 Aug 2022 17:58:49 +0000 (13:58 -0400)
committerValentine Wallace <vwallace@protonmail.com>
Thu, 25 Aug 2022 18:57:43 +0000 (14:57 -0400)
It's more accurate to name it as dropping gossip broadcasts, as it won't drop
all gossip.

lightning/src/ln/peer_handler.rs

index 925d7e5946d82f4e5e5fd463c9ac7cd27f366925..08efffe9641a57e64f122063e1e262ab9a92dd2c 100644 (file)
@@ -398,7 +398,7 @@ impl Peer {
        }
 
        /// Returns whether this peer's buffer is full and we should drop gossip messages.
-       fn buffer_full_drop_gossip(&self) -> bool {
+       fn buffer_full_drop_gossip_broadcast(&self) -> bool {
                self.pending_outbound_buffer.len() > OUTBOUND_BUFFER_LIMIT_DROP_GOSSIP ||
                        self.msgs_sent_since_pong > BUFFER_DRAIN_MSGS_PER_TICK * FORWARD_INIT_SYNC_BUFFER_LIMIT_RATIO
        }
@@ -1322,7 +1322,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
                                                        !peer.should_forward_channel_announcement(msg.contents.short_channel_id) {
                                                continue
                                        }
-                                       if peer.buffer_full_drop_gossip() {
+                                       if peer.buffer_full_drop_gossip_broadcast() {
                                                log_gossip!(self.logger, "Skipping broadcast message to {:?} as its outbound buffer is full", peer.their_node_id);
                                                continue;
                                        }
@@ -1346,7 +1346,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
                                                        !peer.should_forward_node_announcement(msg.contents.node_id) {
                                                continue
                                        }
-                                       if peer.buffer_full_drop_gossip() {
+                                       if peer.buffer_full_drop_gossip_broadcast() {
                                                log_gossip!(self.logger, "Skipping broadcast message to {:?} as its outbound buffer is full", peer.their_node_id);
                                                continue;
                                        }
@@ -1369,7 +1369,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
                                                        !peer.should_forward_channel_announcement(msg.contents.short_channel_id)  {
                                                continue
                                        }
-                                       if peer.buffer_full_drop_gossip() {
+                                       if peer.buffer_full_drop_gossip_broadcast() {
                                                log_gossip!(self.logger, "Skipping broadcast message to {:?} as its outbound buffer is full", peer.their_node_id);
                                                continue;
                                        }