Matt Corallo [Mon, 10 Aug 2020 16:12:09 +0000 (12:12 -0400)]
Use check_spends!() fees
Matt Corallo [Mon, 2 Mar 2020 16:44:11 +0000 (11:44 -0500)]
Calcualte fees in check_spends!() so taht callsites can use it
Jeffrey Czyz [Sun, 9 Aug 2020 19:13:28 +0000 (12:13 -0700)]
WIP: Attempt at fixing test_bump_penalty_txn_on_revoked_htlcs
Jeffrey Czyz [Fri, 7 Aug 2020 22:13:57 +0000 (15:13 -0700)]
WIP: Remove ChainWatchedUtil
Jeffrey Czyz [Fri, 7 Aug 2020 17:58:15 +0000 (10:58 -0700)]
Move channelmonitor.rs from ln to chain module
Given the chain::Watch interface is defined in terms of ChannelMonitor
and ChannelMonitorUpdateErr, move channelmonitor.rs from the ln module
to the chain module.
Jeffrey Czyz [Mon, 3 Aug 2020 23:55:11 +0000 (16:55 -0700)]
Fix architecture diagram arrow directions
Arrows should signify "calls" or "generates" unless noted.
Jeffrey Czyz [Mon, 3 Aug 2020 23:51:10 +0000 (16:51 -0700)]
Fix architecture diagram line length
Jeffrey Czyz [Thu, 30 Jul 2020 17:27:41 +0000 (10:27 -0700)]
Replace WatchEventProvider with chain::Notify
WatchEventProvider served as a means for replacing ChainWatchInterface.
However, it requires users to explicitly fetch WatchEvents, even if not
interested in them. Replace WatchEventProvider by chain::Notify, which
is an optional member of ChainMonitor. If set, interesting transactions
and output spends are registered such that blocks containing them can be
retrieved from a chain source in an efficient manner.
This is useful when the chain source is not a full node. For Electrum,
it allows for pre-filtered blocks. For BIP157/158, it serves as a means
to match against compact filters.
Jeffrey Czyz [Wed, 29 Jul 2020 20:02:29 +0000 (13:02 -0700)]
Remove ChainListener
BlockNotifier was removed in the previous commit, thus ChainListener is
no longer needed. Instead, anything needing chain events should be
notified directly.
Jeffrey Czyz [Wed, 29 Jul 2020 01:08:46 +0000 (18:08 -0700)]
Remove BlockNotifier
BlockNotifier is a convenience for handing blocks to listeners. However,
it requires that each listener conforms to the ChainListener interface.
Additionally, there are only two listeners, ChannelManager and
ChainMonitor, the latter of which may not be used when monitoring
channels remotely. Remove BlockNotifier since it doesn't provide much
value and constrains each listener to a specific interface.
Jeffrey Czyz [Thu, 6 Aug 2020 23:54:13 +0000 (16:54 -0700)]
Remove Key parameter from ChainMonitor
ChainMonitor's template Key parameter was meant to allow supporting
both local monitoring, where Key=OutPoint, and watchtowers, where Key=
(PublicKey, u32). Use OutPoint directly since the watchtower case will
not be supported this way.
Jeffrey Czyz [Tue, 21 Jul 2020 05:12:14 +0000 (22:12 -0700)]
Rename SimpleManyChannelMonitor to ChainMonitor
ManyChannelMonitor was renamed chain::Watch in the previous commit. Use
a more concise name for an implementation that monitors the chain for
channel activity. Future work will parameterize the struct to allow for
different varieties of persistence. Thus, users usually will be able to
use ChainMonitor directly rather than implementing a chain::Watch that
wraps it.
Jeffrey Czyz [Tue, 21 Jul 2020 00:03:52 +0000 (17:03 -0700)]
Replace ManyChannelMonitor with chain::Watch
Rename ManyChannelMonitor to chain::Watch and move to chain/mod.rs,
where chain-related interfaces live. Update the documentation for
clarity and to conform to rustdoc formatting.
Jeffrey Czyz [Sat, 18 Jul 2020 06:19:15 +0000 (23:19 -0700)]
Remove ChainWatchInterface
The remaining use of ChainWatchInterface was replaced by chain::Access
in the previous commit, and thus it is no longer needed.
Jeffrey Czyz [Sat, 18 Jul 2020 05:08:34 +0000 (22:08 -0700)]
Replace ChainWatchInterface in NetGraphMsgHandler
ChainWatchInterface was intended as an interface for watching rather
than accessing the chain. Remove get_chain_utxo and add chain::Access
trait for this behavior. Wrap it with an Option in NetGraphMsgHandler in
order to simplify the error interface.
Jeffrey Czyz [Thu, 16 Jul 2020 05:58:38 +0000 (22:58 -0700)]
Remove ChainWatchInterface from channelmonitor.rs
Use of ChainWatchInterface was replaced with WatchEvent in the previous
commit. Remove it from the parameterization of SimpleManyChannelMonitor
since it is no longer needed.
Jeffrey Czyz [Thu, 9 Jul 2020 06:37:13 +0000 (23:37 -0700)]
Replace use of ChainWatchInterface with WatchEvent
SimpleManyChannelMonitor is parameterized by ChainWatchInterface to
signal what transactions and outputs to watch for on chain. The
interface has grown to cover chain access (via get_chain_utxo) and block
block filtering (via filter_block and reentered), which has added
complexity for implementations and user (see ChainWatchInterfaceUtil).
Pull the watch functionality out as a first step to eliminating
ChainWatchInterface entirely.
Jeffrey Czyz [Tue, 14 Jul 2020 17:29:11 +0000 (10:29 -0700)]
Add test utilities for {dis}connecting a block
Replace direct uses of BlockNotifier in functional tests with utility
functions. This is in preparation for signaling watch events back via a
refactoring of ManyChannelMonitor and ChainWatchInterface. Those events
will be processed by connect_block.
Jeffrey Czyz [Tue, 14 Jul 2020 17:11:50 +0000 (10:11 -0700)]
Replace BlockNotifier with Node in test utilities
Change confirm_transaction and connect_blocks to take a Node instead of
a BlockNotifier. This is in preparation for signaling watch events back
via a refactoring of ManyChannelMonitor and ChainWatchInterface.
Jeffrey Czyz [Tue, 16 Jun 2020 22:24:22 +0000 (15:24 -0700)]
Simplify BlockNotifier tests
Use a simple ChainListner implementation rather than large test objects
for testing BlockNotifier.
Remove unregister_single_listener_ref_test since it is redundant with
unregister_single_listener_test.
Remove unnecessary clone() calls.
Jeffrey Czyz [Fri, 26 Jun 2020 17:43:24 +0000 (10:43 -0700)]
Align ChannelMonitor interface with ChainListener
ChannelMonitor has block_connected and block_disconnected methods called
by <SimpleManyChannelMonitor as ChainListener>. Use similar parameters
in ChannelMonitor such that transformations are not needed and the
interface is more closely aligned with ChainListener.
Jeffrey Czyz [Fri, 26 Jun 2020 01:07:55 +0000 (18:07 -0700)]
f - Update ChainListener::block_connected
Support filtered blocks by taking a &BlockHeader and &Transaction slice
of the form &[(usize, &Transaction)] where each transaction is paired
with its position within the block.
Jeffrey Czyz [Tue, 16 Jun 2020 22:10:17 +0000 (15:10 -0700)]
Remove ChainWatchInterface from BlockNotifier
ChainListeners should be independent of each other, but in practice this
is not the case because ChainWatchInterface introduces a dependency
between them. Push ChainWatchInterface down into the ChainListener
implementations where needed. Update ChainListener's block_connected
method to take the entire block.
Matt Corallo [Mon, 3 Aug 2020 21:25:56 +0000 (14:25 -0700)]
Merge pull request #663 from TheBlueMatt/2020-08-codecov
Set codecov upload token
Matt Corallo [Mon, 3 Aug 2020 20:48:58 +0000 (16:48 -0400)]
Set codecov upload token
Docs seem to indicate this should only be required for private
repos, but we have builds failing claiming this needs to be
specified, so just set it manually.
Matt Corallo [Wed, 29 Jul 2020 19:08:13 +0000 (12:08 -0700)]
Merge pull request #658 from lightning-signer/self-delay
ChannelKeys - provide to_self_delay alongside the remote channel pubkeys
Devrandom [Thu, 23 Jul 2020 13:54:49 +0000 (06:54 -0700)]
ChannelKeys - provide to_self_delay alongside the remote channel pubkeys
In the phase 2 signer, we will construct the commitment transaction inside the signer.
In preparation, provide needed channel related data.
Matt Corallo [Mon, 27 Jul 2020 17:18:13 +0000 (10:18 -0700)]
Merge pull request #651 from naumenkogs/2020-06-routing-data-improvements
Routing improvements
Gleb Naumenko [Mon, 29 Jun 2020 18:28:15 +0000 (21:28 +0300)]
Check htlc_maximum_msat on channel update
Gleb Naumenko [Sun, 28 Jun 2020 12:18:33 +0000 (15:18 +0300)]
Store channel capacity if available
Gleb Naumenko [Sun, 28 Jun 2020 11:43:10 +0000 (14:43 +0300)]
Add htlc_maximum_msat field
Gleb Naumenko [Fri, 24 Jul 2020 07:19:45 +0000 (10:19 +0300)]
Update comment for test_msg_hole
Matt Corallo [Wed, 22 Jul 2020 20:11:45 +0000 (13:11 -0700)]
Merge pull request #655 from lightning-signer/per-commitment
ChannelKeys - separate commitment revocation from getting the per-commitment point
Devrandom [Sat, 11 Jul 2020 10:19:43 +0000 (03:19 -0700)]
ChannelKeys - separate commitment revocation from getting the per-commitment point
The commitment secret is sensitive - it can be used by an attacker to
steal funds if the node also signs the same transaction. Therefore,
only release the secret from ChannelKeys when we are revoking a
transaction.
Gleb Naumenko [Mon, 29 Jun 2020 17:48:01 +0000 (20:48 +0300)]
Improve routing announcement test
Gleb Naumenko [Thu, 25 Jun 2020 14:01:42 +0000 (17:01 +0300)]
Fix formatting
Gleb Naumenko [Tue, 16 Jun 2020 15:58:06 +0000 (18:58 +0300)]
Use constant for max msats
Gleb Naumenko [Tue, 16 Jun 2020 10:17:43 +0000 (13:17 +0300)]
Update get_route comment to reflect new parameters
Matt Corallo [Wed, 22 Jul 2020 03:04:44 +0000 (20:04 -0700)]
Merge pull request #644 from joemphilips/improve_error_message
Improve error message.
Matt Corallo [Wed, 22 Jul 2020 03:03:37 +0000 (20:03 -0700)]
Merge pull request #623 from LNP-BP/feat-msgsizelimit
Making message size limit an exportable constant
joe.miyamoto [Mon, 13 Jul 2020 04:24:40 +0000 (13:24 +0900)]
slightly refactor internal_announcement_signatures
For making debugging easy.
If the user gives a different node_secret for transport
layer (`PeerManager`) and for routing msg, internal_announcement_signatures
is the first place it causes an error.
By giving a detailed error message, user will be able to
fix the bug quickly.
joe.miyamoto [Mon, 13 Jul 2020 04:16:32 +0000 (13:16 +0900)]
Improve error message.
... for ChannelError and APIMisuseError
Before this commit, When rl returns error, we don't know
The actual parameter which caused the error.
By returning parameterised `String` instead of predefined `&'static str`,
We can give a caller improved error message.
TestLogger now has two additional methods
1. `assert_log_contains` which checks the logged messsage
has how many entry which includes the specified string as a substring.
2. `aasert_log_regex` mostly the same with `assert_log_contains`
but it is more flexible that caller specifies regex which has
to be satisfied instead of just a substring.
For regex, tests now includes `regex` as dev-dependency.
Dr. Maxim Orlovsky [Tue, 21 Jul 2020 12:14:01 +0000 (14:14 +0200)]
Moving LN_MAX_MSG_LEN const to the actual use place
Dr. Maxim Orlovsky [Tue, 21 Jul 2020 12:11:46 +0000 (14:11 +0200)]
Removing spec quotation from LN_MAX_MSG_LEN definition
Dr. Maxim Orlovsky [Tue, 21 Jul 2020 12:00:02 +0000 (14:00 +0200)]
Removing duplicated code in message decryption test cases
Dr. Maxim Orlovsky [Tue, 21 Jul 2020 11:48:37 +0000 (13:48 +0200)]
Test cases for message encryption/decryption size limits
Dr. Maxim Orlovsky [Tue, 21 Jul 2020 11:39:39 +0000 (13:39 +0200)]
Fixing panic messages for decryption procedures
Dr. Maxim Orlovsky [Sun, 17 May 2020 14:02:56 +0000 (16:02 +0200)]
Making message size limit an exportable constant
Matt Corallo [Thu, 16 Jul 2020 17:00:32 +0000 (10:00 -0700)]
Merge pull request #656 from erasmospunk/typo
Fix typo
John L. Jegutanis [Wed, 15 Jul 2020 13:43:18 +0000 (16:43 +0300)]
Fix typo
Matt Corallo [Thu, 2 Jul 2020 18:31:31 +0000 (11:31 -0700)]
Merge pull request #652 from lightning-signer/commitment-secret
ChannelKeys provides individual commitment secrets
Devrandom [Wed, 1 Jul 2020 10:31:53 +0000 (03:31 -0700)]
ChannelKeys provides individual commitment secrets
Matt Corallo [Sun, 28 Jun 2020 18:01:43 +0000 (18:01 +0000)]
Merge pull request #650 from TheBlueMatt/2020-06-fix-build
Fix silent merge conflict between
bcd65be and
940d7ac
Matt Corallo [Sun, 28 Jun 2020 17:21:45 +0000 (13:21 -0400)]
Fix unused-parentheses warnings newer rustcs have added
Matt Corallo [Sun, 28 Jun 2020 17:19:40 +0000 (13:19 -0400)]
Fix silent merge conflict between
bcd65bed7bd9a and
940d7ac8d897589
Matt Corallo [Sat, 27 Jun 2020 00:41:35 +0000 (00:41 +0000)]
Merge pull request #647 from valentinewallace/test-remote-fee-spike-buffer-violation
Test remote fee spike buffer violation
Matt Corallo [Wed, 24 Jun 2020 00:16:28 +0000 (00:16 +0000)]
Merge pull request #638 from TheBlueMatt/2020-06-c-bindings-cleanups-2
Pre-C bindings cleanups (2)
Matt Corallo [Sat, 13 Jun 2020 01:01:32 +0000 (21:01 -0400)]
Use usize for transaction-position-in-block values
We use them largely as indexes into a Vec<Transaction> so there's
little reason for them to be u32s. Instead, use them as usize
everywhere.
We also take this opportunity to add range checks before
short_channel_id calculation, as we could otherwise end up with a
bogus short_channel_id due to an output index out of range.
Matt Corallo [Thu, 11 Jun 2020 20:05:41 +0000 (16:05 -0400)]
Drop unused import in fuzz router.rs
Matt Corallo [Thu, 11 Jun 2020 19:40:28 +0000 (15:40 -0400)]
Take &NetworkGraph as input in get_route, not a NetGraphMsgHandler
This was just an oversight when route calculation was split up into
parts - it makes no sense for get_route to require that we have a
full route message handler, only a network graph (which can always
be accessed from a NetGraphMsgHandler anyway).
Matt Corallo [Sat, 13 Jun 2020 21:33:21 +0000 (17:33 -0400)]
Make ChainWatchInterface::filter_block return only idxes, not refs
Instead of making the filter_block fn in the ChainWatchInterface
trait return both a list of indexes of transaction positions within
the block and references to the transactions themselves, return
only the list of indexes and then build the reference list at the
callsite.
While this may be slightly less effecient from a memory locality
perspective, it shouldn't be materially different.
This should make it more practical to generate bindings for
filter_block as it no longer needs to reference Rust Transaction
objects that are contained in a Rust Block object (which we'd
otherwise just pass over the FFI in fully-serialized form).
Matt Corallo [Thu, 11 Jun 2020 19:33:20 +0000 (15:33 -0400)]
Avoid references to primitives and add NetworkGraph::new()
non-mut references to primitives are only excess overhead, so
there's not much reason to ever have them. As a nice bonus, it also
is one less thing to worry about when generating C bindings
Matt Corallo [Thu, 11 Jun 2020 19:32:23 +0000 (15:32 -0400)]
Avoid use std and use std::fmt and fmt:: instead in network_graph
This is more consistent with the way we use std::cmp over the
codebase and avoids `use std`, which is only actually needed to
support older rustcs, so feels a bit awkward.
Valentine Wallace [Mon, 22 Jun 2020 19:30:10 +0000 (15:30 -0400)]
Add test for remote fee spike buffer violations.
HTLCs that violate the remote's fee spike buffer should be failed.
Valentine Wallace [Mon, 22 Jun 2020 19:29:29 +0000 (15:29 -0400)]
Log fee spike buffer violations.
Matt Corallo [Thu, 11 Jun 2020 19:23:35 +0000 (15:23 -0400)]
Reduce RwLock usage in public interface of NetworkGraph
This isn't a big difference in the API, but it avoids needing to
wrap a given NetworkGraph in a RwLock before passing it, which
makes it much easier to generate C bindings for.
Matt Corallo [Sun, 31 May 2020 03:23:47 +0000 (23:23 -0400)]
Drop a useless import of std::result::Result since its always there
Matt Corallo [Sun, 31 May 2020 03:18:35 +0000 (23:18 -0400)]
Drop some unnecessary lifetime specifiers in return type definitions
In general, we don't need an explicit lifetime when doing something
like:
fn get_thing(&self) -> &Thing { &self.thing }.
This also makes it easier to reason about what's going on in the
bindings generation.
Matt Corallo [Wed, 10 Jun 2020 03:00:30 +0000 (23:00 -0400)]
ChannelMonitor::get_funding_txo returns both the txid and scriptPK
... instead of only the txid.
This is another instance of it not being possible to fully
re-implement SimpleManyChannelMonitor using only public methods. In
this case you couldn't properly register outpoints for monitoring
so that the funding transaction would be matched.
Matt Corallo [Sun, 21 Jun 2020 19:44:56 +0000 (19:44 +0000)]
Merge pull request #641 from jkczyz/2020-06-deterministic-test-logging
Make test output deterministic
Jeffrey Czyz [Wed, 17 Jun 2020 15:29:30 +0000 (08:29 -0700)]
Make test output deterministic
Tests use sources of randomness to produce seeds, preimages, secrets,
and ephemeral data. However, this makes comparing logs between different
test runs difficult. Remove uses of random number generators and the
current time in favor of fixed values in order to make the test output
deterministic.
Matt Corallo [Tue, 16 Jun 2020 19:51:24 +0000 (19:51 +0000)]
Merge pull request #639 from valentinewallace/fix-feerate-new-channel
Use our actual feerate in open_channel messages, not a new one
Valentine Wallace [Mon, 15 Jun 2020 21:28:01 +0000 (17:28 -0400)]
Switch all feerate u64's to u32's.
The protocol only allows a u32, so if we received or sent something
larger it would be an issue (though it's unlikely).
Valentine Wallace [Sat, 13 Jun 2020 20:46:25 +0000 (16:46 -0400)]
Use our actual feerate in open_channel messages, not a new one
When we were sending an open_channel messages we were asking the
feerate estimator for a new value instead of using the one we had.
If the feerate estimator gave a different value than the one it did
when we created the Channel struct, we'd start out-of-sync with our
counterparty and blow up on funding_signed. Even worse, the
ConfirmationTarget used was different, so its highly likely they
would disagree.
Also remove newly unused fee estimator parameter from get_open-channel
API.
Co-authored-by: Matt Corallo <git@bluematt.me>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
Matt Corallo [Mon, 15 Jun 2020 20:17:03 +0000 (20:17 +0000)]
Merge pull request #577 from valentinewallace/fix-onchain-fee-check-htlcs
Incl tx fee when calcing inbound+outbound HTLC limits on channels
Valentine Wallace [Wed, 6 May 2020 23:18:51 +0000 (19:18 -0400)]
Update chanmon fuzzer to include small payment actions.
This change should allow the fuzzer to catch more edge cases, such as
channel reserve checks that cut it close when sending payments.
Valentine Wallace [Wed, 6 May 2020 23:18:23 +0000 (19:18 -0400)]
Add fee spike buffer + incl commit tx fee in chan reserve calculation
When we receive an inbound HTLC from a peer on an inbound channel,
make sure the funder can still cover the additional on-chain cost
of the HTLC while maintaining their channel reserve.
When we're sending an outbound HTLC, make sure the funder can still
cover the additional on-chain cost of the HTLC while maintaining
their channel reserve.
+ implement fee spike buffer for channel initiators sending payments.
Also add an additional spec-deviating fee spike buffer on the
receiving side (but don't close the channel if this reserve is
violated, just fail the HTLC).
From lightning-rfc PR #740.
Co-authored-by: Matt Corallo <git@bluematt.me>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
Matt Corallo [Thu, 11 Jun 2020 18:59:07 +0000 (18:59 +0000)]
Merge pull request #634 from valentinewallace/improve-inbound-htlc-docs
Improve documentation for InboundHTLCState enum states.
Valentine Wallace [Sun, 31 May 2020 19:59:49 +0000 (15:59 -0400)]
Improve documentation for InboundHTLCState enum states.
Valentine Wallace [Fri, 5 Jun 2020 19:27:30 +0000 (15:27 -0400)]
Refactor: move channel checks for HTLC adds into Channel
This also includes adding a closure that creates a new pending HTLC status
as a parameter for Channel's update_add_htlc. This will later be useful
when we add the check for fee spike buffer violations, which will also result
in changing an HTLC's pending status to failing.
Co-authored-by: Jeffrey Czyz <jkczyz@gmail.com>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
Matt Corallo [Thu, 11 Jun 2020 03:58:07 +0000 (03:58 +0000)]
Merge pull request #629 from arik-so/message_handling_extraction
Extract wire message handling into a method.
Arik Sosman [Fri, 22 May 2020 20:03:49 +0000 (13:03 -0700)]
Extract wire message handling into a method.
This is a response to splitting #585 into smaller components. This extraction should allow the subsequent creation of a trait for all message handling, thereby enabling more flexibility in the state machine, particularly for bindings.
Matt Corallo [Sat, 6 Jun 2020 23:22:59 +0000 (23:22 +0000)]
Merge pull request #632 from TheBlueMatt/2020-05-drop-chankeys-privs
Drop ChannelKeys Private Key Methods
Matt Corallo [Thu, 28 May 2020 20:13:38 +0000 (16:13 -0400)]
Drop requirement that all ChannelKeys expose htlc_basepoint
Matt Corallo [Thu, 28 May 2020 20:09:47 +0000 (16:09 -0400)]
Drop requirement that ChannelKeys expose delayed_payment_basepoint
Matt Corallo [Thu, 28 May 2020 20:06:28 +0000 (16:06 -0400)]
Drop requirement that all ChannelKeys expose revocaion_basepoint
Matt Corallo [Thu, 28 May 2020 20:03:03 +0000 (16:03 -0400)]
Drop requirement that all ChannelKeys expose the payment_point
Matt Corallo [Thu, 28 May 2020 20:02:33 +0000 (16:02 -0400)]
Drop requirement that all ChannelKeys expose the funding privkey
Matt Corallo [Thu, 28 May 2020 20:00:46 +0000 (16:00 -0400)]
Expose private keys from InMemoryChannelKeys publicly
As we drop the requirement that all ChannelKeys expose the private
keys used, we should have a way to access the private keys in use
when using InMemoryChannelKeys.
Matt Corallo [Thu, 28 May 2020 19:34:42 +0000 (19:34 +0000)]
Merge pull request #620 from TheBlueMatt/2020-05-pre-bindings-cleanups
Pre-C Bindings Cleanup
Matt Corallo [Thu, 28 May 2020 19:25:06 +0000 (19:25 +0000)]
Merge pull request #610 from ariard/2020-04-cache-in-monitor
Move back to ChannelMonitor RemoteTxCache
Antoine Riard [Mon, 18 May 2020 08:19:32 +0000 (04:19 -0400)]
Add test_key_derivation_params
`to_local` output or remote output on remote commitment transaction
needs a channel keys to be spent. As per-channel keys are derived from
KeysManager seed and per-channel secrets those must be backed up by
any descriptor bookmarking for latter spend. We test that generating
a new KeysManager loaded with such backed-up seed/per-channel secrets
return the correct keys for spending a `to_local` output.
Matt Corallo [Fri, 15 May 2020 22:57:44 +0000 (18:57 -0400)]
Significantly clarify key derivation and expose methods referenced
Antoine Riard [Fri, 8 May 2020 21:19:19 +0000 (17:19 -0400)]
Document better DynamicOutputP2WSH
Antoine Riard [Wed, 6 May 2020 01:42:51 +0000 (21:42 -0400)]
Remove useless build warnings
Antoine Riard [Tue, 5 May 2020 22:48:32 +0000 (18:48 -0400)]
Make get_revokable_redeemscript
Antoine Riard [Tue, 5 May 2020 22:36:06 +0000 (18:36 -0400)]
Make derive_private_key public
Antoine Riard [Mon, 4 May 2020 06:35:54 +0000 (02:35 -0400)]
Dry-up witnessScript in sign_remote_htlc_transaction
Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.
Antoine Riard [Mon, 4 May 2020 06:20:56 +0000 (02:20 -0400)]
Dry-up witnessScript in sign_justice_transaction
Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.
Antoine Riard [Wed, 29 Apr 2020 23:43:31 +0000 (19:43 -0400)]
Imp Writer/Reader for RemoteCommitmentTransaction