Matt Corallo [Sat, 4 Nov 2023 21:01:18 +0000 (21:01 +0000)]
Pre-allocate the full `Vec` prior to serializing as a `Vec<u8>`
We end up generating a substantial amount of allocations just
doubling `Vec`s when serializing to them, and our
`serialized_length` method is generally rather effecient, so we
just rely on it and allocate correctly up front.
Matt Corallo [Sat, 4 Nov 2023 16:21:29 +0000 (16:21 +0000)]
Avoid unnecessarily overriding `serialized_length`
...as LLVM will handle it just fine for us, in most cases.
Matt Corallo [Sat, 4 Nov 2023 16:20:51 +0000 (16:20 +0000)]
Pre-allocate send buffer when forwarding gossip
When forwarding gossip, rather than relying on Vec doubling,
pre-allocate the message encoding buffer.
Matt Corallo [Sat, 4 Nov 2023 16:20:24 +0000 (16:20 +0000)]
Prefer `Writeable.encode()` over `VecWriter` use
It does the same thing and its much simpler.
Matt Corallo [Sat, 4 Nov 2023 03:53:46 +0000 (03:53 +0000)]
Reduce on-startup heap frag due to network graph map/vec doubling
When we're reading a `NetworkGraph`, we know how many
nodes/channels we are reading, there's no reason not to
pre-allocate the `IndexedMap`'s inner `HashMap` and `Vec`, which we
do here.
This seems to reduce on-startup heap fragmentation with glibc by
something like 100MiB.
Matt Corallo [Thu, 2 Nov 2023 19:04:05 +0000 (19:04 +0000)]
Merge pull request #2558 from waterson/pr-2554
Handle retrying sign_counterparty_commitment failures
Elias Rohrer [Thu, 2 Nov 2023 08:50:21 +0000 (09:50 +0100)]
Merge pull request #2641 from alexanderwiederin/2585-preflight-test-coverage
#2585 Preflight Test Coverage
Chris Waterson [Wed, 6 Sep 2023 18:38:34 +0000 (11:38 -0700)]
Add basic async signer tests
Adds a `get_signer` method to the context so that a test can get ahold of the
channel signer. Adds a `set_available` method on the `TestChannelSigner` to
allow a test to enable and disable the signer: when disabled some of the
signer's methods will return `Err` which will typically activate the error
handling case. Adds a `set_channel_signer_available` function on the test
`Node` class to make it easy to enable and disable a specific signer.
Adds a new `async_signer_tests` module:
* Check for asynchronous handling of `funding_created` and `funding_signed`.
* Check that we correctly resume processing after awaiting an asynchronous
signature for a `commitment_signed` event.
* Verify correct handling during peer disconnect.
* Verify correct handling for inbound zero-conf.
Matt Corallo [Tue, 5 Sep 2023 22:21:04 +0000 (22:21 +0000)]
Handle retrying sign_counterparty_commitment inb funding failures
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending which required the signature later,
rather than force-closing the channel (which probably won't even
work if the signer is missing).
This commit adds retrying of inbound funding_created signing
failures, regenerating the `FundingSigned` message, attempting to
re-sign, and sending it to our peers if we succeed.
Matt Corallo [Tue, 5 Sep 2023 22:10:34 +0000 (22:10 +0000)]
Handle retrying sign_counterparty_commitment outb funding failures
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending which required the signature later,
rather than force-closing the channel (which probably won't even
work if the signer is missing).
This commit adds retrying of outbound funding_created signing
failures, regenerating the `FundingCreated` message, attempting to
re-sign, and sending it to our peers if we succeed.
Matt Corallo [Tue, 5 Sep 2023 22:06:53 +0000 (22:06 +0000)]
Handle retrying sign_counterparty_commitment failures
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending which required the signature later,
rather than force-closing the channel (which probably won't even
work if the signer is missing).
This commit adds initial retrying of failures, specifically
regenerating commitment updates, attempting to re-sign the
`CommitmentSigned` message, and sending it to our peers if we
succed.
Matt Corallo [Tue, 5 Sep 2023 21:13:07 +0000 (21:13 +0000)]
Handle sign_counterparty_commitment failing during inb funding
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending which required the signature later,
rather than force-closing the channel (which probably won't even
work if the signer is missing).
Here we add initial handling of sign_counterparty_commitment
failing during inbound channel funding, setting a flag in
`ChannelContext` which indicates we should retry sending the
`funding_signed` later. We don't yet add any ability to do that
retry.
Matt Corallo [Tue, 5 Sep 2023 21:06:22 +0000 (21:06 +0000)]
Handle sign_counterparty_commitment failing during outb funding
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending which required the signature later,
rather than force-closing the channel (which probably won't even
work if the signer is missing).
Here we add initial handling of sign_counterparty_commitment
failing during outbound channel funding, setting a new flag in
`ChannelContext` which indicates we should retry sending the
`funding_created` later. We don't yet add any ability to do that
retry.
Matt Corallo [Tue, 5 Sep 2023 20:46:28 +0000 (20:46 +0000)]
Handling for sign_counterparty_commitment failing during normal op
If sign_counterparty_commitment fails (i.e. because the signer is
temporarily disconnected), this really indicates that we should
retry the message sending later, rather than force-closing the
channel (which probably won't even work if the signer is missing).
Here we add initial handling of sign_counterparty_commitment
failing during normal channel operation, setting a new flag in
`ChannelContext` which indicates we should retry sending the
commitment update later. We don't yet add any ability to do that
retry.
valentinewallace [Wed, 1 Nov 2023 18:34:29 +0000 (14:34 -0400)]
Merge pull request #2682 from jkczyz/2023-09-bolt12-test-vectors
BOLT 12 Offer test vectors
alexanderwiederin [Sun, 22 Oct 2023 12:38:41 +0000 (08:38 -0400)]
add preflight probes test coverage
Matt Corallo [Wed, 1 Nov 2023 17:42:29 +0000 (17:42 +0000)]
Merge pull request #2686 from jkczyz/2023-10-onion-message-fuzz
Re-add one-hop onion message fuzzing test
valentinewallace [Mon, 30 Oct 2023 20:21:36 +0000 (16:21 -0400)]
Merge pull request #2668 from TheBlueMatt/2023-10-fix-doc
Update docs on `MonitorEvent::HolderForceClosed`
valentinewallace [Mon, 30 Oct 2023 16:49:42 +0000 (12:49 -0400)]
Merge pull request #2693 from Evanfeenstra/next-hop-pubkey-secp-mode
next_hop_pubkey secp Verification only
Matt Corallo [Mon, 30 Oct 2023 16:00:19 +0000 (16:00 +0000)]
Merge pull request #2669 from benthecarman/trace-sync-progress
Remove channel monitor sync in progress log
Matt Corallo [Sun, 29 Oct 2023 19:38:26 +0000 (19:38 +0000)]
Merge pull request #2689 from benthecarman/no-std-offer-expire
Add `is_expired_no_std` to Offer
Matt Corallo [Sun, 29 Oct 2023 17:58:56 +0000 (17:58 +0000)]
Merge pull request #2613 from wvanlint/batch_funding_fix_up
Refactor ShutdownResult type and construction
Evan Feenstra [Sat, 28 Oct 2023 15:11:21 +0000 (08:11 -0700)]
next_hop_pubkey secp Verification only
benthecarman [Thu, 26 Oct 2023 21:55:03 +0000 (16:55 -0500)]
Add is_expired_no_std to Offer & Refund
This was available for OfferContents but not an Offer so dependent
projects could not access it.
Jeffrey Czyz [Wed, 18 Oct 2023 21:28:54 +0000 (16:28 -0500)]
Re-add one-hop onion message fuzzing test
Revert fuzz test removal in
6dc42235baaa22320ad78d3e05fab31edad99328.
The test originally checked that OnionMessenger would fail for one-hop
blinded paths. The commit added support for such paths, but changing the
checks was not sufficient since the node was not connected to the
introduction node of the reply path. This is required in order to work
with the trivial TestMessageRouter. Fix this by explicitly connecting
the nodes.
Jeffrey Czyz [Wed, 25 Oct 2023 21:37:26 +0000 (16:37 -0500)]
Wrap long onion_message fuzz strings
Some editors like vim slow to a crawl when scrolling over long strings
when syntax highlighting is turned on. Limit the length in fuzz strings
to avoid this.
Jeffrey Czyz [Tue, 26 Sep 2023 20:42:28 +0000 (15:42 -0500)]
BOLT 12 test vectors for offer parsing
One discrepancy from the spec still needs to be resolved:
https://github.com/lightning/bolts/pull/798/files#r1334851959
Jeffrey Czyz [Tue, 26 Sep 2023 20:41:45 +0000 (15:41 -0500)]
Separate and describe BOLT 12 test vectors
Jeffrey Czyz [Fri, 22 Sep 2023 20:05:49 +0000 (15:05 -0500)]
Move bech32 parsing tests to the parse module
Additional BOLT 12 tests specific to Offer were added, which will live
in the offer module. Thus, it makes sense to move the bech32 tests to
the parse module.
Matt Corallo [Tue, 24 Oct 2023 01:26:30 +0000 (01:26 +0000)]
Merge pull request #2678 from TheBlueMatt/2023-10-0.0.118
Cut 0.0.118
Matt Corallo [Fri, 20 Oct 2023 23:44:49 +0000 (23:44 +0000)]
Bump crate versions to lightning 0.0.118, invoice 0.26
Matt Corallo [Fri, 20 Oct 2023 20:46:30 +0000 (20:46 +0000)]
0.0.118 release notes
Matt Corallo [Mon, 23 Oct 2023 22:58:15 +0000 (22:58 +0000)]
Merge pull request #2679 from TheBlueMatt/2023-10-116-bindings-1
Small bindings tweaks for 0.0.118
Matt Corallo [Mon, 23 Oct 2023 19:50:12 +0000 (19:50 +0000)]
Fix CI on rustc 1.50 and below
rustc doesn't allow `--features` with `-p`, so we simply skip the
steps that rely on it.
Matt Corallo [Mon, 23 Oct 2023 18:55:17 +0000 (18:55 +0000)]
Use a tuple, not a struct, for `PendingOnionMessage` in bindings
Bindings aren't currently able to handle a struct with a generic
which is actually exposed - we map all structs concretely to a
single type, whereas having fluctuating types on a struct requires
mapping the inner field to a trait first.
Since this isn't super practical, we make `PendingOnionMessage` a
tuple in bindings, rather than a struct.
Matt Corallo [Mon, 23 Oct 2023 19:16:29 +0000 (19:16 +0000)]
Merge pull request #2676 from TheBlueMatt/2023-10-various-followups
Various Followups to 2039 and 2674
Matt Corallo [Mon, 23 Oct 2023 16:49:49 +0000 (16:49 +0000)]
Add relevant no-export tags to functions returning builders
Because we can't map move semantics in most languages, we also
can't map our current builders. Thus, we have to mark them
no-export.
Matt Corallo [Mon, 23 Oct 2023 16:50:05 +0000 (16:50 +0000)]
Drop an unnecessary no-export on ParsedOnionMessageContents
Matt Corallo [Sat, 21 Oct 2023 02:42:48 +0000 (02:42 +0000)]
Do not compile the `Simple*` type aliases in `c_bindings` at all
Because the bindings changes now require further changes to our
type definitions, avoiding building the `Simple*` type aliases
entirely makes the patchset there simpler.
Matt Corallo [Sat, 21 Oct 2023 01:08:38 +0000 (01:08 +0000)]
Fix (and test) the `c_bindings` build flag
Rather than only building with the `c_bindings` flag in certain
crates, we go ahead and test all crates with the flag in CI here.
Matt Corallo [Fri, 20 Oct 2023 18:19:57 +0000 (18:19 +0000)]
Remove some additional excess words in `ConfirmationTarget` docs
Matt Corallo [Fri, 20 Oct 2023 18:11:56 +0000 (18:11 +0000)]
Remove a redundant sentence in `ConfirmationTarget` docs
... and correct direction which causes force-closure in another
sentence.
Matt Corallo [Fri, 20 Oct 2023 18:09:39 +0000 (18:09 +0000)]
Drop unused `use` import.
Matt Corallo [Fri, 20 Oct 2023 17:38:19 +0000 (17:38 +0000)]
Avoid a redundant allocation in `InvoiceError` handling in one case
... by passing an owned `String`, rather than taking an `&str` and
`to_owned()`ing it.
Matt Corallo [Fri, 20 Oct 2023 17:34:12 +0000 (17:34 +0000)]
Use `Default::default()` for scoring params in tests
In
26c1639ab69d6780c97a118f09e42cb42304088a we switched to using
`Default::default()` to initialize `()` for scoring parameters in
tests. A number of `()`s slipped back in recently, which we replace
here.
Matt Corallo [Fri, 20 Oct 2023 22:55:08 +0000 (22:55 +0000)]
Merge pull request #2667 from wpaulino/random-htlc-holder-sigs-non-anchors
Use sign_holder_htlc_transaction to sign non-anchors holder HTLCs
Matt Corallo [Fri, 20 Oct 2023 22:54:08 +0000 (22:54 +0000)]
Merge pull request #2674 from wpaulino/consider-anchor-outputs-value-balances
Consider anchor outputs value throughout balance checks and computations
Wilmer Paulino [Mon, 16 Oct 2023 19:21:52 +0000 (12:21 -0700)]
Move HTLCDescriptor to sign module
Now that `HTLCDescriptor` is no longer specific to anchors, it doesn't
make sense for it to live in the `bump_transaction` module anymore.
Wilmer Paulino [Fri, 13 Oct 2023 21:09:37 +0000 (14:09 -0700)]
Don't sign holder HTLCs along with holder commitments
`sign_holder_commitment_and_htlcs` never really made sense. Unlike
`sign_counterparty_commitment`, the signatures for holder HTLC
transactions may be required much later than the commitment
transaction's. While it was nice for us to only reach the signer once to
obtain all holder signatures, it's not really ideal anymore as we want
our signatures to be random and not reused.
We no longer return all holder HTLC signatures and instead defer to
obtaining them via `EcdsaChannelSigner::sign_holder_htlc_transaction`.
Wilmer Paulino [Fri, 13 Oct 2023 20:58:59 +0000 (13:58 -0700)]
Remove caching of holder HTLC signatures
Since we want our holder HTLC signatures to be randomly generated and
not reused, our existing caches are useless now, so we opt to remove
them.
Wilmer Paulino [Fri, 13 Oct 2023 20:52:23 +0000 (13:52 -0700)]
Use sign_holder_htlc_transaction to sign non-anchors holder HTLCs
We want to ensure we use fresh random signatures to prevent certain
classes of transaction replacement attacks at the bitcoin P2P layer.
This was already covered for commitment transactions and zero fee holder
HTLC transactions, but was missing for holder HTLC transactions on
non-anchors channels.
We can easily do this by reusing the existing
`EcdsaChannelSigner::sign_holder_htlc_transaction` method and
circumventing the existing `holder_htlc_sigs/prev_holder_htlc_sigs`
caches, which will be removed in a later commit anyway.
Matt Corallo [Fri, 20 Oct 2023 17:31:42 +0000 (17:31 +0000)]
Apply a default max fee rather than none when paying for BOLT12
If the user declines to specify a `max_total_routing_fee_msat` in
the new BOLT12 payment methods, rather than defaulting to no limit
on the fee we pay at all, we should default to our "usual default",
ie the one calculated in
`RouteParameters::from_payment_params_and_value`.
We do this here, as well as documenting the behavior on the payment
methods.
Wilmer Paulino [Thu, 19 Oct 2023 16:29:21 +0000 (09:29 -0700)]
Only account for fee spike buffer multiple on non-anchor channels
Anchor outputs channels are no longer susceptible to fee spikes as they
now mostly target the dynamic minimum mempool fee and can contribute the
remainder of fees when closing.
Wilmer Paulino [Thu, 19 Oct 2023 16:27:57 +0000 (09:27 -0700)]
Consider anchor outputs value on channel open
We should make sure the funding amount of a channel can cover all its
associated costs, including the value of anchor outputs, to make sure
that it is actually usable once "opened".
Wilmer Paulino [Thu, 19 Oct 2023 16:27:30 +0000 (09:27 -0700)]
Consider anchor outputs value on inbound HTLCs
This could lead us to accept HTLCs that would put the sender below
their reserve, which must never happen.
Wilmer Paulino [Thu, 19 Oct 2023 16:25:23 +0000 (09:25 -0700)]
Consider anchor outputs value in get_available_balances
This could lead us to sending/forwarding HTLCs that would put us below
our reserve, forcing our counterparty to close the channel on us due to
an invalid update.
Wilmer Paulino [Thu, 19 Oct 2023 16:22:50 +0000 (09:22 -0700)]
Run chanmon_consistency_test with anchor outputs channels
Wilmer Paulino [Fri, 13 Oct 2023 20:47:45 +0000 (13:47 -0700)]
Provide missing derivation parameters to OnchainTxHandler
`OnchainTxHandler` will need to construct `HTLCDescriptor`s for holder
HTLCs, but it did not have access to all of the derivation parameters
that need to be provided.
Wilmer Paulino [Fri, 13 Oct 2023 20:49:50 +0000 (13:49 -0700)]
Support signing non-anchors HTLCs with HTLCDescriptor
We plan to use `EcdsaChannelSigner::sign_holder_htlc_transaction` to
also sign holder HTLC transactions on non-anchor outputs channels.
`HTLCDescriptor` was only used in an anchor outputs context, so a few
things needed changing, mostly to handle the different scripts and
feerate.
Matt Corallo [Fri, 20 Oct 2023 17:37:17 +0000 (17:37 +0000)]
Merge pull request #2660 from benthecarman/flexible-fee-rate
More flexible fee rate estimates
benthecarman [Thu, 12 Oct 2023 20:43:30 +0000 (15:43 -0500)]
More flexible fee rate estimates
Matt Corallo [Fri, 20 Oct 2023 16:40:17 +0000 (16:40 +0000)]
Merge pull request #2039 from jkczyz/2023-02-offer-flow
BOLT 12 Offers message flow
Matt Corallo [Tue, 17 Oct 2023 16:23:20 +0000 (16:23 +0000)]
Update docs on `MonitorEvent::HolderForceClosed`
In
a96e2fe144383ea6fd670153fb895ee07a3245ef we renamed
`MonitorEvent::CommitmentTxConfirmed` to `HolderForceClosed` to
better document what actually happened. However, we failed to
update the documentation on the type, which we do here.
Pointed out by @yellowred.
Matt Corallo [Fri, 20 Oct 2023 15:57:43 +0000 (15:57 +0000)]
Merge pull request #2670 from yanganto/socket-addr-to-string
Impl `Display` for SocketAddress
Jeffrey Czyz [Fri, 20 Oct 2023 01:32:00 +0000 (20:32 -0500)]
Fix PaymentConstraints::max_cltv_expiry docs
Jeffrey Czyz [Thu, 19 Oct 2023 23:02:58 +0000 (18:02 -0500)]
Fix build warnings
Jeffrey Czyz [Thu, 19 Oct 2023 21:36:02 +0000 (16:36 -0500)]
Expand request_refund_payment docs for limitations
Jeffrey Czyz [Thu, 19 Oct 2023 20:50:19 +0000 (15:50 -0500)]
Onion message routing to immediate peers.
DefaultMessageRouter always fails. Update it so that it can route to a
directly connected peer. This is needed for an Offers minimum viable
product.
Jeffrey Czyz [Thu, 19 Oct 2023 14:45:30 +0000 (09:45 -0500)]
Add privacy section to pay_for_offer docs
Jeffrey Czyz [Thu, 19 Oct 2023 14:37:47 +0000 (09:37 -0500)]
Organize create_refund and pay_for_offer docs
Jeffrey Czyz [Thu, 19 Oct 2023 14:16:08 +0000 (09:16 -0500)]
Document InvoiceRequestFailed in ChannelManager
Jeffrey Czyz [Thu, 12 Oct 2023 21:10:51 +0000 (16:10 -0500)]
Revert "Config-guard Event::InvoiceRequestFailed"
This reverts commit
c7219e46831751c52026932294c33fce24121d84.
Jeffrey Czyz [Tue, 6 Jun 2023 17:00:54 +0000 (12:00 -0500)]
Use ChannelManager as OffersMessageHandler
Jeffrey Czyz [Fri, 1 Sep 2023 19:04:27 +0000 (14:04 -0500)]
OffersMessageHandler impl for ChannelManager
Define the BOLT 12 message flow in ChannelManager's
OffersMessageHandler implementation.
- An invoice_request message results in responding with an invoice
message if it can be verified that the request is for a valid offer.
- An invoice is paid if it can be verified to have originated from a
sent invoice_request or a refund.
- An invoice_error is sent in some failure cases.
- Initial messages enqueued for sending are released to OnionMessenger
Jeffrey Czyz [Thu, 19 Oct 2023 22:49:13 +0000 (17:49 -0500)]
Check offer expiry when building invoice in no-std
Building an invoice will fail if the underlying offer or refund has
already expired. The check was skipped in no-std since there is no
system clock. However, the invoice creation time can be used instead.
This prevents responding to an invoice request if the offer has already
expired.
Jeffrey Czyz [Fri, 1 Sep 2023 14:40:34 +0000 (09:40 -0500)]
Grammar fix in docs
Jeffrey Czyz [Fri, 1 Sep 2023 14:38:44 +0000 (09:38 -0500)]
BOLT12 invoice_feature methods for ChannelManager
Jeffrey Czyz [Fri, 1 Sep 2023 14:22:43 +0000 (09:22 -0500)]
Qualify BOLT11 ChannelManager invoice_features
Jeffrey Czyz [Fri, 15 Sep 2023 18:40:41 +0000 (13:40 -0500)]
Utility for creating and sending Bolt12Invoices
Add a utility to ChannelManager for creating a Bolt12Invoice for a
Refund such that the ChannelManager can recognize the PaymentHash and
reconstruct the PaymentPreimage from the PaymentSecret, the latter of
which is contained in a BlindedPath within the invoice.
Jeffrey Czyz [Thu, 14 Sep 2023 18:32:51 +0000 (13:32 -0500)]
Utility for paying for an Offer
Add a utility to ChannelManager for sending an InvoiceRequest for an
Offer such that derived keys are used for the payer id. This allows for
stateless verification of any Invoice messages before it is paid.
Also tracks future payments using the given PaymentId such that the
corresponding Invoice is paid only once.
Jeffrey Czyz [Thu, 19 Oct 2023 19:38:16 +0000 (14:38 -0500)]
Absolute expiry or timer tick payment expiration
Pending outbound payments use an absolute expiry to determine when they
are considered stale and should be fail. In `no-std`, this may result in
long timeouts as the highest seen block time is used. Instead, allow for
expiration based on timer ticks. This will be use in an upcoming commit
for invoice request expiration.
Jeffrey Czyz [Thu, 14 Sep 2023 19:50:56 +0000 (14:50 -0500)]
Store OffersMessages for later sending
Upcoming commits will add utilities for sending an InvoiceRequest for an
Offer and an Invoice for a Refund. These messages need to be enqueued so
that they can be released in ChannelManager's implementation of
OffersMessageHandler to OnionMessenger for sending.
These messages do not need to be serialized as they must be resent upon
restart.
Jeffrey Czyz [Thu, 19 Oct 2023 13:45:25 +0000 (08:45 -0500)]
Expand docs on failing expired outbound payments
Antonio Yang [Wed, 18 Oct 2023 10:36:03 +0000 (18:36 +0800)]
impl Display for SocketAddress
Elias Rohrer [Fri, 20 Oct 2023 07:52:29 +0000 (09:52 +0200)]
Merge pull request #2636 from slanesuke/impl-ToSocketAddrs-for-Hostname
Impl ToSocketAddrs for SocketAddress
Matt Corallo [Thu, 19 Oct 2023 21:49:02 +0000 (21:49 +0000)]
Merge pull request #2666 from tnull/2023-10-observable-update
Matt Corallo [Thu, 19 Oct 2023 17:53:46 +0000 (17:53 +0000)]
Merge pull request #2661 from TheBlueMatt/2023-10-dup-claim-chan-hang
Immediately unblock channels on duplicate claims
Matt Corallo [Wed, 11 Oct 2023 14:01:28 +0000 (14:01 +0000)]
Immediately unblock channels on duplicate claims
When `MonitorUpdateCompletionAction`s were added, we didn't
consider the case of a duplicate claim during normal HTLC
processing (as the handling only had an `if let` rather than a
`match`, which made the branch easy to miss). This can lead to a
channel freezing indefinitely if an HTLC is claimed (without a
`commitment_signed`), the peer disconnects, and then the HTLC is
claimed again, leading to a never-completing
`MonitorUpdateCompletionAction`.
The fix is simple - if we get back an
`UpdateFulfillCommitFetch::DuplicateClaim` when claiming from the
inbound edge, immediately unlock the outbound edge channel with a
new `MonitorUpdateCompletionAction::FreeOtherChannelImmediately`.
Here we implement this fix by actually generating the new variant
when a claim is duplicative.
Matt Corallo [Wed, 11 Oct 2023 13:56:00 +0000 (13:56 +0000)]
Add an immediately-freeing `MonitorUpdateCompletionAction`.
When `MonitorUpdateCompletionAction`s were added, we didn't
consider the case of a duplicate claim during normal HTLC
processing (as the handling only had an `if let` rather than a
`match`, which made the branch easy to miss). This can lead to a
channel freezing indefinitely if an HTLC is claimed (without a
`commitment_signed`), the peer disconnects, and then the HTLC is
claimed again, leading to a never-completing
`MonitorUpdateCompletionAction`.
The fix is simple - if we get back an
`UpdateFulfillCommitFetch::DuplicateClaim` when claiming from the
inbound edge, immediately unlock the outbound edge channel with a
new `MonitorUpdateCompletionAction::FreeOtherChannelImmediately`.
Here we add the new variant, which we start generating in the next
commit.
Matt Corallo [Thu, 12 Oct 2023 22:26:07 +0000 (22:26 +0000)]
Indicate to `claim_funds_internal` that we're replaying on startup
While we'd previously avoided this, this is sadly now required in
the next commit.
Matt Corallo [Wed, 11 Oct 2023 01:39:26 +0000 (01:39 +0000)]
Log when we prepare to block a channel's next `revoke_and_ack`
This may help in debugging blocking actions in the future.
Elias Rohrer [Thu, 19 Oct 2023 15:00:50 +0000 (17:00 +0200)]
Don't apply PathFailure::ChannelUpdateMessage
If we receive a channel update from an intermediary via a failure onion
we shouldn't apply them in a persisted and network-observable way to our
network graph, as this might introduce a privacy leak. Here, we
therefore avoid applying such updates to our network graph.
Elias Rohrer [Fri, 13 Oct 2023 09:30:15 +0000 (11:30 +0200)]
Allow to verify channel updates without applying them
We introduce a new `NetworkGraph::verify_channel_update` method that
allows to check whether an update would be applied by `update_channel`.
Willem Van Lint [Thu, 28 Sep 2023 01:36:21 +0000 (18:36 -0700)]
Construct ShutdownResult as a struct in Channel
This refactors ShutdownResult as follows:
- Makes ShutdownResult a struct instead of a tuple to represent
individual results that need to be handled. This recently also
includes funding batch closure propagations.
- Makes Channel solely responsible for constructing ShutdownResult as
it should own all channel-specific logic.
Willem Van Lint [Wed, 27 Sep 2023 23:12:35 +0000 (16:12 -0700)]
Refactor check_closed_event for multiple events
The check_closed_event function verified closure events against multiple
counterparty nodes, but only a single closure reason and channel
capacity. This commit introduces a check_closed_events function to
verify events against descriptions of each expected event, and refactors
check_closed_event in function of check_closed_events.
Willem Van Lint [Wed, 27 Sep 2023 22:44:52 +0000 (15:44 -0700)]
Clean up typos and unused variables/imports
Matt Corallo [Thu, 19 Oct 2023 02:41:48 +0000 (02:41 +0000)]
Merge pull request #2578 from jkczyz/2023-09-offer-utilities
BOLT 12 Offers utilities
slanesuke [Sat, 30 Sep 2023 23:05:00 +0000 (17:05 -0600)]
Impl ToSocketAddrs for SocketAddress
Jeffrey Czyz [Wed, 18 Oct 2023 23:24:07 +0000 (18:24 -0500)]
Clean up peel_onion name, parameters, and docs
For consistency with other functions and doc cleanliness.
Jeffrey Czyz [Fri, 3 Mar 2023 15:38:45 +0000 (09:38 -0600)]
Include a one-hop blinded path in Offer and Refund
While this doesn't add much privacy over not including any blinded
paths, it allows us to exercise code for receiving on blinded paths.