Matt Corallo [Sun, 30 Jul 2023 17:10:38 +0000 (17:10 +0000)]
Drop unicode in documentation
Javadocs refuse unicode and as our rustdocs get copied over to Java
bindings (and thus get run through javadocs) we can't have unicode
in our rustdocs.
Matt Corallo [Fri, 28 Jul 2023 06:20:43 +0000 (06:20 +0000)]
Drop `claimable` from `Balance::claimable_amount_satoshis` fields
In Java/TypeScript, we map enums as a base class and each variant
as a class which extends the base. In Java/TypeScript, functions
and fields share the same namespace, which means we cannot have
functions on an enum which have the same name as any fields in any
enum variants.
`Balance`'s `claimable_amount_satoshis` method aliases with fields
in each variant, and thus ultimately doesn't compile in TypeScript.
Because `Balance::claimable_amount_satoshis` has the same name as
the fields, it's also a bit confusing, as it doesn't return the
field for each variant, but sometimes returns zero if we're not
sure we can claim the balance.
Instead, we rename the fields in each enum variant to simply
`amount_satoshis`, to avoid implying that we can definitely claim
the balance.
Matt Corallo [Fri, 24 Sep 2021 18:44:32 +0000 (18:44 +0000)]
Make the custom message traits cloneable as they're deep in nested structs
Matt Corallo [Mon, 1 Feb 2021 01:12:50 +0000 (20:12 -0500)]
Make ChannelMonitor clonable again
In general, we'd been moving away from ChannelMonitor being clonable,
XXXXXXXXXXXXXXXXXXXx
Matt Corallo [Tue, 25 Jul 2023 02:23:03 +0000 (02:23 +0000)]
Merge pull request #2443 from TheBlueMatt/2023-07-0.0.116-bindings
Matt Corallo [Wed, 19 Jul 2023 20:09:23 +0000 (20:09 +0000)]
Mark several types no-export which should be exported eventually
Matt Corallo [Wed, 19 Jul 2023 19:20:50 +0000 (19:20 +0000)]
Drop separate `Locked` type on `LockableScore`
While this is useful in Rust, it is simply confusing in bindings,
as we just use the same type for the locked score - a trait impl.
Matt Corallo [Tue, 18 Jul 2023 19:25:52 +0000 (19:25 +0000)]
Hard-code scorer parameters to `ProbabilisticScoringFeeParameters`
The scorer currently relies on an associated type for the fee
parameters. This isn't supportable at all in bindings, and for
lack of a better option we simply hard-code the parameter for all
scorers to `ProbabilisticScoringFeeParameters`.
Matt Corallo [Tue, 11 Jul 2023 02:00:22 +0000 (02:00 +0000)]
Drop `ScoreParams` in bindings builds
Sadly, we can't realistically expose associated types in bindings -
not only does C not have any concept of generics or associated
types (duh), but many of the downstream languages we support don't
either.
Instead, we hard-code the scoring parameters type to
`ProbabilisticScoringFeeParams` for all scorers.
Matt Corallo [Tue, 25 Apr 2023 17:40:40 +0000 (17:40 +0000)]
Add some no-exporting of more offers code
These really could be handled in the bindings, but for lack of
immediate users there's not a strong reason to, so instead we just
disable them for now.
Matt Corallo [Sun, 5 Mar 2023 20:38:42 +0000 (20:38 +0000)]
Avoid enums containing references with lifetimes
Having struct fields with references to other structs is tough in
our bindings logic, but even worse if the fields are in an enum.
Its simplest to just take the clone penalty here.
Matt Corallo [Tue, 28 Feb 2023 21:45:14 +0000 (21:45 +0000)]
Export `outbound_payment` structs in their respective modules
Re-exports in Rust make `use` statements a little shorter, but for
otherwise don't materially change a crate's API. Sadly, the C
bindings generator currently can't figure out re-exports, but it
also exports everything into one global namespace, so it doesn't
matter much anyway.
Matt Corallo [Sat, 24 Dec 2022 04:16:48 +0000 (04:16 +0000)]
Use an explicit `Sign` type on the `ChannelMonitor` read tuple
The bindings currently get confused by the implicit `Sign` type, so
we temporarily remove it on the `impl` here.
Matt Corallo [Mon, 19 Dec 2022 21:38:45 +0000 (21:38 +0000)]
Export Onion Message structs in their respective modules
Re-exports in Rust make `use` statements a little shorter, but for
otherwise don't materially change a crate's API. Sadly, the C
bindings generator currently can't figure out re-exports, but it
also exports everything into one global namespace, so it doesn't
matter much anyway.
Matt Corallo [Sun, 26 Jun 2022 18:14:30 +0000 (18:14 +0000)]
Tag `KVStore` `(C-not exported)` as `Writeable` isn't mapped
Currently `Writeable` is mapped manually, making it impossible to
automatically map a trait method that is parameterized by
`Writeable` (as is true for the `write` method on `KVStore`).
Ultimately we'll want to move to automatically mapping `Writeable`
like any other trait (only manually mapping the std `Write` and
`Read` traits), so this is only a candidate for the bindings branch,
not upstream. That may take a few releases, however.
Jeffrey Czyz [Tue, 29 Mar 2022 15:20:39 +0000 (10:20 -0500)]
Restrict ChannelInfo::as_directed_from visibility
Bindings can't handle references in return types, so reduce the
visibility to pub(crate).
Matt Corallo [Tue, 1 Mar 2022 03:47:28 +0000 (03:47 +0000)]
Simplify type aliasing somewhat around times
.. as the current C bindings generator isn't capable of handling
type aliases in generics in type alias definition currently.
Matt Corallo [Tue, 1 Mar 2022 03:46:52 +0000 (03:46 +0000)]
Make `as_directed_to` non-public
...as the bindings generation does not currently have the ability
to map a reference to a `NodeId` inside a tuple.
Matt Corallo [Fri, 21 Jul 2023 23:15:05 +0000 (23:15 +0000)]
Merge pull request #2427 from TheBlueMatt/2023-07-cut-116
Release 0.0.116
Matt Corallo [Mon, 17 Jul 2023 22:34:44 +0000 (22:34 +0000)]
Bump crate versions to 0.0.116 release
Matt Corallo [Mon, 17 Jul 2023 22:32:45 +0000 (22:32 +0000)]
Add a warning on anchors and update 116 changelog for release
Matt Corallo [Fri, 21 Jul 2023 20:26:16 +0000 (20:26 +0000)]
Add `lightning-background-processor` `no-std` feature
While this is generally uneccessary as users set the `no-std` or
`std` features on the `lightning` crate directly, having this
allows `lightning-background-processor` to be built by itself
without extra dep lines. Specifically, the bindings are moving to
using the `-Z avoid-dev-deps` option, which now causes
`lightning-background-processor` to fail to build directly.
Jeffrey Czyz [Fri, 21 Jul 2023 20:25:57 +0000 (15:25 -0500)]
Merge pull request #2436 from tnull/2023-07-improve-router-logging
Improve router logging and update documentation
Matt Corallo [Fri, 21 Jul 2023 19:37:28 +0000 (19:37 +0000)]
Merge pull request #2439 from tnull/2023-05-fix-0conf-sigs-racing-confirms
Avoid panic when 0conf channel's ann. sigs race on-chain confirmation
Elias Rohrer [Tue, 18 Jul 2023 11:23:20 +0000 (13:23 +0200)]
Improve logging for ignored candiate hops
Previously, we barely gave any hints why we excluded certain hops during
pathfinding. Here, we introduce more verbose logging by a) accounting
how much candidates we ignored for which reasons and b) logging any
first/last/blinded hops we end up ignoring.
Fixes #1646.
Elias Rohrer [Tue, 18 Jul 2023 10:41:07 +0000 (12:41 +0200)]
Update outdated `router.rs` docs
As `RouteParameters` are not included anymore in
`Event::PaymentPathFailed` since 0.0.115, and we don't give value/payee
as immediate arguments to `find_route` anymore.
Matt Corallo [Fri, 21 Jul 2023 16:39:19 +0000 (16:39 +0000)]
Merge pull request #2434 from TheBlueMatt/2023-07-116-bindings-part-2
0.0.116 Bindings Changes
Elias Rohrer [Sat, 17 Jun 2023 11:17:20 +0000 (13:17 +0200)]
Avoid `unwrap`ing in `get_announcement_sigs`
While this is currently not reachable, it's still cleaner to
avoid the `unwrap` and return `None` if `short_channel_id` hasn't been
set yet.
Elias Rohrer [Sat, 17 Jun 2023 11:16:52 +0000 (13:16 +0200)]
Avoid panic when 0conf channel's ann. sigs race on-chain confirmation
A channel's `short_channel_id` is currently only set when the funding
transaction is confirmed via `transactions_confirmed`, which might be
well after the channel initally becomes usable, e.g., in the 0conf case.
Previously we would panic due to a reachable `unwrap` when receiving a
counterparty's `announcement_signatures` message for a 0conf channel
pending confirmation on-chain.
Here we fix this bug by avoiding unsafe `unwrap`s and just erroring out
and ignoring the announcement_signatures message if the `short_channel_id`
hasn't been set yet.
Matt Corallo [Wed, 19 Jul 2023 23:59:29 +0000 (23:59 +0000)]
Add relevant derives for `BigSize` as its a simple integer
Matt Corallo [Wed, 19 Jul 2023 23:58:42 +0000 (23:58 +0000)]
Add relevant trait derives for `bump_transaction` structs
Notably including `Hash`/`Eq`/`Ord` for structs which may be used
in maps.
Matt Corallo [Wed, 19 Jul 2023 20:22:41 +0000 (20:22 +0000)]
Make `OffersMessage` and offers errors `Clone`able
Matt Corallo [Wed, 19 Jul 2023 20:11:35 +0000 (20:11 +0000)]
Make `requires_unknown_bits_from` param type bindings compatible
While bindings should probably be able to figure out that this is
the same type as `Self`, for now we simply swap the type to make
the bindings generator have an easier go of it.
Matt Corallo [Wed, 19 Jul 2023 20:04:24 +0000 (20:04 +0000)]
Mark the `Duration` serialization implementation no-bindings-export
The bindings are being updated to consider all traits even if the
trait itself is no-export, which causes issues generating code
around the `Duration` impl here.
Matt Corallo [Wed, 19 Jul 2023 20:02:10 +0000 (20:02 +0000)]
No-export un-exportable types in BOLT12 module
We missed one method that now cannot be bindings exported - the
`payment_paths` method, as it returns a slice of objects, which
cannot be supported in bindings.
Matt Corallo [Wed, 19 Jul 2023 20:01:32 +0000 (20:01 +0000)]
No-export `APeerManager` in bindings
`APeerManager` will simply be mapped as `PeerManager` in bindings,
as structs are all concretized into a single form.
Matt Corallo [Wed, 19 Jul 2023 20:01:01 +0000 (20:01 +0000)]
Move `ClaimId` to `[u8; 32]` in bindings.
This matches what we've done for other `[u8; 32]` newtypes.
Matt Corallo [Wed, 19 Jul 2023 19:37:21 +0000 (19:37 +0000)]
Tweak PSBT signing for bindings compatibility
In bindings we can't practically pass a mutable PSBT, and instead
need to pass an owned transaction and have the sign method return a
signed copy. We do this here for all build modes as its not a
material API change for Rust users.
Matt Corallo [Wed, 19 Jul 2023 18:39:31 +0000 (18:39 +0000)]
Add a c_bindings test to `check-compiles.sh` as it should build
Matt Corallo [Thu, 20 Jul 2023 21:42:44 +0000 (21:42 +0000)]
Merge pull request #2430 from TheBlueMatt/2023-07-116-bindings-part-1
Assorted 0.0.116 Bindings updates
Matt Corallo [Thu, 20 Jul 2023 21:40:04 +0000 (21:40 +0000)]
Merge pull request #2382 from dunxen/2077-followups
Address outstanding 2077 feedback
Matt Corallo [Tue, 18 Jul 2023 19:52:26 +0000 (19:52 +0000)]
Drop `c_bindings` implementation of scoring on `Mutex`/`RefCell`
This code was always effectively dead - we have a special
`MultiThreadedLockableScore` type which wraps a `Mutex` for
bindings users, so there's no need to implement any
bindings-specific scoring logic for them.
Matt Corallo [Tue, 18 Jul 2023 19:41:07 +0000 (19:41 +0000)]
Pass `InFlightHltcs` to the scorer by ownership rather than ref
Given we build `InFlightHtlcs` per route-fetch call, there's no
reason to pass them out by reference rather than simply giving the
user the full object. This also allows them to tweak the in-flight
set before fetching a route.
Matt Corallo [Tue, 18 Jul 2023 19:34:00 +0000 (19:34 +0000)]
Pass must-spend inputs to users by ownership
We already hold them in a vec, so there's no cost to passing them
by ownership vs making it a slice. Further, this helps bindings as
we can't represent slices to non-pointers in a sensible way.
Matt Corallo [Tue, 18 Jul 2023 19:13:19 +0000 (19:13 +0000)]
Tweak transaction bumping `sign_tx` types for bindings
In bindings we can't practically pass a mutable transaction, and
instead need to pass an owned transaction and have the sign method
return a signed copy. We do this here for all build modes as the
API is roughly equivalent also to Rust users.
Matt Corallo [Wed, 19 Jul 2023 17:43:30 +0000 (17:43 +0000)]
Merge pull request #2423 from wpaulino/2403-fixups
PR #2403 fixups
Duncan Dean [Fri, 14 Jul 2023 14:59:29 +0000 (16:59 +0200)]
Close and remove unfunded inbound/outbound channels that are older than an hour
We introduce a `UnfundedChannelContext` which contains a counter for the
current age of an unfunded channel in timer ticks. This age is incremented
for every `ChannelManager::timer_tick_ocurred` and the unfunded channel
is removed if it exceeds `UNFUNDED_CHANNEL_AGE_LIMIT_TICKS`.
The value will not be persisted as unfunded channels themselves are not
persisted.
Duncan Dean [Tue, 27 Jun 2023 18:07:33 +0000 (14:07 -0400)]
Remove redundant 'outbound' wording from methods
Duncan Dean [Tue, 27 Jun 2023 16:19:35 +0000 (12:19 -0400)]
Force close pending channels in `internal_shutdown`
Duncan Dean [Mon, 26 Jun 2023 17:53:14 +0000 (13:53 -0400)]
Consider all channel maps in `update_partial_channel_config`
Duncan Dean [Mon, 26 Jun 2023 14:48:45 +0000 (10:48 -0400)]
Fallback `close_channel_internal` to force close unfunded channels
Duncan Dean [Mon, 26 Jun 2023 14:06:50 +0000 (10:06 -0400)]
Add missing unfunded channel maps checks in `ChannelManager`
One of a series of follow-up commits to address some issues found
in PR 2077, where we split channels up into different maps and structs
depending on phase in their life.
Duncan Dean [Mon, 17 Jul 2023 13:52:44 +0000 (15:52 +0200)]
Refer to channels busy with funding tx negotiation as "unfunded"
We had some inconsistencies so far in referring to channels such as
`OutboundV1Channel` and `InboundV1Channel` as pending and unfunded.
From here we refer to these kinds of channels only as "unfunded".
This is a slight conflation with the term "unfunded" in the contexts
of denial of service mitigation. There, "unfunded" actually refers to
non-0conf, inbound channels that have not had their funding transaction
confirmed. This might warrant changing that usage to "unconfirmed inbound".
Wilmer Paulino [Wed, 19 Jul 2023 16:11:43 +0000 (09:11 -0700)]
Merge pull request #2426 from TheBlueMatt/2023-07-proc-macro2-msrv
Matt Corallo [Tue, 18 Jul 2023 19:04:56 +0000 (19:04 +0000)]
Tweak generics on `derive_channel_signer` to be bindings-compatible
The C bindings generation currently has issues looking through a
generic associated type. While this should be fixed in the bindings
generator, its easy to fix here for now and we can revisit it
later.
Matt Corallo [Tue, 18 Jul 2023 01:54:16 +0000 (01:54 +0000)]
Only try to build `lightning-transaction-sync` if we meet its MSRV
This should fix CI
Elias Rohrer [Mon, 17 Jul 2023 19:08:26 +0000 (21:08 +0200)]
Pin `proc-macro2` in CI to fix MSRV breakage
The proc-macro2 crate switched to Rust edition 2021 starting with
v1.0.66, i.e., has MSRV of 1.56.
Here, we pin it in CI to fix the breakage.
Matt Corallo [Mon, 17 Jul 2023 21:53:07 +0000 (21:53 +0000)]
Test MSRV builds (without dev-dependencies) in CI
Matt Corallo [Mon, 17 Jul 2023 21:01:02 +0000 (21:01 +0000)]
Drop `tokio/macros` dependency in `lightning-net-tokio`, fix MSRV
The `tokio` `macros` feature depends on `proc-macro2`, which
recently broke its MSRV in a patch version. Such crates aren't
reasonable for us to have as dependencies, so instead we replace
the one trivial use we have of `tokio::select!()` with our own
manual future.
Wilmer Paulino [Mon, 17 Jul 2023 21:47:10 +0000 (14:47 -0700)]
Add warning regarding remote fee estimators
Matt Corallo [Mon, 17 Jul 2023 22:18:19 +0000 (22:18 +0000)]
Merge pull request #2414 from TheBlueMatt/2023-07-cut-116-rc
Add 0.0.116 CHANGELOG entries and prep for 0.0.116rc1
Matt Corallo [Thu, 13 Jul 2023 22:28:29 +0000 (22:28 +0000)]
Update version numbers to rc1, from alpha1
Matt Corallo [Thu, 13 Jul 2023 22:27:22 +0000 (22:27 +0000)]
Add 0.0.116rc1 CHANGELOG entries (to be renamed 116 later)
Matt Corallo [Mon, 17 Jul 2023 19:45:51 +0000 (19:45 +0000)]
Merge pull request #2415 from wpaulino/update-fee-anchors
Add min mempool estimate for feerate updates on anchor channels
Wilmer Paulino [Mon, 17 Jul 2023 17:56:16 +0000 (10:56 -0700)]
Clarify log for commitment transaction already meeting required feerate
Wilmer Paulino [Mon, 17 Jul 2023 17:45:39 +0000 (10:45 -0700)]
Drop use of RefCell in DebugIter
The `RefCell` was necessary in a previous iteration of the code in which
the iterator was not `Clone` so we needed interior mutability in order
to consume the iterator. Now that it is `Clone`, we can drop it, as
we're no longer mutating the original iterator.
Matt Corallo [Mon, 17 Jul 2023 17:18:20 +0000 (17:18 +0000)]
Merge pull request #2403 from wpaulino/bump-transaction-event-handler-tests
Integrate BumpTransactionEventHandler into existing anchor tests
valentinewallace [Sat, 15 Jul 2023 01:38:31 +0000 (21:38 -0400)]
Merge pull request #2416 from jkczyz/2023-07-invoice-rename
Qualify BOLT 11/12 invoice and related types
Wilmer Paulino [Thu, 13 Jul 2023 23:04:10 +0000 (16:04 -0700)]
Use min mempool feerate for outbound updates on anchor channels
As done with inbound feerate updates, we can afford to commit less in
fees, as long as we still may the minimum mempool feerate. This enables
users to spend a bit more of their balance, as less funds are being
committed to transaction fees.
Wilmer Paulino [Thu, 13 Jul 2023 23:03:32 +0000 (16:03 -0700)]
Relax constraints for inbound feerate updates on anchor channels
Channels supporting anchors outputs no longer require their feerate
updates to target a prompt confirmation since commitment transactions
can be bumped when broadcasting. Commitment transactions must now at
least meet the minimum mempool feerate, until package relay is deployed,
such that they can propagate across node mempools in the network by
themselves.
The existing higher bound no longer applies to channels supporting
anchor outputs since their HTLC transactions don't have any fees
committed, which directly impact the available balance users can send.
Wilmer Paulino [Thu, 13 Jul 2023 23:02:17 +0000 (16:02 -0700)]
Add new ConfirmationTarget variant for min mempool feerates
Now that we support channels with anchor outputs, we add a new
ConfirmationTarget variant that, for now, will only apply to such
channels. This new variant should target estimating the minimum feerate
required to be accepted into most node mempools across the network.
Wilmer Paulino [Tue, 11 Jul 2023 22:18:08 +0000 (15:18 -0700)]
Integrate BumpTransactionEventHandler into existing anchor tests
Wilmer Paulino [Tue, 11 Jul 2023 22:12:19 +0000 (15:12 -0700)]
Add BumpTransactionEventHandler instance to node test harness
Wilmer Paulino [Tue, 11 Jul 2023 23:43:10 +0000 (16:43 -0700)]
Improve logging in BumpTransactionEventHandler paths
Wilmer Paulino [Fri, 14 Jul 2023 21:44:00 +0000 (14:44 -0700)]
Add log_iter utility macro
This is a useful primitive to have that formats the contents of the
iterator as a comma-separated list.
Wilmer Paulino [Tue, 11 Jul 2023 22:17:34 +0000 (15:17 -0700)]
Add debug assertions for weight estimates of bump transactions
This ensures our estimates are correct by never underestimating and
only allowing overestimations by a margin of 1%.
Wilmer Paulino [Tue, 11 Jul 2023 22:30:51 +0000 (15:30 -0700)]
Consider existing commitment transaction feerate when bumping
With anchors, we've yet to change the frequency or aggressiveness of
feerate updates, so it's likely that commitment transactions have a
good enough feerate to confirm on its own. In any case, when producing a
child anchor transaction, we should already take into account the fees
paid by the commitment transaction itself, allowing the user to save
some satoshis. Unfortunately, in its current form, this will still
result in overpaying by a small margin at the expense of making the coin
selection API more complex.
Wilmer Paulino [Tue, 11 Jul 2023 22:16:16 +0000 (15:16 -0700)]
Avoid yielding ChannelClose bump events with sufficient feerate
There's no need to yield such an event when the commitment transaction
already meets the target feerate on its own, so we can simply broadcast
it without an anchor child transaction. This may be a common occurrence
until we are less aggressive about feerate updates.
Wilmer Paulino [Tue, 11 Jul 2023 22:14:01 +0000 (15:14 -0700)]
Move feerate helpers to chain module
We plan to use these outside of the `bump_transaction` module in the
next commit, and they really should belong in the same module as
`FeeEstimator`.
Jeffrey Czyz [Fri, 14 Jul 2023 20:59:33 +0000 (15:59 -0500)]
Qualify the BOLT 11 invoice description type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 20:53:07 +0000 (15:53 -0500)]
Qualify the BOLT 11 invoice signature type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 19:41:58 +0000 (14:41 -0500)]
Qualify the BOLT 11 invoice features type
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Fri, 14 Jul 2023 01:56:30 +0000 (20:56 -0500)]
Qualify the BOLT 11 semantic error type
A previous commit qualified the BOLT 12 semantic error type. Qualify the
BOLT 11 semantic error type for consistency.
Jeffrey Czyz [Fri, 14 Jul 2023 01:49:02 +0000 (20:49 -0500)]
Qualify the BOLT 11 parse error type
A previous commit qualified the BOLT 12 parse error type. Qualify the
BOLT 11 parse error type for consistency.
Jeffrey Czyz [Fri, 14 Jul 2023 01:34:27 +0000 (20:34 -0500)]
Qualify the BOLT 11 raw invoice types
A previous commit qualified the BOLT 11 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Thu, 13 Jul 2023 22:22:26 +0000 (17:22 -0500)]
Qualify the BOLT 11 invoice type
A previous commit qualified the BOLT 12 invoice type. Qualify the BOLT
11 invoice type for consistency.
Jeffrey Czyz [Thu, 13 Jul 2023 21:28:55 +0000 (16:28 -0500)]
Qualify the BOLT 12 semantic error
To avoid a naming conflict in bindings with BOLT 11 semantic error,
qualify the BOLT 12 semantic error type.
Jeffrey Czyz [Thu, 13 Jul 2023 21:09:43 +0000 (16:09 -0500)]
Qualify the BOLT 12 parse error
To avoid a naming conflict in bindings with BOLT 11 parse error, qualify
the BOLT 12 parse error type.
Jeffrey Czyz [Thu, 13 Jul 2023 18:47:09 +0000 (13:47 -0500)]
Qualify the BOLT 12 unsigned invoice type
A previous commit qualified the BOLT 12 invoice type, so any related
types should be similarly qualified, if public.
Jeffrey Czyz [Thu, 13 Jul 2023 18:32:40 +0000 (13:32 -0500)]
Qualify the BOLT 12 invoice type
To avoid a naming conflict in bindings with BOLT 11 invoices, qualify
the BOLT 12 invoice type.
Jeffrey Czyz [Fri, 14 Jul 2023 20:04:30 +0000 (15:04 -0500)]
Fix grammar in docs
Jeffrey Czyz [Fri, 14 Jul 2023 20:02:29 +0000 (15:02 -0500)]
Use rustc stable for check_commits
Otherwise, the compiler will panic when using 1.57 for upcoming commits.
Matt Corallo [Wed, 12 Jul 2023 22:37:40 +0000 (22:37 +0000)]
Merge pull request #2391 from TheBlueMatt/2023-07-all-compl-actions
Handle pre-startup and closed-channel monitor update completion actions
Matt Corallo [Wed, 5 Jul 2023 17:06:19 +0000 (17:06 +0000)]
Add comment describing when a completion action can be discarded
In an older PR a reviewer had asked why the discarding of a channel
being blocked on another monitor update is okay if the blocked
channel has since closed. At the time, this was not actually okay -
the monitor updates in the channel weren't moved to the
`ChannelManager` on close so the whole pipeline was busted, but
with the changes in
4041f0899f86eaf6a0a4576a91918fa54026ac46 the
handling of channel closes with pending monitor updates is now
correct, and so is the existing code block.
Matt Corallo [Wed, 5 Jul 2023 02:15:42 +0000 (02:15 +0000)]
Run monitor update completion actions for pre-startup completion
If a `ChannelMonitorUpdate` completes being persisted, but the
`ChannelManager` isn't informed thereof (or isn't persisted) before
shutdown, on startup we may still have it listed as in-flight. When
we compare the available `ChannelMonitor` with the in-flight set,
we'll notice it completed and remove it, however this may leave
some post-update actions dangling which need to complete.
Here we handle this with a new `BackgroundEvent` indicating we need
to handle any post-update action(s) for a given channel.
Elias Rohrer [Wed, 12 Jul 2023 19:17:56 +0000 (21:17 +0200)]
Merge pull request #2393 from wpaulino/bump-transaction-event-handler-fixups
Bump transaction event handler fixups
Matt Corallo [Wed, 12 Jul 2023 16:12:11 +0000 (16:12 +0000)]
Merge pull request #2406 from tnull/2023-07-pin-serde
Pin `serde_json` in CI to fix MSRV builds
Elias Rohrer [Wed, 12 Jul 2023 09:28:42 +0000 (11:28 +0200)]
Pin `serde_json` in CI to fix MSRV
Unfortunately `serde_json` switched to use Rust edition 2021 with
version 1.0.101, i.e., has an MSRV of 1.56 now.
Wilmer Paulino [Wed, 5 Jul 2023 16:45:20 +0000 (09:45 -0700)]
Expose previous UTXO for anchor and HTLC inputs
This may be required by some wallets that rely on PSBTs internally to
create/sign transactions.
Wilmer Paulino [Wed, 5 Jul 2023 16:47:05 +0000 (09:47 -0700)]
Add transaction-related helpers to AnchorDescriptor
This provides a similar interface as `HTLCDescriptor` for users which
choose to implement their own bump transaction event handler.